Repository navigation
test: characterize pointer gestures in LGraphCanvas - #17110
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 2128 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T08:15:47.975Z",
"gitSha": "f7338eb0ce4267c0ea85c6266694fbba46462331",
"branch": "drjkl/fe-2040-gesture-harness",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1997.6550000000088,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9040000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.77600000000007,
"heapDeltaBytes": 9977804,
"heapUsedBytes": 72233832,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.055,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.265000000085,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.504000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.49199999999996,
"heapDeltaBytes": 7624988,
"heapUsedBytes": 70029108,
"domNodes": -228,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.306999999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.2770000000269,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.378999999999998,
"layouts": 12,
"layoutDurationMs": 4.357,
"taskDurationMs": 822.7739999999999,
"heapDeltaBytes": -3109464,
"heapUsedBytes": 59213888,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 165.23900000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.4109999999919,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.015,
"layouts": 12,
"layoutDurationMs": 4.653,
"taskDurationMs": 826.515,
"heapDeltaBytes": 4187784,
"heapUsedBytes": 66524416,
"domNodes": -228,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 166.597,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.4280000000126,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.219000000000001,
"layouts": 6,
"layoutDurationMs": 1.3810000000000002,
"taskDurationMs": 321.913,
"heapDeltaBytes": 2214492,
"heapUsedBytes": 64570224,
"domNodes": 53,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.167999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.0379999999313,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.756,
"layouts": 6,
"layoutDurationMs": 1.209,
"taskDurationMs": 332.43100000000004,
"heapDeltaBytes": 2214664,
"heapUsedBytes": 64194496,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.197000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 657.4919999999906,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.49,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.832,
"heapDeltaBytes": 18527904,
"heapUsedBytes": 80853964,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 170.392,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 667.3660000000154,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.952000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.15100000000007,
"heapDeltaBytes": 18411592,
"heapUsedBytes": 81090232,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 166.66899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1223.7409999999613,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 909.595,
"heapDeltaBytes": -14161484,
"heapUsedBytes": 72221284,
"domNodes": -259,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 73.81400000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 568,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1223.6429999999245,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 905.1129999999998,
"heapDeltaBytes": -13036912,
"heapUsedBytes": 73830556,
"domNodes": -259,
"jsHeapTotalBytes": 18481152,
"scriptDurationMs": 71.833,
"eventListeners": -207,
"totalBlockingTimeMs": 558,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.7650000000149,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.53300000000013,
"heapDeltaBytes": 14910808,
"heapUsedBytes": 90475452,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 177.229,
"eventListeners": 0,
"totalBlockingTimeMs": 242,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.7069999999667,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.2400000000002,
"heapDeltaBytes": 14386852,
"heapUsedBytes": 90777456,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.56700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11028.925000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9990.243,
"heapDeltaBytes": 12784360,
"heapUsedBytes": 95240732,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8248.643999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 1481,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11098.148000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10127.77,
"heapDeltaBytes": 3344532,
"heapUsedBytes": 85945136,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8422.538999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1310,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11472.983999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10521.464999999998,
"heapDeltaBytes": -9738812,
"heapUsedBytes": 73360696,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8826.207,
"eventListeners": 0,
"totalBlockingTimeMs": 1697,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10386.604000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9398.535,
"heapDeltaBytes": 16252232,
"heapUsedBytes": 80597312,
"domNodes": -228,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 7745.465,
"eventListeners": -164,
"totalBlockingTimeMs": 1218,
"frameDurationMs": 18.89333333333331,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2056.7459999999755,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.720000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 618.9689999999999,
"heapDeltaBytes": -6533012,
"heapUsedBytes": 74795048,
"domNodes": -228,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 36.672,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2056.5110000000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.5920000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.7520000000001,
"heapDeltaBytes": -124508,
"heapUsedBytes": 80965056,
"domNodes": -228,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 34.58800000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2510.785999999996,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.235999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1719.817,
"heapDeltaBytes": -15719424,
"heapUsedBytes": 66779532,
"domNodes": -228,
"jsHeapTotalBytes": 1339392,
"scriptDurationMs": 887.5880000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2550.0039999999444,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.391,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1673.553,
"heapDeltaBytes": 20301360,
"heapUsedBytes": 84452480,
"domNodes": -228,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 866.896,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3684.804999999983,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.737,
"layouts": 60,
"layoutDurationMs": 13.766,
"taskDurationMs": 1741.736,
"heapDeltaBytes": -11615468,
"heapUsedBytes": 69784088,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 800.12,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3611.1799999999903,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.956000000000001,
"layouts": 60,
"layoutDurationMs": 13.804,
"taskDurationMs": 1686.0349999999999,
"heapDeltaBytes": 8547100,
"heapUsedBytes": 74397888,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 790.934,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3192.7729999999883,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.577999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2041.0110000000002,
"heapDeltaBytes": -4464244,
"heapUsedBytes": 81068300,
"domNodes": -228,
"jsHeapTotalBytes": 8835072,
"scriptDurationMs": 1026.519,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3153.24899999996,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.140999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1926.857,
"heapDeltaBytes": 1326652,
"heapUsedBytes": 67370412,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 998.6179999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2046.2009999999964,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.344,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.056,
"heapDeltaBytes": -13745080,
"heapUsedBytes": 74966984,
"domNodes": -228,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 38.366,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2001.2779999999566,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.182,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.742,
"heapDeltaBytes": 20068704,
"heapUsedBytes": 84687824,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.27400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.1799999999989,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.960000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.455,
"heapDeltaBytes": 13982616,
"heapUsedBytes": 76646080,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 145.524,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.2849999999644,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.331000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.12899999999996,
"heapDeltaBytes": 13871524,
"heapUsedBytes": 77313708,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 149.132,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.7769999999996,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.867,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.57599999999996,
"heapDeltaBytes": 16019744,
"heapUsedBytes": 78646672,
"domNodes": -244,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.879,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.3339999999816,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.486000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.739,
"heapDeltaBytes": -4907116,
"heapUsedBytes": 58820472,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.5299999999999985,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.6179999999822,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.619,
"layouts": 16,
"layoutDurationMs": 5.694,
"taskDurationMs": 778.81,
"heapDeltaBytes": 5391692,
"heapUsedBytes": 69060668,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 111.837,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.759000000081,
"styleRecalcs": 59,
"styleRecalcDurationMs": 16.494,
"layouts": 16,
"layoutDurationMs": 5.7780000000000005,
"taskDurationMs": 781.211,
"heapDeltaBytes": -3883176,
"heapUsedBytes": 58980880,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 114.391,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 932.547999999997,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.887000000000004,
"layouts": 5,
"layoutDurationMs": 13.577000000000002,
"taskDurationMs": 698.612,
"heapDeltaBytes": 19491828,
"heapUsedBytes": 97718916,
"domNodes": 13667,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 26.232,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8662.712,
"styleRecalcs": 248,
"styleRecalcDurationMs": 31.536999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5800.254,
"heapDeltaBytes": -2096100,
"heapUsedBytes": 84672040,
"domNodes": -228,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2837.035,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8479.165999999965,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.392000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5691.37,
"heapDeltaBytes": -978204,
"heapUsedBytes": 80278452,
"domNodes": -228,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 2774.3269999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17087.906999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16596.267,
"heapDeltaBytes": -66381440,
"heapUsedBytes": 173173236,
"domNodes": -8049,
"jsHeapTotalBytes": -14536704,
"scriptDurationMs": 264.62600000000003,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17444.97200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17006.124999999996,
"heapDeltaBytes": -61765796,
"heapUsedBytes": 178712392,
"domNodes": -8049,
"jsHeapTotalBytes": -18812928,
"scriptDurationMs": 278.09000000000003,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20355.110999999964,
"styleRecalcs": 165,
"styleRecalcDurationMs": 16.575000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20080.923,
"heapDeltaBytes": -37373644,
"heapUsedBytes": 180631596,
"domNodes": -8053,
"jsHeapTotalBytes": -17309696,
"scriptDurationMs": 885.196,
"eventListeners": -14923,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21219.875,
"styleRecalcs": 153,
"styleRecalcDurationMs": 18.547000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21035.139,
"heapDeltaBytes": -26009096,
"heapUsedBytes": 191822264,
"domNodes": -8049,
"jsHeapTotalBytes": -17641472,
"scriptDurationMs": 946.732,
"eventListeners": -14923,
"totalBlockingTimeMs": 142,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6128.624999999943,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.01000000000002,
"layouts": 20,
"layoutDurationMs": 23.666999999999994,
"taskDurationMs": 6013.087999999999,
"heapDeltaBytes": -63003244,
"heapUsedBytes": 176447508,
"domNodes": -8049,
"jsHeapTotalBytes": 12427264,
"scriptDurationMs": 108.965,
"eventListeners": -14922,
"totalBlockingTimeMs": 406,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6292.599000000109,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.48700000000002,
"layouts": 20,
"layoutDurationMs": 24.595999999999993,
"taskDurationMs": 6201.631,
"heapDeltaBytes": -43536532,
"heapUsedBytes": 196195144,
"domNodes": -8049,
"jsHeapTotalBytes": 10854400,
"scriptDurationMs": 116.71599999999998,
"eventListeners": -14923,
"totalBlockingTimeMs": 451,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8605.372000000101,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8367.990000000002,
"heapDeltaBytes": 25998604,
"heapUsedBytes": 201143832,
"domNodes": 0,
"jsHeapTotalBytes": -19136512,
"scriptDurationMs": 130.245,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8515.57600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8345.320999999998,
"heapDeltaBytes": 9274604,
"heapUsedBytes": 182831332,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 130.23499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 445.25499999997464,
"styleRecalcs": 16,
"styleRecalcDurationMs": 16.254,
"layouts": 3,
"layoutDurationMs": 1.617,
"taskDurationMs": 110.40599999999998,
"heapDeltaBytes": 4912036,
"heapUsedBytes": 70401176,
"domNodes": 104,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.872,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 114.40999999990709,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.634,
"layouts": 2,
"layoutDurationMs": 1.2949999999999997,
"taskDurationMs": 77.844,
"heapDeltaBytes": 2970772,
"heapUsedBytes": 65016276,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.615000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 772970ffae44d06fdcdb2a6cd02c3101908b2df5
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## drjkl/fe-2040-selection-batch #17110 +/- ##
=================================================================
- Coverage 84.89% 84.89% -0.01%
=================================================================
Files 2304 2304
Lines 132425 132369 -56
Branches 33848 33827 -21
=================================================================
- Hits 112425 112371 -54
+ Misses 19702 19700 -2
Partials 298 298
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
This harness is the best asset in the FE-2040 stack. It builds a real LGraphCanvas rather than a mock, getBoundingClientRect is mocked to 800x600 rather than left as zeros so the coordinate assertions actually measure something, and six tests assert a genuine callback sequence with toEqual rather than set membership. That last part is what makes the ADR's same-relative-order clause checkable at all.
I also checked the two edited files for weakened assertions, since a characterization PR that quietly relaxes an existing test is the worst possible outcome here, and there are none. is_selected === true to truthiness is provably behavior-preserving (LGraphNode.ts:824 types it boolean), and LGraphCanvas.selection.test.ts is a pure extraction into __fixtures__/canvasHarness.ts. The pointerEvent helper's new button/timeStamp defaults reproduce the old behavior exactly.
The comments below are about coverage holes, not defects. The reason they matter is that #17113, #17116 and #17122 are all justified by "the characterization tests cover it", and for several of the specific behaviors those PRs change, they do not.
One note not tied to a line: this suite forces vueNodesMode = false in beforeEach while every test in #17109 runs with @vue-nodes forcing it on. So each renderer has a baseline at exactly one layer, and the divergences the ADR is built on (6px vs 3px, two modifier policies, setPointerCapture on one path only) are each observed on one side only. A unifying refactor cannot be checked against both.
|
|
||
| function recordCallbacks(canvas: LGraphCanvas, node: LGraphNode) { | ||
| const log: string[] = [] | ||
| const record = (name: string) => () => { |
There was a problem hiding this comment.
issue: record discards arguments, so the ADR's "same arguments" promise has no coverage at all.
const record = (name: string) => () => { log.push(name) } takes no parameters. Every entity callback and every spy routes through it, and grep -n "toHaveBeenCalledWith\|expect.objectContaining" over this file returns nothing.
The order half of the clause is genuinely covered. The argument half is not, and #17122 changes precisely which object a press resolves to. If it resolves to the wrong node, bringToFront and processContextMenu are invoked on the wrong node and the log is byte-identical, so every toEqual([...]) still passes.
The sharpest case is node.onMouseDown, which production calls as onMouseDown(e, [x - node.pos[0], y - node.pos[1]], canvas). That node-local position is what widget hit-testing consumes. A regression passing canvas coordinates instead is invisible here and breaks widget interaction across the custom-node ecosystem. Having record push [name, ...args] for the two or three callbacks whose arguments matter would close this cheaply.
There was a problem hiding this comment.
Fixed in the updated commit. The harness now records callback arguments separately and asserts the target event, local coordinates, canvas, and selected node IDs where identity matters.
| } | ||
| } | ||
|
|
||
| function recordCallbacks(canvas: LGraphCanvas, node: LGraphNode) { |
There was a problem hiding this comment.
issue: CanvasPointer's own callback surface is recorded nowhere, which is exactly where the refactor changes behavior.
recordCallbacks wires 15 callbacks and spies, and none of them are pointer.onClick, onDoubleClick, onDragStart, onDrag, onDragEnd or finally. Grepping all six across this file returns zero hits.
That is the gap that matters most. #17113 inverts onDragStart and onDrag relative to main (old move() ran onDrag then _setDragStarted; the reducer emits ['startDrag','moveDrag']), and it stops firing onDrag for sub-threshold moves entirely. Neither is detectable here. The ADR also commits to CanvasPointer keeping its current callback surface, and this is the suite that would have to prove it.
Wiring the six into the same log would have caught both changes at the moment they were introduced.
There was a problem hiding this comment.
Fixed. Added direct CanvasPointer lifecycle tests for click, double-click fallback, drag start/move/end, final cleanup, synthetic pointer-up, and writable dragStarted compatibility.
|
|
||
| vi.mock('@/renderer/core/layout/store/layoutStore', () => ({ | ||
| layoutStore: { | ||
| querySlotAtPoint: vi.fn(), |
There was a problem hiding this comment.
issue: mocking these three to bare vi.fn() makes slot, reroute and link targets unreachable by construction.
They return undefined unconditionally, so those hit tests can never succeed. Combined with fixture nodes that carry no widgets and no slots, and a group probed only at its title, that leaves 4 of the ADR's 12 PointerTarget kinds covered here (one only partially): canvas, node, nodeTitle and groupTitle. Widget, slot, group body, reroute, link, linkCenter, resizeHandle and subgraphIO have none.
The ADR's migration step 4 is "replace pointer.onClick writers one target kind at a time", justified by having a characterization baseline per kind. For eight kinds there is no baseline, so each of those steps lands unverified. A regression where a press on a slot starts a node drag instead of a link drag, or where a press on a resize handle selects the node instead of resizing it, produces a fully green run.
Returning a real value from these mocks for at least the slot and reroute cases would unblock the two kinds most likely to break.
There was a problem hiding this comment.
Expanded the characterization coverage with real output-slot and reroute target cases, including click and drag behavior. The downstream target resolver also adds overlap and press-latch coverage.
| onSelected: record('node.onSelected'), | ||
| onDeselected: record('node.onDeselected'), | ||
| onMouseDown: record('node.onMouseDown'), | ||
| onMouseUp: record('node.onMouseUp'), |
There was a problem hiding this comment.
issue: node.onMouseUp is wired here but cannot fire, and the exact-sequence assertions silently encode its absence as correct.
Production fires it only off node_over (LGraphCanvas.ts:3962), and node_over is assigned only in the hover path via processMouseMove. The Gesture helper never sends a hover move before pressing: click() is press-then-release and drag() moves only after the press. So node_over is always undefined.
That is why onMouseUp never appears in the toEqual([...]) arrays at :178 and :209. Those arrays read as authoritative, so they now pin "no onMouseUp" as expected behavior. onMouseUp is named in the ADR's compatibility list, so any change to it across #17113/#17116/#17122 ships with zero coverage.
onDeselected and canvas.onNodeDeselected have the same shape, wired and never asserted, though for those it is an oversight rather than a structural impossibility. A hover move before the press in the Gesture helper would fix the onMouseUp case.
There was a problem hiding this comment.
Fixed by adding a hover-before-press case. It currently remains an expected failure because the adapter supplies pointerdown instead of pointerup; the test now makes that compatibility defect explicit rather than silently omitting the callback.
| expect(log).not.toContain('canvas.onNodeMoved') | ||
| }) | ||
|
|
||
| it.fails('slow movement within the drift threshold stays a click', () => { |
There was a problem hiding this comment.
suggestion: it.fails is the right marker here, but as a characterization this test is empty.
it.fails passes iff something throws. The first assertion throws today, so line 247 is unreachable. The test never records what the buggy behavior actually is: not the drifted position, not that canvas.onNodeMoved does fire.
So if #17113 replaces the bug with a different wrong behavior, a wildly wrong position, selection not applied, a throw inside processMouseMove, this still passes. It goes green only when the assertion stops throwing, which is a weaker signal than it looks.
Keeping it.fails on the should-be-a-click assertion and adding a separate passing test that pins today's actual outcome would give the flip something to be measured against. Credit for the mechanism though: #17113 flipping this to it() is exactly how a characterized bug should be retired, and it is the clearest thing in that PR.
There was a problem hiding this comment.
Fixed. The expected-failure assertion now checks the desired click behavior, and a separate passing characterization records the current 1 px move plus onNodeMoved callback.
| expect(log).not.toContain('canvas.onNodeMoved') | ||
| }) | ||
|
|
||
| it('release far from the press without a move event is a drag', () => { |
There was a problem hiding this comment.
suggestion: this one pins a known defect as expected behavior with nothing marking it as such.
It asserts canvas.onNodeMoved fires while the position is unchanged at [20, 40]. That is _completeClick's teleport branch, where _setDragStarted() and onDragEnd run on a release beyond drift with no intervening move, so consumers are told a node moved when it did not.
Unlike :241 this carries neither it.fails nor a comment, and its name reads as endorsement. onNodeMoved is on the ADR's compatibility list and extensions use it to sync positions, so if a later PR correctly stops emitting it here, the fixing PR is forced to edit a characterization test. That is the failure mode these tests exist to prevent.
A one-line comment saying this pins current behavior rather than desired behavior is enough.
There was a problem hiding this comment.
Fixed by renaming the test to state that it records the current unchanged-position/onNodeMoved defect explicitly.
2e52297 to
5d7b3a4
Compare
e1608b8 to
ba3e7ab
Compare
fcc5924 to
46506c7
Compare
14f4f6b to
15f03cd
Compare
46506c7 to
c7b4697
Compare
15f03cd to
2ea795a
Compare
c7b4697 to
af14bb2
Compare
2ea795a to
235c87e
Compare
af14bb2 to
393b481
Compare
235c87e to
5ca4cfa
Compare
393b481 to
1eac171
Compare
5ca4cfa to
8203f45
Compare
1eac171 to
0933435
Compare
8203f45 to
231aa2c
Compare
0933435 to
5483992
Compare
231aa2c to
ac166da
Compare
5483992 to
1429198
Compare
ac166da to
c3e90b9
Compare
e214dbd to
9ee5920
Compare
a4a89d0 to
b741bd1
Compare
dcf8bf1 to
aaede7d
Compare
52a0bc0 to
fc4f1dc
Compare
aaede7d to
1bb3f51
Compare
5b40902 to
772970f
Compare
Drives processMouseDown/Move/Up/Cancel against a real canvas per target kind (node, group, empty canvas) and records selection, position, pan and callback order. One expected failure records the bufferTime promotion that moves a node on a slow click. Part of FE-2040. Amp-Thread-ID: https://ampcode.com/threads/T-01a0d64f-7e18-71c9-a617-8fd02a7e98a5
1bb3f51 to
4bc49eb
Compare
jaeone94
left a comment
There was a problem hiding this comment.
LGTM. I found no blocking issues. The characterization tests exercise the real canvas gesture paths, and the fixture extraction preserves the existing assertions. The focused gesture and selection suites passed.
## Summary Recreates Comfy-Org#17110 on `main`; that PR was accidentally merged into its stale stack branch instead of the default branch. Adds the characterization harness for pointer gestures in `LGraphCanvas`, ahead of the reducer extraction described in ADR-CANVAS-GESTURE-0029 (Comfy-Org#17106). There are no production-code changes. - Drives real `LGraphCanvas` and `CanvasPointer` instances with deterministic synthetic pointer events. - Covers node, group, reroute, link, empty-canvas, marquee, context-menu, click, double-click, drag, and cancel paths. - Moves shared canvas fixtures into `src/lib/litegraph/src/__fixtures__/canvasHarness.ts`. - Keeps two expected-failure characterizations for behavior fixed later in the stack. Part of FE-2040. ## Checklist - [x] Focused gesture suite: 29 passed, 2 expected failures - [x] `pnpm typecheck:app` - [x] `git diff --check` Co-authored-by: Amp <amp@ampcode.com>
…rg#20374) ## Summary Replaces pointer gesture handling in the classic canvas and Vue nodes with one pure state machine, per ADR-CANVAS-GESTURE-0029. This combines and supersedes Comfy-Org#17113, Comfy-Org#17116, Comfy-Org#17122 and Comfy-Org#17308. ```text pointer events (classic canvas or Vue node) CanvasPointer | useNodePointerInteractions # adapters captureGesture(element, pointerId, cancel) # lost capture -> cancel; release stops listening first reduceGesture(state, event) # pure: idle | pressed | dragging effects: click doubleClick startDrag movePress moveDrag endDrag cancelDrag classic -> onClick onDoubleClick onDragStart onDrag onDragEnd onDragCancel Vue -> processSelect, useNodeDrag start/handle/end/cancelDrag resolvePointerTarget # classic canvas only: hit-test once per press ``` - **Reducer:** `reduceGesture(state, event)` classifies click, drag and double click. The `down` event carries `CanvasPointer.gesturePolicy()` (`maxClickDrift`, `doubleClickTime`), and the pressed state keeps it, so a setting change applies to the next press. `up` carries `acceptsDoubleClick`; Vue nodes pass `false`, so a quick second ctrl/shift click toggles selection as on main. An interrupted drag emits `cancelDrag`. - **Distance only:** a press becomes a drag only when it moves further than `Comfy.Pointer.ClickDrift`. Time-based promotion is removed. `Comfy.Pointer.ClickBufferTime` stays registered as hidden and deprecated, which keeps its typed key and gives the remaining `get`/`set` callers a default. Its translations are removed. - **Vue nodes:** pointer events route through the same reducer. `handleNodeSelect` and `toggleNodeSelectionAfterPointerUp` are deleted, and Vue nodes no longer use `useClickDragGuard` (load3d and linear mode still do). Selection uses pointer-down modifiers, matching the classic canvas. Alt-clone requires `LiteGraph.alt_drag_do_clone_nodes`, no ctrl, and `canvas.allow_interaction`, as on the classic canvas. Pinned nodes take no pointer capture and never move. A node pinned mid-drag is not snapped. An interrupted drag calls `useNodeDrag().cancelDrag()` without snapping. A release while space-panning ends the drag normally, with snap, as on main. - **Press target:** the classic canvas resolves the primary-button target once per press into an exhaustive `PointerTarget` union. A node is a target only when the canvas or node allows interaction. Otherwise the press falls through to badge, subgraph IO, reroute, link, group or empty. Ctrl/meta in panning mode uses `resolveSelectableTarget` only when no node was hit. Hidden reroutes no longer capture selection. - **Interruptions:** `captureGesture` sets capture and cancels on `lostpointercapture`. Its release function stops listening before it releases capture, so the `lostpointercapture` the browser fires after `pointerup` does not cancel. Chromium fires no event when the captured element is removed. Both adapters recover because a buttonless move counts as a release and a new press from the same pointer cancels the stale one. There are no window blur or visibility listeners. Interrupted classic moves keep their position through `onDragCancel` without snapping. Interrupted resizes close their change transaction. - **Drag zoom:** any press or buttonless move ends an active drag zoom, as do a release over the canvas and teardown. It still holds no capture, so a release outside the canvas ends at the next buttonless move or press. - **Number widgets:** moving within the drift threshold still forwards to `onDrag`, so a slow nudge can adjust the value and then open the prompt on release. This is intentional and documented in the ADR. - `unbindEvents` now removes capture-phase listeners with the capture flag. Docs: docs.comfy.org/interface/settings/lite-graph still lists "Pointer click drift delay". Remove it; click versus drag now depends only on "Pointer click drift (maximum distance)". ## Evidence - **Before:** characterization tests from Comfy-Org#17110 recorded time-based promotion as `it.fails`. Three Vue e2e tests were `test.fail`: a slow group-title click moved the group; Vue nodes dragged at 3 px instead of the 6 px `ClickDrift`; Vue nodes came to the front on release, not on press. **After:** the `it.fails` passes as `it`, and all three `test.fail` markers are removed. - Reducer tests cover each phase's transitions, repeated moves while dragging, the drift boundary, and the double-click time and 3 × drift distance boundaries. - Vitest over `src/lib/litegraph`, `src/renderer/extensions/vueNodes`, `src/platform/settings` and `src/renderer/core/canvas`: 269 files, 3694 passed, 8 expected failures (pre-existing markers), 5 skipped. - `pnpm typecheck:app` passes. ## Merge Danger **Door:** two-way. No persisted data changes; reverting restores the previous handlers. **Blast Radius:** pointer interactions. Every click, drag, double-click and selection path on the canvas and on Vue nodes goes through the new code. `CanvasPointer` public changes against main: - `eLastDown` is removed, so readers get `undefined`. ComfyUI-compare-videos reads `pointer.eDown ?? pointer.eLastDown`, and basify also reads it. - `static bufferTime` is removed. Assignments to it have no effect. - `onDragCancel` is added. `reset()` calls it when it interrupts an active drag. - `dragStarted` is a read-only getter. Extensions that write it would throw; no in-repo writer exists. Callbacks assigned through `onClick`, `onDoubleClick`, `onDragStart`, `onDrag`, `onDragEnd` and `finally` keep working. User-visible changes on Vue nodes: - The drag threshold is `Comfy.Pointer.ClickDrift` (default 6 px) instead of a fixed 3 px. - An unpinned node comes to the front on press. - A context menu opened during a node drag is suppressed and cancels the drag. Open PR Comfy-Org#20098 edits `handleNodeSelect` and `toggleNodeSelectionAfterPointerUp`, which this PR deletes. Part of FE-2040. --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Adds a characterization harness for pointer gestures in
LGraphCanvas, ahead of the reducer extraction described in ADR-CANVAS-GESTURE-0029 (#17106). There are no production-code changes.LGraphCanvasandCanvasPointerinstances with deterministic synthetic pointer events.src/lib/litegraph/src/__fixtures__/canvasHarness.ts.node.onMouseUpreceives the stored down event instead of pointer-up.At this stack layer, cancellation preserves an already-moved position but does not run normal drag completion. A later stack PR adds interruption-specific finalization without invoking normal completion behavior such as snapping.
Stacked on #17105. Part of FE-2040.
Checklist
pnpm typecheck:app