Repository navigation
test: characterize pointer gestures in LGraphCanvas - #18883
Conversation
Drives processMouseDown/Move/Up/Cancel against a real canvas per target kind (node, group, empty canvas) and records selection, position, pan and callback order. One expected failure records the bufferTime promotion that moves a node on a slow click. Part of FE-2040. Amp-Thread-ID: https://ampcode.com/threads/T-01a0d64f-7e18-71c9-a617-8fd02a7e98a5
🎭 Playwright: ✅ 2130 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 22f7d6a501d1eefc3df31572a589fcdffbbe0681
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzip 🔴 +305 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.73 kB) • 🔴 +38 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.43 MB) • 🔴 +22.4 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 124 kB) • 🔴 +9.77 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.5 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 39.4 kB (baseline 27.8 kB) • 🔴 +11.6 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +690 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 125 kB (baseline 117 kB) • 🔴 +8.01 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.98 MB (baseline 3.6 MB) • 🔴 +380 kBStores, services, APIs, and repositories
Status: 15 added / 16 removed Utilities & Hooks — 576 kB (baseline 559 kB) • 🔴 +17.6 kBHelpers, composables, and utility bundles
Status: 30 added / 30 removed / 6 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -686 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.9 MB (baseline 16.4 MB) • 🔴 +1.49 MBBundles that do not match a named category
Status: 179 added / 174 removed / 122 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T16:12:32.621Z",
"gitSha": "292c3ed2dc94310e52ebca68a242d5678bdadd28",
"branch": "drjkl/fe-2040-gesture-harness-main",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1990.7310000000393,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.464,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.071,
"heapDeltaBytes": -6523388,
"heapUsedBytes": 55711508,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.050999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1993.696,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.8259999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.587,
"heapDeltaBytes": 8376420,
"heapUsedBytes": 70532296,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.083999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.7279999999978,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.662000000000003,
"layouts": 12,
"layoutDurationMs": 4.337,
"taskDurationMs": 690.661,
"heapDeltaBytes": 11408204,
"heapUsedBytes": 73835592,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 129.439,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.933000000031,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.826,
"layouts": 12,
"layoutDurationMs": 4.219,
"taskDurationMs": 694.057,
"heapDeltaBytes": -2820936,
"heapUsedBytes": 59195008,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 129.323,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.300000000018,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.632000000000001,
"layouts": 6,
"layoutDurationMs": 1.036,
"taskDurationMs": 271.204,
"heapDeltaBytes": 2140968,
"heapUsedBytes": 64516592,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.376999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.1190000000006,
"styleRecalcs": 28,
"styleRecalcDurationMs": 9.162000000000003,
"layouts": 6,
"layoutDurationMs": 1.123,
"taskDurationMs": 275.383,
"heapDeltaBytes": 2076436,
"heapUsedBytes": 64716176,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.032999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 516.4340000000038,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.3500000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.383,
"heapDeltaBytes": 18175400,
"heapUsedBytes": 80600940,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 129.975,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 529.8999999999978,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.523,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.409,
"heapDeltaBytes": 18195396,
"heapUsedBytes": 80756484,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 132.415,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1058.2069999999817,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.184,
"heapDeltaBytes": 39479004,
"heapUsedBytes": 106389156,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 54.97600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 441,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1065.4939999999442,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.1589999999999,
"heapDeltaBytes": -13813004,
"heapUsedBytes": 72363680,
"domNodes": -259,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 52.244,
"eventListeners": -207,
"totalBlockingTimeMs": 413,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 767.0180000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.91700000000003,
"heapDeltaBytes": 14883812,
"heapUsedBytes": 92148572,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.17999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 767.1510000000126,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.2429999999999,
"heapDeltaBytes": 14744316,
"heapUsedBytes": 91847160,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.12999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7454.739000000018,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.28599999999999803,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6605.045999999999,
"heapDeltaBytes": -1135652,
"heapUsedBytes": 81865536,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 5255.413,
"eventListeners": 0,
"totalBlockingTimeMs": 79,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7453.2320000000145,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.2410000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6675.1050000000005,
"heapDeltaBytes": -238476,
"heapUsedBytes": 74029640,
"domNodes": -228,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5331.004,
"eventListeners": -164,
"totalBlockingTimeMs": 93,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7288.604000000021,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6180000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6473.963,
"heapDeltaBytes": 11523992,
"heapUsedBytes": 89193000,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5170.415999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 109,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7128.024000000039,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9919999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6326.259999999999,
"heapDeltaBytes": 9253212,
"heapUsedBytes": 87082908,
"domNodes": -228,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 5038.246,
"eventListeners": -164,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2036.608000000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.6199999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.9119999999999,
"heapDeltaBytes": -8417936,
"heapUsedBytes": 73382036,
"domNodes": -228,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 34.248,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.4019999999236,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2129999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.00200000000007,
"heapDeltaBytes": 1281044,
"heapUsedBytes": 82810064,
"domNodes": -228,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 30.682000000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2134.672000000023,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.848,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1310.756,
"heapDeltaBytes": -18227600,
"heapUsedBytes": 64614852,
"domNodes": -228,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 642.621,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2154.2610000000195,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1396.3000000000002,
"heapDeltaBytes": -7160276,
"heapUsedBytes": 75209484,
"domNodes": -228,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 672.494,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3222.327000000007,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.242000000000003,
"layouts": 60,
"layoutDurationMs": 13.294,
"taskDurationMs": 1428.865,
"heapDeltaBytes": -9978784,
"heapUsedBytes": 74319840,
"domNodes": -228,
"jsHeapTotalBytes": 5533696,
"scriptDurationMs": 656.675,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3202.9980000000933,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.863999999999997,
"layouts": 60,
"layoutDurationMs": 13.382000000000001,
"taskDurationMs": 1409.861,
"heapDeltaBytes": -11351340,
"heapUsedBytes": 72927304,
"domNodes": -228,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 622.768,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2181.810999999982,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.103,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1539.0900000000004,
"heapDeltaBytes": 17866448,
"heapUsedBytes": 103487368,
"domNodes": 0,
"jsHeapTotalBytes": 5697536,
"scriptDurationMs": 771.31,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2234.538000000043,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.3340000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1554.126,
"heapDeltaBytes": -10683092,
"heapUsedBytes": 75329524,
"domNodes": 0,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 773.939,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2034.911999999963,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.595,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.97900000000004,
"heapDeltaBytes": -14298124,
"heapUsedBytes": 74827104,
"domNodes": -228,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 29.715,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.101999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9860000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.32399999999996,
"heapDeltaBytes": -9433956,
"heapUsedBytes": 73019504,
"domNodes": -228,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 28.580999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 511.08899999996993,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.735,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.97999999999996,
"heapDeltaBytes": 13965404,
"heapUsedBytes": 83813772,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 118.20400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.6959999999581,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.013000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.913,
"heapDeltaBytes": 13128540,
"heapUsedBytes": 76968468,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 122.749,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1998.3680000000277,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3819999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.42699999999996,
"heapDeltaBytes": -7551416,
"heapUsedBytes": 54787276,
"domNodes": 0,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.162999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.0799999999635,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.913,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.59,
"heapDeltaBytes": 14961008,
"heapUsedBytes": 78516528,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.917000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.5560000000105,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.795,
"layouts": 16,
"layoutDurationMs": 5.363,
"taskDurationMs": 630.327,
"heapDeltaBytes": -10556532,
"heapUsedBytes": 59210560,
"domNodes": -244,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 88.795,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.1020000001045,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.347000000000001,
"layouts": 16,
"layoutDurationMs": 5.016000000000001,
"taskDurationMs": 650.408,
"heapDeltaBytes": -5743636,
"heapUsedBytes": 57166932,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 90.80300000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 801.2219999999957,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.996000000000002,
"layouts": 5,
"layoutDurationMs": 9.376000000000003,
"taskDurationMs": 571.0900000000001,
"heapDeltaBytes": 19834028,
"heapUsedBytes": 100083824,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 21.227000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 86,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8154.528999999968,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.852,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4551.03,
"heapDeltaBytes": -665620,
"heapUsedBytes": 80965460,
"domNodes": -228,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 2154.0629999999996,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8193.969000000037,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.91,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4811.451,
"heapDeltaBytes": -16441876,
"heapUsedBytes": 65586492,
"domNodes": -228,
"jsHeapTotalBytes": 1863680,
"scriptDurationMs": 2240.935,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14228.166000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13939.404,
"heapDeltaBytes": -30051088,
"heapUsedBytes": 184835668,
"domNodes": -8049,
"jsHeapTotalBytes": -16318464,
"scriptDurationMs": 209.65200000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14375.294000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14221.166,
"heapDeltaBytes": -61076056,
"heapUsedBytes": 179943172,
"domNodes": -8049,
"jsHeapTotalBytes": -14880768,
"scriptDurationMs": 204.682,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16860.39800000003,
"styleRecalcs": 114,
"styleRecalcDurationMs": 14.172000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16667.757,
"heapDeltaBytes": -33537848,
"heapUsedBytes": 194361632,
"domNodes": -8049,
"jsHeapTotalBytes": -14266368,
"scriptDurationMs": 696.9830000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 53,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17081.222000000023,
"styleRecalcs": 118,
"styleRecalcDurationMs": 14.39399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16944.338000000003,
"heapDeltaBytes": -56721960,
"heapUsedBytes": 180026112,
"domNodes": -8049,
"jsHeapTotalBytes": -17936384,
"scriptDurationMs": 712.936,
"eventListeners": -14923,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5152.557000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.88100000000002,
"layouts": 20,
"layoutDurationMs": 30.127000000000002,
"taskDurationMs": 5126.5830000000005,
"heapDeltaBytes": -38344060,
"heapUsedBytes": 176464136,
"domNodes": -8049,
"jsHeapTotalBytes": 10678272,
"scriptDurationMs": 109.371,
"eventListeners": -14923,
"totalBlockingTimeMs": 294,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5028.985999999918,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.64800000000001,
"layouts": 20,
"layoutDurationMs": 21.971000000000004,
"taskDurationMs": 5000.5599999999995,
"heapDeltaBytes": -62034536,
"heapUsedBytes": 171370160,
"domNodes": -8049,
"jsHeapTotalBytes": 13910016,
"scriptDurationMs": 84.27999999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 138,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7218.947999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7163.743,
"heapDeltaBytes": 24553116,
"heapUsedBytes": 193046224,
"domNodes": 0,
"jsHeapTotalBytes": -24379392,
"scriptDurationMs": 100.64699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7004.037000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6814.293999999999,
"heapDeltaBytes": 13739284,
"heapUsedBytes": 183294896,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 95.70800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 450.24899999998524,
"styleRecalcs": 20,
"styleRecalcDurationMs": 17.598000000000003,
"layouts": 4,
"layoutDurationMs": 1.5280000000000002,
"taskDurationMs": 112.46000000000001,
"heapDeltaBytes": 5232760,
"heapUsedBytes": 67244932,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.129999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 457.0849999998927,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.304,
"layouts": 4,
"layoutDurationMs": 1.6920000000000002,
"taskDurationMs": 101.078,
"heapDeltaBytes": 4884860,
"heapUsedBytes": 66971996,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.722,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Files not reviewed due to moderation or processing errors (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughAdds a shared canvas test harness, gesture tests for pointer and canvas interactions, and updates the selection tests to use shared helpers. ChangesCanvas interaction tests
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is established from the supplied changes; merge after normal test checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review coverage is incomplete: 3 files could not be fully reviewed. Findings from completed review steps are included; see review info for details. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18883 +/- ##
==========================================
+ Coverage 83.94% 84.90% +0.95%
==========================================
Files 3067 2306 -761
Lines 151775 132533 -19242
Branches 41213 35782 -5431
==========================================
- Hits 127406 112524 -14882
+ Misses 22923 19703 -3220
+ Partials 1446 306 -1140
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Recreates #17110 on
main; that PR was accidentally merged into its stale stack branch instead of the default branch.Adds the characterization harness for pointer gestures in
LGraphCanvas, ahead of the reducer extraction described in ADR-CANVAS-GESTURE-0029 (#17106). There are no production-code changes.LGraphCanvasandCanvasPointerinstances with deterministic synthetic pointer events.src/lib/litegraph/src/__fixtures__/canvasHarness.ts.Part of FE-2040.
Checklist
pnpm typecheck:appgit diff --check