Repository navigation
[backport cloud/1.56] fix(agent-crdt): preserve restored same-document subscription - #21314
Conversation
## Summary Preserves connected and stale-recovery state when a restored follower's first reactive acknowledgement names its already-subscribed document. ## Changes - Treat an active same-document transition as an idempotent acknowledgement before subscription teardown. - Exclude the inactive-to-active edge so held same-workflow tab-switch ops still resubscribe, resume, and drain rejected reverts. - Add one follower regression for persisted rebind followed by naming the same workflow. ## Review Focus The early return applies only while active, not on an activation edge, and only when the named document already equals the subscribed workflow. Inactive transitions, activation edges, and true retargets keep the existing reset path. Follow-up to #16708. Extends [FE-1969](https://linear.app/comfyorg/issue/FE-1969/crdt-follower-cannot-restore-persisted-binding-through-agentpanelroot). ## Evidence - The regression fails on current `main` with `connected` false after the same-document acknowledgement. - `NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/workbench/extensions/agent/crdt/` — 964 passed, 1 expected fail. - `NODE_OPTIONS=--no-experimental-webstorage pnpm typecheck` — passed. - Changed-file oxlint, ESLint, oxfmt, and the pre-push Knip/Fallow gates passed. ## End-to-end coverage: why this fix has no `browser_tests/` case Reproducing this in the browser needs a live document subscription that survives a reload. `agentConversationTest` has no reload step, and `agentChatRefreshPersistence.spec.ts` runs with `connectWebSocketToServer: false`, so neither enters the persisted-rebind path with a live subscription. Adding that harness capability is separate work. --------- Co-authored-by: Amp <amp@ampcode.com>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-18T22:27:56.961Z",
"gitSha": "f83ad99ff69a003072ea4584273857fd7bd9c79e",
"branch": "backport-16849-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.2540000000317,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.400000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.02599999999995,
"heapDeltaBytes": 723832,
"heapUsedBytes": 68423256,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.051000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2008.254000000079,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7670000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.91399999999993,
"heapDeltaBytes": 1018632,
"heapUsedBytes": 68533572,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.233999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1804.350999999997,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.397,
"layouts": 12,
"layoutDurationMs": 4.829,
"taskDurationMs": 715.8979999999999,
"heapDeltaBytes": -1954468,
"heapUsedBytes": 67303452,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 135.643,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814818,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1701.6999999999598,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.665,
"layouts": 12,
"layoutDurationMs": 3.9389999999999996,
"taskDurationMs": 645.5010000000001,
"heapDeltaBytes": 20452740,
"heapUsedBytes": 80310312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 123.24100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.7170000000024,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.294,
"layouts": 6,
"layoutDurationMs": 1.2770000000000001,
"taskDurationMs": 293.119,
"heapDeltaBytes": 4132656,
"heapUsedBytes": 71951184,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.790000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.5530000000044,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.137,
"layouts": 6,
"layoutDurationMs": 1.296,
"taskDurationMs": 289.34900000000005,
"heapDeltaBytes": 4137964,
"heapUsedBytes": 72050120,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.143,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 547.3820000000842,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.031,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.6480000000001,
"heapDeltaBytes": -6740396,
"heapUsedBytes": 60785768,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 135.796,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 543.6599999999316,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.861999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.232,
"heapDeltaBytes": 14794868,
"heapUsedBytes": 73981684,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 135.433,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1004.6710000000303,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.7019999999999,
"heapDeltaBytes": 10606516,
"heapUsedBytes": 92425460,
"domNodes": 0,
"jsHeapTotalBytes": 1474560,
"scriptDurationMs": 46.775999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 373,
"frameDurationMs": 29.408823529411755,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 994.199999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.8820000000001,
"heapDeltaBytes": 39306760,
"heapUsedBytes": 108062536,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 54.25300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 375,
"frameDurationMs": 29.40882352941178,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 779.1039999999612,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.2629999999998,
"heapDeltaBytes": 16907840,
"heapUsedBytes": 91806332,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 124.93700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 165,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 783.8820000000624,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.7209999999999,
"heapDeltaBytes": 17677724,
"heapUsedBytes": 99367836,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 122.90800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7002.8369999999995,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9580000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6271.419,
"heapDeltaBytes": -4771912,
"heapUsedBytes": 72241668,
"domNodes": -142,
"jsHeapTotalBytes": -9048064,
"scriptDurationMs": 5059.169000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 72,
"frameDurationMs": 25.453818181818182,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6553.234999999972,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9750000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5900.619,
"heapDeltaBytes": 1112556,
"heapUsedBytes": 68953324,
"domNodes": -142,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 4699.3369999999995,
"eventListeners": -74,
"totalBlockingTimeMs": 33,
"frameDurationMs": 25.191538461538467,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7109.583999999927,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.4590000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6426.092,
"heapDeltaBytes": 15851588,
"heapUsedBytes": 93454292,
"domNodes": -142,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 5140.298,
"eventListeners": -74,
"totalBlockingTimeMs": 110,
"frameDurationMs": 25.723550724637683,
"p95FrameDurationMs": 33.5
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6441.929000000073,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0289999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5902.821,
"heapDeltaBytes": 7517572,
"heapUsedBytes": 84980388,
"domNodes": -142,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 4726.2119999999995,
"eventListeners": -74,
"totalBlockingTimeMs": 25,
"frameDurationMs": 24.902316602316606,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2009.200000000078,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.071,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.8129999999999,
"heapDeltaBytes": -10776508,
"heapUsedBytes": 77596040,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.477000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2016.1769999999706,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.192,
"heapDeltaBytes": -10446096,
"heapUsedBytes": 77274936,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.913999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2111.498000000097,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.054,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1313.8739999999998,
"heapDeltaBytes": -16947192,
"heapUsedBytes": 68310264,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 681.122,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66614173228346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2139.261999999917,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.419,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1219.1209999999999,
"heapDeltaBytes": -19783756,
"heapUsedBytes": 68888324,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 648.6780000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3225.0209999999697,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.182,
"layouts": 60,
"layoutDurationMs": 13.949,
"taskDurationMs": 1410.931,
"heapDeltaBytes": 3009088,
"heapUsedBytes": 84052904,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 662.339,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580310880829,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3227.2349999999506,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.463000000000001,
"layouts": 60,
"layoutDurationMs": 13.828,
"taskDurationMs": 1379.2380000000003,
"heapDeltaBytes": 5431168,
"heapUsedBytes": 92774860,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 655.7539999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580310880829,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2400.978000000009,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.429,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1584.5120000000002,
"heapDeltaBytes": 5824700,
"heapUsedBytes": 74274676,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 823.595,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7830985915493,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2258.7800000000016,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.728,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1560.386,
"heapDeltaBytes": 8366080,
"heapUsedBytes": 75763268,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 816.979,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.790298507462683,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.4359999999751,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.122999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.7010000000001,
"heapDeltaBytes": -8807356,
"heapUsedBytes": 81307568,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 32.669000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2014.8619999999937,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2759999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.6960000000001,
"heapDeltaBytes": -11153280,
"heapUsedBytes": 69315252,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.452999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.0750000000107,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.191000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.99999999999994,
"heapDeltaBytes": -11909600,
"heapUsedBytes": 58139588,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 122.26800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.4760000000178,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.399000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.43800000000005,
"heapDeltaBytes": -11833496,
"heapUsedBytes": 57615084,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 126.328,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.3740000000034,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.544000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.98400000000004,
"heapDeltaBytes": 1174576,
"heapUsedBytes": 70966292,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.563000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.5929999999717,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.84200000000004,
"heapDeltaBytes": 1187116,
"heapUsedBytes": 70760204,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.040999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.5879999999106,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.848,
"layouts": 16,
"layoutDurationMs": 4.704,
"taskDurationMs": 620.141,
"heapDeltaBytes": 16682844,
"heapUsedBytes": 78777704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 90.251,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.4839999999267,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.777,
"layouts": 16,
"layoutDurationMs": 4.666,
"taskDurationMs": 609.741,
"heapDeltaBytes": 17296504,
"heapUsedBytes": 81142120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 88.78800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 901.5249999999924,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.93,
"layouts": 5,
"layoutDurationMs": 10.607000000000001,
"taskDurationMs": 726.5929999999998,
"heapDeltaBytes": -565696,
"heapUsedBytes": 90050008,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 21.768000000000004,
"eventListeners": 2463,
"totalBlockingTimeMs": 89,
"frameDurationMs": 19.565217391304348,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8163.244000000077,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.633,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4545.171,
"heapDeltaBytes": 7850636,
"heapUsedBytes": 96187904,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 2277.501,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591836734694,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8198.648999999932,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.144999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4475.861,
"heapDeltaBytes": -18684048,
"heapUsedBytes": 69463340,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2221.944,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666056910569107,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15777.893000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15142.701,
"heapDeltaBytes": -32456484,
"heapUsedBytes": 180609240,
"domNodes": -3045,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 233.39300000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.03321492007105,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 15928.17100000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15369.079,
"heapDeltaBytes": -49472852,
"heapUsedBytes": 180631128,
"domNodes": -3045,
"jsHeapTotalBytes": 8671232,
"scriptDurationMs": 256.886,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.36531365313653,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 17943.413000000077,
"styleRecalcs": 141,
"styleRecalcDurationMs": 16.397999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17575.063000000002,
"heapDeltaBytes": -19599920,
"heapUsedBytes": 191911192,
"domNodes": -3045,
"jsHeapTotalBytes": 5652480,
"scriptDurationMs": 774.854,
"eventListeners": -14915,
"totalBlockingTimeMs": 2,
"frameDurationMs": 34.549807692307695,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18179.81800000007,
"styleRecalcs": 137,
"styleRecalcDurationMs": 15.731999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17891.969,
"heapDeltaBytes": -37707204,
"heapUsedBytes": 175067756,
"domNodes": -3045,
"jsHeapTotalBytes": 7163904,
"scriptDurationMs": 693.9739999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.56768060836502,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5513.400999999931,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.03699999999998,
"layouts": 20,
"layoutDurationMs": 22.31799999999999,
"taskDurationMs": 5401.673,
"heapDeltaBytes": 1108532,
"heapUsedBytes": 214163816,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 88.259,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.432727272727284,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5612.772999999947,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.987000000000016,
"layouts": 20,
"layoutDurationMs": 23.453000000000003,
"taskDurationMs": 5543.192999999999,
"heapDeltaBytes": 926236,
"heapUsedBytes": 213618264,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 95.44400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 3,
"frameDurationMs": 33.93818181818181,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6206.157000000076,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5720.654000000001,
"heapDeltaBytes": -31135436,
"heapUsedBytes": 184349020,
"domNodes": -3045,
"jsHeapTotalBytes": 10915840,
"scriptDurationMs": 95.27799999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.930976430976433,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7645.7000000000335,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7453.944000000001,
"heapDeltaBytes": -35637640,
"heapUsedBytes": 167010056,
"domNodes": -3045,
"jsHeapTotalBytes": 7688192,
"scriptDurationMs": 112.02300000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.756363636363638,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 466.961000000083,
"styleRecalcs": 18,
"styleRecalcDurationMs": 15.353,
"layouts": 3,
"layoutDurationMs": 1.4369999999999998,
"taskDurationMs": 110.319,
"heapDeltaBytes": 5850916,
"heapUsedBytes": 71287844,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.774999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 90.33799999997427,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.667000000000001,
"layouts": 2,
"layoutDurationMs": 0.6559999999999999,
"taskDurationMs": 57.62700000000001,
"heapDeltaBytes": 3753312,
"heapUsedBytes": 69060100,
"domNodes": 94,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.315,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 566.7450000000827,
"styleRecalcs": 78,
"styleRecalcDurationMs": 80.656,
"layouts": 76,
"layoutDurationMs": 20.032,
"taskDurationMs": 539.4319999999999,
"heapDeltaBytes": -17196188,
"heapUsedBytes": 66285724,
"domNodes": 76,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 204.023,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 551.2200000000576,
"styleRecalcs": 78,
"styleRecalcDurationMs": 80.406,
"layouts": 76,
"layoutDurationMs": 20.444,
"taskDurationMs": 523.821,
"heapDeltaBytes": -17446224,
"heapUsedBytes": 67582116,
"domNodes": 76,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 195.33,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1235.019000000193,
"styleRecalcs": 78,
"styleRecalcDurationMs": 260.336,
"layouts": 76,
"layoutDurationMs": 27.455000000000002,
"taskDurationMs": 1202.665,
"heapDeltaBytes": 7693976,
"heapUsedBytes": 115486404,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 373.71099999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.12916666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1244.1839999999047,
"styleRecalcs": 78,
"styleRecalcDurationMs": 265.423,
"layouts": 76,
"layoutDurationMs": 28.561,
"taskDurationMs": 1215.8580000000002,
"heapDeltaBytes": -17685208,
"heapUsedBytes": 108368700,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 373.204,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.121917808219173,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2205 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1b0ddf2ef25caee1fb682ca2f08b352475983bdf
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #21314 +/- ##
=============================================
Coverage ? 85.93%
=============================================
Files ? 2504
Lines ? 142864
Branches ? 38943
=============================================
Hits ? 122769
Misses ? 19709
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: this is a faithful cloud/1.56 backport and CI is settled green at this exact head.
Full context for agent readers
The mechanical fidelity pass matches the merged original, including the changed-file result. There are no package manifest or export changes, no unresolved review threads, and no workspace-scope change.
Backport of #16849 to
cloud/1.56Automatically created by backport workflow.