Repository navigation
[backport core/1.52] revert: post-first-run discovery actions - #16828
Conversation
## Summary Reverts #16143 while the post-first-run discovery flow is reworked to satisfy the agreed correctness, observability, and end-to-end coverage requirements. ## Changes - **What**: Restores the previous first-run nudge, template loading, and tour-controller behavior. - **Dependencies**: None. ## Review Focus This is the exact inverse of the squash commit from #16143. Follow-up work will restore the product feature in a reviewable stack; the existing E2E work in #16136 should not merge ahead of that stack.
🎭 Playwright: ✅ 1986 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T19:44:46.647Z",
"gitSha": "8eba7e98c6cfbee2b737955692cff5bdb0662946",
"branch": "backport-16197-to-core-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2051.16000000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.7200000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.05799999999994,
"heapDeltaBytes": -6723556,
"heapUsedBytes": 55662036,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.322000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1990.3119999999603,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.819000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.323,
"heapDeltaBytes": 2952852,
"heapUsedBytes": 65104756,
"domNodes": -282,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 5.698999999999999,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.1679999999817,
"styleRecalcs": 72,
"styleRecalcDurationMs": 26.494000000000003,
"layouts": 12,
"layoutDurationMs": 2.9859999999999998,
"taskDurationMs": 676.456,
"heapDeltaBytes": 13510804,
"heapUsedBytes": 75448408,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 83.566,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.7960000000066,
"styleRecalcs": 71,
"styleRecalcDurationMs": 29.915000000000003,
"layouts": 12,
"layoutDurationMs": 3.5089999999999995,
"taskDurationMs": 681.432,
"heapDeltaBytes": -4867780,
"heapUsedBytes": 57457828,
"domNodes": -282,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 83.259,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.754999999995,
"styleRecalcs": 33,
"styleRecalcDurationMs": 13.547000000000002,
"layouts": 6,
"layoutDurationMs": 0.54,
"taskDurationMs": 286.831,
"heapDeltaBytes": 3309908,
"heapUsedBytes": 65995392,
"domNodes": 80,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.205,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1657.4860000000626,
"styleRecalcs": 29,
"styleRecalcDurationMs": 12.501,
"layouts": 6,
"layoutDurationMs": 0.508,
"taskDurationMs": 278.082,
"heapDeltaBytes": 3302552,
"heapUsedBytes": 66299564,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.121,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 461.34100000000444,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.421,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.868,
"heapDeltaBytes": 10842024,
"heapUsedBytes": 73598852,
"domNodes": 14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 43.07,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 456.1439999999948,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.036000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.252,
"heapDeltaBytes": 9771528,
"heapUsedBytes": 72360300,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 41.782,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2023.2839999999896,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.664999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.829,
"heapDeltaBytes": -10511892,
"heapUsedBytes": 66954800,
"domNodes": -282,
"jsHeapTotalBytes": -790528,
"scriptDurationMs": 12.138000000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.944000000009,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.186999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.72099999999995,
"heapDeltaBytes": -11445760,
"heapUsedBytes": 66163004,
"domNodes": -281,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 13.627,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2095.450000000028,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.254000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 939.296,
"heapDeltaBytes": 13090924,
"heapUsedBytes": 91381840,
"domNodes": -283,
"jsHeapTotalBytes": 4939776,
"scriptDurationMs": 267.103,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2094.53000000002,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.446,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 913.1339999999999,
"heapDeltaBytes": -3013560,
"heapUsedBytes": 75101164,
"domNodes": -239,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 247.44699999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3081.6930000000298,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.965,
"layouts": 60,
"layoutDurationMs": 6.623,
"taskDurationMs": 1070.039,
"heapDeltaBytes": 15377356,
"heapUsedBytes": 78238004,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 312.17599999999993,
"eventListeners": -145,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3056.414000000018,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.519000000000002,
"layouts": 60,
"layoutDurationMs": 7.071999999999999,
"taskDurationMs": 1108.7980000000002,
"heapDeltaBytes": 17405900,
"heapUsedBytes": 96946892,
"domNodes": 16,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 319.11,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2223.6859999999865,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.644000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1209.959,
"heapDeltaBytes": -23128020,
"heapUsedBytes": 63945308,
"domNodes": -243,
"jsHeapTotalBytes": 5500928,
"scriptDurationMs": 386.133,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2112.9789999999957,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.198999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1129.669,
"heapDeltaBytes": -17144488,
"heapUsedBytes": 69991620,
"domNodes": 14,
"jsHeapTotalBytes": 8687616,
"scriptDurationMs": 363.239,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2027.6589999999715,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.630000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.94899999999996,
"heapDeltaBytes": -10462968,
"heapUsedBytes": 74777504,
"domNodes": -270,
"jsHeapTotalBytes": 2879488,
"scriptDurationMs": 12.934999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.9839999999895,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.210000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.49299999999994,
"heapDeltaBytes": -10035256,
"heapUsedBytes": 75268400,
"domNodes": -270,
"jsHeapTotalBytes": 3141632,
"scriptDurationMs": 12.86,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 529.4039999999995,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.649000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.011,
"heapDeltaBytes": 11463116,
"heapUsedBytes": 74314976,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 90.737,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.6949999999279,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.902,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.736,
"heapDeltaBytes": 11662544,
"heapUsedBytes": 74263236,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 95.811,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2038.310000000024,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.326999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.031,
"heapDeltaBytes": 5960804,
"heapUsedBytes": 68157168,
"domNodes": -279,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.654000000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.869000000032,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.417000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.813,
"heapDeltaBytes": 18472332,
"heapUsedBytes": 81004244,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 5.278999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.017000000017,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.283,
"layouts": 16,
"layoutDurationMs": 3.409,
"taskDurationMs": 627.5730000000001,
"heapDeltaBytes": 4611368,
"heapUsedBytes": 67559820,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 67.60100000000001,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.965000000007,
"styleRecalcs": 75,
"styleRecalcDurationMs": 30.13,
"layouts": 16,
"layoutDurationMs": 3.9810000000000003,
"taskDurationMs": 642.304,
"heapDeltaBytes": 20065936,
"heapUsedBytes": 82609108,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 69.368,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.4460000000117,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.422000000000008,
"layouts": 14,
"layoutDurationMs": 10.521,
"taskDurationMs": 718.912,
"heapDeltaBytes": 1443020,
"heapUsedBytes": 99538440,
"domNodes": 13673,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 12.725999999999994,
"eventListeners": 2373,
"totalBlockingTimeMs": 87,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8130.255999999974,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.253,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3213.867,
"heapDeltaBytes": 2556444,
"heapUsedBytes": 79926016,
"domNodes": -268,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 795.664,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8104.355999999939,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.675,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3208.075,
"heapDeltaBytes": -2308468,
"heapUsedBytes": 75050440,
"domNodes": -274,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 789.581,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14696.889,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14161.819000000001,
"heapDeltaBytes": -37898564,
"heapUsedBytes": 175830036,
"domNodes": -8312,
"jsHeapTotalBytes": -19439616,
"scriptDurationMs": 96.773,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14722.40899999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14135.401,
"heapDeltaBytes": -50531800,
"heapUsedBytes": 176306280,
"domNodes": -8312,
"jsHeapTotalBytes": -20369408,
"scriptDurationMs": 82.315,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17169.280000000013,
"styleRecalcs": 152,
"styleRecalcDurationMs": 14.873999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16635.404000000002,
"heapDeltaBytes": -46408724,
"heapUsedBytes": 180120040,
"domNodes": -8312,
"jsHeapTotalBytes": -11022336,
"scriptDurationMs": 336.31100000000004,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17128.450999999928,
"styleRecalcs": 145,
"styleRecalcDurationMs": 13.97100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16597.888000000003,
"heapDeltaBytes": -36225680,
"heapUsedBytes": 193199572,
"domNodes": -8312,
"jsHeapTotalBytes": -19742720,
"scriptDurationMs": 320.66299999999995,
"eventListeners": -16389,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 462.16299999997545,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.441000000000003,
"layouts": 9,
"layoutDurationMs": 1.9269999999999998,
"taskDurationMs": 101.66099999999999,
"heapDeltaBytes": 5356316,
"heapUsedBytes": 67459460,
"domNodes": 150,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.555000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 450.74300000010226,
"styleRecalcs": 11,
"styleRecalcDurationMs": 17.506,
"layouts": 3,
"layoutDurationMs": 0.601,
"taskDurationMs": 92.559,
"heapDeltaBytes": 4984980,
"heapUsedBytes": 67056124,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.285999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.52 #16828 +/- ##
=============================================
- Coverage 82.01% 81.99% -0.02%
=============================================
Files 1907 1906 -1
Lines 109080 108910 -170
Branches 30247 30175 -72
=============================================
- Hits 89462 89301 -161
+ Misses 19268 19260 -8
+ Partials 350 349 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #16197 to
core/1.52Automatically created by backport workflow.