Repository navigation
fix(auth): retry unified refresh and rotate session cookie on reactive re-mint - #16063
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2016 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.4 MB gzip 🔴 +335 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 592 kB (baseline 592 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.54 MB (baseline 3.54 MB) • 🔴 +1.33 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 220 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-27T00:42:05.791Z",
"gitSha": "558950821cf14929b9c073a681b69fed20ca813d",
"branch": "jaewon/fe-1595-unified-session-cookie-rotation",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2070.9819999999863,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.805999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.5640000000001,
"heapDeltaBytes": 10544280,
"heapUsedBytes": 81818420,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.355000000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2021.921999999904,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.483,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.859,
"heapDeltaBytes": -14451972,
"heapUsedBytes": 57884300,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.529000000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2308.88699999997,
"styleRecalcs": 80,
"styleRecalcDurationMs": 43.348,
"layouts": 12,
"layoutDurationMs": 3.7030000000000003,
"taskDurationMs": 1363.389,
"heapDeltaBytes": 1327864,
"heapUsedBytes": 72671408,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 159.617,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2158.006999999998,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.41,
"layouts": 12,
"layoutDurationMs": 3.2439999999999998,
"taskDurationMs": 1217.452,
"heapDeltaBytes": 1961040,
"heapUsedBytes": 73923420,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 142.358,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.8019999999829,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.418000000000003,
"layouts": 6,
"layoutDurationMs": 0.6469999999999999,
"taskDurationMs": 362.82699999999994,
"heapDeltaBytes": 4105068,
"heapUsedBytes": 76096452,
"domNodes": 78,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.020000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1757.614999999987,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.535999999999998,
"layouts": 6,
"layoutDurationMs": 0.589,
"taskDurationMs": 398.588,
"heapDeltaBytes": 4244472,
"heapUsedBytes": 76383804,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 15.675,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 925.6300000000124,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.074,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.485,
"heapDeltaBytes": 6707188,
"heapUsedBytes": 78728264,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 142.848,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 899.3090000000166,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.577000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.6540000000001,
"heapDeltaBytes": 7012276,
"heapUsedBytes": 78320628,
"domNodes": 14,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 140.192,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2033.1070000000295,
"styleRecalcs": 3,
"styleRecalcDurationMs": 4.279000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.716,
"heapDeltaBytes": -1718640,
"heapUsedBytes": 77317908,
"domNodes": -271,
"jsHeapTotalBytes": -1884160,
"scriptDurationMs": 39.7,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2044.3630000000894,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.349000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.7390000000001,
"heapDeltaBytes": -1951500,
"heapUsedBytes": 77199288,
"domNodes": -271,
"jsHeapTotalBytes": -1359872,
"scriptDurationMs": 38.348,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3220.435000000009,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.979000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2416.563,
"heapDeltaBytes": -13276504,
"heapUsedBytes": 66356996,
"domNodes": -276,
"jsHeapTotalBytes": 1261568,
"scriptDurationMs": 854.92,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3187.4599999999873,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.245000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2371.181,
"heapDeltaBytes": 586908,
"heapUsedBytes": 66031312,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 844.2760000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4353.668999999968,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.752000000000002,
"layouts": 60,
"layoutDurationMs": 8.395999999999999,
"taskDurationMs": 2480.3569999999995,
"heapDeltaBytes": -4413756,
"heapUsedBytes": 66501204,
"domNodes": 24,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 838.581,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4211.765000000014,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.090999999999998,
"layouts": 60,
"layoutDurationMs": 8.033999999999999,
"taskDurationMs": 2388.9320000000002,
"heapDeltaBytes": 24298760,
"heapUsedBytes": 91160228,
"domNodes": 24,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 809.0649999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 5000.839999999982,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.834000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3806.86,
"heapDeltaBytes": 23790568,
"heapUsedBytes": 91460768,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1071.003,
"eventListeners": 192,
"totalBlockingTimeMs": 25,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 4684.330999999929,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.726000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3442.1429999999996,
"heapDeltaBytes": 22869368,
"heapUsedBytes": 90514412,
"domNodes": 0,
"jsHeapTotalBytes": 2514944,
"scriptDurationMs": 952.5630000000001,
"eventListeners": 192,
"totalBlockingTimeMs": 7,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.026999999971,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.216,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.9549999999999,
"heapDeltaBytes": -2915616,
"heapUsedBytes": 77702448,
"domNodes": -272,
"jsHeapTotalBytes": -2146304,
"scriptDurationMs": 38.923,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.6950000000706,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.1909999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.441,
"heapDeltaBytes": -4318900,
"heapUsedBytes": 76449132,
"domNodes": -278,
"jsHeapTotalBytes": -2670592,
"scriptDurationMs": 37.629,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 700.9199999999964,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.262999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.71600000000007,
"heapDeltaBytes": -7724044,
"heapUsedBytes": 64182920,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 132.013,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 761.1749999999802,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.662,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.12,
"heapDeltaBytes": -7854248,
"heapUsedBytes": 64834628,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.05,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.3550000000087,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.020999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.303,
"heapDeltaBytes": -12020196,
"heapUsedBytes": 60503396,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.447,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.279000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.080000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.552,
"heapDeltaBytes": -10577508,
"heapUsedBytes": 61745008,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.699999999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1874.6120000000133,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.787,
"layouts": 16,
"layoutDurationMs": 4.823000000000001,
"taskDurationMs": 1094.783,
"heapDeltaBytes": -3989280,
"heapUsedBytes": 68702880,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.90999999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1869.5450000000164,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.528000000000006,
"layouts": 16,
"layoutDurationMs": 4.412,
"taskDurationMs": 1098.1409999999998,
"heapDeltaBytes": -8683424,
"heapUsedBytes": 64055732,
"domNodes": -300,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 100.582,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.5480000000634,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.220999999999997,
"layouts": 13,
"layoutDurationMs": 13.082999999999998,
"taskDurationMs": 952.7419999999997,
"heapDeltaBytes": -9522200,
"heapUsedBytes": 84893780,
"domNodes": 13671,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.537999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 120,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12364.878999999974,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.396,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8666.909,
"heapDeltaBytes": 16453252,
"heapUsedBytes": 95280592,
"domNodes": -267,
"jsHeapTotalBytes": 3289088,
"scriptDurationMs": 2901.497,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12359.845999999947,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.819,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8452.083,
"heapDeltaBytes": -9938660,
"heapUsedBytes": 68958404,
"domNodes": -271,
"jsHeapTotalBytes": 1523712,
"scriptDurationMs": 2887.662,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18598.922000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17825.286000000004,
"heapDeltaBytes": -30452800,
"heapUsedBytes": 177523380,
"domNodes": -6548,
"jsHeapTotalBytes": 1445888,
"scriptDurationMs": 379.29900000000004,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18250.955999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17810.542999999998,
"heapDeltaBytes": -44341428,
"heapUsedBytes": 178242168,
"domNodes": -6548,
"jsHeapTotalBytes": -1060864,
"scriptDurationMs": 361.586,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22046.21400000002,
"styleRecalcs": 171,
"styleRecalcDurationMs": 20.529000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21781.694000000003,
"heapDeltaBytes": -58768876,
"heapUsedBytes": 166859264,
"domNodes": -6548,
"jsHeapTotalBytes": -4841472,
"scriptDurationMs": 925.7079999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 59,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22227.526000000013,
"styleRecalcs": 170,
"styleRecalcDurationMs": 20.444000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21902.027000000002,
"heapDeltaBytes": -43732976,
"heapUsedBytes": 163813600,
"domNodes": -6548,
"jsHeapTotalBytes": -585728,
"scriptDurationMs": 955.243,
"eventListeners": -7467,
"totalBlockingTimeMs": 170,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 132.83000000001266,
"styleRecalcs": 11,
"styleRecalcDurationMs": 18.508,
"layouts": 6,
"layoutDurationMs": 1.8139999999999998,
"taskDurationMs": 101.42400000000002,
"heapDeltaBytes": 3598532,
"heapUsedBytes": 72126076,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.715,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 125.14900000007856,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.151,
"layouts": 2,
"layoutDurationMs": 1.1350000000000002,
"taskDurationMs": 93.029,
"heapDeltaBytes": 3564400,
"heapUsedBytes": 71523064,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.097000000000002,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughUnified token refreshes now retry transient proactive failures with bounded exponential backoff. Successful reactive re-mints notify token consumers. Tests cover recovery, retry exhaustion, token preservation, and refresh scheduling. ChangesUnified token refresh
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This localized change retries transient unified-auth refresh failures and rotates the session cookie after reactive re-mint, improving image and asset-preview availability; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description is complete and directly aligned with the pull request. It explains the issue, root cause, implementation, affected behavior, regression tests, review focus, and issue reference. It does not use every template heading exactly, but it provides the required information, including why screenshots are not applicable and that legacy authentication remains unchanged. Full details: End-To-End Regression Coverage For FixesExplanation The changed-file information is available and lists files under Full details: Website End-To-End Regression CoverageExplanation The changed files are Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed files are
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16063 +/- ##
==========================================
+ Coverage 80.56% 82.59% +2.03%
==========================================
Files 2291 1941 -350
Lines 117860 111782 -6078
Branches 33541 32671 -870
==========================================
- Hits 94958 92331 -2627
+ Misses 22348 19103 -3245
+ Partials 554 348 -206
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 364 files with indirect coverage changes 🚀 New features to boost your workflow:
|
thedatalife
left a comment
There was a problem hiding this comment.
Approving the approach — the root cause here is sharper than the one on the ticket.
The reactive-remint/cookie divergence was the visible half, but
} else {
console.warn('Unified token refresh failed:', err)
}
scheduling nothing is the real defect: the proactive chain was one network blip from permanent death, after which the cookie was never rotated again. The "up to ~85 minutes" framing matches Rob's report better than a timing-window explanation does.
Two notes, one question answered inline.
Backoff base: 5s is fine. The refresh fires at expiry−5min, so 5/10/20s all land inside the buffer with room to spare — no need for the delay clamp that legacy
scheduleTokenRefreshRetry applies. 35s total won't cover a slow laptop wake, but that degrades to the reactive path, which now rotates. Correct fallback shape.
Tests look right. The exhaustion case asserting mockFetch stays at 5 after advancing an hour is the one that actually guards against an unbounded retry loop, and leaving the existing not.toHaveBeenCalled() assertions for login mint and workspace switch intact keeps the "only re-mints rotate" invariant pinned.
One scoping flag: this fixes the cause but not the two things that make the failure stick once a window does occur, so FE-1595's reporter-visible symptom isn't fully addressed.
- A failed
<img>latchesimageErrorand never retries. Cloud/viewURLs are byte-stable (getRandParam()returns '' on cloud), so the element never re-requests. Recovery now rides the next API 401 -> re-mint -> cookie POST, which is fire-and-forget, so images requested in that gap still fail and stay failed. This is the "didn't clear until several attempts in" part of the report. getImageFilenamein ImagePreview.vue callsnew URL(url), which throws on every relative cloud URL and falls through to theimageDoesNotExiststring. That's the literal text in this ticket's title, and it renders for any failed image regardless of whether it exists. One-word fix:new URL(url, location.href).
Neither belongs in this PR — it's cleanly scoped to auth and R3 is the right label. But worth a follow-up ticket so FE-1595 doesn't get closed on the assumption the message is gone.
| // Only re-mints rotate the session cookie; the initial login mint and | ||
| // workspace switches establish it themselves. A stale (discarded) | ||
| // re-mint does not rotate either. | ||
| if (minted) { |
There was a problem hiding this comment.
The retry only arms from the catch block, but mintUnified can return false
without throwing. performUnifiedMint swallows the error at line 805:
} catch (err) {
if (
capturedRequestId !== unifiedRefreshRequestId ||
capturedOwnerUid === null || // <-- returns false, never throws
!isCurrentUser(capturedOwnerUid)
) {
return false
}
throw err
}
So minted === false takes neither branch here, and the timer is left unarmed —
the same dead proactive chain this PR is fixing, entered through a different door.
capturedOwnerUid is currentUserUid(), which is useAuthStore().currentUser?.uid ?? null
(line 146). currentUser is null while Firebase re-initializes, which is exactly the
post-wake/reconnect moment the backoff is meant to cover. A null user plus a failing
requestToken silently kills the chain again.
Narrower than the original bug since it needs both conditions, and remintUnifiedOnce
still backstops it — so not a blocker. But it's the same defect class and cheap to close:
schedule the retry on a falsy return as well as on a transient throw.
There was a problem hiding this comment.
Confirmed and fixed in 96f82aa. Both refresh timers now null unifiedRefreshTimerId when they fire, and refreshUnified treats a falsy mint with no armed timer as a dead chain and re-arms the backoff retry. The armed-timer guard keeps the other false source (a superseding mint/switch that already scheduled its own refresh) from being stomped by a stale-refresh retry. Two regression tests: owner-null-mid-refresh recovery via the 5s retry, and no pending retry after a superseding workspace switch.
| try { | ||
| const minted = await mintUnified(target) | ||
| if (!minted) return null | ||
| useAuthStore().notifyTokenRefreshed() |
There was a problem hiding this comment.
Re: "confirm that's acceptable vs. gating the bump" — acceptable, and it's tighter
than the concern suggests. Two independent layers already collapse it:
onTokenRefreshediswhenever(() => authStore.tokenRefreshTrigger, callback)
(useCurrentUser.ts:41) — a Vue watcher on the defaultflush: 'pre'. Concurrent
401 replays resume in the same microtask batch, so N bumps fire the callback once.- Anything that does span ticks hits
useSessionCookie'sinFlightCreateSession
dedupe, keyed by ownerUid.
No gating needed.
There was a problem hiding this comment.
Thanks for tracing both layers — agreed, leaving the bump ungated.
christian-byrne
left a comment
There was a problem hiding this comment.
Auth retry chain restored.
Reactive re-mint rotates cookies.
CI complete and green.
Full context for agent readers
Reviewed exact head 96f82aa4e3d7561b73bd158f02109ba0eaabfa0a against main. The bounded pass covered the complete two-file diff, auth lifecycle intent, retry and stale-request concurrency behavior, behavioral unit detectors, repository guidance, all current review threads, CI integration, and open-PR overlap.
No blocking findings. The added tests exercise transient retry success, bounded exhaustion, owner-null recovery, superseding workspace-switch safety, normal schedule re-arming, and reactive cookie rotation. Both existing threads are addressed at this head. PR #16066 changes only the action-pin workflow, so there is no semantic or file overlap and no land-order dependency. REST returned all 99 check runs reported for this commit: 75 successful, 24 skipped, 0 pending, 0 failed.
|
@dante01yoon Successfully backported to #16079 |
|
@dante01yoon Successfully backported to #16080 |
…lures (Comfy-Org#16072) ## Summary Follow-up to Comfy-Org#16063: the unified-auth incident (FE-1595) was invisible in telemetry — every path that killed image loads only `console.warn`ed. This instruments the lifecycle so the fix's effect is measurable and a recurrence alerts instead of waiting on customer reports. ## Why this is needed Diagnosing FE-1595 required the artist's Network tab because none of the failing seams emit telemetry: - The proactive `refreshUnified()` failure — the moment the session-cookie rotation chain dies — was `console.warn` only. - Session-cookie creation failure (`useSessionCookie.createSession`) was swallowed with a warn; that cookie is the only credential `<img>`/media loads carry. - The user-facing symptom itself (`ImagePreview` load error) set local state only, so affected-user counts were unknowable. - `trackUnifiedAuthRetry` covered only axios/fetch transports and only reached Datadog RUM, so PostHog could not query or alert on any of it. ## Changes - **What**: `trackUnifiedAuthRefresh` lifecycle event (`succeeded` / `retry_scheduled` / `retries_exhausted` / `permanent_failure`, with `retry_count`) emitted from `refreshUnified()`; measures the retry/backoff added in Comfy-Org#16063. - **What**: `reportError(..., { errorType: 'session_cookie_creation_failure' })` on swallowed `createSession` failures (dual-sink per repo convention). - **What**: `trackImageLoadFailed({ source: 'node_image_preview' })` from `ImagePreview`'s error handler — no filenames/PII, source tag only. - **What**: `'ws'` transport + `'token_unavailable'` reason on `UnifiedAuthRetryMetadata`, emitted when WebSocket connect cannot obtain a token under unified auth. - **What**: PostHog provider now implements `trackUnifiedAuthRetry`/`trackUnifiedAuthRefresh` (previously Datadog-only), enabling PostHog queries and alerts. ## Review Focus - Event volume: `auth.unified.refresh.succeeded` fires ~once per 85min per active session; `app:image_load_failed` fires per failed `<img>` render in node previews. Both go to Datadog actions; only the unified-auth events go to PostHog. - `retry_count` is attached to non-succeeded outcomes only. ## Tests - Refresh lifecycle outcomes asserted across the existing retry/backoff/permanent-failure store tests. - `session_cookie_creation_failure` report on swallowed createSession failure. - Image-error telemetry asserted in the existing ImagePreview failure test. - Both providers' new methods covered. 216 tests green across the five touched suites; typecheck/lint/knip clean. No UI change (telemetry only), so no screenshots. Related: FE-1595 (linear.app/comfyorg/issue/FE-1595)
…e re-mint (#16063) ## Summary Fixes intermittent "Image failed to load / Image does not exist" on Cloud (FE-1595, also reported by an enterprise pilot): under `unified_cloud_auth`, one transient token-refresh failure permanently stops session-cookie rotation, so `<img>`-based previews and asset thumbnails break while jobs keep running. ## Why this is needed / Root cause Node previews and Media Assets thumbnails load through plain `<img src="/api/view?...">` tags. An `<img>` request cannot carry an `Authorization` header, so those loads are authenticated solely by the 2-hour Firebase session cookie (`services/ingest/server/implementation/auth.go` in cloud). Before unified auth, the cookie was re-minted on every Firebase `onIdTokenChanged` (~hourly, with the Firebase SDK's built-in retries). Under `unified_cloud_auth` (100% since Jul 31) that driver is intentionally gated off in `authStore.ts`, and rotation is driven only by the proactive unified refresh: ``` mint (JWT TTL 1.5h) ──setTimeout(expiry−5m)──▶ refreshUnified() ──success──▶ notifyTokenRefreshed() ──▶ POST /auth/session (new 2h cookie) │ └─transient failure──▶ console.warn only • no retry scheduled → proactive chain dead • reactive 401 re-mint (remintUnifiedOnce) restores API traffic but deliberately did NOT rotate the cookie → cookie expires at 2h → every <img> load 401s until the NEXT scheduled refresh (up to ~85 min) or a page reload ``` This matches the reported shape exactly: job completes and bills normally (Bearer-authenticated API/WS), only image loads fail; only sessions open longer than 2h are affected (reload mints a fresh cookie); it self-heals when a later refresh lands — hence "worked fine last week" and Rob's "resolved itself after a few minutes". ## How we change it Two seams in `workspaceAuthStore.ts`, both flag-gated inside the existing unified lifecycle (legacy path untouched): - **What**: `refreshUnified()` now re-arms itself after a transient failure via `scheduleUnifiedRefreshRetry()` — bounded exponential backoff (5s/10s/20s, reusing `MAX_SCHEDULED_REFRESH_RETRIES`), reusing `unifiedRefreshTimerId` so `clearUnifiedContext()` still cancels pending retries. Permanent-failure teardown behavior is unchanged. - **What**: `remintUnifiedOnce()` (the reactive 401 re-mint) now calls `notifyTokenRefreshed()` on success, so cookie rotation rides the same recovery path as API traffic instead of waiting for the next scheduled refresh. `useSessionCookie` already serializes/dedupes concurrent creates. - Retry counter resets on every successful mint (`scheduleUnifiedRefresh`) and on context teardown (`clearUnifiedContext`). ## AS IS / TO BE - AS IS: after one missed proactive refresh, API traffic self-heals via reactive re-mint but the session cookie never rotates again until the next scheduled refresh or a reload — image loads 401 for up to ~85 minutes. - TO BE: transient refresh failures retry within seconds; even if retries exhaust, the first reactive re-mint (any 401'd API call) rotates the cookie, so image loads recover together with API traffic. No UI change, so no app screenshots; the failure is a timing window (2h+ session + one failed refresh) reproducible only by forcing token-endpoint failures. The regression is covered by unit tests instead. ## Regression tests - `bumps the rotation trigger on a successful reactive re-mint` - `retries a transiently failed proactive refresh with backoff and rotates on success` (also asserts the normal schedule re-arms) - `bounds refresh retries and keeps the slot for reactive recovery` (no toast, slot preserved, no unbounded retry loop) - Existing suites unchanged and green: `useWorkspaceAuth.test.ts` (93), `remintRetry.test.ts` + `authStore.test.ts` + `useSessionCookie.test.ts` (140) ## Review Focus - `remintUnifiedOnce` can be invoked by concurrent 401 replays; each success bumps the rotation trigger, relying on `useSessionCookie`'s in-flight dedupe — confirm that's acceptable vs. gating the bump. - Retry backoff base (5s) is a judgment call for post-wake/network-blip recovery; the cap (3) mirrors the legacy scheduled-retry bound. Fixes FE-1595 (linear.app/comfyorg/issue/FE-1595)
…lures (#16072) ## Summary Follow-up to #16063: the unified-auth incident (FE-1595) was invisible in telemetry — every path that killed image loads only `console.warn`ed. This instruments the lifecycle so the fix's effect is measurable and a recurrence alerts instead of waiting on customer reports. ## Why this is needed Diagnosing FE-1595 required the artist's Network tab because none of the failing seams emit telemetry: - The proactive `refreshUnified()` failure — the moment the session-cookie rotation chain dies — was `console.warn` only. - Session-cookie creation failure (`useSessionCookie.createSession`) was swallowed with a warn; that cookie is the only credential `<img>`/media loads carry. - The user-facing symptom itself (`ImagePreview` load error) set local state only, so affected-user counts were unknowable. - `trackUnifiedAuthRetry` covered only axios/fetch transports and only reached Datadog RUM, so PostHog could not query or alert on any of it. ## Changes - **What**: `trackUnifiedAuthRefresh` lifecycle event (`succeeded` / `retry_scheduled` / `retries_exhausted` / `permanent_failure`, with `retry_count`) emitted from `refreshUnified()`; measures the retry/backoff added in #16063. - **What**: `reportError(..., { errorType: 'session_cookie_creation_failure' })` on swallowed `createSession` failures (dual-sink per repo convention). - **What**: `trackImageLoadFailed({ source: 'node_image_preview' })` from `ImagePreview`'s error handler — no filenames/PII, source tag only. - **What**: `'ws'` transport + `'token_unavailable'` reason on `UnifiedAuthRetryMetadata`, emitted when WebSocket connect cannot obtain a token under unified auth. - **What**: PostHog provider now implements `trackUnifiedAuthRetry`/`trackUnifiedAuthRefresh` (previously Datadog-only), enabling PostHog queries and alerts. ## Review Focus - Event volume: `auth.unified.refresh.succeeded` fires ~once per 85min per active session; `app:image_load_failed` fires per failed `<img>` render in node previews. Both go to Datadog actions; only the unified-auth events go to PostHog. - `retry_count` is attached to non-succeeded outcomes only. ## Tests - Refresh lifecycle outcomes asserted across the existing retry/backoff/permanent-failure store tests. - `session_cookie_creation_failure` report on swallowed createSession failure. - Image-error telemetry asserted in the existing ImagePreview failure test. - Both providers' new methods covered. 216 tests green across the five touched suites; typecheck/lint/knip clean. No UI change (telemetry only), so no screenshots. Related: FE-1595 (linear.app/comfyorg/issue/FE-1595)
|
|
|
|
|
|
…r tracker (Comfy-Org#18701) Follow-up to Comfy-Org#16072 (FE-1595). Independent of Comfy-Org#18698/Comfy-Org#18699 — based on `main`. ## The gap The two outcomes that end the session-cookie rotation chain were a `console.warn` plus a RUM action: ```ts if (report.outcome === 'retries_exhausted') { trackUnifiedRefresh('retries_exhausted') console.warn('Unified token refresh failed; retries exhausted, …') return } … trackUnifiedRefresh('permanent_failure') ``` **A RUM action cannot raise a Sentry alert**, and Sentry is where new-issue alerting is actually wired (`[{{issue.alert_reason}}] New issue to review`). Confirmed against production: the full `error_type` inventory on `cloud-frontend-prod` contains no mint, retry, or refresh failure type at all — only `workspace_auth_gate_initialization_failure`, `bootstrap_auth_wait_timeout`, `session_cookie_creation_failure`, and `agent_cloud_workflow_ids_refresh_failed`. So these could fire indefinitely and produce nothing that pages anyone. They did. ## Why `retries_exhausted` specifically matters It is the **precursor** to FE-1595, not the symptom. The proactive refresh is the only thing that rotates the session cookie, so this fires roughly **two hours before** a user sees a broken image — while every Bearer-authenticated call keeps working normally. That asymmetry is precisely what made the bug read as "images are broken but everything else is fine", and why the reported symptom was so hard to connect to auth. Alerting on this fires before any customer notices. It is also rare enough to be a good alert rather than noise: over 21 days of production RUM, `retries_exhausted` was **3 of 290** refresh-failure outcomes (1.0%), against 200 `retry_scheduled` (69%) — i.e. Comfy-Org#16063's retry is doing its job and this is now the genuine tail. ## The change Both outcomes go through `reportError`, which fans out to Sentry and Datadog RUM together. New error types: - `unified_auth_refresh_retries_exhausted` (tagged `retry_count`) - `unified_auth_refresh_permanent_failure` (tagged `failure_code`, `retry_count`) `reportError` writes the console line itself, so the paired `console.warn` is dropped rather than duplicated — per its own contract that callers never pair it with a console call of their own. ## Test plan - [x] `useWorkspaceAuth.test.ts` — 113 pass. The existing `retries_exhausted` and `permanent_failure` cases now also assert the `reportError` call and its tags, so the reporting is covered by the tests that already drive those outcomes rather than by new scaffolding. ## Note for whoever wires the monitor `unified_auth_refresh_retries_exhausted` is the one to alert on. It is the earliest honest signal that the cookie rail has stopped rotating, and at ~3 events per 21 days it will not be noisy. --------- Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Amp <amp@ampcode.com>
Summary
Fixes intermittent "Image failed to load / Image does not exist" on Cloud (FE-1595, also reported by an enterprise pilot): under
unified_cloud_auth, one transient token-refresh failure permanently stops session-cookie rotation, so<img>-based previews and asset thumbnails break while jobs keep running.Why this is needed / Root cause
Node previews and Media Assets thumbnails load through plain
<img src="/api/view?...">tags. An<img>request cannot carry anAuthorizationheader, so those loads are authenticated solely by the 2-hour Firebase session cookie (services/ingest/server/implementation/auth.goin cloud).Before unified auth, the cookie was re-minted on every Firebase
onIdTokenChanged(~hourly, with the Firebase SDK's built-in retries). Underunified_cloud_auth(100% since Jul 31) that driver is intentionally gated off inauthStore.ts, and rotation is driven only by the proactive unified refresh:This matches the reported shape exactly: job completes and bills normally (Bearer-authenticated API/WS), only image loads fail; only sessions open longer than 2h are affected (reload mints a fresh cookie); it self-heals when a later refresh lands — hence "worked fine last week" and Rob's "resolved itself after a few minutes".
How we change it
Two seams in
workspaceAuthStore.ts, both flag-gated inside the existing unified lifecycle (legacy path untouched):refreshUnified()now re-arms itself after a transient failure viascheduleUnifiedRefreshRetry()— bounded exponential backoff (5s/10s/20s, reusingMAX_SCHEDULED_REFRESH_RETRIES), reusingunifiedRefreshTimerIdsoclearUnifiedContext()still cancels pending retries. Permanent-failure teardown behavior is unchanged.remintUnifiedOnce()(the reactive 401 re-mint) now callsnotifyTokenRefreshed()on success, so cookie rotation rides the same recovery path as API traffic instead of waiting for the next scheduled refresh.useSessionCookiealready serializes/dedupes concurrent creates.scheduleUnifiedRefresh) and on context teardown (clearUnifiedContext).AS IS / TO BE
No UI change, so no app screenshots; the failure is a timing window (2h+ session + one failed refresh) reproducible only by forcing token-endpoint failures. The regression is covered by unit tests instead.
Regression tests
bumps the rotation trigger on a successful reactive re-mintretries a transiently failed proactive refresh with backoff and rotates on success(also asserts the normal schedule re-arms)bounds refresh retries and keeps the slot for reactive recovery(no toast, slot preserved, no unbounded retry loop)useWorkspaceAuth.test.ts(93),remintRetry.test.ts+authStore.test.ts+useSessionCookie.test.ts(140)Review Focus
remintUnifiedOncecan be invoked by concurrent 401 replays; each success bumps the rotation trigger, relying onuseSessionCookie's in-flight dedupe — confirm that's acceptable vs. gating the bump.Fixes FE-1595 (linear.app/comfyorg/issue/FE-1595)