Skip to content

[backport cloud/1.52] fix(billing): price legacy subscription previews from the server costs - #16825

Merged
comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16517-to-cloud-1.52
Sep 3, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16517-to-cloud-1.52

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16517 to cloud/1.52

Automatically created by backport workflow.

#16517)

## Summary

The subscription confirm screens rendered no amount at all whenever
embedded checkout was off — a blank "Total due today" on new
subscriptions and "Unavailable" on plan changes. Resolve the amount from
the legacy cost fields the server always sends.

## Changes

- **What**: `formatAmountDueToday` / `formatRenewalAmount` /
`resolveRenewalDate` in `subscriptionQuoteFormatting.ts` resolve each
figure from the exact quote when the server sent one and from the
always-present legacy costs otherwise.
`SubscriptionAddPaymentPreviewWorkspace` and
`SubscriptionTransitionPreviewWorkspace` consume them. New
`subscription.preview.renewsAtAmount` message for the case where the
server supplies an amount but no renewal date.

### Root cause

#14483 ("consolidate embedded checkout frontend") rewrote both quote
computeds to read only the embedded-checkout field family:

```ts
const totalDueToday = computed(() =>
  previewData?.amount_due_cents === undefined ? '' : formatQuoteMoney(...)
)
```

`POST /api/billing/preview-subscribe` returns two different shapes.
`packages/ingest-types` documents the split on the sibling field:
`payment_method_configuration_id` is *"Present on every successful
preview while embedded checkout is enabled and absent from legacy
previews."* The same holds for the whole family:

| field | contract | legacy preview |
| --- | --- | --- |
| `amount_due_cents`, `currency` | optional | absent |
| `renewal_amount_cents`, `renewal_at` | optional | absent |
| `cost_today_cents`, `cost_next_period_cents` | **required** |
**present** |

So with the flag off, `amount_due_cents` is `undefined` and
`totalDueToday` short-circuits to `''`.
`SubscriptionTransitionPreviewWorkspace` falls through to
`subscription.preview.quoteUnavailable` and prints "Unavailable" twice.

Two things widen the blast radius beyond "someone turned the flag off":

- `embeddedCheckoutEnabled` resolves **fail-closed**
(`resolveFailClosedBooleanFlag`), so a flag that cannot be read is
treated as off and takes this same path.
- `formatQuoteMoney` returns `''` when `currency` is missing, so even
reading `cost_today_cents` while passing the absent `currency` through
would still render blank.

Note the branch here is on the **response shape**, not on the
`embeddedCheckoutEnabled` prop. The shape is what the contract actually
guarantees, it needs no prop threaded into
`SubscriptionTransitionPreviewWorkspace`, and it stays correct if the
flag is on while the backend still serves a legacy preview.
`chargeCents` in the same component already branched this way
(`amount_due_cents ?? cost_today_cents`) — the consolidation just missed
the display computeds.

The renewal **date** is deliberately not synthesized.
`PreviewPlanInfo.period_end` is documented "only for current_plan" and
is absent on a new-subscription preview, so the legacy path shows the
server-provided renewal amount without inventing a date.

## Review Focus

- `LEGACY_QUOTE_CURRENCY = 'usd'` is the one assumption added. The
legacy rail carries no `currency` field because it prices in USD; this
keeps that assumption in a single named constant instead of at each call
site.
- `SubscriptionTransitionPreviewWorkspaceReactivation.test.ts` had a
test asserting "Unavailable" appeared twice for a preview with no exact
quote. That test codified this bug, so it now asserts the legacy amount
renders.
- `cloudSubscribeDeepLink.spec.ts` already drove a legacy-shaped preview
through the real checkout but only asserted the heading, which is how
this reached QA. It now asserts the total.

## Tests

- 8 unit tests on the pure resolvers (exact quote, legacy fallback,
non-USD, missing date)
- 3 component regression tests; verified they fail without the fix and
pass with it
- 1 E2E assertion on the existing flag-off deep-link spec

## Screenshots

Captured in the running app (cloud distribution,
`embedded_checked_enabled` off) — posting them in a follow-up comment.

<!-- Supersedes #16515, which fixes the same bug by branching on the
flag prop and drops the renewal line when the server sends no date. -->
@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1977 passed, 0 failed · 6 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1956 / ❌ 0 / ⚠️ 6 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 07:34:30 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 124ms TBT · 83.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.6 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 116ms TBT · 166.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 525ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.3 MB
canvas-idle: DOM nodes -283
canvas-idle: event listeners -166
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 986ms
canvas-mouse-sweep: script duration 114ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.9 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -168
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 375ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 62.4 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 373ms
dom-widget-clipping: script duration 56ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.3 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 642ms
large-graph-idle: script duration 17ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 69.1 MB
large-graph-idle: DOM nodes -279
large-graph-idle: event listeners -149
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1240ms
large-graph-pan: script duration 334ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 66.7 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -148
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 9ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1452ms
large-graph-zoom: script duration 400ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 65.0 MB
large-graph-zoom: DOM nodes -288
large-graph-zoom: event listeners -154
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1501ms
legacy-node-drag: script duration 481ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 66.8 MB
legacy-node-drag: DOM nodes 11
legacy-node-drag: event listeners 185
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 639ms
minimap-idle: script duration 16ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.4 MB
minimap-idle: DOM nodes -277
minimap-idle: event listeners -148
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 392ms
subgraph-dom-widget-clipping: script duration 121ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.0 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 498ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 76.9 MB
subgraph-idle: DOM nodes -280
subgraph-idle: event listeners -151
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 38ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 73
subgraph-mouse-sweep: task duration 825ms
subgraph-mouse-sweep: script duration 89ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 70.4 MB
subgraph-mouse-sweep: DOM nodes -284
subgraph-mouse-sweep: event listeners -167
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 13
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 949ms
subgraph-transition-enter: script duration 17ms
subgraph-transition-enter: TBT 124ms
subgraph-transition-enter: heap used 83.3 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 45ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4257ms
viewport-pan-sweep: script duration 986ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.8 MB
viewport-pan-sweep: DOM nodes -277
viewport-pan-sweep: event listeners -132
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17647ms
vue-large-graph-idle: script duration 131ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 161.6 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16391
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 22ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 179
vue-large-graph-pan: task duration 21999ms
vue-large-graph-pan: script duration 429ms
vue-large-graph-pan: TBT 116ms
vue-large-graph-pan: heap used 166.1 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16386
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 3
workflow-execution: style recalc count 19
workflow-execution: task duration 124ms
workflow-execution: script duration 14ms
workflow-execution: TBT 0ms
workflow-execution: heap used 64.7 MB
workflow-execution: DOM nodes 145
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-09-03T19:46:46.405Z",
  "gitSha": "c91f90d8af5b0df323e05f3b9a6869baf965d79b",
  "branch": "backport-16517-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2082.6700000000073,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 527.125,
      "heapDeltaBytes": -1660940,
      "heapUsedBytes": 60154884,
      "domNodes": -283,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.261,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2050.707000000102,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.606999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 523.145,
      "heapDeltaBytes": 15381824,
      "heapUsedBytes": 76824312,
      "domNodes": -282,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.265999999999998,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2076.2139999999363,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 46.519,
      "layouts": 12,
      "layoutDurationMs": 5.726,
      "taskDurationMs": 1074.332,
      "heapDeltaBytes": 5899928,
      "heapUsedBytes": 68561308,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 117.69200000000001,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1856.2460000000556,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 40.482,
      "layouts": 12,
      "layoutDurationMs": 3.732999999999999,
      "taskDurationMs": 898.2779999999999,
      "heapDeltaBytes": -5863824,
      "heapUsedBytes": 57032268,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 111.14600000000002,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1757.0100000000366,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.287999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.7380000000000002,
      "taskDurationMs": 378.66099999999994,
      "heapDeltaBytes": 3412984,
      "heapUsedBytes": 65540828,
      "domNodes": 76,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 10.232000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1688.846999999896,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.582,
      "layouts": 6,
      "layoutDurationMs": 0.831,
      "taskDurationMs": 371.344,
      "heapDeltaBytes": 3375472,
      "heapUsedBytes": 65264336,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.848999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 575.823000000014,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.941,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 373.754,
      "heapDeltaBytes": 10862576,
      "heapUsedBytes": 73806280,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 56.261,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 579.1730000000825,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.892999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 372.05499999999995,
      "heapDeltaBytes": 10615324,
      "heapUsedBytes": 73665044,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 55.571,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.2940000000035,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.248000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 660.1510000000001,
      "heapDeltaBytes": -4063012,
      "heapUsedBytes": 73470892,
      "domNodes": -275,
      "jsHeapTotalBytes": -1843200,
      "scriptDurationMs": 17.208,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.7650000000122,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.399000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 623.7409999999999,
      "heapDeltaBytes": -5893052,
      "heapUsedBytes": 71389076,
      "domNodes": -283,
      "jsHeapTotalBytes": -1843200,
      "scriptDurationMs": 16.369000000000003,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2181.6929999999957,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.953000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1219.9009999999998,
      "heapDeltaBytes": -8085984,
      "heapUsedBytes": 70080816,
      "domNodes": -283,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 324.739,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2165.238000000045,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 15.165000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1259.101,
      "heapDeltaBytes": -8482848,
      "heapUsedBytes": 69862372,
      "domNodes": -283,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 344.24100000000004,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3202.8869999999188,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.261000000000005,
      "layouts": 60,
      "layoutDurationMs": 8.511000000000001,
      "taskDurationMs": 1455.098,
      "heapDeltaBytes": -11296000,
      "heapUsedBytes": 68212420,
      "domNodes": -286,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 404.51300000000003,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3213.309999999865,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.589000000000002,
      "layouts": 60,
      "layoutDurationMs": 8.582,
      "taskDurationMs": 1448.7830000000001,
      "heapDeltaBytes": -11187748,
      "heapUsedBytes": 68183136,
      "domNodes": -289,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 396.048,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2247.3830000000135,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.744999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1502.0169999999998,
      "heapDeltaBytes": -15359712,
      "heapUsedBytes": 70180344,
      "domNodes": 10,
      "jsHeapTotalBytes": 8163328,
      "scriptDurationMs": 484.961,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2370.245000000068,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.691000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1500.051,
      "heapDeltaBytes": -17446256,
      "heapUsedBytes": 69900480,
      "domNodes": 12,
      "jsHeapTotalBytes": 9736192,
      "scriptDurationMs": 476.87,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2070.461000000023,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.5169999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 659.2769999999999,
      "heapDeltaBytes": -11791752,
      "heapUsedBytes": 71607048,
      "domNodes": -282,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 17.631000000000004,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2058.230999999978,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.633999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 618.309,
      "heapDeltaBytes": -2514236,
      "heapUsedBytes": 76137088,
      "domNodes": -272,
      "jsHeapTotalBytes": -1056768,
      "scriptDurationMs": 14.792999999999997,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 592.9620000001705,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.270000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 393.61299999999994,
      "heapDeltaBytes": 11961212,
      "heapUsedBytes": 74441512,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 121.887,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 591.2140000000363,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.19,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 390.059,
      "heapDeltaBytes": 12016084,
      "heapUsedBytes": 74477584,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 119.70800000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2036.8819999999914,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.376,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.71200000000005,
      "heapDeltaBytes": 18694400,
      "heapUsedBytes": 80898376,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.222999999999998,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.3780000001407,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.926,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.174,
      "heapDeltaBytes": 17822416,
      "heapUsedBytes": 80359448,
      "domNodes": -279,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 7.137,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1739.3879999999626,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 38.998000000000005,
      "layouts": 16,
      "layoutDurationMs": 4.767,
      "taskDurationMs": 829.2239999999999,
      "heapDeltaBytes": 19190396,
      "heapUsedBytes": 81842144,
      "domNodes": -283,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 88.46100000000001,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1718.4429999999793,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 36.406,
      "layouts": 16,
      "layoutDurationMs": 4.871,
      "taskDurationMs": 820.168,
      "heapDeltaBytes": 2699068,
      "heapUsedBytes": 65761424,
      "domNodes": -285,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 89.10799999999999,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1367.9560000000492,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.475,
      "layouts": 13,
      "layoutDurationMs": 13.256,
      "taskDurationMs": 948.6580000000002,
      "heapDeltaBytes": -4099316,
      "heapUsedBytes": 87309128,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 17.056999999999995,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 124,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8252.49400000007,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 42.805,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4269.385,
      "heapDeltaBytes": -1859748,
      "heapUsedBytes": 74727752,
      "domNodes": -282,
      "jsHeapTotalBytes": -307200,
      "scriptDurationMs": 995.8750000000001,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8213.052999999945,
      "styleRecalcs": 252,
      "styleRecalcDurationMs": 47.154,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4245.019,
      "heapDeltaBytes": 2509088,
      "heapUsedBytes": 80123712,
      "domNodes": -272,
      "jsHeapTotalBytes": -569344,
      "scriptDurationMs": 976.938,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18610.65500000018,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17683.39,
      "heapDeltaBytes": -69631824,
      "heapUsedBytes": 162881272,
      "domNodes": -8312,
      "jsHeapTotalBytes": -22994944,
      "scriptDurationMs": 132.52200000000002,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18650.86199999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17611.265,
      "heapDeltaBytes": -36569168,
      "heapUsedBytes": 176079612,
      "domNodes": -8312,
      "jsHeapTotalBytes": -22106112,
      "scriptDurationMs": 129.95299999999997,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22632.87999999989,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 21.68500000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21965.000000000004,
      "heapDeltaBytes": -51804288,
      "heapUsedBytes": 173603584,
      "domNodes": -8312,
      "jsHeapTotalBytes": -17604608,
      "scriptDurationMs": 443.315,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 74,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22714.476999999988,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 21.91800000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22033.933999999997,
      "heapDeltaBytes": -56248172,
      "heapUsedBytes": 174718112,
      "domNodes": -8312,
      "jsHeapTotalBytes": -22093824,
      "scriptDurationMs": 414.327,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 157,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 486.7150000000038,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 23.925,
      "layouts": 3,
      "layoutDurationMs": 1.3380000000000003,
      "taskDurationMs": 129.559,
      "heapDeltaBytes": 5300032,
      "heapUsedBytes": 67816728,
      "domNodes": 146,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 15.023000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 485.7529999999315,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 20.683,
      "layouts": 3,
      "layoutDurationMs": 1.3479999999999999,
      "taskDurationMs": 119.416,
      "heapDeltaBytes": 5229648,
      "heapUsedBytes": 67937104,
      "domNodes": 143,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 12.962000000000002,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 46444 68776 67.5% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.4% 1212
src/LGraphNode.ts 64.3% 464
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/LGraph.ts 73.0% 312
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 38.0% 258
src/scripts/app.ts 71.2% 241
src/scripts/pnginfo.ts 21.5% 219
src/stores/assetsStore.ts 45.0% 203

@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff               @@
##           cloud/1.52   #16825      +/-   ##
==============================================
+ Coverage       79.68%   82.06%   +2.37%     
==============================================
  Files            2243     1913     -330     
  Lines          115301   110303    -4998     
  Branches        33470    32280    -1190     
==============================================
- Hits            91877    90519    -1358     
+ Misses          22929    19444    -3485     
+ Partials          495      340     -155     
Flag Coverage Δ
e2e 66.03% <ø> (-0.09%) ⬇️
unit 74.12% <ø> (ø)
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 351 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot added this pull request to the merge queue Sep 3, 2026
Merged via the queue into cloud/1.52 with commit 1bfb04e Sep 3, 2026
89 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16517-to-cloud-1.52 branch September 3, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants