Repository navigation
feat(agent): add dev panel clipboard controls - #16666
christian-byrne wants to merge 3 commits into
Conversation
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Comment |
🎭 Playwright: ❌ 1888 passed, 53 failed · 11 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-02T15:49:38.388Z",
"gitSha": "f72c8772e34026f769ed4496e0e357b728d6545d",
"branch": "christian-byrne/fec-copy-1-clipboard",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.9240000000318,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.279,
"heapDeltaBytes": 2640680,
"heapUsedBytes": 98605072,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.677,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2049.1480000000593,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.815999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.307,
"heapDeltaBytes": 2911148,
"heapUsedBytes": 98377260,
"domNodes": 14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.24,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2241.7709999999715,
"styleRecalcs": 82,
"styleRecalcDurationMs": 54.647999999999996,
"layouts": 14,
"layoutDurationMs": 5.441,
"taskDurationMs": 1245.128,
"heapDeltaBytes": -7128304,
"heapUsedBytes": 88849936,
"domNodes": 65,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 153.45000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2194.994999999949,
"styleRecalcs": 82,
"styleRecalcDurationMs": 48.63000000000001,
"layouts": 14,
"layoutDurationMs": 5.489,
"taskDurationMs": 1223.7500000000002,
"heapDeltaBytes": -7024024,
"heapUsedBytes": 89073116,
"domNodes": 63,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 157.385,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.2920000000058,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.199,
"layouts": 6,
"layoutDurationMs": 1.2220000000000002,
"taskDurationMs": 429.04699999999997,
"heapDeltaBytes": 5441288,
"heapUsedBytes": 102296680,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 15.1,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.5549999999057,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.186,
"layouts": 6,
"layoutDurationMs": 1.2630000000000001,
"taskDurationMs": 385.407,
"heapDeltaBytes": 5911296,
"heapUsedBytes": 102490060,
"domNodes": 76,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 13.271999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 969.0789999999652,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.788999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 704.9559999999999,
"heapDeltaBytes": 7291404,
"heapUsedBytes": 103828388,
"domNodes": 14,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 144.974,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 957.2809999999663,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.813,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 703.085,
"heapDeltaBytes": 7279984,
"heapUsedBytes": 104021336,
"domNodes": 12,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 147.01699999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2017.9300000000353,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.785999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.1610000000001,
"heapDeltaBytes": 16757136,
"heapUsedBytes": 120672312,
"domNodes": 8,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 40.00300000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2018.8640000000078,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.815999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.5350000000001,
"heapDeltaBytes": 16832336,
"heapUsedBytes": 121059848,
"domNodes": 10,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 44.588,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3270.8240000000046,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.320000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2558.4139999999998,
"heapDeltaBytes": -6557752,
"heapUsedBytes": 98368316,
"domNodes": 8,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 892.2900000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3274.744999999939,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.106,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2554.396,
"heapDeltaBytes": -6906900,
"heapUsedBytes": 98550244,
"domNodes": 6,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 889.5999999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4439.502000000004,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.215000000000002,
"layouts": 60,
"layoutDurationMs": 15.761999999999999,
"taskDurationMs": 2644.2230000000004,
"heapDeltaBytes": 10567548,
"heapUsedBytes": 120897796,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 883.343,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4491.6840000000775,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.321,
"layouts": 60,
"layoutDurationMs": 15.254999999999999,
"taskDurationMs": 2644.912,
"heapDeltaBytes": 4046688,
"heapUsedBytes": 113220676,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 891.2919999999999,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 4924.547999999959,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.2490000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3722.8079999999995,
"heapDeltaBytes": 18347988,
"heapUsedBytes": 130237928,
"domNodes": 0,
"jsHeapTotalBytes": 6709248,
"scriptDurationMs": 1013.582,
"eventListeners": 192,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 4905.197000000044,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.338,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3736.524,
"heapDeltaBytes": 17494064,
"heapUsedBytes": 129978532,
"domNodes": 2,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 1010.123,
"eventListeners": 192,
"totalBlockingTimeMs": 5,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1993.295000000046,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.138999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.2909999999999,
"heapDeltaBytes": -9912332,
"heapUsedBytes": 96445732,
"domNodes": 8,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 38.175999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.8520000000517,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.902000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.1320000000001,
"heapDeltaBytes": -9446252,
"heapUsedBytes": 96482404,
"domNodes": 6,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 44.67399999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 795.7319999999868,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.58,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.0609999999999,
"heapDeltaBytes": -5842776,
"heapUsedBytes": 91810176,
"domNodes": 20,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 148.82299999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 748.9380000000665,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.684000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.184,
"heapDeltaBytes": -5900700,
"heapUsedBytes": 91636944,
"domNodes": 18,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 146.728,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.5090000000037,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.572,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.4709999999999,
"heapDeltaBytes": 3024852,
"heapUsedBytes": 99858928,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 9.768999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.4989999999625,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.741999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.05600000000004,
"heapDeltaBytes": 2830928,
"heapUsedBytes": 99612476,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 9.484,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1874.416999999994,
"styleRecalcs": 80,
"styleRecalcDurationMs": 44.919000000000004,
"layouts": 18,
"layoutDurationMs": 6.6,
"taskDurationMs": 1133.528,
"heapDeltaBytes": 6613300,
"heapUsedBytes": 104303392,
"domNodes": 68,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 118.05799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1922.4879999999303,
"styleRecalcs": 82,
"styleRecalcDurationMs": 52.55800000000001,
"layouts": 18,
"layoutDurationMs": 6.6770000000000005,
"taskDurationMs": 1149.825,
"heapDeltaBytes": 6587940,
"heapUsedBytes": 104098192,
"domNodes": 71,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 115.482,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.5910000000295,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.237000000000002,
"layouts": 15,
"layoutDurationMs": 12.938999999999998,
"taskDurationMs": 978.4360000000003,
"heapDeltaBytes": 22576612,
"heapUsedBytes": 116649536,
"domNodes": 13671,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 36.064,
"eventListeners": 2383,
"totalBlockingTimeMs": 126,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12458.56900000001,
"styleRecalcs": 246,
"styleRecalcDurationMs": 43.37,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9056.064,
"heapDeltaBytes": -13201268,
"heapUsedBytes": 90140800,
"domNodes": -282,
"jsHeapTotalBytes": -1945600,
"scriptDurationMs": 2985.883,
"eventListeners": -141,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12494.020999999975,
"styleRecalcs": 245,
"styleRecalcDurationMs": 44.004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9264.256,
"heapDeltaBytes": 5887544,
"heapUsedBytes": 109465292,
"domNodes": -283,
"jsHeapTotalBytes": -1490944,
"scriptDurationMs": 3043.925,
"eventListeners": -171,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19469.82800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19009.894000000004,
"heapDeltaBytes": -16598640,
"heapUsedBytes": 215177496,
"domNodes": -6548,
"jsHeapTotalBytes": 15548416,
"scriptDurationMs": 380.24499999999995,
"eventListeners": -7453,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19330.705999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18847.625,
"heapDeltaBytes": -31874328,
"heapUsedBytes": 198961520,
"domNodes": -6548,
"jsHeapTotalBytes": 6230016,
"scriptDurationMs": 382.945,
"eventListeners": -7453,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 24603.456999999937,
"styleRecalcs": 182,
"styleRecalcDurationMs": 26.58100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24475.448999999997,
"heapDeltaBytes": -25477656,
"heapUsedBytes": 200114688,
"domNodes": -6548,
"jsHeapTotalBytes": 13189120,
"scriptDurationMs": 993.076,
"eventListeners": -7443,
"totalBlockingTimeMs": 168,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 24720.462999999996,
"styleRecalcs": 182,
"styleRecalcDurationMs": 26.320999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24457.616,
"heapDeltaBytes": -17097940,
"heapUsedBytes": 214150848,
"domNodes": -6548,
"jsHeapTotalBytes": 7995392,
"scriptDurationMs": 965.279,
"eventListeners": -7443,
"totalBlockingTimeMs": 177,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 479.02399999998124,
"styleRecalcs": 17,
"styleRecalcDurationMs": 32.236000000000004,
"layouts": 4,
"layoutDurationMs": 1.8760000000000001,
"taskDurationMs": 152.154,
"heapDeltaBytes": 5735892,
"heapUsedBytes": 99192332,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.115999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 156.93199999998342,
"styleRecalcs": 9,
"styleRecalcDurationMs": 20.491999999999997,
"layouts": 3,
"layoutDurationMs": 1.9130000000000003,
"taskDurationMs": 122.443,
"heapDeltaBytes": 3832880,
"heapUsedBytes": 96828720,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.027000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/agent-panel-v1 #16666 +/- ##
============================================================
+ Coverage 80.67% 83.04% +2.37%
============================================================
Files 2339 2009 -330
Lines 120790 115792 -4998
Branches 35560 33337 -2223
============================================================
- Hits 97444 96162 -1282
+ Misses 22849 19288 -3561
+ Partials 497 342 -155
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 350 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed head bbe3429 against nathaniel/agent-panel-v1 (three-dot diff, 3 files). The controls work as described and the tests pin the payloads. Three things worth changing before this lands, in order of weight: the per-event copy hands back the truncated excerpt rather than the full detail, the template re-stringifies each detail three times per row on every re-render, and the new per-item buttons give no feedback so they look broken in a non-secure (plain http) context where navigator.clipboard is undefined. One nitpick on an unrelated formatting hunk pulled in by the automated commit.
Full context for agent readers
Verified: doc_nodes_changed ids are strings and added/removed are disjoint (useAgentCrdtFollower.ts L162-L251), so the node-id filter and v-for keys are sound. Existing crdt suite 10 files / 69 tests green on head. fmtDetail truncates at 200 chars with an ellipsis; the copy button forwards that same string. processedWidgetRenderModel.ts hunk is trailing-comma removal from the [automated] ESLint/Oxfmt commit, also present on #16659, not from this change.
Address review on #16666: - The per-row copy button now writes the full stringified detail (same Uint8Array replacer) instead of the 200-char on-screen excerpt, which was truncated exactly when a copy was most useful. - Build a LogRow view model once in the computed so each row's detail is stringified once per render instead of three times per binding. - Track the last successful per-item copy in copiedKey and flip that button's label to Copied for 1200 ms, matching Copy JSON; failures (e.g. navigator.clipboard undefined on plain-http origins) leave the label unchanged. Timer is cleared on unmount. Tests cover the full payload, the truncated excerpt display, the transient feedback, and the no-feedback-on-failure path.
|
Pushed Full context for agent readersCommit |
|
CI on 1b9583c: unit tests and lint green. Playwright failures (cloud |
CodeJuggernaut
left a comment
There was a problem hiding this comment.
The copy controls read the stored redacted values, so nothing can leak past the redaction; no issues.
|
Severity: Minor What: Why this is an issue: Unmount within 1200ms fires against a disposed component; the two copy timers follow opposite disciplines. Proposed Fix: Store and clear it with |
|
Severity: Minor (PR description) What: Review Focus asks to confirm the copied payload matches the 200-character excerpt, but the head copies the full detail (test at Why this is an issue: A reviewer following the body files a false defect. Proposed Fix: Reword to the full-detail behaviour. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 3 |
| 🟢 Low | 5 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
|
Re-carried onto Full context for agent readersThe new PR preserves document-ID, full-detail, and node-ID copying, includes transient success feedback, and keeps failed writes from showing success. It also incorporates the earlier timer-cleanup and PR-description review feedback. The unrelated |
## Summary Re-carry the CRDT dev panel clipboard controls from #16666 onto the current main-based panel. ## Changes - **What**: Add copy controls for the document ID, full event details, and node IDs surfaced by `doc_nodes_changed`, with per-button success and failure feedback. - **What**: Change collapsed event details from main's 400-character, two-line-clamped view to a capped 200-character excerpt. Keep the 20,000-character expanded display limit while copying the full untruncated detail. - **What**: Keep filtered full-log copying and the current report collector behavior unchanged. ## Current scope and contract - **Why this remains wanted**: Development-only CRDT observability needs copyable document IDs, full event details, and node IDs so testers and operators can correlate and share gap, reset, and drop evidence. - **TDD mapping**: Serves [`docs/DEV-SETUP.md` §3, S5 / `CRDT-RM-5`](https://github.com/christian-byrne/in-app-agent-program/blob/main/docs/DEV-SETUP.md#3-in-app-debugging): latency/performance and observability, including gap/reset/drop metrics. - **Preserved invariants**: This is presentation and clipboard behavior only. It adds no shared-document write, op minting, transport, persistence, mutation, or authority seam. Raw Yjs updates remain host-to-follower only; presence remains ephemeral; layout remains separate from the semantic document; optimistic overlays remain presentation-only. Filtered full-log copying and report collection remain unchanged. ## Review Focus Confirm individual detail copies contain the full untruncated value, failed clipboard writes show failure feedback, and collapsed rows use the intentional 200-character excerpt. Supersedes #16666. Original implementation and review fix by Christian Byrne in `118958f3e9` and `1b9583c8c1`; adapted to the current panel structure on `main`. ## Evidence - Rebased onto `main` at `fdcc06bbaa3d263cdd5fc1a1541d9a68e5a6c642`; GitHub compare reports `behind_by: 0` for head `082063a4cc8e88899c496df78c20dee1b74ff9bc`. - `pnpm test:unit src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts` — 2 files, 17 tests passed at the rebased head. - `pnpm exec eslint src/workbench/extensions/agent/crdt/CrdtDevPanel.vue src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts` — passed at the rebased head. - Commit hook: Oxfmt, Stylelint, type-aware Oxlint, ESLint, `pnpm typecheck` — passed. - Push hook: `pnpm knip --cache` — passed. - `git diff origin/main -- src/renderer/extensions/vueNodes/composables/processedWidgetRenderModel.ts` — empty; the frozen-base formatter hunk was not carried. <!-- authored-by:agent lane-prbase-7-0357 --> <!-- authored-by:agent lane-prbase-7-0623 -->
## Summary Follow up merged [frontend Comfy-Org#16927](Comfy-Org#16927) and closed [frontend Comfy-Org#16666](Comfy-Org#16666) by addressing all eight remaining review findings in the CRDT dev-panel copy controls. - Deduplicate and cap node-ID controls at 50 with a remaining-count indicator. - Serialize circular and bigint details losslessly, bound retained detail strings to 20,000 code points, and truncate excerpts without splitting Unicode code points. - Show a constant placeholder when a detail can be neither serialized nor stringified, so one bad detail cannot blank the log tab. - Make copy feedback latest-request-wins, which also discards writes that settle after unmount. Hostile getters and iterators on `doc_nodes_changed` lists are no longer handled in the panel: since Comfy-Org#16926, `recordDevEvent` rebuilds every detail as plain data before the panel reads it. Source review threads on [frontend Comfy-Org#16666](Comfy-Org#16666): [one](Comfy-Org#16666 (comment)), [two](Comfy-Org#16666 (comment)), [three](Comfy-Org#16666 (comment)), [four](Comfy-Org#16666 (comment)), [five](Comfy-Org#16666 (comment)), [six](Comfy-Org#16666 (comment)), [seven](Comfy-Org#16666 (comment)), and [eight](Comfy-Org#16666 (comment)). ## Evidence - `pnpm exec vitest run src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts` — 30/30 passed; each surviving behavior's test fails when that behavior is reverted. - Changed-file ESLint, oxfmt, type-aware oxlint, `pnpm typecheck`, and `pnpm knip` — passed. <!-- authored-by:agent lane-evfail-86-0653 --> --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Adds explicit clipboard controls for CRDT document IDs, changed node IDs, and rendered event-detail excerpts while preserving full filtered-log copying.
Changes
Review Focus
Confirm the copied detail payload exactly matches the visible 200-character excerpt and that node ID controls remain limited to
doc_nodes_changedevents.Evidence
pnpm test:unit src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts— 5 tests passed.pnpm typecheck— passed.pnpm exec oxfmt --check src/workbench/extensions/agent/crdt/CrdtDevPanel.vue src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts— passed.Screenshots (if applicable)
Not included; behavior is covered by focused component tests.