Skip to content

feat(agent): add dev panel clipboard controls - #16666

Closed
christian-byrne wants to merge 3 commits into
nathaniel/agent-panel-v1from
christian-byrne/fec-copy-1-clipboard
Closed

christian-byrne wants to merge 3 commits into
nathaniel/agent-panel-v1from
christian-byrne/fec-copy-1-clipboard

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Adds explicit clipboard controls for CRDT document IDs, changed node IDs, and rendered event-detail excerpts while preserving full filtered-log copying.

Changes

  • What: Routes every copy action through one local clipboard helper; omits unavailable controls; adds focused payload tests.
  • Breaking: None.
  • Dependencies: None.

Review Focus

Confirm the copied detail payload exactly matches the visible 200-character excerpt and that node ID controls remain limited to doc_nodes_changed events.

Evidence

  • pnpm test:unit src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts — 5 tests passed.
  • pnpm typecheck — passed.
  • pnpm exec oxfmt --check src/workbench/extensions/agent/crdt/CrdtDevPanel.vue src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts — passed.
  • Targeted Oxlint and ESLint — passed with zero errors.
  • Pre-commit checks, including type-aware Oxlint, ESLint, typecheck, and formatting — passed.
  • Pre-push Knip — passed.

Screenshots (if applicable)

Not included; behavior is covered by focused component tests.

@christian-byrne christian-byrne added the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Approval pending

CodeRabbit has no unresolved comments, but it has not reviewed the latest commit.

Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ❌ 1888 passed, 53 failed · 11 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1877 / ❌ 48 / ⚠️ 11 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 8 / ❌ 5 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 03:36:22 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 93.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 97.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 115.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 93.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 111.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 3ms TBT · 124.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 126ms TBT · 111.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.2 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 197.5 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 173ms TBT · 197.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 93.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 519ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 93.9 MB
canvas-idle: DOM nodes 15
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 52ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 82
canvas-mouse-sweep: task duration 1234ms
canvas-mouse-sweep: script duration 155ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 84.8 MB
canvas-mouse-sweep: DOM nodes 64
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 407ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 97.6 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 704ms
dom-widget-clipping: script duration 146ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 99.1 MB
dom-widget-clipping: DOM nodes 13
dom-widget-clipping: event listeners 3
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 597ms
large-graph-idle: script duration 42ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 115.3 MB
large-graph-idle: DOM nodes 9
large-graph-idle: event listeners 5
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 2556ms
large-graph-pan: script duration 891ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 93.9 MB
large-graph-pan: DOM nodes 7
large-graph-pan: event listeners 8
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 16ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 2645ms
large-graph-zoom: script duration 887ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 111.6 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 11
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 3730ms
legacy-node-drag: script duration 1012ms
legacy-node-drag: TBT 3ms
legacy-node-drag: heap used 124.1 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 192
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 607ms
minimap-idle: script duration 41ms
minimap-idle: TBT 0ms
minimap-idle: heap used 92.0 MB
minimap-idle: DOM nodes 7
minimap-idle: event listeners 4
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 568ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 87.5 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 517ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 95.1 MB
subgraph-idle: DOM nodes 18
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 7ms
subgraph-mouse-sweep: style recalc duration 49ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 81
subgraph-mouse-sweep: task duration 1142ms
subgraph-mouse-sweep: script duration 117ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 99.4 MB
subgraph-mouse-sweep: DOM nodes 70
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 978ms
subgraph-transition-enter: script duration 36ms
subgraph-transition-enter: TBT 126ms
subgraph-transition-enter: heap used 111.2 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 44ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 9160ms
viewport-pan-sweep: script duration 3015ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 95.2 MB
viewport-pan-sweep: DOM nodes -283
viewport-pan-sweep: event listeners -156
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18929ms
vue-large-graph-idle: script duration 382ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 197.5 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7453
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 26ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 182
vue-large-graph-pan: task duration 24467ms
vue-large-graph-pan: script duration 979ms
vue-large-graph-pan: TBT 173ms
vue-large-graph-pan: heap used 197.5 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7443
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 26ms
workflow-execution: layout count 4
workflow-execution: style recalc count 13
workflow-execution: task duration 137ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 93.5 MB
workflow-execution: DOM nodes 117
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-09-02T15:49:38.388Z",
  "gitSha": "f72c8772e34026f769ed4496e0e357b728d6545d",
  "branch": "christian-byrne/fec-copy-1-clipboard",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2025.9240000000318,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.731,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.279,
      "heapDeltaBytes": 2640680,
      "heapUsedBytes": 98605072,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.677,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2049.1480000000593,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.815999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 523.307,
      "heapDeltaBytes": 2911148,
      "heapUsedBytes": 98377260,
      "domNodes": 14,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 11.24,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2241.7709999999715,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 54.647999999999996,
      "layouts": 14,
      "layoutDurationMs": 5.441,
      "taskDurationMs": 1245.128,
      "heapDeltaBytes": -7128304,
      "heapUsedBytes": 88849936,
      "domNodes": 65,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 153.45000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2194.994999999949,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 48.63000000000001,
      "layouts": 14,
      "layoutDurationMs": 5.489,
      "taskDurationMs": 1223.7500000000002,
      "heapDeltaBytes": -7024024,
      "heapUsedBytes": 89073116,
      "domNodes": 63,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 157.385,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1733.2920000000058,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.199,
      "layouts": 6,
      "layoutDurationMs": 1.2220000000000002,
      "taskDurationMs": 429.04699999999997,
      "heapDeltaBytes": 5441288,
      "heapUsedBytes": 102296680,
      "domNodes": 75,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 15.1,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.5549999999057,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.186,
      "layouts": 6,
      "layoutDurationMs": 1.2630000000000001,
      "taskDurationMs": 385.407,
      "heapDeltaBytes": 5911296,
      "heapUsedBytes": 102490060,
      "domNodes": 76,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 13.271999999999998,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 969.0789999999652,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.788999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 704.9559999999999,
      "heapDeltaBytes": 7291404,
      "heapUsedBytes": 103828388,
      "domNodes": 14,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 144.974,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 957.2809999999663,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.813,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 703.085,
      "heapDeltaBytes": 7279984,
      "heapUsedBytes": 104021336,
      "domNodes": 12,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 147.01699999999997,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2017.9300000000353,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.785999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 596.1610000000001,
      "heapDeltaBytes": 16757136,
      "heapUsedBytes": 120672312,
      "domNodes": 8,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 40.00300000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2018.8640000000078,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.815999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.5350000000001,
      "heapDeltaBytes": 16832336,
      "heapUsedBytes": 121059848,
      "domNodes": 10,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 44.588,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3270.8240000000046,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.320000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2558.4139999999998,
      "heapDeltaBytes": -6557752,
      "heapUsedBytes": 98368316,
      "domNodes": 8,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 892.2900000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3274.744999999939,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.106,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2554.396,
      "heapDeltaBytes": -6906900,
      "heapUsedBytes": 98550244,
      "domNodes": 6,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 889.5999999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4439.502000000004,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 14.215000000000002,
      "layouts": 60,
      "layoutDurationMs": 15.761999999999999,
      "taskDurationMs": 2644.2230000000004,
      "heapDeltaBytes": 10567548,
      "heapUsedBytes": 120897796,
      "domNodes": 24,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 883.343,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4491.6840000000775,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 14.321,
      "layouts": 60,
      "layoutDurationMs": 15.254999999999999,
      "taskDurationMs": 2644.912,
      "heapDeltaBytes": 4046688,
      "heapUsedBytes": 113220676,
      "domNodes": 24,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 891.2919999999999,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4924.547999999959,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.2490000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3722.8079999999995,
      "heapDeltaBytes": 18347988,
      "heapUsedBytes": 130237928,
      "domNodes": 0,
      "jsHeapTotalBytes": 6709248,
      "scriptDurationMs": 1013.582,
      "eventListeners": 192,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4905.197000000044,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.338,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3736.524,
      "heapDeltaBytes": 17494064,
      "heapUsedBytes": 129978532,
      "domNodes": 2,
      "jsHeapTotalBytes": 6971392,
      "scriptDurationMs": 1010.123,
      "eventListeners": 192,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 1993.295000000046,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.138999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 612.2909999999999,
      "heapDeltaBytes": -9912332,
      "heapUsedBytes": 96445732,
      "domNodes": 8,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 38.175999999999995,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2003.8520000000517,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.902000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 601.1320000000001,
      "heapDeltaBytes": -9446252,
      "heapUsedBytes": 96482404,
      "domNodes": 6,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 44.67399999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 795.7319999999868,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.58,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 571.0609999999999,
      "heapDeltaBytes": -5842776,
      "heapUsedBytes": 91810176,
      "domNodes": 20,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 148.82299999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 748.9380000000665,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.684000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 564.184,
      "heapDeltaBytes": -5900700,
      "heapUsedBytes": 91636944,
      "domNodes": 18,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 146.728,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.5090000000037,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.572,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.4709999999999,
      "heapDeltaBytes": 3024852,
      "heapUsedBytes": 99858928,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 9.768999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.4989999999625,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.741999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.05600000000004,
      "heapDeltaBytes": 2830928,
      "heapUsedBytes": 99612476,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 9.484,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1874.416999999994,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 44.919000000000004,
      "layouts": 18,
      "layoutDurationMs": 6.6,
      "taskDurationMs": 1133.528,
      "heapDeltaBytes": 6613300,
      "heapUsedBytes": 104303392,
      "domNodes": 68,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 118.05799999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1922.4879999999303,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 52.55800000000001,
      "layouts": 18,
      "layoutDurationMs": 6.6770000000000005,
      "taskDurationMs": 1149.825,
      "heapDeltaBytes": 6587940,
      "heapUsedBytes": 104098192,
      "domNodes": 71,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 115.482,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1402.5910000000295,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.237000000000002,
      "layouts": 15,
      "layoutDurationMs": 12.938999999999998,
      "taskDurationMs": 978.4360000000003,
      "heapDeltaBytes": 22576612,
      "heapUsedBytes": 116649536,
      "domNodes": 13671,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 36.064,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 126,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12458.56900000001,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 43.37,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9056.064,
      "heapDeltaBytes": -13201268,
      "heapUsedBytes": 90140800,
      "domNodes": -282,
      "jsHeapTotalBytes": -1945600,
      "scriptDurationMs": 2985.883,
      "eventListeners": -141,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12494.020999999975,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 44.004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9264.256,
      "heapDeltaBytes": 5887544,
      "heapUsedBytes": 109465292,
      "domNodes": -283,
      "jsHeapTotalBytes": -1490944,
      "scriptDurationMs": 3043.925,
      "eventListeners": -171,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19469.82800000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19009.894000000004,
      "heapDeltaBytes": -16598640,
      "heapUsedBytes": 215177496,
      "domNodes": -6548,
      "jsHeapTotalBytes": 15548416,
      "scriptDurationMs": 380.24499999999995,
      "eventListeners": -7453,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19330.705999999962,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18847.625,
      "heapDeltaBytes": -31874328,
      "heapUsedBytes": 198961520,
      "domNodes": -6548,
      "jsHeapTotalBytes": 6230016,
      "scriptDurationMs": 382.945,
      "eventListeners": -7453,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24603.456999999937,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 26.58100000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24475.448999999997,
      "heapDeltaBytes": -25477656,
      "heapUsedBytes": 200114688,
      "domNodes": -6548,
      "jsHeapTotalBytes": 13189120,
      "scriptDurationMs": 993.076,
      "eventListeners": -7443,
      "totalBlockingTimeMs": 168,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24720.462999999996,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 26.320999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24457.616,
      "heapDeltaBytes": -17097940,
      "heapUsedBytes": 214150848,
      "domNodes": -6548,
      "jsHeapTotalBytes": 7995392,
      "scriptDurationMs": 965.279,
      "eventListeners": -7443,
      "totalBlockingTimeMs": 177,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 479.02399999998124,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 32.236000000000004,
      "layouts": 4,
      "layoutDurationMs": 1.8760000000000001,
      "taskDurationMs": 152.154,
      "heapDeltaBytes": 5735892,
      "heapUsedBytes": 99192332,
      "domNodes": 124,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.115999999999998,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 156.93199999998342,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 20.491999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.9130000000000003,
      "taskDurationMs": 122.443,
      "heapDeltaBytes": 3832880,
      "heapUsedBytes": 96828720,
      "domNodes": 109,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.027000000000001,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 47976 70144 68.4% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.2% 1178
src/LGraphNode.ts 69.7% 389
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 37.3% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.0% 258
src/LGraph.ts 79.0% 250
src/scripts/app.ts 71.8% 243
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 45.0% 203

@comfy-pr-bot
comfy-pr-bot requested a review from a team as a code owner September 2, 2026 15:01
@github-actions github-actions Bot added risk:R2 PR risk grade (advisory shadow check; grader-owned) and removed risk:R1 PR risk grade (advisory shadow check; grader-owned) labels Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                     Coverage Diff                      @@
##           nathaniel/agent-panel-v1   #16666      +/-   ##
============================================================
+ Coverage                     80.67%   83.04%   +2.37%     
============================================================
  Files                          2339     2009     -330     
  Lines                        120790   115792    -4998     
  Branches                      35560    33337    -2223     
============================================================
- Hits                          97444    96162    -1282     
+ Misses                        22849    19288    -3561     
+ Partials                        497      342     -155     
Flag Coverage Δ
e2e 66.88% <ø> (-0.03%) ⬇️
unit 75.96% <100.00%> (+0.16%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...vueNodes/composables/processedWidgetRenderModel.ts 97.12% <ø> (ø)
...c/workbench/extensions/agent/crdt/CrdtDevPanel.vue 93.19% <100.00%> (+65.67%) ⬆️

... and 350 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head bbe3429 against nathaniel/agent-panel-v1 (three-dot diff, 3 files). The controls work as described and the tests pin the payloads. Three things worth changing before this lands, in order of weight: the per-event copy hands back the truncated excerpt rather than the full detail, the template re-stringifies each detail three times per row on every re-render, and the new per-item buttons give no feedback so they look broken in a non-secure (plain http) context where navigator.clipboard is undefined. One nitpick on an unrelated formatting hunk pulled in by the automated commit.

Full context for agent readers

Verified: doc_nodes_changed ids are strings and added/removed are disjoint (useAgentCrdtFollower.ts L162-L251), so the node-id filter and v-for keys are sound. Existing crdt suite 10 files / 69 tests green on head. fmtDetail truncates at 200 chars with an ellipsis; the copy button forwards that same string. processedWidgetRenderModel.ts hunk is trailing-comma removal from the [automated] ESLint/Oxfmt commit, also present on #16659, not from this change.

Address review on #16666:

- The per-row copy button now writes the full stringified detail
  (same Uint8Array replacer) instead of the 200-char on-screen excerpt,
  which was truncated exactly when a copy was most useful.
- Build a LogRow view model once in the computed so each row's detail
  is stringified once per render instead of three times per binding.
- Track the last successful per-item copy in copiedKey and flip that
  button's label to Copied for 1200 ms, matching Copy JSON; failures
  (e.g. navigator.clipboard undefined on plain-http origins) leave the
  label unchanged. Timer is cleared on unmount.

Tests cover the full payload, the truncated excerpt display, the
transient feedback, and the no-feedback-on-failure path.
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Pushed 1b9583c addressing my review: the per-row copy now writes the full detail instead of the 200-char excerpt, row details are stringified once per render via a LogRow view model, and per-item copy buttons flip to Copied for 1.2 s on success (no change on failure). Left the unrelated processedWidgetRenderModel.ts formatter hunk alone.

Full context for agent readers

Commit 1b9583c8c1458bb41406123d19eeaed947150a56 on christian-byrne/fec-copy-1-clipboard, fast-forward from bbe3429. Files: CrdtDevPanel.vue, CrdtDevPanel.clipboard.test.ts. fmtDetail split into stringifyDetail (full) plus excerpt computed in logRows; copyItem(key, value) with copiedKey ref and a timer cleared on unmount; copyButtonLabel(key). Aria labels unchanged so existing selectors hold. Tests: 7 in the clipboard file (was 5); the two new/changed ones fail against the pre-fix component (mutation check). Gates on the fix tree: crdt dir 10 files / 71 tests pass, oxlint 0 warnings/errors, eslint clean, vue-tsc --noEmit exit 0, oxfmt check passes. Deliberate scope decision: did not hide the controls when navigator.clipboard is undefined, since that would also change the pre-existing Copy JSON button; easy follow-up if wanted.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

CI on 1b9583c: unit tests and lint green. Playwright failures (cloud agentPanel.spec.ts:49/:287, mobile-chrome screenshot baselines, 12/16 chromium shards) match every other PR against nathaniel/agent-panel-v1; the two shards that differ from peers fail in nodeReplacement.spec.ts and subgraphSearch.spec.ts, which this PR does not touch. Nothing here is attributable to the dev panel change.

@CodeJuggernaut CodeJuggernaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copy controls read the stored redacted values, so nothing can leak past the redaction; no issues.

@huang47 huang47 added risk:high PR risk grade (advisory shadow check; grader-owned) and removed risk:R2 PR risk grade (advisory shadow check; grader-owned) labels Sep 2, 2026
@CodeJuggernaut

CodeJuggernaut commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Severity: Minor

What: copyEvents arms a bare setTimeout(..., 1200) at :217 while this diff stores and clears copiedTimer (:189, :133).

Why this is an issue: Unmount within 1200ms fires against a disposed component; the two copy timers follow opposite disciplines.

Proposed Fix: Store and clear it with copiedTimer.

@CodeJuggernaut

CodeJuggernaut commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Severity: Minor (PR description)

What: Review Focus asks to confirm the copied payload matches the 200-character excerpt, but the head copies the full detail (test at :77).

Why this is an issue: A reviewer following the body files a false defect.

Proposed Fix: Reword to the full-detail behaviour.

@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 3, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 1
🟡 Medium 3
🟢 Low 5
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Re-carried onto main in PR #16927. Closing this frozen-base PR as superseded.

Full context for agent readers

The new PR preserves document-ID, full-detail, and node-ID copying, includes transient success feedback, and keeps failed writes from showing success. It also incorporates the earlier timer-cleanup and PR-description review feedback. The unrelated processedWidgetRenderModel.ts formatter hunk was dropped. Focused tests, lint, typecheck, formatting, and Knip are green.

@christian-byrne
christian-byrne deleted the christian-byrne/fec-copy-1-clipboard branch September 4, 2026 04:10
christian-byrne added a commit that referenced this pull request Sep 4, 2026
## Summary

Re-carry the CRDT dev panel clipboard controls from #16666 onto the
current main-based panel.

## Changes

- **What**: Add copy controls for the document ID, full event details,
and node IDs surfaced by `doc_nodes_changed`, with per-button success
and failure feedback.
- **What**: Change collapsed event details from main's 400-character,
two-line-clamped view to a capped 200-character excerpt. Keep the
20,000-character expanded display limit while copying the full
untruncated detail.
- **What**: Keep filtered full-log copying and the current report
collector behavior unchanged.

## Current scope and contract

- **Why this remains wanted**: Development-only CRDT observability needs
copyable document IDs, full event details, and node IDs so testers and
operators can correlate and share gap, reset, and drop evidence.
- **TDD mapping**: Serves [`docs/DEV-SETUP.md` §3, S5 /
`CRDT-RM-5`](https://github.com/christian-byrne/in-app-agent-program/blob/main/docs/DEV-SETUP.md#3-in-app-debugging):
latency/performance and observability, including gap/reset/drop metrics.
- **Preserved invariants**: This is presentation and clipboard behavior
only. It adds no shared-document write, op minting, transport,
persistence, mutation, or authority seam. Raw Yjs updates remain
host-to-follower only; presence remains ephemeral; layout remains
separate from the semantic document; optimistic overlays remain
presentation-only. Filtered full-log copying and report collection
remain unchanged.

## Review Focus

Confirm individual detail copies contain the full untruncated value,
failed clipboard writes show failure feedback, and collapsed rows use
the intentional 200-character excerpt.

Supersedes #16666. Original implementation and review fix by Christian
Byrne in `118958f3e9` and `1b9583c8c1`; adapted to the current panel
structure on `main`.

## Evidence

- Rebased onto `main` at `fdcc06bbaa3d263cdd5fc1a1541d9a68e5a6c642`;
GitHub compare reports `behind_by: 0` for head
`082063a4cc8e88899c496df78c20dee1b74ff9bc`.
- `pnpm test:unit
src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts
src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts` — 2
files, 17 tests passed at the rebased head.
- `pnpm exec eslint src/workbench/extensions/agent/crdt/CrdtDevPanel.vue
src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts` —
passed at the rebased head.
- Commit hook: Oxfmt, Stylelint, type-aware Oxlint, ESLint, `pnpm
typecheck` — passed.
- Push hook: `pnpm knip --cache` — passed.
- `git diff origin/main --
src/renderer/extensions/vueNodes/composables/processedWidgetRenderModel.ts`
— empty; the frozen-base formatter hunk was not carried.

<!-- authored-by:agent lane-prbase-7-0357 -->
<!-- authored-by:agent lane-prbase-7-0623 -->
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Ha1baraA11 pushed a commit to Ha1baraA11/ComfyUI_frontend that referenced this pull request Oct 12, 2026
## Summary

Follow up merged [frontend
Comfy-Org#16927](Comfy-Org#16927) and
closed [frontend
Comfy-Org#16666](Comfy-Org#16666) by
addressing all eight remaining review findings in the CRDT dev-panel
copy controls.

- Deduplicate and cap node-ID controls at 50 with a remaining-count
indicator.
- Serialize circular and bigint details losslessly, bound retained
detail strings to 20,000 code points, and truncate excerpts without
splitting Unicode code points.
- Show a constant placeholder when a detail can be neither serialized
nor stringified, so one bad detail cannot blank the log tab.
- Make copy feedback latest-request-wins, which also discards writes
that settle after unmount.

Hostile getters and iterators on `doc_nodes_changed` lists are no longer
handled in the panel: since Comfy-Org#16926, `recordDevEvent` rebuilds every
detail as plain data before the panel reads it.

Source review threads on [frontend
Comfy-Org#16666](Comfy-Org#16666):
[one](Comfy-Org#16666 (comment)),
[two](Comfy-Org#16666 (comment)),
[three](Comfy-Org#16666 (comment)),
[four](Comfy-Org#16666 (comment)),
[five](Comfy-Org#16666 (comment)),
[six](Comfy-Org#16666 (comment)),
[seven](Comfy-Org#16666 (comment)),
and
[eight](Comfy-Org#16666 (comment)).

## Evidence

- `pnpm exec vitest run
src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts
src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts` — 30/30
passed; each surviving behavior's test fails when that behavior is
reverted.
- Changed-file ESLint, oxfmt, type-aware oxlint, `pnpm typecheck`, and
`pnpm knip` — passed.

<!-- authored-by:agent lane-evfail-86-0653 -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants