Repository navigation
feat(agent): add CRDT dev panel clipboard controls - #16927
Conversation
|
Important Approval pendingCodeRabbit has no unresolved comments, but it could not review the latest commit because the review limit was reached. Follow the review guidance in this comment to continue. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1906 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.69 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T06:43:37.892Z",
"gitSha": "fcc88f067d9dc56debffc562eea25622443da434",
"branch": "christian-byrne/prbase-7-fec-clipboard",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2003.5730000000171,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.183,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.978,
"heapDeltaBytes": -12427832,
"heapUsedBytes": 57278464,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5.731,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2025.6800000000226,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.579999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.777,
"heapDeltaBytes": -1012308,
"heapUsedBytes": 69835776,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5.567000000000001,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.1999999999991,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.218999999999998,
"layouts": 14,
"layoutDurationMs": 2.079,
"taskDurationMs": 532.15,
"heapDeltaBytes": -8448448,
"heapUsedBytes": 61842992,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 76.50699999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.3130000000028,
"styleRecalcs": 73,
"styleRecalcDurationMs": 19.706000000000003,
"layouts": 14,
"layoutDurationMs": 2.5770000000000004,
"taskDurationMs": 552.7189999999999,
"heapDeltaBytes": -12000640,
"heapUsedBytes": 58798976,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 86.468,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1660.4189999999903,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.173000000000002,
"layouts": 6,
"layoutDurationMs": 0.9119999999999999,
"taskDurationMs": 236.251,
"heapDeltaBytes": 5123580,
"heapUsedBytes": 75885936,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6.453,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.4590000000035,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.136999999999999,
"layouts": 6,
"layoutDurationMs": 0.7929999999999998,
"taskDurationMs": 234.04400000000004,
"heapDeltaBytes": 5117360,
"heapUsedBytes": 76009124,
"domNodes": 80,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 6.2719999999999985,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 460.1169999999968,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.222,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 275.64,
"heapDeltaBytes": 17601756,
"heapUsedBytes": 87948720,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 89.654,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 444.19099999998934,
"styleRecalcs": 14,
"styleRecalcDurationMs": 5.4060000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.149,
"heapDeltaBytes": -8113252,
"heapUsedBytes": 62550356,
"domNodes": 24,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 92.55099999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2026.3830000000098,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.429,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.729,
"heapDeltaBytes": 11442012,
"heapUsedBytes": 87574336,
"domNodes": -261,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 14.985999999999999,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2014.5600000000172,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.201999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.181,
"heapDeltaBytes": -13702148,
"heapUsedBytes": 87590392,
"domNodes": -263,
"jsHeapTotalBytes": -1900544,
"scriptDurationMs": 19.125000000000004,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2060.7560000000262,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.765999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 958.6619999999999,
"heapDeltaBytes": 25753320,
"heapUsedBytes": 91441220,
"domNodes": -267,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 442.14300000000003,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2126.4059999999745,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.996999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 969.017,
"heapDeltaBytes": 19090628,
"heapUsedBytes": 85069968,
"domNodes": -263,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 463.31600000000003,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3040.6229999999823,
"styleRecalcs": 63,
"styleRecalcDurationMs": 7.380000000000001,
"layouts": 60,
"layoutDurationMs": 7.231,
"taskDurationMs": 999.539,
"heapDeltaBytes": 8523728,
"heapUsedBytes": 75910436,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 415.384,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3046.9870000000014,
"styleRecalcs": 64,
"styleRecalcDurationMs": 7.949000000000002,
"layouts": 60,
"layoutDurationMs": 6.92,
"taskDurationMs": 1024.2649999999999,
"heapDeltaBytes": 9189244,
"heapUsedBytes": 76219648,
"domNodes": -270,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 427.938,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2162.1680000000083,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.232999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1124.5990000000002,
"heapDeltaBytes": 13692872,
"heapUsedBytes": 81393160,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 519.9970000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2129.3319999999767,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.097999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1107.39,
"heapDeltaBytes": 13831572,
"heapUsedBytes": 81176908,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 503.56899999999996,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2009.8610000000008,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.7760000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.40900000000005,
"heapDeltaBytes": 11166796,
"heapUsedBytes": 87421448,
"domNodes": -265,
"jsHeapTotalBytes": -2985984,
"scriptDurationMs": 16.548000000000002,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2007.983999999965,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.065999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.76500000000004,
"heapDeltaBytes": 10715392,
"heapUsedBytes": 87555836,
"domNodes": -265,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 16.548000000000002,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 379.729999999995,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.9300000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 249.54999999999998,
"heapDeltaBytes": 14806520,
"heapUsedBytes": 85785108,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 80.77699999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 410.44900000002826,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.5859999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 255.42200000000003,
"heapDeltaBytes": 15162168,
"heapUsedBytes": 87249420,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 78.91100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.563000000019,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.632000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.575,
"heapDeltaBytes": 1714380,
"heapUsedBytes": 74644932,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 4.975999999999999,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.1949999999715,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.090000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.04,
"heapDeltaBytes": 5599696,
"heapUsedBytes": 78229160,
"domNodes": -293,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 4.704,
"eventListeners": -224,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.542999999987,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.881,
"layouts": 18,
"layoutDurationMs": 2.66,
"taskDurationMs": 520.575,
"heapDeltaBytes": -13926860,
"heapUsedBytes": 58917776,
"domNodes": -293,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 55.784,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.2690000000161,
"styleRecalcs": 78,
"styleRecalcDurationMs": 20.008,
"layouts": 18,
"layoutDurationMs": 2.713,
"taskDurationMs": 535.518,
"heapDeltaBytes": 3889764,
"heapUsedBytes": 76757684,
"domNodes": -293,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 57.26500000000001,
"eventListeners": -224,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 832.636999999977,
"styleRecalcs": 22,
"styleRecalcDurationMs": 19.935000000000002,
"layouts": 18,
"layoutDurationMs": 9.472999999999999,
"taskDurationMs": 593.0139999999999,
"heapDeltaBytes": 21843912,
"heapUsedBytes": 105561216,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 16.061,
"eventListeners": 2385,
"totalBlockingTimeMs": 86,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8105.367999999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3413.6099999999997,
"heapDeltaBytes": 13912644,
"heapUsedBytes": 89754064,
"domNodes": -265,
"jsHeapTotalBytes": -1449984,
"scriptDurationMs": 1473.4,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8107.717999999977,
"styleRecalcs": 248,
"styleRecalcDurationMs": 18.847,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3421.215,
"heapDeltaBytes": 24864496,
"heapUsedBytes": 90079964,
"domNodes": -265,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 1514.885,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 8937.523,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8327.894,
"heapDeltaBytes": -5993816,
"heapUsedBytes": 182480484,
"domNodes": -6548,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 80.366,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 9918.243000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8909.626,
"heapDeltaBytes": -31968752,
"heapUsedBytes": 178412184,
"domNodes": -6548,
"jsHeapTotalBytes": -10137600,
"scriptDurationMs": 97.90899999999999,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 11459.880999999996,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.91699999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10774.023,
"heapDeltaBytes": -6527212,
"heapUsedBytes": 195052612,
"domNodes": -6548,
"jsHeapTotalBytes": 11718656,
"scriptDurationMs": 504.22299999999996,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 11553.65999999998,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.059000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10777.448,
"heapDeltaBytes": -31324156,
"heapUsedBytes": 170138788,
"domNodes": -6548,
"jsHeapTotalBytes": 10706944,
"scriptDurationMs": 500.68,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3300.6209999999783,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.45200000000002,
"layouts": 20,
"layoutDurationMs": 14.993000000000006,
"taskDurationMs": 3167.582,
"heapDeltaBytes": -23115128,
"heapUsedBytes": 185336920,
"domNodes": -6548,
"jsHeapTotalBytes": 14422016,
"scriptDurationMs": 39.63100000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3278.4899999999766,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.115,
"layouts": 20,
"layoutDurationMs": 15.881999999999993,
"taskDurationMs": 3107.0650000000005,
"heapDeltaBytes": -10987228,
"heapUsedBytes": 176317392,
"domNodes": -6548,
"jsHeapTotalBytes": 14159872,
"scriptDurationMs": 40.05400000000001,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5066.54199999997,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.11300000000000199,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4526.824999999999,
"heapDeltaBytes": 13981628,
"heapUsedBytes": 187127656,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 43.38199999999998,
"eventListeners": 14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 4608.033999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4230.098000000001,
"heapDeltaBytes": 470548,
"heapUsedBytes": 174690628,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 41.115999999999985,
"eventListeners": -6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 418.86299999998755,
"styleRecalcs": 15,
"styleRecalcDurationMs": 13.145,
"layouts": 3,
"layoutDurationMs": 0.5099999999999999,
"taskDurationMs": 72.23100000000001,
"heapDeltaBytes": 4800140,
"heapUsedBytes": 72622712,
"domNodes": 124,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 5.66,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 428.96299999995335,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.497000000000002,
"layouts": 3,
"layoutDurationMs": 1.065,
"taskDurationMs": 66.71599999999998,
"heapDeltaBytes": 4907912,
"heapUsedBytes": 73861032,
"domNodes": 144,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.575,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #16927 +/- ##
==========================================
+ Coverage 81.19% 82.76% +1.57%
==========================================
Files 2462 2044 -418
Lines 126755 119306 -7449
Branches 33790 30151 -3639
==========================================
- Hits 102914 98749 -4165
+ Misses 23325 20375 -2950
+ Partials 516 182 -334
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 418 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed at bb2064c. Checked the diff against useAgentCrdtFollower.ts (the added/removed sets on doc_nodes_changed are disjoint, so the per-node copy buttons cannot collide on :key), the useClipboard mock pattern (five other suites already spread importOriginal), and the clipboard behaviour of the existing log/report copy buttons. No blocking issues; one suggestion on failure feedback and two nitpicks below.
Full context for agent readers
Three inline comments: copyItem swallows clipboard failures silently while the sibling copy buttons show S.copyFailed; the new test suite does not enable the debug gate the way CrdtDevPanel.test.ts does; and the PR body describes the 200-character collapsed excerpt as preserving existing behaviour, but origin/main truncates at 400 with line-clamp-2.
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Pushed the two code fixes from the review in 2edf762: per-item copy buttons now show Full context for agent readers
Verification at 2edf762 in a clean worktree: |
|
CI on 2edf762 is green: 76 success, 16 skipped, 0 failures, run settled at 05:37Z. No fix loop iterations were needed. Full context for agent readersPolled via the check-runs API on |
2edf762 to
082063a
Compare
## Summary Follow up merged [frontend Comfy-Org#16927](Comfy-Org#16927) and closed [frontend Comfy-Org#16666](Comfy-Org#16666) by addressing all eight remaining review findings in the CRDT dev-panel copy controls. - Deduplicate and cap node-ID controls at 50 with a remaining-count indicator. - Serialize circular and bigint details losslessly, bound retained detail strings to 20,000 code points, and truncate excerpts without splitting Unicode code points. - Show a constant placeholder when a detail can be neither serialized nor stringified, so one bad detail cannot blank the log tab. - Make copy feedback latest-request-wins, which also discards writes that settle after unmount. Hostile getters and iterators on `doc_nodes_changed` lists are no longer handled in the panel: since Comfy-Org#16926, `recordDevEvent` rebuilds every detail as plain data before the panel reads it. Source review threads on [frontend Comfy-Org#16666](Comfy-Org#16666): [one](Comfy-Org#16666 (comment)), [two](Comfy-Org#16666 (comment)), [three](Comfy-Org#16666 (comment)), [four](Comfy-Org#16666 (comment)), [five](Comfy-Org#16666 (comment)), [six](Comfy-Org#16666 (comment)), [seven](Comfy-Org#16666 (comment)), and [eight](Comfy-Org#16666 (comment)). ## Evidence - `pnpm exec vitest run src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts` — 30/30 passed; each surviving behavior's test fails when that behavior is reverted. - Changed-file ESLint, oxfmt, type-aware oxlint, `pnpm typecheck`, and `pnpm knip` — passed. <!-- authored-by:agent lane-evfail-86-0653 --> --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Re-carry the CRDT dev panel clipboard controls from #16666 onto the current main-based panel.
Changes
doc_nodes_changed, with per-button success and failure feedback.Current scope and contract
docs/DEV-SETUP.md§3, S5 /CRDT-RM-5: latency/performance and observability, including gap/reset/drop metrics.Review Focus
Confirm individual detail copies contain the full untruncated value, failed clipboard writes show failure feedback, and collapsed rows use the intentional 200-character excerpt.
Supersedes #16666. Original implementation and review fix by Christian Byrne in
118958f3e9and1b9583c8c1; adapted to the current panel structure onmain.Evidence
mainatfdcc06bbaa3d263cdd5fc1a1541d9a68e5a6c642; GitHub compare reportsbehind_by: 0for head082063a4cc8e88899c496df78c20dee1b74ff9bc.pnpm test:unit src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts— 2 files, 17 tests passed at the rebased head.pnpm exec eslint src/workbench/extensions/agent/crdt/CrdtDevPanel.vue src/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.ts— passed at the rebased head.pnpm typecheck— passed.pnpm knip --cache— passed.git diff origin/main -- src/renderer/extensions/vueNodes/composables/processedWidgetRenderModel.ts— empty; the frozen-base formatter hunk was not carried.