Skip to content

fix(agent): keep CRDT dev panel within viewport - #16667

Closed
christian-byrne wants to merge 2 commits into
nathaniel/agent-panel-v1from
christian/fec-responsive-panel
Closed

christian-byrne wants to merge 2 commits into
nathaniel/agent-panel-v1from
christian/fec-responsive-panel

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor
  • Small viewports retain 12 px panel edges.
  • Desktop width remains capped at 420 px.
  • Focused test, lint, formatting, and typecheck are green.
Full context for agent readers

Replaces the open CRDT dev panel's fixed width with calc(100vw - 1.5rem) plus the existing 420 px desktop cap. The 1.5 rem subtraction matches the existing right-3 offset on both viewport edges.

The focused component test also locks the unchanged closed-chip styling, fixed edge offsets, 70vh height cap, and both scrolling regions.

Evidence

  • $ NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/workbench/extensions/agent/crdt/CrdtDevPanel.responsive.test.ts — 1 test passed.
  • $ NODE_OPTIONS=--no-experimental-webstorage pnpm exec eslint src/workbench/extensions/agent/crdt/CrdtDevPanel.vue src/workbench/extensions/agent/crdt/CrdtDevPanel.responsive.test.ts — passed.
  • $ pnpm exec oxfmt --check src/workbench/extensions/agent/crdt/CrdtDevPanel.vue src/workbench/extensions/agent/crdt/CrdtDevPanel.responsive.test.ts — both files formatted.
  • $ NODE_OPTIONS=--no-experimental-webstorage pnpm typecheck — passed.

Base: nathaniel/agent-panel-v1 as required by the FEC lane.

@christian-byrne christian-byrne added the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: f0a3762f-536f-4e32-8555-6102c03edb7c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 03:04:55 PM UTC

Links

🎭 Playwright: ❌ 1886 passed, 55 failed · 10 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1875 / ❌ 50 / ⚠️ 10 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 8 / ❌ 5 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 97.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 115.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 108.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 3ms TBT · 109.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 104.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 117ms TBT · 101.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 4ms TBT · 105.2 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 191.8 MB heap
vue-large-graph-pan: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 200ms TBT · 200.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 556ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 94.6 MB
canvas-idle: DOM nodes 17
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 83
canvas-mouse-sweep: task duration 1150ms
canvas-mouse-sweep: script duration 147ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 85.2 MB
canvas-mouse-sweep: DOM nodes 66
canvas-mouse-sweep: event listeners 5
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 419ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 97.9 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 681ms
dom-widget-clipping: script duration 144ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 99.0 MB
dom-widget-clipping: DOM nodes 15
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 557ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 115.4 MB
large-graph-idle: DOM nodes 9
large-graph-idle: event listeners 5
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 2492ms
large-graph-pan: script duration 860ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 94.0 MB
large-graph-pan: DOM nodes 8
large-graph-pan: event listeners 8
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 15ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 2542ms
large-graph-zoom: script duration 848ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 108.2 MB
large-graph-zoom: DOM nodes 25
large-graph-zoom: event listeners 11
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 3620ms
legacy-node-drag: script duration 995ms
legacy-node-drag: TBT 3ms
legacy-node-drag: heap used 109.2 MB
legacy-node-drag: DOM nodes 2
legacy-node-drag: event listeners 192
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 630ms
minimap-idle: script duration 41ms
minimap-idle: TBT 0ms
minimap-idle: heap used 104.2 MB
minimap-idle: DOM nodes 8
minimap-idle: event listeners 5
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 535ms
subgraph-dom-widget-clipping: script duration 138ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 87.4 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 476ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 95.9 MB
subgraph-idle: DOM nodes 20
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 44ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 80
subgraph-mouse-sweep: task duration 1086ms
subgraph-mouse-sweep: script duration 109ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 99.6 MB
subgraph-mouse-sweep: DOM nodes 68
subgraph-mouse-sweep: event listeners 5
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 897ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 117ms
subgraph-transition-enter: heap used 101.4 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 42ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 8964ms
viewport-pan-sweep: script duration 2979ms
viewport-pan-sweep: TBT 4ms
viewport-pan-sweep: heap used 105.2 MB
viewport-pan-sweep: DOM nodes -292
viewport-pan-sweep: event listeners -180
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18302ms
vue-large-graph-idle: script duration 352ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 191.8 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7457
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 26ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 23660ms
vue-large-graph-pan: script duration 989ms
vue-large-graph-pan: TBT 200ms
vue-large-graph-pan: heap used 200.6 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7445
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 28ms
workflow-execution: layout count 7
workflow-execution: style recalc count 17
workflow-execution: task duration 168ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 95.0 MB
workflow-execution: DOM nodes 135
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-09-02T15:27:56.672Z",
  "gitSha": "959fc029976546286eba4ebe238b1774c90b6a3d",
  "branch": "christian/fec-responsive-panel",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2055.172999999968,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 644.4920000000001,
      "heapDeltaBytes": 2792244,
      "heapUsedBytes": 99112132,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 12.219000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.3050000000367,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.526999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 467.785,
      "heapDeltaBytes": 2930296,
      "heapUsedBytes": 99253992,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 8.789000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2206.1929999999847,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 46.55799999999999,
      "layouts": 14,
      "layoutDurationMs": 5.205,
      "taskDurationMs": 1194.7610000000002,
      "heapDeltaBytes": -7161828,
      "heapUsedBytes": 89818048,
      "domNodes": 67,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 153.364,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2120.3590000000077,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 40.96,
      "layouts": 14,
      "layoutDurationMs": 4.936999999999999,
      "taskDurationMs": 1105.6929999999998,
      "heapDeltaBytes": -7094172,
      "heapUsedBytes": 88924188,
      "domNodes": 64,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 140.45,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1749.8930000000428,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.682,
      "layouts": 6,
      "layoutDurationMs": 1.203,
      "taskDurationMs": 453.38400000000007,
      "heapDeltaBytes": 5671788,
      "heapUsedBytes": 102758544,
      "domNodes": 74,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 17.169,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1730.322000000001,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.587,
      "layouts": 6,
      "layoutDurationMs": 1.306,
      "taskDurationMs": 383.93799999999993,
      "heapDeltaBytes": 5651012,
      "heapUsedBytes": 102632036,
      "domNodes": 76,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 13.232999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 978.8389999999936,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.206999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 693.6569999999999,
      "heapDeltaBytes": 6884304,
      "heapUsedBytes": 103957692,
      "domNodes": 14,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 145.02100000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 915.2809999999363,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.482,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 667.553,
      "heapDeltaBytes": 7381064,
      "heapUsedBytes": 103571248,
      "domNodes": 16,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 142.589,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2004.0300000000002,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 614.7779999999999,
      "heapDeltaBytes": 16444692,
      "heapUsedBytes": 120605540,
      "domNodes": 10,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 41.084,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2015.3409999999212,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.2660000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.992,
      "heapDeltaBytes": 16933152,
      "heapUsedBytes": 121370180,
      "domNodes": 8,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 34.11,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3243.494999999996,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.213,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2578.549,
      "heapDeltaBytes": -6035888,
      "heapUsedBytes": 98611420,
      "domNodes": 8,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 874.189,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3163.2359999999835,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.402,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2404.9990000000003,
      "heapDeltaBytes": -6358484,
      "heapUsedBytes": 98591964,
      "domNodes": 8,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 846.237,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4486.043999999993,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.808000000000002,
      "layouts": 60,
      "layoutDurationMs": 14.866000000000001,
      "taskDurationMs": 2650.89,
      "heapDeltaBytes": 3314216,
      "heapUsedBytes": 113544112,
      "domNodes": 24,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 863.7629999999999,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4263.949999999909,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.801999999999998,
      "layouts": 60,
      "layoutDurationMs": 14.256,
      "taskDurationMs": 2434.089,
      "heapDeltaBytes": 3792648,
      "heapUsedBytes": 113296748,
      "domNodes": 26,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 832.467,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4985.436999999991,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.001000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3729.805,
      "heapDeltaBytes": -12549692,
      "heapUsedBytes": 99058520,
      "domNodes": 0,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 1039.184,
      "eventListeners": 192,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4706.589000000008,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.404,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3510.584,
      "heapDeltaBytes": 17570796,
      "heapUsedBytes": 129925536,
      "domNodes": 4,
      "jsHeapTotalBytes": 6709248,
      "scriptDurationMs": 951.4060000000001,
      "eventListeners": 192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2002.437000000043,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 3.034000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 681.022,
      "heapDeltaBytes": 16842968,
      "heapUsedBytes": 122211200,
      "domNodes": 6,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 38.158,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.4820000000154,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.911000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.3409999999999,
      "heapDeltaBytes": -9431844,
      "heapUsedBytes": 96342984,
      "domNodes": 10,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 43.642999999999994,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 745.5979999999727,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.91,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 547.11,
      "heapDeltaBytes": -5645196,
      "heapUsedBytes": 91292424,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 138.598,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 711.255000000051,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.712,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 523.829,
      "heapDeltaBytes": -5516824,
      "heapUsedBytes": 92019024,
      "domNodes": 18,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 138.291,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.7820000000106,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.534,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.01700000000005,
      "heapDeltaBytes": 2838484,
      "heapUsedBytes": 100685600,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 9.133000000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.4840000000395,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.059000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 467.928,
      "heapDeltaBytes": 3221880,
      "heapUsedBytes": 100522820,
      "domNodes": 20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 7.82,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1907.7260000000251,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 48.162,
      "layouts": 18,
      "layoutDurationMs": 6.084,
      "taskDurationMs": 1143.028,
      "heapDeltaBytes": 6813552,
      "heapUsedBytes": 104371400,
      "domNodes": 69,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 114.50399999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1776.7939999999953,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 39.205000000000005,
      "layouts": 18,
      "layoutDurationMs": 5.954,
      "taskDurationMs": 1029.558,
      "heapDeltaBytes": 6752620,
      "heapUsedBytes": 104406104,
      "domNodes": 67,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 103.022,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1403.0649999999696,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 28.299000000000003,
      "layouts": 15,
      "layoutDurationMs": 11.691000000000004,
      "taskDurationMs": 897.4809999999998,
      "heapDeltaBytes": -7209600,
      "heapUsedBytes": 106332224,
      "domNodes": 13671,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 30.014000000000006,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 117,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12560.262000000022,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 41.144,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9114.710000000001,
      "heapDeltaBytes": -1850600,
      "heapUsedBytes": 102406880,
      "domNodes": -282,
      "jsHeapTotalBytes": -1490944,
      "scriptDurationMs": 3019.586,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12504.066999999963,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 42.480999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8813.48,
      "heapDeltaBytes": 13424188,
      "heapUsedBytes": 118154072,
      "domNodes": -301,
      "jsHeapTotalBytes": -2924544,
      "scriptDurationMs": 2939.383,
      "eventListeners": -203,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19206.67400000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18865.26,
      "heapDeltaBytes": -12389028,
      "heapUsedBytes": 202560072,
      "domNodes": -6548,
      "jsHeapTotalBytes": 18477056,
      "scriptDurationMs": 364.70699999999994,
      "eventListeners": -7461,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18422.79499999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17737.821999999996,
      "heapDeltaBytes": -31421304,
      "heapUsedBytes": 199730660,
      "domNodes": -6548,
      "jsHeapTotalBytes": 13713408,
      "scriptDurationMs": 338.638,
      "eventListeners": -7453,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24314.54800000006,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 28.81499999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24148.017,
      "heapDeltaBytes": -7433680,
      "heapUsedBytes": 216674504,
      "domNodes": -6548,
      "jsHeapTotalBytes": 11161600,
      "scriptDurationMs": 1010.4199999999998,
      "eventListeners": -7445,
      "totalBlockingTimeMs": 287,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23468.54799999994,
      "styleRecalcs": 179,
      "styleRecalcDurationMs": 22.914999999999964,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23171.573000000004,
      "heapDeltaBytes": -40936836,
      "heapUsedBytes": 203950304,
      "domNodes": -6548,
      "jsHeapTotalBytes": 6467584,
      "scriptDurationMs": 968.4889999999999,
      "eventListeners": -7445,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 536.6020000000162,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 28.618,
      "layouts": 11,
      "layoutDurationMs": 4.435,
      "taskDurationMs": 187.892,
      "heapDeltaBytes": 6066400,
      "heapUsedBytes": 99639200,
      "domNodes": 149,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 10.591999999999999,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 483.141000000046,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 26.891,
      "layouts": 3,
      "layoutDurationMs": 1.1579999999999997,
      "taskDurationMs": 147.87499999999997,
      "heapDeltaBytes": 5707932,
      "heapUsedBytes": 99565496,
      "domNodes": 121,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.014999999999997,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 47987 70144 68.4% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.2% 1178
src/LGraphNode.ts 69.7% 389
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 37.3% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.0% 258
src/LGraph.ts 79.0% 250
src/scripts/app.ts 71.8% 243
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 45.0% 203

@comfy-pr-bot
comfy-pr-bot requested a review from a team as a code owner September 2, 2026 15:02
@github-actions github-actions Bot added risk:R2 PR risk grade (advisory shadow check; grader-owned) and removed risk:R1 PR risk grade (advisory shadow check; grader-owned) labels Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                     Coverage Diff                      @@
##           nathaniel/agent-panel-v1   #16667      +/-   ##
============================================================
+ Coverage                     80.67%   83.02%   +2.35%     
============================================================
  Files                          2339     2009     -330     
  Lines                        120790   115753    -5037     
  Branches                      35560    33302    -2258     
============================================================
- Hits                          97444    96102    -1342     
+ Misses                        22849    19310    -3539     
+ Partials                        497      341     -156     
Flag Coverage Δ
e2e 66.89% <ø> (-0.01%) ⬇️
unit 75.92% <ø> (+0.12%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...vueNodes/composables/processedWidgetRenderModel.ts 97.12% <ø> (ø)
...c/workbench/extensions/agent/crdt/CrdtDevPanel.vue 77.77% <ø> (+50.25%) ⬆️

... and 351 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodeJuggernaut

CodeJuggernaut commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Severity: Minor (test-integrity)

What: CrdtDevPanel.responsive.test.ts asserts only Tailwind classes (right-3, bottom-3, rounded-full, px-3, py-1), several untouched by this PR.

Why this is an issue: Repo testing rules ban class assertions; under jsdom it cannot fail for its stated reason, and #16666 restructures the subtree it pins.

Proposed Fix: Replace with a behavioral pin or drop the file; the production change is correct and stays.

@huang47 huang47 added risk:high PR risk grade (advisory shadow check; grader-owned) and removed risk:R2 PR risk grade (advisory shadow check; grader-owned) labels Sep 2, 2026
@CodeJuggernaut

Copy link
Copy Markdown
Contributor

Severity: Minor

What: CrdtDevPanel.vue's chip container (fixed right-3 bottom-3 z-9999, :196) sits over the agent composer's Send button when the panel is docked - observed in the #16643 harness at current main, where Playwright's click on Send is pointer-intercepted by crdt-dev-panel-chip.

Why this is an issue: Real clicks on Send never land in a dev session with the chip visible; only keyboard Enter sends.

Proposed Fix: Offset the chip when the agent panel is docked, or drop its z-index below the composer.

@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 3, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 3 finding(s).

Severity Count
🟡 Medium 1
🟢 Low 1
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

<div
v-else
class="flex max-h-[70vh] w-[420px] flex-col overflow-hidden rounded-lg border border-border-default bg-base-background shadow-xl"
class="flex max-h-[70vh] w-[calc(100vw-1.5rem)] max-w-[420px] flex-col overflow-hidden rounded-lg border border-border-default bg-base-background shadow-xl"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — w-[calc(100vw-1.5rem)] uses 100vw, which includes the classic scrollbar gutter, while the wrapper's fixed right-3 offset is measured against the scrollbar-excluded layout viewport. Below ~444px (the only width where max-w-[420px] doesn't clamp) the panel exceeds viewport - 1.5rem, pushing its left edge off-screen and potentially adding horizontal scroll; use 100dvw or drop the calc in favour of left-3 right-3 with w-auto. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

await userEvent.click(chip)

const panel = screen.getByTestId('crdt-dev-panel-open')
expect(panel).toHaveClass(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This test only asserts that literal Tailwind class strings appear in the class attribute; happy-dom computes no layout, so it never observes width, height, or overflow and would pass even if Tailwind emitted no rule for the arbitrary w-[calc(...)] candidate — the exact regression it is meant to guard. Repo guidance also forbids tests that depend on utility classes/styles; a Playwright check of the rendered box (or dropping the test) is the honest option, and the right-3/bottom-3/rounded-full/px-3/py-1 assertions on untouched styling are pure change detectors either way. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case).

isGraphReady,
rootGraph,
ui,
ui

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — These two trailing-comma removals are unrelated to the CRDT dev panel change and look like a stray formatter run with different settings than the repo's oxfmt config. Revert them to keep the PR focused (and confirm pnpm format doesn't disagree). Raised by 0 of 8 reviewers (adjudicator).

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing as superseded: the responsive fix targets a panel design that no longer exists on main.

Full context for agent readers

The re-carry (fleet row prbase-8) found that main restructured the CRDT dev instrument in #16365 (commit 8f3b156): the panel is no longer a fixed right-3 floating overlay capped at w-[420px], but a flex child of AgentPanel's #instrument column, engineered so it cannot exceed the panel/viewport or push the composer below the fold (see the doc block at the top of main's CrdtDevPanel.vue). The overflow this PR fixed (w-[420px] floating panel on small viewports) is structurally impossible in the new design, and porting max-w-[420px] would shrink main's docked instrument rather than preserve intent. The PR's second head commit only touched processedWidgetRenderModel.ts and is dropped per the prbase recipe (would revert Nathaniel's 5d6233a dedupe fix).

Superseder: #16365 / commit 8f3b156 on main.

@christian-byrne
christian-byrne deleted the christian/fec-responsive-panel branch September 4, 2026 04:00
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Accounting corrected: five canonical zero-context hunks; zero residual.

Full context for agent readers

The program ledger now enumerates all five git diff -U0 583ad3b400eb4781816278e024f00d57e61d251a 16402f8bc7e190b6cbc0731928eb058960971e47 hunks one-for-one: two processedWidgetRenderModel.ts formatter end-states already on main, the new responsive test-file hunk intentionally dropped, and two CrdtDevPanel.vue hunks intentionally dropped as superseded by #16365. The existing supersession rationale is unchanged.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants