Repository navigation
fix(agent): keep CRDT dev panel within viewport - #16667
christian-byrne wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 1886 passed, 55 failed · 10 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-02T15:27:56.672Z",
"gitSha": "959fc029976546286eba4ebe238b1774c90b6a3d",
"branch": "christian/fec-responsive-panel",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.172999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.4920000000001,
"heapDeltaBytes": 2792244,
"heapUsedBytes": 99112132,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 12.219000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.3050000000367,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.526999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.785,
"heapDeltaBytes": 2930296,
"heapUsedBytes": 99253992,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8.789000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2206.1929999999847,
"styleRecalcs": 83,
"styleRecalcDurationMs": 46.55799999999999,
"layouts": 14,
"layoutDurationMs": 5.205,
"taskDurationMs": 1194.7610000000002,
"heapDeltaBytes": -7161828,
"heapUsedBytes": 89818048,
"domNodes": 67,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 153.364,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2120.3590000000077,
"styleRecalcs": 82,
"styleRecalcDurationMs": 40.96,
"layouts": 14,
"layoutDurationMs": 4.936999999999999,
"taskDurationMs": 1105.6929999999998,
"heapDeltaBytes": -7094172,
"heapUsedBytes": 88924188,
"domNodes": 64,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 140.45,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1749.8930000000428,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.682,
"layouts": 6,
"layoutDurationMs": 1.203,
"taskDurationMs": 453.38400000000007,
"heapDeltaBytes": 5671788,
"heapUsedBytes": 102758544,
"domNodes": 74,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 17.169,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.322000000001,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.587,
"layouts": 6,
"layoutDurationMs": 1.306,
"taskDurationMs": 383.93799999999993,
"heapDeltaBytes": 5651012,
"heapUsedBytes": 102632036,
"domNodes": 76,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 13.232999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 978.8389999999936,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.206999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 693.6569999999999,
"heapDeltaBytes": 6884304,
"heapUsedBytes": 103957692,
"domNodes": 14,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 145.02100000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 915.2809999999363,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.482,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 667.553,
"heapDeltaBytes": 7381064,
"heapUsedBytes": 103571248,
"domNodes": 16,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 142.589,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2004.0300000000002,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.7779999999999,
"heapDeltaBytes": 16444692,
"heapUsedBytes": 120605540,
"domNodes": 10,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 41.084,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2015.3409999999212,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.2660000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.992,
"heapDeltaBytes": 16933152,
"heapUsedBytes": 121370180,
"domNodes": 8,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 34.11,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3243.494999999996,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.213,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2578.549,
"heapDeltaBytes": -6035888,
"heapUsedBytes": 98611420,
"domNodes": 8,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 874.189,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3163.2359999999835,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.402,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2404.9990000000003,
"heapDeltaBytes": -6358484,
"heapUsedBytes": 98591964,
"domNodes": 8,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 846.237,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 4486.043999999993,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.808000000000002,
"layouts": 60,
"layoutDurationMs": 14.866000000000001,
"taskDurationMs": 2650.89,
"heapDeltaBytes": 3314216,
"heapUsedBytes": 113544112,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 863.7629999999999,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4263.949999999909,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.801999999999998,
"layouts": 60,
"layoutDurationMs": 14.256,
"taskDurationMs": 2434.089,
"heapDeltaBytes": 3792648,
"heapUsedBytes": 113296748,
"domNodes": 26,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 832.467,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 4985.436999999991,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.001000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3729.805,
"heapDeltaBytes": -12549692,
"heapUsedBytes": 99058520,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 1039.184,
"eventListeners": 192,
"totalBlockingTimeMs": 5,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 4706.589000000008,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.404,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3510.584,
"heapDeltaBytes": 17570796,
"heapUsedBytes": 129925536,
"domNodes": 4,
"jsHeapTotalBytes": 6709248,
"scriptDurationMs": 951.4060000000001,
"eventListeners": 192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2002.437000000043,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.034000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.022,
"heapDeltaBytes": 16842968,
"heapUsedBytes": 122211200,
"domNodes": 6,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 38.158,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2020.4820000000154,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.911000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.3409999999999,
"heapDeltaBytes": -9431844,
"heapUsedBytes": 96342984,
"domNodes": 10,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 43.642999999999994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 745.5979999999727,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.91,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.11,
"heapDeltaBytes": -5645196,
"heapUsedBytes": 91292424,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 138.598,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 711.255000000051,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.712,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.829,
"heapDeltaBytes": -5516824,
"heapUsedBytes": 92019024,
"domNodes": 18,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 138.291,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.7820000000106,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.534,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.01700000000005,
"heapDeltaBytes": 2838484,
"heapUsedBytes": 100685600,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 9.133000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.4840000000395,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.059000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.928,
"heapDeltaBytes": 3221880,
"heapUsedBytes": 100522820,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 7.82,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1907.7260000000251,
"styleRecalcs": 81,
"styleRecalcDurationMs": 48.162,
"layouts": 18,
"layoutDurationMs": 6.084,
"taskDurationMs": 1143.028,
"heapDeltaBytes": 6813552,
"heapUsedBytes": 104371400,
"domNodes": 69,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 114.50399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1776.7939999999953,
"styleRecalcs": 79,
"styleRecalcDurationMs": 39.205000000000005,
"layouts": 18,
"layoutDurationMs": 5.954,
"taskDurationMs": 1029.558,
"heapDeltaBytes": 6752620,
"heapUsedBytes": 104406104,
"domNodes": 67,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 103.022,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1403.0649999999696,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.299000000000003,
"layouts": 15,
"layoutDurationMs": 11.691000000000004,
"taskDurationMs": 897.4809999999998,
"heapDeltaBytes": -7209600,
"heapUsedBytes": 106332224,
"domNodes": 13671,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 30.014000000000006,
"eventListeners": 2381,
"totalBlockingTimeMs": 117,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12560.262000000022,
"styleRecalcs": 246,
"styleRecalcDurationMs": 41.144,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9114.710000000001,
"heapDeltaBytes": -1850600,
"heapUsedBytes": 102406880,
"domNodes": -282,
"jsHeapTotalBytes": -1490944,
"scriptDurationMs": 3019.586,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12504.066999999963,
"styleRecalcs": 246,
"styleRecalcDurationMs": 42.480999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8813.48,
"heapDeltaBytes": 13424188,
"heapUsedBytes": 118154072,
"domNodes": -301,
"jsHeapTotalBytes": -2924544,
"scriptDurationMs": 2939.383,
"eventListeners": -203,
"totalBlockingTimeMs": 8,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19206.67400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18865.26,
"heapDeltaBytes": -12389028,
"heapUsedBytes": 202560072,
"domNodes": -6548,
"jsHeapTotalBytes": 18477056,
"scriptDurationMs": 364.70699999999994,
"eventListeners": -7461,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18422.79499999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17737.821999999996,
"heapDeltaBytes": -31421304,
"heapUsedBytes": 199730660,
"domNodes": -6548,
"jsHeapTotalBytes": 13713408,
"scriptDurationMs": 338.638,
"eventListeners": -7453,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 24314.54800000006,
"styleRecalcs": 182,
"styleRecalcDurationMs": 28.81499999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24148.017,
"heapDeltaBytes": -7433680,
"heapUsedBytes": 216674504,
"domNodes": -6548,
"jsHeapTotalBytes": 11161600,
"scriptDurationMs": 1010.4199999999998,
"eventListeners": -7445,
"totalBlockingTimeMs": 287,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 23468.54799999994,
"styleRecalcs": 179,
"styleRecalcDurationMs": 22.914999999999964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23171.573000000004,
"heapDeltaBytes": -40936836,
"heapUsedBytes": 203950304,
"domNodes": -6548,
"jsHeapTotalBytes": 6467584,
"scriptDurationMs": 968.4889999999999,
"eventListeners": -7445,
"totalBlockingTimeMs": 112,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 536.6020000000162,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.618,
"layouts": 11,
"layoutDurationMs": 4.435,
"taskDurationMs": 187.892,
"heapDeltaBytes": 6066400,
"heapUsedBytes": 99639200,
"domNodes": 149,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.591999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 483.141000000046,
"styleRecalcs": 13,
"styleRecalcDurationMs": 26.891,
"layouts": 3,
"layoutDurationMs": 1.1579999999999997,
"taskDurationMs": 147.87499999999997,
"heapDeltaBytes": 5707932,
"heapUsedBytes": 99565496,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.014999999999997,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/agent-panel-v1 #16667 +/- ##
============================================================
+ Coverage 80.67% 83.02% +2.35%
============================================================
Files 2339 2009 -330
Lines 120790 115753 -5037
Branches 35560 33302 -2258
============================================================
- Hits 97444 96102 -1342
+ Misses 22849 19310 -3539
+ Partials 497 341 -156
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 351 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Severity: Minor (test-integrity) What: Why this is an issue: Repo testing rules ban class assertions; under jsdom it cannot fail for its stated reason, and #16666 restructures the subtree it pins. Proposed Fix: Replace with a behavioral pin or drop the file; the production change is correct and stays. |
|
Severity: Minor What: Why this is an issue: Real clicks on Send never land in a dev session with the chip visible; only keyboard Enter sends. Proposed Fix: Offset the chip when the agent panel is docked, or drop its z-index below the composer. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| <div | ||
| v-else | ||
| class="flex max-h-[70vh] w-[420px] flex-col overflow-hidden rounded-lg border border-border-default bg-base-background shadow-xl" | ||
| class="flex max-h-[70vh] w-[calc(100vw-1.5rem)] max-w-[420px] flex-col overflow-hidden rounded-lg border border-border-default bg-base-background shadow-xl" |
There was a problem hiding this comment.
🟡 Medium — w-[calc(100vw-1.5rem)] uses 100vw, which includes the classic scrollbar gutter, while the wrapper's fixed right-3 offset is measured against the scrollbar-excluded layout viewport. Below ~444px (the only width where max-w-[420px] doesn't clamp) the panel exceeds viewport - 1.5rem, pushing its left edge off-screen and potentially adding horizontal scroll; use 100dvw or drop the calc in favour of left-3 right-3 with w-auto. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| await userEvent.click(chip) | ||
|
|
||
| const panel = screen.getByTestId('crdt-dev-panel-open') | ||
| expect(panel).toHaveClass( |
There was a problem hiding this comment.
🟢 Low — This test only asserts that literal Tailwind class strings appear in the class attribute; happy-dom computes no layout, so it never observes width, height, or overflow and would pass even if Tailwind emitted no rule for the arbitrary w-[calc(...)] candidate — the exact regression it is meant to guard. Repo guidance also forbids tests that depend on utility classes/styles; a Playwright check of the rendered box (or dropping the test) is the honest option, and the right-3/bottom-3/rounded-full/px-3/py-1 assertions on untouched styling are pure change detectors either way. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case).
| isGraphReady, | ||
| rootGraph, | ||
| ui, | ||
| ui |
There was a problem hiding this comment.
⚪ Nit — These two trailing-comma removals are unrelated to the CRDT dev panel change and look like a stray formatter run with different settings than the repo's oxfmt config. Revert them to keep the PR focused (and confirm pnpm format doesn't disagree). Raised by 0 of 8 reviewers (adjudicator).
|
Closing as superseded: the responsive fix targets a panel design that no longer exists on main. Full context for agent readersThe re-carry (fleet row prbase-8) found that main restructured the CRDT dev instrument in #16365 (commit 8f3b156): the panel is no longer a fixed |
|
Accounting corrected: five canonical zero-context hunks; zero residual. Full context for agent readersThe program ledger now enumerates all five |
Full context for agent readers
Replaces the open CRDT dev panel's fixed width with
calc(100vw - 1.5rem)plus the existing 420 px desktop cap. The 1.5 rem subtraction matches the existingright-3offset on both viewport edges.The focused component test also locks the unchanged closed-chip styling, fixed edge offsets, 70vh height cap, and both scrolling regions.
Evidence
$ NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/workbench/extensions/agent/crdt/CrdtDevPanel.responsive.test.ts— 1 test passed.$ NODE_OPTIONS=--no-experimental-webstorage pnpm exec eslint src/workbench/extensions/agent/crdt/CrdtDevPanel.vue src/workbench/extensions/agent/crdt/CrdtDevPanel.responsive.test.ts— passed.$ pnpm exec oxfmt --check src/workbench/extensions/agent/crdt/CrdtDevPanel.vue src/workbench/extensions/agent/crdt/CrdtDevPanel.responsive.test.ts— both files formatted.$ NODE_OPTIONS=--no-experimental-webstorage pnpm typecheck— passed.Base:
nathaniel/agent-panel-v1as required by the FEC lane.