Repository navigation
test(assets): cover useAssetsQuery loadMore transient failure retry - #16641
Conversation
Ports the transient-failure retry coverage from fe #16254 (606c2ac) -- the sole 56-line delta that PR added on top of a now-rewritten stacked base. Re-authored against current main's loadMore()/hasMore contract: - loadMore() resolves void (src/utils/pagedList.ts usePreemptableQueue), not the boolean the original test asserted on. - backingOff (refAutoReset, useAssetsQuery.ts) only arms for the 5xx/network-reject branches of doQuery, not for a malformed-but- received JSON body, so hasMore recovery timing differs per case. Tests use fake timers to advance past the real 2000ms backoff window instead of assuming an immediate reset. Per christian-byrne/blocked-on-christian#292: "if the distinctions mean tests, port." HTTP 500 / malformed JSON / offline are three distinct test cases, so ported rather than closed. Only the retry tests are restored; the rest of the deleted test file's pagination-dedup assertions (loadNew overlap handling, loadMore overlap dedup) no longer match current doLoadMore/loadNew behavior and would need separate, unrelated fixes -- out of scope here.
|
Warning Review limit reachedNext included review available in 34 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎭 Playwright: ✅ 1901 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T11:55:14.853Z",
"gitSha": "ba805c525a6dc4498b78763316b888c1650c2a24",
"branch": "act-fe-16254/port-transient-retry-tests",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.5060000000076,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.186000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.85,
"heapDeltaBytes": -10292760,
"heapUsedBytes": 60307916,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.933999999999997,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2032.6310000000376,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.671,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.245,
"heapDeltaBytes": -11620408,
"heapUsedBytes": 58097820,
"domNodes": -278,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.283999999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2019.8589999999967,
"styleRecalcs": 80,
"styleRecalcDurationMs": 38.91,
"layouts": 14,
"layoutDurationMs": 7.514999999999999,
"taskDurationMs": 993.799,
"heapDeltaBytes": -9512916,
"heapUsedBytes": 60352776,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 172.17100000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.0099999999748,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.765,
"layouts": 14,
"layoutDurationMs": 4.0040000000000004,
"taskDurationMs": 888.871,
"heapDeltaBytes": 3111060,
"heapUsedBytes": 72377116,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 157.61700000000002,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.8800000000556,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.928999999999998,
"layouts": 6,
"layoutDurationMs": 1.063,
"taskDurationMs": 355.147,
"heapDeltaBytes": 5072628,
"heapUsedBytes": 75799020,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.090000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.7079999998605,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.252000000000002,
"layouts": 6,
"layoutDurationMs": 1.135,
"taskDurationMs": 341.55899999999997,
"heapDeltaBytes": 5102044,
"heapUsedBytes": 75777880,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.604000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 633.6600000000772,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.583,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.679,
"heapDeltaBytes": -8153332,
"heapUsedBytes": 62492768,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 164.65400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 672.9480000000194,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.661999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.64099999999996,
"heapDeltaBytes": -7777644,
"heapUsedBytes": 62864844,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 160.37199999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2051.1040000000094,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.756000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.822,
"heapDeltaBytes": -13015444,
"heapUsedBytes": 87338396,
"domNodes": -267,
"jsHeapTotalBytes": -839680,
"scriptDurationMs": 30.479999999999993,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2022.9589999999007,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.3380000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.371,
"heapDeltaBytes": 10839580,
"heapUsedBytes": 87016412,
"domNodes": -272,
"jsHeapTotalBytes": -1925120,
"scriptDurationMs": 30.74099999999999,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2300.6299999999555,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.840999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1644.264,
"heapDeltaBytes": 12533032,
"heapUsedBytes": 88514264,
"domNodes": -272,
"jsHeapTotalBytes": -651264,
"scriptDurationMs": 817.1,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2225.4629999999906,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.075999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1598.803,
"heapDeltaBytes": -12562720,
"heapUsedBytes": 89176012,
"domNodes": -267,
"jsHeapTotalBytes": -1925120,
"scriptDurationMs": 801.836,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3605.4570000000012,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.997000000000002,
"layouts": 60,
"layoutDurationMs": 12.382,
"taskDurationMs": 1715.164,
"heapDeltaBytes": 12232840,
"heapUsedBytes": 80172800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 813.3399999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3489.945999999918,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.136,
"layouts": 60,
"layoutDurationMs": 11.51,
"taskDurationMs": 1648.32,
"heapDeltaBytes": 7726244,
"heapUsedBytes": 75070164,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 755.2529999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3040.3949999999895,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.517999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1871.378,
"heapDeltaBytes": 22430976,
"heapUsedBytes": 89358996,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 934.304,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3065.350999999964,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.668000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1893.7329999999997,
"heapDeltaBytes": 25801096,
"heapUsedBytes": 93146892,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 952.3979999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.4970000000294,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.7560000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.4259999999999,
"heapDeltaBytes": 22233384,
"heapUsedBytes": 87979556,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.36,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2025.4789999999048,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.0329999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.6629999999999,
"heapDeltaBytes": 10674980,
"heapUsedBytes": 86828380,
"domNodes": -269,
"jsHeapTotalBytes": -2187264,
"scriptDurationMs": 28.31600000000001,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.0300000000552,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.422,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.165,
"heapDeltaBytes": 15232968,
"heapUsedBytes": 87893828,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 142.068,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.9510000000901,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.126999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.85400000000004,
"heapDeltaBytes": 14823484,
"heapUsedBytes": 87411220,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 145.71699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.8569999999918,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.9499999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.24100000000004,
"heapDeltaBytes": -6951504,
"heapUsedBytes": 65727616,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.832999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1991.9300000000248,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.4990000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.288,
"heapDeltaBytes": -8171192,
"heapUsedBytes": 64701844,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.755000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.7730000000083,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.369,
"layouts": 18,
"layoutDurationMs": 4.5729999999999995,
"taskDurationMs": 784.917,
"heapDeltaBytes": 2098128,
"heapUsedBytes": 74668996,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 103.173,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.931999999938,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.211999999999996,
"layouts": 18,
"layoutDurationMs": 5.495,
"taskDurationMs": 823.1310000000001,
"heapDeltaBytes": 3256408,
"heapUsedBytes": 75710052,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 113.46599999999998,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.4150000000582,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.603000000000005,
"layouts": 15,
"layoutDurationMs": 15.190999999999995,
"taskDurationMs": 914.8669999999998,
"heapDeltaBytes": -7279488,
"heapUsedBytes": 85840216,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 29.976000000000003,
"eventListeners": 2381,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8481.101999999964,
"styleRecalcs": 245,
"styleRecalcDurationMs": 33.665,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5891.878,
"heapDeltaBytes": 10835600,
"heapUsedBytes": 86021432,
"domNodes": -276,
"jsHeapTotalBytes": -651264,
"scriptDurationMs": 2801.867,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8471.334999999954,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.034000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5690.533,
"heapDeltaBytes": -11523200,
"heapUsedBytes": 89308392,
"domNodes": -267,
"jsHeapTotalBytes": -352256,
"scriptDurationMs": 2672.5060000000003,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16776.204000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15936.595000000001,
"heapDeltaBytes": -40976676,
"heapUsedBytes": 175257512,
"domNodes": -6548,
"jsHeapTotalBytes": 3395584,
"scriptDurationMs": 267.765,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16509.455000000118,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15566.746,
"heapDeltaBytes": -34798888,
"heapUsedBytes": 176032324,
"domNodes": -6548,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 247.882,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20643.03899999993,
"styleRecalcs": 176,
"styleRecalcDurationMs": 17.92699999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20254.965000000004,
"heapDeltaBytes": -27615612,
"heapUsedBytes": 180128796,
"domNodes": -6548,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 955.0240000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 80,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20592.527000000016,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.448000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20174.893,
"heapDeltaBytes": -12664812,
"heapUsedBytes": 190077156,
"domNodes": -6548,
"jsHeapTotalBytes": 94208,
"scriptDurationMs": 891.837,
"eventListeners": -7467,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5888.9520000000175,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.07300000000001,
"layouts": 20,
"layoutDurationMs": 21.65199999999999,
"taskDurationMs": 5799.7750000000015,
"heapDeltaBytes": -20985940,
"heapUsedBytes": 181229780,
"domNodes": -6548,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 109.03900000000002,
"eventListeners": -7469,
"totalBlockingTimeMs": 333,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5822.255000000041,
"styleRecalcs": 20,
"styleRecalcDurationMs": 92.42499999999998,
"layouts": 20,
"layoutDurationMs": 27.336000000000013,
"taskDurationMs": 5715.288,
"heapDeltaBytes": -33963848,
"heapUsedBytes": 175934072,
"domNodes": -6548,
"jsHeapTotalBytes": 5394432,
"scriptDurationMs": 101.85399999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 301,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 125.83200000005945,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.623000000000001,
"layouts": 2,
"layoutDurationMs": 1.137,
"taskDurationMs": 83.142,
"heapDeltaBytes": 3146188,
"heapUsedBytes": 71251784,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.514,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 147.0529999999144,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.732999999999999,
"layouts": 2,
"layoutDurationMs": 0.7909999999999999,
"taskDurationMs": 80.77299999999998,
"heapDeltaBytes": 3011252,
"heapUsedBytes": 71533944,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.061,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16641 +/- ##
==========================================
+ Coverage 80.73% 82.37% +1.63%
==========================================
Files 2438 2031 -407
Lines 124324 117236 -7088
Branches 32894 29508 -3386
==========================================
- Hits 100378 96572 -3806
+ Misses 23444 20486 -2958
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Ports the transient-failure retry coverage for
useAssetsQuery'sloadMore()from fe #16254, which sat on a now-rewritten stacked base (test/assets-delete-cache-refetch-coverage) and had drifted to 83 commits / 38 conflicts against it. The PR's actual content was a single 56-line test addition to the now-deleteduseAssetsQuery.test.ts.Per christian-byrne/blocked-on-christian#292: "If the distinctions mean tests, port." The three transient-failure cases (HTTP 500, malformed JSON, offline request) are distinct test cases, so this ports them rather than closing the source PR outright.
Re-authoring notes (not a mechanical port)
The original test asserted
loadMore()resolves to abooleansuccess signal and thathasMorestaystrueimmediately after every failure. Neither holds against currentmain:loadMore()now resolvesvoidviausePreemptableQueue().enqueue(src/utils/pagedList.ts), so assertions here checkitems/hasMorestate instead of a resolved boolean.backingOff(refAutoReset(false, 2000)inuseAssetsQuery.ts) only arms for the 5xx/429 and network-reject branches ofdoQuery— not for a successfully-received-but-malformed JSON body. SohasMoreonly drops immediately for the HTTP-500 and offline cases; the malformed-JSON case never backs off. Tests use fake timers to advance past the real 2000ms window for the cases that do back off, rather than assuming an immediate reset.Only the retry tests are restored. The rest of the deleted file's pagination-dedup assertions (
loadNewoverlap handling,loadMoreoverlap dedup) no longer match currentdoLoadMore/loadNewbehavior (no overlap dedup today,knownIdsnot updated mid-walk inloadNew) — re-adding those would mean fixing unrelated behavior, out of scope here.Evidence
Supersedes fe #16254, which will be closed referencing this PR.