Skip to content

test(assets): cover pagination failure retries - #16254

Closed
christian-byrne wants to merge 83 commits into
test/assets-delete-cache-refetch-coveragefrom
test/assets-pagination-retry
Closed

christian-byrne wants to merge 83 commits into
test/assets-delete-cache-refetch-coveragefrom
test/assets-pagination-retry

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor
  • Covers pagination failure/retry invariants.
  • Preserves rows and exact cursor.
  • Exercises HTTP, decode, and offline failures.
Full context for agent readers

Adds parameterized query-layer regression coverage for the pagination failure/recovery case.

The tests verify that HTTP 500, malformed JSON, and rejected/offline requests:

  • report the correct failure reason;
  • leave already-renderable asset rows intact;
  • retain hasMore so recovery remains available;
  • retry the exact failed after=page-2 cursor;
  • append the recovered page once and settle pagination.

Validation:

  • targeted and adjacent pagination/store suites: 69/69 green;
  • typecheck, ESLint, type-aware oxlint, format, knip, diff check, commit hooks, and push hook: green;
  • mutation proof: clearing the cursor on failure made all three new rows fail at the exact cursor assertion.

Stacked on #16253 to preserve the active Assets test stack.

One test is failing and will need to be addressed
Need to put some further thought into loadNew invalidation.
Ideal case is that output is flagged stale and async fetch doesn't occur
if there isn't active dependent? But per current design specs, all
existent views should be subscribed and thus require update.

That a new 'output' asset might farm out 3 requests (all: load node,
outputs, outputs+temp) leaves a bad taste in my mouth
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 29, 2026
@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9e111b1b-bb0a-45e4-aba2-8090836f724c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne self-assigned this Aug 29, 2026
@github-actions

github-actions Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/29/2026, 08:31:34 PM UTC

Links

🎭 Playwright: ✅ 1997 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1976 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 123ms TBT · 90.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 14ms TBT · 76.3 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.3 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 86ms TBT · 167.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 551ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 70.4 MB
canvas-idle: DOM nodes -284
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 43ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 1313ms
canvas-mouse-sweep: script duration 162ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.8 MB
canvas-mouse-sweep: DOM nodes -283
canvas-mouse-sweep: event listeners -169
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 396ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.4 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 429ms
dom-widget-clipping: script duration 33ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 59.4 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 1ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 2
large-graph-idle: task duration 584ms
large-graph-idle: script duration 40ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 69.8 MB
large-graph-idle: DOM nodes -276
large-graph-idle: event listeners -75
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 2684ms
large-graph-pan: script duration 933ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 72.3 MB
large-graph-pan: DOM nodes -279
large-graph-pan: event listeners -166
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 2624ms
large-graph-zoom: script duration 892ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 76.3 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 11
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 2142ms
legacy-node-drag: script duration 213ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 67.4 MB
legacy-node-drag: DOM nodes -143
legacy-node-drag: event listeners 94
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 628ms
minimap-idle: script duration 43ms
minimap-idle: TBT 0ms
minimap-idle: heap used 69.4 MB
minimap-idle: DOM nodes -275
minimap-idle: event listeners -170
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 512ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.8 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 562ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.7 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 41ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 1155ms
subgraph-mouse-sweep: script duration 115ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.0 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1018ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 123ms
subgraph-transition-enter: heap used 90.2 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 9106ms
viewport-pan-sweep: script duration 3090ms
viewport-pan-sweep: TBT 14ms
viewport-pan-sweep: heap used 76.3 MB
viewport-pan-sweep: DOM nodes -282
viewport-pan-sweep: event listeners -144
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17592ms
vue-large-graph-idle: script duration 366ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.3 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 23ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 173
vue-large-graph-pan: task duration 22114ms
vue-large-graph-pan: script duration 921ms
vue-large-graph-pan: TBT 86ms
vue-large-graph-pan: heap used 167.9 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 26ms
workflow-execution: layout count 4
workflow-execution: style recalc count 18
workflow-execution: task duration 132ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.3 MB
workflow-execution: DOM nodes 135
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-29T20:43:09.526Z",
  "gitSha": "2b15b271e5f23ae76a677c2032e577d3fc419408",
  "branch": "test/assets-pagination-retry",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2068.3689999999897,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.784000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 609.293,
      "heapDeltaBytes": -3908900,
      "heapUsedBytes": 65540792,
      "domNodes": -284,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 11.754999999999997,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2018.231999999898,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.263999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 493.15,
      "heapDeltaBytes": 12935600,
      "heapUsedBytes": 82130708,
      "domNodes": -284,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.765,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2396.355000000028,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 47.867999999999995,
      "layouts": 12,
      "layoutDurationMs": 4.002999999999999,
      "taskDurationMs": 1441.7230000000002,
      "heapDeltaBytes": 449532,
      "heapUsedBytes": 62776220,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 177.83900000000003,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2149.6799999999894,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 38.242,
      "layouts": 12,
      "layoutDurationMs": 3.5649999999999995,
      "taskDurationMs": 1183.601,
      "heapDeltaBytes": 5936464,
      "heapUsedBytes": 75247068,
      "domNodes": -283,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 145.79699999999997,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1742.9139999999848,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.476,
      "layouts": 6,
      "layoutDurationMs": 0.7129999999999999,
      "taskDurationMs": 386.08,
      "heapDeltaBytes": 4356120,
      "heapUsedBytes": 73970292,
      "domNodes": 75,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 13.633000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1747.5749999999834,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.938000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.7340000000000001,
      "taskDurationMs": 405.40899999999993,
      "heapDeltaBytes": 4331204,
      "heapUsedBytes": 73709720,
      "domNodes": 74,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 13.924000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 719.0679999999929,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.338000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 440.47200000000004,
      "heapDeltaBytes": -6823176,
      "heapUsedBytes": 62237320,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 33.73800000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 707.7800000000707,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.21,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.09,
      "heapDeltaBytes": -6772100,
      "heapUsedBytes": 62327124,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 32.108,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2060.6789999999933,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.855,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 641.8909999999998,
      "heapDeltaBytes": -17987332,
      "heapUsedBytes": 73219592,
      "domNodes": -273,
      "jsHeapTotalBytes": -2101248,
      "scriptDurationMs": 41.121,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2009.5720000000483,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.3979999999999,
      "heapDeltaBytes": 8804316,
      "heapUsedBytes": 73259140,
      "domNodes": -278,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 38.038999999999994,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3419.8499999999967,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.239,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2792.694,
      "heapDeltaBytes": -24323272,
      "heapUsedBytes": 67082088,
      "domNodes": -280,
      "jsHeapTotalBytes": 4190208,
      "scriptDurationMs": 958.7479999999999,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3278.652000000079,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 10.091,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2575.44,
      "heapDeltaBytes": -7749860,
      "heapUsedBytes": 84441928,
      "domNodes": -278,
      "jsHeapTotalBytes": -1875968,
      "scriptDurationMs": 906.467,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4583.964999999978,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.638,
      "layouts": 60,
      "layoutDurationMs": 8.466999999999999,
      "taskDurationMs": 2736.673,
      "heapDeltaBytes": 10646476,
      "heapUsedBytes": 79861392,
      "domNodes": 24,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 911.841,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4269.729999999981,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.772000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.882,
      "taskDurationMs": 2512.3100000000004,
      "heapDeltaBytes": 10380632,
      "heapUsedBytes": 80063604,
      "domNodes": 24,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 873.005,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3268.525000000011,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.291999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2224.765,
      "heapDeltaBytes": 3270048,
      "heapUsedBytes": 71016352,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 226.11000000000004,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3225.8489999999256,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2058.632,
      "heapDeltaBytes": -4013616,
      "heapUsedBytes": 70299604,
      "domNodes": -285,
      "jsHeapTotalBytes": -827392,
      "scriptDurationMs": 200.561,
      "eventListeners": -1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2013.4180000000015,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.6499999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 567.4770000000001,
      "heapDeltaBytes": 9543840,
      "heapUsedBytes": 74374860,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 41.946000000000005,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2059.855999999968,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.083,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 688.164,
      "heapDeltaBytes": -21493668,
      "heapUsedBytes": 71224508,
      "domNodes": -276,
      "jsHeapTotalBytes": 3403776,
      "scriptDurationMs": 45.03699999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 725.0020000000177,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.288999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 504.9380000000001,
      "heapDeltaBytes": 17479868,
      "heapUsedBytes": 87608884,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 137.618,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 744.2889999999807,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.857999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 519.324,
      "heapDeltaBytes": 18199772,
      "heapUsedBytes": 88106808,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 145.641,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.7979999999898,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.296,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 561.985,
      "heapDeltaBytes": -12508788,
      "heapUsedBytes": 57673812,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 9.592,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2051.2500000000955,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.084000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 561.3770000000001,
      "heapDeltaBytes": -544160,
      "heapUsedBytes": 69631496,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 9.743,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1926.2679999999932,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 41.297,
      "layouts": 16,
      "layoutDurationMs": 4.66,
      "taskDurationMs": 1154.2180000000003,
      "heapDeltaBytes": 8189596,
      "heapUsedBytes": 78994156,
      "domNodes": -295,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 115.357,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1916.3560000000643,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 40.26,
      "layouts": 16,
      "layoutDurationMs": 4.678,
      "taskDurationMs": 1155.9759999999999,
      "heapDeltaBytes": -4322416,
      "heapUsedBytes": 65806644,
      "domNodes": -298,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 114.773,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1416.0699999999906,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.979999999999993,
      "layouts": 14,
      "layoutDurationMs": 14.101000000000003,
      "taskDurationMs": 1018.2020000000002,
      "heapDeltaBytes": -1837596,
      "heapUsedBytes": 94591956,
      "domNodes": 13671,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 30.899000000000004,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 123,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12389.96000000003,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 39.00099999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9180.979,
      "heapDeltaBytes": 1427760,
      "heapUsedBytes": 92117540,
      "domNodes": -282,
      "jsHeapTotalBytes": 4907008,
      "scriptDurationMs": 3092.473,
      "eventListeners": -129,
      "totalBlockingTimeMs": 10,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12395.019000000048,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 41.993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9030.500999999998,
      "heapDeltaBytes": -23499648,
      "heapUsedBytes": 67850200,
      "domNodes": -281,
      "jsHeapTotalBytes": 4976640,
      "scriptDurationMs": 3087.518,
      "eventListeners": -159,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 16.670000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17957.78999999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17254.983000000004,
      "heapDeltaBytes": -35799700,
      "heapUsedBytes": 176432980,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3919872,
      "scriptDurationMs": 371.852,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18419.808999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17929.501,
      "heapDeltaBytes": -30343176,
      "heapUsedBytes": 180677712,
      "domNodes": -6548,
      "jsHeapTotalBytes": 188416,
      "scriptDurationMs": 360.68999999999994,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21903.33500000003,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 20.32499999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21588.128999999997,
      "heapDeltaBytes": -28474412,
      "heapUsedBytes": 175955328,
      "domNodes": -6548,
      "jsHeapTotalBytes": 249856,
      "scriptDurationMs": 903.844,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 83,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22908.397000000037,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 25.144999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22638.947,
      "heapDeltaBytes": -28355636,
      "heapUsedBytes": 176188696,
      "domNodes": -6548,
      "jsHeapTotalBytes": 512000,
      "scriptDurationMs": 938.331,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 88,
      "frameDurationMs": 18.333333333333453,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 473.4760000000051,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 23.154999999999994,
      "layouts": 4,
      "layoutDurationMs": 1.5729999999999997,
      "taskDurationMs": 131.182,
      "heapDeltaBytes": 5628460,
      "heapUsedBytes": 72874096,
      "domNodes": 148,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 8.048,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 482.49199999997927,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 28.192999999999994,
      "layouts": 4,
      "layoutDurationMs": 1.496,
      "taskDurationMs": 133.316,
      "heapDeltaBytes": 5477164,
      "heapUsedBytes": 72438420,
      "domNodes": 121,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.654999999999998,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 29, 2026
@codecov

codecov Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.08108% with 84 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../platform/assets/composables/media/assetMappers.ts 7.50% 37 Missing ⚠️
src/stores/assetsStore.ts 70.10% 28 Missing and 1 partial ⚠️
src/platform/assets/composables/useAssetsQuery.ts 90.19% 10 Missing ⚠️
...latform/assets/composables/useMediaAssetActions.ts 92.68% 3 Missing ⚠️
...eNodes/widgets/components/WidgetSelectDropdown.vue 50.00% 2 Missing ⚠️
src/components/sidebar/tabs/AssetsSidebarTab.vue 87.50% 1 Missing ⚠️
src/platform/assets/utils/outputKeyUtil.ts 80.00% 1 Missing ⚠️
...c/renderer/extensions/linearMode/OutputHistory.vue 88.88% 1 Missing ⚠️
@@                              Coverage Diff                              @@
##           test/assets-delete-cache-refetch-coverage   #16254      +/-   ##
=============================================================================
+ Coverage                                      80.02%   82.41%   +2.39%     
=============================================================================
  Files                                           2251     1923     -328     
  Lines                                         114236   109333    -4903     
  Branches                                       31608    30775     -833     
=============================================================================
- Hits                                           91413    90103    -1310     
+ Misses                                         22355    18887    -3468     
+ Partials                                         468      343     -125     
Flag Coverage Δ
e2e 67.03% <59.30%> (-0.08%) ⬇️
unit 74.26% <67.75%> (-0.08%) ⬇️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/queue/QueueProgressOverlay.vue 69.85% <100.00%> (+15.83%) ⬆️
src/composables/node/useNodeImageUpload.ts 94.54% <100.00%> (-0.10%) ⬇️
src/composables/queue/useJobMenu.ts 96.15% <ø> (-3.16%) ⬇️
src/composables/useFeatureFlags.ts 87.73% <100.00%> (+0.60%) ⬆️
...tform/assets/composables/useMediaAssetFiltering.ts 98.27% <100.00%> (ø)
src/platform/assets/composables/useOutputStacks.ts 95.00% <ø> (ø)
src/platform/assets/schemas/assetMetadataSchema.ts 100.00% <100.00%> (ø)
src/platform/assets/services/assetService.ts 82.31% <100.00%> (-1.34%) ⬇️
src/platform/assets/utils/assetPreviewUtil.ts 90.69% <100.00%> (-0.22%) ⬇️
src/platform/assets/utils/outputAssetUtil.ts 100.00% <ø> (+1.11%) ⬆️
... and 19 more

... and 349 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

TL;DR: retargeting is blocked because current main deleted both useAssetsQuery.ts and useAssetsQuery.test.ts; the PR’s sole 56-line delta tests retry semantics for that removed API. No branch mutation was made.

Full context for agent readers

At exact source head 606c2ac30b8d461596a99121c007127188525835, cherry-picking the single commit onto current main (a85d6d7c3eddf5337814e1747f56202c8df5549c) produces a modify/delete conflict in src/platform/assets/composables/useAssetsQuery.test.ts. A source search confirms current main has no useAssetsQuery implementation to exercise. Retaining the deleted test would also require reviving the obsolete stacked assets query seam, while dropping it would make this PR empty. Resume when a main-based replacement pagination API exists and port the retry invariant there, or record an explicit intentional-drop decision.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Re-verified against current main (a9d81e1928): the retarget blocker is real but the prior characterization was slightly off — src/platform/assets/composables/useAssetsQuery.ts (the implementation) still exists on main; only useAssetsQuery.test.ts was deleted. Cherry-picking 606c2ac30b cleanly restores the test file's contents, but 8/11 tests then fail: loadMore() used to resolve to a boolean success signal, and on current main usePreemptableQueue().enqueue returns Promise<void> (src/utils/pagedList.ts:118), so loadMore() no longer carries a success/failure return value at all. The retry/backoff behavior this test wants to cover still exists (backingOff, morePages in useAssetsQuery.ts), but the test would need to be rewritten to assert on hasMore/state transitions instead of resolves.toBe(true/false).

Two options: (1) rewrite the retry test's assertions against the new void-returning enqueue contract (drop the resolves.toBe(...) checks, assert on hasMore/items state after await list.loadMore() instead), or (2) treat this as superseded by whatever test coverage already exists for the current pagination/backoff implementation and close this PR. Since this changes what the test actually asserts (not a mechanical port), leaving for a decision rather than guessing at the intended semantics.

@christian-byrne
christian-byrne force-pushed the test/assets-delete-cache-refetch-coverage branch from fddf035 to 3c83887 Compare September 2, 2026 04:20
@christian-byrne
christian-byrne requested a review from a team as a code owner September 2, 2026 04:20
@christian-byrne

Copy link
Copy Markdown
Contributor Author

The target test seam was deleted by the updated stack base. Safe options: close this PR as superseded, or explicitly port its extra failure-mode matrix to the replacement store tests.

Full context for agent readers
  • The PR adds only useAssetsQuery.test.ts coverage for retrying the same cursor after HTTP 500, malformed JSON, and offline failures.
  • Updated base test/assets-delete-cache-refetch-coverage moved output pagination into assetsStore and deleted useAssetsQuery.test.ts.
  • Replacement coverage already asserts that a failed loadMoreFlatOutputs() preserves rows, hasMore, and the cursor, then retries the same cursor successfully in assetsStore.test.ts.
  • Recommended disposition: close as superseded. Alternative: port only the additional HTTP/JSON failure distinctions at the assetService boundary if that distinction is still required; restoring the deleted composable test would revive obsolete architecture.
  • Rebase was aborted; no branch mutation was pushed.

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@christian-byrne
christian-byrne force-pushed the test/assets-delete-cache-refetch-coverage branch from 3c83887 to fb2948e Compare September 2, 2026 07:50

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Against the current stacked base, the true diff is 77 files and +2,684/-2,621, not the intended 56-line test addition. The base was rewritten, the range now contains 83 commits, and the PR has 38 local merge conflicts. The replacement assetsStore tests already cover retaining rows, hasMore, and cursor reuse after a failed pagination request. I found no new point beyond the existing supersession feedback. Close this as superseded, or port only the additional HTTP/decode/offline distinctions to the current service/store tests. Typecheck, scoped lint/format, 69 focused unit tests, and Playwright --list pass on the current head.

@christian-byrne
christian-byrne force-pushed the test/assets-delete-cache-refetch-coverage branch from fb2948e to 614cc93 Compare September 2, 2026 09:35
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Queue bookkeeping is blocked: the task ID exists twice, and the program-repo lock timed out twice while removing only the stale duplicate. No PR branch mutation occurred.

Full context for agent readers
  • scripts/claim.sh act-fe-16254-rebase-b75ef91a lane-act-fe-16254-rebase-b75ef91a refused the claim because todo.md contains two entries with the same ID.
  • origin/main:todo.md also contains both entries, so this is not an unpulled local artifact.
  • The newer entry includes the corrected current-main investigation and prior evidence; the stale duplicate contains only the original, inaccurate blocker.
  • I prepared a one-line deletion of only the stale duplicate in a private worktree.
  • check-no-conflict-markers.sh todo.md passed.
  • check-todo-regression.sh origin/main passed with [x] 3579 -> 3579.
  • Two separate with-repo-lock.sh attempts each timed out after 120 seconds, so lock doctrine requires escalation instead of another wait or push loop.

Exact commander action: remove the stale duplicate act-fe-16254-rebase-b75ef91a row near the later actioncompiler block, preserving the earlier row with the 2026-09-02 correction; then redispatch the row.

christian-byrne added a commit that referenced this pull request Sep 2, 2026
Ports the transient-failure retry coverage from fe #16254
(606c2ac) -- the sole 56-line delta that PR added on top of a
now-rewritten stacked base. Re-authored against current main's
loadMore()/hasMore contract:

- loadMore() resolves void (src/utils/pagedList.ts usePreemptableQueue),
  not the boolean the original test asserted on.
- backingOff (refAutoReset, useAssetsQuery.ts) only arms for the
  5xx/network-reject branches of doQuery, not for a malformed-but-
  received JSON body, so hasMore recovery timing differs per case.
  Tests use fake timers to advance past the real 2000ms backoff
  window instead of assuming an immediate reset.

Per christian-byrne/blocked-on-christian#292: "if the distinctions
mean tests, port." HTTP 500 / malformed JSON / offline are three
distinct test cases, so ported rather than closed.

Only the retry tests are restored; the rest of the deleted test
file's pagination-dedup assertions (loadNew overlap handling,
loadMore overlap dedup) no longer match current doLoadMore/loadNew
behavior and would need separate, unrelated fixes -- out of scope
here.
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing as superseded — retry coverage ported to fe #16641.

Full context for agent readers

The sole content delta of this PR (56-line useAssetsQuery.test.ts retry coverage for HTTP 500 / malformed JSON / offline) is ported and re-authored against current main's loadMore()/hasMore contract in fe #16641. Per christian-byrne/blocked-on-christian#292: "if the distinctions mean tests, port."

zeus-onl pushed a commit to zeus-onl/ComfyUI_frontend that referenced this pull request Sep 2, 2026
…omfy-Org#16641)

## Summary

Ports the transient-failure retry coverage for `useAssetsQuery`'s
`loadMore()` from [fe
Comfy-Org#16254](Comfy-Org#16254), which
sat on a now-rewritten stacked base
(`test/assets-delete-cache-refetch-coverage`) and had drifted to 83
commits / 38 conflicts against it. The PR's actual content was a single
56-line test addition to the now-deleted `useAssetsQuery.test.ts`.

Per
[christian-byrne/blocked-on-christian#292](christian-byrne/blocked-on-christian#292 (comment)):
"If the distinctions mean tests, port." The three transient-failure
cases (HTTP 500, malformed JSON, offline request) are distinct test
cases, so this ports them rather than closing the source PR outright.

## Re-authoring notes (not a mechanical port)

The original test asserted `loadMore()` resolves to a `boolean` success
signal and that `hasMore` stays `true` immediately after every failure.
Neither holds against current `main`:

- `loadMore()` now resolves `void` via `usePreemptableQueue().enqueue`
(`src/utils/pagedList.ts`), so assertions here check `items`/`hasMore`
state instead of a resolved boolean.
- `backingOff` (`refAutoReset(false, 2000)` in `useAssetsQuery.ts`) only
arms for the 5xx/429 and network-reject branches of `doQuery` — not for
a successfully-received-but-malformed JSON body. So `hasMore` only drops
immediately for the HTTP-500 and offline cases; the malformed-JSON case
never backs off. Tests use fake timers to advance past the real 2000ms
window for the cases that do back off, rather than assuming an immediate
reset.

Only the retry tests are restored. The rest of the deleted file's
pagination-dedup assertions (`loadNew` overlap handling, `loadMore`
overlap dedup) no longer match current `doLoadMore`/`loadNew` behavior
(no overlap dedup today, `knownIds` not updated mid-walk in `loadNew`) —
re-adding those would mean fixing unrelated behavior, out of scope here.

## Evidence

```
$ pnpm exec vitest run src/platform/assets/composables/useAssetsQuery.test.ts
 Test Files  1 passed (1)
      Tests  3 passed (3)

$ pnpm exec oxlint --type-aware --no-error-on-unmatched-pattern src/platform/assets/composables/useAssetsQuery.test.ts
(clean)

$ pnpm exec vue-tsc --noEmit -p tsconfig.json
(no errors in useAssetsQuery files)
```

Supersedes [fe
Comfy-Org#16254](Comfy-Org#16254), which
will be closed referencing this PR.

<!-- authored-by:agent lane-act-fe-16254-rebase-b75ef91a -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants