Repository navigation
Stabilize merge queue browser tests - #16669
Conversation
🎨 Storybook: 🚧 Building...🎭 Playwright: ✅ 1902 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.68 MB gzip 🟢 -158 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • 🟢 -446 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 223 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T16:13:43.961Z",
"gitSha": "1f389649b2a8b69c2a7ec1eaa3330224148b4f95",
"branch": "christian-byrne/mqflake-1",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.9169999999926,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.862,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.40700000000004,
"heapDeltaBytes": -10828084,
"heapUsedBytes": 59630128,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.224,
"eventListeners": -213,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2050.881000000004,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.421000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.359,
"heapDeltaBytes": 11451356,
"heapUsedBytes": 81853384,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.353,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.1749999999743,
"styleRecalcs": 73,
"styleRecalcDurationMs": 22.056,
"layouts": 14,
"layoutDurationMs": 3.248,
"taskDurationMs": 719.347,
"heapDeltaBytes": 6141976,
"heapUsedBytes": 76972692,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 98.40800000000002,
"eventListeners": -178,
"totalBlockingTimeMs": 14,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1705.5330000000595,
"styleRecalcs": 75,
"styleRecalcDurationMs": 21.707,
"layouts": 14,
"layoutDurationMs": 2.8579999999999997,
"taskDurationMs": 582.149,
"heapDeltaBytes": -12794012,
"heapUsedBytes": 57788732,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 84.864,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.4930000000213,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.863999999999999,
"layouts": 6,
"layoutDurationMs": 0.7800000000000001,
"taskDurationMs": 244.40800000000002,
"heapDeltaBytes": 5179436,
"heapUsedBytes": 75988124,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7.244000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.8419999999933,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.593999999999998,
"layouts": 6,
"layoutDurationMs": 1.1149999999999998,
"taskDurationMs": 257.95500000000004,
"heapDeltaBytes": 4657832,
"heapUsedBytes": 74703396,
"domNodes": 79,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8.411000000000001,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 737.212999999997,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.0680000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.958,
"heapDeltaBytes": 18806700,
"heapUsedBytes": 87857312,
"domNodes": 6,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 101.41600000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 183,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 509.40400000001773,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.888,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.755,
"heapDeltaBytes": 17628448,
"heapUsedBytes": 87877528,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 104.659,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2013.104999999996,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.3770000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.59399999999994,
"heapDeltaBytes": 23042520,
"heapUsedBytes": 87978812,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.358999999999995,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2019.5879999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.538,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.5679999999999,
"heapDeltaBytes": -13404692,
"heapUsedBytes": 86916332,
"domNodes": -263,
"jsHeapTotalBytes": -1110016,
"scriptDurationMs": 24.281,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2126.4549999999645,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.502999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1063.126,
"heapDeltaBytes": -16707072,
"heapUsedBytes": 84692704,
"domNodes": -266,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 485.00300000000004,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2076.4420000000428,
"styleRecalcs": 65,
"styleRecalcDurationMs": 8.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1106.779,
"heapDeltaBytes": 21630084,
"heapUsedBytes": 87220284,
"domNodes": 6,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 524.2470000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3107.800999999995,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.229,
"layouts": 60,
"layoutDurationMs": 11.221,
"taskDurationMs": 1228.766,
"heapDeltaBytes": 8548880,
"heapUsedBytes": 75903568,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 518.501,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3071.101999999996,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.517999999999999,
"layouts": 60,
"layoutDurationMs": 9.9,
"taskDurationMs": 1127.6139999999998,
"heapDeltaBytes": 8518944,
"heapUsedBytes": 75559488,
"domNodes": -275,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 478.89000000000004,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2165.4510000000187,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.81,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1253.43,
"heapDeltaBytes": 17053380,
"heapUsedBytes": 84384812,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 580.2779999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2148.851000000036,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.256,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1244.9109999999998,
"heapDeltaBytes": 13460960,
"heapUsedBytes": 81240828,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 582.847,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2015.984000000003,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.9770000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.95200000000006,
"heapDeltaBytes": 10715416,
"heapUsedBytes": 87668684,
"domNodes": -269,
"jsHeapTotalBytes": -1933312,
"scriptDurationMs": 22.418000000000006,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2015.6100000000379,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.016000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.018,
"heapDeltaBytes": -14426992,
"heapUsedBytes": 88052732,
"domNodes": -266,
"jsHeapTotalBytes": -2158592,
"scriptDurationMs": 28.674,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 427.3900000000026,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.991999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 262.77399999999994,
"heapDeltaBytes": 14902048,
"heapUsedBytes": 87431372,
"domNodes": 24,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 81.688,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 447.2039999999424,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.828000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 274.03900000000004,
"heapDeltaBytes": 14867644,
"heapUsedBytes": 87772860,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 88.878,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1989.2879999999877,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.039999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.83400000000006,
"heapDeltaBytes": -7997936,
"heapUsedBytes": 64433648,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 5.971000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.8380000000398,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.961000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.88,
"heapDeltaBytes": 3939264,
"heapUsedBytes": 76504088,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.2749999999999995,
"eventListeners": -224,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.166999999993,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.224999999999998,
"layouts": 18,
"layoutDurationMs": 3.3770000000000002,
"taskDurationMs": 581.0909999999999,
"heapDeltaBytes": 2431048,
"heapUsedBytes": 75302716,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 66.283,
"eventListeners": -224,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.9169999999913,
"styleRecalcs": 79,
"styleRecalcDurationMs": 25.584999999999997,
"layouts": 18,
"layoutDurationMs": 3.491,
"taskDurationMs": 640.351,
"heapDeltaBytes": -11798756,
"heapUsedBytes": 60761792,
"domNodes": -293,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 68.379,
"eventListeners": -224,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 898.7379999999803,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.571,
"layouts": 16,
"layoutDurationMs": 9.809,
"taskDurationMs": 637.013,
"heapDeltaBytes": -1855212,
"heapUsedBytes": 95929336,
"domNodes": 13751,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 21.87,
"eventListeners": 2381,
"totalBlockingTimeMs": 82,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8139.073999999993,
"styleRecalcs": 249,
"styleRecalcDurationMs": 21.642000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3588.2760000000003,
"heapDeltaBytes": -11656528,
"heapUsedBytes": 88866328,
"domNodes": -265,
"jsHeapTotalBytes": -1409024,
"scriptDurationMs": 1562.3700000000001,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8154.862999999978,
"styleRecalcs": 250,
"styleRecalcDurationMs": 25.205,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3664.6120000000005,
"heapDeltaBytes": -11329452,
"heapUsedBytes": 89300272,
"domNodes": -263,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 1577.083,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10562.448000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9595.777999999998,
"heapDeltaBytes": -29729004,
"heapUsedBytes": 183349540,
"domNodes": -6548,
"jsHeapTotalBytes": 495616,
"scriptDurationMs": 138.262,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12136.246000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11426.746,
"heapDeltaBytes": -35967852,
"heapUsedBytes": 175946828,
"domNodes": -6548,
"jsHeapTotalBytes": 1576960,
"scriptDurationMs": 177.462,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14004.011999999988,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.857000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13388.366000000002,
"heapDeltaBytes": -42674204,
"heapUsedBytes": 166731692,
"domNodes": -6548,
"jsHeapTotalBytes": -7553024,
"scriptDurationMs": 651.775,
"eventListeners": -7473,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13878.903000000037,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.968999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13286.771,
"heapDeltaBytes": -54271376,
"heapUsedBytes": 161272088,
"domNodes": -6548,
"jsHeapTotalBytes": -57344,
"scriptDurationMs": 722.649,
"eventListeners": -7473,
"totalBlockingTimeMs": 67,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4030.6809999999587,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.41500000000002,
"layouts": 20,
"layoutDurationMs": 21.704999999999988,
"taskDurationMs": 3919.814,
"heapDeltaBytes": -34770928,
"heapUsedBytes": 181313532,
"domNodes": -6548,
"jsHeapTotalBytes": 13606912,
"scriptDurationMs": 70.953,
"eventListeners": -7475,
"totalBlockingTimeMs": 70,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4096.952999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.922,
"layouts": 20,
"layoutDurationMs": 21.90500000000001,
"taskDurationMs": 3959.956,
"heapDeltaBytes": -31293228,
"heapUsedBytes": 182086852,
"domNodes": -6548,
"jsHeapTotalBytes": 12021760,
"scriptDurationMs": 68.48700000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 107,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 422.8379999999561,
"styleRecalcs": 14,
"styleRecalcDurationMs": 18.181999999999995,
"layouts": 3,
"layoutDurationMs": 0.893,
"taskDurationMs": 78.467,
"heapDeltaBytes": 4798552,
"heapUsedBytes": 73658548,
"domNodes": 122,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.112000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 451.65700000006836,
"styleRecalcs": 18,
"styleRecalcDurationMs": 15.503000000000002,
"layouts": 3,
"layoutDurationMs": 1.461,
"taskDurationMs": 83.809,
"heapDeltaBytes": 4892768,
"heapUsedBytes": 73872184,
"domNodes": 144,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.2299999999999995,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe browser tests now verify workflow viewport persistence through scale and offset values. The mask editor screenshot assertion now permits up to 25 differing pixels. ChangesViewport persistence
Mask editor screenshot tolerance
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR makes localized browser-test reliability adjustments without a supplied actionable merge-blocking risk; it is merge-ready after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description explains the test changes, observed failures, validation steps, and test execution limitation. It omits the template's Changes and Review Focus headings, but the required technical context is mostly present. Full details: End-To-End Regression Coverage For FixesExplanation The available metadata lists two changed files under Resolution Provide the PR title and commit subjects. Then verify whether either contains the specified bug-fix language. Based on the available file list, the PR already updates Playwright tests under Full details: Website End-To-End Regression CoverageExplanation The PR changes only Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed-file list contains only
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16669 +/- ##
==========================================
+ Coverage 80.78% 82.39% +1.61%
==========================================
Files 2440 2031 -409
Lines 124631 117388 -7243
Branches 32976 29431 -3545
==========================================
- Hits 100678 96718 -3960
+ Misses 23451 20492 -2959
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Green at exact head Human review requested from ryan-di and CodeJuggernaut. No merge performed. Full context for agent readersHosted E2E run 33652164376 passed all 16 Chromium shards plus cloud, mobile Chrome, mobile Safari, 0.5x, and 2x Playwright jobs; |
|
Verified locally against head Comparing
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Swapping the screenshot compares for viewport assertions is the right fix for this flake family; no issues.
Summary
Failure evidence
Test plan
pnpm exec oxfmt --check browser_tests/tests/interaction.spec.ts browser_tests/tests/maskEditor.spec.tspnpm exec eslint browser_tests/tests/interaction.spec.ts browser_tests/tests/maskEditor.spec.tspnpm typecheck:browserpnpm typecheckandpnpm typecheck:browser--list; execution requires a local ComfyUI backend, which is unavailable on this worker