Skip to content

[backport core/1.53] fix(litegraph): keep custom widget value normalisation on adoption - #16602

Merged
comfy-pr-bot merged 1 commit into
core/1.53from
backport-16522-to-core-1.53
Sep 2, 2026
Merged

comfy-pr-bot merged 1 commit into
core/1.53from
backport-16522-to-core-1.53

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #16522 to core/1.53. Fixes the rgthree Image Comparer save error after reload (#16479), whose cause (#16097) shipped in 1.53. Clean cherry-pick of 67d5d3e, no conflicts. Requested by the release owner.

Full context for agent readers

…16522)

## Summary

Custom widgets that own their value behind an accessor pair lost their
own normalisation when adopted, so rgthree's Image Comparer threw
`TypeError: can't access property "map",
this.widgets[index].value.images is undefined` from `onSerialize` on
every workflow switch.

## Changes

- **What**: `adoptConcreteWidget` composes a foreign `value` accessor
with the concrete store-backed one. The composed setter wrote the
assigned value straight to the store and the getter returned it,
discarding whatever the widget's own setter normalised. The composed
setter now runs the foreign setter first and stores what the foreign
getter reports, so store reads match the shape the widget itself
exposes. If the foreign getter yields `undefined`, the assigned value is
stored unchanged.
- **Devtools node + E2E**: `DevToolsNodeWithComparerWidget` and
`tools/devtools/web/comparerWidget.js` mirror rgthree's image comparer —
a widget that takes either the serialised list or `{ images }` and
always reads back `{ images }`, plus a node that rewrites
`widgets_values` with the bare list in `onSerialize`.
`browser_tests/tests/legacyDoNotReplicate/legacyComparerWidgetValue.spec.ts`
walks the user's route to the crash: add the node, save the workflow,
reopen it from the sidebar (which feeds the saved list back to the
widget), serialise, and switch away. The custom-node behaviour is
modelled only there, in the quarantined suite.
- **Unit**: one case in `widgetMap.test.ts`, alongside its existing
foreign-accessor cases — a foreign setter's normalised value is what the
store keeps.

## Review Focus

Why the comparer broke: its setter accepts either the serialised image
list or `{ images }`, and its getter always returns `{ images }`. Its
own `onSerialize` writes the bare list into `widgets_values`, so after a
workflow load the widget was assigned a list, the store handed that list
straight back on read, and `value.images.map` threw. The same pattern
appears in rgthree's Power Puter (`{ outputs }`, accepts a bare string)
and Power Lora Loader (falls back to defaults for a non-object), both of
which this also repairs.

The ordering change (foreign setter before concrete setter) means a
foreign setter that reads `this.value` now sees the previous value
rather than the incoming one. That matches what the widget's author
wrote the setter against.

Consequence worth noting: the store now holds the object the widget
owns, so later mutations by the widget are visible through the store
rather than diverging from it.

The unit case was verified red-then-green locally. The E2E spec
typechecks, lints and collects, but this container has no ComfyUI
backend (no Docker daemon, cloud host blocked by network policy), so it
has not been executed — CI is its first run.



---------

(cherry picked from commit 67d5d3e)
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) labels Sep 2, 2026
@christian-byrne christian-byrne self-assigned this Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: d4b65b8f-7bd0-4c24-886f-8d76fa7b4da2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 05:55:23 AM UTC

Links

🎭 Playwright: ✅ 1893 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1872 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 84ms TBT · 103.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
vue-large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.1 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 163.1 MB heap
vue-node-resize-workload: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 25ms TBT · 171.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap

⚠️ 4 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-zoom-sweep: layout duration 1ms 1ms -17% ⚠️ z=4.1
dom-widget-clipping: script duration 178ms 97ms -46% ⚠️ z=8.9
large-graph-pan: script duration 803ms 450ms -44% ⚠️ z=2.1
workflow-execution: event listeners 25 74 +196% ⚠️ z=5.1
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=0.4
canvas-idle: p95 frame time 17ms 17ms +1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 8ms 5ms -43% z=-6.9
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 10 +11% z=-2.1
canvas-idle: task duration 494ms 360ms -27% z=-1.1
canvas-idle: script duration 8ms 6ms -28% z=-8.8
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 64.6 MB 65.3 MB +1% —
canvas-idle: DOM nodes -281 -280 -0% z=-237.3
canvas-idle: event listeners -185 -153 -17% z=-34.8
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 4ms 2ms -49% z=-7.3
canvas-mouse-sweep: style recalc duration 38ms 19ms -51% z=-7.5
canvas-mouse-sweep: layout count 14 14 +0% —
canvas-mouse-sweep: style recalc count 77 75 -3% z=-1.8
canvas-mouse-sweep: task duration 884ms 547ms -38% z=-5.5
canvas-mouse-sweep: script duration 160ms 79ms -50% z=-8.7
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 59.1 MB 63.7 MB +8% —
canvas-mouse-sweep: DOM nodes -279 -279 +0% z=-132.0
canvas-mouse-sweep: event listeners -155 -167 +8% z=-42.1
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-0.3
canvas-zoom-sweep: p95 frame time 17ms 17ms -1% —
canvas-zoom-sweep: layout duration 1ms 1ms -17% ⚠️ z=4.1
canvas-zoom-sweep: style recalc duration 17ms 11ms -37% z=-5.6
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 31 +0% z=-0.6
canvas-zoom-sweep: task duration 363ms 246ms -32% z=-3.5
canvas-zoom-sweep: script duration 11ms 7ms -35% z=-6.7
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 70.8 MB 71.2 MB +1% —
canvas-zoom-sweep: DOM nodes 77 78 +1% z=-2.2
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms -0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 7ms 6ms -25% z=-5.4
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 11 14 +29% z=0.8
dom-widget-clipping: task duration 483ms 295ms -39% z=-4.2
dom-widget-clipping: script duration 178ms 97ms -46% ⚠️ z=8.9
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 81.3 MB 71.7 MB -12% —
dom-widget-clipping: DOM nodes 17 23 +35% z=0.6
dom-widget-clipping: event listeners 2 1 -50% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=0.2
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 5ms 4ms -21% z=-7.6
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 6 9 +42% z=-9.9
large-graph-idle: task duration 588ms 442ms -25% z=-1.8
large-graph-idle: script duration 35ms 19ms -45% z=-7.9
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 82.9 MB 82.6 MB -0% —
large-graph-idle: DOM nodes -267 -263 -1% z=-318.3
large-graph-idle: event listeners -154 -168 +9% z=-31.8
large-graph-pan: avg frame time 17ms 17ms -0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms -0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 11ms 6ms -44% z=-13.9
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 67 66 -1% z=-5.6
large-graph-pan: task duration 1623ms 949ms -42% z=-3.1
large-graph-pan: script duration 803ms 450ms -44% ⚠️ z=2.1
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 78.6 MB 78.1 MB -1% —
large-graph-pan: DOM nodes -271 10 -104% z=-5.4
large-graph-pan: event listeners -153 4 -103% z=-1.1
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 11ms 7ms -39% —
large-graph-zoom: style recalc duration 10ms 8ms -18% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 61 64 +6% —
large-graph-zoom: task duration 1660ms 1013ms -39% —
large-graph-zoom: script duration 769ms 421ms -45% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 73.0 MB 72.4 MB -1% —
large-graph-zoom: DOM nodes -139 -132 -5% —
large-graph-zoom: event listeners -71 8 -111% —
legacy-node-drag: avg frame time 17ms 17ms -0% —
legacy-node-drag: p95 frame time 17ms 17ms +0% —
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 5ms 4ms -15% —
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 40 44 +9% —
legacy-node-drag: task duration 1959ms 1131ms -42% —
legacy-node-drag: script duration 981ms 520ms -47% —
legacy-node-drag: TBT 0ms 0ms +0% —
legacy-node-drag: heap used 87.9 MB 77.6 MB -12% —
legacy-node-drag: DOM nodes -140 -134 -4% —
legacy-node-drag: event listeners 188 185 -2% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms +0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 3ms 3ms +9% z=-7.5
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 4 7 +100% z=-3.8
minimap-idle: task duration 565ms 371ms -34% z=-3.3
minimap-idle: script duration 32ms 16ms -50% z=-8.3
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 83.3 MB 83.3 MB -0% —
minimap-idle: DOM nodes -134 -267 +100% z=-209.2
minimap-idle: event listeners -76 -90 +19% z=-142.5
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.7
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 11ms 7ms -36% z=-6.2
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 49 +3% z=0.9
subgraph-dom-widget-clipping: task duration 408ms 260ms -36% z=-6.4
subgraph-dom-widget-clipping: script duration 138ms 81ms -42% z=-7.5
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 81.8 MB 83.3 MB +2% —
subgraph-dom-widget-clipping: DOM nodes 20 23 +15% z=0.7
subgraph-dom-widget-clipping: event listeners 8 7 -13% z=-1.6
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 7ms 5ms -24% z=-6.4
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 8 12 +44% z=0.9
subgraph-idle: task duration 488ms 336ms -31% z=-1.1
subgraph-idle: script duration 8ms 5ms -38% z=-5.8
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 60.5 MB 65.7 MB +9% —
subgraph-idle: DOM nodes -298 -295 -1% z=-211.9
subgraph-idle: event listeners -202 -229 +13% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% —
subgraph-mouse-sweep: layout duration 5ms 3ms -50% z=-6.5
subgraph-mouse-sweep: style recalc duration 35ms 20ms -45% z=-6.9
subgraph-mouse-sweep: layout count 18 18 +0% —
subgraph-mouse-sweep: style recalc count 78 78 -1% z=-1.4
subgraph-mouse-sweep: task duration 805ms 527ms -34% z=-3.4
subgraph-mouse-sweep: script duration 108ms 56ms -48% z=-6.8
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 64.8 MB 71.8 MB +11% —
subgraph-mouse-sweep: DOM nodes -297 -296 -0% z=-162.2
subgraph-mouse-sweep: event listeners -217 -231 +6% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms -0% —
subgraph-transition-enter: p95 frame time 17ms 17ms -1% —
subgraph-transition-enter: layout duration 16ms 9ms -44% —
subgraph-transition-enter: style recalc duration 32ms 20ms -36% —
subgraph-transition-enter: layout count 14 18 +29% —
subgraph-transition-enter: style recalc count 18 22 +22% —
subgraph-transition-enter: task duration 951ms 591ms -38% —
subgraph-transition-enter: script duration 31ms 15ms -50% —
subgraph-transition-enter: TBT 136ms 84ms -38% —
subgraph-transition-enter: heap used 94.6 MB 103.9 MB +10% —
subgraph-transition-enter: DOM nodes 13751 13751 +0% —
subgraph-transition-enter: event listeners 2381 2381 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 33ms 19ms -43% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 247 249 +1% —
viewport-pan-sweep: task duration 5716ms 3379ms -41% —
viewport-pan-sweep: script duration 2676ms 1473ms -45% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 82.3 MB 83.1 MB +1% —
viewport-pan-sweep: DOM nodes -268 -263 -2% —
viewport-pan-sweep: event listeners -139 -74 -47% —
vue-large-graph-idle: avg frame time 18ms 17ms -5% —
vue-large-graph-idle: p95 frame time 17ms 17ms -0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 16184ms 8420ms -48% —
vue-large-graph-idle: script duration 264ms 81ms -69% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 167.4 MB 171.1 MB +2% —
vue-large-graph-idle: DOM nodes -6548 -6548 +0% —
vue-large-graph-idle: event listeners -7475 -7474 -0% —
vue-large-graph-pan: avg frame time 18ms 17ms -2% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 17ms 9ms -49% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 169 67 -61% —
vue-large-graph-pan: task duration 20224ms 10629ms -47% —
vue-large-graph-pan: script duration 908ms 484ms -47% —
vue-large-graph-pan: TBT 144ms 0ms -100% —
vue-large-graph-pan: heap used 174.7 MB 163.1 MB -7% —
vue-large-graph-pan: DOM nodes -6548 -6548 +0% —
vue-large-graph-pan: event listeners -7468 -7471 +0% —
vue-node-resize-workload: avg frame time 17ms 17ms -5% —
vue-node-resize-workload: p95 frame time 17ms 17ms -0% —
vue-node-resize-workload: layout duration 29ms 15ms -48% —
vue-node-resize-workload: style recalc duration 88ms 49ms -44% —
vue-node-resize-workload: layout count 20 20 +0% —
vue-node-resize-workload: style recalc count 20 20 +0% —
vue-node-resize-workload: task duration 6034ms 3100ms -49% —
vue-node-resize-workload: script duration 111ms 39ms -65% —
vue-node-resize-workload: TBT 369ms 25ms -93% —
vue-node-resize-workload: heap used 169.1 MB 171.1 MB +1% —
vue-node-resize-workload: DOM nodes -6548 -6549 +0% —
vue-node-resize-workload: event listeners -7471 -7473 +0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms -0% —
workflow-execution: layout duration 1ms 1ms -35% z=-5.2
workflow-execution: style recalc duration 15ms 10ms -34% z=-6.4
workflow-execution: layout count 2 3 +50% z=-3.6
workflow-execution: style recalc count 8 13 +73% z=-2.3
workflow-execution: task duration 77ms 59ms -24% z=-5.9
workflow-execution: script duration 8ms 5ms -40% z=-8.2
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 67.4 MB 68.5 MB +2% —
workflow-execution: DOM nodes 128 130 +2% z=-4.4
workflow-execution: event listeners 25 74 +196% ⚠️ z=5.1
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-09-02T06:09:02.255Z",
  "gitSha": "9457b0c9255ea7f0a50929c07246f68af33716e0",
  "branch": "backport-16522-to-core-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2009.7849999999653,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.956,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 349.956,
      "heapDeltaBytes": -11418716,
      "heapUsedBytes": 59243788,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 5.781,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2021.4110000000005,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.425,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.768,
      "heapDeltaBytes": 8159952,
      "heapUsedBytes": 77717824,
      "domNodes": -280,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 5.684,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1718.8049999999748,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 19.123,
      "layouts": 14,
      "layoutDurationMs": 2.217,
      "taskDurationMs": 558.168,
      "heapDeltaBytes": 2332580,
      "heapUsedBytes": 70894932,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 80.92600000000002,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1721.2480000000028,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 18.497,
      "layouts": 14,
      "layoutDurationMs": 2.128,
      "taskDurationMs": 536.3299999999999,
      "heapDeltaBytes": -7437904,
      "heapUsedBytes": 62701964,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 77.723,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1669.4860000000062,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 11.132,
      "layouts": 6,
      "layoutDurationMs": 0.874,
      "taskDurationMs": 255.26800000000006,
      "heapDeltaBytes": 4484148,
      "heapUsedBytes": 74400756,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 7.073999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.9359999999706,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 10.009,
      "layouts": 6,
      "layoutDurationMs": 0.785,
      "taskDurationMs": 237.54799999999997,
      "heapDeltaBytes": 4498204,
      "heapUsedBytes": 74977648,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 7.0070000000000014,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 470.7789999999932,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 5.030999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 286.39300000000003,
      "heapDeltaBytes": 18206436,
      "heapUsedBytes": 87941884,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 93.41199999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 476.58100000001014,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 6.121000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 303.214,
      "heapDeltaBytes": -8157556,
      "heapUsedBytes": 62484072,
      "domNodes": 24,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 99.75399999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2017.7310000000261,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.954000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.80499999999995,
      "heapDeltaBytes": -12159792,
      "heapUsedBytes": 86877476,
      "domNodes": -264,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 20.913999999999994,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2020.2199999999948,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.623000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.594,
      "heapDeltaBytes": 10702532,
      "heapUsedBytes": 86397168,
      "domNodes": -262,
      "jsHeapTotalBytes": -2965504,
      "scriptDurationMs": 17.096,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2048.2150000000274,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 6.0539999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 954.7930000000001,
      "heapDeltaBytes": 13513452,
      "heapUsedBytes": 80305328,
      "domNodes": 10,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 451.634,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2077.681000000041,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 6.321000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 943.202,
      "heapDeltaBytes": 17704964,
      "heapUsedBytes": 83581472,
      "domNodes": 10,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 449.32300000000004,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3032.4449999999956,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 7.404000000000001,
      "layouts": 60,
      "layoutDurationMs": 6.878,
      "taskDurationMs": 1007.1300000000001,
      "heapDeltaBytes": 9486732,
      "heapUsedBytes": 75995716,
      "domNodes": -275,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 412.403,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3071.3630000000194,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 8.247000000000002,
      "layouts": 60,
      "layoutDurationMs": 6.7829999999999995,
      "taskDurationMs": 1018.4829999999998,
      "heapDeltaBytes": 8823792,
      "heapUsedBytes": 75844656,
      "domNodes": 12,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 429.65,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2125.235000000032,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 3.4849999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1151.8410000000001,
      "heapDeltaBytes": 13913260,
      "heapUsedBytes": 81336296,
      "domNodes": -278,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 526.9019999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2107.1779999999762,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 4.444,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1110.92,
      "heapDeltaBytes": 13884336,
      "heapUsedBytes": 81309232,
      "domNodes": 10,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 513.813,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 1994.7230000000218,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 2.7170000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 359.792,
      "heapDeltaBytes": 21802856,
      "heapUsedBytes": 87083464,
      "domNodes": -269,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 16.673000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.9899999999452,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.055,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 382.4920000000001,
      "heapDeltaBytes": 21827060,
      "heapUsedBytes": 87520540,
      "domNodes": -265,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 15.787999999999997,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 425.87599999995973,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 7.179000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 259.424,
      "heapDeltaBytes": 14831916,
      "heapUsedBytes": 87365624,
      "domNodes": 24,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 81.764,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 410.3749999999309,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.577,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 259.649,
      "heapDeltaBytes": 14859504,
      "heapUsedBytes": 87382056,
      "domNodes": 22,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 79.749,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.0779999999786,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.854999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 337.575,
      "heapDeltaBytes": -9945352,
      "heapUsedBytes": 62737344,
      "domNodes": -294,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 4.688,
      "eventListeners": -229,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.805000000009,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.021000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 334.545,
      "heapDeltaBytes": 2288696,
      "heapUsedBytes": 75107248,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 4.770000000000001,
      "eventListeners": -229,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1695.2350000000251,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 19.407999999999998,
      "layouts": 18,
      "layoutDurationMs": 2.641,
      "taskDurationMs": 526.855,
      "heapDeltaBytes": 2820580,
      "heapUsedBytes": 75535696,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 56.087999999999994,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1690.956999999969,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 19.833999999999996,
      "layouts": 18,
      "layoutDurationMs": 2.5849999999999995,
      "taskDurationMs": 527.563,
      "heapDeltaBytes": 2281660,
      "heapUsedBytes": 75009928,
      "domNodes": -294,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 56.480000000000004,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 832.3680000000309,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 20.465999999999998,
      "layouts": 18,
      "layoutDurationMs": 9.050999999999998,
      "taskDurationMs": 590.8769999999998,
      "heapDeltaBytes": 21073392,
      "heapUsedBytes": 108927944,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 15.232000000000003,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 84,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8097.510999999997,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 18.692000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3364.656,
      "heapDeltaBytes": 23163824,
      "heapUsedBytes": 89268728,
      "domNodes": -258,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 1484.767,
      "eventListeners": 20,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8117.613000000006,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 19.574,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3393.964,
      "heapDeltaBytes": 10293992,
      "heapUsedBytes": 84918892,
      "domNodes": -267,
      "jsHeapTotalBytes": 929792,
      "scriptDurationMs": 1462.0800000000002,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 8787.421000000051,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8374.076,
      "heapDeltaBytes": -10329328,
      "heapUsedBytes": 177293176,
      "domNodes": -6548,
      "jsHeapTotalBytes": 274432,
      "scriptDurationMs": 81.116,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 9105.372999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8465.644,
      "heapDeltaBytes": -9690140,
      "heapUsedBytes": 181427800,
      "domNodes": -6548,
      "jsHeapTotalBytes": 6119424,
      "scriptDurationMs": 81.072,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 11413.374999999975,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 8.710000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10665.393999999998,
      "heapDeltaBytes": -29759508,
      "heapUsedBytes": 170712992,
      "domNodes": -6548,
      "jsHeapTotalBytes": 11493376,
      "scriptDurationMs": 487.33199999999994,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 11261.371000000054,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 9.134999999999977,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10593.125,
      "heapDeltaBytes": -16224160,
      "heapUsedBytes": 171417036,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9449472,
      "scriptDurationMs": 481.09900000000005,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3255.4529999999886,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 49.52599999999999,
      "layouts": 20,
      "layoutDurationMs": 15.364999999999997,
      "taskDurationMs": 3106.719,
      "heapDeltaBytes": -6477764,
      "heapUsedBytes": 181125324,
      "domNodes": -6548,
      "jsHeapTotalBytes": 13905920,
      "scriptDurationMs": 38.971,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 50,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3263.402000000042,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 48.233,
      "layouts": 20,
      "layoutDurationMs": 14.931000000000006,
      "taskDurationMs": 3092.611,
      "heapDeltaBytes": -26595616,
      "heapUsedBytes": 177615488,
      "domNodes": -6549,
      "jsHeapTotalBytes": 8454144,
      "scriptDurationMs": 38.236000000000004,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 432.76400000002013,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 13.465000000000002,
      "layouts": 4,
      "layoutDurationMs": 1.199,
      "taskDurationMs": 73.40299999999999,
      "heapDeltaBytes": 5213988,
      "heapUsedBytes": 73441512,
      "domNodes": 153,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.776,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 78.0530000000681,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.562,
      "layouts": 2,
      "layoutDurationMs": 0.40099999999999986,
      "taskDurationMs": 43.745000000000005,
      "heapDeltaBytes": 3238168,
      "heapUsedBytes": 70306728,
      "domNodes": 106,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 3.7789999999999995,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 47989 70464 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport of merged #16522 onto core/1.53, with no extra code changes. The original and backport stable patch IDs are both 78588e394a44c199f04e5baa22874550373eb4ab; file status and numstat also match (5 files, +206/-1). Local typecheck, changed-file format/ESLint, 7 focused unit tests, and Playwright discovery of the new browser case pass. Hosted checks are green.

@comfy-pr-bot
comfy-pr-bot merged commit 038efce into core/1.53 Sep 2, 2026
97 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16522-to-core-1.53 branch September 2, 2026 09:57
comfy-pr-bot pushed a commit that referenced this pull request Sep 2, 2026
…isation on adoption (#16603)

Backport of #16522 to `cloud/1.53`. Fixes the rgthree Image Comparer
save error after reload (#16479), whose cause (#16097) shipped in 1.53.
Clean cherry-pick of 67d5d3e, no conflicts. Requested by the release
owner.

<details><summary>Full context for agent readers</summary>

- Source: #16522 (merged to main 2026-09-01), labeled needs-backport +
cloud/1.53.
- Cherry-pick of 67d5d3e onto
`cloud/1.53`; original author preserved, AI co-author trailer stripped
from the commit message per repo policy.
- Sibling backports: #16602 (core/1.53), #16603 (cloud/1.53). The
core/1.52 auto-backport failed on conflicts and is handled separately.

</details>

<!-- authored-by:agent w3-bp -->

Co-authored-by: Alexander Brown <drjkl@comfy.org>
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
DrJKL added a commit that referenced this pull request Sep 23, 2026
…tibility (#18472)

Manual backport of #18301 to `core/1.53`.

Cherry-picked from upstream merge commit
`1344a91e0e5fd03ce2131bacf30d1faca7dcd26a`.

## Why

Restores Impact Preview Bridge mask registration, WAS Pause live button
enablement, and MiniMax RefMod schema-order serialization for the widget
ECS compatibility layer shipped in core/1.53.

## Dependency check

#18352 is still open, but it only changes `useStringWidget.ts` and its
test. It is not in #18301's ancestry and does not overlap this backport,
so the bot's stacking suggestion did not apply.

## Conflict resolution

- `browser_tests/tests/loadWorkflowInMedia.spec.ts` — kept core/1.53's
runtime settings and URL setup; added only the fixed LoadImage option
fixture from #18301.
- `src/components/graph/GraphCanvas.vue` — kept `LiteGraph.vueNodesMode`
ownership in core/1.53's `useVueFeatureFlags`; refreshes live disabled
state on renderer transitions without importing main's newer visibility
facade.
- `src/core/graph/widgets/nodeWidgetValues.ts` — preserved the target
branch's callback behavior and added `widget.value` assignment after
successful store writes so extension setters run.
- `src/lib/litegraph/src/types/widgets.ts` and `BaseWidget.ts` — added
only the live-disabled synchronization contract; omitted main-only
visibility APIs.
- `src/lib/litegraph/src/widgets/widgetMap.ts` — preserved core/1.53's
normalizing setter composition from #16602 while retaining the
extension's live `disabled` getter.
- Browser compatibility specs use core/1.53's existing
`getNodeRefsByType(...)[0]` helper because main's singular helper is
unavailable.

## Backport-only compatibility fix

Core/1.53's mask editor predates the shared widget-value boundary
migration present on main. Its image write adapter now delegates to
`setNodeWidgetValue`, ensuring mask Save reaches extension value setters
while preserving the stable branch's store-first read path and
`properties.image` mirror. A regression test covers this boundary.

## Validation

- `pnpm test:unit src/composables/maskeditor/imageWidgetAdapter.test.ts
src/core/graph/widgets/nodeWidgetValues.test.ts
src/lib/litegraph/src/widgets/widgetMap.test.ts
src/lib/litegraph/src/LGraph.serialise.test.ts` — 4 files, 39 tests
passed.
- `pnpm typecheck` — passed.
- `pnpm typecheck:browser` — passed.
- Changed-file ESLint — 0 errors; 26 pre-existing layer-boundary
warnings in LiteGraph files.
- Changed-file Oxlint — passed.
- `pnpm exec oxfmt --check <changed JSON/TS/Vue/JS files>` — passed.
- `python -m compileall -q tools/devtools/nodes` — passed.
- Push-time `knip --cache` — passed.

The three new browser compatibility specs require a production frontend
served by a ComfyUI backend with `tools/devtools` installed; the local
Vite workflow deliberately does not expose those extensions, so they
were not run locally.

Original PR: #18301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants