Repository navigation
[backport core/1.53] fix(litegraph): keep custom widget value normalisation on adoption - #16602
Conversation
…16522) ## Summary Custom widgets that own their value behind an accessor pair lost their own normalisation when adopted, so rgthree's Image Comparer threw `TypeError: can't access property "map", this.widgets[index].value.images is undefined` from `onSerialize` on every workflow switch. ## Changes - **What**: `adoptConcreteWidget` composes a foreign `value` accessor with the concrete store-backed one. The composed setter wrote the assigned value straight to the store and the getter returned it, discarding whatever the widget's own setter normalised. The composed setter now runs the foreign setter first and stores what the foreign getter reports, so store reads match the shape the widget itself exposes. If the foreign getter yields `undefined`, the assigned value is stored unchanged. - **Devtools node + E2E**: `DevToolsNodeWithComparerWidget` and `tools/devtools/web/comparerWidget.js` mirror rgthree's image comparer — a widget that takes either the serialised list or `{ images }` and always reads back `{ images }`, plus a node that rewrites `widgets_values` with the bare list in `onSerialize`. `browser_tests/tests/legacyDoNotReplicate/legacyComparerWidgetValue.spec.ts` walks the user's route to the crash: add the node, save the workflow, reopen it from the sidebar (which feeds the saved list back to the widget), serialise, and switch away. The custom-node behaviour is modelled only there, in the quarantined suite. - **Unit**: one case in `widgetMap.test.ts`, alongside its existing foreign-accessor cases — a foreign setter's normalised value is what the store keeps. ## Review Focus Why the comparer broke: its setter accepts either the serialised image list or `{ images }`, and its getter always returns `{ images }`. Its own `onSerialize` writes the bare list into `widgets_values`, so after a workflow load the widget was assigned a list, the store handed that list straight back on read, and `value.images.map` threw. The same pattern appears in rgthree's Power Puter (`{ outputs }`, accepts a bare string) and Power Lora Loader (falls back to defaults for a non-object), both of which this also repairs. The ordering change (foreign setter before concrete setter) means a foreign setter that reads `this.value` now sees the previous value rather than the incoming one. That matches what the widget's author wrote the setter against. Consequence worth noting: the store now holds the object the widget owns, so later mutations by the widget are visible through the store rather than diverging from it. The unit case was verified red-then-green locally. The E2E spec typechecks, lints and collects, but this container has no ComfyUI backend (no Docker daemon, cloud host blocked by network policy), so it has not been executed — CI is its first run. --------- (cherry picked from commit 67d5d3e)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1893 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T06:09:02.255Z",
"gitSha": "9457b0c9255ea7f0a50929c07246f68af33716e0",
"branch": "backport-16522-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.7849999999653,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.956,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.956,
"heapDeltaBytes": -11418716,
"heapUsedBytes": 59243788,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5.781,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2021.4110000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.425,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.768,
"heapDeltaBytes": 8159952,
"heapUsedBytes": 77717824,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.684,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1718.8049999999748,
"styleRecalcs": 75,
"styleRecalcDurationMs": 19.123,
"layouts": 14,
"layoutDurationMs": 2.217,
"taskDurationMs": 558.168,
"heapDeltaBytes": 2332580,
"heapUsedBytes": 70894932,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 80.92600000000002,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1721.2480000000028,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.497,
"layouts": 14,
"layoutDurationMs": 2.128,
"taskDurationMs": 536.3299999999999,
"heapDeltaBytes": -7437904,
"heapUsedBytes": 62701964,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 77.723,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.4860000000062,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.132,
"layouts": 6,
"layoutDurationMs": 0.874,
"taskDurationMs": 255.26800000000006,
"heapDeltaBytes": 4484148,
"heapUsedBytes": 74400756,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.073999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.9359999999706,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.009,
"layouts": 6,
"layoutDurationMs": 0.785,
"taskDurationMs": 237.54799999999997,
"heapDeltaBytes": 4498204,
"heapUsedBytes": 74977648,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7.0070000000000014,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 470.7789999999932,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.030999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.39300000000003,
"heapDeltaBytes": 18206436,
"heapUsedBytes": 87941884,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 93.41199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 476.58100000001014,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.121000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.214,
"heapDeltaBytes": -8157556,
"heapUsedBytes": 62484072,
"domNodes": 24,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 99.75399999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2017.7310000000261,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.954000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.80499999999995,
"heapDeltaBytes": -12159792,
"heapUsedBytes": 86877476,
"domNodes": -264,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 20.913999999999994,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2020.2199999999948,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.623000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.594,
"heapDeltaBytes": 10702532,
"heapUsedBytes": 86397168,
"domNodes": -262,
"jsHeapTotalBytes": -2965504,
"scriptDurationMs": 17.096,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2048.2150000000274,
"styleRecalcs": 66,
"styleRecalcDurationMs": 6.0539999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 954.7930000000001,
"heapDeltaBytes": 13513452,
"heapUsedBytes": 80305328,
"domNodes": 10,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 451.634,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2077.681000000041,
"styleRecalcs": 66,
"styleRecalcDurationMs": 6.321000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 943.202,
"heapDeltaBytes": 17704964,
"heapUsedBytes": 83581472,
"domNodes": 10,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 449.32300000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3032.4449999999956,
"styleRecalcs": 63,
"styleRecalcDurationMs": 7.404000000000001,
"layouts": 60,
"layoutDurationMs": 6.878,
"taskDurationMs": 1007.1300000000001,
"heapDeltaBytes": 9486732,
"heapUsedBytes": 75995716,
"domNodes": -275,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 412.403,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3071.3630000000194,
"styleRecalcs": 65,
"styleRecalcDurationMs": 8.247000000000002,
"layouts": 60,
"layoutDurationMs": 6.7829999999999995,
"taskDurationMs": 1018.4829999999998,
"heapDeltaBytes": 8823792,
"heapUsedBytes": 75844656,
"domNodes": 12,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 429.65,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2125.235000000032,
"styleRecalcs": 42,
"styleRecalcDurationMs": 3.4849999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1151.8410000000001,
"heapDeltaBytes": 13913260,
"heapUsedBytes": 81336296,
"domNodes": -278,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 526.9019999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2107.1779999999762,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.444,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1110.92,
"heapDeltaBytes": 13884336,
"heapUsedBytes": 81309232,
"domNodes": 10,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 513.813,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1994.7230000000218,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.7170000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.792,
"heapDeltaBytes": 21802856,
"heapUsedBytes": 87083464,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.673000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.9899999999452,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.055,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.4920000000001,
"heapDeltaBytes": 21827060,
"heapUsedBytes": 87520540,
"domNodes": -265,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.787999999999997,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 425.87599999995973,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.179000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 259.424,
"heapDeltaBytes": 14831916,
"heapUsedBytes": 87365624,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 81.764,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 410.3749999999309,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 259.649,
"heapDeltaBytes": 14859504,
"heapUsedBytes": 87382056,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 79.749,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2007.0779999999786,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.854999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.575,
"heapDeltaBytes": -9945352,
"heapUsedBytes": 62737344,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 4.688,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.805000000009,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.021000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.545,
"heapDeltaBytes": 2288696,
"heapUsedBytes": 75107248,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 4.770000000000001,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.2350000000251,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.407999999999998,
"layouts": 18,
"layoutDurationMs": 2.641,
"taskDurationMs": 526.855,
"heapDeltaBytes": 2820580,
"heapUsedBytes": 75535696,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 56.087999999999994,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.956999999969,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.833999999999996,
"layouts": 18,
"layoutDurationMs": 2.5849999999999995,
"taskDurationMs": 527.563,
"heapDeltaBytes": 2281660,
"heapUsedBytes": 75009928,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 56.480000000000004,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 832.3680000000309,
"styleRecalcs": 22,
"styleRecalcDurationMs": 20.465999999999998,
"layouts": 18,
"layoutDurationMs": 9.050999999999998,
"taskDurationMs": 590.8769999999998,
"heapDeltaBytes": 21073392,
"heapUsedBytes": 108927944,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 15.232000000000003,
"eventListeners": 2381,
"totalBlockingTimeMs": 84,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8097.510999999997,
"styleRecalcs": 248,
"styleRecalcDurationMs": 18.692000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3364.656,
"heapDeltaBytes": 23163824,
"heapUsedBytes": 89268728,
"domNodes": -258,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 1484.767,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8117.613000000006,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.574,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3393.964,
"heapDeltaBytes": 10293992,
"heapUsedBytes": 84918892,
"domNodes": -267,
"jsHeapTotalBytes": 929792,
"scriptDurationMs": 1462.0800000000002,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 8787.421000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8374.076,
"heapDeltaBytes": -10329328,
"heapUsedBytes": 177293176,
"domNodes": -6548,
"jsHeapTotalBytes": 274432,
"scriptDurationMs": 81.116,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 9105.372999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8465.644,
"heapDeltaBytes": -9690140,
"heapUsedBytes": 181427800,
"domNodes": -6548,
"jsHeapTotalBytes": 6119424,
"scriptDurationMs": 81.072,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 11413.374999999975,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.710000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10665.393999999998,
"heapDeltaBytes": -29759508,
"heapUsedBytes": 170712992,
"domNodes": -6548,
"jsHeapTotalBytes": 11493376,
"scriptDurationMs": 487.33199999999994,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 11261.371000000054,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.134999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10593.125,
"heapDeltaBytes": -16224160,
"heapUsedBytes": 171417036,
"domNodes": -6548,
"jsHeapTotalBytes": 9449472,
"scriptDurationMs": 481.09900000000005,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3255.4529999999886,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.52599999999999,
"layouts": 20,
"layoutDurationMs": 15.364999999999997,
"taskDurationMs": 3106.719,
"heapDeltaBytes": -6477764,
"heapUsedBytes": 181125324,
"domNodes": -6548,
"jsHeapTotalBytes": 13905920,
"scriptDurationMs": 38.971,
"eventListeners": -7471,
"totalBlockingTimeMs": 50,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3263.402000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.233,
"layouts": 20,
"layoutDurationMs": 14.931000000000006,
"taskDurationMs": 3092.611,
"heapDeltaBytes": -26595616,
"heapUsedBytes": 177615488,
"domNodes": -6549,
"jsHeapTotalBytes": 8454144,
"scriptDurationMs": 38.236000000000004,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 432.76400000002013,
"styleRecalcs": 19,
"styleRecalcDurationMs": 13.465000000000002,
"layouts": 4,
"layoutDurationMs": 1.199,
"taskDurationMs": 73.40299999999999,
"heapDeltaBytes": 5213988,
"heapUsedBytes": 73441512,
"domNodes": 153,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.776,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 78.0530000000681,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.562,
"layouts": 2,
"layoutDurationMs": 0.40099999999999986,
"taskDurationMs": 43.745000000000005,
"heapDeltaBytes": 3238168,
"heapUsedBytes": 70306728,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.7789999999999995,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
98d202c to
bd90948
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Faithful backport of merged #16522 onto core/1.53, with no extra code changes. The original and backport stable patch IDs are both 78588e394a44c199f04e5baa22874550373eb4ab; file status and numstat also match (5 files, +206/-1). Local typecheck, changed-file format/ESLint, 7 focused unit tests, and Playwright discovery of the new browser case pass. Hosted checks are green.
…isation on adoption (#16603) Backport of #16522 to `cloud/1.53`. Fixes the rgthree Image Comparer save error after reload (#16479), whose cause (#16097) shipped in 1.53. Clean cherry-pick of 67d5d3e, no conflicts. Requested by the release owner. <details><summary>Full context for agent readers</summary> - Source: #16522 (merged to main 2026-09-01), labeled needs-backport + cloud/1.53. - Cherry-pick of 67d5d3e onto `cloud/1.53`; original author preserved, AI co-author trailer stripped from the commit message per repo policy. - Sibling backports: #16602 (core/1.53), #16603 (cloud/1.53). The core/1.52 auto-backport failed on conflicts and is handled separately. </details> <!-- authored-by:agent w3-bp --> Co-authored-by: Alexander Brown <drjkl@comfy.org>
…tibility (#18472) Manual backport of #18301 to `core/1.53`. Cherry-picked from upstream merge commit `1344a91e0e5fd03ce2131bacf30d1faca7dcd26a`. ## Why Restores Impact Preview Bridge mask registration, WAS Pause live button enablement, and MiniMax RefMod schema-order serialization for the widget ECS compatibility layer shipped in core/1.53. ## Dependency check #18352 is still open, but it only changes `useStringWidget.ts` and its test. It is not in #18301's ancestry and does not overlap this backport, so the bot's stacking suggestion did not apply. ## Conflict resolution - `browser_tests/tests/loadWorkflowInMedia.spec.ts` — kept core/1.53's runtime settings and URL setup; added only the fixed LoadImage option fixture from #18301. - `src/components/graph/GraphCanvas.vue` — kept `LiteGraph.vueNodesMode` ownership in core/1.53's `useVueFeatureFlags`; refreshes live disabled state on renderer transitions without importing main's newer visibility facade. - `src/core/graph/widgets/nodeWidgetValues.ts` — preserved the target branch's callback behavior and added `widget.value` assignment after successful store writes so extension setters run. - `src/lib/litegraph/src/types/widgets.ts` and `BaseWidget.ts` — added only the live-disabled synchronization contract; omitted main-only visibility APIs. - `src/lib/litegraph/src/widgets/widgetMap.ts` — preserved core/1.53's normalizing setter composition from #16602 while retaining the extension's live `disabled` getter. - Browser compatibility specs use core/1.53's existing `getNodeRefsByType(...)[0]` helper because main's singular helper is unavailable. ## Backport-only compatibility fix Core/1.53's mask editor predates the shared widget-value boundary migration present on main. Its image write adapter now delegates to `setNodeWidgetValue`, ensuring mask Save reaches extension value setters while preserving the stable branch's store-first read path and `properties.image` mirror. A regression test covers this boundary. ## Validation - `pnpm test:unit src/composables/maskeditor/imageWidgetAdapter.test.ts src/core/graph/widgets/nodeWidgetValues.test.ts src/lib/litegraph/src/widgets/widgetMap.test.ts src/lib/litegraph/src/LGraph.serialise.test.ts` — 4 files, 39 tests passed. - `pnpm typecheck` — passed. - `pnpm typecheck:browser` — passed. - Changed-file ESLint — 0 errors; 26 pre-existing layer-boundary warnings in LiteGraph files. - Changed-file Oxlint — passed. - `pnpm exec oxfmt --check <changed JSON/TS/Vue/JS files>` — passed. - `python -m compileall -q tools/devtools/nodes` — passed. - Push-time `knip --cache` — passed. The three new browser compatibility specs require a production frontend served by a ComfyUI backend with `tools/devtools` installed; the local Vite workflow deliberately does not expose those extensions, so they were not run locally. Original PR: #18301
Backport of #16522 to
core/1.53. Fixes the rgthree Image Comparer save error after reload (#16479), whose cause (#16097) shipped in 1.53. Clean cherry-pick of 67d5d3e, no conflicts. Requested by the release owner.Full context for agent readers
core/1.53; original author preserved, AI co-author trailer stripped from the commit message per repo policy.