Repository navigation
[backport core/1.53] fix: restore Impact, WAS Pause, and RefMod compatibility - #18472
Conversation
Backport of #18301 to core/1.53. ## Backport-only compatibility fix Core/1.53's mask editor predates the shared widget-value boundary migration. Route its image write adapter through setNodeWidgetValue so registered widgets still invoke extension value setters while preserving the branch's read path. Amp-Thread-ID: https://ampcode.com/threads/T-01a0cb3e-a9d2-77bc-8240-13a5cfab694e
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1910 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T23:07:22.422Z",
"gitSha": "3e378068c49408ad76e375c8640beedec072f26c",
"branch": "backport-18301-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2100.987000000032,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.347999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.904,
"heapDeltaBytes": -12895228,
"heapUsedBytes": 56955540,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.359000000000002,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2044.4599999999582,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.590000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.935,
"heapDeltaBytes": -12721808,
"heapUsedBytes": 57130692,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.311000000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1856.935999999962,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.638000000000005,
"layouts": 14,
"layoutDurationMs": 4.168,
"taskDurationMs": 876.0459999999999,
"heapDeltaBytes": 1612976,
"heapUsedBytes": 71299228,
"domNodes": -282,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 161.32399999999998,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1908.046000000013,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.291000000000004,
"layouts": 14,
"layoutDurationMs": 4.578,
"taskDurationMs": 917.9380000000001,
"heapDeltaBytes": 1605232,
"heapUsedBytes": 71301392,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 169.84099999999998,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.8629999999544,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.986,
"layouts": 6,
"layoutDurationMs": 1.111,
"taskDurationMs": 350.41299999999995,
"heapDeltaBytes": 4333276,
"heapUsedBytes": 74057724,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.094,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.7490000000107,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.575000000000003,
"layouts": 6,
"layoutDurationMs": 1.0980000000000003,
"taskDurationMs": 357.19100000000003,
"heapDeltaBytes": 4652620,
"heapUsedBytes": 75551216,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.728,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 635.1509999999507,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.7470000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.93800000000005,
"heapDeltaBytes": -7812508,
"heapUsedBytes": 63040508,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 160.319,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 644.1559999999527,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.1720000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.31399999999996,
"heapDeltaBytes": -7412044,
"heapUsedBytes": 63394488,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 159.466,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2038.6369999999943,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.1640000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.0580000000001,
"heapDeltaBytes": 11468848,
"heapUsedBytes": 86817704,
"domNodes": -274,
"jsHeapTotalBytes": -2179072,
"scriptDurationMs": 40.945,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.6520000000137,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.925999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.337,
"heapDeltaBytes": -13888436,
"heapUsedBytes": 87369576,
"domNodes": -273,
"jsHeapTotalBytes": -1880064,
"scriptDurationMs": 41.046,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2234.708000000012,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.253999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1619.262,
"heapDeltaBytes": 20804532,
"heapUsedBytes": 87086900,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 822.8969999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2231.8619999999783,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.566999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1656.4950000000001,
"heapDeltaBytes": 10907316,
"heapUsedBytes": 87959924,
"domNodes": -269,
"jsHeapTotalBytes": -905216,
"scriptDurationMs": 838.4130000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3548.954999999978,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.479,
"layouts": 60,
"layoutDurationMs": 11.798000000000002,
"taskDurationMs": 1678.912,
"heapDeltaBytes": 8174800,
"heapUsedBytes": 76085284,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 769.9599999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3598.2529999999997,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.769999999999998,
"layouts": 60,
"layoutDurationMs": 11.82,
"taskDurationMs": 1670.8,
"heapDeltaBytes": 8149596,
"heapUsedBytes": 75547632,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 766.189,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3102.135999999973,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.630999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1912.7559999999999,
"heapDeltaBytes": 21919764,
"heapUsedBytes": 89780772,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 960.845,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3068.5479999999643,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.526,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1891.738,
"heapDeltaBytes": 22741364,
"heapUsedBytes": 90184796,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 945.9760000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2024.7909999999933,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.532999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.3130000000001,
"heapDeltaBytes": 22147288,
"heapUsedBytes": 88110500,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.094,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.9129999999413,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.48,
"heapDeltaBytes": 10670740,
"heapUsedBytes": 86627844,
"domNodes": -272,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 31.659999999999993,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.2529999999665,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.378,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.751,
"heapDeltaBytes": 14852380,
"heapUsedBytes": 87768548,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.44199999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.4339999999975,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.058,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.551,
"heapDeltaBytes": 14783200,
"heapUsedBytes": 87656924,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.66,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2024.15400000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.717999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.77400000000006,
"heapDeltaBytes": -10447124,
"heapUsedBytes": 62198188,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.186999999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.237000000071,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.809,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.471,
"heapDeltaBytes": 2348800,
"heapUsedBytes": 75308680,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.0619999999999985,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.391999999994,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.047,
"layouts": 18,
"layoutDurationMs": 5.343000000000001,
"taskDurationMs": 827.3539999999999,
"heapDeltaBytes": -13995816,
"heapUsedBytes": 58444668,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 111.786,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.089999999971,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.665,
"layouts": 18,
"layoutDurationMs": 4.628,
"taskDurationMs": 805.8299999999999,
"heapDeltaBytes": -12206780,
"heapUsedBytes": 60545484,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 111.97100000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.1109999999398,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.238,
"layouts": 15,
"layoutDurationMs": 16.069000000000003,
"taskDurationMs": 950.3809999999997,
"heapDeltaBytes": 21172444,
"heapUsedBytes": 109548004,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 32.75800000000001,
"eventListeners": 2381,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8517.771999999979,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.892999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5785.731,
"heapDeltaBytes": -12039544,
"heapUsedBytes": 89480168,
"domNodes": -265,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 2677.749,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8447.60599999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.24099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5808.4169999999995,
"heapDeltaBytes": -20184832,
"heapUsedBytes": 80886920,
"domNodes": -265,
"jsHeapTotalBytes": -606208,
"scriptDurationMs": 2725.5220000000004,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16946.998000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16498.271,
"heapDeltaBytes": -34372472,
"heapUsedBytes": 175389924,
"domNodes": -6548,
"jsHeapTotalBytes": -3796992,
"scriptDurationMs": 281.505,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16946.33699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16441.04,
"heapDeltaBytes": -33273856,
"heapUsedBytes": 175993024,
"domNodes": -6548,
"jsHeapTotalBytes": -3362816,
"scriptDurationMs": 280.435,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21038.182000000008,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.784999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20623,
"heapDeltaBytes": -28500416,
"heapUsedBytes": 180210928,
"domNodes": -6548,
"jsHeapTotalBytes": -5378048,
"scriptDurationMs": 955.1610000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 60,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20961.320999999996,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.80200000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20485.324,
"heapDeltaBytes": -41867316,
"heapUsedBytes": 162824536,
"domNodes": -6548,
"jsHeapTotalBytes": 1044480,
"scriptDurationMs": 908.4239999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 137,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6127.716999999961,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.61799999999997,
"layouts": 20,
"layoutDurationMs": 23.73399999999999,
"taskDurationMs": 6031.195,
"heapDeltaBytes": -26851604,
"heapUsedBytes": 183243048,
"domNodes": -6548,
"jsHeapTotalBytes": 9007104,
"scriptDurationMs": 111.67,
"eventListeners": -7471,
"totalBlockingTimeMs": 511,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6232.089999999971,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.66499999999999,
"layouts": 20,
"layoutDurationMs": 23.30199999999999,
"taskDurationMs": 6137.259,
"heapDeltaBytes": -30143184,
"heapUsedBytes": 179332352,
"domNodes": -6548,
"jsHeapTotalBytes": 10350592,
"scriptDurationMs": 111.04700000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 528,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 469.0049999999246,
"styleRecalcs": 22,
"styleRecalcDurationMs": 24.685,
"layouts": 4,
"layoutDurationMs": 2.162,
"taskDurationMs": 124.723,
"heapDeltaBytes": 5267180,
"heapUsedBytes": 74277736,
"domNodes": 151,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.982000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 89.34999999996762,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.234999999999998,
"layouts": 2,
"layoutDurationMs": 1.198,
"taskDurationMs": 66.931,
"heapDeltaBytes": 3112292,
"heapUsedBytes": 71629512,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.673000000000002,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.53 #18472 +/- ##
=============================================
+ Coverage 83.29% 83.40% +0.10%
=============================================
Files 2036 2034 -2
Lines 117789 117888 +99
Branches 33287 32718 -569
=============================================
+ Hits 98111 98322 +211
+ Misses 19322 19203 -119
- Partials 356 363 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 58 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of #18301 to
core/1.53.Cherry-picked from upstream merge commit
1344a91e0e5fd03ce2131bacf30d1faca7dcd26a.Why
Restores Impact Preview Bridge mask registration, WAS Pause live button enablement, and MiniMax RefMod schema-order serialization for the widget ECS compatibility layer shipped in core/1.53.
Dependency check
#18352 is still open, but it only changes
useStringWidget.tsand its test. It is not in #18301's ancestry and does not overlap this backport, so the bot's stacking suggestion did not apply.Conflict resolution
browser_tests/tests/loadWorkflowInMedia.spec.ts— kept core/1.53's runtime settings and URL setup; added only the fixed LoadImage option fixture from fix: restore Impact, WAS Pause, and RefMod compatibility #18301.src/components/graph/GraphCanvas.vue— keptLiteGraph.vueNodesModeownership in core/1.53'suseVueFeatureFlags; refreshes live disabled state on renderer transitions without importing main's newer visibility facade.src/core/graph/widgets/nodeWidgetValues.ts— preserved the target branch's callback behavior and addedwidget.valueassignment after successful store writes so extension setters run.src/lib/litegraph/src/types/widgets.tsandBaseWidget.ts— added only the live-disabled synchronization contract; omitted main-only visibility APIs.src/lib/litegraph/src/widgets/widgetMap.ts— preserved core/1.53's normalizing setter composition from [backport core/1.53] fix(litegraph): keep custom widget value normalisation on adoption #16602 while retaining the extension's livedisabledgetter.getNodeRefsByType(...)[0]helper because main's singular helper is unavailable.Backport-only compatibility fix
Core/1.53's mask editor predates the shared widget-value boundary migration present on main. Its image write adapter now delegates to
setNodeWidgetValue, ensuring mask Save reaches extension value setters while preserving the stable branch's store-first read path andproperties.imagemirror. A regression test covers this boundary.Validation
pnpm test:unit src/composables/maskeditor/imageWidgetAdapter.test.ts src/core/graph/widgets/nodeWidgetValues.test.ts src/lib/litegraph/src/widgets/widgetMap.test.ts src/lib/litegraph/src/LGraph.serialise.test.ts— 4 files, 39 tests passed.pnpm typecheck— passed.pnpm typecheck:browser— passed.pnpm exec oxfmt --check <changed JSON/TS/Vue/JS files>— passed.python -m compileall -q tools/devtools/nodes— passed.knip --cache— passed.The three new browser compatibility specs require a production frontend served by a ComfyUI backend with
tools/devtoolsinstalled; the local Vite workflow deliberately does not expose those extensions, so they were not run locally.Original PR: #18301