Skip to content

[backport cloud/1.53] fix(litegraph): keep custom widget value normalisation on adoption - #16603

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16522-to-cloud-1.53
Sep 2, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16522-to-cloud-1.53

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #16522 to cloud/1.53. Fixes the rgthree Image Comparer save error after reload (#16479), whose cause (#16097) shipped in 1.53. Clean cherry-pick of 67d5d3e, no conflicts. Requested by the release owner.

Full context for agent readers

…16522)

## Summary

Custom widgets that own their value behind an accessor pair lost their
own normalisation when adopted, so rgthree's Image Comparer threw
`TypeError: can't access property "map",
this.widgets[index].value.images is undefined` from `onSerialize` on
every workflow switch.

## Changes

- **What**: `adoptConcreteWidget` composes a foreign `value` accessor
with the concrete store-backed one. The composed setter wrote the
assigned value straight to the store and the getter returned it,
discarding whatever the widget's own setter normalised. The composed
setter now runs the foreign setter first and stores what the foreign
getter reports, so store reads match the shape the widget itself
exposes. If the foreign getter yields `undefined`, the assigned value is
stored unchanged.
- **Devtools node + E2E**: `DevToolsNodeWithComparerWidget` and
`tools/devtools/web/comparerWidget.js` mirror rgthree's image comparer —
a widget that takes either the serialised list or `{ images }` and
always reads back `{ images }`, plus a node that rewrites
`widgets_values` with the bare list in `onSerialize`.
`browser_tests/tests/legacyDoNotReplicate/legacyComparerWidgetValue.spec.ts`
walks the user's route to the crash: add the node, save the workflow,
reopen it from the sidebar (which feeds the saved list back to the
widget), serialise, and switch away. The custom-node behaviour is
modelled only there, in the quarantined suite.
- **Unit**: one case in `widgetMap.test.ts`, alongside its existing
foreign-accessor cases — a foreign setter's normalised value is what the
store keeps.

## Review Focus

Why the comparer broke: its setter accepts either the serialised image
list or `{ images }`, and its getter always returns `{ images }`. Its
own `onSerialize` writes the bare list into `widgets_values`, so after a
workflow load the widget was assigned a list, the store handed that list
straight back on read, and `value.images.map` threw. The same pattern
appears in rgthree's Power Puter (`{ outputs }`, accepts a bare string)
and Power Lora Loader (falls back to defaults for a non-object), both of
which this also repairs.

The ordering change (foreign setter before concrete setter) means a
foreign setter that reads `this.value` now sees the previous value
rather than the incoming one. That matches what the widget's author
wrote the setter against.

Consequence worth noting: the store now holds the object the widget
owns, so later mutations by the widget are visible through the store
rather than diverging from it.

The unit case was verified red-then-green locally. The E2E spec
typechecks, lints and collects, but this container has no ComfyUI
backend (no Docker daemon, cloud host blocked by network policy), so it
has not been executed — CI is its first run.



---------

(cherry picked from commit 67d5d3e)
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) labels Sep 2, 2026
@christian-byrne christian-byrne self-assigned this Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 64c2be7d-ef48-4bbb-bb54-9fb19113ed5a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1893 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1872 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 05:55:50 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 130ms TBT · 82.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.5 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 165ms TBT · 175.3 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 459ms TBT · 171.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 498ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.6 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 6ms
canvas-mouse-sweep: style recalc duration 48ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 80
canvas-mouse-sweep: task duration 1011ms
canvas-mouse-sweep: script duration 171ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 70.9 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -186
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 355ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.6 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 443ms
dom-widget-clipping: script duration 153ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.0 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 596ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.0 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1585ms
large-graph-pan: script duration 772ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.2 MB
large-graph-pan: DOM nodes -273
large-graph-pan: event listeners -169
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1696ms
large-graph-zoom: script duration 780ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 75.0 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1861ms
legacy-node-drag: script duration 927ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.0 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 591ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.5 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -185
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 411ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.6 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 493ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.3 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -200
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 40ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 813ms
subgraph-mouse-sweep: script duration 104ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.6 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 917ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 130ms
subgraph-transition-enter: heap used 82.3 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5724ms
viewport-pan-sweep: script duration 2628ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.3 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -139
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17324ms
vue-large-graph-idle: script duration 316ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 161.5 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 173
vue-large-graph-pan: task duration 21995ms
vue-large-graph-pan: script duration 923ms
vue-large-graph-pan: TBT 165ms
vue-large-graph-pan: heap used 175.3 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 74ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6378ms
vue-node-resize-workload: script duration 123ms
vue-node-resize-workload: TBT 459ms
vue-node-resize-workload: heap used 171.1 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 2
workflow-execution: style recalc count 11
workflow-execution: task duration 90ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.2 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-02T06:14:48.501Z",
  "gitSha": "4952b8421842d4e4ee95d5f0a2c3c56138c82edb",
  "branch": "backport-16522-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2038.9620000000264,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.245999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.123,
      "heapDeltaBytes": 330160,
      "heapUsedBytes": 70527888,
      "domNodes": -281,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 8.854999999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2068.2150000000092,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.666,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 493.956,
      "heapDeltaBytes": -13145912,
      "heapUsedBytes": 56465816,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.32,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2131.5609999999765,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 55.642999999999994,
      "layouts": 14,
      "layoutDurationMs": 6.328,
      "taskDurationMs": 1129.517,
      "heapDeltaBytes": 4745832,
      "heapUsedBytes": 74253872,
      "domNodes": -282,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 191.47400000000002,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1889.534000000026,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.683,
      "layouts": 14,
      "layoutDurationMs": 4.836999999999999,
      "taskDurationMs": 893.3399999999999,
      "heapDeltaBytes": 4315300,
      "heapUsedBytes": 74531752,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 151.4,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.039999999969,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.459000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.1720000000000002,
      "taskDurationMs": 356.819,
      "heapDeltaBytes": 4364456,
      "heapUsedBytes": 74994632,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.323,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.0199999999431,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 15.506,
      "layouts": 6,
      "layoutDurationMs": 1.026,
      "taskDurationMs": 353.784,
      "heapDeltaBytes": 4377524,
      "heapUsedBytes": 75154656,
      "domNodes": 76,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.924999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 656.0029999999983,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.971,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.40200000000004,
      "heapDeltaBytes": -7726712,
      "heapUsedBytes": 62673296,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 150.98,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 637.7070000000913,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.931000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.187,
      "heapDeltaBytes": 18190860,
      "heapUsedBytes": 88282908,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 155.88000000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.7379999999762,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.923,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 593.9390000000001,
      "heapDeltaBytes": -13520500,
      "heapUsedBytes": 87125552,
      "domNodes": -271,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 30.782000000000004,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.740000000099,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.400000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 597.4739999999999,
      "heapDeltaBytes": -13260468,
      "heapUsedBytes": 86887340,
      "domNodes": -268,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 33.791999999999994,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2152.7060000000233,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.986000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1533.4240000000002,
      "heapDeltaBytes": 19373008,
      "heapUsedBytes": 85102652,
      "domNodes": -271,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 747.521,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2224.9910000000455,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.117999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1637.3949999999998,
      "heapDeltaBytes": 4277492,
      "heapUsedBytes": 81067012,
      "domNodes": -274,
      "jsHeapTotalBytes": 405504,
      "scriptDurationMs": 797.01,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3511.9020000000205,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.595,
      "layouts": 60,
      "layoutDurationMs": 12.802999999999999,
      "taskDurationMs": 1640.5279999999998,
      "heapDeltaBytes": 8461876,
      "heapUsedBytes": 75729752,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 740.989,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3606.573000000026,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.788000000000006,
      "layouts": 60,
      "layoutDurationMs": 13.046999999999999,
      "taskDurationMs": 1751.0659999999998,
      "heapDeltaBytes": 13755748,
      "heapUsedBytes": 81591204,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 818.753,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3006.257000000005,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.327999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1869.894,
      "heapDeltaBytes": 21475080,
      "heapUsedBytes": 89251808,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 929.519,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3080.2929999999833,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.364999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1852.8739999999998,
      "heapDeltaBytes": 21188440,
      "heapUsedBytes": 88980576,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 924.4999999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.618999999997,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 4.919,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.9459999999999,
      "heapDeltaBytes": 9396648,
      "heapUsedBytes": 86192820,
      "domNodes": -277,
      "jsHeapTotalBytes": -2179072,
      "scriptDurationMs": 38.486,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.7579999999589,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.931999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 593.789,
      "heapDeltaBytes": 10363432,
      "heapUsedBytes": 86925724,
      "domNodes": -274,
      "jsHeapTotalBytes": -1916928,
      "scriptDurationMs": 32.495999999999995,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 628.0990000000202,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.560000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.78900000000004,
      "heapDeltaBytes": 14316452,
      "heapUsedBytes": 85884004,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 142.679,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.8019999999688,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.074,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.76899999999995,
      "heapDeltaBytes": 14840320,
      "heapUsedBytes": 87403424,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 142.12800000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2039.322000000027,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.731,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.304,
      "heapDeltaBytes": -8319312,
      "heapUsedBytes": 63864892,
      "domNodes": -293,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.975999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.9769999999926,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.176999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.26699999999994,
      "heapDeltaBytes": -9853148,
      "heapUsedBytes": 62523340,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.783999999999999,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1736.4170000000172,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 37.074,
      "layouts": 18,
      "layoutDurationMs": 5.101000000000001,
      "taskDurationMs": 793.396,
      "heapDeltaBytes": -12544420,
      "heapUsedBytes": 60149460,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 102.241,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1739.8840000000746,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 42.485,
      "layouts": 18,
      "layoutDurationMs": 6.063,
      "taskDurationMs": 832.133,
      "heapDeltaBytes": -11874164,
      "heapUsedBytes": 60642204,
      "domNodes": -295,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 104.772,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.4780000000583,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 31.574000000000005,
      "layouts": 16,
      "layoutDurationMs": 14.735999999999995,
      "taskDurationMs": 917.3489999999999,
      "heapDeltaBytes": -5337180,
      "heapUsedBytes": 86347076,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 30.35,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 130,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8412.45200000003,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 39.586,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5643.398999999999,
      "heapDeltaBytes": -15753376,
      "heapUsedBytes": 84585020,
      "domNodes": -269,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 2581.839,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8396.556000000033,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 37.604,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5804.933,
      "heapDeltaBytes": -10588284,
      "heapUsedBytes": 90192056,
      "domNodes": -271,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 2674.08,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18209.821999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17525.829,
      "heapDeltaBytes": -40400548,
      "heapUsedBytes": 164304968,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1961984,
      "scriptDurationMs": 321.749,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17887.051999999927,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17122.807,
      "heapDeltaBytes": -35328192,
      "heapUsedBytes": 174369536,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4845568,
      "scriptDurationMs": 309.554,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22695.245,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 22.58899999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22383.429,
      "heapDeltaBytes": -43990632,
      "heapUsedBytes": 177246476,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1900544,
      "scriptDurationMs": 925.5580000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 155,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21945.53499999995,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 19.747999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21606.421000000002,
      "heapDeltaBytes": -20003232,
      "heapUsedBytes": 190369676,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5177344,
      "scriptDurationMs": 919.448,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 175,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6687.018000000024,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.67999999999996,
      "layouts": 20,
      "layoutDurationMs": 24.221999999999994,
      "taskDurationMs": 6590.379,
      "heapDeltaBytes": -45716940,
      "heapUsedBytes": 167628704,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1593344,
      "scriptDurationMs": 123.56200000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 473,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6254.165999999941,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.44000000000001,
      "layouts": 20,
      "layoutDurationMs": 24.462999999999997,
      "taskDurationMs": 6166.148,
      "heapDeltaBytes": -23992648,
      "heapUsedBytes": 191261552,
      "domNodes": -6548,
      "jsHeapTotalBytes": 19865600,
      "scriptDurationMs": 123.201,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 445,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 447.69800000005944,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 18.493999999999996,
      "layouts": 2,
      "layoutDurationMs": 0.575,
      "taskDurationMs": 99.118,
      "heapDeltaBytes": 5071304,
      "heapUsedBytes": 73643796,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.438999999999997,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 114.05400000001009,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 17.872,
      "layouts": 2,
      "layoutDurationMs": 1.4540000000000002,
      "taskDurationMs": 81.84899999999999,
      "heapDeltaBytes": 3121956,
      "heapUsedBytes": 71568028,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.700000000000001,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 47990 70464 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport of merged #16522 onto cloud/1.53, with no extra code changes. The original and backport stable patch IDs are both 78588e394a44c199f04e5baa22874550373eb4ab; file status and numstat also match (5 files, +206/-1). Local typecheck, changed-file format/ESLint, 7 focused unit tests, and Playwright discovery of the new browser case pass. Hosted checks are green.

comfy-pr-bot pushed a commit that referenced this pull request Sep 2, 2026
…sation on adoption (#16602)

Backport of #16522 to `core/1.53`. Fixes the rgthree Image Comparer save
error after reload (#16479), whose cause (#16097) shipped in 1.53. Clean
cherry-pick of 67d5d3e, no conflicts. Requested by the release owner.

<details><summary>Full context for agent readers</summary>

- Source: #16522 (merged to main 2026-09-01), labeled needs-backport +
core/1.53.
- Cherry-pick of 67d5d3e onto
`core/1.53`; original author preserved, AI co-author trailer stripped
from the commit message per repo policy.
- Sibling backports: #16602 (core/1.53), #16603 (cloud/1.53). The
core/1.52 auto-backport failed on conflicts and is handled separately.

</details>

<!-- authored-by:agent w3-bp -->

Co-authored-by: Alexander Brown <drjkl@comfy.org>
@comfy-pr-bot
comfy-pr-bot merged commit 1642c81 into cloud/1.53 Sep 2, 2026
98 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16522-to-cloud-1.53 branch September 2, 2026 09:57
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants