Repository navigation
fix(ci): follow-up to #15418 — restore binary-size label revalidation - #16585
Conversation
Restores immediate apply/revoke semantics for allow-large-binaries while isolating unrelated label events from the validation concurrency group. Review threads: Comfy-Org#15418 (comment) Comfy-Org#15418 (comment) Comfy-Org#15418 (comment)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe binary-size validation workflow now handles pull request label changes. It uses conditional concurrency groups and evaluates ChangesBinary size validation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This workflow change restores binary-size label revalidation without an identified current merge-blocking issue; no actionable risk remains beyond normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The review context does not provide the PR title or any commit subjects. The custom check requires that metadata to evaluate the bug-fix condition and explicitly requires INCONCLUSIVE when commit subjects or the changed-file list are unavailable. The context does show a CI workflow change, but that does not replace the missing required metadata. Full details: Website End-To-End Regression CoverageExplanation The changed-file list shows only Full details: Description checkExplanation The description explains the purpose, affected label events, concurrency behavior, follow-up context, and verification steps. The Review Focus section is not included, but the description is otherwise complete and relevant.
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: 🚧 Building...🎭 Playwright: ✅ 1898 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.67 MB gzip 🟢 -763 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • 🟢 -1.79 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 17 added / 17 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 70 added / 70 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T05:31:37.876Z",
"gitSha": "1673298821c2d092e3f50b28684479365610ad1b",
"branch": "fix/binary-size-label-revalidation-followup-15418",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2064.538999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.837,
"heapDeltaBytes": -13035128,
"heapUsedBytes": 56483440,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.224,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2032.9699999999775,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.576000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.44599999999997,
"heapDeltaBytes": 11779340,
"heapUsedBytes": 81569212,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.456999999999997,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2058.3579999999984,
"styleRecalcs": 79,
"styleRecalcDurationMs": 49.338,
"layouts": 14,
"layoutDurationMs": 5.276999999999999,
"taskDurationMs": 1051.279,
"heapDeltaBytes": -8301324,
"heapUsedBytes": 61914172,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 172.781,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.6020000000208,
"styleRecalcs": 80,
"styleRecalcDurationMs": 44.166999999999994,
"layouts": 14,
"layoutDurationMs": 4.889,
"taskDurationMs": 912.096,
"heapDeltaBytes": -8647264,
"heapUsedBytes": 61679992,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 150.55200000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.1770000000006,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.386,
"layouts": 6,
"layoutDurationMs": 1.291,
"taskDurationMs": 366.81899999999996,
"heapDeltaBytes": 4635680,
"heapUsedBytes": 75392732,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.346,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1676.1600000000954,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.500000000000004,
"layouts": 6,
"layoutDurationMs": 1.1260000000000003,
"taskDurationMs": 402.498,
"heapDeltaBytes": 4392256,
"heapUsedBytes": 74967392,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.704000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 664.1669999999635,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.8889999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.72499999999997,
"heapDeltaBytes": -7853236,
"heapUsedBytes": 62826636,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 155.935,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 662.431999999967,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.777,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.13199999999995,
"heapDeltaBytes": -7813172,
"heapUsedBytes": 62790336,
"domNodes": 16,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 153.22,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2053.929000000039,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.115999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.202,
"heapDeltaBytes": -14073984,
"heapUsedBytes": 86760124,
"domNodes": -269,
"jsHeapTotalBytes": -1622016,
"scriptDurationMs": 34.059000000000005,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.824999999998,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.671999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.682,
"heapDeltaBytes": 22163076,
"heapUsedBytes": 87106808,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.366,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2169.1170000000284,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.467000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1538.6309999999999,
"heapDeltaBytes": 19061408,
"heapUsedBytes": 84365000,
"domNodes": -274,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 731.256,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2235.7319999999845,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.932000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1620.6390000000001,
"heapDeltaBytes": 22037468,
"heapUsedBytes": 87696872,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 772.3129999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3486.8960000000015,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.014999999999997,
"layouts": 60,
"layoutDurationMs": 13.422,
"taskDurationMs": 1698.721,
"heapDeltaBytes": 7357076,
"heapUsedBytes": 76464252,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 764.356,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3529.3679999999767,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.092999999999998,
"layouts": 60,
"layoutDurationMs": 13.264,
"taskDurationMs": 1690.1950000000002,
"heapDeltaBytes": 8788528,
"heapUsedBytes": 75766196,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 748.8589999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3093.819999999994,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.246,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1889.5749999999998,
"heapDeltaBytes": 17501884,
"heapUsedBytes": 85187400,
"domNodes": -11,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 942.222,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3103.836000000001,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.4380000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1936.41,
"heapDeltaBytes": 25805896,
"heapUsedBytes": 93469496,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 965.0799999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.2679999999777,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.8109999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.147,
"heapDeltaBytes": 21699724,
"heapUsedBytes": 87111620,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 41.33500000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.7410000000164,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.2949999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.476,
"heapDeltaBytes": -15038388,
"heapUsedBytes": 87827752,
"domNodes": -271,
"jsHeapTotalBytes": -1622016,
"scriptDurationMs": 35.193999999999996,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.7109999999939,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.137,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.099,
"heapDeltaBytes": 14842192,
"heapUsedBytes": 87448268,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 140.925,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.7699999999868,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.654,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.4839999999999,
"heapDeltaBytes": 14793664,
"heapUsedBytes": 87434284,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 135.659,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.262000000012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.939000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.363,
"heapDeltaBytes": -688404,
"heapUsedBytes": 70298000,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.741999999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.077999999965,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.853000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.10999999999996,
"heapDeltaBytes": -8247364,
"heapUsedBytes": 64338032,
"domNodes": -295,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.802999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1802.2310000000061,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.815000000000005,
"layouts": 18,
"layoutDurationMs": 6.479,
"taskDurationMs": 874.021,
"heapDeltaBytes": -12200464,
"heapUsedBytes": 60376188,
"domNodes": -298,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 110.194,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.0679999999938,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.482,
"layouts": 18,
"layoutDurationMs": 5.863999999999999,
"taskDurationMs": 838.152,
"heapDeltaBytes": 2419384,
"heapUsedBytes": 75234544,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 106.565,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.3510000000006,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.089,
"layouts": 14,
"layoutDurationMs": 14.348999999999997,
"taskDurationMs": 914.784,
"heapDeltaBytes": -7094848,
"heapUsedBytes": 82277568,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 30.856999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 123,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8481.877999999995,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.536,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5903.2119999999995,
"heapDeltaBytes": 8891144,
"heapUsedBytes": 84884648,
"domNodes": -269,
"jsHeapTotalBytes": -909312,
"scriptDurationMs": 2581.0460000000003,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8346.66100000004,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.483000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5661.734,
"heapDeltaBytes": 23650060,
"heapUsedBytes": 88574660,
"domNodes": -271,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2574.5199999999995,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18216.11100000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17635.6,
"heapDeltaBytes": -41588096,
"heapUsedBytes": 174129960,
"domNodes": -6548,
"jsHeapTotalBytes": 3088384,
"scriptDurationMs": 330.99,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18007.90799999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17599.546,
"heapDeltaBytes": -24090588,
"heapUsedBytes": 187257184,
"domNodes": -6548,
"jsHeapTotalBytes": 7806976,
"scriptDurationMs": 304.371,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22467.514999999992,
"styleRecalcs": 169,
"styleRecalcDurationMs": 22.008000000000028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22205.046,
"heapDeltaBytes": -11708996,
"heapUsedBytes": 190111528,
"domNodes": -6548,
"jsHeapTotalBytes": 4403200,
"scriptDurationMs": 945.8980000000001,
"eventListeners": -7470,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22172.086000000036,
"styleRecalcs": 164,
"styleRecalcDurationMs": 22.042000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21985.413,
"heapDeltaBytes": -29121888,
"heapUsedBytes": 180644020,
"domNodes": -6548,
"jsHeapTotalBytes": -4132864,
"scriptDurationMs": 945.4359999999999,
"eventListeners": -7467,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6505.599000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.928,
"layouts": 20,
"layoutDurationMs": 25.632000000000016,
"taskDurationMs": 6430.993,
"heapDeltaBytes": -28782852,
"heapUsedBytes": 181091352,
"domNodes": -6548,
"jsHeapTotalBytes": 11927552,
"scriptDurationMs": 121.70500000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 450,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6486.5420000000995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.762,
"layouts": 20,
"layoutDurationMs": 24.511000000000006,
"taskDurationMs": 6404.124,
"heapDeltaBytes": -29969884,
"heapUsedBytes": 179609408,
"domNodes": -6548,
"jsHeapTotalBytes": 10846208,
"scriptDurationMs": 121.243,
"eventListeners": -7471,
"totalBlockingTimeMs": 386,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 110.03199999993285,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.154,
"layouts": 2,
"layoutDurationMs": 4.44,
"taskDurationMs": 78.61199999999998,
"heapDeltaBytes": 3186512,
"heapUsedBytes": 71528080,
"domNodes": 130,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.591,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 124.33999999996104,
"styleRecalcs": 7,
"styleRecalcDurationMs": 23.418000000000003,
"layouts": 3,
"layoutDurationMs": 1.173,
"taskDurationMs": 94.56500000000001,
"heapDeltaBytes": 3219860,
"heapUsedBytes": 71635196,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.46,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16585 +/- ##
==========================================
+ Coverage 80.67% 82.28% +1.61%
==========================================
Files 2432 2023 -409
Lines 124041 116799 -7242
Branches 32804 29267 -3537
==========================================
- Hits 100065 96112 -3953
+ Misses 23475 20510 -2965
+ Partials 501 177 -324
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
CI recovered; exact-head approval preserved; auto-merge enabled. Full context for agent readersThe failed |
Follow-up to #15418
Summary
Restores immediate binary-size revalidation when
allow-large-binariesis applied or removed, without letting unrelated label writes cancel an in-flight validation.Changes
labeledandunlabeledagain.allow-large-binariesevents in the validation group: applying the bypass cancels/skips, removing it runs a fresh size check.Follow-up to #15418
Addresses:
Verification:
pnpm typecheck; workflow YAML parse;oxfmt --check. No Vitest target is affected by this workflow-only change.