Repository navigation
ci(binary-size): stop re-triggering on label changes - #15418
Conversation
`ci-binary-size-validation.yaml` subscribes to the `labeled` and `unlabeled` pull_request event types while using a concurrency group with `cancel-in-progress: true`. Any label write therefore starts a second run on the identical commit and cancels the one already in flight. A label change cannot alter a bundle's size, so there is nothing for the job to re-evaluate. The `allow-large-binaries` bypass is still read from `github.event.pull_request.labels.*.name` and is re-evaluated on the next `synchronize`. Measured over 819 runs (2026-08-16 -> 08-18): 164 cancelled (20.0%), and 163 of those 164 (99.4%) were superseded by a later run on the *same* head SHA, median 2s apart -- not by a push.
🎭 Playwright: ✅ 1830 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 8.86 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.52 MB (baseline 3.52 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 549 kB (baseline 549 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BBundles that do not match a named category Status: 286 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-18T23:03:18.146Z",
"gitSha": "ab76ffe2f73cfc50ed07c9211240d7ca7172856c",
"branch": "fix/binary-size-label-triggers",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2144.916999999964,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.401999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.177,
"heapDeltaBytes": -1698644,
"heapUsedBytes": 58570156,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.422999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2032.2930000000952,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.238000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.3419999999999,
"heapDeltaBytes": 1145900,
"heapUsedBytes": 62151752,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.723999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1922.6079999999683,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.273,
"layouts": 12,
"layoutDurationMs": 3.6700000000000004,
"taskDurationMs": 935.4910000000001,
"heapDeltaBytes": 12181588,
"heapUsedBytes": 73460160,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 118.629,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1902.588000000037,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.695,
"layouts": 12,
"layoutDurationMs": 3.3,
"taskDurationMs": 851.032,
"heapDeltaBytes": 12798680,
"heapUsedBytes": 73472204,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 108.773,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.2269999999562,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.671999999999999,
"layouts": 6,
"layoutDurationMs": 0.6689999999999999,
"taskDurationMs": 364.387,
"heapDeltaBytes": 2834768,
"heapUsedBytes": 63109876,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.350000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.197999999963,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.608999999999998,
"layouts": 6,
"layoutDurationMs": 0.66,
"taskDurationMs": 363.28099999999995,
"heapDeltaBytes": 2766028,
"heapUsedBytes": 63428664,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.054,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 566.6399999999499,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.798000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.405,
"heapDeltaBytes": 10416356,
"heapUsedBytes": 71009184,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 54.401999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 582.0979999999736,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.486999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.59999999999997,
"heapDeltaBytes": 10710628,
"heapUsedBytes": 70973548,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 54.90099999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2073.0389999999943,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.329,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 618.823,
"heapDeltaBytes": 1349992,
"heapUsedBytes": 75293940,
"domNodes": -262,
"jsHeapTotalBytes": -1314816,
"scriptDurationMs": 13.826000000000002,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2058.3809999999403,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.669000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.37,
"heapDeltaBytes": 2714416,
"heapUsedBytes": 76639276,
"domNodes": -263,
"jsHeapTotalBytes": -2101248,
"scriptDurationMs": 15.665000000000004,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2141.638999999998,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.725999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1179.5629999999999,
"heapDeltaBytes": 1228988,
"heapUsedBytes": 76366176,
"domNodes": -263,
"jsHeapTotalBytes": -1351680,
"scriptDurationMs": 338.36,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2176.0830000000624,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.497,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1207.393,
"heapDeltaBytes": 13542028,
"heapUsedBytes": 87722548,
"domNodes": -282,
"jsHeapTotalBytes": 5464064,
"scriptDurationMs": 349.9,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3156.673000000012,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.939999999999998,
"layouts": 60,
"layoutDurationMs": 7.236,
"taskDurationMs": 1322.522,
"heapDeltaBytes": 15583124,
"heapUsedBytes": 78482432,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 388.27299999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3180.178999999953,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.904,
"layouts": 60,
"layoutDurationMs": 6.89,
"taskDurationMs": 1365.656,
"heapDeltaBytes": 15554312,
"heapUsedBytes": 76625964,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 390.113,
"eventListeners": -145,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2268.8170000000127,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.797999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1422.259,
"heapDeltaBytes": 11680600,
"heapUsedBytes": 94332460,
"domNodes": 12,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 457.79,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2256.9630000000416,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.620000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1414.031,
"heapDeltaBytes": 11972116,
"heapUsedBytes": 94692152,
"domNodes": 14,
"jsHeapTotalBytes": 7794688,
"scriptDurationMs": 457.774,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.098,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.877,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.189,
"heapDeltaBytes": 1984584,
"heapUsedBytes": 77594272,
"domNodes": -267,
"jsHeapTotalBytes": -2363392,
"scriptDurationMs": 12.750999999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2057.9500000000053,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.613999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.944,
"heapDeltaBytes": -4762704,
"heapUsedBytes": 76026180,
"domNodes": -262,
"jsHeapTotalBytes": 4784128,
"scriptDurationMs": 13.876999999999997,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.5669999999832,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.466999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.33399999999995,
"heapDeltaBytes": 11082852,
"heapUsedBytes": 71968156,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 121.18299999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 569.5269999999937,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.922999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.15400000000005,
"heapDeltaBytes": 10783820,
"heapUsedBytes": 71323160,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 113.96400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2004.0839999999776,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.126999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.08299999999997,
"heapDeltaBytes": -515148,
"heapUsedBytes": 60368992,
"domNodes": -281,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 6.310000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2034.8340000000462,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.240999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.204,
"heapDeltaBytes": 342688,
"heapUsedBytes": 61132280,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.178000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.9930000000113,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.629,
"layouts": 16,
"layoutDurationMs": 5.104,
"taskDurationMs": 813.8969999999999,
"heapDeltaBytes": 8420560,
"heapUsedBytes": 69158548,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 88.423,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.0100000000684,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.33500000000001,
"layouts": 16,
"layoutDurationMs": 4.248,
"taskDurationMs": 794.462,
"heapDeltaBytes": 10192228,
"heapUsedBytes": 71240968,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 86.076,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.0230000000247,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.471,
"layouts": 14,
"layoutDurationMs": 14.369,
"taskDurationMs": 913.0700000000003,
"heapDeltaBytes": 21784480,
"heapUsedBytes": 96529580,
"domNodes": 13673,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 18.066,
"eventListeners": 2375,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8232.105999999987,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.769,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4193.3730000000005,
"heapDeltaBytes": 8361088,
"heapUsedBytes": 82334980,
"domNodes": -262,
"jsHeapTotalBytes": -1613824,
"scriptDurationMs": 1064.3700000000001,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8347.753000000012,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.44799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4178.567,
"heapDeltaBytes": -10623896,
"heapUsedBytes": 63350896,
"domNodes": -281,
"jsHeapTotalBytes": 4976640,
"scriptDurationMs": 1075.3460000000002,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17107.011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16443.875000000004,
"heapDeltaBytes": -45338492,
"heapUsedBytes": 173550972,
"domNodes": -8312,
"jsHeapTotalBytes": -20127744,
"scriptDurationMs": 114.78,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16836.141999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16242.283000000001,
"heapDeltaBytes": -32117904,
"heapUsedBytes": 173749348,
"domNodes": -8312,
"jsHeapTotalBytes": -14327808,
"scriptDurationMs": 108.77899999999998,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20774.680999999986,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.291,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20159.267,
"heapDeltaBytes": -28486436,
"heapUsedBytes": 190837692,
"domNodes": -8312,
"jsHeapTotalBytes": -11804672,
"scriptDurationMs": 431.66600000000005,
"eventListeners": -16385,
"totalBlockingTimeMs": 59,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21004.362000000016,
"styleRecalcs": 173,
"styleRecalcDurationMs": 18.206,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20315.842,
"heapDeltaBytes": -21527560,
"heapUsedBytes": 184077656,
"domNodes": -8312,
"jsHeapTotalBytes": -12066816,
"scriptDurationMs": 407.45200000000006,
"eventListeners": -16385,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 118.53499999995165,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.159999999999997,
"layouts": 7,
"layoutDurationMs": 2.2300000000000004,
"taskDurationMs": 89.051,
"heapDeltaBytes": 3082944,
"heapUsedBytes": 63589912,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.421999999999999,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 494.2550000000665,
"styleRecalcs": 14,
"styleRecalcDurationMs": 34.378,
"layouts": 4,
"layoutDurationMs": 1.494,
"taskDurationMs": 139.287,
"heapDeltaBytes": 4931336,
"heapUsedBytes": 65420396,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.226,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughThe binary-size validation workflow no longer runs when pull request labels change. It continues to run for opened, synchronized, and reopened pull requests. ChangesBinary size validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The workflow will no longer rerun for label changes, preventing duplicate cancelled checks while preserving runs for code changes and reopening. The label-based bypass may apply on the next code-related event instead of immediately, but it is non-gating and no actionable merge-blocking risk remains. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15418 +/- ##
==========================================
+ Coverage 78.78% 81.25% +2.47%
==========================================
Files 2210 1883 -327
Lines 116265 111362 -4903
Branches 36092 34938 -1154
==========================================
- Hits 91594 90485 -1109
+ Misses 24186 20493 -3693
+ Partials 485 384 -101
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 2 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
Panel: 8/8 reviewers contributed findings.
benjcooley
left a comment
There was a problem hiding this comment.
Approved with 1 non-blocking SHOULD FIX noted inline.
…alidation (Comfy-Org#16585) Follow-up to Comfy-Org#15418 ## Summary Restores immediate binary-size revalidation when `allow-large-binaries` is applied or removed, without letting unrelated label writes cancel an in-flight validation. ## Changes - Subscribe to `labeled` and `unlabeled` again. - Give unrelated label events unique concurrency groups and skip their job. - Keep `allow-large-binaries` events in the validation group: applying the bypass cancels/skips, removing it runs a fresh size check. Follow-up to Comfy-Org#15418 Addresses: - Comfy-Org#15418 (comment) - Comfy-Org#15418 (comment) - Comfy-Org#15418 (comment) Verification: `pnpm typecheck`; workflow YAML parse; `oxfmt --check`. No Vitest target is affected by this workflow-only change. <!-- authored-by:agent addr-drain --> Co-authored-by: Pipeline Agent <agent@pipeline.local>
The bug
.github/workflows/ci-binary-size-validation.yamlsubscribes to thelabeledandunlabeledpull_request event types:
So any label write starts a second binary-size run on the identical commit, and
cancel-in-progresskills the one already in flight. A label change cannot alter a bundle'ssize, so there is nothing for the job to re-evaluate — the second run just recomputes the same
answer and leaves a permanent
cancelledcheck run behind on the commit.Why it matters beyond wasted minutes
The cancelled check does not go away when the retry succeeds. Both check runs stay attached to
the commit, so the commit's check rollup is
FAILUREforever.The PR risk grader reads that rollup. Its reversibility axis treats a non-
SUCCESSrollup asno_green_checks_tier, which.github/risk.jsonsets to R2 — so a PR gets bumped to R2because a label bot wrote a
size:*label two seconds after CI started.The chain, end to end:
dosubot[bot]writes asize:*label seconds after the PR opens or is pushed to.labeledevent re-triggers binary-size on the same commit;cancel-in-progresscancelsthe in-flight run.
binary-size / CANCELLEDcheck run.CANCELLEDas a failing check, so the rollup is notSUCCESS, soreversibility is pinned at R2.
Measured (re-verified for this PR, 2026-08-18)
cancelledfailurecancelledand asuccessrunCancellations outrun real findings by roughly 29 to 1.
Timed to the second on three live PRs (label event → new run → prior run cancelled):
size:XSat 21:31:18Z → new run 21:31:20Z, prior run (started 21:31:17Z) cancelledsize:Lat 21:35:47Z → new run 21:35:49Z, prior run (21:35:45Z) cancelledsize:Lat 21:02:03Z → new run 21:02:06Z, prior run (21:02:01Z) cancelledA settled rollup showing the consequence. Commit
ce9ec9b4d0(#15414, abrowser_tests/-onlyPR) — rollup state
FAILUREover 85 contexts: 57SUCCESS, 26SKIPPED, and exactly onefailing-class context,
binary-size / CANCELLED. That PR carriesrisk:R2.Across the whole label population: of the 112 PRs currently carrying
risk:R2, 17 (15.2%)have a check rollup whose only failing-class context is
binary-size / CANCELLED— #14546,#15138, #15173, #15178, #15261, #15280, #15307, #15354, #15371, #15376, #15380, #15388, #15402,
#15404, #15410, #15411, #15414.
Why removing the trigger is the right fix, and not the concurrency group
Keying the concurrency group on
github.event.pull_request.head.shadoes not help: a labelwrite happens on the identical commit, so it lands in the same group and still cancels. The
re-trigger itself is what has to go.
binary-sizeis not a required check for merge — theProtectMainruleset requirestest,lint-and-format,e2e-statusandwebsite-e2e, andCLA Checkrequirescla-assistant.Trade-off, stated plainly
The
allow-large-binariesbypass is read fromgithub.event.pull_request.labels.*.nameat thejob
if:. Withlabeledremoved, applying that label no longer re-evaluates the checkinstantly — it takes effect on the next
synchronize/reopened. That costs nothing today:allow-large-binarieshas been applied to 0 PRs, ever, and the check does not gate merge, soa stale red never blocks anyone.
scripts/cicd/check-binary-size.sh:165prints "add the 'allow-large-binaries' label to the PR"on failure; that advice still works, it just lands on the next push rather than instantly. I have
deliberately not touched that file — happy to reword it in a follow-up if a reviewer wants it.
This PR demonstrates the fix on itself
pull_requestworkflow definitions are read from the PR head, so the change is already livehere. Timeline:
32194526247startsdosubot[bot]appliessize:XS, two seconds into the run — the exact patternthat cancels the run on every other PR
Result: one binary-size run on this commit, no second trigger, no cancellation,
binary-size pass 35s. Compare #15413 / #15414 / #15412 above, where the same two-second labelwrite killed the in-flight run and left a permanent
CANCELLEDon the commit.Scope
This is half the loop. The other half is grader-side:
CANCELLEDis counted as a failingcheck in
Comfy-Org/github-workflows(scripts/pr-risk/grade-pr-risk.sh), which is what turns acancelled run into an R2. That fix has not shipped and is not in this PR. So this PR removes
the largest source of the cancellations but does not fully close the loop — a binary-size run
cancelled for any other reason would still red the rollup.
No other change to the file.