Repository navigation
Conversation
S3 save/reload no longer observes VHS_VAEDecodeBatched.per_batch or VHS_VAEEncodeBatched.per_batch under VueNodes=false. Keep the Vue renderer contract.
🎭 Playwright: ✅ 1898 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.67 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 294 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T02:40:28.738Z",
"gitSha": "002cfe720fb44fcdf3c3ff8c75ab2710051fa544",
"branch": "cursor/vhs-per-batch-stale-allowlist-636f",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2046.3469999999688,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.210000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.387,
"heapDeltaBytes": -1145644,
"heapUsedBytes": 68421504,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.873000000000001,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.9809999999743,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.703999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.513,
"heapDeltaBytes": -542752,
"heapUsedBytes": 69161364,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.481,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1816.2000000000376,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.142,
"layouts": 14,
"layoutDurationMs": 4.079999999999999,
"taskDurationMs": 854.698,
"heapDeltaBytes": -7566528,
"heapUsedBytes": 62993632,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 157.773,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1886.7139999999836,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.065,
"layouts": 14,
"layoutDurationMs": 4.801,
"taskDurationMs": 934.0740000000001,
"heapDeltaBytes": 5029356,
"heapUsedBytes": 75316912,
"domNodes": -283,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 166.59799999999998,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.6049999999873,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.593,
"layouts": 6,
"layoutDurationMs": 0.915,
"taskDurationMs": 349.326,
"heapDeltaBytes": 4472780,
"heapUsedBytes": 74267164,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.496999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.195000000048,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.247,
"layouts": 6,
"layoutDurationMs": 1.3210000000000002,
"taskDurationMs": 404.288,
"heapDeltaBytes": 4792432,
"heapUsedBytes": 74806904,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.137,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 655.8679999999981,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.115999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.99299999999994,
"heapDeltaBytes": 18484804,
"heapUsedBytes": 88234292,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 155.68500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 697.7689999999939,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.253,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.48100000000005,
"heapDeltaBytes": -7448856,
"heapUsedBytes": 63108004,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 168.34500000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2054.036999999994,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.598999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.696,
"heapDeltaBytes": -12891712,
"heapUsedBytes": 87122220,
"domNodes": -266,
"jsHeapTotalBytes": -1097728,
"scriptDurationMs": 31.625000000000007,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.7700000000323,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.860999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.878,
"heapDeltaBytes": 11013092,
"heapUsedBytes": 86804060,
"domNodes": -274,
"jsHeapTotalBytes": -2183168,
"scriptDurationMs": 31.084,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2352.948999999967,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.317,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1677.2160000000001,
"heapDeltaBytes": -12788268,
"heapUsedBytes": 88848652,
"domNodes": -273,
"jsHeapTotalBytes": -1396736,
"scriptDurationMs": 837.2470000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2369.2470000000867,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.514999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1662.3229999999999,
"heapDeltaBytes": 25381300,
"heapUsedBytes": 91058248,
"domNodes": -279,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 803.778,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3459.9790000000326,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.630999999999997,
"layouts": 60,
"layoutDurationMs": 11.823000000000002,
"taskDurationMs": 1642.3099999999997,
"heapDeltaBytes": 8482160,
"heapUsedBytes": 75432048,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 748.0389999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3624.967999999967,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.879999999999999,
"layouts": 60,
"layoutDurationMs": 12.187,
"taskDurationMs": 1721.0460000000003,
"heapDeltaBytes": 8783952,
"heapUsedBytes": 75763148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 779.7570000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3094.110999999998,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.602000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1915.5069999999998,
"heapDeltaBytes": 21650732,
"heapUsedBytes": 89226340,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 963.138,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3067.1140000000605,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.572000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1946.8849999999998,
"heapDeltaBytes": 26056388,
"heapUsedBytes": 93432080,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 949.5519999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2049.297000000024,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.9239999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.955,
"heapDeltaBytes": -15319452,
"heapUsedBytes": 87515152,
"domNodes": -271,
"jsHeapTotalBytes": -1622016,
"scriptDurationMs": 39.08500000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2040.8419999999978,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.595000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.6859999999999,
"heapDeltaBytes": 21802500,
"heapUsedBytes": 87617116,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.345,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.0699999999974,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.126,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.1,
"heapDeltaBytes": 14773972,
"heapUsedBytes": 87186088,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 139.41199999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.3690000000097,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.794,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.4220000000001,
"heapDeltaBytes": 14811392,
"heapUsedBytes": 87628296,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.56999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2035.2750000000128,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.516,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.25900000000007,
"heapDeltaBytes": 4201348,
"heapUsedBytes": 76911100,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.065999999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.2140000000572,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.073000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.793,
"heapDeltaBytes": 2048792,
"heapUsedBytes": 73741772,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.259,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.4069999999851,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.679,
"layouts": 18,
"layoutDurationMs": 5.6080000000000005,
"taskDurationMs": 813.061,
"heapDeltaBytes": -11327920,
"heapUsedBytes": 61293164,
"domNodes": -296,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 109.03,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.9610000000266,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.837999999999994,
"layouts": 18,
"layoutDurationMs": 5.304,
"taskDurationMs": 847.2389999999998,
"heapDeltaBytes": -11562528,
"heapUsedBytes": 61053456,
"domNodes": -299,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 114.37,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.0749999999152,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.91000000000001,
"layouts": 15,
"layoutDurationMs": 16.423000000000002,
"taskDurationMs": 984.6170000000001,
"heapDeltaBytes": -7432116,
"heapUsedBytes": 87828000,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 31.826999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8503.683999999965,
"styleRecalcs": 245,
"styleRecalcDurationMs": 32.001000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5775.051,
"heapDeltaBytes": 8677724,
"heapUsedBytes": 84485120,
"domNodes": -273,
"jsHeapTotalBytes": -1957888,
"scriptDurationMs": 2644.326,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8689.155000000028,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.522,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5945.097,
"heapDeltaBytes": 9076092,
"heapUsedBytes": 84862008,
"domNodes": -270,
"jsHeapTotalBytes": -1433600,
"scriptDurationMs": 2670.292,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17144.11799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16687.025999999998,
"heapDeltaBytes": -26958428,
"heapUsedBytes": 175456844,
"domNodes": -6548,
"jsHeapTotalBytes": -3424256,
"scriptDurationMs": 279.405,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17199.785000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16631.801,
"heapDeltaBytes": -41358564,
"heapUsedBytes": 167766148,
"domNodes": -6548,
"jsHeapTotalBytes": 4182016,
"scriptDurationMs": 326.863,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20974.467000000004,
"styleRecalcs": 167,
"styleRecalcDurationMs": 18.63999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20688.786,
"heapDeltaBytes": -46223272,
"heapUsedBytes": 162610412,
"domNodes": -6548,
"jsHeapTotalBytes": -5988352,
"scriptDurationMs": 895.687,
"eventListeners": -7469,
"totalBlockingTimeMs": 65,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21020.352000000003,
"styleRecalcs": 165,
"styleRecalcDurationMs": 18.208999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20725.704,
"heapDeltaBytes": -21466028,
"heapUsedBytes": 166574272,
"domNodes": -6548,
"jsHeapTotalBytes": 2039808,
"scriptDurationMs": 933.0390000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 106,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6124.944999999969,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.21499999999997,
"layouts": 20,
"layoutDurationMs": 22.130999999999997,
"taskDurationMs": 6076.184999999999,
"heapDeltaBytes": -24328556,
"heapUsedBytes": 180187228,
"domNodes": -6548,
"jsHeapTotalBytes": 17506304,
"scriptDurationMs": 111.348,
"eventListeners": -7473,
"totalBlockingTimeMs": 380,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6233.500000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.08100000000002,
"layouts": 20,
"layoutDurationMs": 22.274999999999988,
"taskDurationMs": 6137.463,
"heapDeltaBytes": -29300216,
"heapUsedBytes": 175249500,
"domNodes": -6548,
"jsHeapTotalBytes": 9953280,
"scriptDurationMs": 117.35299999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 414,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 116.66699999989305,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.902,
"layouts": 2,
"layoutDurationMs": 1.314,
"taskDurationMs": 81.72800000000001,
"heapDeltaBytes": 3191308,
"heapUsedBytes": 71876996,
"domNodes": 132,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.149,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 105.54000000001906,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.411999999999997,
"layouts": 2,
"layoutDurationMs": 1.2850000000000001,
"taskDurationMs": 74.045,
"heapDeltaBytes": 3115768,
"heapUsedBytes": 71565840,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.361999999999999,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe round-trip fixtures remove VideoHelperSuite value-drift exceptions and update ChangesRound-trip value drift checks
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR updates round-trip test expectations for retired keys and equivalent value shapes without changing product behavior; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed files are available and both are under Full details: Website End-To-End Regression CoverageExplanation PASS. The PR changes only Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed files are node-related test fixtures, so the check applies. The metadata shows only removal of stale VHS value-drift allowlist entries, removal of the matching mechanism row, and a comparison change for named-object reload values. The diff adds no entity state mutation, entity method or property, ECS component behavior, extension callback change, node widget access, serialization override, or graph version update. No ADR 0003 or ADR 0008 violation is present. Full details: Description checkExplanation The description clearly explains the stale allowlist removal, the S3 roundtrip test update, review focus, evidence, and verification steps. It includes the required Summary, Changes, and Review Focus sections. The omitted Dependencies and Screenshots sections are optional when not applicable. Full details: Title checkExplanation The title accurately identifies the primary change: removing stale VHS LiteGraph per_batch allowlist keys. It is concise and specific, although it does not mention the related shared comparison update.
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
S3 reports the first renderer only. After LiteGraph was emptied, the same spec proved Vue also no longer drifts per_batch. Drop the Vue keys and the matching ROUNDTRIP_VALUE_ALLOWLIST mechanism row.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16567 +/- ##
==========================================
+ Coverage 80.66% 82.28% +1.62%
==========================================
Files 2432 2023 -409
Lines 124018 116800 -7218
Branches 33060 29528 -3532
==========================================
- Hits 100035 96107 -3928
+ Misses 23485 20516 -2969
+ Partials 498 177 -321
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
S3 stale-key throws hid that VHS reload now emits named objects with
the same values ([16] -> {per_batch:16}). Accept that shape in the
shared preserves check so retiring the per_batch keys can go green.
DrJKL
left a comment
There was a problem hiding this comment.
One correctness issue blocks this review: the shared preservation check now ignores widget names and can accept a different named widget when its value happens to match.
Fallow analyzed both changed files and passed the diff gate with no introduced dead-code, complexity, or duplication findings. Its five complexity findings were inherited. The relevant S3 custom-node test passed; the failed custom-node check was the unrelated S9 Impact-Pack model-download case.
| ? afterNormalized | ||
| : afterNormalized !== null && | ||
| typeof afterNormalized === 'object' | ||
| ? Object.values(afterNormalized) |
There was a problem hiding this comment.
[P1] Preserve widget identity, not object insertion order. Object.values() makes { wrong_name: 16 } equivalent to [16], and multi-widget objects can compare incorrectly when insertion order differs. VHS restores named values using widget.name, so the keys are part of the contract. widgets_values_named is already serialized alongside positional values; use that existing name-keyed shadow for array-to-object comparisons and fail closed when it is unavailable.
| export const ROUNDTRIP_VALUE_ALLOWED_KEYS_VUE: Record< | ||
| string, | ||
| Record<string, string> | ||
| > = {} |
There was a problem hiding this comment.
Non-blocking ponytail note: both key allowlists are now empty, leaving the key-specific ledger, bookkeeping, stale check, and tests with no configured contract. Since this PR retires the last entries, delete that machinery. It can be recovered from history if a real named-key drift appears.
|
Closing as superseded. Main already landed the same root cause:
Rebase onto current Do not merge this PR over #16676. Staying closed. Not marking ready. |
…6903) <!-- CURSOR_AGENT_PR_BODY_BEGIN --> ## Summary Cloud Playwright fails because keyboard open already shows the dock, but `#agent-panel-title` is never in the success-path DOM. The complementary landmark still points at that id. ## Evidence **Failing run:** https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33822896207 **SHA:** `9a24b373` **Job:** `playwright-tests (cloud)` — browsers=failure; sharded=success **Spec:** `browser_tests/tests/agent/agentPanelLifecycle.spec.ts:68` — `supports keyboard activation and returns one complementary landmark` What happens today (the failing spec is the proof): 1. Focus the Ask Comfy Agent button and press Enter. 2. `#docked-agent-panel` becomes visible (`toBeVisible` passed). 3. The landmark has `role="complementary"` and `aria-labelledby="agent-panel-title"` (both passed). 4. `expect(page.locator('#agent-panel-title')).toHaveCount(1)` times out at 5000ms — received 0 on the first attempt and all 3 retries. This is not a keyboard-activation failure and not a flake. Click-open in the same file also mounts the success tree; only this test asks for the title id. `#11452` (`getSlotKey`) is discarded as cause. That commit only touches `src/renderer/core/layout/slots/slotIdentifier.ts` and an eslint suppression. It does not load, label, or render the agent panel. The next merge after the lifecycle spec (`#16217`) just happened to be `#11452`. Also not `#16754` (error-overlay / in-flight execution errors). Does not reopen `#16537` or `#16567`. Does not touch `#16559` (knip). ## Root cause `DockedAgentPanel.vue:6` always sets `aria-labelledby="agent-panel-title"`. That id is only rendered on the chunk-load **error** fallback (`DockedAgentPanel.vue:48`). The success path (`AgentPanelRoot` → `AgentPanel` → `PanelHeader`) had a visible `<h1>` with `t('agent.title')` and no id. `#16198` removed the Suspense fallback that used to render `#agent-panel-title` while loading. The success heading never received the id, so after a successful open the labelledby target is missing. ## Change - **What:** `PanelHeader.vue:36` — add `id="agent-panel-title"` to the existing success-path `<h1>`. - Unit proof: `PanelHeader.test.ts` asserts the heading named "Comfy Agent" carries that id. - No e2e spec changes. No other product behavior. ## Verify (human, minutes) ``` pnpm exec playwright test browser_tests/tests/agent/agentPanelLifecycle.spec.ts --grep "supports keyboard activation" ``` Expected: after keyboard activation, `#agent-panel-title` is present (count 1); that test green. No other product behavior change. ## Review Focus The dock landmark and the visible heading must share one id on the success path. The error fallback already owns the same id and is mutually exclusive with `PanelHeader`. ## Screenshots (if applicable) N/A — a11y id wiring; no visual change. <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-bd50d3ca-5bca-4e30-a350-e95776a9b7a0?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-bd50d3ca-5bca-4e30-a350-e95776a9b7a0&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
…Comfy-Org#13957) ## ELI-5 When you generate an image through the API (or the Comfy MCP), the job never stores the editor file the canvas saves — only the machine-format graph. Drop that machine-format JSON on the canvas and it rebuilds a workflow just fine, but the asset three-dots "Open this workflow in a new tab" just said there was no workflow data. This teaches the menu the same trick the canvas already knows: no editor workflow, open the stored machine-format graph instead. Nothing is written back to the job or the asset — save it yourself if you want to keep it. ## Summary The asset menu's "Open this workflow in a new tab" now falls back to the API-format graph a job stores at `workflow.prompt` when `extra_data.extra_pnginfo.workflow` is absent, loading it through `app.loadApiJson` — the same loader the canvas uses for a dropped API-format JSON file, ending in the same `afterLoadNewGraph` new-tab handoff. ## Changes - `jobTypes.ts`: `zWorkflowContainer` also parses `prompt` (it was previously stripped). - `fetchJobs.ts`: `extractApiPrompt()` — returns the stored API graph **only** when no editor workflow is embedded. An embedded workflow always suppresses the fallback, so frontend/desktop submissions are used as-is and never re-derived (this holds even when that embedded workflow fails validation, which is deliberate — presence, not validity, is the switch). - `jobOutputCache.ts` / `workflowExtractionUtil.ts`: `getJobApiPrompt()` / `extractApiPromptFromAsset()`, reusing the same LRU-cached job detail, so the fallback costs no extra request. - `useMediaAssetActions.ts`: single-asset `openWorkflow` and bulk `openMultipleWorkflows` both go through one `openAssetWorkflow` helper that uses the fallback when extraction yields no workflow, gated by `app.isApiJson`. The fallback returns the same `{ success, error }` shape as `openWorkflowAction`, with the prompt fetch and the load inside one try/catch, so a failure at either step degrades to the warning toast with the underlying message rather than escaping as an unhandled rejection. - `app.ts`: the canvas drop path's `await this.loadApiJson(...)` gets its own `try`/`catch`, reporting through `showErrorOnFileLoad`. Previously a failed load fell into `handleFile`'s prompt-parse `catch` and continued on to the A1111-parameters fallback, surfacing a misleading parse error instead of the real one. - `assetSchema.ts`: `zAsset` accepts a `null` `user_metadata` and normalizes it to `undefined`. The generated ingest shape is `.optional()`, which rejects an explicit `null` outright — so an asset whose payload carried one failed `safeParse` and was dropped entirely rather than reaching the metadata guard. The fallback engages only on the branch that previously always failed, so no existing behavior changes. One incidental improvement: that branch's toast now shows the translated `mediaAsset.noWorkflowDataFound` instead of the raw English `'No workflow data available'` that leaked out of `openWorkflowAction`. ## Deviation from the plan — please read The plan for this called for converting the stored graph with the extracted `@comfyorg/api-to-workflow` package and feeding the result to `loadGraphData`. **That package is not consumable from this repo today**, verified rather than assumed: - `npm view @comfyorg/api-to-workflow` → `E404`, while `npm view @comfyorg/comfyui-electron-types version` → `0.7.0` from the same registry and scope, so this is a genuine absence, not a registry/auth artifact. - Its source repo is **private**, and the package directory there holds only `README`/`package.json`/`tsconfig` — it compiles from that repo's own `src/converter`. So a git dependency is not an option either: this repo is public and every contributor's `pnpm install` and CI would fail. So this ships the fallback through the converter the frontend **already has** and already ships in the drop path, which is also what the plan named as the behavioral target ("same downstream behavior as the chunk path" — `handleFile` prefers the `workflow` chunk and falls back to the `prompt` chunk via `loadApiJson`). No second copy of any converter is introduced. When the package is published, swapping `openApiPromptAsWorkflow` to convert-then-`loadGraphData` is a contained change, and it would also be the moment to retire `app.loadApiJson`'s in-place path for the drop path too. ## Deliberately not in scope - **Export workflow** still reports no workflow for these assets. Export needs a serialized workflow document, which `loadApiJson` cannot produce without mutating the user's open graph. That wants the pure converter, so it is left for the package. - The **queue** job menu is a separate call path and untouched. ## Overlap to be aware of Open draft Comfy-Org#10929 (@guill, last updated May) does the same fallback for the **queue** menu in `useJobMenu.ts` and touches `fetchJobs.ts` / `jobTypes.ts` / `jobOutputCache.ts` too, so the two will conflict textually. Neither supersedes the other on behavior — that PR covers the queue menu, this covers the asset menu. Whichever lands second should rebase onto the first and reuse its `prompt` plumbing rather than duplicating it. I have not touched Comfy-Org#10929. ## Merge with `main` Merged `main` in. One textual conflict (an import block in `jobOutputCache.test.ts`, both sides kept) and one semantic one that no conflict marker would have shown: Comfy-Org#15381 changed `isOutputAssetMetadata` to require `subfolder` rather than `nodeId`, so this PR's `'missing nodeId'` negative case (`{ jobId, subfolder }`) is now *valid* output metadata and the fallback correctly fires for it. That row is realigned to `'missing subfolder'`, which is what the current guard actually rejects. No production code changed for this — the guard is shared with `extractWorkflowFromAsset`, which already followed `main`. Merged `main` a second time (`27f79c4d42`) to pick up Comfy-Org#16577, which temporarily disables the automatic custom-node suites. Those two `custom_nodes_e2e` shards were the branch's only red checks and their failure came from `main`, not this diff — a stale `ROUNDTRIP_VALUE_ALLOWED_KEYS` allowance for VHS `per_batch` that Comfy-Org#15381 made obsolete (analysis in the comment thread; the real ledger fix is Comfy-Org#16567). Clean merge, no conflicts. ## Review Focus - The synthesized graph has invented layout and no groups/reroutes; that is inherent to API format and accepted here. - `extractApiPrompt` returns `unknown` on purpose: the canonical format check is `app.isApiJson`, a type guard, and importing `app` into the remote layer to use it there would invert the layering. ## Provenance - **Authored by:** agent-work loop - **Verified:** re-verified on the merged tree at `27f79c4d42`: `pnpm vitest run` over the five touched suites plus `src/platform/assets` — 55 files, 931 passed, 1 skipped, 0 failed; `pnpm typecheck`, `pnpm format:check` and `eslint` on the changed files all clean (only the pre-existing `apiSchema is deprecated` warnings on imports this PR did not add). `pnpm test:unit` on the previous head — 1455/1457 files pass; the two failures (`scripts/cicd/check-binary-size.test.ts`, `useFreeTierQuota.test.ts`) reproduce identically on unmodified `origin/main` and are a local Node 24 vs required >=25 artifact, not this branch. Merges clean with `main` (`mergeable: MERGEABLE`); no merge-queue run has ever been ejected for this PR. - **Deviations:** the planned `@comfyorg/api-to-workflow` conversion path was not used — see "Deviation from the plan" above for the evidence. Still unverified end to end: no run against a live API-submitted cloud job, so the assertion that these jobs populate `workflow.prompt` and omit `extra_pnginfo.workflow` rests on the plan and Comfy-Org#10929's manual repro rather than a first-hand reproduction. CodeRabbit's transactional-`loadApiJson` finding is deferred rather than fixed here — pre-existing across `loadGraphData` / `importA1111` too, and a design call; recorded as a follow-up (rationale on the resolved thread). --------- Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Summary
S3 save/reload on main no longer observes VHS
per_batchvalue drift. The shared allowlist still listed those keys, so the surviving spec failed closed.Same fail again on
d47f0c26after #16359:This PR stays the vehicle for that contract. No second PR.
Standing status
Draft. Do not mark ready. Do not auto-merge. Do not convert to ready unless ShihChi explicitly says mark ready.
Changes
VHS_VAEDecodeBatched.per_batchandVHS_VAEEncodeBatched.per_batchfromROUNDTRIP_VALUE_ALLOWED_KEYS_LITEGRAPH,ROUNDTRIP_VALUE_ALLOWED_KEYS_VUE, andROUNDTRIP_VALUE_ALLOWLIST.preserveson this branch also accepts array → named-object when values match.Later main landings (do not merge this PR as-is)
While this draft was open, main received the same root-cause work:
widgets_valuesby name when only the container shape changes (serializer-aligned names)Rebasing this branch onto current
origin/mainleaves no unique allowlist diff. The remainingpreserveshunk here is weaker than #16676 (Object.valuesvs named keys +serialize: falsealignment) and would regress that fix. Left un-rebased so this draft keeps the original characterization; do not merge it over #16676.Evidence
Main fail after #15381 (
93f2d927): https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33578231033Main fail after #16359 (
d47f0c26): same stale keys (VHS_VAEDecodeBatched.per_batch,VHS_VAEEncodeBatched.per_batch,VueNodes=false)browser_tests/tests/customNodes/allNodes.spec.ts(S3: enrolled registered-node save/reload outcomes match exact contracts)browser_tests/fixtures/customNode/valueDrift.ts:35-43browser_tests/fixtures/customNode/allNodesRoundtripTier.ts:884-887Verify
Expected: that S3 case green for ComfyUI-VideoHelperSuite; no other product behavior change.
Does not reopen #16537. Auto-merge stays off.