Skip to content

test: drop stale VHS LiteGraph per_batch allowlist keys - #16567

Closed
huang47 wants to merge 3 commits into
mainfrom
cursor/vhs-per-batch-stale-allowlist-636f
Closed

huang47 wants to merge 3 commits into
mainfrom
cursor/vhs-per-batch-stale-allowlist-636f

Conversation

@huang47

@huang47 huang47 commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

S3 save/reload on main no longer observes VHS per_batch value drift. The shared allowlist still listed those keys, so the surviving spec failed closed.

Same fail again on d47f0c26 after #16359:

stale ROUNDTRIP_VALUE_ALLOWED_KEYS entries with VueNodes=false: VHS_VAEDecodeBatched.per_batch, VHS_VAEEncodeBatched.per_batch

This PR stays the vehicle for that contract. No second PR.

Standing status

Draft. Do not mark ready. Do not auto-merge. Do not convert to ready unless ShihChi explicitly says mark ready.

Changes

  • What:
    • Retire VHS_VAEDecodeBatched.per_batch and VHS_VAEEncodeBatched.per_batch from ROUNDTRIP_VALUE_ALLOWED_KEYS_LITEGRAPH, ROUNDTRIP_VALUE_ALLOWED_KEYS_VUE, and ROUNDTRIP_VALUE_ALLOWLIST.
    • S3 preserves on this branch also accepts array → named-object when values match.
  • Breaking: none

Later main landings (do not merge this PR as-is)

While this draft was open, main received the same root-cause work:

Rebasing this branch onto current origin/main leaves no unique allowlist diff. The remaining preserves hunk here is weaker than #16676 (Object.values vs named keys + serialize: false alignment) and would regress that fix. Left un-rebased so this draft keeps the original characterization; do not merge it over #16676.

Evidence

Main fail after #15381 (93f2d927): https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33578231033

Main fail after #16359 (d47f0c26): same stale keys (VHS_VAEDecodeBatched.per_batch, VHS_VAEEncodeBatched.per_batch, VueNodes=false)

  • Surviving spec: browser_tests/tests/customNodes/allNodes.spec.ts (S3: enrolled registered-node save/reload outcomes match exact contracts)
  • Allowlist change: browser_tests/fixtures/customNode/valueDrift.ts:35-43
  • Stale-key assertion: browser_tests/fixtures/customNode/allNodesRoundtripTier.ts:884-887

Verify

pnpm exec playwright test browser_tests/tests/customNodes/allNodes.spec.ts \
  --config playwright.chrome.config.ts \
  --grep "S3: enrolled registered-node save/reload"

Expected: that S3 case green for ComfyUI-VideoHelperSuite; no other product behavior change.

Does not reopen #16537. Auto-merge stays off.

Open in Web Open in Cursor 

S3 save/reload no longer observes VHS_VAEDecodeBatched.per_batch or
VHS_VAEEncodeBatched.per_batch under VueNodes=false. Keep the Vue
renderer contract.
@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1898 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1877 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 9.67 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 41 MB baseline 41 MB — ⚪ 0 B
  • Gzip: 9.67 MB baseline 9.67 MB — ⚪ 0 B
  • Brotli: 6.8 MB baseline 6.8 MB — ⚪ 0 B
  • Bundles: 447 current • 447 baseline

Category Glance
Vendor & Third-Party ⚪ 0 B (18.1 MB) · Other ⚪ 0 B (16.4 MB) · Data & Services ⚪ 0 B (3.59 MB) · Graph Workspace ⚪ 0 B (1.4 MB) · Panels & Settings ⚪ 0 B (621 kB) · Utilities & Hooks ⚪ 0 B (555 kB) · + 5 more

App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 27 unchanged

User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 117 kB (baseline 117 kB) • ⚪ 0 B

Reusable component library chunks

Status: 15 unchanged

Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 36 unchanged

Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 294 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 136ms TBT · 83.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 163.7 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 86ms TBT · 157.0 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 397ms TBT · 169.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap

⚠️ 12 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 569ms 555ms -2% ⚠️ z=5.2
canvas-mouse-sweep: layout duration 5ms 4ms -5% ⚠️ z=4.2
canvas-mouse-sweep: script duration 159ms 162ms +2% ⚠️ z=4.1
canvas-zoom-sweep: layout duration 1ms 1ms +1% ⚠️ z=10.5
canvas-zoom-sweep: task duration 414ms 377ms -9% ⚠️ z=2.2
dom-widget-clipping: task duration 469ms 455ms -3% ⚠️ z=5.5
dom-widget-clipping: script duration 159ms 162ms +2% ⚠️ z=29.0
large-graph-pan: task duration 1692ms 1670ms -1% ⚠️ z=13.7
large-graph-pan: script duration 787ms 821ms +4% ⚠️ z=20.8
subgraph-dom-widget-clipping: script duration 149ms 141ms -5% ⚠️ z=2.1
subgraph-idle: task duration 538ms 501ms -7% ⚠️ z=4.2
subgraph-mouse-sweep: layout duration 6ms 5ms -9% ⚠️ z=2.4
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms -0% z=-0.5
canvas-idle: p95 frame time 17ms 17ms -1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 8ms 8ms +10% z=-2.7
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 8 9 +6% z=-4.7
canvas-idle: task duration 569ms 555ms -2% ⚠️ z=5.2
canvas-idle: script duration 11ms 9ms -16% z=-7.2
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 55.6 MB 65.6 MB +18% —
canvas-idle: DOM nodes -281 -282 +0% z=-238.4
canvas-idle: event listeners -155 -186 +20% z=-41.7
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-1.5
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 5ms 4ms -5% ⚠️ z=4.2
canvas-mouse-sweep: style recalc duration 40ms 39ms -4% z=-1.3
canvas-mouse-sweep: layout count 14 14 +0% —
canvas-mouse-sweep: style recalc count 76 76 -1% z=-1.4
canvas-mouse-sweep: task duration 949ms 894ms -6% z=0.5
canvas-mouse-sweep: script duration 159ms 162ms +2% ⚠️ z=4.1
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 73.0 MB 66.0 MB -10% —
canvas-mouse-sweep: DOM nodes -281 -282 +0% z=-133.1
canvas-mouse-sweep: event listeners -187 -170 -9% z=-42.8
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-0.3
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms +1% ⚠️ z=10.5
canvas-zoom-sweep: style recalc duration 19ms 19ms -1% z=-0.1
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 32 +3% z=1.6
canvas-zoom-sweep: task duration 414ms 377ms -9% ⚠️ z=2.2
canvas-zoom-sweep: script duration 14ms 12ms -12% z=-4.9
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 71.8 MB 71.1 MB -1% —
canvas-zoom-sweep: DOM nodes 77 78 +1% z=-2.2
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms -1% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 8ms 8ms +5% z=-2.1
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 11 12 +5% z=-3.2
dom-widget-clipping: task duration 469ms 455ms -3% ⚠️ z=5.5
dom-widget-clipping: script duration 159ms 162ms +2% ⚠️ z=29.0
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 60.0 MB 72.2 MB +20% —
dom-widget-clipping: DOM nodes 18 19 +6% z=-2.2
dom-widget-clipping: event listeners 2 1 -50% variance too high
large-graph-idle: avg frame time 17ms 17ms -0% z=-0.6
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 3ms 4ms +32% z=-8.1
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 3 5 +50% z=-22.6
large-graph-idle: task duration 683ms 591ms -13% z=0.9
large-graph-idle: script duration 42ms 31ms -25% z=-6.8
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 83.2 MB 82.9 MB -0% —
large-graph-idle: DOM nodes -274 -270 -1% z=-326.0
large-graph-idle: event listeners -153 -169 +10% z=-32.0
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 10ms 10ms -3% z=-9.2
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 63 65 +3% z=-7.1
large-graph-pan: task duration 1692ms 1670ms -1% ⚠️ z=13.7
large-graph-pan: script duration 787ms 821ms +4% ⚠️ z=20.8
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 80.1 MB 85.8 MB +7% —
large-graph-pan: DOM nodes -11 -276 +2409% z=-178.8
large-graph-pan: event listeners 6 -168 -2900% z=-208.8
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 14ms 12ms -14% —
large-graph-zoom: style recalc duration 11ms 10ms -14% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 60 60 +0% —
large-graph-zoom: task duration 1786ms 1682ms -6% —
large-graph-zoom: script duration 784ms 764ms -3% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 72.3 MB 72.1 MB -0% —
large-graph-zoom: DOM nodes 0 0 +0% —
large-graph-zoom: event listeners 8 10 +25% —
legacy-node-drag: avg frame time 17ms 17ms -0% —
legacy-node-drag: p95 frame time 17ms 17ms -0% —
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 6ms 5ms -8% —
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 40 41 +1% —
legacy-node-drag: task duration 2003ms 1931ms -4% —
legacy-node-drag: script duration 1001ms 956ms -4% —
legacy-node-drag: TBT 0ms 0ms +0% —
legacy-node-drag: heap used 85.4 MB 87.1 MB +2% —
legacy-node-drag: DOM nodes 0 1 — —
legacy-node-drag: event listeners 188 188 +0% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms +0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 1ms 3ms +212% z=-7.7
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 1 4 +250% z=-8.9
minimap-idle: task duration 641ms 590ms -8% z=1.3
minimap-idle: script duration 37ms 37ms +0% z=-6.2
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 83.0 MB 83.5 MB +1% —
minimap-idle: DOM nodes -274 -270 -1% z=-211.4
minimap-idle: event listeners -155 -154 -1% z=-240.2
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.7
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 12ms 10ms -9% z=-2.4
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 46 47 +1% z=-2.5
subgraph-dom-widget-clipping: task duration 442ms 410ms -7% z=1.7
subgraph-dom-widget-clipping: script duration 149ms 141ms -5% ⚠️ z=2.1
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 83.2 MB 83.4 MB +0% —
subgraph-dom-widget-clipping: DOM nodes 18 19 +6% z=-2.8
subgraph-dom-widget-clipping: event listeners 6 7 +17% z=-1.6
subgraph-idle: avg frame time 17ms 17ms -0% z=-0.7
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 9ms 8ms -3% z=-2.7
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 9 10 +6% z=-2.1
subgraph-idle: task duration 538ms 501ms -7% ⚠️ z=4.2
subgraph-idle: script duration 10ms 9ms -14% z=-4.3
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 62.0 MB 71.8 MB +16% —
subgraph-idle: DOM nodes -297 -296 -0% z=-212.6
subgraph-idle: event listeners -199 -231 +16% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.1
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% —
subgraph-mouse-sweep: layout duration 6ms 5ms -9% ⚠️ z=2.4
subgraph-mouse-sweep: style recalc duration 40ms 37ms -6% z=-1.6
subgraph-mouse-sweep: layout count 18 18 +0% —
subgraph-mouse-sweep: style recalc count 77 78 +1% z=-1.4
subgraph-mouse-sweep: task duration 859ms 830ms -3% z=0.9
subgraph-mouse-sweep: script duration 110ms 112ms +2% z=1.7
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 59.0 MB 58.3 MB -1% —
subgraph-mouse-sweep: DOM nodes -295 -298 +1% z=-163.1
subgraph-mouse-sweep: event listeners -201 -200 -0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +0% —
subgraph-transition-enter: layout duration 15ms 16ms +11% —
subgraph-transition-enter: style recalc duration 32ms 33ms +2% —
subgraph-transition-enter: layout count 15 15 +0% —
subgraph-transition-enter: style recalc count 19 19 +0% —
subgraph-transition-enter: task duration 1010ms 985ms -3% —
subgraph-transition-enter: script duration 33ms 32ms -3% —
subgraph-transition-enter: TBT 129ms 136ms +5% —
subgraph-transition-enter: heap used 78.4 MB 83.8 MB +7% —
subgraph-transition-enter: DOM nodes 13751 13751 +0% —
subgraph-transition-enter: event listeners 2381 2383 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 41ms 34ms -18% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 248 247 -1% —
viewport-pan-sweep: task duration 5883ms 5860ms -0% —
viewport-pan-sweep: script duration 2606ms 2657ms +2% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 84.1 MB 80.8 MB -4% —
viewport-pan-sweep: DOM nodes -267 -272 +2% —
viewport-pan-sweep: event listeners -169 -168 -1% —
vue-large-graph-idle: avg frame time 18ms 18ms -3% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 17767ms 16659ms -6% —
vue-large-graph-idle: script duration 328ms 303ms -8% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 167.4 MB 163.7 MB -2% —
vue-large-graph-idle: DOM nodes -6548 -6548 +0% —
vue-large-graph-idle: event listeners -7475 -7474 -0% —
vue-large-graph-pan: avg frame time 18ms 18ms +0% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 23ms 18ms -20% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 169 166 -2% —
vue-large-graph-pan: task duration 22330ms 20707ms -7% —
vue-large-graph-pan: script duration 969ms 914ms -6% —
vue-large-graph-pan: TBT 206ms 86ms -58% —
vue-large-graph-pan: heap used 171.8 MB 157.0 MB -9% —
vue-large-graph-pan: DOM nodes -6548 -6548 +0% —
vue-large-graph-pan: event listeners -7469 -7469 +0% —
vue-node-resize-workload: avg frame time 18ms 18ms -0% —
vue-node-resize-workload: p95 frame time 17ms 17ms -0% —
vue-node-resize-workload: layout duration 26ms 22ms -14% —
vue-node-resize-workload: style recalc duration 76ms 79ms +3% —
vue-node-resize-workload: layout count 20 20 +0% —
vue-node-resize-workload: style recalc count 20 20 +0% —
vue-node-resize-workload: task duration 6535ms 6107ms -7% —
vue-node-resize-workload: script duration 120ms 114ms -5% —
vue-node-resize-workload: TBT 488ms 397ms -19% —
vue-node-resize-workload: heap used 171.9 MB 169.5 MB -1% —
vue-node-resize-workload: DOM nodes -6548 -6548 +0% —
vue-node-resize-workload: event listeners -7469 -7472 +0% —
workflow-execution: avg frame time 17ms 17ms -0% z=0.1
workflow-execution: p95 frame time 17ms 17ms -0% —
workflow-execution: layout duration 2ms 1ms -21% z=-1.7
workflow-execution: style recalc duration 23ms 14ms -39% z=-4.6
workflow-execution: layout count 3 2 -33% z=-5.4
workflow-execution: style recalc count 9 7 -22% z=-5.3
workflow-execution: task duration 109ms 78ms -28% z=-4.2
workflow-execution: script duration 7ms 7ms -1% z=-7.4
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 68.3 MB 68.4 MB +0% —
workflow-execution: DOM nodes 128 129 +0% z=-4.5
workflow-execution: event listeners 49 25 -49% z=-6.1
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-09-02T02:40:28.738Z",
  "gitSha": "002cfe720fb44fcdf3c3ff8c75ab2710051fa544",
  "branch": "cursor/vhs-per-batch-stale-allowlist-636f",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2046.3469999999688,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.210000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 564.387,
      "heapDeltaBytes": -1145644,
      "heapUsedBytes": 68421504,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.873000000000001,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2055.9809999999743,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.703999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 546.513,
      "heapDeltaBytes": -542752,
      "heapUsedBytes": 69161364,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 10.481,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1816.2000000000376,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 36.142,
      "layouts": 14,
      "layoutDurationMs": 4.079999999999999,
      "taskDurationMs": 854.698,
      "heapDeltaBytes": -7566528,
      "heapUsedBytes": 62993632,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 157.773,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1886.7139999999836,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 41.065,
      "layouts": 14,
      "layoutDurationMs": 4.801,
      "taskDurationMs": 934.0740000000001,
      "heapDeltaBytes": 5029356,
      "heapUsedBytes": 75316912,
      "domNodes": -283,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 166.59799999999998,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.6049999999873,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.593,
      "layouts": 6,
      "layoutDurationMs": 0.915,
      "taskDurationMs": 349.326,
      "heapDeltaBytes": 4472780,
      "heapUsedBytes": 74267164,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.496999999999996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.195000000048,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 20.247,
      "layouts": 6,
      "layoutDurationMs": 1.3210000000000002,
      "taskDurationMs": 404.288,
      "heapDeltaBytes": 4792432,
      "heapUsedBytes": 74806904,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 14.137,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 655.8679999999981,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.115999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.99299999999994,
      "heapDeltaBytes": 18484804,
      "heapUsedBytes": 88234292,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 155.68500000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 697.7689999999939,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.253,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.48100000000005,
      "heapDeltaBytes": -7448856,
      "heapUsedBytes": 63108004,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 168.34500000000003,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.036999999994,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.598999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 593.696,
      "heapDeltaBytes": -12891712,
      "heapUsedBytes": 87122220,
      "domNodes": -266,
      "jsHeapTotalBytes": -1097728,
      "scriptDurationMs": 31.625000000000007,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.7700000000323,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.860999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.878,
      "heapDeltaBytes": 11013092,
      "heapUsedBytes": 86804060,
      "domNodes": -274,
      "jsHeapTotalBytes": -2183168,
      "scriptDurationMs": 31.084,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2352.948999999967,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.317,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1677.2160000000001,
      "heapDeltaBytes": -12788268,
      "heapUsedBytes": 88848652,
      "domNodes": -273,
      "jsHeapTotalBytes": -1396736,
      "scriptDurationMs": 837.2470000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2369.2470000000867,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.514999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1662.3229999999999,
      "heapDeltaBytes": 25381300,
      "heapUsedBytes": 91058248,
      "domNodes": -279,
      "jsHeapTotalBytes": 1011712,
      "scriptDurationMs": 803.778,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3459.9790000000326,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.630999999999997,
      "layouts": 60,
      "layoutDurationMs": 11.823000000000002,
      "taskDurationMs": 1642.3099999999997,
      "heapDeltaBytes": 8482160,
      "heapUsedBytes": 75432048,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 748.0389999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3624.967999999967,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.879999999999999,
      "layouts": 60,
      "layoutDurationMs": 12.187,
      "taskDurationMs": 1721.0460000000003,
      "heapDeltaBytes": 8783952,
      "heapUsedBytes": 75763148,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 779.7570000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3094.110999999998,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.602000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1915.5069999999998,
      "heapDeltaBytes": 21650732,
      "heapUsedBytes": 89226340,
      "domNodes": 0,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 963.138,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3067.1140000000605,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.572000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1946.8849999999998,
      "heapDeltaBytes": 26056388,
      "heapUsedBytes": 93432080,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 949.5519999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2049.297000000024,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.9239999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 596.955,
      "heapDeltaBytes": -15319452,
      "heapUsedBytes": 87515152,
      "domNodes": -271,
      "jsHeapTotalBytes": -1622016,
      "scriptDurationMs": 39.08500000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2040.8419999999978,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.595000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 583.6859999999999,
      "heapDeltaBytes": 21802500,
      "heapUsedBytes": 87617116,
      "domNodes": -269,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.345,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 596.0699999999974,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.126,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.1,
      "heapDeltaBytes": 14773972,
      "heapUsedBytes": 87186088,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 139.41199999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 590.3690000000097,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.794,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.4220000000001,
      "heapDeltaBytes": 14811392,
      "heapUsedBytes": 87628296,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 143.56999999999996,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2035.2750000000128,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.516,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.25900000000007,
      "heapDeltaBytes": 4201348,
      "heapUsedBytes": 76911100,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.065999999999999,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.2140000000572,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.073000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 516.793,
      "heapDeltaBytes": 2048792,
      "heapUsedBytes": 73741772,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.259,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000007,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1724.4069999999851,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 37.679,
      "layouts": 18,
      "layoutDurationMs": 5.6080000000000005,
      "taskDurationMs": 813.061,
      "heapDeltaBytes": -11327920,
      "heapUsedBytes": 61293164,
      "domNodes": -296,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 109.03,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1728.9610000000266,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 36.837999999999994,
      "layouts": 18,
      "layoutDurationMs": 5.304,
      "taskDurationMs": 847.2389999999998,
      "heapDeltaBytes": -11562528,
      "heapUsedBytes": 61053456,
      "domNodes": -299,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 114.37,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1385.0749999999152,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.91000000000001,
      "layouts": 15,
      "layoutDurationMs": 16.423000000000002,
      "taskDurationMs": 984.6170000000001,
      "heapDeltaBytes": -7432116,
      "heapUsedBytes": 87828000,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 31.826999999999995,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 136,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8503.683999999965,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 32.001000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5775.051,
      "heapDeltaBytes": 8677724,
      "heapUsedBytes": 84485120,
      "domNodes": -273,
      "jsHeapTotalBytes": -1957888,
      "scriptDurationMs": 2644.326,
      "eventListeners": -169,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8689.155000000028,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.522,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5945.097,
      "heapDeltaBytes": 9076092,
      "heapUsedBytes": 84862008,
      "domNodes": -270,
      "jsHeapTotalBytes": -1433600,
      "scriptDurationMs": 2670.292,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17144.11799999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16687.025999999998,
      "heapDeltaBytes": -26958428,
      "heapUsedBytes": 175456844,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3424256,
      "scriptDurationMs": 279.405,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17199.785000000018,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16631.801,
      "heapDeltaBytes": -41358564,
      "heapUsedBytes": 167766148,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4182016,
      "scriptDurationMs": 326.863,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20974.467000000004,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 18.63999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20688.786,
      "heapDeltaBytes": -46223272,
      "heapUsedBytes": 162610412,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5988352,
      "scriptDurationMs": 895.687,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 65,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21020.352000000003,
      "styleRecalcs": 165,
      "styleRecalcDurationMs": 18.208999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20725.704,
      "heapDeltaBytes": -21466028,
      "heapUsedBytes": 166574272,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2039808,
      "scriptDurationMs": 933.0390000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 106,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6124.944999999969,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.21499999999997,
      "layouts": 20,
      "layoutDurationMs": 22.130999999999997,
      "taskDurationMs": 6076.184999999999,
      "heapDeltaBytes": -24328556,
      "heapUsedBytes": 180187228,
      "domNodes": -6548,
      "jsHeapTotalBytes": 17506304,
      "scriptDurationMs": 111.348,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 380,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6233.500000000049,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.08100000000002,
      "layouts": 20,
      "layoutDurationMs": 22.274999999999988,
      "taskDurationMs": 6137.463,
      "heapDeltaBytes": -29300216,
      "heapUsedBytes": 175249500,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9953280,
      "scriptDurationMs": 117.35299999999998,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 414,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 116.66699999989305,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.902,
      "layouts": 2,
      "layoutDurationMs": 1.314,
      "taskDurationMs": 81.72800000000001,
      "heapDeltaBytes": 3191308,
      "heapUsedBytes": 71876996,
      "domNodes": 132,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.149,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 105.54000000001906,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 12.411999999999997,
      "layouts": 2,
      "layoutDurationMs": 1.2850000000000001,
      "taskDurationMs": 74.045,
      "heapDeltaBytes": 3115768,
      "heapUsedBytes": 71565840,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.361999999999999,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48020 70676 67.9% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.6% 250
src/scripts/pnginfo.ts 21.4% 221
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: f654b101-c8b2-4784-b44a-4780196144bb

📥 Commits

Reviewing files that changed from the base of the PR and between 410078e and dd742a3.

📒 Files selected for processing (1)
  • browser_tests/fixtures/customNode/allNodesRoundtripTier.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The round-trip fixtures remove VideoHelperSuite value-drift exceptions and update preserves to compare array elements with object values when the configured result is object-shaped.

Changes

Round-trip value drift checks

Layer / File(s) Summary
Remove VideoHelperSuite exceptions
browser_tests/fixtures/customNode/valueDrift.ts, browser_tests/fixtures/customNode/allNodesRoundtripTier.ts
The LiteGraph and Vue allowed-key maps are now empty typed records. The round-trip tier no longer allowlists per_batch drift for the two VideoHelperSuite nodes.
Compare array values
browser_tests/fixtures/customNode/allNodesRoundtripTier.ts
preserves now compares before-array elements with Object.values(after) when after is a non-null object.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to dd742

This PR updates round-trip test expectations for retired keys and equivalent value shapes without changing product behavior; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: benjcooley


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The changed files are available and both are under browser_tests/, and the PR description explains the S3 regression-test coverage. However, the PR title and actual commit subjects are not available… Provide the PR title and commit subjects, then re-evaluate whether either contains bug-fix language such as fix, fixed, fixes, fixing, bugfix, or hotfix.
✅ Passed checks (6 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Website End-To-End Regression Coverage ✅ Passed PASS. The PR changes only browser_tests/fixtures/customNode/valueDrift.ts and browser_tests/fixtures/customNode/allNodesRoundtripTier.ts. It does not change files under apps/website/src/ or `app…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are node-related test fixtures, so the check applies. The metadata shows only removal of stale VHS value-drift allowlist entries, removal of the matching mechanism row, and a compari…
Description check ✅ Passed The description clearly explains the stale allowlist removal, the S3 roundtrip test update, review focus, evidence, and verification steps. It includes the required Summary, Changes, and Review Focus …
Title check ✅ Passed The title accurately identifies the primary change: removing stale VHS LiteGraph per_batch allowlist keys. It is concise and specific, although it does not mention the related shared comparison update…
Full details: End-To-End Regression Coverage For Fixes

Explanation

The changed files are available and both are under browser_tests/, and the PR description explains the S3 regression-test coverage. However, the PR title and actual commit subjects are not available in the review context. The custom check requires those fields to evaluate the bug-fix signal, so the result cannot be determined without guessing.

Full details: Website End-To-End Regression Coverage

Explanation

PASS. The PR changes only browser_tests/fixtures/customNode/valueDrift.ts and browser_tests/fixtures/customNode/allNodesRoundtripTier.ts. It does not change files under apps/website/src/ or apps/website/public/, so this website-specific check does not apply.

Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

The changed files are node-related test fixtures, so the check applies. The metadata shows only removal of stale VHS value-drift allowlist entries, removal of the matching mechanism row, and a comparison change for named-object reload values. The diff adds no entity state mutation, entity method or property, ECS component behavior, extension callback change, node widget access, serialization override, or graph version update. No ADR 0003 or ADR 0008 violation is present.

Full details: Description check

Explanation

The description clearly explains the stale allowlist removal, the S3 roundtrip test update, review focus, evidence, and verification steps. It includes the required Summary, Changes, and Review Focus sections. The omitted Dependencies and Screenshots sections are optional when not applicable.

Full details: Title check

Explanation

The title accurately identifies the primary change: removing stale VHS LiteGraph per_batch allowlist keys. It is concise and specific, although it does not mention the related shared comparison update.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/vhs-per-batch-stale-allowlist-636f

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 2, 2026
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
S3 reports the first renderer only. After LiteGraph was emptied, the
same spec proved Vue also no longer drifts per_batch. Drop the Vue
keys and the matching ROUNDTRIP_VALUE_ALLOWLIST mechanism row.
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #16567      +/-   ##
==========================================
+ Coverage   80.66%   82.28%   +1.62%     
==========================================
  Files        2432     2023     -409     
  Lines      124018   116800    -7218     
  Branches    33060    29528    -3532     
==========================================
- Hits       100035    96107    -3928     
+ Misses      23485    20516    -2969     
+ Partials      498      177     -321     
Flag Coverage Δ
e2e 67.94% <ø> (-0.04%) ⬇️
unit 76.58% <ø> (+0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 424 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 2, 2026
S3 stale-key throws hid that VHS reload now emits named objects with
the same values ([16] -> {per_batch:16}). Accept that shape in the
shared preserves check so retiring the per_batch keys can go green.
@huang47
huang47 marked this pull request as ready for review September 2, 2026 02:43
@huang47
huang47 requested a review from a team September 2, 2026 02:43

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One correctness issue blocks this review: the shared preservation check now ignores widget names and can accept a different named widget when its value happens to match.

Fallow analyzed both changed files and passed the diff gate with no introduced dead-code, complexity, or duplication findings. Its five complexity findings were inherited. The relevant S3 custom-node test passed; the failed custom-node check was the unrelated S9 Impact-Pack model-download case.

? afterNormalized
: afterNormalized !== null &&
typeof afterNormalized === 'object'
? Object.values(afterNormalized)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Preserve widget identity, not object insertion order. Object.values() makes { wrong_name: 16 } equivalent to [16], and multi-widget objects can compare incorrectly when insertion order differs. VHS restores named values using widget.name, so the keys are part of the contract. widgets_values_named is already serialized alongside positional values; use that existing name-keyed shadow for array-to-object comparisons and fail closed when it is unavailable.

export const ROUNDTRIP_VALUE_ALLOWED_KEYS_VUE: Record<
string,
Record<string, string>
> = {}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking ponytail note: both key allowlists are now empty, leaving the key-specific ledger, bookkeeping, stale check, and tests with no configured contract. Since this PR retires the last entries, delete that machinery. It can be recovered from history if a real named-key drift appears.

@huang47
huang47 marked this pull request as draft September 2, 2026 04:57
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@huang47

huang47 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Closing as superseded.

Main already landed the same root cause:

Rebase onto current origin/main leaves no unique allowlist diff. The leftover preserves hunk here is weaker than #16676 (Object.values vs named keys) and would regress that fix.

Do not merge this PR over #16676. Staying closed. Not marking ready.

@huang47 huang47 closed this Sep 3, 2026
christian-byrne pushed a commit that referenced this pull request Sep 4, 2026
…6903)

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## Summary

Cloud Playwright fails because keyboard open already shows the dock, but
`#agent-panel-title` is never in the success-path DOM. The complementary
landmark still points at that id.

## Evidence

**Failing run:**
https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33822896207
**SHA:** `9a24b373`  
**Job:** `playwright-tests (cloud)` — browsers=failure; sharded=success
**Spec:** `browser_tests/tests/agent/agentPanelLifecycle.spec.ts:68` —
`supports keyboard activation and returns one complementary landmark`

What happens today (the failing spec is the proof):

1. Focus the Ask Comfy Agent button and press Enter.
2. `#docked-agent-panel` becomes visible (`toBeVisible` passed).
3. The landmark has `role="complementary"` and
`aria-labelledby="agent-panel-title"` (both passed).
4. `expect(page.locator('#agent-panel-title')).toHaveCount(1)` times out
at 5000ms — received 0 on the first attempt and all 3 retries.

This is not a keyboard-activation failure and not a flake. Click-open in
the same file also mounts the success tree; only this test asks for the
title id.

`#11452` (`getSlotKey`) is discarded as cause. That commit only touches
`src/renderer/core/layout/slots/slotIdentifier.ts` and an eslint
suppression. It does not load, label, or render the agent panel. The
next merge after the lifecycle spec (`#16217`) just happened to be
`#11452`.

Also not `#16754` (error-overlay / in-flight execution errors). Does not
reopen `#16537` or `#16567`. Does not touch `#16559` (knip).

## Root cause

`DockedAgentPanel.vue:6` always sets
`aria-labelledby="agent-panel-title"`. That id is only rendered on the
chunk-load **error** fallback (`DockedAgentPanel.vue:48`). The success
path (`AgentPanelRoot` → `AgentPanel` → `PanelHeader`) had a visible
`<h1>` with `t('agent.title')` and no id.

`#16198` removed the Suspense fallback that used to render
`#agent-panel-title` while loading. The success heading never received
the id, so after a successful open the labelledby target is missing.

## Change

- **What:** `PanelHeader.vue:36` — add `id="agent-panel-title"` to the
existing success-path `<h1>`.
- Unit proof: `PanelHeader.test.ts` asserts the heading named "Comfy
Agent" carries that id.
- No e2e spec changes. No other product behavior.

## Verify (human, minutes)

```
pnpm exec playwright test browser_tests/tests/agent/agentPanelLifecycle.spec.ts --grep "supports keyboard activation"
```

Expected: after keyboard activation, `#agent-panel-title` is present
(count 1); that test green. No other product behavior change.

## Review Focus

The dock landmark and the visible heading must share one id on the
success path. The error fallback already owns the same id and is
mutually exclusive with `PanelHeader`.

## Screenshots (if applicable)

N/A — a11y id wiring; no visual change.
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-bd50d3ca-5bca-4e30-a350-e95776a9b7a0?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-bd50d3ca-5bca-4e30-a350-e95776a9b7a0&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 27, 2026
…Comfy-Org#13957)

## ELI-5

When you generate an image through the API (or the Comfy MCP), the job
never stores the editor file the canvas saves — only the machine-format
graph. Drop that machine-format JSON on the canvas and it rebuilds a
workflow just fine, but the asset three-dots "Open this workflow in a
new tab" just said there was no workflow data. This teaches the menu the
same trick the canvas already knows: no editor workflow, open the stored
machine-format graph instead. Nothing is written back to the job or the
asset — save it yourself if you want to keep it.

## Summary

The asset menu's "Open this workflow in a new tab" now falls back to the
API-format graph a job stores at `workflow.prompt` when
`extra_data.extra_pnginfo.workflow` is absent, loading it through
`app.loadApiJson` — the same loader the canvas uses for a dropped
API-format JSON file, ending in the same `afterLoadNewGraph` new-tab
handoff.

## Changes

- `jobTypes.ts`: `zWorkflowContainer` also parses `prompt` (it was
previously stripped).
- `fetchJobs.ts`: `extractApiPrompt()` — returns the stored API graph
**only** when no editor workflow is embedded. An embedded workflow
always suppresses the fallback, so frontend/desktop submissions are used
as-is and never re-derived (this holds even when that embedded workflow
fails validation, which is deliberate — presence, not validity, is the
switch).
- `jobOutputCache.ts` / `workflowExtractionUtil.ts`: `getJobApiPrompt()`
/ `extractApiPromptFromAsset()`, reusing the same LRU-cached job detail,
so the fallback costs no extra request.
- `useMediaAssetActions.ts`: single-asset `openWorkflow` and bulk
`openMultipleWorkflows` both go through one `openAssetWorkflow` helper
that uses the fallback when extraction yields no workflow, gated by
`app.isApiJson`. The fallback returns the same `{ success, error }`
shape as `openWorkflowAction`, with the prompt fetch and the load inside
one try/catch, so a failure at either step degrades to the warning toast
with the underlying message rather than escaping as an unhandled
rejection.
- `app.ts`: the canvas drop path's `await this.loadApiJson(...)` gets
its own `try`/`catch`, reporting through `showErrorOnFileLoad`.
Previously a failed load fell into `handleFile`'s prompt-parse `catch`
and continued on to the A1111-parameters fallback, surfacing a
misleading parse error instead of the real one.
- `assetSchema.ts`: `zAsset` accepts a `null` `user_metadata` and
normalizes it to `undefined`. The generated ingest shape is
`.optional()`, which rejects an explicit `null` outright — so an asset
whose payload carried one failed `safeParse` and was dropped entirely
rather than reaching the metadata guard.

The fallback engages only on the branch that previously always failed,
so no existing behavior changes. One incidental improvement: that
branch's toast now shows the translated `mediaAsset.noWorkflowDataFound`
instead of the raw English `'No workflow data available'` that leaked
out of `openWorkflowAction`.

## Deviation from the plan — please read

The plan for this called for converting the stored graph with the
extracted `@comfyorg/api-to-workflow` package and feeding the result to
`loadGraphData`. **That package is not consumable from this repo
today**, verified rather than assumed:

- `npm view @comfyorg/api-to-workflow` → `E404`, while `npm view
@comfyorg/comfyui-electron-types version` → `0.7.0` from the same
registry and scope, so this is a genuine absence, not a registry/auth
artifact.
- Its source repo is **private**, and the package directory there holds
only `README`/`package.json`/`tsconfig` — it compiles from that repo's
own `src/converter`. So a git dependency is not an option either: this
repo is public and every contributor's `pnpm install` and CI would fail.

So this ships the fallback through the converter the frontend **already
has** and already ships in the drop path, which is also what the plan
named as the behavioral target ("same downstream behavior as the chunk
path" — `handleFile` prefers the `workflow` chunk and falls back to the
`prompt` chunk via `loadApiJson`). No second copy of any converter is
introduced. When the package is published, swapping
`openApiPromptAsWorkflow` to convert-then-`loadGraphData` is a contained
change, and it would also be the moment to retire `app.loadApiJson`'s
in-place path for the drop path too.

## Deliberately not in scope

- **Export workflow** still reports no workflow for these assets. Export
needs a serialized workflow document, which `loadApiJson` cannot produce
without mutating the user's open graph. That wants the pure converter,
so it is left for the package.
- The **queue** job menu is a separate call path and untouched.

## Overlap to be aware of

Open draft Comfy-Org#10929 (@guill, last updated May) does the same fallback for
the **queue** menu in `useJobMenu.ts` and touches `fetchJobs.ts` /
`jobTypes.ts` / `jobOutputCache.ts` too, so the two will conflict
textually. Neither supersedes the other on behavior — that PR covers the
queue menu, this covers the asset menu. Whichever lands second should
rebase onto the first and reuse its `prompt` plumbing rather than
duplicating it. I have not touched Comfy-Org#10929.

## Merge with `main`

Merged `main` in. One textual conflict (an import block in
`jobOutputCache.test.ts`, both sides kept) and one semantic one that no
conflict marker would have shown: Comfy-Org#15381 changed `isOutputAssetMetadata`
to require `subfolder` rather than `nodeId`, so this PR's `'missing
nodeId'` negative case (`{ jobId, subfolder }`) is now *valid* output
metadata and the fallback correctly fires for it. That row is realigned
to `'missing subfolder'`, which is what the current guard actually
rejects. No production code changed for this — the guard is shared with
`extractWorkflowFromAsset`, which already followed `main`.

Merged `main` a second time (`27f79c4d42`) to pick up Comfy-Org#16577, which
temporarily disables the automatic custom-node suites. Those two
`custom_nodes_e2e` shards were the branch's only red checks and their
failure came from `main`, not this diff — a stale
`ROUNDTRIP_VALUE_ALLOWED_KEYS` allowance for VHS `per_batch` that Comfy-Org#15381
made obsolete (analysis in the comment thread; the real ledger fix is
Comfy-Org#16567). Clean merge, no conflicts.

## Review Focus

- The synthesized graph has invented layout and no groups/reroutes; that
is inherent to API format and accepted here.
- `extractApiPrompt` returns `unknown` on purpose: the canonical format
check is `app.isApiJson`, a type guard, and importing `app` into the
remote layer to use it there would invert the layering.

## Provenance

- **Authored by:** agent-work loop
- **Verified:** re-verified on the merged tree at `27f79c4d42`: `pnpm
vitest run` over the five touched suites plus `src/platform/assets` — 55
files, 931 passed, 1 skipped, 0 failed; `pnpm typecheck`, `pnpm
format:check` and `eslint` on the changed files all clean (only the
pre-existing `apiSchema is deprecated` warnings on imports this PR did
not add). `pnpm test:unit` on the previous head — 1455/1457 files pass;
the two failures (`scripts/cicd/check-binary-size.test.ts`,
`useFreeTierQuota.test.ts`) reproduce identically on unmodified
`origin/main` and are a local Node 24 vs required >=25 artifact, not
this branch. Merges clean with `main` (`mergeable: MERGEABLE`); no
merge-queue run has ever been ejected for this PR.
- **Deviations:** the planned `@comfyorg/api-to-workflow` conversion
path was not used — see "Deviation from the plan" above for the
evidence. Still unverified end to end: no run against a live
API-submitted cloud job, so the assertion that these jobs populate
`workflow.prompt` and omit `extra_pnginfo.workflow` rests on the plan
and Comfy-Org#10929's manual repro rather than a first-hand reproduction.
CodeRabbit's transactional-`loadApiJson` finding is deferred rather than
fixed here — pre-existing across `loadGraphData` / `importA1111` too,
and a design call; recorded as a follow-up (rationale on the resolved
thread).

---------

Co-authored-by: bymyself <cbyrne@comfy.org>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants