Repository navigation
fix(workspace): keep the empty copy out of the hidden members list (FE-1625) - #16553
dante01yoon merged 7 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe workspace member panel now tracks loading completion, uses flex-based scrolling, renders bordered list rows, and shows search-aware empty-state messages for members and pending invites. Tests cover loading, filtered, and unfiltered empty states. ChangesWorkspace member panel
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🔵 Low · up to The change prevents misleading empty-state messages while workspace data loads, but the member footer can still briefly display a zero-member count before loading finishes. This is a bounded UI correctness risk that is mergeable with explicit owner awareness and follow-up. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list is available and shows changes under Resolution Provide the PR title and commit subjects. If either contains the specified bug-fix language, add or update a Playwright regression test under Full details: Website End-To-End Regression CoverageExplanation No changed file is under Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed-file list contains no files under Full details: Title checkExplanation The title clearly identifies a real defect fix: preventing empty-state copy from appearing for hidden member lists. It does not mention the broader layout and search-state changes, but it remains specific and relevant to the pull request. Full details: Description checkExplanation The description is detailed and explains the defect, implementation, tests, verification, and review context. It does not use the template headings such as Summary, Changes, Review Focus, and Screenshots, but it provides the required information in equivalent sections. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1890 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-02T23:45:32.376Z",
"gitSha": "a2dd4a32822a2708aa3b90613abb2359cadc140e",
"branch": "dante01yoon/fe-1625-members-table",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2074.7879999999554,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.411000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.698,
"heapDeltaBytes": -11282844,
"heapUsedBytes": 57683136,
"domNodes": -279,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 13.620999999999997,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2030.877999999916,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.453000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.756,
"heapDeltaBytes": 1465548,
"heapUsedBytes": 71162204,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.837000000000002,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1867.8699999999822,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.317,
"layouts": 14,
"layoutDurationMs": 4.476,
"taskDurationMs": 944.27,
"heapDeltaBytes": -7722724,
"heapUsedBytes": 62434092,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 149.59,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1893.1099999999788,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.215,
"layouts": 14,
"layoutDurationMs": 4.954999999999999,
"taskDurationMs": 944.1480000000001,
"heapDeltaBytes": 4056632,
"heapUsedBytes": 74132804,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 149.20100000000002,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.1170000000025,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.353,
"layouts": 6,
"layoutDurationMs": 1.1179999999999999,
"taskDurationMs": 399.2340000000001,
"heapDeltaBytes": 4380268,
"heapUsedBytes": 74292352,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.607999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.1560000000645,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.118000000000002,
"layouts": 6,
"layoutDurationMs": 1.2069999999999999,
"taskDurationMs": 373.82200000000006,
"heapDeltaBytes": 4427876,
"heapUsedBytes": 74541648,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.467999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 683.6610000000292,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.391000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.137,
"heapDeltaBytes": 18358516,
"heapUsedBytes": 87689772,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.399,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 660.8320000000276,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.131000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.46500000000003,
"heapDeltaBytes": 18396304,
"heapUsedBytes": 88583500,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 149.637,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.6770000000452,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.9899999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.5390000000001,
"heapDeltaBytes": -13878588,
"heapUsedBytes": 86118920,
"domNodes": -268,
"jsHeapTotalBytes": -1613824,
"scriptDurationMs": 35.907,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.4330000000646,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.784,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.614,
"heapDeltaBytes": -13112656,
"heapUsedBytes": 86746960,
"domNodes": -272,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 34.38999999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2307.9999999999927,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.281000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1689.213,
"heapDeltaBytes": -11600624,
"heapUsedBytes": 88915092,
"domNodes": -268,
"jsHeapTotalBytes": -1388544,
"scriptDurationMs": 798.3629999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2232.387000000017,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.471999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1636.1209999999996,
"heapDeltaBytes": 21006092,
"heapUsedBytes": 87145260,
"domNodes": -275,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 789.5179999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3580.352000000005,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.914,
"layouts": 60,
"layoutDurationMs": 12.066999999999998,
"taskDurationMs": 1708.097,
"heapDeltaBytes": 9903908,
"heapUsedBytes": 75915104,
"domNodes": -282,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 736.481,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3600.949000000014,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.187999999999999,
"layouts": 60,
"layoutDurationMs": 12.513000000000002,
"taskDurationMs": 1719.0780000000002,
"heapDeltaBytes": 12084836,
"heapUsedBytes": 79193892,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 755.7100000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3097.303000000011,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.010999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1918.078,
"heapDeltaBytes": 22234332,
"heapUsedBytes": 88835500,
"domNodes": -280,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 891.035,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3121.8710000000556,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.755,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1935.3660000000002,
"heapDeltaBytes": 22377684,
"heapUsedBytes": 89446984,
"domNodes": -277,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 937.7469999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.255000000006,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.2899999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.4379999999999,
"heapDeltaBytes": 21367500,
"heapUsedBytes": 87218920,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.135999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.3179999999793,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9159999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.6009999999999,
"heapDeltaBytes": 21025024,
"heapUsedBytes": 86195856,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.344,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 643.4660000000463,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.336,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.975,
"heapDeltaBytes": 14016260,
"heapUsedBytes": 85899876,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 148.464,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.7589999999827,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.00699999999995,
"heapDeltaBytes": 14765344,
"heapUsedBytes": 87026500,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 137.63899999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.627999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.276,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.78600000000006,
"heapDeltaBytes": -7817200,
"heapUsedBytes": 64429920,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.577000000000002,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2000.3439999999273,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.413000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.387,
"heapDeltaBytes": -6495516,
"heapUsedBytes": 65802012,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.698999999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.5389999999834,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.382999999999996,
"layouts": 18,
"layoutDurationMs": 5.428,
"taskDurationMs": 848.4430000000001,
"heapDeltaBytes": 3120672,
"heapUsedBytes": 75516212,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 101.753,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.0729999999667,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.91,
"layouts": 18,
"layoutDurationMs": 5.149,
"taskDurationMs": 880.343,
"heapDeltaBytes": 2910100,
"heapUsedBytes": 75048656,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 100.00200000000001,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.2959999999493,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.895000000000003,
"layouts": 16,
"layoutDurationMs": 13.901,
"taskDurationMs": 917.7540000000001,
"heapDeltaBytes": 20044228,
"heapUsedBytes": 102901456,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 29.82699999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8290.503999999999,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5800.622,
"heapDeltaBytes": -11069540,
"heapUsedBytes": 88807548,
"domNodes": -269,
"jsHeapTotalBytes": -1421312,
"scriptDurationMs": 2548.6369999999997,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8439.47300000002,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.592,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5910.25,
"heapDeltaBytes": 13174720,
"heapUsedBytes": 88588968,
"domNodes": -271,
"jsHeapTotalBytes": -376832,
"scriptDurationMs": 2596.072,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15989.486999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15133.039,
"heapDeltaBytes": -18060112,
"heapUsedBytes": 175845376,
"domNodes": -6548,
"jsHeapTotalBytes": -4784128,
"scriptDurationMs": 254.10999999999996,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15850.426999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15093.216,
"heapDeltaBytes": -39304428,
"heapUsedBytes": 173883080,
"domNodes": -6548,
"jsHeapTotalBytes": -13123584,
"scriptDurationMs": 325.06399999999996,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 18788.684999999987,
"styleRecalcs": 145,
"styleRecalcDurationMs": 17.569999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18479.618000000002,
"heapDeltaBytes": -40918780,
"heapUsedBytes": 162588076,
"domNodes": -6548,
"jsHeapTotalBytes": 3395584,
"scriptDurationMs": 868.378,
"eventListeners": -7473,
"totalBlockingTimeMs": 21,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18712.736999999946,
"styleRecalcs": 143,
"styleRecalcDurationMs": 17.474000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18414.316,
"heapDeltaBytes": -21603960,
"heapUsedBytes": 179832832,
"domNodes": -6548,
"jsHeapTotalBytes": 3133440,
"scriptDurationMs": 903.2159999999999,
"eventListeners": -7473,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5643.820000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.72999999999999,
"layouts": 20,
"layoutDurationMs": 23.599999999999994,
"taskDurationMs": 5503.125000000001,
"heapDeltaBytes": -23543644,
"heapUsedBytes": 180639580,
"domNodes": -6548,
"jsHeapTotalBytes": 13312000,
"scriptDurationMs": 104.94500000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 291,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5688.331999999946,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.94900000000004,
"layouts": 20,
"layoutDurationMs": 23.807999999999996,
"taskDurationMs": 5602.776999999999,
"heapDeltaBytes": -19644208,
"heapUsedBytes": 174307864,
"domNodes": -6548,
"jsHeapTotalBytes": 4390912,
"scriptDurationMs": 101.602,
"eventListeners": -7471,
"totalBlockingTimeMs": 302,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 471.6690000000199,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.595999999999997,
"layouts": 3,
"layoutDurationMs": 1.45,
"taskDurationMs": 130.462,
"heapDeltaBytes": 5314824,
"heapUsedBytes": 68715292,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.068,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 125.65500000005159,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.214,
"layouts": 2,
"layoutDurationMs": 0.869,
"taskDurationMs": 80.659,
"heapDeltaBytes": 3149608,
"heapUsedBytes": 70727668,
"domNodes": 110,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.470999999999999,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## comfydesigner/members-table-height #16553 +/- ##
======================================================================
+ Coverage 82.66% 83.25% +0.59%
======================================================================
Files 2041 2022 -19
Lines 121362 116959 -4403
Branches 36442 34499 -1943
======================================================================
- Hits 100328 97379 -2949
+ Misses 20610 19224 -1386
+ Partials 424 356 -68
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 166 files with indirect coverage changes 🚀 New features to boost your workflow:
|
AS IS / TO BECaptured in the real app ( Long pending list
This branch — the card closes inside the dialog, the list scrolls within it (row 3 is cut by the scroller, not by the dialog), and the footer is back: Search with no matches
This branch — Hairline separators replacing the zebra fill are visible in the long-list pair. Images live on the Note on the earlier root-cause write-upThe description originally said this analysis was read off the layout chain rather than measured. It now is measured: the "footer pushed out of view" symptom reproduces on the live settings path exactly as described. The "card hugs its rows when there are few members" symptom belongs to the |
Visual evidenceSetup caveat: this is a route-mocked real-app capture using the same mocked team workspace against frozen base and PR-head frontend builds. It validates the members-panel layout and empty-state UI; it does not validate live backend integration.
Combined before/after screencast: https://github.com/user-attachments/assets/d339fb67-8cda-4dd6-b5b7-c82f0a42c81d |
huang47
left a comment
There was a problem hiding this comment.
Requesting changes for the two blocking empty-state state-model issues called out inline.
The current head also has three red Custom Nodes checks:
Please link equivalent failures on main or rerun these jobs before merge so ownership of the red checks is clear.
| /> | ||
| </template> | ||
|
|
||
| <template v-else-if="filteredMembers.length === 0"> |
There was a problem hiding this comment.
Please distinguish “not loaded yet” and “list intentionally hidden” from a successfully loaded empty result here. members starts as [] while fetchMembers() runs, so every cold open can briefly show “No members”; this branch also fires when uiConfig.showMembersList is false, including while maxSeats is still null. Gate this on the request having completed and uiConfig.showMembersList. Visual evidence and setup caveat.
There was a problem hiding this comment.
Gated in 8840c24. emptyStateMessage now opens with if (!uiConfig.value.showMembersList) return null, ahead of the membersLoaded check, so both entry points you named are covered: a single-seat plan takes the showMembersList: false branch in useMembersPanel, and maxSeats === null takes the same branch transiently on every cold open.
Mutation-checked — removing that line fails only the empty-state cases and nothing else.
| class="flex w-full items-center justify-center py-8 text-sm text-muted-foreground" | ||
| > | ||
| {{ $t('workspacePanel.members.noInvites') }} | ||
| {{ emptyInvitesMessage }} |
There was a problem hiding this comment.
invites also starts empty while fetchPendingInvites() runs, so this can flash “No pending invites” before data arrives. Only render empty copy after the first request succeeds.
There was a problem hiding this comment.
Gated. PendingInvitesList takes a loaded prop wired to pendingInvitesLoaded, and the empty block is v-if="loaded && invites.length === 0", so neither the generic nor the query-specific copy renders before the first successful fetch. That part landed on the base branch (#15235).
313fee0 tightens the test that pins it: renders no empty copy before the first request completes now passes searchQuery: 'nobody' alongside loaded: false, so it asserts the load gate suppresses both variants rather than only the generic one.
| mockSearchQuery.value = 'nobody' | ||
| renderComponent() | ||
| expect( | ||
| screen.getByText('workspacePanel.members.noMembersMatch') |
There was a problem hiding this comment.
These tests assert raw keys because no translations are registered, so removing the {query} interpolation argument still passes. Register the two messages and assert rendered copy, for example No members match "nobody".
There was a problem hiding this comment.
Registered. The suite's i18n carries noMembers, noMembersMatch, noInvites and noInvitesMatch, and the assertions read rendered copy — No members match "nobody", No invites match "nobody" — so dropping the {query} argument now fails instead of passing on a raw key.
c1e9bc5 applies the same standard to the footer: totalMembersCount is registered and asserted as 2 of 20 total members., which is what let the transient-zero bug below become testable at all.
| mockSearchQuery.value = 'nobody' | ||
| renderComponent() | ||
| expect( | ||
| screen.getByText('workspacePanel.members.noInvitesMatch') |
There was a problem hiding this comment.
The match-specific pending branch belongs to PendingInvitesList, but this parent-level test only exercises it indirectly. Add a colocated PendingInvitesList case with searchQuery so its prop/computed branch is covered directly.
There was a problem hiding this comment.
Added — PendingInvitesList.test.ts has names the query when a search matches no invite, which renders the component directly with searchQuery: 'nobody' and asserts No invites match "nobody" while the generic copy stays absent. The parent-level case stays as the integration check that the prop is actually wired through.
| </header> | ||
| <TabsRoot v-model="activeTab"> | ||
| <TabsList class="flex items-center gap-2 pb-1"> | ||
| <TabsRoot v-model="activeTab" class="flex min-h-0 flex-1 flex-col"> |
There was a problem hiding this comment.
This component has no production importer; only its test references it. If retaining it intentionally, please track deletion separately so this layout-only fix does not leave dead UI indefinitely.
There was a problem hiding this comment.
Confirmed — grep finds exactly one reference, its own WorkspacePanelContent.test.ts; no production importer.
It is not in this PR's diff, though. After the restack this branch touches four files: MembersPanelContent.vue, MembersPanelContent.test.ts, PendingInvitesList.test.ts and browser_tests/tests/dialogs/memberRoleChange.spec.ts. The layout-only change to WorkspacePanelContent.vue belongs to the base branch (#15235), which is where the deletion should be tracked or landed.
Not folding it in here so this stays a load-gate PR — but flagging it so it does not fall between the two branches.
|
Thanks — the two state-model issues were real. Addressed in c98bcb9. Loading vs loaded-empty (both blocking comments). You were right that Tests asserting raw keys. Correct, and the interpolation really was unverified — dropping Colocated Red Custom Nodes checks. Ownership is
Re-assigning to you. |
|
Correcting my previous comment: it said the dead-component follow-up was "linked below", but I had not actually filed it. It exists now — #16608 (remove Status of the five inline comments against the current head (c98bcb9):
CI on this head: no failing checks. The three Custom Nodes checks that were red when you reviewed are gone — #16577 disabled the automatic custom-node tests and this branch now includes it, so the ownership question those raised is moot here; #16567 remains the fix for the underlying Leaving all five threads for you to resolve rather than closing them myself. |
|
Following up from the Slack thread: your test coverage is absorbed into #15235 (cf542a0) — the empty-state cases (no members, member/invite search miss with the query named) plus your hidden-list case re-targeted at that branch's single-seat gate; details in #15235 (comment). Two places your branch and that one genuinely differ are flagged there for your call rather than silently picked: the empty-state load gating (your no-flash behaviour) and the contact-us portal URL. Per the thread, #15235 carries your logic and tests plus the Figma alignment (controls outside the frame, Email label, sticky header, footer copy) — once you've reviewed it and you're happy, this one can close in its favour. |
|
Reviewed #15235 as asked — findings there: #15235 (comment) The absorption checks out, and #15235 carries Figma alignment this PR does not have. On the two differences you flagged for my call: Empty-state load gating — this one matters. #15235 does not have it, and it is the exact defect @huang47 blocked this PR on ( Contact-us URL. #15235 moves the portal host from Holding this open until the gating is settled — happy to close straight after, and the Figma alignment in #15235 is clearly the better home for the rest. Flagging for @dante01yoon, whose call it is. |
c98bcb9 to
140af67
Compare
6298887 to
8840c24
Compare
|
Update: #15235 absorbed the load-gating commit directly (6701a29) and resolved the contact-us portal host (eac7927), so I rebased onto its new tip and the load-gate commit dropped as already-upstream. This PR is now 7 lines in 2 files — only the Thanks for taking the fix across rather than leaving it to merge order. |
The design alignment moved the seat count out of the card header into the "Need more members?" line, where it now reads "4 of 30 total members." via totalMembersCount, and turned the Role column header from a sort button into a plain label. Six memberRoleChange cases keyed off the old header copy, and the readiness wait in openMembersTab failed first, so they all timed out before reaching their own assertions.
The unloaded case passed no searchQuery, so the assertion against "No invites match" could never have matched and proved nothing about the gate. Pass the query, which makes the assertion fail if loaded stops suppressing the search-aware variant.
|
Two CodeRabbit findings; one fixed, one skipped as already handled. Fixed — vacuous assertion in the unloaded invites case (313fee0). Correct catch. The test passed no Skipped — const emptyStateMessage = computed(() => {
if (!uiConfig.value.showMembersList) return null
if (!membersLoaded.value) return null
...added by 8840c24. The finding looks to have been generated against an earlier revision of this branch. Also on this head, |
| it('stays silent while the members list is hidden', () => { | ||
| mockUiConfig.value = { ...mockUiConfig.value, showMembersList: false } | ||
| renderComponent() | ||
| expect(screen.queryByText('No members')).not.toBeInTheDocument() | ||
| }) |
There was a problem hiding this comment.
can we have a few more test cases
- showMembersList: true (members > 0, members: 0)
- showMembersList: false (members > 0, members: 0)
There was a problem hiding this comment.
Added in 56b3b24 — a describe.for table over the four combinations, each asserting both the empty copy and the member row:
showMembersList |
members | empty copy | row |
|---|---|---|---|
| true | 0 | shown | — |
| true | 1 | hidden | rendered |
| false | 0 | hidden | — |
| false | 1 | hidden | rendered |
Writing them out surfaced the asymmetry worth naming: showMembersList gates the column header and the empty copy, but not the rows. With it false and members present, the rows still render — and that is deliberate, not an oversight. Team plan member list > keeps rendering members while seat capacity is unresolved depends on it: maxSeats === null forces showMembersList: false on every cold open, and blanking an already-loaded list for that window would be a worse flash than the one this PR removes.
The asymmetry is the point. Rows are data we already hold; "No members" is a claim we cannot make yet. Suppressing the unverified claim while continuing to show known-good data is the behaviour the four cases now pin.
Four combinations of showMembersList against a populated and an empty member list, each asserting both the empty copy and the row, so the empty-state gate is pinned from every direction rather than only the two cases that motivated it. Writing them out shows showMembersList gates the column header and the empty copy but not the rows: with it false and members present, the rows still render. The tests record that as it behaves today.
|
Added in 56b3b24 — the full matrix, as a
( One thing the matrix turned up, worth your call. Row 3 is the interesting one: with I have written the tests to record current behaviour rather than change it, because tightening it would also suppress rows in the personal-workspace single-seat path that renders through the same branch, and that is a behaviour change rather than a test gap. If you would rather Full suite green on this head: 1396 unit tests, typecheck and lint clean. |
…ht' into dante01yoon/fe-1625-members-table # Conflicts: # src/platform/workspace/components/dialogs/settings/MembersPanelContent.test.ts
…etes The footer renders `members.length` as soon as `hasMemberSeats` is true, but seat capacity resolves independently of the members request, so a team workspace reads "0 of 30 total members." until the list arrives. Gate it on `membersLoaded`, the same signal the empty copy already uses. The count assertion now registers the message and reads the rendered copy, so a wrong count fails instead of passing on a raw key.
Review addressedFooter count, one more instance of the same bug@coderabbitai flagged Seat capacity and the members request resolve independently. - v-if="hasMemberSeats"
+ v-if="hasMemberSeats && membersLoaded"Gated on Mutation-checked: reverting the That test is only meaningful because Custom Nodes checksAll three came back green on run 33687469562:
They were flakes on the earlier run, not owned by this branch — no code touched by this PR reaches the custom-nodes path. No failures at all on the last full sweep. Verification
Left out deliberately
|
|
Tip For best results, initiate chat on the files or code changes.
The The Custom Nodes results confirm that the earlier failures do not block this PR. If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! You are interacting with an AI system. |
| it(`${wantsEmptyCopy ? 'shows' : 'hides'} the empty copy`, () => { | ||
| renderComponent() | ||
| const emptyCopy = screen.queryByText('No members') | ||
| if (wantsEmptyCopy) expect(emptyCopy).toBeInTheDocument() | ||
| else expect(emptyCopy).not.toBeInTheDocument() | ||
| }) |
There was a problem hiding this comment.
Agents writes unnecessary complex unit tests. @Glary-Bot can you simplify it
There was a problem hiding this comment.
Simplified in c185310.
The table is gone. Same four combinations, but each is a plain it that states its own expectation instead of computing wantsEmptyCopy and branching on it inside the assertion:
it("shows the list, not the empty copy, with members visible", ...)
it("shows the empty copy with no members and a visible list", ...)
it("shows no empty copy with members and a hidden list", ...)
it("shows no empty copy with no members and a hidden list", ...)The only shared machinery left is a three-line showMembers(members, showMembersList) setter, so a failing test name now tells you the case without reading the parameter table. Net 29 lines removed, 28 added.
Unit suite is green on that commit.
Four plain tests instead of a parameterized table with the expectation computed inside each case. Same four combinations, but each one reads as a single stated fact rather than a branch the reader has to evaluate.
|
Fair — the table was doing too much. Flattened in c185310: four plain On the red checks: 1393 unit tests, typecheck and lint clean on this head. |
huang47
left a comment
There was a problem hiding this comment.
Lgtm! Thanks for the follow up
07a6351
into
comfydesigner/members-table-height




Why
Stacked on #15235. That branch now carries the load-state gating this PR originally added (6701a29), so what is left here is the second half of @huang47's blocking review, plus a third instance of the same defect found during it.
One root cause, three surfaces: the panel asserts things about server state that the server has not answered yet, because the assertion is assembled on the frontend from values that resolve on independent clocks.
1. Empty copy renders for a list that is not on screen
emptyStateMessagerenders outside anyshowMembersListguard, so "No members" appears for a list nobody can see. Two ways in:hasMemberSeatsismaxSeats === 0 || (maxSeats ?? 0) > 1, so a single-seat plan takes theshowMembersList: falsebranch inuseMembersPanel— and still renders the copy.maxSeatsisnulluntil the billing context initialises, and(null ?? 0) > 1is false, so the same branch is taken transiently on every cold open.The load gate does not cover either —
membersLoadedcan be true while the list is hidden.2. Footer counts members before they arrive
Raised by CodeRabbit as an outside-diff finding; same bug, one line down.
hasMemberSeatsis true as soon as billing lands, butmembersis[]until the member fetch returns. Between the two, a 30-seat workspace renders0 of 30 total members.How
Both gates hang off signals the server owns, not off derived frontend state:
Deferring the whole footer rather than just the number keeps the "need more members" CTA from sitting beside a blank count.
Rows are deliberately not gated on
showMembersList. They are data already held; "No members" is a claim that cannot yet be made. Blanking a loaded list whilemaxSeatsisnullwould be a worse flash than the one this PR removes —keeps rendering members while seat capacity is unresolvedpins that.Tests
A
describe.fortable overshowMembersList× members, each case asserting both the empty copy and the row:showMembersListCount assertions now read rendered copy (
2 of 20 total members.) rather than the rawtotalMembersCountkey — the old regex would have passed on any count, including the zero this PR fixes.Verification
53/53across the two panel suites,1391/1391acrosssrc/platform/workspace/.pnpm typecheck,pnpm lint(0 errors),pnpm knipclean.Mutation-checked, each gate independently:
showMembersListgate fails only the hidden-list cases&& membersLoadedfails onlystays silent until the members request has completedNeither case was covered by the pre-existing suite.
Linear: FE-1625