Skip to content

fix(workspace): keep the empty copy out of the hidden members list (FE-1625) - #16553

Merged
dante01yoon merged 7 commits into
comfydesigner/members-table-heightfrom
dante01yoon/fe-1625-members-table
Sep 3, 2026
Merged

dante01yoon merged 7 commits into
comfydesigner/members-table-heightfrom
dante01yoon/fe-1625-members-table

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Sep 1, 2026 •

Copy link
Copy Markdown
Collaborator

Why

Stacked on #15235. That branch now carries the load-state gating this PR originally added (6701a29), so what is left here is the second half of @huang47's blocking review, plus a third instance of the same defect found during it.

Please distinguish "not loaded yet" and "list intentionally hidden" from a successfully loaded empty result here. [...] this branch also fires when uiConfig.showMembersList is false, including while maxSeats is still null. Gate this on the request having completed and uiConfig.showMembersList.

One root cause, three surfaces: the panel asserts things about server state that the server has not answered yet, because the assertion is assembled on the frontend from values that resolve on independent clocks.

1. Empty copy renders for a list that is not on screen

emptyStateMessage renders outside any showMembersList guard, so "No members" appears for a list nobody can see. Two ways in:

  • Seatless workspace. hasMemberSeats is maxSeats === 0 || (maxSeats ?? 0) > 1, so a single-seat plan takes the showMembersList: false branch in useMembersPanel — and still renders the copy.
  • Billing not resolved. maxSeats is null until the billing context initialises, and (null ?? 0) > 1 is false, so the same branch is taken transiently on every cold open.

The load gate does not cover either — membersLoaded can be true while the list is hidden.

2. Footer counts members before they arrive

Raised by CodeRabbit as an outside-diff finding; same bug, one line down. hasMemberSeats is true as soon as billing lands, but members is [] until the member fetch returns. Between the two, a 30-seat workspace renders 0 of 30 total members.

billing resolves ──────┐
                       ├── window where the footer states 0 of 30
members request ───────┘

How

Both gates hang off signals the server owns, not off derived frontend state:

const emptyStateMessage = computed(() => {
  if (!uiConfig.value.showMembersList) return null
  if (!membersLoaded.value) return null
  ...
-      v-if="hasMemberSeats"
+      v-if="hasMemberSeats && membersLoaded"

Deferring the whole footer rather than just the number keeps the "need more members" CTA from sitting beside a blank count.

Rows are deliberately not gated on showMembersList. They are data already held; "No members" is a claim that cannot yet be made. Blanking a loaded list while maxSeats is null would be a worse flash than the one this PR removes — keeps rendering members while seat capacity is unresolved pins that.

Tests

A describe.for table over showMembersList × members, each case asserting both the empty copy and the row:

showMembersList members empty copy row
true 0 shown —
true 1 hidden rendered
false 0 hidden —
false 1 hidden rendered

Count assertions now read rendered copy (2 of 20 total members.) rather than the raw totalMembersCount key — the old regex would have passed on any count, including the zero this PR fixes.

Verification

53/53 across the two panel suites, 1391/1391 across src/platform/workspace/. pnpm typecheck, pnpm lint (0 errors), pnpm knip clean.

Mutation-checked, each gate independently:

  • removing the showMembersList gate fails only the hidden-list cases
  • removing && membersLoaded fails only stays silent until the members request has completed

Neither case was covered by the pre-existing suite.

Linear: FE-1625

@dante01yoon
dante01yoon requested a review from a team September 1, 2026 23:50
@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 3fadd102-8c44-4f14-af8f-aa34fbbad980

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: ba95f6a9-ced8-4ff1-949d-f75c20253282

📥 Commits

Reviewing files that changed from the base of the PR and between c98bcb9 and 140af67.

📒 Files selected for processing (8)
  • src/locales/en/main.json
  • src/platform/workspace/components/dialogs/settings/MemberListItem.vue
  • src/platform/workspace/components/dialogs/settings/MembersPanelContent.test.ts
  • src/platform/workspace/components/dialogs/settings/MembersPanelContent.vue
  • src/platform/workspace/components/dialogs/settings/PendingInvitesList.test.ts
  • src/platform/workspace/components/dialogs/settings/PendingInvitesList.vue
  • src/platform/workspace/components/dialogs/settings/WorkspaceMembersPanelContent.vue
  • src/platform/workspace/components/dialogs/settings/WorkspacePanelContent.vue

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The workspace member panel now tracks loading completion, uses flex-based scrolling, renders bordered list rows, and shows search-aware empty-state messages for members and pending invites. Tests cover loading, filtered, and unfiltered empty states.

Changes

Workspace member panel

Layer / File(s) Summary
Loading state contract
src/platform/workspace/stores/teamWorkspaceStore.ts, src/platform/workspace/composables/useMembersPanel.ts
The workspace store tracks loaded states for members and pending invites. useMembersPanel exposes both refs.
Search-aware empty states
src/locales/en/main.json, src/platform/workspace/components/dialogs/settings/MembersPanelContent.vue, src/platform/workspace/components/dialogs/settings/PendingInvitesList.vue, src/platform/workspace/components/dialogs/settings/MembersPanelContent.test.ts, src/platform/workspace/components/dialogs/settings/PendingInvitesList.test.ts
The member and invite lists render localized messages after loading. Active queries use query-specific messages.
Panel layout and row presentation
src/platform/workspace/components/dialogs/settings/WorkspacePanelContent.vue, src/platform/workspace/components/dialogs/settings/WorkspaceMembersPanelContent.vue, src/platform/workspace/components/dialogs/settings/MembersPanelContent.vue, src/platform/workspace/components/dialogs/settings/MemberListItem.vue, src/platform/workspace/components/dialogs/settings/PendingInvitesList.vue
The panel uses flex-based internal scrolling. Rows use bottom borders without alternating backgrounds. The member footer and contact URL are updated.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: 🔵 Low · up to 140af

The change prevents misleading empty-state messages while workspace data loads, but the member footer can still briefly display a zero-member count before loading finishes. This is a bounded UI correctness risk that is mergeable with explicit owner awareness and follow-up.

Suggested reviewers: christian-byrne


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The changed-file list is available and shows changes under src/, with no browser_tests/ file. The PR description does not provide a concrete explanation for not adding an end-to-end regression tes… Provide the PR title and commit subjects. If either contains the specified bug-fix language, add or update a Playwright regression test under browser_tests/, or add a concrete explanation in the PR description explaining why an end-to-end…
✅ Passed checks (6 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Website End-To-End Regression Coverage ✅ Passed No changed file is under apps/website/src/ or apps/website/public/. The pull request changes workspace frontend files under src/ and localization files only, so this website-specific check does …
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains no files under src/lib/litegraph/ or src/ecs/, and no files related to graph entities such as nodes, links, widgets, slots, reroutes, groups, or subgraphs. This chec…
Title check ✅ Passed The title clearly identifies a real defect fix: preventing empty-state copy from appearing for hidden member lists. It does not mention the broader layout and search-state changes, but it remains spec…
Description check ✅ Passed The description is detailed and explains the defect, implementation, tests, verification, and review context. It does not use the template headings such as Summary, Changes, Review Focus, and Screensh…
Full details: End-To-End Regression Coverage For Fixes

Explanation

The changed-file list is available and shows changes under src/, with no browser_tests/ file. The PR description does not provide a concrete explanation for not adding an end-to-end regression test. However, the PR title and commit subjects are not available in the review context, so the required bug-fix language condition cannot be verified.

Resolution

Provide the PR title and commit subjects. If either contains the specified bug-fix language, add or update a Playwright regression test under browser_tests/, or add a concrete explanation in the PR description explaining why an end-to-end regression test is not practical.

Full details: Website End-To-End Regression Coverage

Explanation

No changed file is under apps/website/src/ or apps/website/public/. The pull request changes workspace frontend files under src/ and localization files only, so this website-specific check does not apply.

Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

The changed-file list contains no files under src/lib/litegraph/ or src/ecs/, and no files related to graph entities such as nodes, links, widgets, slots, reroutes, groups, or subgraphs. This check is therefore not applicable.

Full details: Title check

Explanation

The title clearly identifies a real defect fix: preventing empty-state copy from appearing for hidden member lists. It does not mention the broader layout and search-state changes, but it remains specific and relevant to the pull request.

Full details: Description check

Explanation

The description is detailed and explains the defect, implementation, tests, verification, and review context. It does not use the template headings such as Summary, Changes, Review Focus, and Screenshots, but it provides the required information in equivalent sections.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dante01yoon/fe-1625-members-table

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 1, 2026
@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1890 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1869 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 11:34:20 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 129ms TBT · 98.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.6 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.8 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 21ms TBT · 163.3 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 297ms TBT · 169.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 585ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.4 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 40ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 944ms
canvas-mouse-sweep: script duration 149ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.1 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -171
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 387ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.0 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 446ms
dom-widget-clipping: script duration 148ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.1 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 619ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.4 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1663ms
large-graph-pan: script duration 794ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.0 MB
large-graph-pan: DOM nodes -272
large-graph-pan: event listeners -74
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1714ms
large-graph-zoom: script duration 746ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.0 MB
large-graph-zoom: DOM nodes -141
large-graph-zoom: event listeners -86
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1927ms
legacy-node-drag: script duration 914ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.0 MB
legacy-node-drag: DOM nodes -279
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 577ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.7 MB
minimap-idle: DOM nodes -275
minimap-idle: event listeners -76
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 432ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.5 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 509ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.1 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -199
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 36ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 864ms
subgraph-mouse-sweep: script duration 101ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.8 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -232
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 918ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 129ms
subgraph-transition-enter: heap used 98.1 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5855ms
viewport-pan-sweep: script duration 2572ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.6 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -154
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15113ms
vue-large-graph-idle: script duration 290ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 166.8 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 144
vue-large-graph-pan: task duration 18447ms
vue-large-graph-pan: script duration 886ms
vue-large-graph-pan: TBT 21ms
vue-large-graph-pan: heap used 163.3 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7473
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 73ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5553ms
vue-node-resize-workload: script duration 103ms
vue-node-resize-workload: TBT 297ms
vue-node-resize-workload: heap used 169.3 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 106ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.5 MB
workflow-execution: DOM nodes 131
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-09-02T23:45:32.376Z",
  "gitSha": "a2dd4a32822a2708aa3b90613abb2359cadc140e",
  "branch": "dante01yoon/fe-1625-members-table",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2074.7879999999554,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.411000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 644.698,
      "heapDeltaBytes": -11282844,
      "heapUsedBytes": 57683136,
      "domNodes": -279,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 13.620999999999997,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2030.877999999916,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.453000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 525.756,
      "heapDeltaBytes": 1465548,
      "heapUsedBytes": 71162204,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.837000000000002,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1867.8699999999822,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.317,
      "layouts": 14,
      "layoutDurationMs": 4.476,
      "taskDurationMs": 944.27,
      "heapDeltaBytes": -7722724,
      "heapUsedBytes": 62434092,
      "domNodes": -280,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 149.59,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1893.1099999999788,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 40.215,
      "layouts": 14,
      "layoutDurationMs": 4.954999999999999,
      "taskDurationMs": 944.1480000000001,
      "heapDeltaBytes": 4056632,
      "heapUsedBytes": 74132804,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 149.20100000000002,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1735.1170000000025,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 18.353,
      "layouts": 6,
      "layoutDurationMs": 1.1179999999999999,
      "taskDurationMs": 399.2340000000001,
      "heapDeltaBytes": 4380268,
      "heapUsedBytes": 74292352,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.607999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.1560000000645,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.118000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.2069999999999999,
      "taskDurationMs": 373.82200000000006,
      "heapDeltaBytes": 4427876,
      "heapUsedBytes": 74541648,
      "domNodes": 77,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 11.467999999999996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 683.6610000000292,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.391000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.137,
      "heapDeltaBytes": 18358516,
      "heapUsedBytes": 87689772,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 146.399,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 660.8320000000276,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.131000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.46500000000003,
      "heapDeltaBytes": 18396304,
      "heapUsedBytes": 88583500,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 149.637,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2046.6770000000452,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.9899999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 613.5390000000001,
      "heapDeltaBytes": -13878588,
      "heapUsedBytes": 86118920,
      "domNodes": -268,
      "jsHeapTotalBytes": -1613824,
      "scriptDurationMs": 35.907,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.4330000000646,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.784,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 624.614,
      "heapDeltaBytes": -13112656,
      "heapUsedBytes": 86746960,
      "domNodes": -272,
      "jsHeapTotalBytes": -1089536,
      "scriptDurationMs": 34.38999999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2307.9999999999927,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.281000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1689.213,
      "heapDeltaBytes": -11600624,
      "heapUsedBytes": 88915092,
      "domNodes": -268,
      "jsHeapTotalBytes": -1388544,
      "scriptDurationMs": 798.3629999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2232.387000000017,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.471999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1636.1209999999996,
      "heapDeltaBytes": 21006092,
      "heapUsedBytes": 87145260,
      "domNodes": -275,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 789.5179999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3580.352000000005,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.914,
      "layouts": 60,
      "layoutDurationMs": 12.066999999999998,
      "taskDurationMs": 1708.097,
      "heapDeltaBytes": 9903908,
      "heapUsedBytes": 75915104,
      "domNodes": -282,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 736.481,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3600.949000000014,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.187999999999999,
      "layouts": 60,
      "layoutDurationMs": 12.513000000000002,
      "taskDurationMs": 1719.0780000000002,
      "heapDeltaBytes": 12084836,
      "heapUsedBytes": 79193892,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 755.7100000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3097.303000000011,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.010999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1918.078,
      "heapDeltaBytes": 22234332,
      "heapUsedBytes": 88835500,
      "domNodes": -280,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 891.035,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3121.8710000000556,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.755,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1935.3660000000002,
      "heapDeltaBytes": 22377684,
      "heapUsedBytes": 89446984,
      "domNodes": -277,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 937.7469999999998,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2023.255000000006,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.2899999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 568.4379999999999,
      "heapDeltaBytes": 21367500,
      "heapUsedBytes": 87218920,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.135999999999996,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2015.3179999999793,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.9159999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 584.6009999999999,
      "heapDeltaBytes": 21025024,
      "heapUsedBytes": 86195856,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.344,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 643.4660000000463,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.336,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.975,
      "heapDeltaBytes": 14016260,
      "heapUsedBytes": 85899876,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 148.464,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 612.7589999999827,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.401,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.00699999999995,
      "heapDeltaBytes": 14765344,
      "heapUsedBytes": 87026500,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 137.63899999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2010.627999999997,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.276,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 503.78600000000006,
      "heapDeltaBytes": -7817200,
      "heapUsedBytes": 64429920,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 8.577000000000002,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2000.3439999999273,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.413000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 514.387,
      "heapDeltaBytes": -6495516,
      "heapUsedBytes": 65802012,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.698999999999998,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.5389999999834,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 36.382999999999996,
      "layouts": 18,
      "layoutDurationMs": 5.428,
      "taskDurationMs": 848.4430000000001,
      "heapDeltaBytes": 3120672,
      "heapUsedBytes": 75516212,
      "domNodes": -294,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 101.753,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1734.0729999999667,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 35.91,
      "layouts": 18,
      "layoutDurationMs": 5.149,
      "taskDurationMs": 880.343,
      "heapDeltaBytes": 2910100,
      "heapUsedBytes": 75048656,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 100.00200000000001,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.2959999999493,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 28.895000000000003,
      "layouts": 16,
      "layoutDurationMs": 13.901,
      "taskDurationMs": 917.7540000000001,
      "heapDeltaBytes": 20044228,
      "heapUsedBytes": 102901456,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 29.82699999999999,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 129,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8290.503999999999,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 34.993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5800.622,
      "heapDeltaBytes": -11069540,
      "heapUsedBytes": 88807548,
      "domNodes": -269,
      "jsHeapTotalBytes": -1421312,
      "scriptDurationMs": 2548.6369999999997,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8439.47300000002,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.592,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5910.25,
      "heapDeltaBytes": 13174720,
      "heapUsedBytes": 88588968,
      "domNodes": -271,
      "jsHeapTotalBytes": -376832,
      "scriptDurationMs": 2596.072,
      "eventListeners": -169,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15989.486999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15133.039,
      "heapDeltaBytes": -18060112,
      "heapUsedBytes": 175845376,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4784128,
      "scriptDurationMs": 254.10999999999996,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.33666666666674,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15850.426999999967,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15093.216,
      "heapDeltaBytes": -39304428,
      "heapUsedBytes": 173883080,
      "domNodes": -6548,
      "jsHeapTotalBytes": -13123584,
      "scriptDurationMs": 325.06399999999996,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18788.684999999987,
      "styleRecalcs": 145,
      "styleRecalcDurationMs": 17.569999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18479.618000000002,
      "heapDeltaBytes": -40918780,
      "heapUsedBytes": 162588076,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3395584,
      "scriptDurationMs": 868.378,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 21,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18712.736999999946,
      "styleRecalcs": 143,
      "styleRecalcDurationMs": 17.474000000000018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18414.316,
      "heapDeltaBytes": -21603960,
      "heapUsedBytes": 179832832,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3133440,
      "scriptDurationMs": 903.2159999999999,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 20,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5643.820000000005,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.72999999999999,
      "layouts": 20,
      "layoutDurationMs": 23.599999999999994,
      "taskDurationMs": 5503.125000000001,
      "heapDeltaBytes": -23543644,
      "heapUsedBytes": 180639580,
      "domNodes": -6548,
      "jsHeapTotalBytes": 13312000,
      "scriptDurationMs": 104.94500000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 291,
      "frameDurationMs": 17.22666666666664,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5688.331999999946,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 72.94900000000004,
      "layouts": 20,
      "layoutDurationMs": 23.807999999999996,
      "taskDurationMs": 5602.776999999999,
      "heapDeltaBytes": -19644208,
      "heapUsedBytes": 174307864,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4390912,
      "scriptDurationMs": 101.602,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 302,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 471.6690000000199,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 21.595999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.45,
      "taskDurationMs": 130.462,
      "heapDeltaBytes": 5314824,
      "heapUsedBytes": 68715292,
      "domNodes": 151,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 12.068,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 125.65500000005159,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.214,
      "layouts": 2,
      "layoutDurationMs": 0.869,
      "taskDurationMs": 80.659,
      "heapDeltaBytes": 3149608,
      "heapUsedBytes": 70727668,
      "domNodes": 110,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.470999999999999,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 47985 70447 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.3% 398
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 38.0% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                          Coverage Diff                           @@
##           comfydesigner/members-table-height   #16553      +/-   ##
======================================================================
+ Coverage                               82.66%   83.25%   +0.59%     
======================================================================
  Files                                    2041     2022      -19     
  Lines                                  121362   116959    -4403     
  Branches                                36442    34499    -1943     
======================================================================
- Hits                                   100328    97379    -2949     
+ Misses                                  20610    19224    -1386     
+ Partials                                  424      356      -68     
Flag Coverage Δ
e2e 66.61% <ø> (-0.01%) ⬇️
unit 76.49% <100.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...omponents/dialogs/settings/MembersPanelContent.vue 96.10% <100.00%> (ø)

... and 166 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

AS IS / TO BE

Captured in the real app (DISTRIBUTION=cloud dev build) against a mocked team workspace — 4 members, 21 pending invites — at a 1280×720 viewport. Each pair is current main first, then this branch.

Long pending list

main — the card runs past the dialog, only 3 of 21 rows fit, the card's bottom edge is clipped by the dialog boundary and the "Need more members?" footer is nowhere on screen:

Long list on main

This branch — the card closes inside the dialog, the list scrolls within it (row 3 is cut by the scroller, not by the dialog), and the footer is back:

Long list on this branch

Search with no matches

main — column headers above a tall blank box, no message:

Unmatched search on main

This branch — No members match "zzzznomatch", and the footer stays put:

Unmatched search on this branch

Hairline separators replacing the zebra fill are visible in the long-list pair.

Images live on the pr-16553-screenshots branch so they stay out of this PR's diff.

Note on the earlier root-cause write-up

The description originally said this analysis was read off the layout chain rather than measured. It now is measured: the "footer pushed out of view" symptom reproduces on the live settings path exactly as described. The "card hugs its rows when there are few members" symptom belongs to the WorkspacePanelContent (tabbed) host, which — as flagged in the description — has no production references today.

@dante01yoon dante01yoon changed the title fix(workspace): bound the members table height and add empty states fix(workspace): bound the members table height and add empty states (FE-1625) Sep 2, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 2, 2026
@huang47

huang47 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Visual evidence

Setup caveat: this is a route-mocked real-app capture using the same mocked team workspace against frozen base and PR-head frontend builds. It validates the members-panel layout and empty-state UI; it does not validate live backend integration.

Before — base 1fcab7c After — head 5d38b04
The members card overflows the dialog and unmatched search leaves a blank list. The list is bounded inside the dialog and unmatched search shows explicit empty-state copy.

Combined before/after screencast: https://github.com/user-attachments/assets/d339fb67-8cda-4dd6-b5b7-c82f0a42c81d

@huang47 huang47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for the two blocking empty-state state-model issues called out inline.

The current head also has three red Custom Nodes checks:

Please link equivalent failures on main or rerun these jobs before merge so ownership of the red checks is clear.

Current-head visual evidence and route-mocked setup caveat.

/>
</template>

<template v-else-if="filteredMembers.length === 0">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please distinguish “not loaded yet” and “list intentionally hidden” from a successfully loaded empty result here. members starts as [] while fetchMembers() runs, so every cold open can briefly show “No members”; this branch also fires when uiConfig.showMembersList is false, including while maxSeats is still null. Gate this on the request having completed and uiConfig.showMembersList. Visual evidence and setup caveat.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gated in 8840c24. emptyStateMessage now opens with if (!uiConfig.value.showMembersList) return null, ahead of the membersLoaded check, so both entry points you named are covered: a single-seat plan takes the showMembersList: false branch in useMembersPanel, and maxSeats === null takes the same branch transiently on every cold open.

Mutation-checked — removing that line fails only the empty-state cases and nothing else.

class="flex w-full items-center justify-center py-8 text-sm text-muted-foreground"
>
{{ $t('workspacePanel.members.noInvites') }}
{{ emptyInvitesMessage }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invites also starts empty while fetchPendingInvites() runs, so this can flash “No pending invites” before data arrives. Only render empty copy after the first request succeeds.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gated. PendingInvitesList takes a loaded prop wired to pendingInvitesLoaded, and the empty block is v-if="loaded && invites.length === 0", so neither the generic nor the query-specific copy renders before the first successful fetch. That part landed on the base branch (#15235).

313fee0 tightens the test that pins it: renders no empty copy before the first request completes now passes searchQuery: 'nobody' alongside loaded: false, so it asserts the load gate suppresses both variants rather than only the generic one.

mockSearchQuery.value = 'nobody'
renderComponent()
expect(
screen.getByText('workspacePanel.members.noMembersMatch')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests assert raw keys because no translations are registered, so removing the {query} interpolation argument still passes. Register the two messages and assert rendered copy, for example No members match "nobody".

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registered. The suite's i18n carries noMembers, noMembersMatch, noInvites and noInvitesMatch, and the assertions read rendered copy — No members match "nobody", No invites match "nobody" — so dropping the {query} argument now fails instead of passing on a raw key.

c1e9bc5 applies the same standard to the footer: totalMembersCount is registered and asserted as 2 of 20 total members., which is what let the transient-zero bug below become testable at all.

mockSearchQuery.value = 'nobody'
renderComponent()
expect(
screen.getByText('workspacePanel.members.noInvitesMatch')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The match-specific pending branch belongs to PendingInvitesList, but this parent-level test only exercises it indirectly. Add a colocated PendingInvitesList case with searchQuery so its prop/computed branch is covered directly.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added — PendingInvitesList.test.ts has names the query when a search matches no invite, which renders the component directly with searchQuery: 'nobody' and asserts No invites match "nobody" while the generic copy stays absent. The parent-level case stays as the integration check that the prop is actually wired through.

</header>
<TabsRoot v-model="activeTab">
<TabsList class="flex items-center gap-2 pb-1">
<TabsRoot v-model="activeTab" class="flex min-h-0 flex-1 flex-col">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component has no production importer; only its test references it. If retaining it intentionally, please track deletion separately so this layout-only fix does not leave dead UI indefinitely.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed — grep finds exactly one reference, its own WorkspacePanelContent.test.ts; no production importer.

It is not in this PR's diff, though. After the restack this branch touches four files: MembersPanelContent.vue, MembersPanelContent.test.ts, PendingInvitesList.test.ts and browser_tests/tests/dialogs/memberRoleChange.spec.ts. The layout-only change to WorkspacePanelContent.vue belongs to the base branch (#15235), which is where the deletion should be tracked or landed.

Not folding it in here so this stays a load-gate PR — but flagging it so it does not fall between the two branches.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Thanks — the two state-model issues were real. Addressed in c98bcb9.

Loading vs loaded-empty (both blocking comments). You were right that members and pendingInvites both start as [], which is indistinguishable from a loaded-but-empty result — there was no flag anywhere to tell them apart, so I added one rather than inferring it. WorkspaceState now carries membersLoaded / pendingInvitesLoaded, set on a successful fetch, exposed through the store and useMembersPanel. The active-tab copy is gated on membersLoaded && uiConfig.showMembersList && filteredMembers.length === 0, which also closes the showMembersList === false / maxSeats === null case you flagged. PendingInvitesList takes loaded as a prop so it keeps owning its own empty state.

Tests asserting raw keys. Correct, and the interpolation really was unverified — dropping {query} passed. Both test files now register the four messages and assert rendered copy (No members match "nobody"), so that regression fails. Added three cases for the new gate: silent before the members request completes, silent before the invites request completes, silent while the list is hidden.

Colocated PendingInvitesList coverage. Added there directly: one case for the search-aware branch with searchQuery, one for no empty copy before the first request completes.

Red Custom Nodes checks. Ownership is #16567 ("test: drop stale VHS LiteGraph per_batch allowlist keys") — its diff removes exactly the VHS_VAEDecodeBatched / VHS_VAEEncodeBatched per_batch entries this failure names. It is not caused by this branch: browser_tests/fixtures/customNode/valueDrift.ts here is byte-identical to main, and the same three checks were red on unrelated PRs #16570 / #16568 / #16567. I deliberately did not duplicate that fix here — it would conflict with #16567 and put a test-fixture change in a members-table PR. I have also merged current main, which includes #16577 (temporarily disabling the automatic custom-node tests), so this head should no longer run them.

WorkspacePanelContent.vue with no production importer. Agreed, and tracked separately rather than deleted here — see the follow-up linked below. This PR only touches its layout classes so the tabbed host stays consistent with the live one; it does not add to the dead surface.

Re-assigning to you.

@dante01yoon
dante01yoon requested a review from huang47 September 2, 2026 05:38
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 2, 2026
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Correcting my previous comment: it said the dead-component follow-up was "linked below", but I had not actually filed it. It exists now — #16608 (remove WorkspacePanelContent.vue, no production importer). Sorry for the dangling reference.

Status of the five inline comments against the current head (c98bcb9):

Comment State
MembersPanelContent.vue — loading vs loaded-empty fixed, gated on membersLoaded && uiConfig.showMembersList
PendingInvitesList.vue:73 — same flash for invites fixed, v-if="loaded && invites.length === 0" (now line 70)
test asserts raw keys, interpolation unverified fixed, messages registered, asserts No members match "nobody"
colocated PendingInvitesList search case added in PendingInvitesList.test.ts
WorkspacePanelContent.vue dead component tracked as #16608

CI on this head: no failing checks. The three Custom Nodes checks that were red when you reviewed are gone — #16577 disabled the automatic custom-node tests and this branch now includes it, so the ownership question those raised is moot here; #16567 remains the fix for the underlying VHS ... per_batch allowlist staleness.

Leaving all five threads for you to resolve rather than closing them myself.

@comfydesigner

Copy link
Copy Markdown
Contributor

Following up from the Slack thread: your test coverage is absorbed into #15235 (cf542a0) — the empty-state cases (no members, member/invite search miss with the query named) plus your hidden-list case re-targeted at that branch's single-seat gate; details in #15235 (comment). Two places your branch and that one genuinely differ are flagged there for your call rather than silently picked: the empty-state load gating (your no-flash behaviour) and the contact-us portal URL. Per the thread, #15235 carries your logic and tests plus the Figma alignment (controls outside the frame, Email label, sticky header, footer copy) — once you've reviewed it and you're happy, this one can close in its favour.

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Reviewed #15235 as asked — findings there: #15235 (comment)

The absorption checks out, and #15235 carries Figma alignment this PR does not have. On the two differences you flagged for my call:

Empty-state load gating — this one matters. #15235 does not have it, and it is the exact defect @huang47 blocked this PR on (members/pendingInvites start as [], indistinguishable from loaded-but-empty, so every cold open flashes the empty copy). Closing this in favour of #15235 as it stands would reintroduce that, and bounding the height makes it more visible rather than less. The fix in c98bcb9 is portable — store-level membersLoaded / pendingInvitesLoaded, a loaded prop on PendingInvitesList, and three regression tests.

Contact-us URL. #15235 moves the portal host from comfysupport.portal.usepylon.com (what is on main; this PR does not touch it) to comfy-org.portal.usepylon.com. I cannot tell which is live, so I have flagged it there for someone who can, rather than picking one.

Holding this open until the gating is settled — happy to close straight after, and the Figma alignment in #15235 is clearly the better home for the rest. Flagging for @dante01yoon, whose call it is.

@dante01yoon
dante01yoon force-pushed the dante01yoon/fe-1625-members-table branch from c98bcb9 to 140af67 Compare September 2, 2026 20:25
@dante01yoon dante01yoon changed the title fix(workspace): bound the members table height and add empty states (FE-1625) fix(workspace): hold the members empty copy until the request completes (FE-1625) Sep 2, 2026
@dante01yoon
dante01yoon changed the base branch from main to comfydesigner/members-table-height September 2, 2026 20:25
@dante01yoon
dante01yoon force-pushed the dante01yoon/fe-1625-members-table branch from 6298887 to 8840c24 Compare September 2, 2026 20:39
@dante01yoon dante01yoon changed the title fix(workspace): hold the members empty copy until the request completes (FE-1625) fix(workspace): keep the empty copy out of the hidden members list (FE-1625) Sep 2, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Update: #15235 absorbed the load-gating commit directly (6701a29) and resolved the contact-us portal host (eac7927), so I rebased onto its new tip and the load-gate commit dropped as already-upstream.

This PR is now 7 lines in 2 files — only the showMembersList half of @huang47's review, which #15235 does not have. Everything else from the original #16553 now lives on that branch.

Thanks for taking the fix across rather than leaving it to merge order.

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
The design alignment moved the seat count out of the card header into the
"Need more members?" line, where it now reads "4 of 30 total members."
via totalMembersCount, and turned the Role column header from a sort
button into a plain label. Six memberRoleChange cases keyed off the old
header copy, and the readiness wait in openMembersTab failed first, so
they all timed out before reaching their own assertions.
The unloaded case passed no searchQuery, so the assertion against
"No invites match" could never have matched and proved nothing about the
gate. Pass the query, which makes the assertion fail if loaded stops
suppressing the search-aware variant.
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Two CodeRabbit findings; one fixed, one skipped as already handled.

Fixed — vacuous assertion in the unloaded invites case (313fee0). Correct catch. The test passed no searchQuery, so queryByText('No invites match "nobody"') could never have matched whether or not the gate worked. It now passes the query alongside loaded: false. I confirmed it is no longer vacuous by flipping loaded to true and watching the assertion fail, then reverting.

Skipped — emptyStateMessage ignoring uiConfig.showMembersList. Not valid against the current head. That is the first guard in the computed:

const emptyStateMessage = computed(() => {
  if (!uiConfig.value.showMembersList) return null
  if (!membersLoaded.value) return null
  ...

added by 8840c24. The finding looks to have been generated against an earlier revision of this branch.

Also on this head, memberRoleChange.spec.ts is fixed (c085553): the design alignment moved the seat count into the footer as 4 of 30 total members. and turned the Role header from a sort button into a plain label, which was failing six cases through the shared openMembersTab readiness wait.

Comment on lines +679 to +683
it('stays silent while the members list is hidden', () => {
mockUiConfig.value = { ...mockUiConfig.value, showMembersList: false }
renderComponent()
expect(screen.queryByText('No members')).not.toBeInTheDocument()
})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a few more test cases

  1. showMembersList: true (members > 0, members: 0)
  2. showMembersList: false (members > 0, members: 0)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 56b3b24 — a describe.for table over the four combinations, each asserting both the empty copy and the member row:

showMembersList members empty copy row
true 0 shown —
true 1 hidden rendered
false 0 hidden —
false 1 hidden rendered

Writing them out surfaced the asymmetry worth naming: showMembersList gates the column header and the empty copy, but not the rows. With it false and members present, the rows still render — and that is deliberate, not an oversight. Team plan member list > keeps rendering members while seat capacity is unresolved depends on it: maxSeats === null forces showMembersList: false on every cold open, and blanking an already-loaded list for that window would be a worse flash than the one this PR removes.

The asymmetry is the point. Rows are data we already hold; "No members" is a claim we cannot make yet. Suppressing the unverified claim while continuing to show known-good data is the behaviour the four cases now pin.

@huang47 huang47 assigned dante01yoon and unassigned huang47 Sep 2, 2026
Four combinations of showMembersList against a populated and an empty
member list, each asserting both the empty copy and the row, so the
empty-state gate is pinned from every direction rather than only the two
cases that motivated it.

Writing them out shows showMembersList gates the column header and the
empty copy but not the rows: with it false and members present, the rows
still render. The tests record that as it behaves today.
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Added in 56b3b24 — the full matrix, as a describe.for over the four combinations. Each case asserts both the empty copy and the member row, so the gate is pinned from both directions rather than only where it fires:

showMembersList members empty copy member row
true 1 hidden rendered
true 0 shown omitted
false 1 hidden rendered
false 0 hidden omitted

(describe.each is rejected by the repo's vitest(consistent-each-for) rule, hence .for.)

One thing the matrix turned up, worth your call. Row 3 is the interesting one: with showMembersList: false and members present, the rows still render — showMembersList gates the column header and the empty copy, but not the MemberListItem loop. So the flag half-hides the list today.

I have written the tests to record current behaviour rather than change it, because tightening it would also suppress rows in the personal-workspace single-seat path that renders through the same branch, and that is a behaviour change rather than a test gap. If you would rather showMembersList: false hide the rows too, happy to make that change here — otherwise it is captured and visible.

Full suite green on this head: 1396 unit tests, typecheck and lint clean.

…ht' into dante01yoon/fe-1625-members-table

# Conflicts:
#	src/platform/workspace/components/dialogs/settings/MembersPanelContent.test.ts
…etes

The footer renders `members.length` as soon as `hasMemberSeats` is true, but
seat capacity resolves independently of the members request, so a team
workspace reads "0 of 30 total members." until the list arrives.

Gate it on `membersLoaded`, the same signal the empty copy already uses. The
count assertion now registers the message and reads the rendered copy, so a
wrong count fails instead of passing on a raw key.
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Review addressed

Footer count, one more instance of the same bug

@coderabbitai flagged hasMemberSeats on the footer as an outside-diff finding, and it is the same defect this PR exists to fix, one line further down.

Seat capacity and the members request resolve independently. hasMemberSeats is true as soon as billing lands, but members is still [] until the member fetch returns — so a 30-seat team workspace renders 0 of 30 total members. in the window between them. Same failure mode as the empty copy: a claim about server state assembled on the frontend before the server answered.

-      v-if="hasMemberSeats"
+      v-if="hasMemberSeats && membersLoaded"

Gated on membersLoaded — the same signal the empty copy uses, so the count and the list now arrive together rather than the count arriving early and wrong. Deferring the whole footer rather than just the number keeps the CTA from appearing next to a blank count.

Mutation-checked: reverting the && membersLoaded fails exactly member count display > stays silent until the members request has completed, and nothing else — the existing suite did not cover it.

That test is only meaningful because totalMembersCount is now registered in the suite i18n and asserted as rendered copy (2 of 20 total members.) instead of the raw key, per @huang47's point on raw-key assertions. The previous assertion matched /workspacePanel\.members\.totalMembersCount/, which would have passed with any count at all — including zero.

Custom Nodes checks

All three came back green on run 33687469562:

Check Result
E2E Custom Nodes Test pass
custom_nodes_e2e (2/5, 0) pass, 14m53s
custom_nodes_e2e (core:1/2, 0) pass, 8m16s

They were flakes on the earlier run, not owned by this branch — no code touched by this PR reaches the custom-nodes path. No failures at all on the last full sweep.

Verification

53/53 across the two panel suites, 1391/1391 across src/platform/workspace/. pnpm typecheck, pnpm lint (0 errors) and pnpm knip clean.

Left out deliberately

WorkspacePanelContent.vue is confirmed dead — its only reference is its own test — but it is not in this PR's diff after the restack. Replied in thread: it belongs to #15235, where the file actually changes.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@dante01yoon, this addresses the footer-count finding.

The membersLoaded guard prevents the transient 0 of 30 total members. state before fetchMembers completes. The rendered-copy assertion also validates both the count and its interpolation.

The Custom Nodes results confirm that the earlier failures do not block this PR.


If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

You are interacting with an AI system.

Comment on lines +709 to +714
it(`${wantsEmptyCopy ? 'shows' : 'hides'} the empty copy`, () => {
renderComponent()
const emptyCopy = screen.queryByText('No members')
if (wantsEmptyCopy) expect(emptyCopy).toBeInTheDocument()
else expect(emptyCopy).not.toBeInTheDocument()
})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agents writes unnecessary complex unit tests. @Glary-Bot can you simplify it

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified in c185310.

The table is gone. Same four combinations, but each is a plain it that states its own expectation instead of computing wantsEmptyCopy and branching on it inside the assertion:

it("shows the list, not the empty copy, with members visible", ...)
it("shows the empty copy with no members and a visible list", ...)
it("shows no empty copy with members and a hidden list", ...)
it("shows no empty copy with no members and a hidden list", ...)

The only shared machinery left is a three-line showMembers(members, showMembersList) setter, so a failing test name now tells you the case without reading the parameter table. Net 29 lines removed, 28 added.

Unit suite is green on that commit.

@huang47 huang47 removed their assignment Sep 2, 2026
Four plain tests instead of a parameterized table with the expectation
computed inside each case. Same four combinations, but each one reads as
a single stated fact rather than a branch the reader has to evaluate.
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Fair — the table was doing too much. Flattened in c185310: four plain it() blocks, one small showMembers() helper for setup, and each case states a single fact rather than computing its expectation inline. Same four combinations, no describe.for.

shows the list, not the empty copy, with members visible
shows the empty copy with no members and a visible list
shows no empty copy with members and a hidden list
shows no empty copy with no members and a hidden list

On the red checks: playwright-tests-chromium-sharded (5, 16) fails on interaction.spec.ts:1072 › Viewport settings › Keeps viewport settings when changing tabs, a canvas screenshot comparison. Against its base this PR touches four files — MembersPanelContent.vue, MembersPanelContent.test.ts, PendingInvitesList.test.ts, memberRoleChange.spec.ts — none of which reach canvas or viewport state. That shard also logged three flaky retries alongside the failure, and the base branch (#15235) is carrying its own unrelated red checks. Not treating it as this PR's, but flagging rather than ignoring in case you read it differently.

1393 unit tests, typecheck and lint clean on this head.

@dante01yoon
dante01yoon requested a review from huang47 September 3, 2026 00:10

@huang47 huang47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for the follow up

@dante01yoon dante01yoon added core/1.53 Backport PRs for core 1.53 cloud/1.53 Backport PRs for cloud 1.53 labels Sep 3, 2026
@dante01yoon
dante01yoon merged commit 07a6351 into comfydesigner/members-table-height Sep 3, 2026
115 of 116 checks passed
@dante01yoon
dante01yoon deleted the dante01yoon/fe-1625-members-table branch September 3, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.53 Backport PRs for cloud 1.53 core/1.53 Backport PRs for core 1.53 risk:high PR risk grade (advisory shadow check; grader-owned) risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants