Repository navigation
refactor: relocate readFileAsArrayBuffer to src/utils/fileUtil - #13739
Conversation
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 8 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (7)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change adds a shared ChangesShared file reader migration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change relocates a generic file-reading helper and updates its five consumers without changing behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file information is available, but the PR title and commit subjects are not present in the review context. The check requires those metadata fields to determine whether bug-fix language is used. The PR description does explain the relocation and test scope, but this cannot establish or exclude the required bug-fix signal. Full details: Website End-To-End Regression CoverageExplanation No files under Full details: Adr Compliance For Entity/Litegraph ChangesExplanation PASS: The changed files are under Full details: Description checkExplanation The description explains the purpose, file changes, behavior impact, review considerations, testing, and provenance. It does not use the template headings exactly, but it provides the required information and is sufficiently complete. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1918 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.83 MB gzip 🟢 -4.44 kBDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • 🟢 -1.01 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 7 unchanged Data & Services — 3.63 MB (baseline 3.64 MB) • 🟢 -13 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 557 kB (baseline 557 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 16 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.8 MB (baseline 16.8 MB) • 🔴 +73 BBundles that do not match a named category
Status: 80 added / 80 removed / 217 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-08T22:16:55.231Z",
"gitSha": "8536d5888b5b4d69215a131bde3310de8332d802",
"branch": "matt/be-3216-relocate-read-file-util",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2075.1200000000836,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.473000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 730.082,
"heapDeltaBytes": 5433940,
"heapUsedBytes": 66254320,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 15.932000000000002,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2074.4530000000623,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.824,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.662,
"heapDeltaBytes": 15742416,
"heapUsedBytes": 77078412,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 13.059999999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2014.3310000000838,
"styleRecalcs": 80,
"styleRecalcDurationMs": 38.726000000000006,
"layouts": 14,
"layoutDurationMs": 5.241,
"taskDurationMs": 1021.12,
"heapDeltaBytes": 6502416,
"heapUsedBytes": 68653208,
"domNodes": -283,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 174.69,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1951.0680000000775,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.047000000000004,
"layouts": 14,
"layoutDurationMs": 4.772,
"taskDurationMs": 976.722,
"heapDeltaBytes": 1031116,
"heapUsedBytes": 62127676,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 164.127,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.3469999999852,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.357,
"layouts": 6,
"layoutDurationMs": 1.4459999999999997,
"taskDurationMs": 411.189,
"heapDeltaBytes": 2036148,
"heapUsedBytes": 62764760,
"domNodes": 74,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 15.805999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.9870000000046,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.532,
"layouts": 6,
"layoutDurationMs": 1.1320000000000001,
"taskDurationMs": 409.049,
"heapDeltaBytes": 2086808,
"heapUsedBytes": 64045016,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.979999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 693.4579999999642,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.367999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.61000000000007,
"heapDeltaBytes": 17916304,
"heapUsedBytes": 79864800,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 166.746,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 733.7749999999232,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.760999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.42999999999995,
"heapDeltaBytes": 17911144,
"heapUsedBytes": 79782936,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 174.289,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2064.7709999999506,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.639000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 810.6120000000001,
"heapDeltaBytes": 8029100,
"heapUsedBytes": 80205820,
"domNodes": -249,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 41.059,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2068.587999999977,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.028999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 743.0270000000002,
"heapDeltaBytes": -12698160,
"heapUsedBytes": 82310064,
"domNodes": -250,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 41.38,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2453.5529999999426,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.854999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1779.2149999999997,
"heapDeltaBytes": -16324564,
"heapUsedBytes": 79657220,
"domNodes": -252,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 846.8240000000001,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2384.5739999999296,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.793000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1731.3999999999999,
"heapDeltaBytes": 5373720,
"heapUsedBytes": 78546420,
"domNodes": -258,
"jsHeapTotalBytes": 1265664,
"scriptDurationMs": 830.82,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3760.055999999963,
"styleRecalcs": 62,
"styleRecalcDurationMs": 14.723999999999997,
"layouts": 60,
"layoutDurationMs": 14.642999999999999,
"taskDurationMs": 1917.328,
"heapDeltaBytes": -535140,
"heapUsedBytes": 73895972,
"domNodes": -259,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 835.383,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3870.1209999999264,
"styleRecalcs": 60,
"styleRecalcDurationMs": 12.460000000000003,
"layouts": 60,
"layoutDurationMs": 15.04,
"taskDurationMs": 1894.3569999999997,
"heapDeltaBytes": 8399620,
"heapUsedBytes": 73740584,
"domNodes": -260,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 846.138,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3172.629999999913,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.163000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2087.7129999999997,
"heapDeltaBytes": 22688484,
"heapUsedBytes": 88409216,
"domNodes": -260,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1039.2320000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3126.305000000002,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.193999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2057.4539999999997,
"heapDeltaBytes": 20478400,
"heapUsedBytes": 85876796,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1019.1050000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.8630000000012,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.9880000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.7500000000001,
"heapDeltaBytes": 8684684,
"heapUsedBytes": 83154300,
"domNodes": -256,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 44.257000000000005,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2044.315000000097,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 710.2449999999999,
"heapDeltaBytes": 7854792,
"heapUsedBytes": 81717384,
"domNodes": -250,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 45.480000000000004,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 659.5129999999472,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.959999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.86600000000004,
"heapDeltaBytes": 12866864,
"heapUsedBytes": 74990360,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 150.93200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 639.7839999999633,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.755,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.238,
"heapDeltaBytes": 14032620,
"heapUsedBytes": 76582168,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 148.618,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.7069999999494,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.027000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.3889999999999,
"heapDeltaBytes": 4127584,
"heapUsedBytes": 66784352,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.655,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2011.7549999999937,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.4289999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.5210000000001,
"heapDeltaBytes": 8411324,
"heapUsedBytes": 69996296,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.408,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.9790000000803,
"styleRecalcs": 75,
"styleRecalcDurationMs": 31.677999999999997,
"layouts": 18,
"layoutDurationMs": 6.2909999999999995,
"taskDurationMs": 903.5500000000001,
"heapDeltaBytes": 3516160,
"heapUsedBytes": 65242464,
"domNodes": -277,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 123.689,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.1279999999979,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.868000000000002,
"layouts": 18,
"layoutDurationMs": 5.8500000000000005,
"taskDurationMs": 850.6579999999999,
"heapDeltaBytes": 19061284,
"heapUsedBytes": 81483380,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 118.65899999999999,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.8280000000232,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.508,
"layouts": 5,
"layoutDurationMs": 12.636999999999999,
"taskDurationMs": 1081.4800000000002,
"heapDeltaBytes": 20923636,
"heapUsedBytes": 100857672,
"domNodes": 13747,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 33.894000000000005,
"eventListeners": 2387,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9177.764000000025,
"styleRecalcs": 248,
"styleRecalcDurationMs": 46.597,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6465.926,
"heapDeltaBytes": -7210272,
"heapUsedBytes": 65516488,
"domNodes": -252,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 2872.3230000000003,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8840.075999999954,
"styleRecalcs": 248,
"styleRecalcDurationMs": 45.864000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6254.259999999999,
"heapDeltaBytes": 32538608,
"heapUsedBytes": 95335004,
"domNodes": -247,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 2832.6549999999997,
"eventListeners": -136,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18949.902999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18817.696,
"heapDeltaBytes": -22264056,
"heapUsedBytes": 187623052,
"domNodes": -6542,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 336.315,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18813.590999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18539.656,
"heapDeltaBytes": -14254064,
"heapUsedBytes": 187892588,
"domNodes": -6541,
"jsHeapTotalBytes": -3584000,
"scriptDurationMs": 328.922,
"eventListeners": -7476,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 24221.452999999998,
"styleRecalcs": 182,
"styleRecalcDurationMs": 27.898000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24125.608,
"heapDeltaBytes": -28887404,
"heapUsedBytes": 179136272,
"domNodes": -6542,
"jsHeapTotalBytes": -4567040,
"scriptDurationMs": 977.361,
"eventListeners": -7472,
"totalBlockingTimeMs": 238,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 23914.44999999999,
"styleRecalcs": 177,
"styleRecalcDurationMs": 26.685000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23778.554,
"heapDeltaBytes": -29992220,
"heapUsedBytes": 178237732,
"domNodes": -6542,
"jsHeapTotalBytes": -1744896,
"scriptDurationMs": 960.66,
"eventListeners": -7474,
"totalBlockingTimeMs": 324,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6831.346000000053,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.376,
"layouts": 20,
"layoutDurationMs": 28.898000000000007,
"taskDurationMs": 6810.446000000001,
"heapDeltaBytes": -30122268,
"heapUsedBytes": 172169168,
"domNodes": -6542,
"jsHeapTotalBytes": 10571776,
"scriptDurationMs": 135.045,
"eventListeners": -7474,
"totalBlockingTimeMs": 661,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6784.2410000000655,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.96300000000001,
"layouts": 20,
"layoutDurationMs": 27.675000000000004,
"taskDurationMs": 6737.992000000001,
"heapDeltaBytes": -34995816,
"heapUsedBytes": 173156980,
"domNodes": -6542,
"jsHeapTotalBytes": 6901760,
"scriptDurationMs": 133.337,
"eventListeners": -7474,
"totalBlockingTimeMs": 646,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9355.583000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9285.605999999998,
"heapDeltaBytes": 225824,
"heapUsedBytes": 158963816,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 201.96500000000006,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9306.246999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9189.044000000002,
"heapDeltaBytes": 6412940,
"heapUsedBytes": 167919784,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 160.11299999999994,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 474.80799999993906,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.936999999999994,
"layouts": 4,
"layoutDurationMs": 1.981,
"taskDurationMs": 137.339,
"heapDeltaBytes": 4897704,
"heapUsedBytes": 66620192,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.534999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 107.47200000002977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.084999999999999,
"layouts": 2,
"layoutDurationMs": 1.6199999999999999,
"taskDurationMs": 74.621,
"heapDeltaBytes": 2898020,
"heapUsedBytes": 64508084,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.687,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
✅ No high-signal findings.
Panel: 6/8 reviewers contributed findings.
Reviewers that did not contribute: kimi-k2.5:adversarial (empty), kimi-k2.5:edge-case (empty)
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #13739 +/- ##
==========================================
+ Coverage 81.60% 83.04% +1.44%
==========================================
Files 2501 2058 -443
Lines 127856 119990 -7866
Branches 34794 33544 -1250
==========================================
- Hits 104333 99649 -4684
+ Misses 23000 20160 -2840
+ Partials 523 181 -342
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 455 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/utils/fileUtil.test.ts`:
- Around line 6-7: Expand the tests around readFileAsArrayBuffer to cover
non-ArrayBuffer results, malformed inputs, and boundary cases while preserving
existing success, error, abort, and capped-read coverage. Strengthen the
capped-read assertion to verify the returned leading bytes, not only byteLength,
and retain focused assertions for invalid results and malformed inputs.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 391a84ea-3707-4e3c-9ffd-d555c6140c68
📒 Files selected for processing (7)
src/scripts/metadata/avif.tssrc/scripts/metadata/ebml.tssrc/scripts/metadata/flac.tssrc/scripts/metadata/gltf.tssrc/scripts/metadata/isobmff.tssrc/utils/fileUtil.test.tssrc/utils/fileUtil.ts
|
@coderabbitai review The outstanding thread is addressed in 526eb1f, and latest |
|
|
DrJKL
left a comment
There was a problem hiding this comment.
The moved utility test adds a non-null assertion even though the return type is nullable.
| const buffer = await readFileAsArrayBuffer(file, 10) | ||
|
|
||
| expect(buffer?.byteLength).toBe(10) | ||
| expect(new Uint8Array(buffer!)).toEqual(bytes.slice(0, 10)) |
There was a problem hiding this comment.
Narrow buffer before constructing the typed array, for example with Vitest assert(buffer instanceof ArrayBuffer). expect(...).toBeInstanceOf does not narrow TypeScript, and buffer! hides a wrong return value.
There was a problem hiding this comment.
Fixed in 9bc768e — replaced buffer! with assert(buffer instanceof ArrayBuffer) from Vitest at all three call sites (the two you flagged plus the maxBytes: 0 case, which used buffer?.byteLength and had the same blind spot: a null return made the assertion read undefined rather than fail on the type).
That also let the redundant expect(buffer).toBeInstanceOf(ArrayBuffer) lines go, since assert covers both the narrowing and the check.
Verified it is a real assertion and not just a type escape hatch: mutating readFileAsArrayBuffer to resolve(null) unconditionally fails all three tests. Under buffer! the first two would have thrown an opaque TypeError from the Uint8Array constructor instead.
Leaving the thread for you to resolve.
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
readFileAsArrayBuffer is a generic File -> ArrayBuffer wrapper with no metadata coupling, so living under src/scripts/metadata/ mis-signalled its domain and invited either duplication or an upward import from a non-metadata feature. Move readFile.ts to src/utils/fileUtil.ts alongside jsonUtil.ts (module content unchanged), move its test with it, and point the five metadata parsers at @/utils/fileUtil. No behavior change. The moved test also drops its non-null assertions: readFileAsArrayBuffer returns ArrayBuffer | null and expect().toBeInstanceOf does not narrow, so buffer! turned a regressed null return into an opaque TypeError instead of a failed assertion. assert(buffer instanceof ArrayBuffer) narrows and fails loudly. The capped-read case now seeds distinct bytes and compares contents rather than only byteLength, and the non-ArrayBuffer result branch gained coverage.
9bc768e to
72ed12e
Compare
|
Pushed Review fix — History rewrite (force-push, heads up) — No longer stacked — #13398 merged, so this targets Verified on the merged tree: |
|
CI status on
Evidence it is repo-wide rather than branch-specific: the same assertion fails on the merge-queue run for the unrelated #11818 (run 33586679239), and #16567 ("test: drop stale VHS LiteGraph per_batch allowlist keys") is already open against it. This PR should go green on a re-run once that lands. Everything this PR can be responsible for is green, including |
DrJKL
left a comment
There was a problem hiding this comment.
Follow-up complete. The nullable buffers are now narrowed with a real assertion before typed-array construction, including the zero-byte case. The relocation remains mechanical and the current diff has no further findings. The custom-node failures are unrelated to this utility move.
…th page-aware progressive window Follow-up to the conflict resolution in f845561 (merge of main), where Comfy-Org#17900 switched ogg.ts to the shared `readFileAsArrayBuffer` helper (introduced in Comfy-Org#13398, relocated to utils/fileUtil in Comfy-Org#13739) and the conflict was resolved by keeping this branch's inline `file.slice(0, MAX_READ_BYTES).arrayBuffer()` + try/catch. That left ogg.ts as the only metadata extractor bypassing the helper that ebml, isobmff, flac, avif and gltf already use. Align with the helper and implement smart, spec-compliant page scanning: - Read through `readFileAsArrayBuffer(file, limit)`. A failed read resolves to "no metadata" silently, matching the other extractors. - Initial window starts at 64 KB (fitting typical single-page headers). - Calculate exact page bounds directly from Ogg page headers and segment tables (Lacing values), expanding carefully by page requirements instead of arbitrary doubling. - Cap raised from 2 MB to 16 MB to comfortably accommodate very large ComfyUI workflows without unnecessary truncation. - Audio data early cutoff: RFC 7845 guarantees OpusTags strictly precedes all audio frames. When non-header audio data is detected, scanning aborts immediately on the first window, avoiding full-file reads on audio files. Tests: - Restore FileReader error/abort failure-mode tests. - Verify page-boundary window expansion and audio data early cutoff. - Verify truncation handling at the 16 MB read cap.
ELI-5
A little helper that turns a browser file into raw bytes was living in the
metadata/folder, but it has nothing to do with metadata — any feature couldneed it. This moves it next door to the other generic helpers (
jsonUtil) soits home matches what it actually does, and points the five metadata parsers at
the new address. Nothing about how it works changed.
What / Why
Follow-up to #13398 (non-blocking review nitpick):
readFileAsArrayBufferis ageneric
File->ArrayBufferplatform-API wrapper with no metadata coupling,so
src/scripts/metadata/readFile.tsmis-signalled its domain and would inviteduplication or an awkward upward import from a non-metadata feature.
src/scripts/metadata/readFile.ts->src/utils/fileUtil.ts(alongsidejsonUtil.ts). Module content is byte-identical.src/utils/fileUtil.test.ts; the two import paths inside itnow use the
@/alias (@/utils/fileUtil,@/scripts/metadata/__fixtures__/helpers).avif,ebml,flac,gltf,isobmff) to importfrom
@/utils/fileUtil.Pure file move + import-path update — no behavior change.
#13398 has merged, so this PR now targets
maindirectly and is no longerstacked.
Judgment call
The moved test still imports the generic
FileReadermock helpers from@/scripts/metadata/__fixtures__/helpers(an upward test-only import). Extractingthose mocks to a shared location is out of scope for this focused relocation —
the reviewer's original note was about the source module's domain, not the test
fixtures — so this keeps the diff minimal and blind-shippable.
Testing
vitest runonfileUtil.test.ts+ the five metadata parser specs: 114/114 passagainst
mainmerged in.pnpm typecheck(vue-tsc --noEmit) clean on a freshpnpm install.oxfmt --check,oxlint --type-awareandeslintclean on all touched files.readFileAsArrayBuffertoresolve(null)unconditionally fails thethree
assert-guarded tests, confirming they assert behavior rather than onlynarrowing types.
Provenance
Authored by: agent-work loop
Verified:
pnpm exec vitest run src/utils/fileUtil.test.ts src/scripts/metadata(12 files, 114 tests pass),
pnpm typecheckclean,oxfmt --check/oxlint/eslintclean,knipclean via pre-push hook. Mutation-tested the moved test'sassertions as described above.
Deviations: None. The review follow-up (narrowing
bufferwith Vitestassertinstead of a non-null assertion) was applied to all three affectedtests rather than only the two flagged inline, since the
maxBytes: 0case hadthe same weakness via
buffer?.byteLength.