Repository navigation
fix(load3d): invalidate abandoned thumbnail loads (#16485 follow-up) - #16549
christian-byrne wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Comment |
🎭 Playwright: ✅ 1912 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.68 MB gzip 🔴 +372 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • 🔴 +498 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 17 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 225 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T20:42:47.020Z",
"gitSha": "2e5baeaefcc732d4f8f7a32be5a66244e5f35d34",
"branch": "addr-drain/fe16485-thumbnail-timeout-followup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.7699999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.446000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.31200000000007,
"heapDeltaBytes": 11034248,
"heapUsedBytes": 81831120,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.988999999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2006.9579999999974,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.229000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.655,
"heapDeltaBytes": 8658760,
"heapUsedBytes": 78639680,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.587,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.388000000006,
"styleRecalcs": 74,
"styleRecalcDurationMs": 30.695,
"layouts": 14,
"layoutDurationMs": 4.198,
"taskDurationMs": 654.336,
"heapDeltaBytes": 3085608,
"heapUsedBytes": 73812004,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 106.177,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1735.5000000000018,
"styleRecalcs": 73,
"styleRecalcDurationMs": 28.313,
"layouts": 14,
"layoutDurationMs": 4.087,
"taskDurationMs": 627.451,
"heapDeltaBytes": 11102704,
"heapUsedBytes": 80340064,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 104.589,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1660.7070000000022,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.519999999999998,
"layouts": 6,
"layoutDurationMs": 1.048,
"taskDurationMs": 310.082,
"heapDeltaBytes": 4824496,
"heapUsedBytes": 74919556,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.240000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.1280000000434,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.029,
"layouts": 6,
"layoutDurationMs": 1.165,
"taskDurationMs": 246.90800000000002,
"heapDeltaBytes": 5108624,
"heapUsedBytes": 75781036,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.125,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 532.2689999999852,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.246,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.16600000000005,
"heapDeltaBytes": 18475188,
"heapUsedBytes": 87942580,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 119.13399999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 516.0690000000159,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.209999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.94599999999997,
"heapDeltaBytes": 18106116,
"heapUsedBytes": 88102024,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 110.92399999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2020.230999999967,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.673999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.53999999999996,
"heapDeltaBytes": 11489756,
"heapUsedBytes": 87502572,
"domNodes": -267,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 24.917999999999996,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.9340000000166,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.420000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.55199999999996,
"heapDeltaBytes": -15112672,
"heapUsedBytes": 87102392,
"domNodes": -263,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 27.834999999999997,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2258.032999999955,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.398,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1113.5570000000002,
"heapDeltaBytes": 22626300,
"heapUsedBytes": 88418008,
"domNodes": -273,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 539.13,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2141.9930000000136,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.196,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1121.2490000000003,
"heapDeltaBytes": 7704920,
"heapUsedBytes": 84619068,
"domNodes": -269,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 535.449,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3186.3010000000145,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.787999999999997,
"layouts": 60,
"layoutDurationMs": 13.374,
"taskDurationMs": 1173.7009999999998,
"heapDeltaBytes": 8520860,
"heapUsedBytes": 75436312,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 508.3850000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3212.43400000003,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.863000000000003,
"layouts": 60,
"layoutDurationMs": 13.343,
"taskDurationMs": 1202.518,
"heapDeltaBytes": 9537708,
"heapUsedBytes": 76289744,
"domNodes": 8,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 506.749,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2660.807000000034,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.036999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1441.163,
"heapDeltaBytes": 21159504,
"heapUsedBytes": 89005532,
"domNodes": 10,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 691.38,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2314.6130000000085,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.158999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1381.048,
"heapDeltaBytes": 17907964,
"heapUsedBytes": 85632996,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 665.479,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2007.9540000000407,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.758000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.25100000000003,
"heapDeltaBytes": 22203992,
"heapUsedBytes": 87866764,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.688,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2013.0639999999858,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.100999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.62199999999996,
"heapDeltaBytes": 22230212,
"heapUsedBytes": 87798704,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.804000000000002,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 475.83600000001525,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.131,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.852,
"heapDeltaBytes": 14715344,
"heapUsedBytes": 87763104,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 97.08,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 495.4740000000015,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.732999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.911,
"heapDeltaBytes": 14908116,
"heapUsedBytes": 87761256,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 98.133,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.9340000000147,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.346999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.724,
"heapDeltaBytes": -11376504,
"heapUsedBytes": 61451296,
"domNodes": -295,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.388000000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.5519999999851,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.016000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.851,
"heapDeltaBytes": 3376944,
"heapUsedBytes": 75990936,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.804999999999999,
"eventListeners": -224,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.9390000000158,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.282000000000004,
"layouts": 18,
"layoutDurationMs": 6.057999999999999,
"taskDurationMs": 652.6909999999999,
"heapDeltaBytes": -15202724,
"heapUsedBytes": 57605012,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 90.527,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.1350000000366,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.186999999999998,
"layouts": 18,
"layoutDurationMs": 5.063,
"taskDurationMs": 596.811,
"heapDeltaBytes": -11793084,
"heapUsedBytes": 60934668,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 83.733,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 817.6629999999818,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.952999999999996,
"layouts": 16,
"layoutDurationMs": 12.098,
"taskDurationMs": 610.206,
"heapDeltaBytes": 20943224,
"heapUsedBytes": 108650420,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 21.135,
"eventListeners": 2385,
"totalBlockingTimeMs": 71,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9013.736999999992,
"styleRecalcs": 250,
"styleRecalcDurationMs": 44.045,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4293.652000000001,
"heapDeltaBytes": 17196388,
"heapUsedBytes": 93357084,
"domNodes": -265,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 1922.748,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8810.482000000036,
"styleRecalcs": 250,
"styleRecalcDurationMs": 44.655,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4337.1050000000005,
"heapDeltaBytes": -5838656,
"heapUsedBytes": 95143364,
"domNodes": -261,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 1961.0149999999999,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12728.980999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12081.611,
"heapDeltaBytes": -23805972,
"heapUsedBytes": 179032044,
"domNodes": -6548,
"jsHeapTotalBytes": -3321856,
"scriptDurationMs": 179.587,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12797.012999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12200.775,
"heapDeltaBytes": -33396224,
"heapUsedBytes": 177612600,
"domNodes": -6548,
"jsHeapTotalBytes": -258048,
"scriptDurationMs": 194.071,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15035.144000000002,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.91999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14601.84,
"heapDeltaBytes": -46388732,
"heapUsedBytes": 164062448,
"domNodes": -6548,
"jsHeapTotalBytes": -5849088,
"scriptDurationMs": 672.674,
"eventListeners": -7475,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15162.85800000003,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.734999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14733.507000000001,
"heapDeltaBytes": -15094760,
"heapUsedBytes": 174083852,
"domNodes": -6548,
"jsHeapTotalBytes": 11276288,
"scriptDurationMs": 698.965,
"eventListeners": -7469,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4556.521000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.707999999999984,
"layouts": 20,
"layoutDurationMs": 25.001999999999995,
"taskDurationMs": 4460.666,
"heapDeltaBytes": -16578952,
"heapUsedBytes": 172515932,
"domNodes": -6548,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 76.41399999999999,
"eventListeners": -7473,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4465.726000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.93300000000001,
"layouts": 20,
"layoutDurationMs": 23.178000000000004,
"taskDurationMs": 4383.946,
"heapDeltaBytes": -47030340,
"heapUsedBytes": 163944252,
"domNodes": -6576,
"jsHeapTotalBytes": 7127040,
"scriptDurationMs": 72.69200000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6346.96299999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6064.955000000001,
"heapDeltaBytes": 4235096,
"heapUsedBytes": 178449880,
"domNodes": 0,
"jsHeapTotalBytes": -15728640,
"scriptDurationMs": 88.15699999999998,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6408.5549999999785,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6154.454999999999,
"heapDeltaBytes": -6382460,
"heapUsedBytes": 168493300,
"domNodes": -1,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 86.99200000000002,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 444.7169999999687,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.767,
"layouts": 3,
"layoutDurationMs": 1.5389999999999997,
"taskDurationMs": 97.14699999999998,
"heapDeltaBytes": 5008884,
"heapUsedBytes": 73809404,
"domNodes": 149,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.667,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 70.5000000000382,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.684,
"layouts": 1,
"layoutDurationMs": 0.3849999999999999,
"taskDurationMs": 41.523,
"heapDeltaBytes": 3016940,
"heapUsedBytes": 71633068,
"domNodes": 102,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 2.997000000000001,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #16549 +/- ##
==========================================
+ Coverage 81.15% 82.73% +1.57%
==========================================
Files 2460 2042 -418
Lines 126623 119151 -7472
Branches 33739 32433 -1306
==========================================
- Hits 102766 98579 -4187
+ Misses 23341 20391 -2950
+ Partials 516 181 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 421 files with indirect coverage changes 🚀 New features to boost your workflow:
|
352fa09 to
85c9db1
Compare
|
Removed |
|
@coderabbitai review |
|
… render Follow-up to #16485's approve-with-comments review (Cursor 8-reviewer panel, 1 High / 1 Medium / 3 Low findings, none addressed before merge): - High: a timed-out load's finally block called remove() (disposes the model/loader managers) but never bumped LoaderManager.currentLoadId, so the abandoned in-flight load still passed its own staleness guard and called setupModel() on an already-disposed manager — leaking GPU resources and risking a spurious errorLoadingModel toast. Added LoaderManager.invalidate() (bumps currentLoadId) and call it before remove() in the thumbnail module's finally block. - Medium: withTimeout() only wrapped load3d.loadModel(); the dynamic import(), createLoad3d() (allocates a WebGL context), and captureThumbnail() were unbounded. A stall in any of them would wedge the module-global queue for the rest of the session — the exact head-of-line failure this module exists to prevent. Now the whole renderThumbnail body is bounded. - Low: a timeout now reports through reportError() with a stable errorType (agent_crdt... no — load3d_thumbnail_generation_failed) instead of silently degrading to null. - Low (fake timers not restored in the test): verified moot — the project's global Vitest setup already restores real timers automatically (oxlint's no-redundant-vitest-cleanup rule confirms this). - Nit (es-toolkit's withTimeout leaves a pending setTimeout on the winning race branch): upstream library behavior, out of scope for this repo; left as-is per the original reviewer's own 'non-blocking' call. New regression test pins invalidate() running before remove() and proves an abandoned load can no longer reach captureThumbnail after timeout. Quality gates: focused Vitest 6/6, vue-tsc clean, eslint clean, oxlint clean, oxfmt clean, knip clean.
85c9db1 to
ec3e2ea
Compare
|
Rebased onto current Full context for agent readers
|
|
|
Resolves four conflicts introduced since the previous main sync. modelThumbnail.ts / modelThumbnail.test.ts: take main. This branch's hand-rolled Promise.race + clearTimeout guard (8f47af8) was superseded by withTimeout(..., 15_000) shipped on main in Comfy-Org#16485, which also disposes the renderer and recovers the queue. Keeping the branch version would fork a file that open PR Comfy-Org#16549 is already hardening further. Run-mode surface: restore from main. Commits 228ed53 and 30df47e removed RunModePopover.vue, agentRunModeStore.ts and their specs on the premise that run-mode control was dead code. That premise no longer holds: main still renders RunModePopover from Composer.vue, Comfy-Org#16383 landed seven popover behavior tests, and open PR Comfy-Org#16432 persists run mode through the agent API. Deleting a live user-facing surface is out of scope for a renderer/composer hardening PR, so the deletion is reverted and main's suite is taken verbatim. The branch's own improvement to the submitting-Stop test is kept. Verified: 1006/1006 tests across src/workbench/extensions/agent and src/components/load3d, vue-tsc --noEmit clean, scoped ESLint clean, oxfmt clean.
christian-byrne
left a comment
There was a problem hiding this comment.
One non-blocking note on the timer lifetime, surfaced while resolving a conflict on #16385 over this same file.
| load3d.remove() | ||
| } | ||
| } catch { | ||
| }, MODEL_LOAD_TIMEOUT_MS) |
There was a problem hiding this comment.
suggestion: (non-blocking) withTimeout here is called without a signal, and es-toolkit's timeout(ms) only clears its setTimeout on abort. When run() wins the race the timer stays armed for the full MODEL_LOAD_TIMEOUT_MS. Nothing rejects visibly, since the settled Promise.race swallows the later TimeoutError, but widening the wrapper to cover the whole render means every successful thumbnail now leaves a 15s timer behind, and a bulk asset import queues one per model. Would it be cleaner to pass a controller and abort it in the existing finally, next to getLoaderManager().invalidate()?
const timeoutController = new AbortController()
try {
return await withTimeout(async () => { /* ... */ }, MODEL_LOAD_TIMEOUT_MS, {
signal: timeoutController.signal
})
} catch (error) {
// ...
} finally {
timeoutController.abort()
holder.current?.getLoaderManager().invalidate()
holder.current?.remove()
}Aborting after the race has already settled is safe in both directions: on the timeout path abortHandler calls clearTimeout on an already-fired timer, and on the success path it cancels the pending one. It should not disturb the fake-timer regression, which advances past the deadline before the abort runs.
…umbnail-timeout-followup
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Green at Full context for agent readersThe previous head was 129 commits behind. Its two failing jobs both reported the same shared VideoHelperSuite S3 save/reload contract failure seen across unrelated PRs. Current Exact-head evidence: 76 successful checks, 12 skipped checks, zero failures, and zero pending checks. The merge commit's second parent is current base |
Summary
Follow-up to #16485 (
fix(load3d): recover thumbnail queue after stuck model load), approved by @CodeJuggernaut with comments. The PR merged before its Cursor multi-reviewer panel findings (1 High, 1 Medium, 3 Low, 1 Nit — 8/8 reviewers) were addressed.Items addressed
LoaderManagerstaleness guard, leaks GPU resources (comment)LoaderManager.invalidate(), called beforeload3d.remove()on timeoutloadModelbounded;import()/createLoad3d()/captureThumbnail()unbounded (comment)withTimeoutnow wraps the wholerenderThumbnailbodyTimeoutErrorsilently degrades tonull(comment)reportError()witherrorType: load3d_thumbnail_generation_failedvi.useFakeTimers()never restored in test (comment)no-redundant-vitest-cleanuprule)setupModelrisk (comment)invalidate()→remove()ordering and assertscaptureThumbnailnever fires after timeoutwithTimeout's losingsetTimeoutisn't cleared (comment)es-toolkitbehavior, out of scope here; original reviewer already called it non-blockingVerification
vue-tsc --noEmit: cleaneslint/oxlint(incl. type-aware, pre-commit hook): cleanoxfmt --check: cleanknip: clean