Repository navigation
test: follow-up to #16378 — colocate R-78 collision characterization - #16548
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe PR adds a fixed-input regression test for two colliding workflow paths. It verifies their shared key and replacement behavior. It removes the previous property test and an unused import. ChangesDraft cache collision coverage
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 2063 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.95 MB gzip 🟢 -232 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • 🟢 -52 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 228 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T11:59:17.583Z",
"gitSha": "7d53a8260e8ed38c03db9e44df11186809621da7",
"branch": "r78-cache-followup-16378",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2004.8719999999776,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.5450000000001,
"heapDeltaBytes": 17161080,
"heapUsedBytes": 79110912,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.6659999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2009.3070000000353,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.163,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.5540000000001,
"heapDeltaBytes": 17960140,
"heapUsedBytes": 78807212,
"domNodes": -263,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 11.242000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1907.1430000000191,
"styleRecalcs": 80,
"styleRecalcDurationMs": 29.649,
"layouts": 14,
"layoutDurationMs": 4.519,
"taskDurationMs": 940.087,
"heapDeltaBytes": 19819116,
"heapUsedBytes": 80833152,
"domNodes": -264,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 183.981,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1836.5549999999757,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.784000000000002,
"layouts": 14,
"layoutDurationMs": 3.8589999999999995,
"taskDurationMs": 848.96,
"heapDeltaBytes": 14626652,
"heapUsedBytes": 76769320,
"domNodes": -264,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 163.65400000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.4820000000323,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.316999999999997,
"layouts": 6,
"layoutDurationMs": 1.1430000000000002,
"taskDurationMs": 342.88300000000004,
"heapDeltaBytes": 2105436,
"heapUsedBytes": 64397764,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.24,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.0049999999674,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.933999999999997,
"layouts": 6,
"layoutDurationMs": 1.307,
"taskDurationMs": 357.787,
"heapDeltaBytes": 2335912,
"heapUsedBytes": 63612228,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.849,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 603.6119999999983,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.035999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.98299999999995,
"heapDeltaBytes": 18747236,
"heapUsedBytes": 79505460,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 165.42800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 625.1059999999597,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.486,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.107,
"heapDeltaBytes": 18647372,
"heapUsedBytes": 80390680,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 171.199,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2036.137999999994,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.05,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.7189999999999,
"heapDeltaBytes": 2232172,
"heapUsedBytes": 83420012,
"domNodes": -251,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 41.132000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2022.096999999917,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.522000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.5639999999999,
"heapDeltaBytes": 3789196,
"heapUsedBytes": 83249876,
"domNodes": -248,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 31.488000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2279.548000000034,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.770999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1630.868,
"heapDeltaBytes": 15760660,
"heapUsedBytes": 80161696,
"domNodes": -256,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 849.966,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2396.566000000007,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.75,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1677.2830000000001,
"heapDeltaBytes": 15385208,
"heapUsedBytes": 80289480,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 883.24,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3533.510999999976,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.966000000000003,
"layouts": 60,
"layoutDurationMs": 13.006,
"taskDurationMs": 1675.735,
"heapDeltaBytes": 9684444,
"heapUsedBytes": 74796120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 788.9010000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3516.785000000027,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.437999999999999,
"layouts": 60,
"layoutDurationMs": 12.836,
"taskDurationMs": 1691.824,
"heapDeltaBytes": 8507532,
"heapUsedBytes": 74350368,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 790.2739999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3111.082999999951,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.705999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1856.1360000000002,
"heapDeltaBytes": 17472176,
"heapUsedBytes": 83486488,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 971.5500000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3136.608000000024,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.326000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1937.0219999999997,
"heapDeltaBytes": 23194968,
"heapUsedBytes": 89173644,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 999.43,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2002.646000000027,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.3850000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.9919999999998,
"heapDeltaBytes": 20592176,
"heapUsedBytes": 84397392,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.429,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2031.0430000000679,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.712000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.485,
"heapDeltaBytes": -4522628,
"heapUsedBytes": 83921968,
"domNodes": -251,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 42.72899999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.0260000000035,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.767000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.455,
"heapDeltaBytes": 14202048,
"heapUsedBytes": 77353428,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.707,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.5289999999941,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.69,
"heapDeltaBytes": 13833292,
"heapUsedBytes": 77155664,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 144.703,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.8600000000079,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.199000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.427,
"heapDeltaBytes": 8478048,
"heapUsedBytes": 72045132,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.544000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1998.5070000000178,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.163000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.079,
"heapDeltaBytes": 17566896,
"heapUsedBytes": 81073088,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.187000000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.3889999999933,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.523,
"layouts": 18,
"layoutDurationMs": 4.895999999999999,
"taskDurationMs": 815.596,
"heapDeltaBytes": 651344,
"heapUsedBytes": 64177400,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 110.00999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.6140000000114,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.841,
"layouts": 18,
"layoutDurationMs": 5.184,
"taskDurationMs": 780.6599999999999,
"heapDeltaBytes": 16076244,
"heapUsedBytes": 79621432,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 109.056,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1398.8499999999249,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.460000000000008,
"layouts": 5,
"layoutDurationMs": 13.324,
"taskDurationMs": 940.884,
"heapDeltaBytes": -6495916,
"heapUsedBytes": 81358424,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 32.876999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8415.594,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.199000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5773.414,
"heapDeltaBytes": 16693520,
"heapUsedBytes": 80012004,
"domNodes": -250,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 2768.716,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8528.177999999913,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.16,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5999.429999999999,
"heapDeltaBytes": -4825976,
"heapUsedBytes": 76359252,
"domNodes": -250,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 2839.5480000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16807.469999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16478.599,
"heapDeltaBytes": -23811628,
"heapUsedBytes": 190759736,
"domNodes": -8061,
"jsHeapTotalBytes": -13901824,
"scriptDurationMs": 254.84799999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17222.34400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16841.014,
"heapDeltaBytes": -64432068,
"heapUsedBytes": 174257908,
"domNodes": -8061,
"jsHeapTotalBytes": -7610368,
"scriptDurationMs": 272.19,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20437.16599999999,
"styleRecalcs": 148,
"styleRecalcDurationMs": 18.287000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20246.86,
"heapDeltaBytes": -51454080,
"heapUsedBytes": 179260980,
"domNodes": -8061,
"jsHeapTotalBytes": -13438976,
"scriptDurationMs": 916.872,
"eventListeners": -14928,
"totalBlockingTimeMs": 95,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20446.93499999994,
"styleRecalcs": 163,
"styleRecalcDurationMs": 18.126000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20151.873,
"heapDeltaBytes": -40543160,
"heapUsedBytes": 168099652,
"domNodes": -8061,
"jsHeapTotalBytes": -13148160,
"scriptDurationMs": 924.183,
"eventListeners": -14928,
"totalBlockingTimeMs": 151,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6091.902000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.978,
"layouts": 20,
"layoutDurationMs": 23.578000000000003,
"taskDurationMs": 6029.586,
"heapDeltaBytes": -18040356,
"heapUsedBytes": 196962744,
"domNodes": -8061,
"jsHeapTotalBytes": 16437248,
"scriptDurationMs": 108.88099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 371,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6040.766000000076,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.44100000000002,
"layouts": 20,
"layoutDurationMs": 23.315,
"taskDurationMs": 5991.037,
"heapDeltaBytes": -50428056,
"heapUsedBytes": 181675140,
"domNodes": -8061,
"jsHeapTotalBytes": 15618048,
"scriptDurationMs": 109.10999999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 393,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8490.197999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8334.005,
"heapDeltaBytes": 8354824,
"heapUsedBytes": 184542500,
"domNodes": 0,
"jsHeapTotalBytes": -9699328,
"scriptDurationMs": 131.19100000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8352.035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8006.271,
"heapDeltaBytes": 32064776,
"heapUsedBytes": 189805932,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 120.79200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 103.80799999995816,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.598999999999998,
"layouts": 2,
"layoutDurationMs": 1.1159999999999999,
"taskDurationMs": 84.786,
"heapDeltaBytes": 3178520,
"heapUsedBytes": 64917220,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.388,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 104.06100000000151,
"styleRecalcs": 9,
"styleRecalcDurationMs": 19.720000000000002,
"layouts": 3,
"layoutDurationMs": 1.4949999999999999,
"taskDurationMs": 76.61299999999999,
"heapDeltaBytes": 3018052,
"heapUsedBytes": 64760944,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.85,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since dad05c594f8a77b4e31c502b84621b736bb418c3
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16548 +/- ##
==========================================
+ Coverage 82.93% 83.91% +0.97%
==========================================
Files 2956 2260 -696
Lines 145561 128536 -17025
Branches 37498 35497 -2001
==========================================
- Hits 120727 107863 -12864
+ Misses 23564 20383 -3181
+ Partials 1270 290 -980
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
eb8f765 to
625f07a
Compare
|
Removed |
|
placeholder |
|
@coderabbitai review |
|
Follow-up to #16378 — CodeJuggernaut approved with a non-blocking test-placement note: the R-78 collision-aliasing characterization test is a fixed-input regression, not a property, so it belongs in its own file rather than draftCacheV2.property.test.ts. Moves it to draftCacheV2.collision.test.ts, matching the alternative naming already given in the originating todo row (r78-cache-1).
625f07a to
5585a2f
Compare
|
Rebased onto current Full context for agent readersGit recognized the 26 intervening commits as already applied and replayed only the R-78 test-colocation change. The refreshed commit is Verification:
|
|
@coderabbitai review |
|
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Base drift refreshed; branch Actions are green. Full context for agent readersMerged current Evidence:
|
|
Brought this up to current For a characterization test the thing worth checking is whether it still characterizes anything, since the moment the behaviour it pins gets fixed the test quietly becomes a false statement rather than a failing one. R-78 is still live: widening the draft key in That also means the reverse is worth stating for whoever eventually closes R-78: this test is expected to go red when the collision is fixed, and should be flipped to assert the two paths stay distinct rather than deleted. Verified: persistence suite 12 files / 162 passed / 1 expected-fail, |
dante01yoon
left a comment
There was a problem hiding this comment.
Approving. This is a behaviour-preserving move and I verified the parts that a pure relocation can still get wrong.
What I checked:
- The move is faithful. The block added to
draftCacheV2.collision.test.tsis character-identical to the one removed fromdraftCacheV2.property.test.ts, apart from two added comment lines explaining the relocation. Same paths, same metadata, same three assertions. - The import cleanup is correct.
getEntryByPathis dropped from the property file's import list; at this head there is no remaining reference to it in that file, so the narrowed import cannot breaktypecheck. The remaining eight tests there are all genuinefc.assertproperties, so the file now matches its name. - The collision is real, not stale. I ran the
fnv1a/hashPathimplementation fromhashUtil.tsat this head directly:workflows/ewip.jsonandworkflows/4hbab.jsonboth hash to684dbc71. Combined withupsertEntrykeying onhashPath(path)andgetEntryByPathre-hashing to look up, all three assertions follow —ordercollapses to one key, one entry survives, and theewiplookup returnsdraft-bat pathworkflows/4hbab.json. The characterization still characterizes something. - The new filename is picked up.
vite.config.mtsincludessrc/**/*.{test,spec}.{...,ts,...}, which matchesdraftCacheV2.collision.test.ts, so the test does not silently stop running by being renamed out of the old file. - Checks. Re-fetched at
3bfd9a2: no failing checks; everything ispassorskipping.mergeStateStatusisBLOCKEDonly for want of an approving review.
One non-blocking suggestion inline about matching the it.fails idiom the sibling test already uses. Nothing blocking.
| import { createEmptyIndex, getEntryByPath, upsertEntry } from './draftCacheV2' | ||
|
|
||
| describe('R-78 draft cache collision aliasing', () => { | ||
| it('characterizes R-78 draft cache aliasing for known colliding paths', () => { |
There was a problem hiding this comment.
suggestion (non-blocking): hashUtil.test.ts:66 already pins this exact collision, but with the opposite idiom:
it.fails('produces different hashes for known collision paths', () => {
const hash1 = hashPath('workflows/ewip.json')
const hash2 = hashPath('workflows/4hbab.json')
expect(hash1).not.toBe(hash2)
})That one asserts the desired behaviour and marks it expected-fail; this one asserts the buggy behaviour under a plain it. Both go red when R-78 is fixed, so this is not a correctness problem — the two layers are complementary coverage (hash-level collision vs. cache-level aliasing) and I would not want to lose either.
The difference is what a reader concludes without the R-78 context. expect(index.order).toEqual(['684dbc71']) reads as though collapsing two distinct drafts into one entry were the intended contract, and the reason it is not lives in your PR comment ("should be flipped to assert the two paths stay distinct rather than deleted") rather than in the file. Writing it as it.fails with the positive assertion — order has two keys, two entries, ewip still resolves to draft-a — would put that instruction in the test itself and match the sibling.
Entirely your call; the current form is correct and the comment above the assertions does explain the collision. Raising it because the fix-time ergonomics differ and the two tests sit one directory apart.
There was a problem hiding this comment.
Tracked as FE-2596. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
Summary
Follow-up to #16378. Addresses the non-blocking test-placement note from CodeJuggernaut's approval: the R-78 draft-cache collision characterization (comment) is a fixed-input regression, not a property-based test, so it did not belong in
draftCacheV2.property.test.ts.Moves it into its own
draftCacheV2.collision.test.ts, matching the alternative naming already given in the originating todo row for this work (r78-cache-1: "...or a newdraftCacheV2.collision.test.tscolocated alongside").No behavior change — same assertions, same known colliding pair (
workflows/ewip.json/workflows/4hbab.json->684dbc71).Verification
pnpm test:unit src/platform/workflow/persistence/base/draftCacheV2.property.test.ts src/platform/workflow/persistence/base/draftCacheV2.collision.test.ts-> 2 files, 9 tests passedpnpm exec oxfmt --check-> passedpnpm typecheck-> passedpnpm exec eslint-> passed