Repository navigation
fix(load3d): recover thumbnail queue after stuck model load - #16485
Conversation
Addresses review feedback: #16406 (comment)
|
Warning Review limit reachedNext included review available in 14 seconds. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head self-review at 91702cb880d15485edfdd0ed757fbb778009fcad: the diff is limited to the loadModel timeout boundary and its queue-recovery regression. Verified focused Vitest 5/5, targeted ESLint, oxfmt, full typecheck, commit hooks, pre-push Knip, and git diff --check; no additional findings.
|
@coderabbitai review |
|
🎭 Playwright: ✅ 1893 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.67 MB gzip 🟢 -133 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.58 MB (baseline 3.58 MB) • 🟢 -1.44 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 17 added / 17 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BBundles that do not match a named category
Status: 70 added / 70 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-01T09:36:03.915Z",
"gitSha": "40edb06b2e386fde08e3934dae949406f9031feb",
"branch": "christian-byrne/fix-load3d-thumbnail-timeout",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2113.9760000000365,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.498000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.6539999999999,
"heapDeltaBytes": -13539972,
"heapUsedBytes": 56694188,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.515000000000004,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2058.3859999999277,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.908,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 618.391,
"heapDeltaBytes": 8982276,
"heapUsedBytes": 72851408,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.815,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1943.4269999999856,
"styleRecalcs": 78,
"styleRecalcDurationMs": 47.68899999999999,
"layouts": 14,
"layoutDurationMs": 5.261,
"taskDurationMs": 994.234,
"heapDeltaBytes": 8001236,
"heapUsedBytes": 71102040,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 161.811,
"eventListeners": -189,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1952.2380000000794,
"styleRecalcs": 78,
"styleRecalcDurationMs": 48.550999999999995,
"layouts": 14,
"layoutDurationMs": 5.216,
"taskDurationMs": 1012.283,
"heapDeltaBytes": -7596580,
"heapUsedBytes": 62146408,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 162.58700000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1748.7740000000258,
"styleRecalcs": 30,
"styleRecalcDurationMs": 19.638999999999996,
"layouts": 6,
"layoutDurationMs": 1.2479999999999998,
"taskDurationMs": 422.087,
"heapDeltaBytes": 4452664,
"heapUsedBytes": 74542956,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 15.264999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.2630000000554,
"styleRecalcs": 30,
"styleRecalcDurationMs": 21.316999999999997,
"layouts": 6,
"layoutDurationMs": 1.476,
"taskDurationMs": 460.218,
"heapDeltaBytes": 4372508,
"heapUsedBytes": 74199312,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 17.022,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 737.0070000000055,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.370000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.862,
"heapDeltaBytes": 18706080,
"heapUsedBytes": 81445116,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 171.186,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 727.4290000000292,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.98,
"heapDeltaBytes": 17805748,
"heapUsedBytes": 87821908,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 163.83700000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2064.7539999999935,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.6120000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.653,
"heapDeltaBytes": -12901752,
"heapUsedBytes": 87137704,
"domNodes": -270,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 42.950999999999986,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2057.9110000001037,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.864000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 734.9800000000001,
"heapDeltaBytes": -13895348,
"heapUsedBytes": 86537324,
"domNodes": -273,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 38.623999999999995,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2348.9420000000223,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.665999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1654.412,
"heapDeltaBytes": 22570480,
"heapUsedBytes": 88047628,
"domNodes": -277,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 796.778,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2355.2799999999934,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.911999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1700.9850000000001,
"heapDeltaBytes": 23195600,
"heapUsedBytes": 88492812,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 796.736,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3741.2570000000187,
"styleRecalcs": 60,
"styleRecalcDurationMs": 12.318,
"layouts": 60,
"layoutDurationMs": 14.956,
"taskDurationMs": 1848.9079999999997,
"heapDeltaBytes": 8066152,
"heapUsedBytes": 75704352,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 827.221,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3817.3719999999776,
"styleRecalcs": 60,
"styleRecalcDurationMs": 12.468999999999998,
"layouts": 60,
"layoutDurationMs": 15.116,
"taskDurationMs": 1875.591,
"heapDeltaBytes": 8451096,
"heapUsedBytes": 75694548,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 817.501,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3200.9499999999775,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.0180000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2073.424,
"heapDeltaBytes": 26486888,
"heapUsedBytes": 94109420,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1048.7450000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3146.6749999999593,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.360999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2080.3700000000003,
"heapDeltaBytes": 25637232,
"heapUsedBytes": 93293192,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1023.3780000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.159999999967,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.5260000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.244,
"heapDeltaBytes": -14770956,
"heapUsedBytes": 87068408,
"domNodes": -274,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 43.285999999999994,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2051.592000000028,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.219999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 815.93,
"heapDeltaBytes": 10544260,
"heapUsedBytes": 86321656,
"domNodes": -270,
"jsHeapTotalBytes": -2179072,
"scriptDurationMs": 40.238,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 667.2810000000027,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.395,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.241,
"heapDeltaBytes": 14026384,
"heapUsedBytes": 85974572,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.02599999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 682.6659999999265,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.632,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.484,
"heapDeltaBytes": 14051868,
"heapUsedBytes": 85897428,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.68800000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2055.496000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.439999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.1659999999999,
"heapDeltaBytes": -6250648,
"heapUsedBytes": 65706736,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.558000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2035.7609999999795,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.123000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.33,
"heapDeltaBytes": -11329088,
"heapUsedBytes": 60867680,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 11.912000000000003,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1737.3550000000364,
"styleRecalcs": 78,
"styleRecalcDurationMs": 40.736,
"layouts": 18,
"layoutDurationMs": 5.9590000000000005,
"taskDurationMs": 899.736,
"heapDeltaBytes": -11144144,
"heapUsedBytes": 61199816,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 117.2,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1791.66500000008,
"styleRecalcs": 79,
"styleRecalcDurationMs": 49.09400000000001,
"layouts": 18,
"layoutDurationMs": 6.532,
"taskDurationMs": 956.998,
"heapDeltaBytes": -11360412,
"heapUsedBytes": 60622836,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 121.42800000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1432.7029999999468,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.087,
"layouts": 15,
"layoutDurationMs": 15.767,
"taskDurationMs": 1062.6100000000004,
"heapDeltaBytes": -7407420,
"heapUsedBytes": 86239952,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 36.782999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8810.515000000067,
"styleRecalcs": 247,
"styleRecalcDurationMs": 43.746,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6139.36,
"heapDeltaBytes": 9527204,
"heapUsedBytes": 84494520,
"domNodes": -271,
"jsHeapTotalBytes": 897024,
"scriptDurationMs": 2712.947,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8930.055000000038,
"styleRecalcs": 246,
"styleRecalcDurationMs": 43.44100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6292.882,
"heapDeltaBytes": -15856056,
"heapUsedBytes": 84471324,
"domNodes": -271,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2750.257,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18961.87599999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18798.710999999996,
"heapDeltaBytes": -28716992,
"heapUsedBytes": 180855052,
"domNodes": -6548,
"jsHeapTotalBytes": -126976,
"scriptDurationMs": 336.065,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19389.20399999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19160.711999999996,
"heapDeltaBytes": -29396000,
"heapUsedBytes": 180475336,
"domNodes": -6548,
"jsHeapTotalBytes": -126976,
"scriptDurationMs": 338.015,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 24421.36000000005,
"styleRecalcs": 182,
"styleRecalcDurationMs": 28.42,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24316.662,
"heapDeltaBytes": -26610600,
"heapUsedBytes": 176321908,
"domNodes": -6548,
"jsHeapTotalBytes": 2641920,
"scriptDurationMs": 1037.026,
"eventListeners": -7427,
"totalBlockingTimeMs": 164,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 24403.193999999985,
"styleRecalcs": 182,
"styleRecalcDurationMs": 29.825999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24251.667,
"heapDeltaBytes": -18782684,
"heapUsedBytes": 189987668,
"domNodes": -6548,
"jsHeapTotalBytes": -5251072,
"scriptDurationMs": 1035.413,
"eventListeners": -7469,
"totalBlockingTimeMs": 242,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-node-resize-workload",
"durationMs": 6828.206000000023,
"styleRecalcs": 20,
"styleRecalcDurationMs": 90.75,
"layouts": 20,
"layoutDurationMs": 38.992,
"taskDurationMs": 6769.646999999999,
"heapDeltaBytes": -47724460,
"heapUsedBytes": 161099820,
"domNodes": -6548,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 178.10500000000002,
"eventListeners": -7471,
"totalBlockingTimeMs": 590,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6975.174000000038,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.54900000000004,
"layouts": 20,
"layoutDurationMs": 30.482999999999983,
"taskDurationMs": 6947.672,
"heapDeltaBytes": -34239924,
"heapUsedBytes": 175745284,
"domNodes": -6548,
"jsHeapTotalBytes": 6950912,
"scriptDurationMs": 136.106,
"eventListeners": -7469,
"totalBlockingTimeMs": 738,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 125.96300000006977,
"styleRecalcs": 9,
"styleRecalcDurationMs": 22.191000000000003,
"layouts": 3,
"layoutDurationMs": 1.055,
"taskDurationMs": 94.48700000000001,
"heapDeltaBytes": 3258204,
"heapUsedBytes": 71377916,
"domNodes": 115,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.848,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 492.3780000001443,
"styleRecalcs": 16,
"styleRecalcDurationMs": 22.606,
"layouts": 3,
"layoutDurationMs": 1.7049999999999998,
"taskDurationMs": 134.40699999999998,
"heapDeltaBytes": 5176676,
"heapUsedBytes": 72760312,
"domNodes": 146,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.678,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16485 +/- ##
==========================================
+ Coverage 80.35% 82.23% +1.88%
==========================================
Files 2407 2017 -390
Lines 123277 116507 -6770
Branches 30770 29229 -1541
==========================================
- Hits 99058 95809 -3249
+ Misses 23794 20523 -3271
+ Partials 425 175 -250
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 400 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Fix verified at source and the new test is meaningful; one timer-cleanup nit below. Severity: Note What: Why this is an issue: No-op today because it is the file's last test and Vitest isolates files; it stops being one the moment anyone appends a test below - that test silently inherits fake timers. Proposed Fix: Add |
|
Cursor review is running on the exact PR head.
Full context for agent readersThe 15-minute pacing window had elapsed, and the first attempted candidate, FE #16495, was correctly rejected by the workflow because its head is on a fork. FE #16485 was then refreshed live at head Added |
|
Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 1 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| }) | ||
| try { | ||
| await load3d.loadModel(modelUrl) | ||
| await withTimeout(() => load3d.loadModel(modelUrl), MODEL_LOAD_TIMEOUT_MS) |
There was a problem hiding this comment.
🟠 High — withTimeout only rejects the wrapper — it cannot cancel load3d.loadModel, which takes no AbortSignal — so on timeout the finally block runs load3d.remove() while the load is still fetching/parsing; since remove() never bumps currentLoadId, the abandoned load later passes LoaderManager's own staleness guard and calls modelManager.setupModel() on already-disposed managers, leaking model/GPU resources and possibly raising the errorLoadingModel toast for a thumbnail the caller already gave up on. It also breaks the single-flight bound this module documents: the queue advances every 15s while each abandoned load keeps downloading, so a directory of large or slow-serving models accumulates unbounded concurrent in-flight loads. Invalidate the load (bump the load id, or plumb an AbortSignal through loadModel) instead of merely abandoning it. Raised by 8 of 8 reviewers (gpt-5.6-sol-max adversarial and edge-case, claude-opus-5-thinking-max adversarial and edge-case, gemini-3.1-pro adversarial and edge-case, kimi-k3-max adversarial and edge-case).
| try { | ||
| await load3d.loadModel(modelUrl) | ||
| await withTimeout(() => load3d.loadModel(modelUrl), MODEL_LOAD_TIMEOUT_MS) | ||
| const dataUrl = await load3d.captureThumbnail(256, 256) |
There was a problem hiding this comment.
🟡 Medium — Only loadModel is bounded; the dynamic import(), createLoad3d() (which allocates a WebGL context) and captureThumbnail() are still unbounded awaits. Because queue is module-global and never reset, a stall in any of them wedges the chain permanently and every later generateModelThumbnail call stays pending for the rest of the session — the exact head-of-line failure this change sets out to fix. Consider wrapping the whole renderThumbnail body in the timeout rather than just the load step. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case, kimi-k3-max adversarial, claude-opus-5-thinking-max adversarial).
| await withTimeout(() => load3d.loadModel(modelUrl), MODEL_LOAD_TIMEOUT_MS) | ||
| const dataUrl = await load3d.captureThumbnail(256, 256) | ||
| if (isAssetPreviewSupported()) { | ||
| void fetch(dataUrl) |
There was a problem hiding this comment.
🟢 Low — The new TimeoutError falls into the blanket catch { return null } below (line 51), so a 15s stall is indistinguishable from an unsupported or corrupt model. A systemically slow asset backend or oversized models would silently degrade every thumbnail to null with nothing in Sentry/RUM; per src/AGENTS.md route this through reportError() with a stable errorType. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial).
| }) | ||
|
|
||
| it('times out a stuck load, disposes it, and advances the queue', async () => { | ||
| vi.useFakeTimers() |
There was a problem hiding this comment.
🟢 Low — vi.useFakeTimers() is never restored — the file has no afterEach(() => vi.useRealTimers()) and beforeEach only resets mocks. This passes today only because it is the last test in the file; any test appended after it, or a shuffled run, would silently inherit fake timers and hang on the vi.waitFor in the persistence test. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| it('times out a stuck load, disposes it, and advances the queue', async () => { | ||
| vi.useFakeTimers() | ||
| const stuck = mockInstance({ | ||
| loadModel: vi.fn(() => new Promise<void>(() => {})) |
There was a problem hiding this comment.
🟢 Low — Mocking the stuck loadModel with a promise that never settles means the test cannot exercise what actually happens after a timeout: the abandoned load resuming into setupModel/setupModelAnimations/handleResize on an instance that remove() already disposed. Asserting stuck.remove was called locks in disposal-while-loading as the expected behaviour; a mock that resolves shortly after the 15s advance would cover where the real risk lives. Raised by 2 of 8 reviewers (gemini-3.1-pro adversarial, claude-opus-5-thinking-max adversarial).
| @@ -1,9 +1,12 @@ | |||
| import { withTimeout } from 'es-toolkit' | |||
There was a problem hiding this comment.
⚪ Nit — es-toolkit's withTimeout is Promise.race([run(), timeout(ms)]) and never clears the underlying setTimeout when run() wins the race, so every successful thumbnail leaves a 15s timer pending after the function has already resolved. Harmless in the browser but needless retained work across a long queue, and it can surprise tests that assert on pending timers. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Approving - the fix is verified at source (finally-guaranteed disposal, queue advance) and the test is meaningful; the timer-cleanup note is a nit.
|
Approve-with-comments follow-up: #16549 addresses the 5 actionable review findings (1 High resource-leak, 1 Medium timeout-scope gap, 3 Low) from the Cursor multi-reviewer panel that were outstanding at merge. The remaining Nit (es-toolkit's |
## Summary Bounds thumbnail model loading so a stuck renderer is disposed and later queued thumbnails can continue. ## Changes - **What**: Wraps `load3d.loadModel()` in a 15-second timeout and adds an executable fake-timer regression for disposal and queue advancement. ## Review Focus Please verify the timeout duration and that the queue recovery semantics remain appropriate for slow models. Fixes #16471 ## Screenshots (if applicable) Not applicable; behavior is covered by a unit regression.
… render Follow-up to #16485's approve-with-comments review (Cursor 8-reviewer panel, 1 High / 1 Medium / 3 Low findings, none addressed before merge): - High: a timed-out load's finally block called remove() (disposes the model/loader managers) but never bumped LoaderManager.currentLoadId, so the abandoned in-flight load still passed its own staleness guard and called setupModel() on an already-disposed manager — leaking GPU resources and risking a spurious errorLoadingModel toast. Added LoaderManager.invalidate() (bumps currentLoadId) and call it before remove() in the thumbnail module's finally block. - Medium: withTimeout() only wrapped load3d.loadModel(); the dynamic import(), createLoad3d() (allocates a WebGL context), and captureThumbnail() were unbounded. A stall in any of them would wedge the module-global queue for the rest of the session — the exact head-of-line failure this module exists to prevent. Now the whole renderThumbnail body is bounded. - Low: a timeout now reports through reportError() with a stable errorType (agent_crdt... no — load3d_thumbnail_generation_failed) instead of silently degrading to null. - Low (fake timers not restored in the test): verified moot — the project's global Vitest setup already restores real timers automatically (oxlint's no-redundant-vitest-cleanup rule confirms this). - Nit (es-toolkit's withTimeout leaves a pending setTimeout on the winning race branch): upstream library behavior, out of scope for this repo; left as-is per the original reviewer's own 'non-blocking' call. New regression test pins invalidate() running before remove() and proves an abandoned load can no longer reach captureThumbnail after timeout. Quality gates: focused Vitest 6/6, vue-tsc clean, eslint clean, oxlint clean, oxfmt clean, knip clean.
…yrne/w3pub-reply-assets
… render Follow-up to #16485's approve-with-comments review (Cursor 8-reviewer panel, 1 High / 1 Medium / 3 Low findings, none addressed before merge): - High: a timed-out load's finally block called remove() (disposes the model/loader managers) but never bumped LoaderManager.currentLoadId, so the abandoned in-flight load still passed its own staleness guard and called setupModel() on an already-disposed manager — leaking GPU resources and risking a spurious errorLoadingModel toast. Added LoaderManager.invalidate() (bumps currentLoadId) and call it before remove() in the thumbnail module's finally block. - Medium: withTimeout() only wrapped load3d.loadModel(); the dynamic import(), createLoad3d() (allocates a WebGL context), and captureThumbnail() were unbounded. A stall in any of them would wedge the module-global queue for the rest of the session — the exact head-of-line failure this module exists to prevent. Now the whole renderThumbnail body is bounded. - Low: a timeout now reports through reportError() with a stable errorType (agent_crdt... no — load3d_thumbnail_generation_failed) instead of silently degrading to null. - Low (fake timers not restored in the test): verified moot — the project's global Vitest setup already restores real timers automatically (oxlint's no-redundant-vitest-cleanup rule confirms this). - Nit (es-toolkit's withTimeout leaves a pending setTimeout on the winning race branch): upstream library behavior, out of scope for this repo; left as-is per the original reviewer's own 'non-blocking' call. New regression test pins invalidate() running before remove() and proves an abandoned load can no longer reach captureThumbnail after timeout. Quality gates: focused Vitest 6/6, vue-tsc clean, eslint clean, oxlint clean, oxfmt clean, knip clean.
Resolves four conflicts introduced since the previous main sync. modelThumbnail.ts / modelThumbnail.test.ts: take main. This branch's hand-rolled Promise.race + clearTimeout guard (8f47af8) was superseded by withTimeout(..., 15_000) shipped on main in Comfy-Org#16485, which also disposes the renderer and recovers the queue. Keeping the branch version would fork a file that open PR Comfy-Org#16549 is already hardening further. Run-mode surface: restore from main. Commits 228ed53 and 30df47e removed RunModePopover.vue, agentRunModeStore.ts and their specs on the premise that run-mode control was dead code. That premise no longer holds: main still renders RunModePopover from Composer.vue, Comfy-Org#16383 landed seven popover behavior tests, and open PR Comfy-Org#16432 persists run mode through the agent API. Deleting a live user-facing surface is out of scope for a renderer/composer hardening PR, so the deletion is reverted and main's suite is taken verbatim. The branch's own improvement to the submitting-Stop test is kept. Verified: 1006/1006 tests across src/workbench/extensions/agent and src/components/load3d, vue-tsc --noEmit clean, scoped ESLint clean, oxfmt clean.
…yrne/w3pub-reply-assets
Summary
Bounds thumbnail model loading so a stuck renderer is disposed and later queued thumbnails can continue.
Changes
load3d.loadModel()in a 15-second timeout and adds an executable fake-timer regression for disposal and queue advancement.Review Focus
Please verify the timeout duration and that the queue recovery semantics remain appropriate for slow models.
Fixes #16471
Screenshots (if applicable)
Not applicable; behavior is covered by a unit regression.