Skip to content

fix: require Web Crypto for UUID generation - #16280

Merged
christian-byrne merged 1 commit into
christian-byrne/integration-candidate-v2-ci-fixfrom
christian-byrne/ext102-opid-fallback
Aug 30, 2026
Merged

christian-byrne merged 1 commit into
christian-byrne/integration-candidate-v2-ci-fixfrom
christian-byrne/ext102-opid-fallback

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

TL;DR:

  • Removes the Math.random() UUID fallback so CRDT op_id minting remains collision-resistant.
  • Keeps plain-HTTP/insecure-context support through crypto.getRandomValues().
  • Adds coverage for both Web Crypto paths, fail-closed behavior, UUIDv4 format, and sanity uniqueness.
Full context for agent readers

The ext102-1 audit found that the final Math.random() branch in createUuidv4() violated the coordination-free identity requirement in ADR-007. A collision can conflate operations in deduplication and change the final LWW tie-break result.

This change preserves the intended fallback order as crypto.randomUUID() then crypto.getRandomValues(), which remains available in insecure contexts. Environments without Web Crypto now fail loudly instead of silently minting a weak identifier.

Validation:

  • pnpm test:unit src/utils/uuid.test.ts src/workbench/extensions/agent/crdt/opEnvelope.test.ts (13 passed)
  • pnpm test:unit src/workbench/extensions/agent/crdt (203 passed)
  • pnpm typecheck
  • pnpm lint (0 errors; inherited warnings only)

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 30, 2026
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c5d895f3-9685-4541-aee3-b1fb0bca070c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/30/2026, 05:56:39 AM UTC

Links

🎭 Playwright: ❌ 1789 passed, 47 failed · 3 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1778 / ❌ 42 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 8 / ❌ 5 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 109ms TBT · 104.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.6 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 2ms TBT · 169.3 MB heap
vue-node-resize-workload: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 36ms TBT · 170.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 5ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 452ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 72.8 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 23ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 639ms
canvas-mouse-sweep: script duration 97ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 78.1 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 285ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.4 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 321ms
dom-widget-clipping: script duration 110ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.8 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 485ms
large-graph-idle: script duration 21ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.7 MB
large-graph-idle: DOM nodes -266
large-graph-idle: event listeners -151
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 6ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1118ms
large-graph-pan: script duration 523ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.8 MB
large-graph-pan: DOM nodes -132
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1170ms
large-graph-zoom: script duration 492ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.6 MB
large-graph-zoom: DOM nodes 6
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1327ms
legacy-node-drag: script duration 606ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 78.3 MB
legacy-node-drag: DOM nodes -121
legacy-node-drag: event listeners 93
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 461ms
minimap-idle: script duration 24ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.6 MB
minimap-idle: DOM nodes -268
minimap-idle: event listeners -73
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 296ms
subgraph-dom-widget-clipping: script duration 95ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.8 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 406ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.3 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -233
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 24ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 615ms
subgraph-mouse-sweep: script duration 66ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.5 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 684ms
subgraph-transition-enter: script duration 20ms
subgraph-transition-enter: TBT 109ms
subgraph-transition-enter: heap used 104.6 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 22ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4089ms
viewport-pan-sweep: script duration 1756ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.4 MB
viewport-pan-sweep: DOM nodes -262
viewport-pan-sweep: event listeners -129
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 11ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 1
vue-large-graph-idle: task duration 10110ms
vue-large-graph-idle: script duration 107ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.6 MB
vue-large-graph-idle: DOM nodes -6547
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 69
vue-large-graph-pan: task duration 12738ms
vue-large-graph-pan: script duration 551ms
vue-large-graph-pan: TBT 2ms
vue-large-graph-pan: heap used 169.3 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 16ms
vue-node-resize-workload: style recalc duration 69ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 21
vue-node-resize-workload: task duration 3773ms
vue-node-resize-workload: script duration 63ms
vue-node-resize-workload: TBT 36ms
vue-node-resize-workload: heap used 170.2 MB
vue-node-resize-workload: DOM nodes -6547
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 11ms
workflow-execution: layout count 3
workflow-execution: style recalc count 8
workflow-execution: task duration 57ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.8 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-08-30T06:06:16.312Z",
  "gitSha": "df1b1d870e2f2cdd060a059fd2ec98c7cf363a01",
  "branch": "christian-byrne/ext102-opid-fallback",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2025.6289999999808,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.332,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.745,
      "heapDeltaBytes": 3481436,
      "heapUsedBytes": 73424792,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 6.781000000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2025.1260000000002,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.212,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.924,
      "heapDeltaBytes": 9090476,
      "heapUsedBytes": 79285472,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.2509999999999994,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1685.9339999999747,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 21.581999999999997,
      "layouts": 14,
      "layoutDurationMs": 2.7729999999999997,
      "taskDurationMs": 627.914,
      "heapDeltaBytes": 13006012,
      "heapUsedBytes": 83460984,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 93.28399999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1726.3140000000021,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 23.421999999999997,
      "layouts": 14,
      "layoutDurationMs": 2.935,
      "taskDurationMs": 649.35,
      "heapDeltaBytes": 9695832,
      "heapUsedBytes": 80280984,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 101.48899999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1658.7690000000066,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 11.108000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.8490000000000002,
      "taskDurationMs": 277.259,
      "heapDeltaBytes": 4398952,
      "heapUsedBytes": 74779132,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 7.492999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1666.4770000001,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.514000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.7769999999999999,
      "taskDurationMs": 293.385,
      "heapDeltaBytes": 4461676,
      "heapUsedBytes": 74977144,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 7.632,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 512.6389999999788,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 317.019,
      "heapDeltaBytes": 18446096,
      "heapUsedBytes": 88903108,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 109.398,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 528.2069999999521,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.776,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 324.134,
      "heapDeltaBytes": 18541920,
      "heapUsedBytes": 89004956,
      "domNodes": 20,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 110.434,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2048.7509999999816,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.709,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.0490000000001,
      "heapDeltaBytes": -12795084,
      "heapUsedBytes": 87836424,
      "domNodes": -264,
      "jsHeapTotalBytes": -1347584,
      "scriptDurationMs": 21.476000000000003,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2018.8650000000052,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.7189999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 477.29299999999995,
      "heapDeltaBytes": -11710396,
      "heapUsedBytes": 87713200,
      "domNodes": -267,
      "jsHeapTotalBytes": -1085440,
      "scriptDurationMs": 21.256999999999998,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2099.109999999996,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 7.456999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1102.61,
      "heapDeltaBytes": 22728764,
      "heapUsedBytes": 89301200,
      "domNodes": -268,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 516.76,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2076.964999999973,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 5.425999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1134.2119999999998,
      "heapDeltaBytes": 17681744,
      "heapUsedBytes": 84333612,
      "domNodes": 4,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 529.855,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3107.0530000000076,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 7.628000000000003,
      "layouts": 60,
      "layoutDurationMs": 7.582,
      "taskDurationMs": 1163.739,
      "heapDeltaBytes": 8200888,
      "heapUsedBytes": 76235456,
      "domNodes": 6,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 486.92999999999995,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3063.9260000000377,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 7.3980000000000015,
      "layouts": 60,
      "layoutDurationMs": 7.82,
      "taskDurationMs": 1176.508,
      "heapDeltaBytes": 11739244,
      "heapUsedBytes": 80131816,
      "domNodes": 6,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 496.95300000000003,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2326.7890000000193,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.098999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1357.355,
      "heapDeltaBytes": -578108,
      "heapUsedBytes": 79722900,
      "domNodes": -248,
      "jsHeapTotalBytes": -180224,
      "scriptDurationMs": 625.272,
      "eventListeners": -1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2099.050000000034,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 4.436000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1297.568,
      "heapDeltaBytes": 14708136,
      "heapUsedBytes": 84380568,
      "domNodes": 6,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 587.587,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2036.7439999999988,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.789,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.47799999999995,
      "heapDeltaBytes": -13734412,
      "heapUsedBytes": 88503280,
      "domNodes": -264,
      "jsHeapTotalBytes": -1347584,
      "scriptDurationMs": 24.044999999999998,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 1995.5239999999321,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.4680000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.334,
      "heapDeltaBytes": 21968232,
      "heapUsedBytes": 88889876,
      "domNodes": -272,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 23.544000000000004,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 513.3500000000026,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.061,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 301.86899999999997,
      "heapDeltaBytes": 14377488,
      "heapUsedBytes": 86777524,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 96.678,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 496.9949999999699,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.071999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 290.09,
      "heapDeltaBytes": 14306908,
      "heapUsedBytes": 86799384,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 92.34100000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2010.123999999962,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.279999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.688,
      "heapDeltaBytes": -4128480,
      "heapUsedBytes": 68650316,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 5.7330000000000005,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.4150000000272,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.984999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.64599999999996,
      "heapDeltaBytes": -5280520,
      "heapUsedBytes": 66259712,
      "domNodes": -296,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 6.047999999999999,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.5400000000413,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 22.901000000000003,
      "layouts": 18,
      "layoutDurationMs": 2.912,
      "taskDurationMs": 614.509,
      "heapDeltaBytes": -4574488,
      "heapUsedBytes": 68117260,
      "domNodes": -294,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 66.044,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1726.8620000000965,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 24.259999999999998,
      "layouts": 18,
      "layoutDurationMs": 3.0679999999999996,
      "taskDurationMs": 616.448,
      "heapDeltaBytes": 9591140,
      "heapUsedBytes": 81896472,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 66.733,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 899.4019999998955,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 24.424,
      "layouts": 16,
      "layoutDurationMs": 9.959000000000001,
      "taskDurationMs": 684.0590000000002,
      "heapDeltaBytes": 20988300,
      "heapUsedBytes": 109702620,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 20.040000000000003,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 109,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8126.172000000053,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 22.163999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4104,
      "heapDeltaBytes": 13663768,
      "heapUsedBytes": 89781824,
      "domNodes": -262,
      "jsHeapTotalBytes": -372736,
      "scriptDurationMs": 1747.203,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8180.520999999999,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 21.823,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4073.29,
      "heapDeltaBytes": -15642556,
      "heapUsedBytes": 85199992,
      "domNodes": -262,
      "jsHeapTotalBytes": -1384448,
      "scriptDurationMs": 1765.0300000000002,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10618.551000000025,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 11.36999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10075.191,
      "heapDeltaBytes": -42509196,
      "heapUsedBytes": 178275464,
      "domNodes": -6547,
      "jsHeapTotalBytes": -1830912,
      "scriptDurationMs": 104.38899999999998,
      "eventListeners": -7472,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10653.096000000005,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 11.09099999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10144.08,
      "heapDeltaBytes": -27522456,
      "heapUsedBytes": 175320428,
      "domNodes": -6547,
      "jsHeapTotalBytes": 2580480,
      "scriptDurationMs": 110.247,
      "eventListeners": -7474,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13308.205000000044,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 20.182000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12809.781,
      "heapDeltaBytes": -31619400,
      "heapUsedBytes": 170420676,
      "domNodes": -6547,
      "jsHeapTotalBytes": 10240000,
      "scriptDurationMs": 552.746,
      "eventListeners": -7470,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13156.068000000005,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 19.99999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12666.218,
      "heapDeltaBytes": -16565076,
      "heapUsedBytes": 184552092,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12804096,
      "scriptDurationMs": 548.782,
      "eventListeners": -7470,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3881.439999999998,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 68.14900000000002,
      "layouts": 20,
      "layoutDurationMs": 15.718999999999998,
      "taskDurationMs": 3730.5660000000007,
      "heapDeltaBytes": -27492688,
      "heapUsedBytes": 175177756,
      "domNodes": -6547,
      "jsHeapTotalBytes": 12611584,
      "scriptDurationMs": 70.11099999999999,
      "eventListeners": -7470,
      "totalBlockingTimeMs": 60,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3971.533999999906,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 70.741,
      "layouts": 20,
      "layoutDurationMs": 17.11,
      "taskDurationMs": 3815.68,
      "heapDeltaBytes": -34038196,
      "heapUsedBytes": 181709724,
      "domNodes": -6547,
      "jsHeapTotalBytes": 20201472,
      "scriptDurationMs": 55.401999999999994,
      "eventListeners": -7470,
      "totalBlockingTimeMs": 11,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 94.3129999999428,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.902,
      "layouts": 3,
      "layoutDurationMs": 1.193,
      "taskDurationMs": 54.83200000000001,
      "heapDeltaBytes": 3182576,
      "heapUsedBytes": 70634552,
      "domNodes": 128,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.366,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 80.80900000004476,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 11.550999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.5009999999999997,
      "taskDurationMs": 60.13699999999998,
      "heapDeltaBytes": 3119836,
      "heapUsedBytes": 71466960,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.939000000000001,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

@christian-byrne christian-byrne self-assigned this Aug 30, 2026
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 30, 2026
@codecov

codecov Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                                Coverage Diff                                 @@
##             christian-byrne/integration-candidate-v2-ci-fix   #16280   +/-   ##
==================================================================================
  Coverage                                                   ?   83.25%           
==================================================================================
  Files                                                      ?     2027           
  Lines                                                      ?   117317           
  Branches                                                   ?    32571           
==================================================================================
  Hits                                                       ?    97677           
  Misses                                                     ?    19289           
  Partials                                                   ?      351           
Flag Coverage Δ
e2e 66.67% <66.66%> (?)
unit 76.39% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/utils/uuid.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

CI evidence for exact head f39e6df81487f0d5580f3c0b39887d524cd51b52:

  • lint-and-format, unit test, binary-size, perf-tests, dist telemetry scan, OSS asset validation, Storybook build/deploy, website gates, custom-node E2E, ecosystem matrices, PR risk, CLA, co-author trailer, Socket, and CodeRabbit checks passed or were intentionally skipped.
  • Local focused unit tests passed: 13/13 across uuid.test.ts and opEnvelope.test.ts.
  • Local agent CRDT project passed: 203/203.
  • Local pnpm typecheck and pnpm lint passed; lint reported inherited warnings only and zero errors.
  • The failing Playwright set is inherited from the base: mobile-chrome, cloud, and chromium shards 2/3/4/6/7/8/9/10/13/14/15/16 fail in this run (33295718793). The identical job set fails on sibling #16279 (run 33295474063) and #16274 (run 33295679784), both targeting christian-byrne/integration-candidate-v2-ci-fix. The failures are screenshot-baseline mismatches in unrelated Vue-node/browser specs; this PR changes only src/utils/uuid.ts and its unit test.

@christian-byrne
christian-byrne merged commit 9bae700 into christian-byrne/integration-candidate-v2-ci-fix Aug 30, 2026
92 of 107 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/ext102-opid-fallback branch August 30, 2026 06:14
akumaburn pushed a commit to akumaburn/ComfyUI_frontend that referenced this pull request Aug 30, 2026
…resolves (Comfy-Org#14965)

## Summary

Part of FE-1540 / PAY-004. Six Pylon tickets (Comfy-Org#16322, Comfy-Org#16286, Comfy-Org#16285,
Comfy-Org#16284, Comfy-Org#16280, Comfy-Org#16274), one customer threatening a formal payment
dispute.

`canRunWorkflows` is `false` from the very first render —
`isInitialized` starts `false`, `subscription` is `null`, and
`canAccessSubscriptionFeatures` is `statusData.value?.is_active ??
false` (`useWorkspaceBilling.ts:127-129`). Neither
`CloudRunButtonWrapper.vue` nor `LinearControls.vue` read
`isInitialized`, `isLoading`, or `error`, so **the locked "Subscribe to
run" button was the default render**, asserted on no data at all.

A paying subscriber whose status fetch is slow, failing, or scoped to
the wrong workspace saw a paywall over Run, with no recovery path —
`CloudRunButtonWrapper`'s focus refetch is gated behind
`refreshBillingOnFocus`, which is only set inside the payment-recovery
dialog, so it never fires for a plain status desync.

Worth stating because it contradicts an assumption made during triage:
`canAccessSubscriptionFeatures` does not mean "this user has a paid
subscription", it means "the last status response said `is_active:
true`". Those differ during a desync, which is the incident.

## Change

Adds `showsSubscribeToRunPrompt` to the billing context — it only claims
the user needs to subscribe once billing status has resolved:

```ts
const showsSubscribeToRunPrompt = computed(
  () => isInitialized.value && !canRunWorkflows.value
)
```

Consumed at the three render sites (`CloudRunButtonWrapper.vue:3`,
`LinearControls.vue:182,246`) instead of each re-deriving the rule.

During the unresolved window the normal Run button renders. Entitlement
is still enforced by the backend on execution, and
`useAccountPreconditionDialog` already handles that rejection, so
failing open for that window is the safer direction — a subscriber who
cannot run is a dispute, a non-subscriber who clicks Run gets a clear
server-driven prompt.

## Scope

Deliberately the low-risk half of FE-1540. **Not** included, because
they change Run-button behaviour for all cloud users and want a human
call during an active incident:

- an unsolicited focus/visibility refetch on the Run path (what Robin
asked for in-thread)
- hardening `useWorkspaceBilling.ts:244` so a successful-but-stale
response cannot silently downgrade a previously-active subscription

Also not addressed here: `getBillingStatus()` sends no workspace
parameter (`workspaceApi.ts:430-441`), so a subscription on a team
workspace while Personal is active reads the wrong billing entirely.
Tracked on FE-1540.

## Tests

New case `keeps the run button while billing status is still resolving`,
verified red against the old gate:

```
× keeps the run button while billing status is still resolving
  Tests  1 failed | 11 passed (12)
```

275 tests pass across the 19 affected suites. `pnpm typecheck` exit 0,
`pnpm knip` exit 0.

- Part of FE-1540

Co-authored-by: Connor Byrne <c.byrne@comfy.org>
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support risk:high PR risk grade (advisory shadow check; grader-owned) size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants