Skip to content

refactor: read agent gate from server features - #16274

Merged
christian-byrne merged 3 commits into
christian-byrne/integration-candidate-v2-ci-fixfrom
christian-byrne/rul115-agent-flag-features
Aug 30, 2026
Merged

christian-byrne merged 3 commits into
christian-byrne/integration-candidate-v2-ci-fixfrom
christian-byrne/rul115-agent-flag-features

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Read the in-app agent gate from the existing reactive /features composable so local and cloud builds share the backend-evaluated value.

Changes

  • What: adds agent-in-app-experience to ServerFeatureFlag, watches it through useFeatureFlags().featureFlag(...), and deletes both duplicate PostHog source adapters plus their source-specific tests.
  • Dependencies: no new dependencies; the agent gate no longer imports posthog-js.

Review Focus

The panel still fails closed when the key is absent, remains forced on in development mode, reacts to server-feature changes, and marks the gate settled synchronously because /features is now the single source.

Screenshots (if applicable)

Not applicable; no visual behavior changes for enrolled users.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ea3ecc78-029f-4fa6-b7d3-ab8c2f842033

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 30, 2026
@github-actions

github-actions Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/30/2026, 06:40:43 AM UTC

Links

🎭 Playwright: ❌ 1791 passed, 47 failed · 2 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1780 / ❌ 42 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 8 / ❌ 5 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 132ms TBT · 99.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.9 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.7 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 152ms TBT · 163.4 MB heap
vue-node-resize-workload: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 492ms TBT · 172.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 511ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 71.7 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 39ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 933ms
canvas-mouse-sweep: script duration 149ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.9 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 350ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.8 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 445ms
dom-widget-clipping: script duration 155ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.9 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 10ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 611ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.8 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -183
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1509ms
large-graph-pan: script duration 726ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.4 MB
large-graph-pan: DOM nodes -275
large-graph-pan: event listeners -76
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1661ms
large-graph-zoom: script duration 742ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.1 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1908ms
legacy-node-drag: script duration 938ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.3 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 571ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.3 MB
minimap-idle: DOM nodes -271
minimap-idle: event listeners -155
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 400ms
subgraph-dom-widget-clipping: script duration 138ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 81.7 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 479ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.2 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -200
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 801ms
subgraph-mouse-sweep: script duration 101ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 56.9 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 911ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 132ms
subgraph-transition-enter: heap used 99.6 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5550ms
viewport-pan-sweep: script duration 2512ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.9 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -139
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17135ms
vue-large-graph-idle: script duration 299ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.7 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 169
vue-large-graph-pan: task duration 21329ms
vue-large-graph-pan: script duration 899ms
vue-large-graph-pan: TBT 152ms
vue-large-graph-pan: heap used 163.4 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 76ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6264ms
vue-node-resize-workload: script duration 117ms
vue-node-resize-workload: TBT 492ms
vue-node-resize-workload: heap used 172.3 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 81ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.3 MB
workflow-execution: DOM nodes 129
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-08-30T06:52:39.514Z",
  "gitSha": "6d3b62b67ca965b2af2ac0f50bc708511346520c",
  "branch": "christian-byrne/rul115-agent-flag-features",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2054.8989999999776,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.980000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.31800000000004,
      "heapDeltaBytes": -2154128,
      "heapUsedBytes": 67499888,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.153000000000002,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2055.0559999999223,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.803999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.715,
      "heapDeltaBytes": 13213400,
      "heapUsedBytes": 82945384,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.142,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2019.8579999999993,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 43.668,
      "layouts": 14,
      "layoutDurationMs": 6.369,
      "taskDurationMs": 998.468,
      "heapDeltaBytes": -8357248,
      "heapUsedBytes": 60271224,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 157.228,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1798.7729999999829,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 34.289,
      "layouts": 14,
      "layoutDurationMs": 4.483,
      "taskDurationMs": 867.726,
      "heapDeltaBytes": -8398840,
      "heapUsedBytes": 61080012,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 140.622,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.8359999999861,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.152,
      "layouts": 6,
      "layoutDurationMs": 1.0919999999999999,
      "taskDurationMs": 354.68600000000004,
      "heapDeltaBytes": 4411016,
      "heapUsedBytes": 74416540,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.034,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.1979999999485,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.32,
      "layouts": 6,
      "layoutDurationMs": 1.258,
      "taskDurationMs": 345.46600000000007,
      "heapDeltaBytes": 3593400,
      "heapUsedBytes": 67708144,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.087000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 660.8610000000112,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.340999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.64200000000005,
      "heapDeltaBytes": 18776292,
      "heapUsedBytes": 88000564,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 156.368,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 649.5330000000195,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.481,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.91700000000003,
      "heapDeltaBytes": 18423172,
      "heapUsedBytes": 87965344,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 153.309,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2079.876000000013,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.963,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 647.0730000000001,
      "heapDeltaBytes": 10826604,
      "heapUsedBytes": 85014052,
      "domNodes": -270,
      "jsHeapTotalBytes": -1384448,
      "scriptDurationMs": 35.211999999999996,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.6740000000382,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.379,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 574.3099999999998,
      "heapDeltaBytes": 10480980,
      "heapUsedBytes": 86470500,
      "domNodes": -274,
      "jsHeapTotalBytes": -2433024,
      "scriptDurationMs": 31.926000000000002,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2161.5680000000452,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 12.019999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1512.72,
      "heapDeltaBytes": 23020276,
      "heapUsedBytes": 88898832,
      "domNodes": -272,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 733.726,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2129.3889999999465,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 10.295999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1504.601,
      "heapDeltaBytes": 17871160,
      "heapUsedBytes": 83975168,
      "domNodes": -277,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 718.761,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3510.2380000000153,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.597999999999995,
      "layouts": 60,
      "layoutDurationMs": 13.084,
      "taskDurationMs": 1639.1609999999998,
      "heapDeltaBytes": 8509412,
      "heapUsedBytes": 75309860,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 733.24,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3537.36200000003,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.987000000000004,
      "layouts": 60,
      "layoutDurationMs": 13.324,
      "taskDurationMs": 1683.106,
      "heapDeltaBytes": 8800132,
      "heapUsedBytes": 75876232,
      "domNodes": -280,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 750.0389999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3078.5170000000335,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.329999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1921.3839999999998,
      "heapDeltaBytes": 22728808,
      "heapUsedBytes": 89530624,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 944.135,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3090.049000000022,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.245000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1894.224,
      "heapDeltaBytes": 25774072,
      "heapUsedBytes": 93507332,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 932.402,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2060.3479999999763,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.4509999999999983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 562.637,
      "heapDeltaBytes": 22141304,
      "heapUsedBytes": 87484028,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.823,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2036.3179999999375,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.434,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.4149999999998,
      "heapDeltaBytes": -13980444,
      "heapUsedBytes": 87273692,
      "domNodes": -269,
      "jsHeapTotalBytes": -1609728,
      "scriptDurationMs": 32.533,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 586.6110000000049,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.179,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.61099999999993,
      "heapDeltaBytes": 13764388,
      "heapUsedBytes": 85601696,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 136.762,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 591.3480000000391,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.972000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.36999999999995,
      "heapDeltaBytes": 13959460,
      "heapUsedBytes": 85769932,
      "domNodes": 22,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 139.28,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.8889999999542,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.228,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.382,
      "heapDeltaBytes": -7376244,
      "heapUsedBytes": 64258408,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 6.658999999999998,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.1550000000116,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.180999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.777,
      "heapDeltaBytes": -9667072,
      "heapUsedBytes": 61986392,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 6.960000000000001,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1740.3410000000008,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 36.098,
      "layouts": 18,
      "layoutDurationMs": 5.496,
      "taskDurationMs": 804.879,
      "heapDeltaBytes": -11202328,
      "heapUsedBytes": 60341044,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 100.891,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1757.0419999999558,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 38.087999999999994,
      "layouts": 18,
      "layoutDurationMs": 5.348999999999999,
      "taskDurationMs": 796.252,
      "heapDeltaBytes": -12682904,
      "heapUsedBytes": 59010484,
      "domNodes": -294,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 100.36200000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.556999999988,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 29.405,
      "layouts": 15,
      "layoutDurationMs": 14.150999999999996,
      "taskDurationMs": 910.99,
      "heapDeltaBytes": 21918628,
      "heapUsedBytes": 104486940,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 30.496000000000002,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8381.473000000027,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.227,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5604.698,
      "heapDeltaBytes": -10828264,
      "heapUsedBytes": 89118404,
      "domNodes": -267,
      "jsHeapTotalBytes": -1384448,
      "scriptDurationMs": 2536.0040000000004,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8272.520000000099,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 38.844,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5495.108,
      "heapDeltaBytes": -11027600,
      "heapUsedBytes": 88872396,
      "domNodes": -268,
      "jsHeapTotalBytes": -1384448,
      "scriptDurationMs": 2488.9410000000003,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17935.896000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17055.889,
      "heapDeltaBytes": -27170584,
      "heapUsedBytes": 175330452,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 285.91,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17838.56199999991,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17213.164,
      "heapDeltaBytes": -23713184,
      "heapUsedBytes": 178467504,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 311.498,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21608.204,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 20.218999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21180.399999999998,
      "heapDeltaBytes": -33385592,
      "heapUsedBytes": 176238488,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6410240,
      "scriptDurationMs": 883.1940000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 143,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21846.258000000034,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 20.55700000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21477.668,
      "heapDeltaBytes": -36472836,
      "heapUsedBytes": 166367468,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 914.253,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 161,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6446.82499999999,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.34100000000005,
      "layouts": 20,
      "layoutDurationMs": 26.121999999999993,
      "taskDurationMs": 6327.607,
      "heapDeltaBytes": -29467324,
      "heapUsedBytes": 180297152,
      "domNodes": -6548,
      "jsHeapTotalBytes": 11939840,
      "scriptDurationMs": 117.854,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 506,
      "frameDurationMs": 18.889999999999965,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6255.110000000059,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.99600000000001,
      "layouts": 20,
      "layoutDurationMs": 25.56900000000001,
      "taskDurationMs": 6199.746,
      "heapDeltaBytes": -28615400,
      "heapUsedBytes": 181136520,
      "domNodes": -6548,
      "jsHeapTotalBytes": 11939840,
      "scriptDurationMs": 115.955,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 477,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 122.27199999995264,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.904000000000003,
      "layouts": 2,
      "layoutDurationMs": 1.1800000000000002,
      "taskDurationMs": 89.29199999999999,
      "heapDeltaBytes": 3192548,
      "heapUsedBytes": 70772808,
      "domNodes": 132,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.345,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 106.21800000001258,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.094,
      "layouts": 2,
      "layoutDurationMs": 1.4209999999999998,
      "taskDurationMs": 73.266,
      "heapDeltaBytes": 3006976,
      "heapUsedBytes": 70398960,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.493999999999998,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@christian-byrne christian-byrne self-assigned this Aug 30, 2026
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 30, 2026
@codecov

codecov Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/composables/useFeatureFlags.ts 50.00% 2 Missing ⚠️
@@                                Coverage Diff                                 @@
##             christian-byrne/integration-candidate-v2-ci-fix   #16274   +/-   ##
==================================================================================
  Coverage                                                   ?   83.25%           
==================================================================================
  Files                                                      ?     2025           
  Lines                                                      ?   117289           
  Branches                                                   ?    33168           
==================================================================================
  Hits                                                       ?    97645           
  Misses                                                     ?    19294           
  Partials                                                   ?      350           
Flag Coverage Δ
e2e 66.69% <90.00%> (?)
unit 76.38% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/extensions/core/agentPanel.ts 100.00% <100.00%> (ø)
src/composables/useFeatureFlags.ts 86.48% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne force-pushed the christian-byrne/rul115-agent-flag-features branch from c70687d to 932313c Compare August 30, 2026 06:38
@christian-byrne

Copy link
Copy Markdown
Contributor Author

TL;DR

  • The initial cloud delta disproved inherited-only: four panel tests failed only on this PR because the fixture still seeded the former PostHog gate.
  • Commit 932313c7 now seeds agent-in-app-experience through the server feature_flags handshake; the exact-head reports match the latest base-producing run at every failing scope.
  • The remaining 15 failed checks are inherited from base tip 9bae7001; waiver requested for squash merge.
Full context for agent readers

Compared PR head 932313c7d4b23c641f3d748fb140153f99369d37 in E2E run 33297376751 with the CI run that produced current base tip 9bae7001158b71cbba5f74084964a29cdc87ea54: PR #16280 head f39e6df8, run 33295718793. The base push workflow itself only dispatches the cloud build, so the producing PR run is the base-tip E2E receipt.

Check PR head Base-producing run Same signature
playwright-tests-chromium-sharded (2, 16) fail fail yes
playwright-tests-chromium-sharded (3, 16) fail fail yes
playwright-tests-chromium-sharded (4, 16) fail fail yes
playwright-tests-chromium-sharded (6, 16) fail fail yes
playwright-tests-chromium-sharded (7, 16) fail fail yes
playwright-tests-chromium-sharded (8, 16) fail fail yes
playwright-tests-chromium-sharded (9, 16) fail fail yes
playwright-tests-chromium-sharded (10, 16) fail fail yes
playwright-tests-chromium-sharded (13, 16) fail fail yes
playwright-tests-chromium-sharded (14, 16) fail fail yes
playwright-tests-chromium-sharded (15, 16) fail fail yes
playwright-tests-chromium-sharded (16, 16) fail fail yes
playwright-tests (mobile-chrome) fail fail yes
playwright-tests (cloud) fail fail yes
e2e-status fail fail yes, aggregate only

The retained JSON report comparison is exact by failed test-title set: Chromium 42/42, mobile Chrome 5/5, and cloud 2/2. The failing shard-name set also matches exactly. All other completed check families are green or skipped on the PR head.

The genuine PR-only issue was limited to the panel test fixture. api.getServerFeature() reads api.serverFeatureFlags, populated by the WebSocket feature_flags handshake; /api/features does not seed that state. The fixture now calls comfyPage.featureFlags.setServerFlagsPersistent() before page initialization. Local unit tests passed 63/63, and formatting, lint, browser typecheck, plus commit-hook validation passed.

@christian-byrne
christian-byrne merged commit 94a795b into christian-byrne/integration-candidate-v2-ci-fix Aug 30, 2026
79 of 94 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/rul115-agent-flag-features branch August 30, 2026 06:59
akumaburn pushed a commit to akumaburn/ComfyUI_frontend that referenced this pull request Aug 30, 2026
…resolves (Comfy-Org#14965)

## Summary

Part of FE-1540 / PAY-004. Six Pylon tickets (Comfy-Org#16322, Comfy-Org#16286, Comfy-Org#16285,
Comfy-Org#16284, Comfy-Org#16280, Comfy-Org#16274), one customer threatening a formal payment
dispute.

`canRunWorkflows` is `false` from the very first render —
`isInitialized` starts `false`, `subscription` is `null`, and
`canAccessSubscriptionFeatures` is `statusData.value?.is_active ??
false` (`useWorkspaceBilling.ts:127-129`). Neither
`CloudRunButtonWrapper.vue` nor `LinearControls.vue` read
`isInitialized`, `isLoading`, or `error`, so **the locked "Subscribe to
run" button was the default render**, asserted on no data at all.

A paying subscriber whose status fetch is slow, failing, or scoped to
the wrong workspace saw a paywall over Run, with no recovery path —
`CloudRunButtonWrapper`'s focus refetch is gated behind
`refreshBillingOnFocus`, which is only set inside the payment-recovery
dialog, so it never fires for a plain status desync.

Worth stating because it contradicts an assumption made during triage:
`canAccessSubscriptionFeatures` does not mean "this user has a paid
subscription", it means "the last status response said `is_active:
true`". Those differ during a desync, which is the incident.

## Change

Adds `showsSubscribeToRunPrompt` to the billing context — it only claims
the user needs to subscribe once billing status has resolved:

```ts
const showsSubscribeToRunPrompt = computed(
  () => isInitialized.value && !canRunWorkflows.value
)
```

Consumed at the three render sites (`CloudRunButtonWrapper.vue:3`,
`LinearControls.vue:182,246`) instead of each re-deriving the rule.

During the unresolved window the normal Run button renders. Entitlement
is still enforced by the backend on execution, and
`useAccountPreconditionDialog` already handles that rejection, so
failing open for that window is the safer direction — a subscriber who
cannot run is a dispute, a non-subscriber who clicks Run gets a clear
server-driven prompt.

## Scope

Deliberately the low-risk half of FE-1540. **Not** included, because
they change Run-button behaviour for all cloud users and want a human
call during an active incident:

- an unsolicited focus/visibility refetch on the Run path (what Robin
asked for in-thread)
- hardening `useWorkspaceBilling.ts:244` so a successful-but-stale
response cannot silently downgrade a previously-active subscription

Also not addressed here: `getBillingStatus()` sends no workspace
parameter (`workspaceApi.ts:430-441`), so a subscription on a team
workspace while Personal is active reads the wrong billing entirely.
Tracked on FE-1540.

## Tests

New case `keeps the run button while billing status is still resolving`,
verified red against the old gate:

```
× keeps the run button while billing status is still resolving
  Tests  1 failed | 11 passed (12)
```

275 tests pass across the 19 affected suites. `pnpm typecheck` exit 0,
`pnpm knip` exit 0.

- Part of FE-1540

Co-authored-by: Connor Byrne <c.byrne@comfy.org>
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned) size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants