Skip to content

feat: report cmp event sink failures - #16273

Merged
christian-byrne merged 1 commit into
christian-byrne/integration-candidate-v2-ci-fixfrom
christian-byrne/evsink-fe-wiring
Aug 30, 2026
Merged

christian-byrne merged 1 commit into
christian-byrne/integration-candidate-v2-ci-fixfrom
christian-byrne/evsink-fe-wiring

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Pins merged cmp event-sink contract and maps its failures to the generic FE reporter. Green locally. Operator review needed: this follower base has no production applyOps call, so the adapter is intentionally not attached to a forbidden follower write path.

Full context and validation

Summary

Adds the frontend-owned CmpEventSink adapter selected by cmp ADR-008 without introducing package-global registration.

Changes

  • What: cmpEventSink bounds diagnostic messages, keeps machine fields as stable tags, and keeps op_id/batch_index in non-indexed context.
  • Dependencies: advances @comfyorg/comfy-multi-player to merged SHA 743bfd0, including its exact supply-chain allowlist identity.
  • Authority boundary: does not call applyOps from the follower. The target base only consumes host-owned Yjs updates, so manufacturing a browser applier call would violate the follower contract.

Review Focus

  • Confirm the reporter mapping and message bound.
  • Decide where a future browser-owned cmp applier should receive the event sink; there is no legal production call site on this base.

Validation

  • pnpm test:unit src/platform/telemetry/cmpEventSink.test.ts --run — 2 passed.
  • pnpm typecheck — passed.
  • pnpm lint — passed with 187 pre-existing warnings and zero errors.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 30, 2026
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ff483ad6-1690-4131-97f4-45333693e5a9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎭 Playwright: ❌ 1793 passed, 47 failed · 1 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1782 / ❌ 42 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 8 / ❌ 5 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/30/2026, 03:36:55 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 1ms TBT · 82.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 145ms TBT · 105.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.1 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.7 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 58ms TBT · 172.2 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 494ms TBT · 168.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 564ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.7 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -172
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 46ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 955ms
canvas-mouse-sweep: script duration 169ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.0 MB
canvas-mouse-sweep: DOM nodes -283
canvas-mouse-sweep: event listeners -185
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 358ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.8 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 458ms
dom-widget-clipping: script duration 164ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 81.7 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 649ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.6 MB
large-graph-idle: DOM nodes -279
large-graph-idle: event listeners -184
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1731ms
large-graph-pan: script duration 857ms
large-graph-pan: TBT 1ms
large-graph-pan: heap used 82.6 MB
large-graph-pan: DOM nodes -264
large-graph-pan: event listeners -89
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1770ms
large-graph-zoom: script duration 769ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.2 MB
large-graph-zoom: DOM nodes -137
large-graph-zoom: event listeners -78
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 11ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 2026ms
legacy-node-drag: script duration 972ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 78.9 MB
legacy-node-drag: DOM nodes -268
legacy-node-drag: event listeners -1
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 569ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.8 MB
minimap-idle: DOM nodes -270
minimap-idle: event listeners -153
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 414ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.5 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 516ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 72.1 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 41ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 899ms
subgraph-mouse-sweep: script duration 121ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.4 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 37ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 985ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 145ms
subgraph-transition-enter: heap used 105.3 MB
subgraph-transition-enter: DOM nodes 13675
subgraph-transition-enter: event listeners 2391
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5984ms
viewport-pan-sweep: script duration 2695ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 74.1 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -143
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16905ms
vue-large-graph-idle: script duration 285ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.7 MB
vue-large-graph-idle: DOM nodes -6551
vue-large-graph-idle: event listeners -7481
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 20862ms
vue-large-graph-pan: script duration 913ms
vue-large-graph-pan: TBT 58ms
vue-large-graph-pan: heap used 172.2 MB
vue-large-graph-pan: DOM nodes -6551
vue-large-graph-pan: event listeners -7472
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 83ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6155ms
vue-node-resize-workload: script duration 124ms
vue-node-resize-workload: TBT 494ms
vue-node-resize-workload: heap used 168.1 MB
vue-node-resize-workload: DOM nodes -6551
vue-node-resize-workload: event listeners -7476
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 9
workflow-execution: task duration 92ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.0 MB
workflow-execution: DOM nodes 123
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-08-30T03:49:21.769Z",
  "gitSha": "5b6c02f75e3f241161fb3fd3b91660492b4d9b4d",
  "branch": "christian-byrne/evsink-fe-wiring",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2087.1080000000575,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.371,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 612.512,
      "heapDeltaBytes": 9717180,
      "heapUsedBytes": 79006388,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 13.199000000000002,
      "eventListeners": -159,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2027.360999999928,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.534999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.7499999999999,
      "heapDeltaBytes": -1514696,
      "heapUsedBytes": 62953808,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.259,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1919.240000000059,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 50.541000000000004,
      "layouts": 14,
      "layoutDurationMs": 4.395,
      "taskDurationMs": 981.6890000000001,
      "heapDeltaBytes": -2712444,
      "heapUsedBytes": 67331896,
      "domNodes": -284,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 176.16099999999997,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1880.6230000000141,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.621,
      "layouts": 14,
      "layoutDurationMs": 4.923,
      "taskDurationMs": 929.0880000000002,
      "heapDeltaBytes": 475308,
      "heapUsedBytes": 64868440,
      "domNodes": -281,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 162.458,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1677.7530000000525,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 17.296,
      "layouts": 6,
      "layoutDurationMs": 1.09,
      "taskDurationMs": 360.654,
      "heapDeltaBytes": 4803472,
      "heapUsedBytes": 75232764,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.877,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.7669999999998,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.656,
      "layouts": 6,
      "layoutDurationMs": 1.1059999999999999,
      "taskDurationMs": 355.83500000000004,
      "heapDeltaBytes": 4725260,
      "heapUsedBytes": 75343548,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.644999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 701.2379999999894,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.011000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.156,
      "heapDeltaBytes": 18516420,
      "heapUsedBytes": 88721108,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 163.275,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 708.697999999913,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.745000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.68399999999997,
      "heapDeltaBytes": 18183252,
      "heapUsedBytes": 82694960,
      "domNodes": 18,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 164.073,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2066.283999999996,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.921,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 646.187,
      "heapDeltaBytes": 6086892,
      "heapUsedBytes": 82296708,
      "domNodes": -281,
      "jsHeapTotalBytes": -2170880,
      "scriptDurationMs": 38.982,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2053.9349999999104,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 7.3100000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 651.0870000000001,
      "heapDeltaBytes": 8473348,
      "heapUsedBytes": 84542412,
      "domNodes": -277,
      "jsHeapTotalBytes": -1646592,
      "scriptDurationMs": 37.275999999999996,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2543.6500000000706,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.694999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1786.0220000000002,
      "heapDeltaBytes": 3606364,
      "heapUsedBytes": 80611140,
      "domNodes": -251,
      "jsHeapTotalBytes": -372736,
      "scriptDurationMs": 879.5509999999999,
      "eventListeners": -183,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2425.764000000072,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.705999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1676.812,
      "heapDeltaBytes": 26084968,
      "heapUsedBytes": 92607452,
      "domNodes": -277,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 833.704,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3677.964999999972,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 12.283,
      "layouts": 60,
      "layoutDurationMs": 12.150999999999998,
      "taskDurationMs": 1735.2649999999999,
      "heapDeltaBytes": 8565804,
      "heapUsedBytes": 76520192,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 775.517,
      "eventListeners": 16,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3632.8379999999925,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.49,
      "layouts": 60,
      "layoutDurationMs": 12.06,
      "taskDurationMs": 1805.189,
      "heapDeltaBytes": -3981000,
      "heapUsedBytes": 74791540,
      "domNodes": -277,
      "jsHeapTotalBytes": -1908736,
      "scriptDurationMs": 763.178,
      "eventListeners": -171,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3133.6310000000367,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 8.038,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2022.036,
      "heapDeltaBytes": 3765944,
      "heapUsedBytes": 84108880,
      "domNodes": -281,
      "jsHeapTotalBytes": 606208,
      "scriptDurationMs": 975.115,
      "eventListeners": -1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3208.65700000013,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 13.016999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2029.6539999999998,
      "heapDeltaBytes": 865260,
      "heapUsedBytes": 81282468,
      "domNodes": -255,
      "jsHeapTotalBytes": 606208,
      "scriptDurationMs": 969.582,
      "eventListeners": -1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.4049999999443,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.2510000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 558.9399999999999,
      "heapDeltaBytes": 21960632,
      "heapUsedBytes": 88250336,
      "domNodes": -271,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.465000000000007,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.7299999999668,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.812,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.6640000000001,
      "heapDeltaBytes": 21095880,
      "heapUsedBytes": 87511992,
      "domNodes": -269,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 38.116,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 611.8370000000368,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.194,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.678,
      "heapDeltaBytes": 14351564,
      "heapUsedBytes": 86661568,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 143.93,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 577.7350000000752,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.842,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.198,
      "heapDeltaBytes": 14038560,
      "heapUsedBytes": 86353192,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 140.319,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2039.7790000000668,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.904,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 523.682,
      "heapDeltaBytes": -3779080,
      "heapUsedBytes": 68670592,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.45,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.2330000000284,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.285999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.124,
      "heapDeltaBytes": 10253596,
      "heapUsedBytes": 82457036,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.701,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1740.489000000025,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 38.579,
      "layouts": 18,
      "layoutDurationMs": 5.616,
      "taskDurationMs": 872.7309999999999,
      "heapDeltaBytes": 10492080,
      "heapUsedBytes": 83049608,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 121.90799999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1789.8599999998623,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 42.594,
      "layouts": 18,
      "layoutDurationMs": 5.989,
      "taskDurationMs": 925.519,
      "heapDeltaBytes": -5347908,
      "heapUsedBytes": 66746444,
      "domNodes": -296,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 119.105,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1466.066000000069,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 36.556999999999995,
      "layouts": 16,
      "layoutDurationMs": 16.772999999999996,
      "taskDurationMs": 984.8560000000002,
      "heapDeltaBytes": 21230592,
      "heapUsedBytes": 110389748,
      "domNodes": 13675,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 32.22099999999999,
      "eventListeners": 2391,
      "totalBlockingTimeMs": 145,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9377.034999999978,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 40.575,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6142.629,
      "heapDeltaBytes": -6581180,
      "heapUsedBytes": 69515136,
      "domNodes": -275,
      "jsHeapTotalBytes": 4382720,
      "scriptDurationMs": 2732.747,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8519.41899999997,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.147999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5826.073,
      "heapDeltaBytes": -14573708,
      "heapUsedBytes": 85793972,
      "domNodes": -265,
      "jsHeapTotalBytes": -598016,
      "scriptDurationMs": 2657.562,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17420.68500000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16802.658,
      "heapDeltaBytes": -33140268,
      "heapUsedBytes": 176026372,
      "domNodes": -6551,
      "jsHeapTotalBytes": -3870720,
      "scriptDurationMs": 283.89400000000006,
      "eventListeners": -7480,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17923.823000000084,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17008.011,
      "heapDeltaBytes": -34008012,
      "heapUsedBytes": 175695832,
      "domNodes": -6551,
      "jsHeapTotalBytes": -3084288,
      "scriptDurationMs": 286.354,
      "eventListeners": -7482,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21302.15999999996,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 18.884999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20951.119,
      "heapDeltaBytes": -31426620,
      "heapUsedBytes": 170957044,
      "domNodes": -6551,
      "jsHeapTotalBytes": 1839104,
      "scriptDurationMs": 891.4649999999999,
      "eventListeners": -7472,
      "totalBlockingTimeMs": 28,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21158.759999999802,
      "styleRecalcs": 171,
      "styleRecalcDurationMs": 17.22399999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20773.426,
      "heapDeltaBytes": -12037712,
      "heapUsedBytes": 190173912,
      "domNodes": -6551,
      "jsHeapTotalBytes": 2277376,
      "scriptDurationMs": 934.4,
      "eventListeners": -7472,
      "totalBlockingTimeMs": 88,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6244.927999999959,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.52000000000004,
      "layouts": 20,
      "layoutDurationMs": 24.882000000000016,
      "taskDurationMs": 6155.8150000000005,
      "heapDeltaBytes": -33452564,
      "heapUsedBytes": 175495424,
      "domNodes": -6551,
      "jsHeapTotalBytes": 13574144,
      "scriptDurationMs": 128.37199999999999,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 539,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6325.443999999834,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.85700000000001,
      "layouts": 20,
      "layoutDurationMs": 21.709000000000007,
      "taskDurationMs": 6153.378,
      "heapDeltaBytes": -17620192,
      "heapUsedBytes": 177063372,
      "domNodes": -6551,
      "jsHeapTotalBytes": 9965568,
      "scriptDurationMs": 119.75699999999999,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 448,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 127.64400000003207,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.394000000000002,
      "layouts": 2,
      "layoutDurationMs": 1.276,
      "taskDurationMs": 79.764,
      "heapDeltaBytes": 3164368,
      "heapUsedBytes": 71433272,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.764999999999999,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 466.38499999994565,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 20.843999999999994,
      "layouts": 3,
      "layoutDurationMs": 0.907,
      "taskDurationMs": 104.11200000000001,
      "heapDeltaBytes": 5058500,
      "heapUsedBytes": 73214028,
      "domNodes": 119,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.5680000000000005,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 30, 2026
@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                                Coverage Diff                                 @@
##             christian-byrne/integration-candidate-v2-ci-fix   #16273   +/-   ##
==================================================================================
  Coverage                                                   ?   83.24%           
==================================================================================
  Files                                                      ?     2022           
  Lines                                                      ?   116744           
  Branches                                                   ?    32138           
==================================================================================
  Hits                                                       ?    97182           
  Misses                                                     ?    19223           
  Partials                                                   ?      339           
Flag Coverage Δ
e2e 66.69% <ø> (?)
unit 76.32% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/telemetry/cmpEventSink.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne self-assigned this Aug 30, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor Author

TL;DR: recommend closing this PR and deleting christian-byrne/evsink-fe-wiring. FE has no production CMP applyOps call to wire; the real sink seam is already in the cloud doc-host. Adding an FE applier solely for telemetry would break the read-only follower boundary.

Full context for agent readers

Repository-wide search shows every frontend applyOps( reference is in a test. The production follower decodes host-authored doc_update.update_b64 in src/workbench/extensions/agent/crdt/docFrameClient.ts:134-152 and applies it through Y.applyUpdate in src/workbench/extensions/agent/crdt/followerDoc.ts:9-11.

The actual production CMP call is cloud/services/agent/dochost/src/server.ts:371-376, where applyOps(doc, admitted, catalog, { eventSink }) already captures emitted events. Cloud also has services/agent/internal/dochost/outcomes_test.go:154-155, asserting exactly one op_rejected / unknown_widget event.

Consequently, an FE integration test that induces op_rejected through a production FE path is impossible without either inventing a test-only call or introducing a second applier into the read-only follower. The current adapter remains write-only plumbing, so the correct disposition is close plus branch deletion, with any telemetry delivery work owned at the doc-host response/logging seam.

The PR is one commit behind its current christian-byrne/integration-candidate-v2-ci-fix base. I did not rebase or modify it because that would only refresh code recommended for deletion. The red website-unit check is an unrelated missing-coverage-artifact upload failure; broad Playwright failures are also outside this five-file diff.

Glossary: CMP is @comfyorg/comfy-multi-player; doc-host is the cloud-side canonical document owner; follower is the FE replica that consumes host-authored Yjs updates without writing the shared document.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

TL;DR: All 17 failing checks inherited from base — merging under #16269 precedent. 15 checks byte-match the failing set of merged siblings #16274/#16280/#16269; website-unit + gate proven base-identical blobs.

Full context for agent readers

Waiver evidence (waiver-1, ruled by Christian: merge holds released, prove-inherited-then-merge):

  1. Sibling baseline: merged PRs refactor: read agent gate from server features #16274 (head 932313c), fix: require Web Crypto for UUID generation #16280 (head f39e6df), fix: use createUuidv4 fallback for insecure-context origins #16269 (head b47247f) — all into christian-byrne/integration-candidate-v2-ci-fix — each fail the identical 15-check set: e2e-status, playwright cloud, mobile-chrome, chromium shards 2,3,4,6,7,8,9,10,13,14,15,16. feat: report cmp event sink failures #16273 (head 25400c6, run 33290600747) fails exactly the same 15.
  2. website-unit + website-unit-gate (run 33290600624): proven inherited in reports/review/fe16273-fix-report.md — component blob 20eb839cde and test blob 54cd824d1d byte-identical on base and head (FDCT hero video autoplay assertion pre-dates this PR).
  3. Delta vs base = event-sink FE wiring only; no test files or website content touched.

Zero PR-specific failures → waiver applies.

@christian-byrne
christian-byrne merged commit 442d40a into christian-byrne/integration-candidate-v2-ci-fix Aug 30, 2026
92 of 109 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/evsink-fe-wiring branch August 30, 2026 07:22
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants