Repository navigation
test(assets): cover queue focus lifecycle race - #16256
christian-byrne wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1997 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-29T21:47:13.893Z",
"gitSha": "ee8462be9fb39d157f283f04e63b4ca42336d819",
"branch": "test/assets-focus-lifecycle",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2068.290999999988,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.408999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.499,
"heapDeltaBytes": -3429500,
"heapUsedBytes": 66025560,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.450999999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2037.4419999999418,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.499999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.18000000000006,
"heapDeltaBytes": -13467280,
"heapUsedBytes": 55894292,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.736,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2176.429999999982,
"styleRecalcs": 79,
"styleRecalcDurationMs": 38.712999999999994,
"layouts": 12,
"layoutDurationMs": 3.316,
"taskDurationMs": 1183.908,
"heapDeltaBytes": 4440404,
"heapUsedBytes": 73824560,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 141.25000000000003,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2203.3749999999372,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.606,
"layouts": 12,
"layoutDurationMs": 3.7300000000000004,
"taskDurationMs": 1174.9099999999999,
"heapDeltaBytes": -5221724,
"heapUsedBytes": 57105776,
"domNodes": -285,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 141.447,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.0680000000116,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.655999999999999,
"layouts": 6,
"layoutDurationMs": 0.5910000000000001,
"taskDurationMs": 340.449,
"heapDeltaBytes": 4321468,
"heapUsedBytes": 73792096,
"domNodes": 74,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.342000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.440999999937,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.739,
"layouts": 6,
"layoutDurationMs": 0.5680000000000001,
"taskDurationMs": 345.64099999999996,
"heapDeltaBytes": 4306064,
"heapUsedBytes": 73414448,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.678999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 709.6669999999676,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.812000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.0969999999999,
"heapDeltaBytes": -6187952,
"heapUsedBytes": 63250728,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 30.006999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 702.3289999999633,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.359000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.58,
"heapDeltaBytes": -6804732,
"heapUsedBytes": 62251756,
"domNodes": 14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 32.341,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2067.5410000000056,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.710999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.5709999999999,
"heapDeltaBytes": -19101080,
"heapUsedBytes": 72054536,
"domNodes": -274,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 43.456999999999994,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.5789999999897,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.443,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.838,
"heapDeltaBytes": -19341024,
"heapUsedBytes": 71901524,
"domNodes": -274,
"jsHeapTotalBytes": -790528,
"scriptDurationMs": 38.028000000000006,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 3214.027999999985,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2540.4,
"heapDeltaBytes": 26270504,
"heapUsedBytes": 91445180,
"domNodes": 0,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 940.261,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3150.263999999993,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.53,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2427.474,
"heapDeltaBytes": 24954904,
"heapUsedBytes": 89954260,
"domNodes": 0,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 875.516,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4316.220999999985,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.118,
"layouts": 60,
"layoutDurationMs": 7.93,
"taskDurationMs": 2493.233,
"heapDeltaBytes": 9650012,
"heapUsedBytes": 79081836,
"domNodes": 24,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 863.595,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4292.65799999996,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.796000000000001,
"layouts": 60,
"layoutDurationMs": 7.739,
"taskDurationMs": 2513.278,
"heapDeltaBytes": -188076,
"heapUsedBytes": 72407352,
"domNodes": -266,
"jsHeapTotalBytes": -2138112,
"scriptDurationMs": 852.185,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3175.5899999999997,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.670999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2015.484,
"heapDeltaBytes": 13563100,
"heapUsedBytes": 80965568,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 202.677,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3145.7739999999603,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.573000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2003.2459999999999,
"heapDeltaBytes": 12075588,
"heapUsedBytes": 79579800,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 190.83299999999997,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2017.1589999999924,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.160999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.9159999999999,
"heapDeltaBytes": -21106300,
"heapUsedBytes": 73583732,
"domNodes": -271,
"jsHeapTotalBytes": -790528,
"scriptDurationMs": 37.647000000000006,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2049.2850000000544,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.225,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.575,
"heapDeltaBytes": -22553060,
"heapUsedBytes": 72245784,
"domNodes": -272,
"jsHeapTotalBytes": -1314816,
"scriptDurationMs": 37.564,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 693.240000000003,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.558000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.3540000000001,
"heapDeltaBytes": -7866304,
"heapUsedBytes": 62873840,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 131.022,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 695.5140000000029,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.101999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.68699999999995,
"heapDeltaBytes": 17524988,
"heapUsedBytes": 87776476,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 132.45499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.0549999999898,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.101,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.463,
"heapDeltaBytes": -1451740,
"heapUsedBytes": 68750304,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.985000000000001,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.0729999999821,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.852999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.809,
"heapDeltaBytes": -10400188,
"heapUsedBytes": 59828992,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.995999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1789.4720000000461,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.303000000000004,
"layouts": 16,
"layoutDurationMs": 4.263,
"taskDurationMs": 971.0070000000001,
"heapDeltaBytes": -3234052,
"heapUsedBytes": 67460068,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 103.747,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1908.6609999999382,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.216,
"layouts": 16,
"layoutDurationMs": 4.516,
"taskDurationMs": 1098.251,
"heapDeltaBytes": -4936868,
"heapUsedBytes": 64925624,
"domNodes": -299,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 104.86499999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.5170000000971,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.133,
"layouts": 14,
"layoutDurationMs": 12.711,
"taskDurationMs": 900.0980000000001,
"heapDeltaBytes": 19664460,
"heapUsedBytes": 102249516,
"domNodes": 13671,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 28.011999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 119,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12291.928999999982,
"styleRecalcs": 242,
"styleRecalcDurationMs": 34.29900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9126.186,
"heapDeltaBytes": 23011352,
"heapUsedBytes": 87661416,
"domNodes": 0,
"jsHeapTotalBytes": 4124672,
"scriptDurationMs": 3248.9239999999995,
"eventListeners": 30,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12278.657000000067,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.76,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8783.705999999998,
"heapDeltaBytes": -24358680,
"heapUsedBytes": 66399896,
"domNodes": -273,
"jsHeapTotalBytes": 3141632,
"scriptDurationMs": 3044.181,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17959.672000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16940.805,
"heapDeltaBytes": -21883248,
"heapUsedBytes": 176253844,
"domNodes": -6548,
"jsHeapTotalBytes": -5378048,
"scriptDurationMs": 385.532,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17752.623999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16988.459,
"heapDeltaBytes": -26565612,
"heapUsedBytes": 179667428,
"domNodes": -6548,
"jsHeapTotalBytes": 139264,
"scriptDurationMs": 341.314,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21873.571000000025,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.487000000000034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21470.691,
"heapDeltaBytes": -29661188,
"heapUsedBytes": 175989496,
"domNodes": -6548,
"jsHeapTotalBytes": 139264,
"scriptDurationMs": 942.2049999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 137,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22025.50199999996,
"styleRecalcs": 173,
"styleRecalcDurationMs": 19.884000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21653.448,
"heapDeltaBytes": -40391752,
"heapUsedBytes": 171683232,
"domNodes": -6548,
"jsHeapTotalBytes": -3084288,
"scriptDurationMs": 936.032,
"eventListeners": -7467,
"totalBlockingTimeMs": 177,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 116.96499999993648,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.556000000000003,
"layouts": 6,
"layoutDurationMs": 1.987,
"taskDurationMs": 94.08999999999999,
"heapDeltaBytes": 3601656,
"heapUsedBytes": 70839576,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.385999999999999,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 140.69999999992433,
"styleRecalcs": 6,
"styleRecalcDurationMs": 16.509,
"layouts": 3,
"layoutDurationMs": 1.493,
"taskDurationMs": 104.08799999999998,
"heapDeltaBytes": 3596376,
"heapUsedBytes": 70104560,
"domNodes": 104,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.134999999999998,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## test/assets-pagination-retry #16256 +/- ##
================================================================
- Coverage 82.41% 82.39% -0.02%
================================================================
Files 1923 1923
Lines 109333 109332 -1
Branches 30775 30775
================================================================
- Hits 90103 90088 -15
- Misses 18887 18913 +26
+ Partials 343 331 -12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Retargeting this exact head to |
|
@coderabbitai review |
Rate Limit Exceeded
|
|
Rebase remains unsafe at current main. Full context for agent readersVerified against Conservative disposition: do not rewrite history or push this human-approved green head. Close #16256 as superseded unless the pagination/request-token production seam is intentionally returning; in that case, land that seam on main first and re-author this invariant against it. Program bookkeeping could not be pushed: |
|
Closing as superseded per the approved ruling. Full context for agent readersThe exact-head investigation found that current Christian approved closing this PR as superseded. If paginated queue focus returns, this invariant should be re-authored against the production seam that lands on |
Full context for agent readers
Adds a component regression test for overlapping queue “View item” requests when the user switches sidebar tabs while the older lookup is pending. The latest request must open Assets and select its exact job; after the user switches away, completion of the stale request must neither reopen Assets nor overwrite selection.
Validation:
Stacked on #16254 because this component path is introduced by the Assets pagination/focus stack.