Skip to content

test(assets): cover queue focus lifecycle race - #16256

Closed
christian-byrne wants to merge 1 commit into
test/assets-pagination-retryfrom
test/assets-focus-lifecycle
Closed

christian-byrne wants to merge 1 commit into
test/assets-pagination-retryfrom
test/assets-focus-lifecycle

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor
  • Pins queue focus across sidebar switches.
  • Stale requests cannot reopen or reselect.
  • Covers the queue-focus lifecycle-race case from the internal assets QA plan.
Full context for agent readers

Adds a component regression test for overlapping queue “View item” requests when the user switches sidebar tabs while the older lookup is pending. The latest request must open Assets and select its exact job; after the user switches away, completion of the stale request must neither reopen Assets nor overwrite selection.

Validation:

  • QueueProgressOverlay suite: 8/8
  • Typecheck, ESLint, oxfmt, and knip: green
  • Mutation proof: reopening Assets after an awaited stale lookup fails at the final tab assertion

Stacked on #16254 because this component path is introduced by the Assets pagination/focus stack.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 29, 2026
@christian-byrne christian-byrne self-assigned this Aug 29, 2026
@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 942bceec-10bb-4300-ad1f-afe02e959379

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1997 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1976 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/29/2026, 09:36:01 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 119ms TBT · 97.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.7 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 157ms TBT · 165.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 5ms
canvas-idle: layout count 0
canvas-idle: style recalc count 7
canvas-idle: task duration 522ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 58.1 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 39ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 1179ms
canvas-mouse-sweep: script duration 141ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.4 MB
canvas-mouse-sweep: DOM nodes -283
canvas-mouse-sweep: event listeners -171
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 343ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.2 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 409ms
dom-widget-clipping: script duration 31ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 59.8 MB
dom-widget-clipping: DOM nodes 15
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 575ms
large-graph-idle: script duration 41ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 68.6 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 62
large-graph-pan: task duration 2484ms
large-graph-pan: script duration 908ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 86.5 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 8
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 2503ms
large-graph-zoom: script duration 858ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.2 MB
large-graph-zoom: DOM nodes -121
large-graph-zoom: event listeners -84
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 2009ms
legacy-node-drag: script duration 197ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 76.6 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 544ms
minimap-idle: script duration 38ms
minimap-idle: TBT 0ms
minimap-idle: heap used 69.5 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -155
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 499ms
subgraph-dom-widget-clipping: script duration 132ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.8 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 482ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.3 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 36ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 1035ms
subgraph-mouse-sweep: script duration 104ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.1 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -200
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 900ms
subgraph-transition-enter: script duration 28ms
subgraph-transition-enter: TBT 119ms
subgraph-transition-enter: heap used 97.5 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 245
viewport-pan-sweep: task duration 8955ms
viewport-pan-sweep: script duration 3147ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.5 MB
viewport-pan-sweep: DOM nodes -137
viewport-pan-sweep: event listeners -50
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16965ms
vue-large-graph-idle: script duration 363ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.7 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 177
vue-large-graph-pan: task duration 21562ms
vue-large-graph-pan: script duration 939ms
vue-large-graph-pan: TBT 157ms
vue-large-graph-pan: heap used 165.8 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 5
workflow-execution: style recalc count 8
workflow-execution: task duration 99ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.2 MB
workflow-execution: DOM nodes 117
workflow-execution: event listeners 37
Raw data
{
  "timestamp": "2026-08-29T21:47:13.893Z",
  "gitSha": "ee8462be9fb39d157f283f04e63b4ca42336d819",
  "branch": "test/assets-focus-lifecycle",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2068.290999999988,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.408999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 559.499,
      "heapDeltaBytes": -3429500,
      "heapUsedBytes": 66025560,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.450999999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.4419999999418,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.499999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.18000000000006,
      "heapDeltaBytes": -13467280,
      "heapUsedBytes": 55894292,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.736,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2176.429999999982,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 38.712999999999994,
      "layouts": 12,
      "layoutDurationMs": 3.316,
      "taskDurationMs": 1183.908,
      "heapDeltaBytes": 4440404,
      "heapUsedBytes": 73824560,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 141.25000000000003,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2203.3749999999372,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 38.606,
      "layouts": 12,
      "layoutDurationMs": 3.7300000000000004,
      "taskDurationMs": 1174.9099999999999,
      "heapDeltaBytes": -5221724,
      "heapUsedBytes": 57105776,
      "domNodes": -285,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 141.447,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1711.0680000000116,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.655999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.5910000000000001,
      "taskDurationMs": 340.449,
      "heapDeltaBytes": 4321468,
      "heapUsedBytes": 73792096,
      "domNodes": 74,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.342000000000004,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1720.440999999937,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 14.739,
      "layouts": 6,
      "layoutDurationMs": 0.5680000000000001,
      "taskDurationMs": 345.64099999999996,
      "heapDeltaBytes": 4306064,
      "heapUsedBytes": 73414448,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.678999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 709.6669999999676,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.812000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.0969999999999,
      "heapDeltaBytes": -6187952,
      "heapUsedBytes": 63250728,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 30.006999999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 702.3289999999633,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.359000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.58,
      "heapDeltaBytes": -6804732,
      "heapUsedBytes": 62251756,
      "domNodes": 14,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 32.341,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2067.5410000000056,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.710999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.5709999999999,
      "heapDeltaBytes": -19101080,
      "heapUsedBytes": 72054536,
      "domNodes": -274,
      "jsHeapTotalBytes": -1839104,
      "scriptDurationMs": 43.456999999999994,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.5789999999897,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.443,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 571.838,
      "heapDeltaBytes": -19341024,
      "heapUsedBytes": 71901524,
      "domNodes": -274,
      "jsHeapTotalBytes": -790528,
      "scriptDurationMs": 38.028000000000006,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3214.027999999985,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.621,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2540.4,
      "heapDeltaBytes": 26270504,
      "heapUsedBytes": 91445180,
      "domNodes": 0,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 940.261,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3150.263999999993,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.53,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2427.474,
      "heapDeltaBytes": 24954904,
      "heapUsedBytes": 89954260,
      "domNodes": 0,
      "jsHeapTotalBytes": 1798144,
      "scriptDurationMs": 875.516,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4316.220999999985,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.118,
      "layouts": 60,
      "layoutDurationMs": 7.93,
      "taskDurationMs": 2493.233,
      "heapDeltaBytes": 9650012,
      "heapUsedBytes": 79081836,
      "domNodes": 24,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 863.595,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4292.65799999996,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.796000000000001,
      "layouts": 60,
      "layoutDurationMs": 7.739,
      "taskDurationMs": 2513.278,
      "heapDeltaBytes": -188076,
      "heapUsedBytes": 72407352,
      "domNodes": -266,
      "jsHeapTotalBytes": -2138112,
      "scriptDurationMs": 852.185,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3175.5899999999997,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.670999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2015.484,
      "heapDeltaBytes": 13563100,
      "heapUsedBytes": 80965568,
      "domNodes": 0,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 202.677,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3145.7739999999603,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.573000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2003.2459999999999,
      "heapDeltaBytes": 12075588,
      "heapUsedBytes": 79579800,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 190.83299999999997,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.1589999999924,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.160999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.9159999999999,
      "heapDeltaBytes": -21106300,
      "heapUsedBytes": 73583732,
      "domNodes": -271,
      "jsHeapTotalBytes": -790528,
      "scriptDurationMs": 37.647000000000006,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2049.2850000000544,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.225,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 556.575,
      "heapDeltaBytes": -22553060,
      "heapUsedBytes": 72245784,
      "domNodes": -272,
      "jsHeapTotalBytes": -1314816,
      "scriptDurationMs": 37.564,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 693.240000000003,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.558000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.3540000000001,
      "heapDeltaBytes": -7866304,
      "heapUsedBytes": 62873840,
      "domNodes": 16,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 131.022,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 695.5140000000029,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.101999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.68699999999995,
      "heapDeltaBytes": 17524988,
      "heapUsedBytes": 87776476,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 132.45499999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.0549999999898,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.101,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.463,
      "heapDeltaBytes": -1451740,
      "heapUsedBytes": 68750304,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.985000000000001,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.0729999999821,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.852999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.809,
      "heapDeltaBytes": -10400188,
      "heapUsedBytes": 59828992,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.995999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1789.4720000000461,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.303000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.263,
      "taskDurationMs": 971.0070000000001,
      "heapDeltaBytes": -3234052,
      "heapUsedBytes": 67460068,
      "domNodes": -294,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 103.747,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1908.6609999999382,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 36.216,
      "layouts": 16,
      "layoutDurationMs": 4.516,
      "taskDurationMs": 1098.251,
      "heapDeltaBytes": -4936868,
      "heapUsedBytes": 64925624,
      "domNodes": -299,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 104.86499999999998,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1383.5170000000971,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 29.133,
      "layouts": 14,
      "layoutDurationMs": 12.711,
      "taskDurationMs": 900.0980000000001,
      "heapDeltaBytes": 19664460,
      "heapUsedBytes": 102249516,
      "domNodes": 13671,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 28.011999999999997,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 119,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12291.928999999982,
      "styleRecalcs": 242,
      "styleRecalcDurationMs": 34.29900000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9126.186,
      "heapDeltaBytes": 23011352,
      "heapUsedBytes": 87661416,
      "domNodes": 0,
      "jsHeapTotalBytes": 4124672,
      "scriptDurationMs": 3248.9239999999995,
      "eventListeners": 30,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12278.657000000067,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 38.76,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8783.705999999998,
      "heapDeltaBytes": -24358680,
      "heapUsedBytes": 66399896,
      "domNodes": -273,
      "jsHeapTotalBytes": 3141632,
      "scriptDurationMs": 3044.181,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17959.672000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16940.805,
      "heapDeltaBytes": -21883248,
      "heapUsedBytes": 176253844,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5378048,
      "scriptDurationMs": 385.532,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17752.623999999967,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16988.459,
      "heapDeltaBytes": -26565612,
      "heapUsedBytes": 179667428,
      "domNodes": -6548,
      "jsHeapTotalBytes": 139264,
      "scriptDurationMs": 341.314,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21873.571000000025,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 20.487000000000034,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21470.691,
      "heapDeltaBytes": -29661188,
      "heapUsedBytes": 175989496,
      "domNodes": -6548,
      "jsHeapTotalBytes": 139264,
      "scriptDurationMs": 942.2049999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 137,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22025.50199999996,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 19.884000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21653.448,
      "heapDeltaBytes": -40391752,
      "heapUsedBytes": 171683232,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3084288,
      "scriptDurationMs": 936.032,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 177,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 116.96499999993648,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 15.556000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.987,
      "taskDurationMs": 94.08999999999999,
      "heapDeltaBytes": 3601656,
      "heapUsedBytes": 70839576,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.385999999999999,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 140.69999999992433,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 16.509,
      "layouts": 3,
      "layoutDurationMs": 1.493,
      "taskDurationMs": 104.08799999999998,
      "heapDeltaBytes": 3596376,
      "heapUsedBytes": 70104560,
      "domNodes": 104,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.134999999999998,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 29, 2026
@codecov

codecov Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                       Coverage Diff                        @@
##           test/assets-pagination-retry   #16256      +/-   ##
================================================================
- Coverage                         82.41%   82.39%   -0.02%     
================================================================
  Files                              1923     1923              
  Lines                            109333   109332       -1     
  Branches                          30775    30775              
================================================================
- Hits                              90103    90088      -15     
- Misses                            18887    18913      +26     
+ Partials                            343      331      -12     
Flag Coverage Δ
e2e 67.01% <ø> (-0.03%) ⬇️
unit 74.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Retargeting this exact head to main@a85d6d7c3eddf5337814e1747f56202c8df5549c is currently dependency-blocked. The sole #16256 commit adds the focus-lifecycle race test, but its fixtures (loadOutputAssetMock, itemToView, assetSelectionStore) and the production assetFocusRequest guard live in the stacked parent lineage; current main still calls assetsStore.updateHistory() without request identity. Rebasing only ccaf6d1940 produces a content conflict and a non-compiling test, while flattening the parent would pull roughly 60 unrelated asset-stack files into this PR. I left the head byte-for-byte unchanged. Resume by first landing a main-based carrier for the pagination/request-token seam, then replay this one test commit onto that carrier and retarget to main.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Rate Limit Exceeded

@christian-byrne have exceeded the limit for the number of chat messages per hour. Please wait 4 minutes and 21 seconds before sending another message.

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Rebase remains unsafe at current main.
The tested async race no longer exists there.
Decision tracked in https://github.com/christian-byrne/blocked-on-christian/issues/291.

Full context for agent readers

Verified against main@3277c2782dce4ef668a1f530928820d9a8f669e9: QueueProgressOverlay.vue contains neither loadOutputAsset nor assetFocusRequest. Its current focus path opens Assets, awaits only Vue nextTick, then selects the preview-backed job ID. The PR's sole test depends on the old asynchronous pagination seam and four fixtures absent from main. Parent #16254 remains conflicting and flattening it would import 70+ unrelated stack commits.

Conservative disposition: do not rewrite history or push this human-approved green head. Close #16256 as superseded unless the pagination/request-token production seam is intentionally returning; in that case, land that seam on main first and re-author this invariant against it.

Program bookkeeping could not be pushed: todo.md has two active rows with this exact ID, so the reservation guard rejected the claim, and both mandatory 120-second program lock attempts were occupied. The commander receives the exact row update separately.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing as superseded per the approved ruling.
Current main no longer has the asynchronous request seam this regression covers.

Full context for agent readers

The exact-head investigation found that current main contains neither loadOutputAsset nor assetFocusRequest; the test's fixtures and request-token production seam exist only in the old stacked lineage. Flattening that lineage would import more than 70 unrelated commits. Evidence: #16256 (comment).

Christian approved closing this PR as superseded. If paginated queue focus returns, this invariant should be re-authored against the production seam that lands on main, rather than reviving the obsolete stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants