Skip to content

ci: protect release branches from merge skew - #16129

Merged
christian-byrne merged 1 commit into
mainfrom
chore/typegen-release-safety
Aug 27, 2026
Merged

christian-byrne merged 1 commit into
mainfrom
chore/typegen-release-safety

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Prevent release branches from accepting merge-skew type failures without ownership.

Changes

  • run the application typecheck in the shared PR, merge-queue, and post-merge verification path
  • alert #frontend-releases when that check fails after a release-branch push
  • document that ingest types must be generated from the Cloud contract, never hand-written during backports

Review Focus

The alert is limited to failed push runs on cloud/** and core/**; PR and merge-queue failures do not notify Slack.

Verification

  • pnpm typecheck
  • oxfmt check on changed files
  • actionlint on the new workflow

Related: #16085

@christian-byrne
christian-byrne requested a review from a team August 27, 2026 20:18
@christian-byrne christian-byrne self-assigned this Aug 27, 2026
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 27 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 90 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f2ad3dd1-4a98-43e5-ad78-af466cc6c260

📥 Commits

Reviewing files that changed from the base of the PR and between 92efbae and 2ecf64f.

📒 Files selected for processing (3)
  • .github/actions/lint-format-verify/action.yml
  • .github/workflows/release-branch-ci-alert.yaml
  • docs/release-process.md

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2019 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1998 / ❌ 0 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 9.61 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 40.8 MB baseline 40.8 MB — ⚪ 0 B
  • Gzip: 9.61 MB baseline 9.61 MB — ⚪ 0 B
  • Brotli: 6.76 MB baseline 6.76 MB — ⚪ 0 B
  • Bundles: 451 current • 451 baseline

Category Glance
Vendor & Third-Party ⚪ 0 B (18.1 MB) · Other ⚪ 0 B (16.2 MB) · Data & Services ⚪ 0 B (3.55 MB) · Graph Workspace ⚪ 0 B (1.39 MB) · Panels & Settings ⚪ 0 B (622 kB) · Utilities & Hooks ⚪ 0 B (555 kB) · + 5 more

App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.39 MB (baseline 1.39 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 28 unchanged

User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 115 kB (baseline 115 kB) • ⚪ 0 B

Reusable component library chunks

Status: 15 unchanged

Data & Services — 3.55 MB (baseline 3.55 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 37 unchanged

Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 16.2 MB (baseline 16.2 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 296 unchanged

⚡ Performance

⏳ Performance tests in progress…

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 27, 2026
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #16129      +/-   ##
==========================================
+ Coverage   80.62%   82.65%   +2.03%     
==========================================
  Files        2292     1942     -350     
  Lines      118024   111949    -6075     
  Branches    34125    32747    -1378     
==========================================
- Hits        95153    92530    -2623     
+ Misses      22319    19074    -3245     
+ Partials      552      345     -207     
Flag Coverage Δ
e2e 66.72% <ø> (+<0.01%) ⬆️
unit 75.09% <ø> (ø)
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 353 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL added this pull request to the merge queue Aug 27, 2026
@DrJKL
DrJKL removed this pull request from the merge queue due to a manual request Aug 27, 2026
@christian-byrne
christian-byrne added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit 5942200 Aug 27, 2026
88 checks passed
@christian-byrne
christian-byrne deleted the chore/typegen-release-safety branch August 27, 2026 22:10
mattmillerai pushed a commit that referenced this pull request Aug 29, 2026
## Summary

Prevent release branches from accepting merge-skew type failures without
ownership.

## Changes

- run the application typecheck in the shared PR, merge-queue, and
post-merge verification path
- alert `#frontend-releases` when that check fails after a
release-branch push
- document that ingest types must be generated from the Cloud contract,
never hand-written during backports

## Review Focus

The alert is limited to failed push runs on `cloud/**` and `core/**`; PR
and merge-queue failures do not notify Slack.

## Verification

- `pnpm typecheck`
- oxfmt check on changed files
- actionlint on the new workflow

Related: #16085
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants