Repository navigation
fix: bound asset pagination and resolve queued outputs - #16070
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR updates asset pagination to return progress booleans, prevent duplicate or cyclic cursor loads, and coordinate output-asset loading. Queue inspection selects assets only after successful, current requests. Tests cover pagination, failures, overlaps, and stale requests. ChangesAsset pagination and selection
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~30 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant QueueProgressOverlay
participant assetsStore
participant useAssetsQuery
participant AssetsSidebar
QueueProgressOverlay->>assetsStore: loadOutputAsset(assetId)
assetsStore->>useAssetsQuery: loadMore()
useAssetsQuery-->>assetsStore: return pagination progress
assetsStore-->>QueueProgressOverlay: return asset availability
QueueProgressOverlay->>AssetsSidebar: select current asset
Possibly related PRs
Suggested labels: Suggested reviewers: Merge Risk: 🔵 Low · up to Strengthen the deletion regression fixture before relying on it to protect OSS output deletion. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The title uses the bug-fix signal “fix”. The PR changes frontend files under ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
benjcooley
left a comment
There was a problem hiding this comment.
The OSS/history pagination path can skip a full page during the normal sidebar-open flow, so older queue entries may remain unresolvable.
| Severity | Count |
|---|---|
| BLOCKER | 1 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed this with five parallel readers over the diff, then re-verified the top findings at source myself rather than trusting the agreement. Four readers converged independently on the same defect, which is the first comment below.
The bounded-pagination work itself holds up well: cursor termination in doLoadMore covers repeated, self-referential and A->B->A cursors, invalidate re-seeds correctly, dedup preserves API order, and the model walk has a real MAX_PAGINATION_BATCHES backstop. assetsStore.loadOutputAsset:301 also consumes the new contract exactly right. The problems are at the edges of that contract, not in it.
Two of the inline comments are correctness bugs rather than polish: the unterminated request loop, and a crash in the multi-output delete path.
Below this line are findings from the readers that I did not personally re-verify, so please treat them as leads rather than conclusions:
useAssetsQuery.ts:111invalidate(stale)is the one mutation path that bypasses the preemptable queue, so it filtersitemswithout aborting or awaiting an in-flight page. A page issued before a delete can re-append the deleted asset, which then renders as live until a full invalidate.loadOutputAsset, the function this PR is named for, has no direct test.QueueProgressOverlay.test.ts:24mocks it out entirely, so a regression making that loop unbounded or always-true would pass the suite.- The history-assets suite (roughly 24 tests: offset pagination,
loadedIdsdedup,MAX_HISTORY_ITEMSeviction,outputCountfallback chain) was deleted whileuseHistoryAssets()survives essentially verbatim. That is the default path for OSS users. - Two surviving tests look vacuous now:
useJobMenu.test.ts:711callsentry?.onClick?.()on adeleteentry the PR removed, so it passes trivially;useComboWidget.test.ts:801passes purely becausebeforeEachleaveshasMorefalse, independent of theitemsit sets up. - OSS delete:
assetService.deleteAssetis now called unconditionally, where the old code routed output/temp assets toapi.deleteItem('history', jobId). The history delete still succeeds, so the file goes away, butsucceededis 0 and the user gets a failure toast.
One process note: pnpm typecheck passing is expected here and does not cover most of this. Every inline finding below typechecks cleanly.
## Summary Covers cancelled single and grouped asset deletion. Proves cancel sends no delete/history request and mutates no cache or graph state. ## Review Focus **Coverage** - Verifies single-delete confirmation title, description, and flattened item list. - Verifies grouped output count and names before bulk cancellation. - Verifies cancellation resolves `false` and does not touch Asset DELETE, history deletion, deleting overlays, model caches, output/input reloads, missing-media state, preview cache, widget values, or workflow change tracking. **Validation** - `useMediaAssetActions.test.ts`: 45/45 passed - Known-green `LLink.test.ts` control: 4/4 passed - Mutation: issuing Asset DELETE from `onCancel` failed both new tests at the exact no-DELETE assertion - `vue-tsc --noEmit`: exit 0 - ESLint, Oxfmt, Knip, and `git diff --check`: green Test-only change. Stacked on Comfy-Org#16070 because the Assets-backed panel has not landed on its parent branch.
b6b4559 to
7f61565
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 2120 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.98 MB gzip 🔴 +481 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.44 MB) • 🔴 +275 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.93 MB (baseline 3.93 MB) • 🔴 +2 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • 🔴 +105 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • 🔴 +9 BBundles that do not match a named category
Status: 74 added / 74 removed / 228 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T06:15:07.502Z",
"gitSha": "c7cd3858ba45573b359baafc5bb57abc03f03736",
"branch": "drjkl/fix-assets-pagination-review",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1990.8780000000093,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.057999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.483,
"heapDeltaBytes": 8013328,
"heapUsedBytes": 75544620,
"domNodes": -258,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.379,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2005.5600000000595,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.873000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.723,
"heapDeltaBytes": -9442612,
"heapUsedBytes": 58209988,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.376000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.3060000000241,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.737999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 831.548,
"heapDeltaBytes": -1603332,
"heapUsedBytes": 65149492,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 151.73,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.1479999999901,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.873999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 820.778,
"heapDeltaBytes": 13684776,
"heapUsedBytes": 81129480,
"domNodes": -260,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 150.567,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.3720000000362,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.762,
"layouts": 6,
"layoutDurationMs": 1.2449999999999999,
"taskDurationMs": 376.965,
"heapDeltaBytes": 3156172,
"heapUsedBytes": 70679792,
"domNodes": 80,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.102000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.6120000000456,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.695,
"layouts": 6,
"layoutDurationMs": 1.186,
"taskDurationMs": 299.807,
"heapDeltaBytes": 3099064,
"heapUsedBytes": 70795732,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.903,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 636.3440000000082,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.620999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.028,
"heapDeltaBytes": 18306200,
"heapUsedBytes": 86169036,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 159.42199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 679.980999999998,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.242,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.80699999999996,
"heapDeltaBytes": 18982916,
"heapUsedBytes": 86491060,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 167.05700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1145.0869999999895,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 822.2529999999999,
"heapDeltaBytes": 35295464,
"heapUsedBytes": 105886428,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 62.681,
"eventListeners": 0,
"totalBlockingTimeMs": 535,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1207.6199999999062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 890.6010000000001,
"heapDeltaBytes": -17373820,
"heapUsedBytes": 72598588,
"domNodes": -295,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 66.157,
"eventListeners": -217,
"totalBlockingTimeMs": 537,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 812.3679999999922,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.11100000000033,
"heapDeltaBytes": 14858096,
"heapUsedBytes": 90043972,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 143.31499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 186,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 813.1700000000137,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.11600000000027,
"heapDeltaBytes": 14571588,
"heapUsedBytes": 91152548,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.33399999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 185,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9773.672000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8858.824999999999,
"heapDeltaBytes": -7548208,
"heapUsedBytes": 74343840,
"domNodes": -12,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 6980.434,
"eventListeners": 0,
"totalBlockingTimeMs": 561,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9678.28499999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8808.921999999999,
"heapDeltaBytes": -11277556,
"heapUsedBytes": 70820396,
"domNodes": -14,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7028.881,
"eventListeners": 0,
"totalBlockingTimeMs": 537,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9415.442000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8573.072,
"heapDeltaBytes": 4532784,
"heapUsedBytes": 86723532,
"domNodes": -14,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 7086.22,
"eventListeners": 0,
"totalBlockingTimeMs": 701,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9191.404999999919,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8348.681,
"heapDeltaBytes": 16439856,
"heapUsedBytes": 92647252,
"domNodes": -8,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6580.851,
"eventListeners": 0,
"totalBlockingTimeMs": 349,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2057.762999999966,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.363000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.9670000000001,
"heapDeltaBytes": -5774924,
"heapUsedBytes": 81109228,
"domNodes": -250,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 32.73699999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.9840000000559,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.738999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.785,
"heapDeltaBytes": -3005988,
"heapUsedBytes": 83604648,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.251000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2660.98599999998,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.046000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1714.2250000000004,
"heapDeltaBytes": 20861468,
"heapUsedBytes": 84926360,
"domNodes": -244,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 859.9669999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2378.955000000019,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.934000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1726.1460000000002,
"heapDeltaBytes": -18860452,
"heapUsedBytes": 68748448,
"domNodes": -216,
"jsHeapTotalBytes": 2125824,
"scriptDurationMs": 835.858,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3576.793000000009,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.935999999999996,
"layouts": 60,
"layoutDurationMs": 13.854,
"taskDurationMs": 1588.6660000000002,
"heapDeltaBytes": 8204460,
"heapUsedBytes": 74182196,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 778.1009999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3620.3800000000683,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.700000000000003,
"layouts": 60,
"layoutDurationMs": 13.617,
"taskDurationMs": 1711.4920000000002,
"heapDeltaBytes": 7811184,
"heapUsedBytes": 73837000,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.9499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3102.6540000000296,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.715999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1923.204,
"heapDeltaBytes": 27278168,
"heapUsedBytes": 92806668,
"domNodes": -254,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 956.577,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3141.238000000044,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.179999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1958.3319999999999,
"heapDeltaBytes": 19450816,
"heapUsedBytes": 84250832,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 969.8860000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.1510000000121,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.2499999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 574.0070000000001,
"heapDeltaBytes": 20104112,
"heapUsedBytes": 84722744,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.73899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 1999.5449999998982,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.27,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.84900000000005,
"heapDeltaBytes": 20132688,
"heapUsedBytes": 84605380,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.432,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 620.9330000000364,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.233999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.484,
"heapDeltaBytes": 14119056,
"heapUsedBytes": 83903036,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.43800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.4690000000319,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.707,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.00399999999996,
"heapDeltaBytes": 13616436,
"heapUsedBytes": 83429408,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.893,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2015.3609999999844,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.566,
"heapDeltaBytes": -6378824,
"heapUsedBytes": 63895128,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.642000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2001.8850000000157,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.847999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.50500000000005,
"heapDeltaBytes": -14177760,
"heapUsedBytes": 55870540,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.920000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.5719999999665,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.077,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 818.9170000000001,
"heapDeltaBytes": 5219432,
"heapUsedBytes": 74232088,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 104.626,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.055999999995,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.504,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 791.599,
"heapDeltaBytes": -7614056,
"heapUsedBytes": 62185932,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 103.011,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.6470000000336,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.287999999999997,
"layouts": 5,
"layoutDurationMs": 11.107000000000003,
"taskDurationMs": 884.8940000000001,
"heapDeltaBytes": 20292028,
"heapUsedBytes": 103755912,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 29.885999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8433.73600000001,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.644,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5898.926,
"heapDeltaBytes": -10698684,
"heapUsedBytes": 76129436,
"domNodes": -244,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2700.949,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8659.915999999954,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.913000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5969.226,
"heapDeltaBytes": -5441428,
"heapUsedBytes": 80743308,
"domNodes": -244,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2792.851,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15244.66799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14985.892000000002,
"heapDeltaBytes": -24126148,
"heapUsedBytes": 190781488,
"domNodes": -8090,
"jsHeapTotalBytes": -11591680,
"scriptDurationMs": 233.555,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15112.656000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14835.987000000001,
"heapDeltaBytes": -30191888,
"heapUsedBytes": 177771424,
"domNodes": -8061,
"jsHeapTotalBytes": -6828032,
"scriptDurationMs": 283.073,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 18404.05099999998,
"styleRecalcs": 127,
"styleRecalcDurationMs": 16.07699999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18243.994000000002,
"heapDeltaBytes": -51054804,
"heapUsedBytes": 190327740,
"domNodes": -8061,
"jsHeapTotalBytes": -18096128,
"scriptDurationMs": 937.176,
"eventListeners": -14928,
"totalBlockingTimeMs": 82,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13973.197000000027,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.744000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13701.041999999998,
"heapDeltaBytes": -46414104,
"heapUsedBytes": 168265604,
"domNodes": -8061,
"jsHeapTotalBytes": -13963264,
"scriptDurationMs": 803.329,
"eventListeners": -14928,
"totalBlockingTimeMs": 21,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5544.713000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.683,
"layouts": 20,
"layoutDurationMs": 26.154999999999998,
"taskDurationMs": 5470.950000000001,
"heapDeltaBytes": -47383696,
"heapUsedBytes": 187115308,
"domNodes": -8062,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 98.216,
"eventListeners": -14927,
"totalBlockingTimeMs": 300,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5594.346999999971,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.802,
"layouts": 20,
"layoutDurationMs": 26.363999999999997,
"taskDurationMs": 5558.354,
"heapDeltaBytes": -60043740,
"heapUsedBytes": 181498232,
"domNodes": -8061,
"jsHeapTotalBytes": 11857920,
"scriptDurationMs": 103.33399999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 355,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5447.988000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5308.400000000001,
"heapDeltaBytes": 1342600,
"heapUsedBytes": 190976100,
"domNodes": 0,
"jsHeapTotalBytes": -21495808,
"scriptDurationMs": 86.68499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7476.1760000000095,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7391.743999999999,
"heapDeltaBytes": -1994532,
"heapUsedBytes": 170977652,
"domNodes": 0,
"jsHeapTotalBytes": -23592960,
"scriptDurationMs": 110.49999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 136.9009999999662,
"styleRecalcs": 10,
"styleRecalcDurationMs": 22.369999999999997,
"layouts": 5,
"layoutDurationMs": 2.8220000000000005,
"taskDurationMs": 118.88800000000002,
"heapDeltaBytes": 3425120,
"heapUsedBytes": 68975160,
"domNodes": 143,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.274,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 467.1650000000227,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.160999999999998,
"layouts": 5,
"layoutDurationMs": 2.5780000000000003,
"taskDurationMs": 134.21699999999998,
"heapDeltaBytes": 4985116,
"heapUsedBytes": 70589764,
"domNodes": 146,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.998999999999997,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 091325836a8172dbfecbb4cd51285ba69db98e18
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
7f61565 to
a248f55
Compare
benjcooley
left a comment
There was a problem hiding this comment.
Two correctness blockers remain after the review-fix push:
- OSS history refresh and pagination still mutate the same
historyOffsetoutside one serialization boundary.loadMorePromisededuplicates pagination calls only;updateHistory()can still race it, request offset 0 concurrently, and skip the next page. - The required
loadMore(): Promise<boolean>contract is still ignored by the combo-widgetloadAll()loop. JSON decode and schema-parse failures leavehasMoretrue, so a malformed successful response can still produce an unterminated request/repaint loop.
The nested-ref can-load-more binding also remains open as a non-blocking issue. I verified and resolved the missing-media and deletion-mapping threads. The latest-request-wins selection guard and its real-store component test look good.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #16070 +/- ##
==========================================
+ Coverage 83.51% 84.54% +1.02%
==========================================
Files 2989 2286 -703
Lines 148019 130811 -17208
Branches 40125 36667 -3458
==========================================
- Hits 123619 110591 -13028
+ Misses 23115 19921 -3194
+ Partials 1285 299 -986
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 712 files with indirect coverage changes 🚀 New features to boost your workflow:
|
benjcooley
left a comment
There was a problem hiding this comment.
The new commits resolve the remaining pagination/concurrency blockers. Invalidations are serialized so distinct stale-ID removals and stale-then-full refreshes retain their semantics; concurrent loadMore callers share the same progress result; missing-output lookup now has a finite 20-page bound; and the OSS deletion regression now distinguishes asset IDs from job IDs. The focused regressions exercise the previously failing interleavings and the full CI suite is green.
Summary
Replacement for #16021 that includes its bounded pagination fixes plus the requested review corrections.
Changes
Review Focus
Please verify cursor termination, the
loadMore(): Promise<boolean>contract, and latest-request-wins selection behavior.Verification
pnpm typecheckpasses.pnpm format:checkpass.pnpm fallow:audit --base origin/pr-16021passes with no new findings.