Skip to content

test(assets): cover bounded queue focus - #16222

Closed
christian-byrne wants to merge 76 commits into
Comfy-Org:drjkl/fix-assets-pagination-reviewfrom
christian-byrne:test/assets-bounded-queue-focus
Closed

christian-byrne wants to merge 76 commits into
Comfy-Org:drjkl/fix-assets-pagination-reviewfrom
christian-byrne:test/assets-bounded-queue-focus

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Stacked on #16070 because that replacement changes pagination ownership to loadMore(): Promise<boolean> and does not include #16021's direct output-lookup tests.

Changes

  • Proves queued-output lookup terminates when pagination cannot advance.
  • Keeps the Assets sidebar usable without selecting a missing output.
  • Covers the bounded queue-pagination and queue-focus cases from the internal assets QA plan.

Review Focus

The store tests prove multi-page lookup and termination on a repeated/non-advancing cursor. The component test proves a bounded miss leaves selection empty and the sidebar operable.

The 1,000-page-cap pagination case remains attached to #16021's implementation and is not claimed here.

Verification

Verification:

  • Focused suites: 9 passed.
  • Typecheck, targeted lint/format, and knip: green.
  • Mutation proof: ignoring a false lookup result fails on the exact empty-selection assertion.

One test is failing and will need to be addressed
Need to put some further thought into loadNew invalidation.
Ideal case is that output is flagged stale and async fetch doesn't occur
if there isn't active dependent? But per current design specs, all
existent views should be subscribed and thus require update.

That a new 'output' asset might farm out 3 requests (all: load node,
outputs, outputs+temp) leaves a bad taste in my mouth
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 29, 2026
@christian-byrne christian-byrne self-assigned this Aug 29, 2026
@github-actions

github-actions Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: 🚧 Building...

🎭 Playwright: ✅ 1997 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1976 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 99ms TBT · 96.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 3ms TBT · 171.7 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 15ms TBT · 183.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 504ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.9 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -187
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 38ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 1050ms
canvas-mouse-sweep: script duration 129ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.1 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -170
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 304ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.7 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 363ms
dom-widget-clipping: script duration 29ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 68.8 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 549ms
large-graph-idle: script duration 40ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 65.7 MB
large-graph-idle: DOM nodes -277
large-graph-idle: event listeners -166
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 2311ms
large-graph-pan: script duration 797ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.0 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -149
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 68
large-graph-zoom: task duration 2283ms
large-graph-zoom: script duration 747ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 69.7 MB
large-graph-zoom: DOM nodes -265
large-graph-zoom: event listeners -181
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1810ms
legacy-node-drag: script duration 191ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 76.0 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 1ms
minimap-idle: layout count 0
minimap-idle: style recalc count 2
minimap-idle: task duration 480ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.8 MB
minimap-idle: DOM nodes -136
minimap-idle: event listeners 6
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 427ms
subgraph-dom-widget-clipping: script duration 115ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.8 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 473ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.0 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -232
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 38ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 966ms
subgraph-mouse-sweep: script duration 101ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.3 MB
subgraph-mouse-sweep: DOM nodes -298
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 27ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 856ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 99ms
subgraph-transition-enter: heap used 96.9 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 7864ms
viewport-pan-sweep: script duration 2641ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.3 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -126
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14748ms
vue-large-graph-idle: script duration 299ms
vue-large-graph-idle: TBT 3ms
vue-large-graph-idle: heap used 171.7 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 136
vue-large-graph-pan: task duration 17804ms
vue-large-graph-pan: script duration 770ms
vue-large-graph-pan: TBT 15ms
vue-large-graph-pan: heap used 183.7 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7472
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 90ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.3 MB
workflow-execution: DOM nodes 138
workflow-execution: event listeners 61
Raw data
{
  "timestamp": "2026-08-29T09:18:55.682Z",
  "gitSha": "70d20c4e8080b114f6a02401a67967056568f73b",
  "branch": "test/assets-bounded-queue-focus",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2057.801999999981,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.028,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.79200000000003,
      "heapDeltaBytes": 4972548,
      "heapUsedBytes": 67437936,
      "domNodes": -280,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 9.756,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2009.633000000008,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.501999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.846,
      "heapDeltaBytes": -2826776,
      "heapUsedBytes": 66646244,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 10.402,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1992.5690000000031,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 37.271,
      "layouts": 12,
      "layoutDurationMs": 3.048,
      "taskDurationMs": 1035.57,
      "heapDeltaBytes": 4523740,
      "heapUsedBytes": 73802204,
      "domNodes": -277,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 128.45299999999997,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2041.3340000000062,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 38.59199999999999,
      "layouts": 12,
      "layoutDurationMs": 3.0730000000000004,
      "taskDurationMs": 1063.683,
      "heapDeltaBytes": -10688508,
      "heapUsedBytes": 58563596,
      "domNodes": -281,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 129.39399999999998,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.9839999999867,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.65,
      "layouts": 6,
      "layoutDurationMs": 0.5299999999999999,
      "taskDurationMs": 305.41,
      "heapDeltaBytes": 4331972,
      "heapUsedBytes": 74122436,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.054,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1705.5970000000116,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 13.575000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.585,
      "taskDurationMs": 303.091,
      "heapDeltaBytes": 4090400,
      "heapUsedBytes": 74148160,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.329,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 728.3940000000371,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.294999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 361.65999999999997,
      "heapDeltaBytes": 19721868,
      "heapUsedBytes": 81956024,
      "domNodes": 14,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 28.764,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 687.7680000000055,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.422999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 363.365,
      "heapDeltaBytes": -6739008,
      "heapUsedBytes": 62301076,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 28.591000000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.6739999999668,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.516,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 539.712,
      "heapDeltaBytes": -22091648,
      "heapUsedBytes": 68212536,
      "domNodes": -277,
      "jsHeapTotalBytes": 3403776,
      "scriptDurationMs": 38.99100000000001,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.4219999999978,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.134999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 558.0299999999999,
      "heapDeltaBytes": -21021668,
      "heapUsedBytes": 69655868,
      "domNodes": -276,
      "jsHeapTotalBytes": -2363392,
      "scriptDurationMs": 40.376999999999995,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3205.1320000000487,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.206999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2294.4080000000004,
      "heapDeltaBytes": 6188360,
      "heapUsedBytes": 98143936,
      "domNodes": -283,
      "jsHeapTotalBytes": 4677632,
      "scriptDurationMs": 787.1279999999999,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3214.178000000061,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.421000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2327.353,
      "heapDeltaBytes": -24240112,
      "heapUsedBytes": 67518668,
      "domNodes": -282,
      "jsHeapTotalBytes": 4976640,
      "scriptDurationMs": 805.8779999999999,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4130.606999999998,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.388,
      "layouts": 60,
      "layoutDurationMs": 7.624,
      "taskDurationMs": 2210.7140000000004,
      "heapDeltaBytes": -6100728,
      "heapUsedBytes": 65875868,
      "domNodes": -266,
      "jsHeapTotalBytes": -1875968,
      "scriptDurationMs": 732.563,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4281.5740000000915,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.998,
      "layouts": 60,
      "layoutDurationMs": 8.066,
      "taskDurationMs": 2354.348,
      "heapDeltaBytes": -8958588,
      "heapUsedBytes": 80290212,
      "domNodes": -264,
      "jsHeapTotalBytes": 5726208,
      "scriptDurationMs": 761.8320000000001,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3123.928000000035,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.068999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1785.317,
      "heapDeltaBytes": 13063632,
      "heapUsedBytes": 80373600,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 189.082,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3112.24500000003,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.188999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1834.9630000000002,
      "heapDeltaBytes": 8432404,
      "heapUsedBytes": 78916964,
      "domNodes": 0,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 192.95299999999997,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2022.784999999999,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.6269999999999991,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 551.7350000000001,
      "heapDeltaBytes": 9295876,
      "heapUsedBytes": 74380524,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 41.76800000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2007.7290000000403,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.2380000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.8620000000001,
      "heapDeltaBytes": 9132100,
      "heapUsedBytes": 74103764,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.402,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 615.2550000000474,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.808,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.585,
      "heapDeltaBytes": 18125820,
      "heapUsedBytes": 88098980,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 117.871,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 574.5550000000321,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 7.697000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.04100000000005,
      "heapDeltaBytes": 17550660,
      "heapUsedBytes": 87577560,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 111.997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1990.04199999996,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.909000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.345,
      "heapDeltaBytes": 656832,
      "heapUsedBytes": 63939820,
      "domNodes": -296,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.673,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1997.5590000000238,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.566000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.06100000000004,
      "heapDeltaBytes": 11437740,
      "heapUsedBytes": 74449248,
      "domNodes": -298,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 9.445000000000002,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1756.1809999999696,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 34.202999999999996,
      "layouts": 16,
      "layoutDurationMs": 4.23,
      "taskDurationMs": 942.9080000000001,
      "heapDeltaBytes": -8726196,
      "heapUsedBytes": 61322756,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 98.923,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1803.7669999999935,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 42.435,
      "layouts": 16,
      "layoutDurationMs": 4.2330000000000005,
      "taskDurationMs": 989.5990000000002,
      "heapDeltaBytes": -2512664,
      "heapUsedBytes": 67286628,
      "domNodes": -300,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 103.841,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1331.1720000000378,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 26.924000000000003,
      "layouts": 14,
      "layoutDurationMs": 11.486,
      "taskDurationMs": 855.6810000000002,
      "heapDeltaBytes": 19692752,
      "heapUsedBytes": 101642520,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 28.903,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 99,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12248.432999999977,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 38.167,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7808.795,
      "heapDeltaBytes": -4588700,
      "heapUsedBytes": 86468752,
      "domNodes": -282,
      "jsHeapTotalBytes": 4382720,
      "scriptDurationMs": 2636.804,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12238.608999999997,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.854,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7918.753000000001,
      "heapDeltaBytes": -23931720,
      "heapUsedBytes": 67243016,
      "domNodes": -269,
      "jsHeapTotalBytes": 3141632,
      "scriptDurationMs": 2644.516,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15708.171999999991,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15324.688999999998,
      "heapDeltaBytes": -35855216,
      "heapUsedBytes": 183153892,
      "domNodes": -6548,
      "jsHeapTotalBytes": -9932800,
      "scriptDurationMs": 340.95300000000003,
      "eventListeners": -7477,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14699.222999999962,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14172.099,
      "heapDeltaBytes": -40324264,
      "heapUsedBytes": 177005012,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1589248,
      "scriptDurationMs": 257.714,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18354.790999999976,
      "styleRecalcs": 132,
      "styleRecalcDurationMs": 18.506999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18102.155000000002,
      "heapDeltaBytes": -20620364,
      "heapUsedBytes": 193544848,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8429568,
      "scriptDurationMs": 790.3090000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17899.334000000068,
      "styleRecalcs": 140,
      "styleRecalcDurationMs": 15.941000000000011,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17506.111,
      "heapDeltaBytes": -22557108,
      "heapUsedBytes": 191632708,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7118848,
      "scriptDurationMs": 749.412,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 96.57900000001973,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 11.773999999999997,
      "layouts": 2,
      "layoutDurationMs": 0.8809999999999998,
      "taskDurationMs": 73.055,
      "heapDeltaBytes": 3575368,
      "heapUsedBytes": 70429900,
      "domNodes": 129,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 5.938000000000001,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 468.0080000000544,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 18.328999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.201,
      "taskDurationMs": 107.43799999999999,
      "heapDeltaBytes": 5607460,
      "heapUsedBytes": 72793884,
      "domNodes": 147,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 6.447,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@coderabbitai

coderabbitai Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: f07556f5-bf09-4db7-a727-64bb9a52974b

📥 Commits

Reviewing files that changed from the base of the PR and between b6b4559 and bf088d6.

📒 Files selected for processing (2)
  • src/components/queue/QueueProgressOverlay.test.ts
  • src/stores/assetsStore.outputLookup.test.ts

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                          Coverage Diff                          @@
##             drjkl/fix-assets-pagination-review   #16222   +/-   ##
=====================================================================
  Coverage                                      ?   81.37%           
=====================================================================
  Files                                         ?     1923           
  Lines                                         ?   112617           
  Branches                                      ?    31168           
=====================================================================
  Hits                                          ?    91641           
  Misses                                        ?    20577           
  Partials                                      ?      399           
Flag Coverage Δ
unit 74.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

TL;DR: retargeting this PR directly to main is blocked because its two test commits depend on the still-open implementation PR #16070 at b6b4559e; a metadata-only retarget expands the diff from 2 files to 78 files.

Full context for agent readers Exact-head verification at `bf088d6c9fc9b6025de5d927946e12b9fda3eda7` shows the intended delta against the current base is only `src/components/queue/QueueProgressOverlay.test.ts` plus `src/stores/assetsStore.outputLookup.test.ts` (99 additions, 1 deletion). Current `main` does not contain base `b6b4559e510f8f4d0bcb84d41d798beef39797a2` or the required `assetsStore.loadOutputAsset` behavior. Replaying only the two commits conflicts in `QueueProgressOverlay.test.ts` and leaves tests targeting absent production behavior. Unblock by landing or superseding [#16070](https://github.com//pull/16070), then rebase these two commits onto the resulting `main`; do not retarget metadata-only.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Re-verification against current FE main 5882b01388 (advanced from a85d6d7c3e at prior block). Base drjkl/fix-assets-pagination-review = FE #16070, still OPEN/CONFLICTING. Cherry-pick of the 2 own-commits onto main: first a0bb46991 applies cleanly (creates src/stores/assetsStore.outputLookup.test.ts, 91 lines) but references useAssetsStore().loadOutputAsset(...) — loadOutputAsset has 0 occurrences in main assetsStore.ts. Second bf088d6c9 conflicts in src/components/queue/QueueProgressOverlay.test.ts (additive: 3 new test cases using loadOutputAssetMock). Tests authored against the loadOutputAsset API from #16070, not on main. Block unchanged. Resume after #16070 lands or adapt tests to main's current assets store API.

@DrJKL
DrJKL force-pushed the drjkl/fix-assets-pagination-review branch from b6b4559 to 7f61565 Compare September 16, 2026 23:26
@DrJKL
DrJKL requested a review from a team as a code owner September 16, 2026 23:26
@DrJKL
DrJKL force-pushed the drjkl/fix-assets-pagination-review branch from 7f61565 to a248f55 Compare September 16, 2026 23:31
@DrJKL

DrJKL commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Closing after re-evaluating these two test commits against the current #16070 head (0e59ebd3072ba8cd87c2db56aa53e914d405fd47).

The commits replay cleanly locally, so the reported conflict comes from divergent base history rather than irreconcilable test changes. However, they should not be merged into #16070 as-is:

  • src/stores/assetsStore.outputLookup.test.ts creates its own Pinia and mocks project-owned stores/query modules. Current lint reports comfy/use-global-pinia and vitest/prefer-import-in-mock errors. Store tests must use the globally configured testing Pinia.
  • The bounded pagination behavior is already covered through the real store in src/stores/assetsStore.test.ts.
  • The QueueProgressOverlay addition combines the already-covered bounded-miss behavior with the separately covered sidebar toggle, adding redundant cross-product coverage.

Verification: the replayed candidate tests passed (2 files, 9 tests), and the existing #16070 tests passed (2 files, 56 tests). No commits from this PR were integrated.

@DrJKL DrJKL closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants