Repository navigation
test(assets): cover bounded queue focus - #16222
christian-byrne wants to merge 76 commits into
Conversation
Need to put some further thought into loadNew invalidation. Ideal case is that output is flagged stale and async fetch doesn't occur if there isn't active dependent? But per current design specs, all existent views should be subscribed and thus require update. That a new 'output' asset might farm out 3 requests (all: load node, outputs, outputs+temp) leaves a bad taste in my mouth
comfyPage.setup should be banned
🎨 Storybook: 🚧 Building...🎭 Playwright: ✅ 1997 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-29T09:18:55.682Z",
"gitSha": "70d20c4e8080b114f6a02401a67967056568f73b",
"branch": "test/assets-bounded-queue-focus",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2057.801999999981,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.79200000000003,
"heapDeltaBytes": 4972548,
"heapUsedBytes": 67437936,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.756,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2009.633000000008,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.501999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.846,
"heapDeltaBytes": -2826776,
"heapUsedBytes": 66646244,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.402,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1992.5690000000031,
"styleRecalcs": 80,
"styleRecalcDurationMs": 37.271,
"layouts": 12,
"layoutDurationMs": 3.048,
"taskDurationMs": 1035.57,
"heapDeltaBytes": 4523740,
"heapUsedBytes": 73802204,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 128.45299999999997,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2041.3340000000062,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.59199999999999,
"layouts": 12,
"layoutDurationMs": 3.0730000000000004,
"taskDurationMs": 1063.683,
"heapDeltaBytes": -10688508,
"heapUsedBytes": 58563596,
"domNodes": -281,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 129.39399999999998,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.9839999999867,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.65,
"layouts": 6,
"layoutDurationMs": 0.5299999999999999,
"taskDurationMs": 305.41,
"heapDeltaBytes": 4331972,
"heapUsedBytes": 74122436,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.054,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.5970000000116,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.575000000000001,
"layouts": 6,
"layoutDurationMs": 0.585,
"taskDurationMs": 303.091,
"heapDeltaBytes": 4090400,
"heapUsedBytes": 74148160,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.329,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 728.3940000000371,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.294999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.65999999999997,
"heapDeltaBytes": 19721868,
"heapUsedBytes": 81956024,
"domNodes": 14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 28.764,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 687.7680000000055,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.422999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.365,
"heapDeltaBytes": -6739008,
"heapUsedBytes": 62301076,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 28.591000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2028.6739999999668,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.516,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.712,
"heapDeltaBytes": -22091648,
"heapUsedBytes": 68212536,
"domNodes": -277,
"jsHeapTotalBytes": 3403776,
"scriptDurationMs": 38.99100000000001,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2056.4219999999978,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.134999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.0299999999999,
"heapDeltaBytes": -21021668,
"heapUsedBytes": 69655868,
"domNodes": -276,
"jsHeapTotalBytes": -2363392,
"scriptDurationMs": 40.376999999999995,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3205.1320000000487,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.206999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2294.4080000000004,
"heapDeltaBytes": 6188360,
"heapUsedBytes": 98143936,
"domNodes": -283,
"jsHeapTotalBytes": 4677632,
"scriptDurationMs": 787.1279999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3214.178000000061,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.421000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2327.353,
"heapDeltaBytes": -24240112,
"heapUsedBytes": 67518668,
"domNodes": -282,
"jsHeapTotalBytes": 4976640,
"scriptDurationMs": 805.8779999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 4130.606999999998,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.388,
"layouts": 60,
"layoutDurationMs": 7.624,
"taskDurationMs": 2210.7140000000004,
"heapDeltaBytes": -6100728,
"heapUsedBytes": 65875868,
"domNodes": -266,
"jsHeapTotalBytes": -1875968,
"scriptDurationMs": 732.563,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4281.5740000000915,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.998,
"layouts": 60,
"layoutDurationMs": 8.066,
"taskDurationMs": 2354.348,
"heapDeltaBytes": -8958588,
"heapUsedBytes": 80290212,
"domNodes": -264,
"jsHeapTotalBytes": 5726208,
"scriptDurationMs": 761.8320000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3123.928000000035,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.068999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1785.317,
"heapDeltaBytes": 13063632,
"heapUsedBytes": 80373600,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 189.082,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 3112.24500000003,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.188999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1834.9630000000002,
"heapDeltaBytes": 8432404,
"heapUsedBytes": 78916964,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 192.95299999999997,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.784999999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6269999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.7350000000001,
"heapDeltaBytes": 9295876,
"heapUsedBytes": 74380524,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 41.76800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2007.7290000000403,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.2380000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.8620000000001,
"heapDeltaBytes": 9132100,
"heapUsedBytes": 74103764,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.402,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.2550000000474,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.808,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.585,
"heapDeltaBytes": 18125820,
"heapUsedBytes": 88098980,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 117.871,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.5550000000321,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.697000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.04100000000005,
"heapDeltaBytes": 17550660,
"heapUsedBytes": 87577560,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 111.997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.04199999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.909000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.345,
"heapDeltaBytes": 656832,
"heapUsedBytes": 63939820,
"domNodes": -296,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.673,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1997.5590000000238,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.566000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.06100000000004,
"heapDeltaBytes": 11437740,
"heapUsedBytes": 74449248,
"domNodes": -298,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.445000000000002,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.1809999999696,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.202999999999996,
"layouts": 16,
"layoutDurationMs": 4.23,
"taskDurationMs": 942.9080000000001,
"heapDeltaBytes": -8726196,
"heapUsedBytes": 61322756,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 98.923,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1803.7669999999935,
"styleRecalcs": 76,
"styleRecalcDurationMs": 42.435,
"layouts": 16,
"layoutDurationMs": 4.2330000000000005,
"taskDurationMs": 989.5990000000002,
"heapDeltaBytes": -2512664,
"heapUsedBytes": 67286628,
"domNodes": -300,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 103.841,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1331.1720000000378,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.924000000000003,
"layouts": 14,
"layoutDurationMs": 11.486,
"taskDurationMs": 855.6810000000002,
"heapDeltaBytes": 19692752,
"heapUsedBytes": 101642520,
"domNodes": 13671,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 28.903,
"eventListeners": 2381,
"totalBlockingTimeMs": 99,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 12248.432999999977,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.167,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7808.795,
"heapDeltaBytes": -4588700,
"heapUsedBytes": 86468752,
"domNodes": -282,
"jsHeapTotalBytes": 4382720,
"scriptDurationMs": 2636.804,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12238.608999999997,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.854,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7918.753000000001,
"heapDeltaBytes": -23931720,
"heapUsedBytes": 67243016,
"domNodes": -269,
"jsHeapTotalBytes": 3141632,
"scriptDurationMs": 2644.516,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15708.171999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15324.688999999998,
"heapDeltaBytes": -35855216,
"heapUsedBytes": 183153892,
"domNodes": -6548,
"jsHeapTotalBytes": -9932800,
"scriptDurationMs": 340.95300000000003,
"eventListeners": -7477,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14699.222999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14172.099,
"heapDeltaBytes": -40324264,
"heapUsedBytes": 177005012,
"domNodes": -6548,
"jsHeapTotalBytes": 1589248,
"scriptDurationMs": 257.714,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 18354.790999999976,
"styleRecalcs": 132,
"styleRecalcDurationMs": 18.506999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18102.155000000002,
"heapDeltaBytes": -20620364,
"heapUsedBytes": 193544848,
"domNodes": -6548,
"jsHeapTotalBytes": -8429568,
"scriptDurationMs": 790.3090000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 14,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17899.334000000068,
"styleRecalcs": 140,
"styleRecalcDurationMs": 15.941000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17506.111,
"heapDeltaBytes": -22557108,
"heapUsedBytes": 191632708,
"domNodes": -6548,
"jsHeapTotalBytes": -7118848,
"scriptDurationMs": 749.412,
"eventListeners": -7473,
"totalBlockingTimeMs": 16,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 96.57900000001973,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.773999999999997,
"layouts": 2,
"layoutDurationMs": 0.8809999999999998,
"taskDurationMs": 73.055,
"heapDeltaBytes": 3575368,
"heapUsedBytes": 70429900,
"domNodes": 129,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.938000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 468.0080000000544,
"styleRecalcs": 20,
"styleRecalcDurationMs": 18.328999999999997,
"layouts": 3,
"layoutDurationMs": 1.201,
"taskDurationMs": 107.43799999999999,
"heapDeltaBytes": 5607460,
"heapUsedBytes": 72793884,
"domNodes": 147,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.447,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
Warning Review limit reachedNext included review available in 22 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## drjkl/fix-assets-pagination-review #16222 +/- ##
=====================================================================
Coverage ? 81.37%
=====================================================================
Files ? 1923
Lines ? 112617
Branches ? 31168
=====================================================================
Hits ? 91641
Misses ? 20577
Partials ? 399
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
TL;DR: retargeting this PR directly to Full context for agent readersExact-head verification at `bf088d6c9fc9b6025de5d927946e12b9fda3eda7` shows the intended delta against the current base is only `src/components/queue/QueueProgressOverlay.test.ts` plus `src/stores/assetsStore.outputLookup.test.ts` (99 additions, 1 deletion). Current `main` does not contain base `b6b4559e510f8f4d0bcb84d41d798beef39797a2` or the required `assetsStore.loadOutputAsset` behavior. Replaying only the two commits conflicts in `QueueProgressOverlay.test.ts` and leaves tests targeting absent production behavior. Unblock by landing or superseding [#16070](https://github.com//pull/16070), then rebase these two commits onto the resulting `main`; do not retarget metadata-only. |
|
@coderabbitai review |
|
|
Re-verification against current FE main |
b6b4559 to
7f61565
Compare
7f61565 to
a248f55
Compare
|
Closing after re-evaluating these two test commits against the current #16070 head ( The commits replay cleanly locally, so the reported conflict comes from divergent base history rather than irreconcilable test changes. However, they should not be merged into #16070 as-is:
Verification: the replayed candidate tests passed (2 files, 9 tests), and the existing #16070 tests passed (2 files, 56 tests). No commits from this PR were integrated. |
Summary
Stacked on #16070 because that replacement changes pagination ownership to
loadMore(): Promise<boolean>and does not include #16021's direct output-lookup tests.Changes
Review Focus
The store tests prove multi-page lookup and termination on a repeated/non-advancing cursor. The component test proves a bounded miss leaves selection empty and the sidebar operable.
The 1,000-page-cap pagination case remains attached to #16021's implementation and is not claimed here.
Verification
Verification:
falselookup result fails on the exact empty-selection assertion.