Skip to content

feat(assets): adopt cursor pagination in the flat-output infinite scroll - #12774

Closed
mattmillerai wants to merge 18 commits into
mainfrom
matt/fe-985-fe-adopt-cursor-pagination-in-the-flat-output-infinite
Closed

mattmillerai wants to merge 18 commits into
mainfrom
matt/fe-985-fe-adopt-cursor-pagination-in-the-flat-output-infinite

Conversation

@mattmillerai

Copy link
Copy Markdown
Member

Summary

Migrates the flat-output infinite scroll (fetchFlatOutputs) from offset paging to the keyset cursor contract (after/next_cursor) now live on core (Comfy-Org/ComfyUI#14014) and cloud (Comfy-Org/cloud#3690), building on the service plumbing from #12720.

Changes

  • What: fetchFlatOutputs threads next_cursor into after on loadMore via getAssetsPageByTag, with offset paging retained as the fallback for backends that mint no cursors. hasMore is now server-authoritative (has_more) instead of the page.length === FLAT_OUTPUT_PAGE_SIZE heuristic, with empty-page and non-advancing-cursor termination guards. The reset path clears the cursor and remains a from-the-top head fetch (the contract has no before param).

Review Focus

  • Cursor/offset interplay in fetchFlatOutputs: requestedAfter is captured per request; offset keeps accumulating so a cursor-less response can fall back mid-session.

  • Known, deliberate non-goals: a failed refresh still leaves stale assets with cleared dedupe state (pre-existing behavior, unchanged by this PR), and a stale-cursor 400 has no special recovery — the cursor only lives for one scroll session and a refresh fully recovers. The jobs walk's 400-recovery pattern can be ported later if this surfaces in practice.

  • Fixes FE-985

🤖 Generated with Claude Code

@mattmillerai
mattmillerai requested a review from a team June 10, 2026 21:46
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

assetsStore.ts now coordinates cursor-based flat output paging with load-more versus refresh in-flight handling, cursor advancement, and error preservation. assetsStore.test.ts adds coverage for paging edge cases, failed refresh behavior, and concurrent request ordering.

Changes

Flat Output Pagination Migration

Layer / File(s) Summary
In-flight refresh handling
src/stores/assetsStore.ts
fetchFlatOutputs distinguishes load-more requests from refresh requests and delays a refresh while a load-more request is already in flight.
Cursor paging and termination
src/stores/assetsStore.ts
fetchFlatOutputs reads assets, next_cursor, and has_more from getAssetsPageByTag, advances flatOutputNextCursor, stops when the cursor does not advance, and preserves the current asset list on errors while recording flatOutputError.
Flat output paging tests
src/stores/assetsStore.test.ts
The tests cover initial-load failure state, restart after failed refresh, duplicate-only and empty terminal pages, refresh error preservation, and concurrent refresh versus load-more request ordering.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adopting cursor pagination for flat-output infinite scroll.
Description check ✅ Passed The description matches the template well, with Summary, Changes, and Review Focus sections filled in appropriately.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed Title is feature-oriented, not bug-fix wording; with no visible fix-style commit subject, the check’s fail condition doesn’t trigger despite src/ changes and no browser_tests/ edits.
Adr Compliance For Entity/Litegraph Changes ✅ Passed No changed files under src/lib/litegraph/, src/ecs/, or graph-entity paths; ADR 0003/0008 checks are not applicable.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch matt/fe-985-fe-adopt-cursor-pagination-in-the-flat-output-infinite

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/stores/assetsStore.test.ts (1)

1524-1535: 💤 Low value

Consider function declaration for pure helper.

The makePage helper is a pure function. Per coding guidelines, prefer function declarations over expressions for pure functions.

♻️ Optional refactor to function declaration
-const makePage = (
+function makePage(
   assets: AssetItem[],
   {
     hasMore = false,
     nextCursor
   }: { hasMore?: boolean; nextCursor?: string } = {}
-): AssetResponse => ({
+): AssetResponse {
+  return {
   assets,
   total: assets.length,
   has_more: hasMore,
   ...(nextCursor === undefined ? {} : { next_cursor: nextCursor })
-})
+  }
+}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/stores/assetsStore.test.ts` around lines 1524 - 1535, Convert the pure
helper const makePage = (...) => (...) expression into a function declaration to
follow coding guidelines: replace the arrow-const definition of makePage with a
function declaration function makePage(assets: AssetItem[], { hasMore = false,
nextCursor }: { hasMore?: boolean; nextCursor?: string } = {}): AssetResponse {
return { assets, total: assets.length, has_more: hasMore, ...(nextCursor ===
undefined ? {} : { next_cursor: nextCursor }) }; } so the helper remains pure
and types (AssetItem, AssetResponse) are preserved and easy to locate.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/stores/assetsStore.test.ts`:
- Around line 1524-1535: Convert the pure helper const makePage = (...) => (...)
expression into a function declaration to follow coding guidelines: replace the
arrow-const definition of makePage with a function declaration function
makePage(assets: AssetItem[], { hasMore = false, nextCursor }: { hasMore?:
boolean; nextCursor?: string } = {}): AssetResponse { return { assets, total:
assets.length, has_more: hasMore, ...(nextCursor === undefined ? {} : {
next_cursor: nextCursor }) }; } so the helper remains pure and types (AssetItem,
AssetResponse) are preserved and easy to locate.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b1bf92de-c477-4f03-9338-76a5c250954d

📥 Commits

Reviewing files that changed from the base of the PR and between bd1fd06 and bd9e8b6.

📒 Files selected for processing (2)
  • src/stores/assetsStore.test.ts
  • src/stores/assetsStore.ts

@codecov

codecov Bot commented Jun 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #12774      +/-   ##
==========================================
- Coverage   78.75%   72.36%   -6.39%     
==========================================
  Files        1868     1782      -86     
  Lines      115515    94067   -21448     
  Branches    33610    26137    -7473     
==========================================
- Hits        90979    68076   -22903     
- Misses      23992    25838    +1846     
+ Partials      544      153     -391     
Flag Coverage Δ
e2e ?
unit 72.36% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/stores/assetsStore.ts 95.24% <100.00%> (+0.15%) ⬆️

... and 1174 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattmillerai

Copy link
Copy Markdown
Member Author

Manual verification against testcloud staging (dev:cloud + headed Chrome, network capture on /api/assets; FLAT_OUTPUT_PAGE_SIZE temporarily patched 200→5 locally to force a multi-page walk on a 12-asset account, reverted after):

  • Opening a Load Image widget dropdown issued the head fetch with no offset/after → 5 assets, has_more:true, next_cursor minted.
  • loadMore sent after=<cursor> and no offset; decoded cursor {"s":"created_at","v":…,"id":…} pointed at the prior page's last row. Two walks appended 5+2 unique items (12/12, zero dupes).
  • Final page returned has_more:false with no cursor → flatOutputHasMore=false; a further loadMore issued zero requests.
  • Refresh re-fetched paramless from the head, cleared the cursor, reset the list.
GET /api/assets?include_tags=output&limit=5&exclude_tags=missing&after=eyJzIjoiY3JlYXRlZF9hdCIsInYiOiIxNzczMjY2MDIwMjkwMzk0IiwiaWQiOiJiZmEyYjUw…&include_public=true
→ 200 {"assets":5,"total":12,"has_more":true,"next_cursor":"eyJzIjoiY3JlYXRlZF9hdCIs…"}

Findings for reviewers:

  • loadMore has no production call site — useWidgetSelectItems consumes only media; nothing wires loadMore/hasMore. With the real limit of 200, accounts with 201+ outputs never see the tail. The cursor walk here is correct but dormant until infinite scroll is wired to the flat-output provider (follow-up ticket to come). loadMore steps above were driven through the store on the live app since no UI affordance exists.
  • The offset-fallback leg wasn't observable live (staging always mints cursors); it's covered by unit tests and mainly matters for cursor-less backends.

Created by Claude Code

Calls the reusable Comfy-Org/github-workflows cursor-review.yml (single source of truth for panel, judge, prompts, scripts) instead of a standalone copy. Label-gated to the team; secret-bearing jobs skip fork PRs. Judge overridden to Opus 4.8.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read-only review at c5aaeba (not approving, per request).

The offset→cursor migration in fetchFlatOutputs is clean and the behavioral coverage is genuinely strong: server-authoritative has_more over the old length heuristic, non-advancing-cursor termination (cursorStuck), empty-page-as-terminal, the offset fallback for cursor-less backends, and cursor-preservation-on-loadMore-failure are all exercised. No blocking findings.

One thing I like: flatOutputOffset keeps accumulating even while paging by cursor, so a mid-session cursor drop falls back to a correct offset. Reads as redundant in cursor mode — a one-line comment at the flatOutputOffset.value += batch.length site noting that's deliberate would help the next reader.

The CodeRabbit "missing E2E" pre-merge flag is acceptable here: this is store-level logic fully covered by unit tests, and the Playwright jobs fixture mints no cursors, so an e2e would only re-exercise the offset fallback.

@mattmillerai mattmillerai added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.45 labels Jun 17, 2026
mattmillerai and others added 6 commits June 17, 2026 11:17
- fetchFlatOutputs threads next_cursor into after on loadMore, falling
  back to offset paging for backends that mint no cursors
- hasMore is now server-authoritative (has_more) instead of the
  page-length heuristic, with empty-page and non-advancing-cursor guards
- reset path clears the cursor and stays a from-the-top head fetch
- pin cursor preservation across a failed loadMore (retry resumes via after)
- pin cursor clearing on refresh via the failed-refresh path (kills a
  surviving mutant on the reset-path clear)
- rename error test to match actual preserve-on-error behavior
- use vi.resetAllMocks to isolate per-test once-queues
@mattmillerai
mattmillerai force-pushed the matt/fe-985-fe-adopt-cursor-pagination-in-the-flat-output-infinite branch from c5aaeba to 5463ad4 Compare June 17, 2026 18:48
@mattmillerai
mattmillerai changed the base branch from main to ci/cursor-review-workflow June 17, 2026 18:54
@mattmillerai mattmillerai added the cursor-review Trigger multi-model Cursor agent review on this PR label Jun 17, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @mattmillerai.

Found 6 finding(s).

Severity Count
🟠 High 1
🟡 Medium 3
🟢 Low 1
⚪ Nit 1

Panel: 5/8 reviewers contributed findings.

Reviewers that did not contribute: gemini-3.1-pro:adversarial (error), kimi-k2.5:adversarial (empty), kimi-k2.5:edge-case (empty)

Comment thread src/stores/assetsStore.ts Resolved
Comment thread src/stores/assetsStore.ts Resolved
Comment thread src/stores/assetsStore.ts Resolved
Comment thread src/stores/assetsStore.ts Resolved
Comment thread src/stores/assetsStore.ts Resolved
Comment thread src/stores/assetsStore.ts Resolved
Base automatically changed from ci/cursor-review-workflow to main June 17, 2026 20:56
…le-list append

On refresh failure the catch block returned [] but left flatOutputAssets
intact. The reset block had already cleared seenIds and rewound offset
to 0, so the next loadMoreFlatOutputs would append fresh page-0 items
onto the retained stale list, producing visible duplicates.

Clear flatOutputAssets when the refresh path fails so the list stays
consistent with the reset cursor/offset state.

Add assertions to the existing refresh-failure and restart-from-head
tests to catch this regression.
@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/uy-tieu-s-projects?upgradeToPro=build-rate-limit

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 1, 2026
DrJKL pushed a commit that referenced this pull request Jul 6, 2026
… widget select dropdown (#12780)

## Summary

Wires the previously-dormant `loadMore` path of the flat-output assets
provider into the widget select dropdown, so cloud users with more than
one page of outputs can actually reach them. Stacked on #12774 (FE-985);
retargets to `main` when that merges.

## Changes

- **What**: `VirtualGrid`'s existing `approach-end` event now forwards
through `FormDropdownMenu` → `FormDropdown` → `WidgetSelectDropdown`,
which calls `outputMediaAssets.loadMore()` guarded by
`hasMore`/`isLoadingMore` and debounced 300ms — the same idiom as
`AssetsSidebarTab`. A spinner row (`loadingMore` prop) renders below the
grid while a page is in flight. On cloud this drives the FE-985 cursor
walk; on OSS it drives the FE-962 jobs-history cursor walk via
`useAssetsApi`.

## Review Focus

- Verified end-to-end against the dev server with a mocked 100-asset
backend: scroll → `after=cur-40` → `after=cur-80` → stops at
`has_more:false` (100/100, no duplicate fetches).
- **Known platform limitation, not introduced here**: VueUse ≥14's
`throttleFilter` with `leading=false` drops events spaced wider than the
throttle window, so `useScroll`'s `throttle: 64` in `VirtualGrid` never
reports discrete mouse-wheel scrolls — only high-frequency
(trackpad-style) scrolling triggers `approach-end`. This equally affects
the assets sidebar and manager dialog today; bug filed separately with
root cause. Fixing it makes this wiring work for wheel users with no
further changes.
- Underfill edge: `approach-end` cannot fire when loaded items don't
overflow the viewport (shared VirtualGrid trait with the sidebar); with
the 200-item page size this only matters for heavily-filtered media
types.

- Fixes FE-988

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: GitHub Action <action@github.com>

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the follow-up fixes after the latest main merge. Cursor/offset fallback, terminal guards, refresh/load-more concurrency, and refresh-failure behavior remain covered; the focused assets store suite passes locally (75 tests).

dante01yoon pushed a commit that referenced this pull request Jul 27, 2026
… widget select dropdown (#12780)

## Summary

Wires the previously-dormant `loadMore` path of the flat-output assets
provider into the widget select dropdown, so cloud users with more than
one page of outputs can actually reach them. Stacked on #12774 (FE-985);
retargets to `main` when that merges.

## Changes

- **What**: `VirtualGrid`'s existing `approach-end` event now forwards
through `FormDropdownMenu` → `FormDropdown` → `WidgetSelectDropdown`,
which calls `outputMediaAssets.loadMore()` guarded by
`hasMore`/`isLoadingMore` and debounced 300ms — the same idiom as
`AssetsSidebarTab`. A spinner row (`loadingMore` prop) renders below the
grid while a page is in flight. On cloud this drives the FE-985 cursor
walk; on OSS it drives the FE-962 jobs-history cursor walk via
`useAssetsApi`.

## Review Focus

- Verified end-to-end against the dev server with a mocked 100-asset
backend: scroll → `after=cur-40` → `after=cur-80` → stops at
`has_more:false` (100/100, no duplicate fetches).
- **Known platform limitation, not introduced here**: VueUse ≥14's
`throttleFilter` with `leading=false` drops events spaced wider than the
throttle window, so `useScroll`'s `throttle: 64` in `VirtualGrid` never
reports discrete mouse-wheel scrolls — only high-frequency
(trackpad-style) scrolling triggers `approach-end`. This equally affects
the assets sidebar and manager dialog today; bug filed separately with
root cause. Fixing it makes this wiring work for wheel users with no
further changes.
- Underfill edge: `approach-end` cannot fire when loaded items don't
overflow the viewport (shared VirtualGrid trait with the sidebar); with
the 200-item page size this only matters for heavily-filtered media
types.

- Fixes FE-988

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: GitHub Action <action@github.com>
@mattmillerai
mattmillerai enabled auto-merge July 27, 2026 20:20
@mattmillerai
mattmillerai disabled auto-merge July 27, 2026 20:20
@mattmillerai mattmillerai removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Jul 27, 2026
…cursor-pagination-in-the-flat-output-infinite

# Conflicts:
#	src/stores/assetsStore.ts
@mattmillerai

Copy link
Copy Markdown
Member Author

Merged main and resolved the conflict in src/stores/assetsStore.ts. One resolution was a semantic conflict worth flagging, plus an unrelated fix that was needed to commit at all.

Empty-string cursors: took main's contract, dropped this branch's || undefined

The textual conflict was one line, but the two sides disagreed on behavior.

Both this branch and main independently fixed the merge-base bug where requestedAfter was checked for truthiness (requestedAfter ? ...) instead of !== undefined. main went one step further and also removed the page.next_cursor || undefined coercion, making an empty-string cursor a valid cursor to follow — pinned by two tests:

  • assetsStore.test.ts:2050 — threads an empty-string cursor into after instead of falling back to offset
  • assetsStore.test.ts:897 — follows an empty-string cursor instead of falling back to offset paging

This branch kept the || undefined coercion inherited from the merge base, which turns '' back into undefined and falls back to offset paging. I confirmed empirically that carrying it forward fails main's test:

× threads an empty-string cursor into after instead of falling back to offset
  Tests  1 failed | 88 passed (89)

So the resolution keeps main's semantics (nextCursor used directly, no coercion). Nothing from this branch's intent was lost — the !== undefined guard it added is still what decides after vs offset.

The branch's own refinements are all preserved: the refresh-vs-loadMore coalescing loop, batch.length > 0 (so an all-duplicates page keeps scrolling while an empty page still terminates), the contextual error log, and returning cached assets on a failed refresh. Full suite: 89/89 passing, pnpm lint / pnpm typecheck / oxfmt clean.

Note on scope: the core change already landed via #12780

Most of this PR's stated goal — threading next_cursor into after in fetchFlatOutputs — is already on main (#12780). What remains here is the hardening set above, which is still real but narrower than the PR description implies. Worth a description refresh before merge.

Unrelated: tools/devtools/web/runtimeReflow.js lint errors (2 files outside this PR's scope)

The merge commit could not be created at all: lint-staged lints every staged file, and the merge stages tools/devtools/web/runtimeReflow.js (new on main via #14025), which fails with 2 errors:

1:21  error  Unable to resolve path to module '../../scripts/app.js'  import-x/no-unresolved
37:25 error  'Image' is not defined                                   no-undef

This is pre-existing on main and blocks any commit that stages that file — including every merge-from-main on every feature branch. It slipped through because pnpm lint only covers src/browser_tests, so CI never sees tools/. I fixed it minimally using the repo's own precedents rather than bypassing the hook (no --no-verify):

  • the same eslint-disable-next-line import-x/no-unresolved comment its sibling legacyWidget.js already carries
  • a tools/devtools/web/**/*.js → globals.browser block in eslint.config.ts, mirroring the existing scripts/**/*.js → globals.node block

Happy to split those two files into a separate PR if you'd rather keep this one to assetsStore — but note this branch can't produce a merge commit until that fix exists somewhere.

Re-requesting review since the push dismissed the prior approval.

@mattmillerai

Copy link
Copy Markdown
Member Author

One more divergence from main worth an explicit look during re-review, since it survived the merge and main has no test either way.

main computes the termination guard from the deduped batch:

flatOutputHasMore.value = fresh.length > 0 && page.has_more && !cursorStuck

this branch computes it from the raw batch:

flatOutputHasMore.value = batch.length > 0 && hasMore && !cursorStuck

Both keep the empty-page guard (assetsStore.test.ts — treats an empty page as terminal even when has_more is true passes either way). The trade-off is at the other end:

  • fresh.length (main): a single all-duplicates page permanently ends the scroll, truncating results the server still has. This is the bug this branch is fixing, covered by the new test keeps scrolling when a loadMore page is all duplicates but more remain.
  • batch.length (this branch): loses main's implicit backstop against a server that returns advancing cursors with duplicate payloads forever. cursorStuck only catches a cursor that repeats exactly, so that case would leave hasMore true indefinitely.

I kept this branch's version — the truncation bug is reachable with a correct server, while the runaway case needs a misbehaving one and is bounded by user scroll (each loadMore adds nothing, so the list never grows and nothing auto-retriggers). Flagging it rather than filing a ticket for that reason. Happy to add a "N consecutive all-duplicate pages ends the walk" guard here if you'd rather have belt-and-braces.

@mattmillerai

Copy link
Copy Markdown
Member Author

🤖 The reviews loop filed Linear follow-up ticket(s) for review thread(s) deferred as out of scope for this PR:

  • BE-4815 — Extend the lint gate to cover tools/ so unlinted JS cannot land on main

christian-byrne and others added 2 commits July 30, 2026 19:20
…cursor-pagination-in-the-flat-output-infinite

# Conflicts:
#	eslint.config.ts
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 9, 2026

@AustinMroz AustinMroz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have personal objections to the change, but it will be entirely subsumed by #15381

@AustinMroz AustinMroz removed their assignment Aug 20, 2026

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cursor regressions are valid and pass locally, but current main replaced this flat-output implementation in #15381 and this branch now conflicts with the base. Please close it as superseded rather than reintroducing the old store path.

@christian-byrne

Copy link
Copy Markdown
Contributor

Closing: core change already landed, remainder covered elsewhere.

Full context for agent readers

Closure approved by the repository owner Christian in the private tracking issue blocked-on-christian #504. Inspection: head edd569925, 18 ahead / 865 behind main, GitHub mergeable state CONFLICTING, zero unresolved review threads, latest exact-head Unit Tests run green. No recovery or rebase was performed; no code on this branch was discarded (the branch remains on the fork). Glossary: bounded pagination = page fetching stops at a defined cursor or limit; flat-output provider = the asset store path that lists generated outputs for the widget select dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants