Repository navigation
Template model requirements (FE-1491): feat(templates): provision desktop template inputs - #15902
Conversation
|
Important Review skippedThe saved review history does not include the base for the last reviewed commit. This saved history cannot establish the base for an incremental review. Comment You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe change adds desktop template input-asset retrieval and downloads, tracks their progress, refreshes graph bindings after completion, filters missing-media state, updates template previews, and shows download progress in linear mode. ChangesTemplate input assets
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant ComfyDesktop2Bridge
participant WorkflowTemplateSelectorDialog
participant useTemplateInputDownloadStore
participant GraphView
participant refreshDownloadedTemplateInputBindings
participant missingMediaPipeline
ComfyDesktop2Bridge->>WorkflowTemplateSelectorDialog: provide input assets
WorkflowTemplateSelectorDialog->>ComfyDesktop2Bridge: start missing asset downloads
ComfyDesktop2Bridge->>GraphView: emit download progress
GraphView->>useTemplateInputDownloadStore: update progress
GraphView->>refreshDownloadedTemplateInputBindings: refresh completed bindings
GraphView->>missingMediaPipeline: rescan missing media
GraphView->>useTemplateInputDownloadStore: complete graph sync
Merge Risk: 🟡 Moderate · up to Template opening can report completion before all downloaded inputs have been rebound, and resolved media errors may remain visible after asynchronous verification. Resolve these correctness gaps before merging. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (5 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list and PR description are available, but the PR title and commit subjects are not provided. The check requires those metadata fields to identify bug-fix language, so the result cannot be determined without guessing. Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The check applies because the PR changes graph-related code, including Resolution Review the ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2194 passed, 0 failed📊 Browser Reports
🌐 Website E2ETip All tests passed.
📦 Bundle: 10.2 MB gzipDetailsSummary
Category Glance App Entry Points — 3.92 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.47 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 135 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 648 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 53.7 kBAuthentication, profile, and account management bundles
Status: 15 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 194 kBReusable component library chunks
Status: 18 added Data & Services — 4.13 MBStores, services, APIs, and repositories
Status: 14 added Utilities & Hooks — 587 kBHelpers, composables, and utility bundles
Status: 38 added Vendor & Third-Party — 17.2 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 18.4 MBBundles that do not match a named category
Status: 306 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-04T07:13:50.138Z",
"gitSha": "4890070fd317796b06b3d9cfc4eb388b2f056213",
"branch": "ryan-di/fe-1491-stack-06-input-assets",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.500000000131,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9290000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.0249999999999,
"heapDeltaBytes": 548232,
"heapUsedBytes": 67996504,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.986000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2012.0050000000447,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.254,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.003,
"heapDeltaBytes": 22370908,
"heapUsedBytes": 76465476,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.321999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1791.6750000001684,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.534000000000002,
"layouts": 12,
"layoutDurationMs": 4.191999999999999,
"taskDurationMs": 886.116,
"heapDeltaBytes": -32949704,
"heapUsedBytes": 71203280,
"domNodes": -232,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 162.058,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82358490566038,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.3970000000118,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.227,
"layouts": 12,
"layoutDurationMs": 4.45,
"taskDurationMs": 775.3130000000001,
"heapDeltaBytes": -2996732,
"heapUsedBytes": 64734540,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 158.40300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.6370000000297,
"styleRecalcs": 33,
"styleRecalcDurationMs": 10.517999999999999,
"layouts": 6,
"layoutDurationMs": 1.3750000000000002,
"taskDurationMs": 327.716,
"heapDeltaBytes": 25341468,
"heapUsedBytes": 79250116,
"domNodes": -178,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.634999999999996,
"eventListeners": -145,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1687.2900000003028,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.832999999999998,
"layouts": 6,
"layoutDurationMs": 1.316,
"taskDurationMs": 327.645,
"heapDeltaBytes": 25365104,
"heapUsedBytes": 79331492,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.6,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 698.4179999999469,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.8919999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.999,
"heapDeltaBytes": 15273616,
"heapUsedBytes": 69651520,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.459,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 730.0319999999374,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.151999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.9679999999999,
"heapDeltaBytes": -7037320,
"heapUsedBytes": 61004028,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.883,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909075,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1307.1669999999358,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 988.7730000000001,
"heapDeltaBytes": 17876792,
"heapUsedBytes": 95785276,
"domNodes": 0,
"jsHeapTotalBytes": 10387456,
"scriptDurationMs": 81.723,
"eventListeners": 0,
"totalBlockingTimeMs": 673,
"frameDurationMs": 38.22941176470589,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1176.8190000002505,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.9630000000001,
"heapDeltaBytes": 14220228,
"heapUsedBytes": 92995844,
"domNodes": 0,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 64.65499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 545,
"frameDurationMs": 34.8,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.7569999999687,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.2329999999997,
"heapDeltaBytes": 17679328,
"heapUsedBytes": 104830612,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 171.80700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.4569999997693,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.6020000000003,
"heapDeltaBytes": -8161932,
"heapUsedBytes": 90077508,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 168.21399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.75999999999996,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10058.219000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9141.299,
"heapDeltaBytes": 6085268,
"heapUsedBytes": 83564412,
"domNodes": -142,
"jsHeapTotalBytes": -6164480,
"scriptDurationMs": 7551.195,
"eventListeners": -78,
"totalBlockingTimeMs": 996,
"frameDurationMs": 33.387375415282385,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10056.179999999813,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.053999999999998494,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9144.717,
"heapDeltaBytes": 7487556,
"heapUsedBytes": 84399376,
"domNodes": -142,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 7625.691,
"eventListeners": -78,
"totalBlockingTimeMs": 1193,
"frameDurationMs": 33.27682119205298,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10637.82399999991,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.08900000000000054,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9738.690999999999,
"heapDeltaBytes": 10237808,
"heapUsedBytes": 94304484,
"domNodes": -142,
"jsHeapTotalBytes": -2756608,
"scriptDurationMs": 8063.667,
"eventListeners": -78,
"totalBlockingTimeMs": 1174,
"frameDurationMs": 32.9188854489164,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9671.159999999873,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.46299999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8924.161999999998,
"heapDeltaBytes": -9471996,
"heapUsedBytes": 68096968,
"domNodes": -142,
"jsHeapTotalBytes": -8785920,
"scriptDurationMs": 7397.41,
"eventListeners": -78,
"totalBlockingTimeMs": 796,
"frameDurationMs": 32.878231292517,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2022.8069999998297,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.288999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.642,
"heapDeltaBytes": -10586696,
"heapUsedBytes": 76915028,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.141999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2049.60600000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.313999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.138,
"heapDeltaBytes": -53510644,
"heapUsedBytes": 71967476,
"domNodes": -328,
"jsHeapTotalBytes": -1146880,
"scriptDurationMs": 33.90699999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2263.9419999998154,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.121,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1567.11,
"heapDeltaBytes": 11585952,
"heapUsedBytes": 74025768,
"domNodes": -328,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 826.852,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592592592593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2190.0870000004033,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1497.2209999999998,
"heapDeltaBytes": 755560,
"heapUsedBytes": 63446396,
"domNodes": -348,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 792.7139999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.794615384615387,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3573.374000000058,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.343,
"layouts": 60,
"layoutDurationMs": 14.127,
"taskDurationMs": 1658.9630000000002,
"heapDeltaBytes": -20104424,
"heapUsedBytes": 69913824,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 805.668,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3649.3860000000495,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.813999999999998,
"layouts": 60,
"layoutDurationMs": 13.54,
"taskDurationMs": 1662.255,
"heapDeltaBytes": 460392,
"heapUsedBytes": 65404148,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 797.991,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66575342465753,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3084.0220000000045,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.609000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1803.5850000000003,
"heapDeltaBytes": 8541376,
"heapUsedBytes": 73125412,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 941.5849999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757377049180324,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3134.5030000002225,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.098999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1830.3460000000002,
"heapDeltaBytes": 17704964,
"heapUsedBytes": 86050100,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 961.7630000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903742,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2012.0210000000043,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8960000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.446,
"heapDeltaBytes": -10679252,
"heapUsedBytes": 78618200,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.708,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.7180000002154,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.1780000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.11,
"heapDeltaBytes": -10024536,
"heapUsedBytes": 79543376,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.187999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.9740000000929,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.707,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.05899999999997,
"heapDeltaBytes": -12923656,
"heapUsedBytes": 57573248,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 146.655,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.8789999998407,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.455000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.652,
"heapDeltaBytes": 9533592,
"heapUsedBytes": 63529908,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.507,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.9709999999886,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.016000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.88300000000004,
"heapDeltaBytes": 760620,
"heapUsedBytes": 70661928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.871,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2018.6180000000604,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.0689999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.60900000000004,
"heapDeltaBytes": 956532,
"heapUsedBytes": 70304780,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.370000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.239000000025,
"styleRecalcs": 59,
"styleRecalcDurationMs": 18.486999999999995,
"layouts": 16,
"layoutDurationMs": 6.037,
"taskDurationMs": 778.5569999999999,
"heapDeltaBytes": 16041212,
"heapUsedBytes": 76875724,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.785,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.466999999975,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.839,
"layouts": 16,
"layoutDurationMs": 5.861999999999999,
"taskDurationMs": 737.8750000000001,
"heapDeltaBytes": 16834064,
"heapUsedBytes": 80357932,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.532,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0990000001057,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.210999999999995,
"layouts": 5,
"layoutDurationMs": 13.267999999999999,
"taskDurationMs": 867.7800000000002,
"heapDeltaBytes": -4530460,
"heapUsedBytes": 85513356,
"domNodes": 13747,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 30.599,
"eventListeners": 2383,
"totalBlockingTimeMs": 133,
"frameDurationMs": 19.176712328767117,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8340.99500000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.17,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5391.273,
"heapDeltaBytes": -34949704,
"heapUsedBytes": 90759076,
"domNodes": -328,
"jsHeapTotalBytes": -2527232,
"scriptDurationMs": 2665.542,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699198396793587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8348.75699999975,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.715999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5559.865,
"heapDeltaBytes": -7467592,
"heapUsedBytes": 90677208,
"domNodes": -328,
"jsHeapTotalBytes": -1515520,
"scriptDurationMs": 2704.6259999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16912.50600000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16300.006000000003,
"heapDeltaBytes": -32844244,
"heapUsedBytes": 177496644,
"domNodes": -3045,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 259.46400000000006,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.965753424657535,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 17607.696000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16728.79,
"heapDeltaBytes": -30476352,
"heapUsedBytes": 192010536,
"domNodes": -3045,
"jsHeapTotalBytes": 9252864,
"scriptDurationMs": 289.00100000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.032935153583615,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 21099.077000000078,
"styleRecalcs": 177,
"styleRecalcDurationMs": 18.117999999999967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20628.239,
"heapDeltaBytes": -32647168,
"heapUsedBytes": 169570912,
"domNodes": -3045,
"jsHeapTotalBytes": 8728576,
"scriptDurationMs": 846.7790000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 23,
"frameDurationMs": 37.948021582733816,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 20650.38999999979,
"styleRecalcs": 162,
"styleRecalcDurationMs": 16.93699999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20247.356,
"heapDeltaBytes": -43171388,
"heapUsedBytes": 180136956,
"domNodes": -3045,
"jsHeapTotalBytes": 6746112,
"scriptDurationMs": 867.912,
"eventListeners": -14915,
"totalBlockingTimeMs": 33,
"frameDurationMs": 37.95808823529412,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6037.209000000075,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.94399999999999,
"layouts": 20,
"layoutDurationMs": 23.021,
"taskDurationMs": 5924.414000000001,
"heapDeltaBytes": 1186032,
"heapUsedBytes": 211559968,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 107.21100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.517222222222216,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6180.82000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.505,
"layouts": 20,
"layoutDurationMs": 23.112999999999996,
"taskDurationMs": 6010.539000000001,
"heapDeltaBytes": 15059516,
"heapUsedBytes": 225451704,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 105.957,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.78743169398907,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8702.780000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8444.355,
"heapDeltaBytes": -42126224,
"heapUsedBytes": 177287360,
"domNodes": -3045,
"jsHeapTotalBytes": -417792,
"scriptDurationMs": 133.13800000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.390540540540535,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8719.963000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8318.703000000001,
"heapDeltaBytes": -30046164,
"heapUsedBytes": 179732632,
"domNodes": -3045,
"jsHeapTotalBytes": 10276864,
"scriptDurationMs": 139.023,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.265277777777783,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 487.6999999999043,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.480999999999998,
"layouts": 4,
"layoutDurationMs": 2.117,
"taskDurationMs": 142.51999999999998,
"heapDeltaBytes": 5902224,
"heapUsedBytes": 70802944,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.603000000000005,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 132.75900000007823,
"styleRecalcs": 9,
"styleRecalcDurationMs": 12.850000000000001,
"layouts": 4,
"layoutDurationMs": 1.7820000000000003,
"taskDurationMs": 85.873,
"heapDeltaBytes": 3645244,
"heapUsedBytes": 69219644,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.714000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 859.9380000000565,
"styleRecalcs": 78,
"styleRecalcDurationMs": 101.6,
"layouts": 76,
"layoutDurationMs": 24.561,
"taskDurationMs": 833.378,
"heapDeltaBytes": 17843204,
"heapUsedBytes": 83548800,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 343.43600000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 770.2590000003511,
"styleRecalcs": 78,
"styleRecalcDurationMs": 97.137,
"layouts": 76,
"layoutDurationMs": 23.621,
"taskDurationMs": 739.702,
"heapDeltaBytes": 16663692,
"heapUsedBytes": 81663888,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 297.87600000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1401.002999999946,
"styleRecalcs": 78,
"styleRecalcDurationMs": 259.266,
"layouts": 76,
"layoutDurationMs": 29.566,
"taskDurationMs": 1382.9499999999998,
"heapDeltaBytes": 8628908,
"heapUsedBytes": 114934528,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 467.471,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.70625,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1420.6449999996948,
"styleRecalcs": 78,
"styleRecalcDurationMs": 261.184,
"layouts": 76,
"layoutDurationMs": 28.42,
"taskDurationMs": 1401.095,
"heapDeltaBytes": 8806488,
"heapUsedBytes": 115021180,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 478.72600000000006,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.693827160493836,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0a63e2ad1c9ac019d89f390c2ea75e09327bce7e
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-15902.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-2wtfab3gy-comfyui.vercel.app Last updated: 2026-10-04T03:07:17Z for |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## ryan-di/fe-1491-stack-05-model-routing #15902 +/- ##
==========================================================================
- Coverage 85.78% 85.77% -0.01%
==========================================================================
Files 2437 2441 +4
Lines 139240 139691 +451
Branches 37652 36000 -1652
==========================================================================
+ Hits 119441 119826 +385
- Misses 19422 19488 +66
Partials 377 377
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
1239376 to
7780b9f
Compare
7780b9f to
974ed95
Compare
15633a0 to
12be702
Compare
12be702 to
8c89a97
Compare
8c89a97 to
9df6728
Compare
`scanAllMediaCandidates` lost its `isCloud` parameter on main (#12398). The merge was textually clean, so nothing conflicted and only CI saw it - it typechecks the branch merged with main, which is what my local app typecheck does not do.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium cloud Recorded test titles:
|
|
My agent accidentally merged 6/6. I will restore 5/6 and resolve this PR separately. |
… template setup (Comfy-Org#15875) ## Summary Connects the final model launch choices to the already-prepared workflow. ## Changes - `Open now` opens immediately and starts no idle model downloads. - `Download models & open` requests every eligible idle/failed missing model row, then opens immediately without waiting for transfers. - Individual model download remains available from its Detail row. - Web/Cloud and model-ready Desktop paths remain direct-open. - Consumes the bounded/cancellable readiness result owned by [Comfy-Org#15872](Comfy-Org#15872) without duplicating metadata lifecycle ownership in this layer. - Renames the browser fixture action from `loadTemplate` to `selectTemplate` so clicking a card does not falsely imply that a workflow already loaded. Input asset authority and open-time handoff are intentionally owned by [Comfy-Org#20084](Comfy-Org#20084). Final CTA presentation is owned by [Comfy-Org#16109](Comfy-Org#16109). ## Stack Stack 5/6. Previous: [Comfy-Org#15873](Comfy-Org#15873). Next: [Comfy-Org#20084](Comfy-Org#20084), which replaces [Comfy-Org#15902](Comfy-Org#15902). ## Review focus - Both actions open the exact prepared graph without refetching or waiting. - `Open now` starts no downloads. `Download models & open` starts every eligible idle or failed row; an individual row action starts only that model. - The browser-level non-Desktop path proves that selecting a template loads nodes without presenting Detail. ## Screenshots Captured from `WorkflowTemplateDetail.stories.ts`, added in this slice. Its fixtures mirror what `buildTemplateDetailGroups` emits - one `models` group, labels read from `i18n`, and a byte-size total only once every declaration carries one. The Before capture renders the base branch's Detail with the same fixture. | State | | |---|---| | **Before** - the base branch offers one action, `Open template`, whatever the models need |<img width="2360" height="1400" alt="fe1491-detail-before" src="https://github.com/user-attachments/assets/78d434e2-0583-4b80-8a3c-c989601b58e2" /> | | `Open now` - the missing model can only be fetched by hand, so opening is the only action |<img width="2360" height="1400" alt="fe1491-detail-open-now" src="https://github.com/user-attachments/assets/2a905f8f-c206-4976-b409-b226669f11cb" />| | Resolving - metadata is still arriving, so `Download models & open` is shown disabled |<img width="2360" height="1400" alt="fe1491-detail-resolving" src="https://github.com/user-attachments/assets/bc83b3e1-dd90-455d-b637-68d221df88e8" />| | Downloadable - `Download models & open` plus the per-row download action |<img width="2360" height="1400" alt="fe1491-detail-downloadable" src="https://github.com/user-attachments/assets/f5f26ffa-0e48-44a1-8ade-319cb7634ffe" />| ## Validation At `8230ddbc` on this branch: 7 Vitest files / 149 tests across the files this slice changes - the Detail component and its dialog case, the folder-path cache, the model-download dispatch, the row-downloads composable and the reducer. App typecheck (`vue-tsc -p tsconfig.json`) 0 errors, `pnpm oxlint` 0 errors, ESLint 0 errors on the touched trees. CI status at this head is whatever GitHub shows on the PR. Linear: [FE-1491](https://linear.app/comfyorg/issue/FE-1491) · [Review spec](https://app.notion.com/p/3c76d73d365081c9bffde74a29e5b6c4) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
* test(downloads): specify exact-destination asset jobs * test(downloads): preserve exact policy on retry * feat(downloads): admit exact-destination asset jobs * test(downloads): specify active asset snapshots * feat(downloads): expose active asset snapshots * refactor(tests): use managed asset job types * test(templates): specify input asset snapshots * feat(templates): resolve input asset snapshots * test(templates): specify input asset bridge * feat(templates): expose input asset IPC * test(templates): specify input download correlation * feat(templates): correlate input asset downloads * test(templates): reject remote input asset requests * fix(templates): restrict input assets to local installs * chore(bridge-types): publish template input contract * refactor(tests): use canonical bridge types * test(templates): distinguish unresolved input metadata * fix(templates): preserve unknown input metadata * docs(bridge-types): clarify input metadata fallback * refactor(tests): simplify template input coverage Remove RED-phase import/export fallbacks, reuse typed download fixtures, and make the two-destination DownloadItem test model concurrent writes before either completion so temp-directory cleanup cannot make it order-dependent. * test(templates): tighten input asset boundaries Cover destination-keyed retry, extension-derived media types, explicit IPC response fields, invalid requests, admission fallback, and per-destination bytes. The first three cases fail against the current implementation for the intended reasons. * fix(templates): preserve input asset boundaries Key exact-policy retries by canonical destination, classify approved media from the filename extension, and construct IPC responses from explicit bridge fields so internal resolver metadata cannot leak to the renderer. * refactor(tests): reuse exact asset download harness Centralize exact-policy admission and DownloadItem binding so destination, retry, filename, and finalization cases share the same typed setup without weakening their filesystem assertions. * test(downloads): protect exact job admission * fix(downloads): require exact-compatible joins * test(preload): preserve early terminal progress * fix(preload): replay early terminal progress * chore(bridge-types): publish breaking contract * fix(downloads): deliver join progress to the consumer that asked Addresses benceruleanlu's finding on the join path. A joining request was subscribed as a BrowserWindow and replayed to that window's webContents. The ComfyUI consumer is a WebContentsView, which is why the originating path already sends through senderContents, so a joiner from that view received neither the replay nor any later event. Joins now record the requesting contents alongside the window, and the broadcast fans out to both, skipping the originating target so it is not sent twice. Not covered by a test: adding one to the asset-download suite leaked harness state into five neighbouring cases, and untangling that shared harness is a larger change than this fix. * fix(templates): call the resolver by the name main gave it The conflict resolution left the snapshot calling extractTemplateInputAssets, which main renamed to resolveTemplateInputAssetsFromJson. My local check ran tsconfig.json only; the project's typecheck covers four tsconfigs and is what caught it. * fix(downloads): take benceruleanlu's four directions on the input bridge **One exact-job predicate.** join, lookup and the retry guard each decided what counts as the same asset work, and only join checked preserveRequestedFilename. A deduplicating job for the same URL may land as `name (1).png`, so the other two could report a completion for a file the caller never asked for, and block its retry. `isExactAssetJobFor` is now shared by all three. **A skip request refuses a truncated name.** Windows path-length truncation shortened the stem while the workflow node and the availability probe both use the untruncated name, so the bytes landed where nothing looks: the row stayed missing, the node stayed broken, and every open downloaded it again. Returning not-started loses nothing - that case never worked - and stops the repeat. **In-flight invokes hold the progress handler.** A download invoke can resolve after its last subscriber has gone. Clearing the identity maps in that window lost the terminal event and left the re-attached handler alive for the renderer's lifetime. **One snapshot per template per burst.** A template with four inputs meant five resolutions, each an uncached remote fetch for templates outside the installed packages, with every download waiting on one. A 30s snapshot also keeps the set stable, so an asset the view just listed cannot come back not-declared because the remote changed mid-burst. Failures are not held. Also parallelises the availability probe, which awaited fs.access one file at a time. The snapshot cache has cases for both halves - one resolution across a burst, and a retry after an unresolved template - and each fails under its own mutation. The other three ride on the existing suites; adding cases to the asset-download harness leaks state across neighbours, which is noted on the temp-cleanup thread. * fix(templates): evict only the snapshot entry that failed CodeRabbit caught a real defect in the cache I added. A resolution can outlive its own 30-second TTL, by which point a later call has stored a newer snapshot under the same key. The eviction callback deleted by key without checking ownership, so a slow failure threw away a good entry that had already been handed to callers. The callback compares the entry it owns before deleting. Removing that comparison fails the new case. * fix(templates): report a template input that is already on disk `already-present` carried no download, so the preload had nothing to track and emitted nothing. A renderer watches `onTemplateInputDownloadProgress` and nothing else, so a file that landed between the availability answer and the download call stayed flagged as missing until some later sync happened to run. DrJKL found this reviewing the frontend side (Comfy-Org/ComfyUI_frontend#15902). I first worked around it there by calling into the graph-sync singleton directly, which bypassed the download store - so the preview cache was never invalidated for exactly the file the fix was for - and added a second owner of completions to a module he had asked to see removed. Reverted, and fixed here instead. The result now names the file, and the preload emits one terminal event for it. Nothing on the frontend changes: the fan-out that already feeds both the store and the graph sync picks it up like any other completion. The download id is derived from the template and asset, so a renderer that de-duplicates terminal events sees one completion per file however often a template is reopened. Both admission paths carry it - the availability probe and the download manager's exact-path check. * chore(bridge-types): regenerate declarations for the already-present filename `src/types/comfyDesktopBridge.ts` is the source; the package declarations are generated from it by `bridge-types:gen`, which CI verifies with `bridge-types:check`. I changed the contract without regenerating, so that check would have failed. * fix(downloads): keep a retried transfer named, and claim exact paths atomically **A retry no longer loses the template input it serves.** Benjamin's diagnosis: a retry mints a new `randomUUID`, the renderer dropped the mapping for the old id on its terminal `error`, and nothing linked the new one back - so a retried file could land in `input/` with the detail row stuck in `error`. Taking the second of his two suggestions, the job now carries the identity: `AssetDownloadOptions` accepts it, `PendingDownload` holds it, `RetryParams` preserves it across a retry, and `broadcastProgress` names it on every event. The renderer reads it off the event instead of correlating by id; its map stays only for desktop builds that do not send the field. Reverting any of the three wirings fails the new case. **Exact destinations are claimed with `linkSync`, not probed with `existsSync`.** CodeRabbit is right that the probe and the later `renameSync` are separate operations, and that POSIX rename would then replace a file another writer created in between. The link is the claim and the test in one step; only `EEXIST` means the existing file wins. Other link errors - `EXDEV` across filesystems, some network shares - fall through to the rename rather than reporting a success that never happened, which has its own case. **`discardTempFile`** replaces the fifth copy of the unlink/rmdir pair, per Benjamin's nit. The extraction is behaviour-preserving; removing the unlink still fails the in-flight case. * style: run prettier on the retry-correlation test * fix(downloads): keep the no-clobber guarantee when the hard link fails An exact-destination owner claimed its path with linkSync, but any failure other than EEXIST fell through to the generic renameSync below, and rename replaces an existing file on POSIX. So the one case the link was added for - another writer creating the destination mid-transfer - came back whenever the link itself could not be made, which is what happens across filesystems and on some network shares. The fallback is copyFileSync with COPYFILE_EXCL now: same no-clobber guarantee, and unlike a hard link it works across filesystems. Dropping the flag fails the new case, where the destination appears while linkSync is throwing EXDEV and its contents have to survive. * fix(downloads): end an exact-destination download when the copy fails The copy fallback only handled EEXIST. Any other failure - ENOSPC, EACCES, a failing network share - left `tempPath` set and fell through to the rename below, and rename replaces an existing file on POSIX. That is the clobber the link and the exclusive copy exist to prevent, so the one path that reached it was the path where both had already failed. It now discards the temp file, reports the error, unregisters the download and returns, the way the rename's own failure branch does. The regression test asserts `renameSync` is never called, since a later rewrite could preserve the file by luck while still reaching the fallback. --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
…ktop template inputs (Comfy-Org#20084) ## Summary Completes the trusted Desktop input-asset contract while templates still open immediately. ## Changes - Restricts automatic asset authority to official/default templates; custom and extension templates cannot turn arbitrary missing inputs into managed downloads. - Lists declared Input Assets in Template Detail for transparency, with no per-asset action or transfer status. - Hands off missing trusted assets on every Desktop open route: `Open now`, `Download models & open`, model-ready direct open, and asset-only direct open. - Keeps `Open now` passive for models while still performing the trusted asset handoff. - Leaves transfer progress and recovery to the opened Graph/App and global managed-download surfaces. - Clears resolved missing-media errors and refreshes graph bindings as managed asset transfers complete. - Requires [Comfy-Desktop Comfy-Org#1435](Comfy-Org/Comfy-Desktop#1435) and the published bridge contract before merge. ## Stack Stack 6/6, replacing [Comfy-Org#15902](Comfy-Org#15902). Previous: [Comfy-Org#15875](Comfy-Org#15875). Final Detail copy/layout: [Comfy-Org#16109](Comfy-Org#16109). ## Desktop dependency The host side is [Comfy-Desktop#1435](Comfy-Org/Comfy-Desktop#1435), which owns the bridge contract this slice consumes. It is not a merge blocker: `src/types/comfyDesktopBridgeTemplateInputs.d.ts` declares the new members locally on top of the published `0.2.0` types, every host method is optional, and each call site guards, so a Desktop build without them simply does not light the feature up. What it does set is release ordering. Once Comfy-Org#1435 merges and `@comfyorg/comfyui-desktop-bridge-types@0.3.0` is published, this branch owes two edits: bump the catalog pin in `pnpm-workspace.yaml` from `0.2.0`, and delete the local declaration file. ## Review focus - Viewing Detail starts no transfer. - Input assets never become a second reason to enter Detail. - Only trusted template declarations can authorize asset download. - Open-time handoff is consistent across every Desktop open route. ## Validation At `d190e1af` on this branch: 13 Vitest files / 207 tests for the files this slice changes. App typecheck (`vue-tsc -p tsconfig.json`) 0 errors, `pnpm oxlint` 0 errors, ESLint 0 errors on the touched trees. CI status at this head is whatever GitHub shows on the PR. Linear: [FE-1491](https://linear.app/comfyorg/issue/FE-1491) · [Review spec](https://app.notion.com/p/3c76d73d365081c9bffde74a29e5b6c4) --- Reopened from Comfy-Org#15902, which GitHub closed as merged when its head commits reached this PR's base branch through a mistaken push. Nothing was merged to `main`; the base branch has been restored to its own scope and this branch rebuilt on it. The review history on Comfy-Org#15902 still applies to this diff. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Summary
Completes the trusted Desktop input-asset contract while templates still open immediately.
Changes
Open now,Download models & open, model-ready direct open, and asset-only direct open.Open nowpassive for models while still performing the trusted asset handoff.Stack
Stack 6/6. Previous: #15875. Final Detail copy/layout: #16109.
Review focus
Validation
At
f1e04e32on this branch: 11 Vitest files / 187 tests for the files this slicechanges. App typecheck (
vue-tsc -p tsconfig.json) 0 errors,pnpm oxlint0errors, ESLint 0 errors on the touched trees. Required CI is green on this PR.
Linear: FE-1491 · Review spec