Repository navigation
Template model requirements (FE-1491): feat(templates): resolve model readiness - #15872
Conversation
|
Important Review skippedThe saved review history does not include the base for the last reviewed commit. This saved history cannot establish the base for an incremental review. Comment You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR adds desktop template detail navigation. It adds model availability and metadata resolution, cancellable preparation, failure toasts, stale-work protection, modal scroll restoration, localized labels, and focused tests. ChangesWorkflow template detail flow
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~60 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant User
participant WorkflowTemplateSelectorDialog
participant useTemplateWorkflows
participant useTemplateModelAvailability
participant resolveTemplateModelMetadata
participant WorkflowTemplateDetail
User->>WorkflowTemplateSelectorDialog: Select template
WorkflowTemplateSelectorDialog->>useTemplateWorkflows: Prepare template
useTemplateWorkflows-->>WorkflowTemplateSelectorDialog: Return prepared workflow
WorkflowTemplateSelectorDialog->>useTemplateModelAvailability: Resolve required model availability
useTemplateModelAvailability-->>WorkflowTemplateSelectorDialog: Return availability statuses
WorkflowTemplateSelectorDialog->>resolveTemplateModelMetadata: Resolve missing-model metadata
resolveTemplateModelMetadata-->>WorkflowTemplateSelectorDialog: Return setup data or aborted status
WorkflowTemplateSelectorDialog->>WorkflowTemplateDetail: Render model setup
Possibly related PRs
Merge Risk: 🔵 Low · up to The new detail flow can show an error for an action the user already abandoned, and malformed legacy templates may fail to open. The remaining issues have bounded fallbacks but should be addressed before relying on this flow broadly. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2193 passed, 0 failed📊 Browser Reports
📦 Bundle: 10.2 MB gzipDetailsSummary
Category Glance App Entry Points — 3.92 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.47 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 135 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 648 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 53.7 kBAuthentication, profile, and account management bundles
Status: 15 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 194 kBReusable component library chunks
Status: 18 added Data & Services — 4.11 MBStores, services, APIs, and repositories
Status: 14 added Utilities & Hooks — 587 kBHelpers, composables, and utility bundles
Status: 38 added Vendor & Third-Party — 17.2 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 18.4 MBBundles that do not match a named category
Status: 306 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-04T01:45:28.983Z",
"gitSha": "20efcaf4d2372b8a678740318e2954cba36efec2",
"branch": "ryan-di/fe-1491-stack-03-model-readiness",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.2710000000175,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.524,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.6770000000001,
"heapDeltaBytes": 22357336,
"heapUsedBytes": 76426176,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.418000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2015.096000000085,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5899999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.32499999999993,
"heapDeltaBytes": 597208,
"heapUsedBytes": 68615244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.743,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.3680000000131,
"styleRecalcs": 50,
"styleRecalcDurationMs": 14.658999999999999,
"layouts": 12,
"layoutDurationMs": 4.425,
"taskDurationMs": 734.287,
"heapDeltaBytes": 19495680,
"heapUsedBytes": 73187968,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.714,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1754.5939999999973,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.063000000000002,
"layouts": 12,
"layoutDurationMs": 4.3149999999999995,
"taskDurationMs": 749.7909999999999,
"heapDeltaBytes": 19546936,
"heapUsedBytes": 73538588,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.57299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.675999999973,
"styleRecalcs": 30,
"styleRecalcDurationMs": 8.447000000000001,
"layouts": 6,
"layoutDurationMs": 1.1499999999999997,
"taskDurationMs": 354.316,
"heapDeltaBytes": -26189532,
"heapUsedBytes": 79051228,
"domNodes": -179,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 11.612,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.2279999999437,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.278,
"layouts": 6,
"layoutDurationMs": 1.324,
"taskDurationMs": 338.85699999999997,
"heapDeltaBytes": 3390352,
"heapUsedBytes": 70766332,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.381000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 680.2890000000161,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.665,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.19399999999996,
"heapDeltaBytes": -8103136,
"heapUsedBytes": 59214720,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 163.344,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 674.3880000000217,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.9099999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.25199999999995,
"heapDeltaBytes": -9080696,
"heapUsedBytes": 58993392,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 154.928,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1145.4840000000104,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 798.4749999999999,
"heapDeltaBytes": 13935072,
"heapUsedBytes": 93390396,
"domNodes": 0,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 67.371,
"eventListeners": 0,
"totalBlockingTimeMs": 512,
"frameDurationMs": 33.8264705882353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1118.7100000000783,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 779.93,
"heapDeltaBytes": 15356440,
"heapUsedBytes": 92713444,
"domNodes": 0,
"jsHeapTotalBytes": 7766016,
"scriptDurationMs": 53.394999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 494,
"frameDurationMs": 33.83636363636365,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.6849999999795,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.88700000000006,
"heapDeltaBytes": 18367612,
"heapUsedBytes": 104325588,
"domNodes": 0,
"jsHeapTotalBytes": 1839104,
"scriptDurationMs": 142.48299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 213,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.5090000000218,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.7030000000001,
"heapDeltaBytes": 16225204,
"heapUsedBytes": 90393024,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 144.66299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.76285714285711,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8367.677999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7482.738,
"heapDeltaBytes": -783892,
"heapUsedBytes": 79766512,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 6252.385,
"eventListeners": 0,
"totalBlockingTimeMs": 327,
"frameDurationMs": 31.74752851711027,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7568.797999999902,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6873.1939999999995,
"heapDeltaBytes": 12447964,
"heapUsedBytes": 86868108,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 5762.750999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 76,
"frameDurationMs": 30.265600000000003,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8425.89700000002,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9890000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7774.750000000001,
"heapDeltaBytes": 16312704,
"heapUsedBytes": 94224636,
"domNodes": -142,
"jsHeapTotalBytes": -4591616,
"scriptDurationMs": 6374.992,
"eventListeners": -78,
"totalBlockingTimeMs": 174,
"frameDurationMs": 30.828937728937728,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8285.131999999976,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8640000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7696.763000000001,
"heapDeltaBytes": 9072244,
"heapUsedBytes": 93525572,
"domNodes": -143,
"jsHeapTotalBytes": -5640192,
"scriptDurationMs": 6255.436000000001,
"eventListeners": -82,
"totalBlockingTimeMs": 124,
"frameDurationMs": 30.502952029520294,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2058.7580000000116,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5670000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.2280000000002,
"heapDeltaBytes": -53352060,
"heapUsedBytes": 72137904,
"domNodes": -328,
"jsHeapTotalBytes": -1146880,
"scriptDurationMs": 35.906,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2020.2020000000402,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.641,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.30000000000007,
"heapDeltaBytes": -10860840,
"heapUsedBytes": 77289756,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.26000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2178.449999999998,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.924000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1462.6999999999998,
"heapDeltaBytes": 405496,
"heapUsedBytes": 64096648,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.42,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2199.832000000015,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.876,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1463.807,
"heapDeltaBytes": 1221460,
"heapUsedBytes": 64343344,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 781.239,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79242424242424,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3592.947000000038,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.504,
"layouts": 60,
"layoutDurationMs": 15.037999999999998,
"taskDurationMs": 1600.283,
"heapDeltaBytes": -20631440,
"heapUsedBytes": 69380064,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 780.3330000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3623.593000000028,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.105999999999998,
"layouts": 60,
"layoutDurationMs": 15.819999999999997,
"taskDurationMs": 1626.061,
"heapDeltaBytes": 2628880,
"heapUsedBytes": 81299076,
"domNodes": 24,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 784.693,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665898617511527,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3094.229999999982,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.889999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1772.9240000000002,
"heapDeltaBytes": 5813644,
"heapUsedBytes": 71393068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 957.0179999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757065217391304,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3123.6069999999927,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.9319999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1853.8640000000003,
"heapDeltaBytes": 8899084,
"heapUsedBytes": 77660308,
"domNodes": 0,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 1001.8660000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755913978494622,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.409000000006,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.823000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.1939999999999,
"heapDeltaBytes": -27118976,
"heapUsedBytes": 72944872,
"domNodes": -328,
"jsHeapTotalBytes": -3280896,
"scriptDurationMs": 31.99,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.1230000000123,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.076999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.12199999999996,
"heapDeltaBytes": -10796308,
"heapUsedBytes": 78643048,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.014,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 660.9060000000113,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.287000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.049,
"heapDeltaBytes": -12565036,
"heapUsedBytes": 57264648,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 151.03300000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 599.0990000000238,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.441000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.36899999999997,
"heapDeltaBytes": -12583460,
"heapUsedBytes": 57274324,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 141.887,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.92399999997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.855999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.181,
"heapDeltaBytes": 22024584,
"heapUsedBytes": 76254180,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.85,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.958999999977,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.996999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.574,
"heapDeltaBytes": 673524,
"heapUsedBytes": 70401964,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.495000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.9439999999881,
"styleRecalcs": 59,
"styleRecalcDurationMs": 16.901,
"layouts": 16,
"layoutDurationMs": 5.622999999999999,
"taskDurationMs": 733.659,
"heapDeltaBytes": -6401152,
"heapUsedBytes": 62502840,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 104.431,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.1379999999917,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.613,
"layouts": 16,
"layoutDurationMs": 5.996,
"taskDurationMs": 725.3080000000001,
"heapDeltaBytes": 15006680,
"heapUsedBytes": 69277316,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.9,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1370.5429999999978,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.018999999999995,
"layouts": 5,
"layoutDurationMs": 11.758999999999999,
"taskDurationMs": 852.5639999999999,
"heapDeltaBytes": 23982320,
"heapUsedBytes": 110593920,
"domNodes": 13747,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 27.70199999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 115,
"frameDurationMs": 19.21249999999999,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8242.513999999972,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.335,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5134.392999999999,
"heapDeltaBytes": -60975564,
"heapUsedBytes": 64342060,
"domNodes": -328,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 2528.862,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8256.060999999932,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.057,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5366.901000000001,
"heapDeltaBytes": 13586132,
"heapUsedBytes": 92008772,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2745.517,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665991902834012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17686.283000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16920.256,
"heapDeltaBytes": -21383692,
"heapUsedBytes": 179119608,
"domNodes": -3045,
"jsHeapTotalBytes": 13352960,
"scriptDurationMs": 282.17,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.487241379310344,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 17695.970000000103,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16829.642,
"heapDeltaBytes": -30504304,
"heapUsedBytes": 181494112,
"domNodes": -3045,
"jsHeapTotalBytes": 10833920,
"scriptDurationMs": 282.521,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.487241379310348,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 21475.545000000013,
"styleRecalcs": 171,
"styleRecalcDurationMs": 20.562000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21060.484000000004,
"heapDeltaBytes": -3704444,
"heapUsedBytes": 195633484,
"domNodes": -3045,
"jsHeapTotalBytes": 11710464,
"scriptDurationMs": 860.1,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.84125475285171,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 20525.844000000005,
"styleRecalcs": 164,
"styleRecalcDurationMs": 20.289,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20177.215,
"heapDeltaBytes": -20561400,
"heapUsedBytes": 190190840,
"domNodes": -3045,
"jsHeapTotalBytes": 6103040,
"scriptDurationMs": 860.603,
"eventListeners": -14915,
"totalBlockingTimeMs": 9,
"frameDurationMs": 38.23556797020484,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6325.443000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.58600000000004,
"layouts": 20,
"layoutDurationMs": 24.884000000000004,
"taskDurationMs": 6276.083,
"heapDeltaBytes": 1161376,
"heapUsedBytes": 215164680,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 109.433,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.33602484472051,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6182.653000000073,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.852,
"layouts": 20,
"layoutDurationMs": 25.486000000000008,
"taskDurationMs": 6044.780000000001,
"heapDeltaBytes": 918952,
"heapUsedBytes": 211624680,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 109.214,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.23657142857144,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8853.63799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8632.379999999997,
"heapDeltaBytes": -15781096,
"heapUsedBytes": 185444688,
"domNodes": -3045,
"jsHeapTotalBytes": 6123520,
"scriptDurationMs": 147.776,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.62145328719724,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8879.766000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8575.232000000002,
"heapDeltaBytes": -33154524,
"heapUsedBytes": 178687768,
"domNodes": -3045,
"jsHeapTotalBytes": 8728576,
"scriptDurationMs": 142.942,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.67958477508651,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 472.0670000000382,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.875000000000002,
"layouts": 3,
"layoutDurationMs": 0.9249999999999998,
"taskDurationMs": 111.71099999999997,
"heapDeltaBytes": 5767240,
"heapUsedBytes": 59445256,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.780000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 490.22200000001703,
"styleRecalcs": 20,
"styleRecalcDurationMs": 16.13,
"layouts": 3,
"layoutDurationMs": 1.6859999999999997,
"taskDurationMs": 113.099,
"heapDeltaBytes": 5613296,
"heapUsedBytes": 70555784,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.936,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 899.4330000000446,
"styleRecalcs": 78,
"styleRecalcDurationMs": 107.723,
"layouts": 76,
"layoutDurationMs": 27.258000000000003,
"taskDurationMs": 871.283,
"heapDeltaBytes": -7890496,
"heapUsedBytes": 81736344,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 356.465,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 905.495999999971,
"styleRecalcs": 78,
"styleRecalcDurationMs": 110.261,
"layouts": 76,
"layoutDurationMs": 26.862000000000002,
"taskDurationMs": 874.092,
"heapDeltaBytes": 18306732,
"heapUsedBytes": 83252316,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 352.573,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667272727272742,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1391.7209999999614,
"styleRecalcs": 78,
"styleRecalcDurationMs": 269.606,
"layouts": 76,
"layoutDurationMs": 29.994,
"taskDurationMs": 1365.067,
"heapDeltaBytes": -19139252,
"heapUsedBytes": 108087492,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 440.826,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.72151898734177,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1411.559000000011,
"styleRecalcs": 78,
"styleRecalcDurationMs": 278.884,
"layouts": 76,
"layoutDurationMs": 29.775,
"taskDurationMs": 1382.503,
"heapDeltaBytes": 8455412,
"heapUsedBytes": 114119560,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 444.525,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.931645569620233,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1db92c0d1e1c1a86164b641527f63a09e4f3046a
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## ryan-di/fe-1491-stack-02-template-detail #15872 +/- ##
============================================================================
+ Coverage 85.73% 85.74% +0.01%
============================================================================
Files 2425 2430 +5
Lines 138454 138804 +350
Branches 35738 35832 +94
============================================================================
+ Hits 118698 119018 +320
- Misses 19380 19411 +31
+ Partials 376 375 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
3284c2b to
15cbed9
Compare
|
@coderabbitai review |
|
15cbed9 to
0687d77
Compare
0b9d4cf to
2cded79
Compare
2cded79 to
57542a5
Compare
57542a5 to
2964893
Compare
jaeone94
left a comment
There was a problem hiding this comment.
Reviewed the diff at 2964893b against base cb430e95.
The shape is good: pure derivation split from I/O, red-then-green commit pairs, a discriminated TemplateModelMetadataBatchResult, and a status ladder that degrades to unknown rather than guessing. templateModelAvailability.ts in particular is the cleanest thing here. The regression surface on the shared missingModelDownload.ts is genuinely additive — I traced every existing caller and the resolution === 'failed' ⟺ cacheable === false invariant holds at all eight return sites, so a template-flow failure cannot poison the missing-model dialog's cache.
Three things block, and one pattern is worth naming above the individual findings: the tests currently ratify two of the defects rather than catching them. Both were found by mutating the implementation, not by reading it — details inline.
How I measured
Everything below labelled "measured" was executed, not reasoned about. So you can reproduce or dispute it:
- Live app — built this stack with
DISTRIBUTION=desktop, pointed a Desktop instance's--front-end-rootat thatdist, opened Template Detail over CDP and read the rendered DOM. Cross-checked againstlson the model directory to know which files were actually present. - Template corpus — fetched all 499 templates from
/templates/{name}.jsonon a local backend and walkednodes[].properties.models, subgraph definitions, and top-levelmodelsto collect all 1,055 declared model entries. Used that to test whether the inputs a finding needs actually occur in shipped data. - Mutation — applied a candidate fix (or inverted a branch), re-ran the file's suite, and recorded whether anything failed.
I mention it because two findings I was ready to raise did not survive that check, and I would rather say so than ship them:
- The three-way identity encoding split (
modelKeynormalises separators,modelIdentitydoesn't, metadata keys by URL) produces a real double-count in a synthetic fixture. Across all 1,055 declared entries there are zero names containing a path separator, zero padded name/directory values, and zero same-file-different-spelling collisions, andmergeModelRequirementDetailscollapses[name, directory]upstream, so the wrong-gated-repo variant cannot reachderiveTemplateModelSetupthrough the pipeline at all. Raised as a suggestion on the exported contract, not a defect. - The unmapped-directory label path is not a raw folder-name leak —
formatRequirementTypehumanises it, and folder names are proper-noun-ish and shouldn't be translated anyway. The actual concern turned out to be the opposite one, inline onmodelTypeKeys.
Everything else is inline, prefixed Issue / Suggestion / Nit.
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at 93771d5d. The previous prepared-workflow cleanup blocker is addressed and required CI is green. The remaining review threads are non-blocking test and code-quality follow-ups.
The merge-base changed after approval.
93771d5 to
71581eb
Compare
**The stale branch now proves it releases.** Removing `releasePreparedDetail()` from the post-prepare generation check left all 13 cases green, exactly as reported. The case asserts the discard receives the resolved handle, and that mutation fails it. **Dropped an assertion callers cannot observe.** The call count and the result equality already prove one fetch per unique URL and a stable output order; the worker start order was frozen on top of that, so a queue refactor with identical results would have failed. **Typed the metadata mock to its real contract**, which surfaced the mismatch the cast was hiding: the fixture entries were missing `gatedRepoUrl`. Telemetry uses the shared typed mock now. Double assertions in this file go from five to three; the remaining ones are on composables whose surface the dialog does not exercise, and one keeps a cast because a group fixture's `title` type does not line up. **Removed the one-line alias helper.** engineering.md rule 11 rules it out and a docblock cannot prove a cast safe, both of which apply. The cast is inline at the call site again, and widening `loadGraphData`'s input stays the real fix, tracked separately. **Removed a docblock that restated the five lines under it.**
christian-byrne
left a comment
There was a problem hiding this comment.
Re-reviewed at 19ac0b4. The readiness and lifecycle findings from the prior rounds are addressed, no review threads remain open, and current-head checks pass.
Selection now returns whatever a node declared, down to a bare name. This slice needs the strict shape - a template download has nowhere to put a model without a url and directory - so it narrows the result here instead of widening what it promises. The strict schema's export also moves to this slice, which is where its first consumer is.
A model type is a proper noun here. The asset browser formats the raw directory with `formatCategoryLabel` and the missing-model rows show it verbatim; this slice was the only place running it through `t()`. The row carries the declared directory now and the view formats it the same way, so `Checkpoints` and `Text Encoders` read as they do elsewhere instead of gaining a second spelling. The `modelTypes` locale keys, the known/directory union and its five-entry mapping go with it. This gives up `LoRA` for `Loras`, which is what `formatCategoryLabel` produces. The place for that spelling is that formatter's special cases, beside `diffusion_models`, where the asset browser would get it too - not a second mapping only this screen sees.
christian-byrne
left a comment
There was a problem hiding this comment.
Re-approved at 6ea5b9b after reviewing the propagated preparation changes and the model-directory label correction. The delta is consistent with the stack contracts and CI is green.
…y detail view (Comfy-Org#15874) ## Summary Extracts and hardens reusable template preview and dependency-detail presentation components. Production Detail routing and model-readiness admission are owned by [frontend PR 15872](Comfy-Org#15872). ## Changes - Preserves zero-zoom template-card behavior through the extracted preview wrapper. - Covers media branching, overlays, logos, and the imperative detail focus contract. - Uses VueUse hover tracking and non-comparative Cloud copy. ## Stack Stack 2/6. Previous: [frontend PR 15876](Comfy-Org#15876). Next: [frontend PR 15872](Comfy-Org#15872). ## Validation At `fa5f3154` on this branch: 2 Vitest files / 12 tests for the files this slice changes. App typecheck (`vue-tsc -p tsconfig.json`) 0 errors, `pnpm oxlint` 0 errors, ESLint 0 errors on the touched trees. Required CI is green on this PR. Linear: [FE-1491](https://linear.app/comfyorg/issue/FE-1491) --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
… model downloads (Comfy-Org#15873) ## Summary Adds the per-model download tracker primitives for Desktop Template Detail: a composable that holds row state, correlates native host progress, and exposes a read-only `stateFor(model)`. This slice has no production owner — the wiring that mounts it in Detail lands in [Comfy-Org#15875](Comfy-Org#15875), so product behaviour belongs to that PR, not this one. ## Changes - Tracks queued, starting, active, paused, completed, failed and retry states through a reducer, and correlates native progress against them. - Supports Desktop2, legacy Electron and browser outcomes without inventing progress nobody reported. A host that refuses a request — a resolved `false`, matching the convention `openModelAccessPage` documents on the same bridge — fails the row rather than leaving it in `starting`. - Correlates native events by `ComfyDownloadProgress.id` where the host sends one. An attempt is claimed by the job that reports activity for it, only that job may end it, and a job that has delivered its own terminal event cannot claim a later attempt — so arrival order does not decide who holds a retry. A job is remembered on that terminal event rather than on the claim, because a request the host joins to a transfer already running reuses that job's id: the retry's job is the same job, and refusing it would strand the row. One gap this leaves, not closable from the renderer: hosts that send no id at all — older desktop builds, and Electron — keep the attempt heuristic, where a delayed event from an abandoned attempt still reaches the current row. It needs a request token from the host at accept time, and the dispatch result carries no job id today. - Takes resolved folder paths as a value, so a queued row dispatches at once or fails and no lookup outlives its owner. - Creates the legacy Electron subscription only on the first dispatch that lands there, so Desktop2 never constructs that store. - Buffers live Electron progress during the snapshot restore and replays it afterwards, so a delayed snapshot cannot move a download backwards and no live event is dropped. The progress fan-out isolates each subscriber. - Keeps `stateFor(model)` read-only while already-rendered rows still react to later updates, and disposes idempotently. ## Stack Stack 4/6. Previous: [Comfy-Org#15872](Comfy-Org#15872). Next: [Comfy-Org#15875](Comfy-Org#15875). Final assets: [Comfy-Org#20084](Comfy-Org#20084). Cumulative UI: [Comfy-Org#16109](Comfy-Org#16109). ## Review focus - Job-id correlation: whether claiming an attempt on non-terminal activity, and honouring a terminal event only from the claiming job, is the right rule for a payload with no request token. - The snapshot/live-event ordering in `electronDownloadStore.initialize`, which buffers rather than choosing one of the two failure modes. - Rendering an idle row establishes the Vue dependency a later download needs to update in place, without reads creating tracking state. ## Screenshots Every model-row state, from the `Components/Templates/WorkflowTemplateModelStatus → Every State` story (`pnpm storybook`): idle, queued, starting, active, paused, downloaded, failed, cancelled, installed, manual, unavailable and unknown. <img width="410" height="571" alt="Every model-row status state" src="https://github.com/user-attachments/assets/3967182e-9f2c-40e7-ba0c-4b9239a833f6" /> ## Validation At `8bac45b9` on this branch: 5 Vitest files / 128 tests covering the composable, the reducer, the Electron store and the Detail components. App typecheck (`vue-tsc -p tsconfig.json`) 0 errors, `pnpm oxlint` 0 errors, ESLint 0 errors on the touched trees, and `fallow audit --gate new-only` reports no issues across the changed files. CI status at this head is whatever GitHub shows on the PR; the last head I watched to completion was `e2afbc4`, where every required check passed or was skipped. Each fix in this round was checked by reverting it and confirming a named case fails. I did not retain the run output, so the record is the mutation and the case it breaks, quoted on the thread for each finding - reproducible from those two lines rather than from a log I can link. Not verified here: the two-window Desktop race for template inputs, and any manual Desktop flow at this head. Linear: [FE-1491](https://linear.app/comfyorg/issue/FE-1491) · [Review spec](https://app.notion.com/p/3c76d73d365081c9bffde74a29e5b6c4) --------- Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
… template setup (Comfy-Org#15875) ## Summary Connects the final model launch choices to the already-prepared workflow. ## Changes - `Open now` opens immediately and starts no idle model downloads. - `Download models & open` requests every eligible idle/failed missing model row, then opens immediately without waiting for transfers. - Individual model download remains available from its Detail row. - Web/Cloud and model-ready Desktop paths remain direct-open. - Consumes the bounded/cancellable readiness result owned by [Comfy-Org#15872](Comfy-Org#15872) without duplicating metadata lifecycle ownership in this layer. - Renames the browser fixture action from `loadTemplate` to `selectTemplate` so clicking a card does not falsely imply that a workflow already loaded. Input asset authority and open-time handoff are intentionally owned by [Comfy-Org#20084](Comfy-Org#20084). Final CTA presentation is owned by [Comfy-Org#16109](Comfy-Org#16109). ## Stack Stack 5/6. Previous: [Comfy-Org#15873](Comfy-Org#15873). Next: [Comfy-Org#20084](Comfy-Org#20084), which replaces [Comfy-Org#15902](Comfy-Org#15902). ## Review focus - Both actions open the exact prepared graph without refetching or waiting. - `Open now` starts no downloads. `Download models & open` starts every eligible idle or failed row; an individual row action starts only that model. - The browser-level non-Desktop path proves that selecting a template loads nodes without presenting Detail. ## Screenshots Captured from `WorkflowTemplateDetail.stories.ts`, added in this slice. Its fixtures mirror what `buildTemplateDetailGroups` emits - one `models` group, labels read from `i18n`, and a byte-size total only once every declaration carries one. The Before capture renders the base branch's Detail with the same fixture. | State | | |---|---| | **Before** - the base branch offers one action, `Open template`, whatever the models need |<img width="2360" height="1400" alt="fe1491-detail-before" src="https://github.com/user-attachments/assets/78d434e2-0583-4b80-8a3c-c989601b58e2" /> | | `Open now` - the missing model can only be fetched by hand, so opening is the only action |<img width="2360" height="1400" alt="fe1491-detail-open-now" src="https://github.com/user-attachments/assets/2a905f8f-c206-4976-b409-b226669f11cb" />| | Resolving - metadata is still arriving, so `Download models & open` is shown disabled |<img width="2360" height="1400" alt="fe1491-detail-resolving" src="https://github.com/user-attachments/assets/bc83b3e1-dd90-455d-b637-68d221df88e8" />| | Downloadable - `Download models & open` plus the per-row download action |<img width="2360" height="1400" alt="fe1491-detail-downloadable" src="https://github.com/user-attachments/assets/f5f26ffa-0e48-44a1-8ade-319cb7634ffe" />| ## Validation At `8230ddbc` on this branch: 7 Vitest files / 149 tests across the files this slice changes - the Detail component and its dialog case, the folder-path cache, the model-download dispatch, the row-downloads composable and the reducer. App typecheck (`vue-tsc -p tsconfig.json`) 0 errors, `pnpm oxlint` 0 errors, ESLint 0 errors on the touched trees. CI status at this head is whatever GitHub shows on the PR. Linear: [FE-1491](https://linear.app/comfyorg/issue/FE-1491) · [Review spec](https://app.notion.com/p/3c76d73d365081c9bffde74a29e5b6c4) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
Summary
Resolves truthful Desktop model readiness and owns the pre-load Detail admission contract for active model requirements.
Changes
Stack
Stack 3/6. Previous: #15874. Next: #15873. Cumulative UI: #16109.
Review focus
Validation
At
19ac0b40on this branch: 8 Vitest files / 179 tests for the files this slicechanges. App typecheck (
vue-tsc -p tsconfig.json) 0 errors,pnpm oxlint0errors, ESLint 0 errors on the touched trees. Required CI is green on this PR.
Linear: FE-1491 · Review spec