Repository navigation
Template model requirements (FE-1491): feat(templates): add dependency detail view - #15874
Conversation
|
Important Review skippedThe saved review history does not include the base for the last reviewed commit. This saved history cannot establish the base for an incremental review. Comment You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds a workflow template detail component with requirements, Cloud messaging, and open actions. Adds localized strings, detail types, and tests. Centralizes template thumbnail rendering in a reusable ChangesWorkflow template detail
Unified template previews
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The component change has no established merge-blocking behavior issue. Adding uncontrolled-hover coverage remains a useful follow-up. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The check fails. Bug-fix signals appear in the commit subjects, including ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2191 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 10.2 MB gzipDetailsSummary
Category Glance App Entry Points — 3.92 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.47 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 135 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 648 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 53.7 kBAuthentication, profile, and account management bundles
Status: 15 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 194 kBReusable component library chunks
Status: 18 added Data & Services — 4.09 MBStores, services, APIs, and repositories
Status: 14 added Utilities & Hooks — 587 kBHelpers, composables, and utility bundles
Status: 38 added Vendor & Third-Party — 17.2 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 18.4 MBBundles that do not match a named category
Status: 306 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-04T01:36:00.796Z",
"gitSha": "1db92c0d1e1c1a86164b641527f63a09e4f3046a",
"branch": "ryan-di/fe-1491-stack-02-template-detail",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.3640000000382,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.136,
"heapDeltaBytes": 553424,
"heapUsedBytes": 68301180,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.457000000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2023.1989999999769,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.2560000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.1859999999999,
"heapDeltaBytes": 602284,
"heapUsedBytes": 68064208,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.688999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.8730000000137,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.500000000000004,
"layouts": 12,
"layoutDurationMs": 4.207,
"taskDurationMs": 788.106,
"heapDeltaBytes": -2964156,
"heapUsedBytes": 65425952,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 163.542,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1769.3329999999605,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.183,
"layouts": 12,
"layoutDurationMs": 4.226999999999999,
"taskDurationMs": 804.319,
"heapDeltaBytes": -2719532,
"heapUsedBytes": 65126484,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 166.625,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66698113207547,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.0569999999639,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.356,
"layouts": 6,
"layoutDurationMs": 1.171,
"taskDurationMs": 332.416,
"heapDeltaBytes": 25644080,
"heapUsedBytes": 79675672,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.026,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.4929999999476,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.558000000000002,
"layouts": 6,
"layoutDurationMs": 1.032,
"taskDurationMs": 307.167,
"heapDeltaBytes": 25668184,
"heapUsedBytes": 79724156,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.811000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 676.1569999999892,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.7359999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.589,
"heapDeltaBytes": -8105612,
"heapUsedBytes": 59509200,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 163.25099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 681.9960000000265,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.407999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.73699999999997,
"heapDeltaBytes": -34257524,
"heapUsedBytes": 68090772,
"domNodes": -232,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 164.41499999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1172.2579999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 823.2429999999999,
"heapDeltaBytes": 13639904,
"heapUsedBytes": 93396188,
"domNodes": 0,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 70.773,
"eventListeners": 0,
"totalBlockingTimeMs": 539,
"frameDurationMs": 34.30882352941177,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1140.7089999999016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 750.833,
"heapDeltaBytes": 15601360,
"heapUsedBytes": 84696712,
"domNodes": 0,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 73.042,
"eventListeners": 0,
"totalBlockingTimeMs": 517,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.7020000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.82599999999996,
"heapDeltaBytes": 17474640,
"heapUsedBytes": 104430376,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 165.45399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.2809999999627,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.09900000000016,
"heapDeltaBytes": 17684700,
"heapUsedBytes": 105087360,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 166.52100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10700.779000000011,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05599999999999876,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9700.262,
"heapDeltaBytes": -8437232,
"heapUsedBytes": 76043784,
"domNodes": -142,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 8124.740000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 1538,
"frameDurationMs": 34.18370607028754,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8541.308000000072,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7520000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7850.108,
"heapDeltaBytes": 8308140,
"heapUsedBytes": 92587500,
"domNodes": -142,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 6605.575,
"eventListeners": -78,
"totalBlockingTimeMs": 754,
"frameDurationMs": 33.659842519685036,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10234.681999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9366.949,
"heapDeltaBytes": -12709584,
"heapUsedBytes": 67725320,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 7775.416,
"eventListeners": 0,
"totalBlockingTimeMs": 1090,
"frameDurationMs": 32.79807692307692,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9648.174999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8931.098,
"heapDeltaBytes": -3989040,
"heapUsedBytes": 73736300,
"domNodes": -143,
"jsHeapTotalBytes": -2494464,
"scriptDurationMs": 7408.32,
"eventListeners": -82,
"totalBlockingTimeMs": 1037,
"frameDurationMs": 33.38996539792388,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2039.5840000000476,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.928,
"heapDeltaBytes": -52914664,
"heapUsedBytes": 72509880,
"domNodes": -328,
"jsHeapTotalBytes": -2195456,
"scriptDurationMs": 31.437999999999995,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2019.2879999999604,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.576000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.001,
"heapDeltaBytes": 14747384,
"heapUsedBytes": 90589084,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.60999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2245.6240000000207,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.607,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1573.1419999999998,
"heapDeltaBytes": -20218176,
"heapUsedBytes": 68569932,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 839.817,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.790298507462683,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2498.66499999996,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.123000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1647.1970000000001,
"heapDeltaBytes": -16805380,
"heapUsedBytes": 71935068,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 899.6310000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665999999999997,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3593.3499999999867,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.392,
"layouts": 60,
"layoutDurationMs": 13.763,
"taskDurationMs": 1627.0259999999998,
"heapDeltaBytes": -293828,
"heapUsedBytes": 64710400,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 753.2650000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3536.7479999999887,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.369999999999997,
"layouts": 60,
"layoutDurationMs": 13.719,
"taskDurationMs": 1625.146,
"heapDeltaBytes": 1738952,
"heapUsedBytes": 69066152,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 776.225,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3129.322000000002,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.115,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1888.7519999999997,
"heapDeltaBytes": 8963236,
"heapUsedBytes": 77462928,
"domNodes": 0,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 990.67,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75508021390374,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3033.619999999928,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.141000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1822.463,
"heapDeltaBytes": 5121268,
"heapUsedBytes": 69468868,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 929.6010000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758888888888887,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.0889999999795,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.835999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.4649999999999,
"heapDeltaBytes": -9995932,
"heapUsedBytes": 78736636,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.449999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.505999999964,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.1830000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.28300000000013,
"heapDeltaBytes": -9819248,
"heapUsedBytes": 79324288,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.176000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 654.3479999999704,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.995000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.267,
"heapDeltaBytes": -40954176,
"heapUsedBytes": 63465336,
"domNodes": -249,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 144.349,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 643.9270000000761,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.103,
"heapDeltaBytes": -11975256,
"heapUsedBytes": 57546552,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 144.625,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2025.980000000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.370000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.499,
"heapDeltaBytes": -30001592,
"heapUsedBytes": 75378464,
"domNodes": -250,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 8.256999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.363000000074,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.5159999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.12399999999997,
"heapDeltaBytes": 21941752,
"heapUsedBytes": 75687268,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.077,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.7240000000374,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.974999999999998,
"layouts": 16,
"layoutDurationMs": 5.83,
"taskDurationMs": 780.4279999999999,
"heapDeltaBytes": -6314408,
"heapUsedBytes": 63697400,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.37,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.3630000000903,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.918000000000003,
"layouts": 16,
"layoutDurationMs": 5.138,
"taskDurationMs": 742.6709999999999,
"heapDeltaBytes": 15031472,
"heapUsedBytes": 69372980,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.729,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.5769999999748,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.679000000000002,
"layouts": 5,
"layoutDurationMs": 12.629000000000001,
"taskDurationMs": 929.7390000000001,
"heapDeltaBytes": 23878472,
"heapUsedBytes": 108560308,
"domNodes": 13747,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 32.534,
"eventListeners": 2383,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.143243243243237,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8525.48999999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.501000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5619.691000000001,
"heapDeltaBytes": -18674784,
"heapUsedBytes": 68731020,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2768.685,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698627450980393,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8336.68,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.88999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5425.835999999999,
"heapDeltaBytes": 7207256,
"heapUsedBytes": 94943888,
"domNodes": 0,
"jsHeapTotalBytes": 753664,
"scriptDurationMs": 2713.1150000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699198396793587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17617.343000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16779.316000000003,
"heapDeltaBytes": -17665696,
"heapUsedBytes": 191316484,
"domNodes": -3045,
"jsHeapTotalBytes": 8990720,
"scriptDurationMs": 274.875,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.372241379310346,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 17387.762000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16607.790999999997,
"heapDeltaBytes": -39996312,
"heapUsedBytes": 171731248,
"domNodes": -3045,
"jsHeapTotalBytes": 6639616,
"scriptDurationMs": 276.89599999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.263804713804713,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 21004.57899999998,
"styleRecalcs": 173,
"styleRecalcDurationMs": 20.187999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20637.559,
"heapDeltaBytes": -34497580,
"heapUsedBytes": 173655180,
"domNodes": -3045,
"jsHeapTotalBytes": 8466432,
"scriptDurationMs": 860.0989999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 16,
"frameDurationMs": 37.7681654676259,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 21095.124999999938,
"styleRecalcs": 166,
"styleRecalcDurationMs": 17.858999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20692.371000000003,
"heapDeltaBytes": -45932708,
"heapUsedBytes": 180239676,
"domNodes": -1525,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 843.0970000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 25,
"frameDurationMs": 38.471715328467155,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6287.624999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.12800000000003,
"layouts": 20,
"layoutDurationMs": 22.914000000000005,
"taskDurationMs": 6122.294000000001,
"heapDeltaBytes": -12626524,
"heapUsedBytes": 214196024,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 108.78699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.80800000000001,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6253.949999999918,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.17200000000003,
"layouts": 20,
"layoutDurationMs": 22.576999999999998,
"taskDurationMs": 6095.933,
"heapDeltaBytes": 884624,
"heapUsedBytes": 210083508,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 99.35399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.07988165680474,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8635.072999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8331.813,
"heapDeltaBytes": -29160660,
"heapUsedBytes": 182116932,
"domNodes": -3045,
"jsHeapTotalBytes": 10768384,
"scriptDurationMs": 133.074,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.39788732394366,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8599.54700000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8329.288000000002,
"heapDeltaBytes": -29888152,
"heapUsedBytes": 177761204,
"domNodes": -3045,
"jsHeapTotalBytes": 5074944,
"scriptDurationMs": 130.519,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.955218855218856,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 147.38499999998567,
"styleRecalcs": 10,
"styleRecalcDurationMs": 16.194,
"layouts": 4,
"layoutDurationMs": 1.8940000000000001,
"taskDurationMs": 115.69200000000002,
"heapDeltaBytes": 3962868,
"heapUsedBytes": 57477964,
"domNodes": -135,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.033,
"eventListeners": -122,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 493.36699999992106,
"styleRecalcs": 14,
"styleRecalcDurationMs": 13.644,
"layouts": 3,
"layoutDurationMs": 0.9060000000000001,
"taskDurationMs": 129.656,
"heapDeltaBytes": 5710636,
"heapUsedBytes": 59270288,
"domNodes": -130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.020999999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 955.2019999999857,
"styleRecalcs": 78,
"styleRecalcDurationMs": 107.78500000000001,
"layouts": 76,
"layoutDurationMs": 26.351,
"taskDurationMs": 926.501,
"heapDeltaBytes": 18521596,
"heapUsedBytes": 83458400,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 387.73,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 912.2830000000022,
"styleRecalcs": 78,
"styleRecalcDurationMs": 105.877,
"layouts": 76,
"layoutDurationMs": 26.695,
"taskDurationMs": 886.7379999999999,
"heapDeltaBytes": 18218848,
"heapUsedBytes": 84390804,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 370.16900000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636364,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1370.1790000000074,
"styleRecalcs": 78,
"styleRecalcDurationMs": 254.068,
"layouts": 76,
"layoutDurationMs": 27.830000000000002,
"taskDurationMs": 1356.928,
"heapDeltaBytes": -19258836,
"heapUsedBytes": 109789556,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 450.941,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.510126582278495,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1436.4100000000235,
"styleRecalcs": 78,
"styleRecalcDurationMs": 276.37600000000003,
"layouts": 76,
"layoutDurationMs": 29.075,
"taskDurationMs": 1416.497,
"heapDeltaBytes": -19392904,
"heapUsedBytes": 107586728,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 464.17400000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.58846153846156,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ff0653f8a5102c9a98ba879ecdf1b29af997cae4
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## ryan-di/fe-1491-stack-01-template-preparation #15874 +/- ##
=================================================================================
+ Coverage 85.70% 85.73% +0.02%
=================================================================================
Files 2423 2425 +2
Lines 138487 138454 -33
Branches 35740 35738 -2
=================================================================================
+ Hits 118688 118698 +10
+ Misses 19423 19380 -43
Partials 376 376
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
d362ef6 to
4ed81b8
Compare
|
@coderabbitai review |
|
4f5966b to
7fe784f
Compare
7fe784f to
e7e9798
Compare
e7e9798 to
cb430e9
Compare
jaeone94
left a comment
There was a problem hiding this comment.
Thread sweep: what is stale, what is still open
Correcting the record first: an earlier comment of mine on this PR said there were no findings outstanding on this slice. That was wrong - eight threads were unresolved and unanswered. This is the sweep that should have come with it. Every verdict below was checked against the current branch tip rather than inferred from the thread text.
Stale, closing without change (5 threads)
| Finding | Why it no longer applies |
|---|---|
| Detail view has no production consumer | The second option you offered was taken: production Detail routing is owned by 3/6 (#15872), which imports the component into the dialog. The PR body says so now. Card clicks here still go through loadWorkflowTemplate, consistent with the narrowed scope. |
hoverZoom default is untested |
TemplatePreview.test.ts now kills that exact mutant: it asserts scale(1) with hoverZoom omitted, so a non-zero default would render scale(1.05) and fail. |
Exposed focus is untested |
A component-ref harness drives the exposed focus and asserts the labelled article takes focus, so defineExpose is mutation-covered. |
| Manual mouseenter/mouseleave wiring | Replaced with useTemplateRef plus useElementHover, as suggested. |
| Comparative copy in the detail strings | The detail block is non-comparative and makes no billing claim. There is also a test asserting no free-run messaging. |
One residual nit on the first row: the PR title still reads "add dependency detail view" even though the body now narrows the scope. Worth a retitle before merge.
Still open (3 threads, two fixes)
1. The uncontrolled hover path is never exercised. Raised independently by DrJKL and CodeRabbit, so two threads collapse into one fix. The test passes isHovered: true, which forces the controlled branch, and the only production consumer also passes :is-hovered. useElementHover could be replaced with a constant false and the suite would stay green. Either add an uncontrolled case - omit isHovered, pass a non-zero hoverZoom, hover the root, assert the scale changes - or drop the fallback if nothing is meant to use it.
2. Two of the four thumbnail branches are never reached. The wrapper dispatches on audio, compare-slider, hover-dissolve and default, but the suite only reaches default and compare-slider. Routing audio or hoverDissolve to DefaultThumbnail would still pass. A table over the four discriminators asserting each child's own observable root would close it.
Both are test-only and do not change the slice's shape. Happy to take them in a follow-up commit here; flagging rather than folding them in silently, since the stack is otherwise ready for re-review.
The suite reached only the default and compare-slider branches, so routing audio or hover-dissolve to DefaultThumbnail stayed green. A table over the four discriminators now asserts each child's own observable root; audio and compare-slider by their test ids, and dissolve against default by placeholder count, since dissolve stacks a base and an overlay image. Misrouting either branch fails its row. Images stay lazy under jsdom, so the count is of their placeholders rather than the images themselves.
Replaces the placeholder counting with a LazyImage stub, so the branches are distinguished by rendered images rather than by direct node access.
The component had two ways to learn it was hovered: the isHovered prop, and its own useElementHover as a fallback when the prop was absent. Nothing uses the fallback. The only consumer is the template card, which always passes :is-hovered, and this component is new in this stack, so no other caller exists anywhere. Both reviewers asked for a test of the uncontrolled path. Writing one turned out to be the wrong answer twice over: a browser test of the picker exercises the controlled path and says nothing about the fallback, and reaching the fallback at all means mounting the component in a shape no screen produces. Removing it answers the finding instead. isHovered becomes required, which the one consumer already satisfies.
jaeone94
left a comment
There was a problem hiding this comment.
Approving and lifting my change request from 01 September. Every thread I raised on this slice is answered and resolved, CI is green, and there are no open threads from any reviewer.
Where my own findings turned out to be wrong I said so on their threads rather than letting them stand: the failDownload narrowing would have swallowed every dispatch failure, and the template-name branch was main's code rather than this slice's. Two were coverage gaps rather than defects, and each now fails under its own mutation. One is tracked as #19879 rather than left as a thread, since a third resolution arm changes a type several slices read.
DrJKL's and christian-byrne's change requests are still the gate here, and they are theirs to lift.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
Re-reviewed c88f6fb9ef3aad81e69636e7d40f900fd49c9866 against the actual stacked base 2a58915ace3e8462ff4ece4c72d9fed50105e8b5 (#15876). I reviewed only this PR's 7-file diff. Changes inherited through the main/stack merge commits are context only; all of those merges were authored by jaeone94, and none were pushed by this reviewer.
No P0/P1/P2 findings remain. Two P3 PR-metadata nits, with no code change needed:
- [P3] The PR body still says this slice "Uses VueUse hover tracking". That stopped being true at
b1cbb4b2:TemplatePreviewnow takes a required, parent-ownedisHoveredand has no VueUse import. Please reword it, for example to "parent-controlled hover state". - [P3] The title still says "add dependency detail view", even though the body narrows the scope to reusable presentation. jaeone94 raised this in the sweep review, and it is still unchanged.
Prior findings
- Production Detail flow missing (P1): superseded. The scope is now presentation only; #15872 owns the routing and consumes this component.
TemplatePreviewregression coverage (P2): fixed by the zero-zoom test and the four-way dispatch table.- Exposed
focusuntested (P2): fixed by the component-ref harness. useElementHoverinstead of manual hover (P3): superseded. The fallback is gone, and hover is a required controlled prop.- Comparative and billing copy in Cloud strings (P2): fixed.
- Vacuous negative assertions (P3): fixed.
- Uncontrolled hover untested (P3): superseded because the fallback was removed.
- Audio and hover-dissolve dispatch untested (P3): fixed. Routing either branch to
DefaultThumbnailfails its own table row (mutation-verified). - Four
templateWorkflows.detail.*keys unused here: not a finding. #15872 consumes them, andtemplateWorkflows.*is excluded from the unused-key check.
Checks
Ran standard-depth correctness, maintainability, idiomaticity, tests, and documentation lanes. No Playwright files changed.
pnpm typecheck: pass- Vitest on both changed specs: 2 files, 12 tests passed
- Scoped ESLint, oxlint, and oxfmt: pass
git diff --checkagainst the base: passpnpm fallow:audit: no issues in changed files; advisory grid-track drift only, as assessed in the prior round- Exact-head CI: 124/124 checks completed (106 success, 18 skipped), combined status success
Superseded by #15874 (review) — prior findings fixed or superseded at c88f6fb.
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at c88f6fb9. The dependency detail view is isolated to this stack layer, its current review threads are closed, and required CI is green.
The merge-base changed after approval.
c88f6fb to
ef1a0c3
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Re-reviewed at fa5f315. The detail-view slice is mergeable, has no unresolved threads, and its current-head checks pass.
## Summary Validates a fetched template workflow - against the supported schema, then against the explicit legacy-loadable shape - before it reaches graph loading, and moves the shared model-selection helpers to their workflow-core owner. ## Changes - Accepts a supported workflow, or the explicit legacy-loadable shape, and rejects a payload that is neither - reported through telemetry with its own error type rather than the generic load failure. - Carries which of the two accepted it, so a legacy payload is not parsed a second time and does not reach sample-input preparation, which needs a strictly valid workflow. - Moves `getSelectedModelsMetadata` and its node-activity helpers out of `workbench/` into the workflow-core owner, and keeps partial entries a workflow declared while rejecting malformed ones. There is no public prepare/open seam in this slice: `useTemplateWorkflows()` exposes `loadWorkflowTemplate`, and resolution, validation and loading are private stages of that one call. ## Stack Stack 1/6 targeting `main`. Next: [Comfy-Org#15874](Comfy-Org#15874). Cumulative UI: [Comfy-Org#16109](Comfy-Org#16109). ## Review focus - Whether the loose per-entry parse in `declaredModels` is the right contract for `properties.models`: it keeps a bare `{ name }`, because workflows that fail strict validation still load and enrichment fills each field where present. - Whether the legacy-loadable shape is narrow enough to accept, given that `loadGraphData` takes what it accepts. ## Validation At `c3b66c00` on this branch: 3 Vitest files / 75 tests for the files this slice changes. App typecheck (`vue-tsc -p tsconfig.json`) 0 errors, `pnpm oxlint` 0 errors, ESLint 0 errors on the touched trees. Required CI is green on this PR. No GitHub issue to reference with `Fixes #n` - this work is tracked in Linear only. Linear: [FE-1491](https://linear.app/comfyorg/issue/FE-1491) · [Review spec](https://app.notion.com/p/3c76d73d365081c9bffde74a29e5b6c4) --------- Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
… readiness (Comfy-Org#15872) ## Summary Resolves truthful Desktop model readiness and owns the pre-load Detail admission contract for active model requirements. ## Changes - Reads only the unique model directories referenced by the active template and treats empty, loading, failed, or absent inventory as incomplete evidence. - Enters Detail only when at least one active model is positively missing; all-installed and installed/unknown results direct-open into the existing post-open recovery path. - Resolves unique model URLs with at most six concurrent lookups, a 10-second per-request timeout, and prompt parent cancellation. - Keeps local download admission independent from optional metadata: failed size/gating lookup leaves size unknown without erasing known local downloadability. - Preserves the full active declaration total for the Models group while later stack layers separately derive the remaining startable model size for the CTA. - Reports inventory failures at warning level and normalizes invalid sizes, gated URLs, raw folder labels, and shared model identity. ## Stack Stack 3/6. Previous: [Comfy-Org#15874](Comfy-Org#15874). Next: [Comfy-Org#15873](Comfy-Org#15873). Cumulative UI: [Comfy-Org#16109](Comfy-Org#16109). ## Review focus - Unknown inventory is not proof of absence and therefore does not force the pre-load Detail surface. - Metadata failure cannot silently remove an otherwise valid download action. - Models group total means the complete active declaration; the footer's remaining-download total is a separate selector contract. - Known model kinds keep semantic localized labels; only unknown/raw directories use the generic category formatter. - Broader Civitai taxonomy/parser/cache cleanup remains a follow-up outside this behavior correction. ## Validation At `19ac0b40` on this branch: 8 Vitest files / 179 tests for the files this slice changes. App typecheck (`vue-tsc -p tsconfig.json`) 0 errors, `pnpm oxlint` 0 errors, ESLint 0 errors on the touched trees. Required CI is green on this PR. Linear: [FE-1491](https://linear.app/comfyorg/issue/FE-1491) · [Review spec](https://app.notion.com/p/3c76d73d365081c9bffde74a29e5b6c4) --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
Summary
Extracts and hardens reusable template preview and dependency-detail presentation components. Production Detail routing and model-readiness admission are owned by frontend PR 15872.
Changes
Stack
Stack 2/6. Previous: frontend PR 15876. Next: frontend PR 15872.
Validation
At
fa5f3154on this branch: 2 Vitest files / 12 tests for the files this slicechanges. App typecheck (
vue-tsc -p tsconfig.json) 0 errors,pnpm oxlint0errors, ESLint 0 errors on the touched trees. Required CI is green on this PR.
Linear: FE-1491