Repository navigation
Conversation
🎭 Playwright: ⏳ Running...🎨 Storybook: 🚧 Building... |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughCivitai metadata responses are cached only when they contain a file matching the requested download URL. Tests cover retry behavior, concurrent lookups, and matching files with an unknown size. ChangesCivitai Metadata Lookup
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No merge-blocking issue is identified; normal checks remain appropriate before merging. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR title and commit subject use the bug-fix signal “fix.” The PR changes
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Closing this to keep my open PRs focused, since it hasn't gotten traction. Thanks for maintaining the project. Happy to reopen if it's still useful. |
Summary
Allow later Civitai metadata lookups to retry when a successful response contains no matching file.
Changes
Review Focus
#14348 deliberately cached successful no-match responses to avoid repeated requests. This narrowly changes that contract in response to the minimum follow-up requested in #19879. Repeated lookups after an unmatched response can now issue another API request.
Refs #19879 (cache portion only). This does not close the issue: the broader outcome vocabulary and unsupported-URL parser behavior deferred from #15872 remain unchanged. Current
mainhasfetchModelMetadata, not the stacked PR's resolution-status API.Tests
Browser E2E was not run: reproducing this exact provider-response transition in a browser would require a mocked Civitai sequence and workflow/UI setup. The focused tests directly exercise the public
fetchModelMetadataboundary with those controlled responses, verifying that a later lookup recovers and the valid result is cached.Assistance
Prepared with AI assistance; the regression was reproduced before the fix and the scoped checks above were run against the final patch.