Repository navigation
fix: align local profile billing menu with design - #15611
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a026bd-3054-7198-96fe-d35b273eaa9b Co-authored-by: Amp <amp@ampcode.com>
🎭 Playwright: ✅ 1975 passed, 0 failed · 5 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.11 MB gzip 🟢 -93 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.38 MB (baseline 1.38 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 591 kB (baseline 591 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.53 MB (baseline 3.53 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 549 kB (baseline 549 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 16 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.1 MB (baseline 14.1 MB) • 🔴 +1.06 kBBundles that do not match a named category
Status: 74 added / 74 removed / 211 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-23T12:32:28.247Z",
"gitSha": "dffa9e8975e6a76a903406969001716499af33a3",
"branch": "dante01yoon/fix-local-plans-and-credits",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2103.769,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.587,
"heapDeltaBytes": 19439468,
"heapUsedBytes": 81168804,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.539,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2040.805999999975,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.773000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.70899999999995,
"heapDeltaBytes": 19264376,
"heapUsedBytes": 81098736,
"domNodes": -281,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 13.097,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1957.1419999999762,
"styleRecalcs": 77,
"styleRecalcDurationMs": 43.933,
"layouts": 12,
"layoutDurationMs": 3.661,
"taskDurationMs": 985.6260000000001,
"heapDeltaBytes": 7829008,
"heapUsedBytes": 69504264,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 113.68299999999999,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1966.4860000000317,
"styleRecalcs": 74,
"styleRecalcDurationMs": 40.036,
"layouts": 12,
"layoutDurationMs": 3.731,
"taskDurationMs": 924.989,
"heapDeltaBytes": 7617036,
"heapUsedBytes": 70096988,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.88600000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.0569999999739,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.697,
"layouts": 6,
"layoutDurationMs": 0.654,
"taskDurationMs": 378.17799999999994,
"heapDeltaBytes": 3273320,
"heapUsedBytes": 65407320,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.657,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.2570000000132,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.230000000000004,
"layouts": 6,
"layoutDurationMs": 0.6169999999999999,
"taskDurationMs": 385.9,
"heapDeltaBytes": 3246572,
"heapUsedBytes": 65931108,
"domNodes": 78,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.807,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 579.1939999999727,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.4350000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.603,
"heapDeltaBytes": 10792172,
"heapUsedBytes": 73296268,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 52.904999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 590.8879999999499,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.504,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.82099999999997,
"heapDeltaBytes": 10851768,
"heapUsedBytes": 73418464,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 56.813,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.4169999999535,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.179000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.2979999999999,
"heapDeltaBytes": -2047096,
"heapUsedBytes": 74604960,
"domNodes": -268,
"jsHeapTotalBytes": 520192,
"scriptDurationMs": 13.778000000000002,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2038.789999999949,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.091,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 751.8800000000001,
"heapDeltaBytes": -13541848,
"heapUsedBytes": 62080412,
"domNodes": -284,
"jsHeapTotalBytes": 3665920,
"scriptDurationMs": 19.693,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2227.1200000000135,
"styleRecalcs": 70,
"styleRecalcDurationMs": 18.694,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1214.85,
"heapDeltaBytes": -2601224,
"heapUsedBytes": 75049812,
"domNodes": -242,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 348.62,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2194.7810000000345,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.314999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1179.872,
"heapDeltaBytes": 12403008,
"heapUsedBytes": 89287232,
"domNodes": -283,
"jsHeapTotalBytes": 4939776,
"scriptDurationMs": 312.54099999999994,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3151.3029999999844,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.795999999999998,
"layouts": 60,
"layoutDurationMs": 8.673,
"taskDurationMs": 1448.451,
"heapDeltaBytes": -13637352,
"heapUsedBytes": 65062204,
"domNodes": -289,
"jsHeapTotalBytes": 4452352,
"scriptDurationMs": 391.189,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3133.179000000041,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.339,
"layouts": 60,
"layoutDurationMs": 7.988,
"taskDurationMs": 1355.4660000000001,
"heapDeltaBytes": -13857936,
"heapUsedBytes": 65003752,
"domNodes": -288,
"jsHeapTotalBytes": 5238784,
"scriptDurationMs": 379.653,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2562.880000000007,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.639,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1514.593,
"heapDeltaBytes": 11137736,
"heapUsedBytes": 90669732,
"domNodes": 10,
"jsHeapTotalBytes": 7270400,
"scriptDurationMs": 486.83700000000005,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2321.8259999999873,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.736000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1520.619,
"heapDeltaBytes": -23062264,
"heapUsedBytes": 63617464,
"domNodes": -243,
"jsHeapTotalBytes": 5763072,
"scriptDurationMs": 470.80999999999995,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.7119999999945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.4889999999999,
"heapDeltaBytes": -7953524,
"heapUsedBytes": 74914548,
"domNodes": -272,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 13.728999999999997,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2059.8420000000033,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.6920000000001,
"heapDeltaBytes": -10835760,
"heapUsedBytes": 72319736,
"domNodes": -279,
"jsHeapTotalBytes": 4976640,
"scriptDurationMs": 17.948,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.0320000000124,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.892000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.253,
"heapDeltaBytes": 11621848,
"heapUsedBytes": 74219464,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 121.36800000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.506000000014,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.811,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.23600000000005,
"heapDeltaBytes": 10752424,
"heapUsedBytes": 73129164,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 122.34800000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2049.068000000034,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.405,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.639,
"heapDeltaBytes": 2775540,
"heapUsedBytes": 65075852,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.476,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.7600000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.312999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.66400000000004,
"heapDeltaBytes": 19105484,
"heapUsedBytes": 81540224,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 5.966000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1764.6849999999858,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.198,
"layouts": 16,
"layoutDurationMs": 5.241,
"taskDurationMs": 853.258,
"heapDeltaBytes": 4785692,
"heapUsedBytes": 67115508,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 94.39500000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1750.0410000000102,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.596,
"layouts": 16,
"layoutDurationMs": 4.906000000000001,
"taskDurationMs": 840.452,
"heapDeltaBytes": -6341904,
"heapUsedBytes": 55981364,
"domNodes": -285,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 91.57,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1398.6269999999195,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.630999999999993,
"layouts": 15,
"layoutDurationMs": 13.576,
"taskDurationMs": 979.3010000000002,
"heapDeltaBytes": -5915164,
"heapUsedBytes": 86248148,
"domNodes": 13673,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 18.898000000000007,
"eventListeners": 2373,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8381.074000000011,
"styleRecalcs": 250,
"styleRecalcDurationMs": 44.575,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4474.75,
"heapDeltaBytes": -11220352,
"heapUsedBytes": 64778428,
"domNodes": -280,
"jsHeapTotalBytes": 4190208,
"scriptDurationMs": 1031.058,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8206.726000000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.452000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4217.393999999999,
"heapDeltaBytes": 1536020,
"heapUsedBytes": 78236216,
"domNodes": -268,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 982.8309999999999,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18570.580000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17627.322,
"heapDeltaBytes": -67838312,
"heapUsedBytes": 164652140,
"domNodes": -8312,
"jsHeapTotalBytes": -20475904,
"scriptDurationMs": 129.34400000000002,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18556.758999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17540.119000000002,
"heapDeltaBytes": -40578904,
"heapUsedBytes": 180401992,
"domNodes": -8312,
"jsHeapTotalBytes": -19795968,
"scriptDurationMs": 123.19200000000001,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22167.035,
"styleRecalcs": 175,
"styleRecalcDurationMs": 22.504000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21542.846999999998,
"heapDeltaBytes": -26799172,
"heapUsedBytes": 194096964,
"domNodes": -8312,
"jsHeapTotalBytes": -24584192,
"scriptDurationMs": 463.36099999999993,
"eventListeners": -16385,
"totalBlockingTimeMs": 220,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22112.367999999948,
"styleRecalcs": 176,
"styleRecalcDurationMs": 21.811999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21556.315000000002,
"heapDeltaBytes": -31287640,
"heapUsedBytes": 194509836,
"domNodes": -8312,
"jsHeapTotalBytes": -14409728,
"scriptDurationMs": 416.894,
"eventListeners": -16387,
"totalBlockingTimeMs": 215,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 466.52100000005703,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.925,
"layouts": 3,
"layoutDurationMs": 1.1869999999999998,
"taskDurationMs": 113.892,
"heapDeltaBytes": 5063736,
"heapUsedBytes": 67275376,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.869000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 462.97100000003866,
"styleRecalcs": 14,
"styleRecalcDurationMs": 23.279,
"layouts": 4,
"layoutDurationMs": 1.4459999999999997,
"taskDurationMs": 111.43900000000001,
"heapDeltaBytes": 4934752,
"heapUsedBytes": 67187052,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.004,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe workspace popover now separates cloud subscription actions from local Plans and Credits. Local deployment tests cover menu visibility, permissions, credits navigation, workspace setup, and the updated browser selector. ChangesLocal Plans and Credits
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change limits billing actions to the appropriate distribution and adds the Local Plans and credits entry; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15611 +/- ##
==========================================
+ Coverage 79.45% 81.89% +2.43%
==========================================
Files 2218 1888 -330
Lines 112284 107289 -4995
Branches 31274 34392 +3118
==========================================
- Hits 89217 87863 -1354
+ Misses 22589 19088 -3501
+ Partials 478 338 -140
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 338 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Amp-Thread-ID: https://ampcode.com/threads/T-01a026bd-3054-7198-96fe-d35b273eaa9b Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a026bd-3054-7198-96fe-d35b273eaa9b Co-authored-by: Amp <amp@ampcode.com>
| }}</span> | ||
| </button> | ||
|
|
||
| <button |
There was a problem hiding this comment.
question: The new local button is gated on showPlansAndPricing (= canManageSubscription), while the Cloud "Manage plan" button uses showManagePlan (= canManageSubscription && (canAccessSubscriptionFeatures || hasDelinquentSubscription)). Is the looser guard on Local intentional? My read is yes -- credits exist on Local independently of subscriptions -- but it diverges silently from the Cloud gate. A brief comment or a dedicated showLocalPlanAndCredits computed would document the intent.
There was a problem hiding this comment.
Yes, the looser Local guard is intentional because Credits remains available independently of Cloud subscription lifecycle state. I made that contract explicit in 39dfda7 with a dedicated showLocalPlansAndCredits computed.
| expect(emitted('close')).toHaveLength(1) | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
suggestion (non-blocking): The new test covers isCloud=false + canManageSubscription=true (happy path) but not the inverse. Adding a single queryByTestId('plans-credits-menu-item') absent assertion for the beforeEach defaults (distribution.isCloud reset to true, canManageSubscription=false) would make the guard condition explicit in tests -- currently the existing "read-only member" test passes for combined Cloud+permission reasons, so the Local gate is only verified in one direction.
There was a problem hiding this comment.
Added in 39dfda7: the component test now explicitly renders Local with canManageSubscription=false and verifies plans-credits-menu-item is absent.
| }) | ||
|
|
||
| await comfyPage.cloudAuth.mockAuth() | ||
| await mockWorkspace(page, workspace('personal', 'owner'), []) |
There was a problem hiding this comment.
note: Adding mockWorkspace to this shared fixture makes every future consumer boot as a personal workspace owner (with implied canManageSubscription=true). That's the right semantics for this test, and the docstring was updated -- just flagging that a future spec needing a non-owner local user would need its own fixture or a mid-test override.
There was a problem hiding this comment.
Acknowledged. The fixture now deliberately documents its workspace-owner contract; a non-owner Local scenario should use a dedicated fixture or explicit per-test override rather than silently changing this shared default.
| @@ -163,6 +163,19 @@ | |||
| }}</span> | |||
There was a problem hiding this comment.
nitpick (non-blocking): handleOpenPlanAndCreditsSettings branches on isCloud at runtime, but isCloud is a compile-time constant -- one branch is dead in every build. Both callers are already distribution-gated in the template, so two focused single-purpose handlers (handleOpenManagePlan, handleOpenCreditsSettings) would remove the dead branches and make each button's intent self-contained. Not a functional issue, just a readability note.
There was a problem hiding this comment.
Split in 39dfda7 into handleOpenManagePlanSettings and handleOpenCreditsSettings, removing the runtime distribution branch.
| "partnerNodesCredits": "Partner nodes pricing", | ||
| "partnerNodesPricingTable": "Partner Nodes pricing table", | ||
| "plansAndPricing": "Plans & pricing", | ||
| "plansAndCredits": "Plans and credits", |
There was a problem hiding this comment.
note: subscription.plansAndCredits was added to en/main.json only. The 13 other locale files don't have it yet -- fallbackLocale: 'en' prevents a crash, but non-English users will see English text. The CI translation workflow only runs on version-bump-* branches, so this won't be auto-translated here. Mentioning in case a manual translation pass or .source-manifest.json exemption is needed before this ships to non-English locales.
There was a problem hiding this comment.
Confirmed against src/locales/CONTRIBUTING.md: regular feature/fix PRs add English source only, and release PRs run the translation workflow and update .source-manifest.json. pnpm locale:check passes, so the other locale files are intentionally unchanged here.
| @@ -139,7 +139,7 @@ | |||
| <Divider v-if="!accountActionsOnly" class="mx-0 my-2" /> | |||
|
|
|||
| <div | |||
There was a problem hiding this comment.
suggestion (non-blocking): The Cloud plans-pricing-menu-item is a <div @click> with no role, tabindex, or keyboard handler -- it is unreachable by keyboard. The new Local button is correctly a <button>, which highlights the gap. Worth converting plans-pricing-menu-item to <button> (same pattern as manage-plan-menu-item) or adding role="menuitem" tabindex="0" plus a @keydown.enter/@keydown.space handler as a minimum. Pre-existing issue, but you're already touching the guard on that element.
There was a problem hiding this comment.
Agreed this is an existing accessibility gap. This PR intentionally preserves Cloud behavior while fixing the Local regression; converting the pre-existing Cloud row should be a focused accessibility change with its own keyboard regression coverage.
Amp-Thread-ID: https://ampcode.com/threads/T-01a026bd-3054-7198-96fe-d35b273eaa9b Co-authored-by: Amp <amp@ampcode.com>
|
Current HEAD
No no-op code or commit was added to retrigger CI. |
…into dante01yoon/fix-local-plans-and-credits Amp-Thread-ID: https://ampcode.com/threads/T-01a0298b-4578-722e-9b96-cc20526b5dcb Co-authored-by: Amp <amp@ampcode.com> # Conflicts: # src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts
9235ada
|
@dante01yoon Successfully backported to #15746 |
|
@dante01yoon Successfully backported to #15747 |
|
|
Summary
Fixes QA finding #4 after #15151: the Local profile popover now shows the Local-specific Plans and credits action instead of Cloud-only billing actions.
Regression origin
The regression was introduced by #15164 (
848cd39ed06a2da6fea389305cf7210a0a18c5ee), not #15151. Before #15164, Local renderedCurrentUserPopoverLegacy; #15164 changedCurrentUserButtonto renderCurrentUserPopoverWorkspacein Local after workspace initialization. That shared popover already contained Plans & pricing and Manage plan rows whose visibility depended only on workspace permissions and subscription state, with no distribution boundary. Consequently, switching Local to that popover also exposed its Cloud-only billing navigation.#15151 independently fixed loading and billing-rail behavior inside Settings → Credits; it did not introduce the profile-menu regression.
Changes
CurrentUserPopoverWorkspaceselected billing rows only from workspace permissions and subscription state, so Local reused Cloud's Plans & pricing and Manage plan rows once workspace initialization completed.Review Focus
Confirm the distribution boundary: Cloud keeps Plans & pricing / Manage plan; Local gets one Plans and credits action opening
Settings > Credits.Validation
pnpm exec vitest run src/platform/workspace/components/CurrentUserPopoverWorkspace.test.tspnpm typecheckpnpm typecheck:browserpnpm locale:checkpnpm knipScreenshots