Repository navigation
[backport core/1.51] fix: align local profile billing menu with design - #15746
Conversation
## Summary Fixes QA finding #4 after #15151: the Local profile popover now shows the Local-specific **Plans and credits** action instead of Cloud-only billing actions. ## Regression origin The regression was introduced by [#15164](#15164) (`848cd39ed06a2da6fea389305cf7210a0a18c5ee`), not #15151. Before #15164, Local rendered `CurrentUserPopoverLegacy`; #15164 changed `CurrentUserButton` to render `CurrentUserPopoverWorkspace` in Local after workspace initialization. That shared popover already contained **Plans & pricing** and **Manage plan** rows whose visibility depended only on workspace permissions and subscription state, with no distribution boundary. Consequently, switching Local to that popover also exposed its Cloud-only billing navigation. [#15151](#15151) independently fixed loading and billing-rail behavior inside Settings → Credits; it did not introduce the profile-menu regression. ## Changes - **Root cause**: `CurrentUserPopoverWorkspace` selected billing rows only from workspace permissions and subscription state, so Local reused Cloud's **Plans & pricing** and **Manage plan** rows once workspace initialization completed. - **What**: Gate those existing rows to Cloud, and render the [Local Figma design](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Profile-Menu-Updates?node-id=6322-39073) action that opens Local Plan & Credits settings. - **Regression coverage**: Added distribution-specific component coverage and updated the Local credits browser flow to enter settings through the new action. Cloud behavior remains unchanged. ## Review Focus Confirm the distribution boundary: Cloud keeps **Plans & pricing** / **Manage plan**; Local gets one **Plans and credits** action opening `Settings > Credits`. ## Validation - `pnpm exec vitest run src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts` - related popover, user-button, and settings regression suites (70/70) - `pnpm typecheck` - `pnpm typecheck:browser` - targeted ESLint and formatting checks - `pnpm locale:check` - Local Playwright regression flow (Chromium) - Local and Cloud production builds - pre-push `pnpm knip` ## Screenshots | AS IS | TO BE | | --- | --- | | Local incorrectly exposes Cloud billing actions | Local shows the Figma-defined Plan & Credits action | |  |  | --------- Co-authored-by: Amp <amp@ampcode.com>
🎭 Playwright: ✅ 1825 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-23T12:57:39.604Z",
"gitSha": "c0c4a79e21801ff6464e7cbd6d18822912efb9c1",
"branch": "backport-15611-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2034.6359999999777,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.333000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.405,
"heapDeltaBytes": 5130676,
"heapUsedBytes": 70916968,
"domNodes": 16,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 8.283000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2038.6819999999943,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.540000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.793,
"heapDeltaBytes": 5258308,
"heapUsedBytes": 70571440,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 10.991999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2095.3139999999166,
"styleRecalcs": 79,
"styleRecalcDurationMs": 53.175,
"layouts": 12,
"layoutDurationMs": 3.8459999999999996,
"taskDurationMs": 1077.738,
"heapDeltaBytes": 145728,
"heapUsedBytes": 65050236,
"domNodes": 64,
"jsHeapTotalBytes": 25169920,
"scriptDurationMs": 135.65,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1920.0309999999945,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.282,
"layouts": 12,
"layoutDurationMs": 3.651,
"taskDurationMs": 959.116,
"heapDeltaBytes": -17178116,
"heapUsedBytes": 48247396,
"domNodes": -282,
"jsHeapTotalBytes": 22646784,
"scriptDurationMs": 119.305,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.9489999999578,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.182000000000002,
"layouts": 6,
"layoutDurationMs": 0.6529999999999999,
"taskDurationMs": 468.197,
"heapDeltaBytes": 7987404,
"heapUsedBytes": 73502456,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 14.170000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.1150000000362,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.028,
"layouts": 6,
"layoutDurationMs": 0.6439999999999998,
"taskDurationMs": 450.857,
"heapDeltaBytes": 7945476,
"heapUsedBytes": 73534464,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 14.406000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 666.7959999999766,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.31,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.20000000000005,
"heapDeltaBytes": -11779476,
"heapUsedBytes": 53623460,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 63.034000000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 637.271999999939,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.261,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.95399999999995,
"heapDeltaBytes": -11098632,
"heapUsedBytes": 54443616,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 60.260000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2033.6069999999609,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.192,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 747.5070000000001,
"heapDeltaBytes": 13069236,
"heapUsedBytes": 73156548,
"domNodes": -281,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 18.397999999999996,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2028.9920000000166,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.969999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 743.739,
"heapDeltaBytes": 12994280,
"heapUsedBytes": 73179752,
"domNodes": -283,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 18.956999999999994,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2407.0010000000366,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.847,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1354.805,
"heapDeltaBytes": 9868212,
"heapUsedBytes": 70883968,
"domNodes": -285,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 359.845,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2347.0379999999977,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.623000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1317.319,
"heapDeltaBytes": 10467420,
"heapUsedBytes": 71445556,
"domNodes": -282,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 348.457,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3362.991999999963,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.487000000000004,
"layouts": 60,
"layoutDurationMs": 7.953999999999999,
"taskDurationMs": 1519.253,
"heapDeltaBytes": 5166752,
"heapUsedBytes": 67235612,
"domNodes": -287,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 402.983,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3378.569000000084,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.258000000000001,
"layouts": 60,
"layoutDurationMs": 8.004,
"taskDurationMs": 1528.7269999999999,
"heapDeltaBytes": 5289460,
"heapUsedBytes": 67303324,
"domNodes": -289,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 413.779,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.2579999999707,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.029000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 758.008,
"heapDeltaBytes": 13175372,
"heapUsedBytes": 74801532,
"domNodes": -284,
"jsHeapTotalBytes": 1933312,
"scriptDurationMs": 18.481000000000005,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.9719999999634,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.017999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 722.5070000000002,
"heapDeltaBytes": 13189084,
"heapUsedBytes": 74704200,
"domNodes": -284,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 19.479999999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 643.1559999999763,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.100000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.01800000000003,
"heapDeltaBytes": -9835844,
"heapUsedBytes": 55585760,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 124.60000000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 655.8959999999843,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.913000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.481,
"heapDeltaBytes": -9990836,
"heapUsedBytes": 55708396,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 119.362,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.4099999999507,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.633999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.479,
"heapDeltaBytes": 5547620,
"heapUsedBytes": 71225028,
"domNodes": 18,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 9.297,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.8349999999673,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.052,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.1689999999999,
"heapDeltaBytes": 5548988,
"heapUsedBytes": 71223520,
"domNodes": 16,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 10.716,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.832999999956,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.821000000000005,
"layouts": 16,
"layoutDurationMs": 5.124,
"taskDurationMs": 854.561,
"heapDeltaBytes": -3850960,
"heapUsedBytes": 61663924,
"domNodes": 62,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 96.17999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.7220000000334,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.98799999999999,
"layouts": 16,
"layoutDurationMs": 5.209999999999999,
"taskDurationMs": 858.24,
"heapDeltaBytes": -3763108,
"heapUsedBytes": 61923416,
"domNodes": 60,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 92.052,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.734999999946,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.039,
"layouts": 13,
"layoutDurationMs": 13.440000000000001,
"taskDurationMs": 1033.2630000000004,
"heapDeltaBytes": 1401304,
"heapUsedBytes": 90888588,
"domNodes": 13673,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 20.298,
"eventListeners": 2375,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9232.160000000022,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.409,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4798.954999999999,
"heapDeltaBytes": 14272756,
"heapUsedBytes": 75016032,
"domNodes": -281,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 1153.2279999999998,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9075.449999999932,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.827,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4715.951,
"heapDeltaBytes": 3435988,
"heapUsedBytes": 64015224,
"domNodes": -284,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 1100.379,
"eventListeners": -161,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18422.51699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17388.525999999998,
"heapDeltaBytes": -32147564,
"heapUsedBytes": 166361976,
"domNodes": -8312,
"jsHeapTotalBytes": -15147008,
"scriptDurationMs": 134.73399999999998,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18306.61999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17269.972,
"heapDeltaBytes": -32351808,
"heapUsedBytes": 166116236,
"domNodes": -8312,
"jsHeapTotalBytes": -20389888,
"scriptDurationMs": 126.09400000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22823.82199999995,
"styleRecalcs": 179,
"styleRecalcDurationMs": 23.71899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22086.754,
"heapDeltaBytes": -15418116,
"heapUsedBytes": 181842736,
"domNodes": -8312,
"jsHeapTotalBytes": -14168064,
"scriptDurationMs": 465.842,
"eventListeners": -16383,
"totalBlockingTimeMs": 254,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22333.452000000078,
"styleRecalcs": 177,
"styleRecalcDurationMs": 24.17600000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21704.696,
"heapDeltaBytes": -38090628,
"heapUsedBytes": 172545036,
"domNodes": -8312,
"jsHeapTotalBytes": -16789504,
"scriptDurationMs": 476.6449999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 286,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 461.9920000000093,
"styleRecalcs": 14,
"styleRecalcDurationMs": 21.044999999999998,
"layouts": 3,
"layoutDurationMs": 0.722,
"taskDurationMs": 119.44200000000001,
"heapDeltaBytes": 4950444,
"heapUsedBytes": 69490688,
"domNodes": 128,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.748000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 465.0370000001658,
"styleRecalcs": 11,
"styleRecalcDurationMs": 19.799999999999997,
"layouts": 3,
"layoutDurationMs": 0.6839999999999999,
"taskDurationMs": 112.60000000000001,
"heapDeltaBytes": 4930844,
"heapUsedBytes": 69681744,
"domNodes": 119,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.521,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.51 #15746 +/- ##
==========================================
Coverage 81.65% 81.65%
==========================================
Files 1884 1884
Lines 107108 107115 +7
Branches 32641 32644 +3
==========================================
+ Hits 87454 87463 +9
+ Misses 19320 19309 -11
- Partials 334 343 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #15611 to
core/1.51Automatically created by backport workflow.