Repository navigation
[backport cloud/1.51] fix: align local profile billing menu with design - #15747
Conversation
## Summary Fixes QA finding #4 after #15151: the Local profile popover now shows the Local-specific **Plans and credits** action instead of Cloud-only billing actions. ## Regression origin The regression was introduced by [#15164](#15164) (`848cd39ed06a2da6fea389305cf7210a0a18c5ee`), not #15151. Before #15164, Local rendered `CurrentUserPopoverLegacy`; #15164 changed `CurrentUserButton` to render `CurrentUserPopoverWorkspace` in Local after workspace initialization. That shared popover already contained **Plans & pricing** and **Manage plan** rows whose visibility depended only on workspace permissions and subscription state, with no distribution boundary. Consequently, switching Local to that popover also exposed its Cloud-only billing navigation. [#15151](#15151) independently fixed loading and billing-rail behavior inside Settings → Credits; it did not introduce the profile-menu regression. ## Changes - **Root cause**: `CurrentUserPopoverWorkspace` selected billing rows only from workspace permissions and subscription state, so Local reused Cloud's **Plans & pricing** and **Manage plan** rows once workspace initialization completed. - **What**: Gate those existing rows to Cloud, and render the [Local Figma design](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Profile-Menu-Updates?node-id=6322-39073) action that opens Local Plan & Credits settings. - **Regression coverage**: Added distribution-specific component coverage and updated the Local credits browser flow to enter settings through the new action. Cloud behavior remains unchanged. ## Review Focus Confirm the distribution boundary: Cloud keeps **Plans & pricing** / **Manage plan**; Local gets one **Plans and credits** action opening `Settings > Credits`. ## Validation - `pnpm exec vitest run src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts` - related popover, user-button, and settings regression suites (70/70) - `pnpm typecheck` - `pnpm typecheck:browser` - targeted ESLint and formatting checks - `pnpm locale:check` - Local Playwright regression flow (Chromium) - Local and Cloud production builds - pre-push `pnpm knip` ## Screenshots | AS IS | TO BE | | --- | --- | | Local incorrectly exposes Cloud billing actions | Local shows the Figma-defined Plan & Credits action | |  |  | --------- Co-authored-by: Amp <amp@ampcode.com>
🎭 Playwright: ✅ 1821 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-23T12:56:57.329Z",
"gitSha": "9f5fda0635ab629bfc4c5390eeb44aa354f4cd66",
"branch": "backport-15611-to-cloud-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2031.9930000000568,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.162,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.65399999999994,
"heapDeltaBytes": 5080316,
"heapUsedBytes": 70602732,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.723999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2034.3599999999924,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.241,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.93399999999997,
"heapDeltaBytes": 4933536,
"heapUsedBytes": 70223328,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.744,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1993.9990000000307,
"styleRecalcs": 80,
"styleRecalcDurationMs": 47.392,
"layouts": 12,
"layoutDurationMs": 3.732,
"taskDurationMs": 1018.888,
"heapDeltaBytes": -15784812,
"heapUsedBytes": 49486680,
"domNodes": -282,
"jsHeapTotalBytes": 23957504,
"scriptDurationMs": 124.43900000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.7709999999943,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.744,
"layouts": 12,
"layoutDurationMs": 3.6119999999999997,
"taskDurationMs": 831.3040000000001,
"heapDeltaBytes": 59280,
"heapUsedBytes": 65607236,
"domNodes": 61,
"jsHeapTotalBytes": 24907776,
"scriptDurationMs": 111.485,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.4110000000182,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.32,
"layouts": 6,
"layoutDurationMs": 0.6309999999999998,
"taskDurationMs": 361.289,
"heapDeltaBytes": 8014608,
"heapUsedBytes": 73429556,
"domNodes": 78,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 9.411,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.275000000006,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.831,
"layouts": 6,
"layoutDurationMs": 0.5669999999999998,
"taskDurationMs": 361.676,
"heapDeltaBytes": 7830372,
"heapUsedBytes": 73125884,
"domNodes": 76,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 9.198999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 578.610000000026,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.476,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.074,
"heapDeltaBytes": -11319288,
"heapUsedBytes": 54087464,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 56.693999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 573.5079999999471,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.409999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.974,
"heapDeltaBytes": -11855720,
"heapUsedBytes": 53700492,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 58.285000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2024.8370000000477,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.352000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.5180000000001,
"heapDeltaBytes": 12059024,
"heapUsedBytes": 72393904,
"domNodes": -281,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 16.050999999999995,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2013.420999999994,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.2349999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.82,
"heapDeltaBytes": 12568772,
"heapUsedBytes": 73745900,
"domNodes": -287,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 13.617999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2159.7929999999224,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1172.2489999999998,
"heapDeltaBytes": 10018188,
"heapUsedBytes": 71074820,
"domNodes": -282,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 331.995,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2180.3489999999783,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.182000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1174.297,
"heapDeltaBytes": 4489928,
"heapUsedBytes": 65951520,
"domNodes": -283,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 326.12399999999997,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3232.4599999999464,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.152999999999997,
"layouts": 60,
"layoutDurationMs": 7.3629999999999995,
"taskDurationMs": 1397.6730000000002,
"heapDeltaBytes": -1004172,
"heapUsedBytes": 60876648,
"domNodes": -287,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 390.073,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3183.9389999998957,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.720000000000004,
"layouts": 60,
"layoutDurationMs": 7.2829999999999995,
"taskDurationMs": 1368.1180000000002,
"heapDeltaBytes": -4108112,
"heapUsedBytes": 58301384,
"domNodes": -285,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 383.60799999999995,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2025.32599999995,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.3100000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.5229999999999,
"heapDeltaBytes": 12801084,
"heapUsedBytes": 74024212,
"domNodes": -282,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 13.240000000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2016.324999999938,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.357999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.0039999999999,
"heapDeltaBytes": 13212680,
"heapUsedBytes": 74621024,
"domNodes": -285,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 13.248000000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.83000000005,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.582,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.154,
"heapDeltaBytes": -9975604,
"heapUsedBytes": 55705664,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 120.24600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.2450000000144,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.852,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.297,
"heapDeltaBytes": -10000696,
"heapUsedBytes": 55587116,
"domNodes": 22,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 119.89200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.9960000000247,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.59499999999997,
"heapDeltaBytes": 5535704,
"heapUsedBytes": 71283004,
"domNodes": 20,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 5.925000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.6810000000287,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.92,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.017,
"heapDeltaBytes": 5509100,
"heapUsedBytes": 71206096,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 5.811999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.2899999999481,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.43599999999999,
"layouts": 16,
"layoutDurationMs": 3.6670000000000003,
"taskDurationMs": 745.817,
"heapDeltaBytes": -3709956,
"heapUsedBytes": 61789664,
"domNodes": 63,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 81.032,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.803999999891,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.306000000000004,
"layouts": 16,
"layoutDurationMs": 4.573,
"taskDurationMs": 758.8059999999999,
"heapDeltaBytes": -3838148,
"heapUsedBytes": 61701904,
"domNodes": 63,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 83.759,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.6420000000617,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.480999999999995,
"layouts": 15,
"layoutDurationMs": 12.966000000000001,
"taskDurationMs": 935.9309999999998,
"heapDeltaBytes": -4058252,
"heapUsedBytes": 80862236,
"domNodes": 13673,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 17.706,
"eventListeners": 2375,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8264.098000000104,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.803000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4074.3150000000005,
"heapDeltaBytes": 13872120,
"heapUsedBytes": 74128632,
"domNodes": -280,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 1012.7329999999998,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8181.443000000058,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.441,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4093.1730000000002,
"heapDeltaBytes": 14548940,
"heapUsedBytes": 74616164,
"domNodes": -281,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 1007.571,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17179.569000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16495.677,
"heapDeltaBytes": -26437596,
"heapUsedBytes": 170889584,
"domNodes": -8312,
"jsHeapTotalBytes": -13574144,
"scriptDurationMs": 116.505,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16826.27200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16225.048999999999,
"heapDeltaBytes": -28043932,
"heapUsedBytes": 171325836,
"domNodes": -8312,
"jsHeapTotalBytes": -9375744,
"scriptDurationMs": 110.22900000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20681.413000000022,
"styleRecalcs": 169,
"styleRecalcDurationMs": 17.071,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20015.29,
"heapDeltaBytes": -27815724,
"heapUsedBytes": 182975884,
"domNodes": -8312,
"jsHeapTotalBytes": -11284480,
"scriptDurationMs": 388.94399999999996,
"eventListeners": -16385,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20483.173999999963,
"styleRecalcs": 166,
"styleRecalcDurationMs": 16.08299999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19889.404,
"heapDeltaBytes": -12319780,
"heapUsedBytes": 184709284,
"domNodes": -8346,
"jsHeapTotalBytes": -10760192,
"scriptDurationMs": 390.09299999999996,
"eventListeners": -16385,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 448.20499999991625,
"styleRecalcs": 12,
"styleRecalcDurationMs": 18.104000000000003,
"layouts": 2,
"layoutDurationMs": 0.37200000000000016,
"taskDurationMs": 99.71100000000001,
"heapDeltaBytes": 4947592,
"heapUsedBytes": 69636872,
"domNodes": 124,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6.980999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 453.42299999992974,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.028,
"layouts": 3,
"layoutDurationMs": 0.6000000000000001,
"taskDurationMs": 103.61599999999999,
"heapDeltaBytes": 4927668,
"heapUsedBytes": 69493696,
"domNodes": 123,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.868000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.51 #15747 +/- ##
=============================================
Coverage ? 81.55%
=============================================
Files ? 1884
Lines ? 117710
Branches ? 36773
=============================================
Hits ? 95996
Misses ? 21242
Partials ? 472
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15611 to
cloud/1.51Automatically created by backport workflow.