Repository navigation
fix: prevent subscription status flapping during Firebase token rotation - #15078
christian-byrne wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe subscription status flow now coalesces requests for the same UID, starts separate requests after UID changes, and emits authentication-race telemetry through the telemetry registry and ClickHouse provider. ChangesSubscription authentication race handling
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant SubscriptionComposable
participant AuthStore
participant SubscriptionAPI
participant TelemetryRegistry
SubscriptionComposable->>AuthStore: Read currentUser UID
SubscriptionComposable->>SubscriptionAPI: Fetch status for UID
AuthStore-->>SubscriptionComposable: UID changes
SubscriptionComposable->>TelemetryRegistry: Track authentication race
SubscriptionComposable->>SubscriptionAPI: Start separate status request
SubscriptionAPI-->>SubscriptionComposable: Settle both requests
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/platform/telemetry/types.ts (1)
592-593: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove
SUBSCRIPTION_AUTH_RACE_DETECTED.No provider emits this event.
trackSubscriptionAuthRacesendssubscription_auth_raceinstead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/platform/telemetry/types.ts` around lines 592 - 593, Remove the SUBSCRIPTION_AUTH_RACE_DETECTED event constant from the telemetry event definitions in types.ts, leaving trackSubscriptionAuthRace and its existing subscription_auth_race event unchanged.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/cloud/subscription/composables/useSubscription.ts`:
- Around line 329-349: Update fetchSubscriptionStatus and the related
subscription-status state flow to clear or invalidate subscriptionStatus when
the authenticated UID changes, not only when isLoggedIn changes. Track the UID
owning the stored status or watch the current UID directly, ensuring UID A’s
result cannot remain visible while UID B’s request is pending or fails. Add a
regression test covering an active UID A result followed by a UID B switch with
a delayed or failed refresh.
---
Nitpick comments:
In `@src/platform/telemetry/types.ts`:
- Around line 592-593: Remove the SUBSCRIPTION_AUTH_RACE_DETECTED event constant
from the telemetry event definitions in types.ts, leaving
trackSubscriptionAuthRace and its existing subscription_auth_race event
unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 82f5bf6d-48d0-47ae-a6f4-4f72b478af4d
📒 Files selected for processing (5)
src/platform/cloud/subscription/composables/useSubscription.test.tssrc/platform/cloud/subscription/composables/useSubscription.tssrc/platform/telemetry/TelemetryRegistry.tssrc/platform/telemetry/providers/cloud/ClickHouseTelemetryProvider.tssrc/platform/telemetry/types.ts
| async function fetchSubscriptionStatus(): Promise<CloudSubscriptionStatusResponse | null> { | ||
| const currentUid = authStore.currentUser?.uid ?? null | ||
|
|
||
| if (inFlightStatusFetch?.ownerUid === currentUid) { | ||
| return inFlightStatusFetch.promise | ||
| } | ||
|
|
||
| if (inFlightStatusFetch !== null) { | ||
| telemetry?.trackSubscriptionAuthRace?.({ uid_changed: true }) | ||
| } | ||
|
|
||
| const request: InFlightStatusFetch = { | ||
| ownerUid: currentUid, | ||
| promise: performFetchSubscriptionStatus(currentUid).finally(() => { | ||
| if (inFlightStatusFetch === request) { | ||
| inFlightStatusFetch = null | ||
| } | ||
| }) | ||
| } | ||
| inFlightStatusFetch = request | ||
| return request.promise |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Clear status that belongs to the previous user.
When a logged-in user changes from UID A to UID B, subscriptionStatus can still contain UID A's successful result. The watcher does not run because isLoggedIn remains true. If UID B's request fails or is pending, the UI can show UID A's active subscription.
Track the UID that owns subscriptionStatus, or watch the UID directly and clear status on identity change. Add a regression test that first loads an active status for UID A, then switches to UID B and fails or delays UID B's refresh.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/platform/cloud/subscription/composables/useSubscription.ts` around lines
329 - 349, Update fetchSubscriptionStatus and the related subscription-status
state flow to clear or invalidate subscriptionStatus when the authenticated UID
changes, not only when isLoggedIn changes. Track the UID owning the stored
status or watch the current UID directly, ensuring UID A’s result cannot remain
visible while UID B’s request is pending or fails. Add a regression test
covering an active UID A result followed by a UID B switch with a delayed or
failed refresh.
…onStatus Coalesce concurrent fetchSubscriptionStatus calls per user identity so rapid Firebase token refreshes cannot cause subscriptionStatus to flap. - Track ownerUid on in-flight fetches; callers for same UID share one promise - Start a new fetch (and emit trackSubscriptionAuthRace) when UID changes - Emit subscription_auth_race to ClickHouse for alerting on recurrence Fixes FE-1072, Fixes FE-1153
229af1a to
f9a617f
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
🎨 Storybook: ✅ Built🎭 Playwright: ✅ 1806 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 8.71 MB gzip 🔴 +328 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.51 MB (baseline 3.51 MB) • 🔴 +294 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14.1 MB (baseline 14.1 MB) • 🔴 +121 BBundles that do not match a named category
Status: 69 added / 69 removed / 216 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-12T02:25:42.737Z",
"gitSha": "dcb22b5007833c5c3262984f76cb9d722fb15283",
"branch": "fix/fe-1072-subscription-status-flap",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2048.9489999999932,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.871000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.533,
"heapDeltaBytes": 5796636,
"heapUsedBytes": 70078496,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 22.814999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2035.353999999984,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.673999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.83,
"heapDeltaBytes": 5869796,
"heapUsedBytes": 70378372,
"domNodes": 16,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 23.837999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2042.4939999999765,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.531,
"layouts": 12,
"layoutDurationMs": 3.79,
"taskDurationMs": 1049.723,
"heapDeltaBytes": -13369896,
"heapUsedBytes": 51090428,
"domNodes": -276,
"jsHeapTotalBytes": 24092672,
"scriptDurationMs": 131.797,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1853.8520000000176,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.879,
"layouts": 12,
"layoutDurationMs": 3.9099999999999993,
"taskDurationMs": 919.2620000000001,
"heapDeltaBytes": 488224,
"heapUsedBytes": 65048932,
"domNodes": 58,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 124.11099999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1774.5929999999817,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.408,
"layouts": 6,
"layoutDurationMs": 0.6449999999999999,
"taskDurationMs": 374.95700000000005,
"heapDeltaBytes": 8718436,
"heapUsedBytes": 72946980,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 17.681999999999995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.6200000000454,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.422000000000004,
"layouts": 6,
"layoutDurationMs": 0.6410000000000001,
"taskDurationMs": 427.15799999999996,
"heapDeltaBytes": 8561860,
"heapUsedBytes": 72889684,
"domNodes": 78,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 25.586,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 592.8530000000194,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.356,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.995,
"heapDeltaBytes": -11165592,
"heapUsedBytes": 53151540,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 58.231,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 642.089999999996,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.004999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.269,
"heapDeltaBytes": -11390336,
"heapUsedBytes": 53307264,
"domNodes": 22,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 60.37500000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2037.8900000000044,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.189000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 661.254,
"heapDeltaBytes": 7169656,
"heapUsedBytes": 66647200,
"domNodes": -282,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 87.35799999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.1610000000355,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.447,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 832.1379999999998,
"heapDeltaBytes": 6841188,
"heapUsedBytes": 66361596,
"domNodes": -281,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 121.666,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2152.3219999999696,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.419999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1205.9840000000002,
"heapDeltaBytes": 1971260,
"heapUsedBytes": 62473536,
"domNodes": -286,
"jsHeapTotalBytes": 3702784,
"scriptDurationMs": 399.194,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2208.3069999999907,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.169,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1352.241,
"heapDeltaBytes": 19045160,
"heapUsedBytes": 80135440,
"domNodes": -288,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 423.692,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3181.197999999995,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.397,
"layouts": 60,
"layoutDurationMs": 7.769,
"taskDurationMs": 1466.365,
"heapDeltaBytes": -2614868,
"heapUsedBytes": 59329380,
"domNodes": -286,
"jsHeapTotalBytes": 5869568,
"scriptDurationMs": 507.3110000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3329.7690000000557,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.409000000000002,
"layouts": 60,
"layoutDurationMs": 8.81,
"taskDurationMs": 1640.7280000000003,
"heapDeltaBytes": 25439732,
"heapUsedBytes": 87969952,
"domNodes": 10,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 595.114,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.634999999966,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.013000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.111,
"heapDeltaBytes": 6814772,
"heapUsedBytes": 67313684,
"domNodes": -283,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 90.68799999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2057.7369999999746,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.162999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 844.1619999999998,
"heapDeltaBytes": 7223404,
"heapUsedBytes": 68224048,
"domNodes": -287,
"jsHeapTotalBytes": 2461696,
"scriptDurationMs": 125.37099999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.8289999999947,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.353,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.77,
"heapDeltaBytes": -10645060,
"heapUsedBytes": 53832104,
"domNodes": 20,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 121.969,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 640.6970000000456,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.120999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.39099999999996,
"heapDeltaBytes": -10924820,
"heapUsedBytes": 53614284,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 125.84899999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.3199999999792,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.8999999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.948,
"heapDeltaBytes": -17703924,
"heapUsedBytes": 46729104,
"domNodes": -281,
"jsHeapTotalBytes": 23044096,
"scriptDurationMs": 16.06,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.1060000000452,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.328999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.097,
"heapDeltaBytes": 5674876,
"heapUsedBytes": 70207056,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 20.489,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1762.3089999999593,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.917,
"layouts": 16,
"layoutDurationMs": 4.713,
"taskDurationMs": 778.284,
"heapDeltaBytes": -15135636,
"heapUsedBytes": 49271316,
"domNodes": -279,
"jsHeapTotalBytes": 23044096,
"scriptDurationMs": 83.49599999999998,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1783.2560000000512,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.702000000000005,
"layouts": 16,
"layoutDurationMs": 5.332,
"taskDurationMs": 905.993,
"heapDeltaBytes": -17711928,
"heapUsedBytes": 46775404,
"domNodes": -284,
"jsHeapTotalBytes": 23044096,
"scriptDurationMs": 101.691,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1421.241000000009,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.431,
"layouts": 14,
"layoutDurationMs": 11.834999999999999,
"taskDurationMs": 1033.507,
"heapDeltaBytes": 3358240,
"heapUsedBytes": 75074288,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 37.703,
"eventListeners": 2375,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8226.046999999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.174,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4247.334,
"heapDeltaBytes": 9935724,
"heapUsedBytes": 72229608,
"domNodes": -282,
"jsHeapTotalBytes": 7110656,
"scriptDurationMs": 1288.056,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8287.975000000075,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.90100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4823.327,
"heapDeltaBytes": 10591920,
"heapUsedBytes": 71141184,
"domNodes": -285,
"jsHeapTotalBytes": 6062080,
"scriptDurationMs": 1394.0759999999998,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17113.445000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17095.547,
"heapDeltaBytes": -47460620,
"heapUsedBytes": 175339176,
"domNodes": -8312,
"jsHeapTotalBytes": -6492160,
"scriptDurationMs": 508.188,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17965.209999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17949.85,
"heapDeltaBytes": -36353228,
"heapUsedBytes": 166643188,
"domNodes": -8312,
"jsHeapTotalBytes": -13307904,
"scriptDurationMs": 546.0609999999999,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22025.422999999988,
"styleRecalcs": 158,
"styleRecalcDurationMs": 23.865000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22002.142,
"heapDeltaBytes": -48819960,
"heapUsedBytes": 176573240,
"domNodes": -8312,
"jsHeapTotalBytes": -9449472,
"scriptDurationMs": 899.3309999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 605,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22749.993000000017,
"styleRecalcs": 168,
"styleRecalcDurationMs": 26.92599999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22722.534,
"heapDeltaBytes": -32478364,
"heapUsedBytes": 166537700,
"domNodes": -8312,
"jsHeapTotalBytes": -10690560,
"scriptDurationMs": 908.298,
"eventListeners": -16381,
"totalBlockingTimeMs": 698,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 484.67700000003333,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.301999999999996,
"layouts": 3,
"layoutDurationMs": 1.3860000000000001,
"taskDurationMs": 129.97400000000005,
"heapDeltaBytes": 5299564,
"heapUsedBytes": 68794408,
"domNodes": 150,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.757000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 503.41600000001563,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.574,
"layouts": 3,
"layoutDurationMs": 0.709,
"taskDurationMs": 127.59199999999998,
"heapDeltaBytes": 5051888,
"heapUsedBytes": 68624188,
"domNodes": 121,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 13.684,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #15078 +/- ##
==========================================
- Coverage 81.37% 81.37% -0.01%
==========================================
Files 1874 1874
Lines 106527 106540 +13
Branches 32976 32968 -8
==========================================
+ Hits 86685 86692 +7
+ Misses 19501 19497 -4
- Partials 341 351 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Flagging an overlap before anyone picks this up. #15094 fixes a related race in the same code path: This PR targets status flapping during Firebase token rotation. That may be the same underlying problem seen from a different angle, or a genuinely separate one. It's draft and conflicting, so whoever revives it should read #15094 first and decide whether this still has independent value or reduces to a test. Reassigned area ownership: @dante01yoon owns Cloud billing on the frontend now. |
christian-byrne
left a comment
There was a problem hiding this comment.
Address failing CI checks, rebase on main, push and monitor.
|
Thanks for the fix. The original issue was valid, but this PR has since been superseded by #15094, which is already merged into
Jaewon re-ran the focused subscription suite on current |
Summary
Fixes the run button toggling between "Subscribe to Run" and "Run" ~10 times at ~300ms intervals when users switch networks or wake their laptop.
Root cause: Firebase token refresh fires
onIdTokenChangedmultiple times → each firesfetchSubscriptionStatus()with no in-flight guard → concurrent HTTP requests → some get 401 (stale session cookie) →subscriptionStatusflaps.performFetchSubscriptionStatuschecks UID before the network call and again afterresponse.json(), discarding stale responses if the user changed mid-fetchsubscription_auth_raceevent when identity changes between consecutivefetchSubscriptionStatuscalls so we can alert on recurrenceFixes FE-1072, Fixes FE-1153
Red-Green Verification
test: add failing tests for subscription status fetch dedupe and auth-race telemetryfix: add UID-scoped dedupe and auth-race telemetry to fetchSubscriptionStatusTest Plan
coalesces concurrent callers into one fetch— verifies dedupediscards response for stale identity after user switches mid-fetch— verifies abort logicemits trackSubscriptionAuthRace telemetry when identity changes between fetchStatus calls— verifies observability