Repository navigation
refactor(billing): drop the isActiveSubscription alias - #14867
Conversation
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Comment |
🎭 Playwright: ✅ 1897 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.67 MB gzip 🟢 -213 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • 🟢 -459 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.58 MB (baseline 3.58 MB) • 🟢 -134 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 17 added / 17 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • 🔴 +45 BBundles that do not match a named category
Status: 70 added / 70 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T00:10:16.377Z",
"gitSha": "1c0a1766866995384f08a0c533ff7fffc2322486",
"branch": "refactor/drop-isactivesubscription-alias",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.1119999999792,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.508000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.353,
"heapDeltaBytes": -10292176,
"heapUsedBytes": 59334976,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.465999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2000.560000000064,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.1770000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.572,
"heapDeltaBytes": -11962184,
"heapUsedBytes": 57672184,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.890000000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1733.3890000000451,
"styleRecalcs": 73,
"styleRecalcDurationMs": 25.405000000000005,
"layouts": 14,
"layoutDurationMs": 4.139,
"taskDurationMs": 665.588,
"heapDeltaBytes": -8471048,
"heapUsedBytes": 61710036,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 96.38000000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.2360000000172,
"styleRecalcs": 73,
"styleRecalcDurationMs": 20.407,
"layouts": 14,
"layoutDurationMs": 2.7929999999999997,
"taskDurationMs": 573.3059999999999,
"heapDeltaBytes": -10478312,
"heapUsedBytes": 59059492,
"domNodes": -281,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 83.781,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1671.0799999999608,
"styleRecalcs": 33,
"styleRecalcDurationMs": 11.651000000000002,
"layouts": 6,
"layoutDurationMs": 1.0630000000000002,
"taskDurationMs": 252.14400000000003,
"heapDeltaBytes": 4391280,
"heapUsedBytes": 73843080,
"domNodes": 80,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.463,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1688.6969999999337,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.836,
"layouts": 6,
"layoutDurationMs": 1.288,
"taskDurationMs": 282.733,
"heapDeltaBytes": 4418084,
"heapUsedBytes": 74717860,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.394999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 527.573000000018,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.808,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.63800000000003,
"heapDeltaBytes": 17801796,
"heapUsedBytes": 87904156,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 106.324,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 501.0189999999284,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.582000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.833,
"heapDeltaBytes": 17480892,
"heapUsedBytes": 87648792,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 97.928,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.070000000028,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.9839999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.366,
"heapDeltaBytes": 11495968,
"heapUsedBytes": 86872876,
"domNodes": -268,
"jsHeapTotalBytes": -1658880,
"scriptDurationMs": 27.459000000000003,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2045.2020000000175,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.178999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.511,
"heapDeltaBytes": -13489316,
"heapUsedBytes": 86840252,
"domNodes": -262,
"jsHeapTotalBytes": -1622016,
"scriptDurationMs": 26.918000000000003,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2062.240999999972,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.636000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1043.117,
"heapDeltaBytes": 21967576,
"heapUsedBytes": 87694652,
"domNodes": 10,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 488.691,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2067.982999999913,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1025.6080000000002,
"heapDeltaBytes": 22381072,
"heapUsedBytes": 88221260,
"domNodes": -273,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 472.698,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3085.1020000000062,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.05,
"layouts": 60,
"layoutDurationMs": 11.790000000000001,
"taskDurationMs": 1182.3039999999999,
"heapDeltaBytes": 8193536,
"heapUsedBytes": 75496012,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 494.821,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3091.713000000027,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.274999999999999,
"layouts": 60,
"layoutDurationMs": 10.206,
"taskDurationMs": 1116.547,
"heapDeltaBytes": 11744000,
"heapUsedBytes": 79103192,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 468.276,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2131.093999999962,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.626999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1146.1549999999997,
"heapDeltaBytes": 14036676,
"heapUsedBytes": 80777484,
"domNodes": -274,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 523.632,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2095.315000000028,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.5870000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1178.618,
"heapDeltaBytes": 18124544,
"heapUsedBytes": 85555928,
"domNodes": 10,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 538.725,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2002.3239999999305,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.3009999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.69100000000003,
"heapDeltaBytes": 21796096,
"heapUsedBytes": 87640464,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.759000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2004.2949999999564,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.600000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.34000000000003,
"heapDeltaBytes": 11239352,
"heapUsedBytes": 86943620,
"domNodes": -266,
"jsHeapTotalBytes": -1396736,
"scriptDurationMs": 22.626,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 428.74999999997954,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.210999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 267.58400000000006,
"heapDeltaBytes": 14813872,
"heapUsedBytes": 87520260,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 83.65299999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 446.138000000019,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.324999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 259.64699999999993,
"heapDeltaBytes": 14755984,
"heapUsedBytes": 87324180,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 83.152,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.211000000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.153999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.925,
"heapDeltaBytes": -9314004,
"heapUsedBytes": 63351372,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5.979,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.7830000000413,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.478000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.19,
"heapDeltaBytes": -7002580,
"heapUsedBytes": 65706532,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5.371,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.56499999997,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.599,
"layouts": 18,
"layoutDurationMs": 4.7330000000000005,
"taskDurationMs": 629.589,
"heapDeltaBytes": 4090016,
"heapUsedBytes": 76463816,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 73.815,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.9829999999365,
"styleRecalcs": 78,
"styleRecalcDurationMs": 22.317999999999998,
"layouts": 18,
"layoutDurationMs": 3.2079999999999997,
"taskDurationMs": 572.0039999999999,
"heapDeltaBytes": -96492,
"heapUsedBytes": 71793796,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 64.187,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 849.1579999999885,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.108999999999998,
"layouts": 16,
"layoutDurationMs": 9.465000000000002,
"taskDurationMs": 637.3549999999999,
"heapDeltaBytes": -7405892,
"heapUsedBytes": 86465348,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 20.087,
"eventListeners": 2381,
"totalBlockingTimeMs": 89,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8092.845000000011,
"styleRecalcs": 247,
"styleRecalcDurationMs": 25.561000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3703.705,
"heapDeltaBytes": 23188920,
"heapUsedBytes": 88190648,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 1619.741,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8131.909000000064,
"styleRecalcs": 249,
"styleRecalcDurationMs": 24.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3934.232,
"heapDeltaBytes": -13875504,
"heapUsedBytes": 86030636,
"domNodes": -266,
"jsHeapTotalBytes": 4894720,
"scriptDurationMs": 1779.4479999999999,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10543.923000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9553.557999999999,
"heapDeltaBytes": -33315160,
"heapUsedBytes": 182526696,
"domNodes": -6548,
"jsHeapTotalBytes": 5165056,
"scriptDurationMs": 133.363,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10548.264000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9726.341,
"heapDeltaBytes": -22935224,
"heapUsedBytes": 175234928,
"domNodes": -6548,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 148.99,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13609.93700000006,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.591000000000019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12897.524,
"heapDeltaBytes": -14554196,
"heapUsedBytes": 189200516,
"domNodes": -6548,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 667.212,
"eventListeners": -7473,
"totalBlockingTimeMs": 14,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14273.372999999992,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.24600000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13784.105,
"heapDeltaBytes": -18267472,
"heapUsedBytes": 191246488,
"domNodes": -6548,
"jsHeapTotalBytes": 3112960,
"scriptDurationMs": 681.7719999999999,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 3863.3460000000923,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.982999999999976,
"layouts": 20,
"layoutDurationMs": 20.794999999999995,
"taskDurationMs": 3695.2230000000004,
"heapDeltaBytes": -26929652,
"heapUsedBytes": 184059880,
"domNodes": -6548,
"jsHeapTotalBytes": 15347712,
"scriptDurationMs": 59.46499999999999,
"eventListeners": -7475,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4002.92300000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.611,
"layouts": 20,
"layoutDurationMs": 32.40000000000001,
"taskDurationMs": 3924.5260000000003,
"heapDeltaBytes": -34508224,
"heapUsedBytes": 175201236,
"domNodes": -6548,
"jsHeapTotalBytes": 6946816,
"scriptDurationMs": 68.44100000000002,
"eventListeners": -7473,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 425.2920000000131,
"styleRecalcs": 14,
"styleRecalcDurationMs": 12.346999999999998,
"layouts": 2,
"layoutDurationMs": 0.575,
"taskDurationMs": 75.009,
"heapDeltaBytes": 5073056,
"heapUsedBytes": 72954772,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.884,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 441.6320000000269,
"styleRecalcs": 13,
"styleRecalcDurationMs": 12.561,
"layouts": 3,
"layoutDurationMs": 0.8750000000000001,
"taskDurationMs": 77.758,
"heapDeltaBytes": 5055072,
"heapUsedBytes": 73764756,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.891,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #14867 +/- ##
==========================================
+ Coverage 80.41% 82.31% +1.90%
==========================================
Files 2409 2018 -391
Lines 123483 116616 -6867
Branches 30866 31055 +189
==========================================
- Hits 99297 95994 -3303
+ Misses 23743 20447 -3296
+ Partials 443 175 -268
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 398 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Handoff note — moved to @Jaewon under FE-1585. Recommendation: Hold. Pure refactor across 20 files, stacked on #14866 — squarely a FE-1585 non-goal ("broad billing refactors during incident stabilization"). Worth finishing afterwards though. #11464 renamed |
|
Handoff: I'm off the Cloud billing pod, so @dante01yoon owns this now and I've reassigned it to him. Context that isn't obvious from the assignee change alone: this is one of five of my open billing PRs moved to him on 2026-08-13 (#14867, #14866, #14856, #14865, #14477). They're independent of each other and none is urgent. All of them predate the flag-retirement stack merging, so rebase and re-check CI before reviewing rather than trusting the last green run. The two that are not in that set and do need thought first: #14964 has changes requested, and #15078 is draft, conflicting, and overlaps #15094 on subscription-status fetch races. Don't revive #15078 without reading #15094 first. The live one is #15094, a defect that shipped with the retirement stack. That takes priority over anything here. |
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed the live head 5badea7721b1554ec9d5334b96311b78a1735cb2 against stacked base ca3f895a7ed052ae483d6fb1164990dd84b202bb.
The refactor preserves behavior: the removed alias was the same ComputedRef as canAccessSubscriptionFeatures, and every production/test/storybook consumer now reads that source directly. git grep finds no remaining isActiveSubscription references on the PR head. This does not introduce or reconstruct server state, and it adds no handwritten API response types.
Focused validation: 11 affected Vitest files, 261 tests passed; git diff --check passed. The existing unit CI job is red only because Vitest reported an unrelated EnvironmentTeardownError from TabErrors.test.ts after all 1,109 files / 15,211 tests passed. Other applicable checks, including lint, E2E, Storybook, Codecov, and security, passed.
ca3f895 to
be71af4
Compare
5badea7 to
673c158
Compare
|
Restacked on the updated #14866 head and rebased past the flag-retirement merges. Your approval survived the force-push, but the rebase resolved three conflicts by hand, so those are worth a second look:
The one remaining Full unit suite passes locally (1169 files, 16067 tests), typecheck and knip clean. The failing |
|
Conflict cleared. Merged the updated base rather than rebasing, so the One resolution is a behavior decision worth your eye, since it landed after your approval:
(canAccessSubscriptionFeatures.value ||
((billingStatus.value === 'payment_failed' ||
billingStatus.value === 'paused') &&
Boolean(subscription.value?.planSlug))) &&That surfaced a second problem the merge would have hidden. main's four new cancel-plan cases set Control for that claim: with the source condition reverted to the pre-merge expression, Full unit suite green: 1171 files, 16096 tests. lint, typecheck, typecheck:browser, typecheck:website, knip all clean. |
|
Re-approve needed: test-only follow-up after your approval. Full context for agent readersYour approval was at 5badea7; since then the branch merged origin and added d9d6ce4 (test(billing): point cancel-plan cases at the renamed context flag) — a semantic test adjustment, so the approval does not mechanically carry. CI green, mergeable. Fresh approval at head d9d6ce4 unblocks merge. |
Replace the `isActiveSubscription` alias with the canonical `canAccessSubscriptionFeatures` name across all consumers. The alias was added as a transitional shim and is no longer needed. The 3 files whose old-base versions carried the alias but whose main versions were since refactored to use `canTopUp` / `canSubscribeSelfServe` directly (useTopUpUrlLoader.ts, useTopUpUrlLoader.test.ts, useSettingUI.test.ts) do not require the rename and are left at main. Rebased onto main by cheap-drain lane. <!-- authored-by:agent cheap-drain -->
d9d6ce4 to
4f517dc
Compare
|
Both leftover
CI is re-running on the fresh head. Re-requested your review since the prior approval was dismissed on branch update. |
The vi.mock factory still returned the removed isActiveSubscription property instead of the canonical canAccessSubscriptionFeatures name that useSubscription() actually exports after this PR's rename. <!-- authored-by:agent cheap-drain -->
|
Third leftover
The third one was a |
|
CI fix verified —
Verified: 0 remaining CI status at time of comment: 44/84 checks completed, 0 failures. Approver re-requested: @CodeJuggernaut (prior approval dismissed 2026-09-01T11:58Z after update-branch). |
|
Main reintroduced three Full context for agent readersMerged current Local verification:
CI verification completed successfully for website build/E2E/unit, binary size, lint/format, unit tests, Storybook, assets validation including |
cheap-drain lifecycle update — act-fe-14867-cifixStatus: fix complete, CI settling (GitHub Actions queue backlog), enqueue pending re-approval. Evidence
Post-conditionmergeStateStatus CLEAN + APPROVED required for enqueue. Fix is done, CI is effectively green (failures are from stuck/queued infrastructure runs). Enqueue blocked on human re-approval. |
CI status update — all required checks greenReran the flaky Required checks (all green):
STALE-GREEN GUARD: CI completedAt (2026-09-02T00:25Z) > main commit date (2026-09-01T20:47Z). Enqueue blocked on re-approval only. Both @dante01yoon and @CodeJuggernaut were re-requested after update-branch dismissed prior approvals. Once either re-approves, this is ready to enqueue. |
|
@coderabbitai review |
|
dante01yoon
left a comment
There was a problem hiding this comment.
This is the right cleanup and the reasoning in the summary is the part that makes it reviewable: #11464 renamed the value because off Cloud it is forced true, so isActiveSubscription asserts something the value does not mean — and then the alias kept the misleading name live anyway. Two names for one computed is strictly worse than either name alone, because a reader has to discover they are identical before they can trust either.
I verified the pure-rename claim independently rather than relying on the description. The alias was const isActiveSubscription = canAccessSubscriptionFeatures — a direct assignment of the same ComputedRef, not a second computed() — so every call site was already reading one value and no substitution can change behavior. And the migration is complete:
git grep -c isActiveSubscription origin/main -- src/ browser_tests/ → 18 files
git grep -c isActiveSubscription origin/pr-14867 -- src/ browser_tests/ → 0 files
Zero leftovers, including tests, stories and the storybook mock. Collapsing the duplicate keys in useBillingContext's return object and in BillingContextMockState is a real bonus — those were two sources for one value in a mock, which is how stories quietly drift from production.
I also checked the one comment that changed meaning-adjacent text at useBillingContext.ts:180 and it still reads correctly: the point is that isTeamPlan is deliberately not gated on the access flag, because paused and payment_failed force is_active=false exactly when callers still need to know it is a team plan. Renaming the referenced symbol keeps that accurate.
Approving.
CI
Worth knowing before you merge: gh pr checks shows changes, playwright-tests, playwright-tests-chromium-sharded, playwright-video-new-tests and comment-on-pr-start as failing, but the changes job's actual conclusion via the API is cancelled, not failure, and the downstream jobs all report 0s — they never ran. So this is a cancelled run cascading, not a red signal about the diff. It does mean the PR is BLOCKED with no green run behind it; it needs a fresh CI pass before merge, and given this is a rename touching 32 suites I would want that run rather than merging on the local pnpm typecheck / knip / test results alone.
Stacking
Stacked on #14866, which I approved separately just now.
|
Follow-up queued for both remaining review nits. Full context for agent readersProgram row |
## Summary Reflows the Team-plan identity comment to the repository’s 80-column convention, following up on #14867 (comment). ## Changes - **What**: Wraps the existing comment without changing code behavior. ## Review Focus Comment-only change; no runtime behavior changed. ## Evidence - `awk 'length > 80 { exit 1 }'` on the reflowed comment: passed - `git diff --check`: passed <!-- authored-by:agent act-fe-14867-followup -->
Stacked on #14866.
Summary
#11464 renamed
isActiveSubscriptiontocanAccessSubscriptionFeaturesbecause off cloud the value is forcedtrue(useSubscription.ts:48), so the old name asserts something the value does not mean. That rename is what the local-credits P0 was blamed on in review, and it landed — but it kept an alias:re-exported from
useBillingContextand typed as@deprecatedintypes.ts. So both names stayed live and the misleading one remained in use across the workspace composables, settings, storybook mocks and stories. The hazard the rename existed to remove is still present, now with two names for one value.This removes the alias and migrates every remaining reference.
Change
Pure rename. The alias was a direct assignment of the same computed, so every call site already read an identical value; there is no behavioural difference. Also removed were the duplicate object keys the collapse exposed —
useBillingContext's return object, the storybook mock, anduseMembersPanel.test.tseach listed both names pointing at the same source.18 files, +72/-66.
Checks
pnpm typecheckexit 0,pnpm knipexit 0, 687 tests pass across the 32 affected suites.