Repository navigation
refactor(billing): read the top-up deep link gate from billing policy - #14866
christian-byrne wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
📝 WalkthroughWalkthroughThe top-up URL loader now uses ChangesTop-up telemetry gating
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change makes deep-link top-up access use the billing policy gate and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ❌ 1806 passed, 1 failed · 5 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.85 MB gzip 🟢 -78 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.52 MB (baseline 3.52 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • 🔴 +11 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • 🟢 -268 BBundles that do not match a named category
Status: 68 added / 68 removed / 217 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-16T06:27:55.062Z",
"gitSha": "0c18856fde9de9eed6e4a5bc5738ab439767fa1c",
"branch": "fix/single-source-topup-gate",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2061.9080000000167,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.913999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.987,
"heapDeltaBytes": 4928304,
"heapUsedBytes": 69193520,
"domNodes": 14,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 6.010000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2029.6769999999924,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.684999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.18800000000005,
"heapDeltaBytes": 5118304,
"heapUsedBytes": 69818256,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 6.062999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.707999999987,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.487,
"layouts": 12,
"layoutDurationMs": 4.1370000000000005,
"taskDurationMs": 833.893,
"heapDeltaBytes": -186200,
"heapUsedBytes": 64509092,
"domNodes": 59,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 116.282,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1828.1070000000454,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.159,
"layouts": 12,
"layoutDurationMs": 3.508,
"taskDurationMs": 808.093,
"heapDeltaBytes": -78276,
"heapUsedBytes": 64491976,
"domNodes": 58,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 111.68000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1767.2350000000279,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.179,
"layouts": 6,
"layoutDurationMs": 0.5870000000000001,
"taskDurationMs": 364.76599999999996,
"heapDeltaBytes": 7955624,
"heapUsedBytes": 72586772,
"domNodes": 76,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 8.107,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.318999999933,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.136999999999997,
"layouts": 6,
"layoutDurationMs": 0.6849999999999998,
"taskDurationMs": 350.114,
"heapDeltaBytes": 8209432,
"heapUsedBytes": 72969112,
"domNodes": 79,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 8.648000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 577.5560000000723,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.018999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.892,
"heapDeltaBytes": -11115164,
"heapUsedBytes": 53559908,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 56.701,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 575.7859999999937,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.8759999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.522,
"heapDeltaBytes": -10891956,
"heapUsedBytes": 53490860,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 54.42400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2016.2839999999278,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.602000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.34,
"heapDeltaBytes": 12790008,
"heapUsedBytes": 72645084,
"domNodes": -283,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 13.040999999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.8929999999682,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.7459999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.061,
"heapDeltaBytes": 12694984,
"heapUsedBytes": 72241628,
"domNodes": -282,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 12.030000000000003,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2141.0569999999325,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.665000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1121.8010000000002,
"heapDeltaBytes": 10428608,
"heapUsedBytes": 70865648,
"domNodes": -286,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 318.638,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2139.5590000000766,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.631,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1142.215,
"heapDeltaBytes": 1458788,
"heapUsedBytes": 62705688,
"domNodes": -283,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 322.116,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3164.4850000000133,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.929999999999998,
"layouts": 60,
"layoutDurationMs": 6.898,
"taskDurationMs": 1318.772,
"heapDeltaBytes": -3713092,
"heapUsedBytes": 57959216,
"domNodes": -288,
"jsHeapTotalBytes": 2195456,
"scriptDurationMs": 376.61400000000003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3080.489000000057,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.828000000000003,
"layouts": 60,
"layoutDurationMs": 6.989000000000001,
"taskDurationMs": 1260.115,
"heapDeltaBytes": 16477456,
"heapUsedBytes": 79020240,
"domNodes": 10,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 369.262,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2046.1759999999458,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.621000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.915,
"heapDeltaBytes": 12523280,
"heapUsedBytes": 72961828,
"domNodes": -283,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 11.578999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.9860000000035,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.944999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.899,
"heapDeltaBytes": 13164008,
"heapUsedBytes": 73599076,
"domNodes": -283,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 12.034000000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.2529999999524,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.504,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.386,
"heapDeltaBytes": -10534168,
"heapUsedBytes": 54147176,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 120.857,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.8610000000645,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.657,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.244,
"heapDeltaBytes": -10792384,
"heapUsedBytes": 53846384,
"domNodes": 16,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 118.225,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2006.2290000000758,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.391000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.919,
"heapDeltaBytes": 5000348,
"heapUsedBytes": 69640000,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 5.576,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.1019999999653,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.758000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.94300000000004,
"heapDeltaBytes": 5019772,
"heapUsedBytes": 69896292,
"domNodes": 22,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 5.894,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.6330000000244,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.111999999999995,
"layouts": 16,
"layoutDurationMs": 4.475,
"taskDurationMs": 733.456,
"heapDeltaBytes": -4111608,
"heapUsedBytes": 60598912,
"domNodes": 61,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 81.63900000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.1159999999654,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.852999999999994,
"layouts": 16,
"layoutDurationMs": 4.558,
"taskDurationMs": 735.3190000000001,
"heapDeltaBytes": -4093104,
"heapUsedBytes": 60719340,
"domNodes": 62,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 83.005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.5219999999708,
"styleRecalcs": 20,
"styleRecalcDurationMs": 29.441999999999997,
"layouts": 15,
"layoutDurationMs": 12.331999999999999,
"taskDurationMs": 873.979,
"heapDeltaBytes": 20305548,
"heapUsedBytes": 97468892,
"domNodes": 13673,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 14.879000000000003,
"eventListeners": 2375,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8189.043999999967,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3995.0920000000006,
"heapDeltaBytes": 15560504,
"heapUsedBytes": 75829256,
"domNodes": -284,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 1010.923,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8170.238999999924,
"styleRecalcs": 248,
"styleRecalcDurationMs": 33.708,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3944.0750000000003,
"heapDeltaBytes": 3243664,
"heapUsedBytes": 63676220,
"domNodes": -282,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 991.565,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16610.17000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15617.041000000001,
"heapDeltaBytes": -27075424,
"heapUsedBytes": 170924832,
"domNodes": -8312,
"jsHeapTotalBytes": -8593408,
"scriptDurationMs": 102.215,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16715.752000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15624.414999999999,
"heapDeltaBytes": -29422760,
"heapUsedBytes": 167173608,
"domNodes": -8312,
"jsHeapTotalBytes": -10428416,
"scriptDurationMs": 101.10699999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20369.114999999965,
"styleRecalcs": 170,
"styleRecalcDurationMs": 16.10299999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19840.521,
"heapDeltaBytes": -45048604,
"heapUsedBytes": 165339532,
"domNodes": -8312,
"jsHeapTotalBytes": -10428416,
"scriptDurationMs": 394.11400000000003,
"eventListeners": -16381,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20418.625000000022,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.258000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19850.003,
"heapDeltaBytes": -34145508,
"heapUsedBytes": 164132424,
"domNodes": -8312,
"jsHeapTotalBytes": -14360576,
"scriptDurationMs": 416.647,
"eventListeners": -16385,
"totalBlockingTimeMs": 69,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 453.40599999997266,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.732,
"layouts": 3,
"layoutDurationMs": 0.5970000000000001,
"taskDurationMs": 104.78199999999998,
"heapDeltaBytes": 4952008,
"heapUsedBytes": 68579080,
"domNodes": 126,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6.843999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 494.44199999993543,
"styleRecalcs": 16,
"styleRecalcDurationMs": 23.874,
"layouts": 4,
"layoutDurationMs": 1.6119999999999997,
"taskDurationMs": 116.27,
"heapDeltaBytes": 5057088,
"heapUsedBytes": 68541564,
"domNodes": 143,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.407000000000002,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14866 +/- ##
==========================================
+ Coverage 78.87% 81.87% +3.00%
==========================================
Files 2211 1884 -327
Lines 112055 118178 +6123
Branches 31675 35705 +4030
==========================================
+ Hits 88380 96760 +8380
+ Misses 23219 20964 -2255
+ Partials 456 454 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 489 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Handoff note — moved to @Jaewon under FE-1585. Recommendation: Hold until Code Red closes. Correct, but the impact is suppressed deep-link top-up telemetry, not a broken user flow, so it does not meet the FE-1585 bar of "verified customer impact or materially improves regression detection". Context for whoever resumes it: |
|
Handoff: I'm off the Cloud billing pod, so @dante01yoon owns this now and I've reassigned it to him. Context that isn't obvious from the assignee change alone: this is one of five of my open billing PRs moved to him on 2026-08-13 (#14867, #14866, #14856, #14865, #14477). They're independent of each other and none is urgent. All of them predate the flag-retirement stack merging, so rebase and re-check CI before reviewing rather than trusting the last green run. The two that are not in that set and do need thought first: #14964 has changes requested, and #15078 is draft, conflicting, and overlaps #15094 on subscription-status fetch races. Don't revive #15078 without reading #15094 first. The live one is #15094, a defect that shipped with the retirement stack. That takes priority over anything here. |
dante01yoon
left a comment
There was a problem hiding this comment.
The policy-source consolidation is reasonable, but the reported off-Cloud telemetry defect is not reachable through the production entry point. Please either demonstrate a reachable state where the old gate disagrees with topUpAccess and cover it through that entry point, or reframe this as a non-behavioral refactor and remove the impossible regression case.
The loader computed its own gate from isActiveSubscription and isFreeTier under a comment saying it was the negation of showTopUpCreditsDialog's paywall gate. That stopped being true once the dialog moved to billingPolicyCapabilities: the loader has no distribution term, so off cloud it suppressed add_api_credit_button_clicked for deep links that do open the real top-up dialog. Both now read topUpAccess, so they cannot disagree. Fixes #14862
useUrlActionLoaders instantiates and runs useTopUpUrlLoader only when isCloud, so the off-Cloud case the test asserted cannot happen in production. Removing it leaves the change a source-of-truth consolidation: across every reachable Cloud billing policy state the old expression and topUpAccess agree, so there is no runtime behavior to regress against. Addresses review feedback: #14866 (comment)
ca3f895 to
be71af4
Compare
|
Superseded by merged #15804. Close recommended. Full context for agent readersFresh exact-head reclassification at Replaying this branch now conflicts in both changed files. The branch imports Recommended disposition: close #14866 as superseded. Keep #14862 open for its separate residual |
|
Verified: not still wanted. Superseded by merged #15804 (merged 2026-08-26). Author already recommended close on 2026-08-26. The addressing lane should skip the large effort here. The sole human CR thread (dante01yoon, 2026-08-14) is Full context for agent readersVerification evidence for
|
|
PR action: attempted rebase to resolve CONFLICTING mergeStateStatus before addressing dante01yoon's single unresolved (outdated) review thread on Rebase onto Preserving intent (gate telemetry/dialog choice on whatever now determines top-up-vs-paywall) requires understanding the new server-capabilities model, not a mechanical conflict resolve. Rebase aborted, no branch mutation. Resuming at a higher tier with billing-capabilities context. |
|
Superseded by merged #15804; no conflict rebase should be forced. Full context for agent readersCurrent Evidence:
This lane is leaving the branch untouched rather than forcing an obsolete conflict resolution. |
dante01yoon
left a comment
There was a problem hiding this comment.
Thanks for taking the earlier point seriously rather than papering over it. My previous review asked you to either demonstrate a reachable state where the old expression and the policy disagree, or reframe the PR — and you did the second thing properly: the summary now states plainly that the defect is not reachable, says why (useUrlActionLoaders instantiates the loader only when isCloud, pinned by its own test), and the unreachable off-Cloud case is deleted rather than left as a test asserting a state production cannot enter. That is the right outcome. Prior feedback resolved.
I verified the equivalence claim rather than taking it on faith. Walking every Cloud row of getBillingPolicyCapabilities against the old isActiveSubscription && !isFreeTier:
| state | topUpAccess |
old expression |
|---|---|---|
CloudWithoutActiveSubscription |
subscription-required |
false |
CloudTeamWithoutActiveSubscription |
subscription-required |
false |
CloudAndFree |
subscription-required |
false |
CloudAndUnknown |
allowed |
true |
CloudAndStandard / Creator / Pro / Founders / Team |
allowed |
true |
They agree on every reachable row, so "no runtime behavior change" holds. The Local* rows all map to allowed and would diverge, which is exactly why the isCloud pin in the test matters.
The value here is real: showTopUpCreditsDialog and its deep_link telemetry now read one policy instead of two expressions kept in sync by a comment, and that comment had already gone stale once. Approving.
CI
playwright-tests (mobile-chrome) is red, but on vue-nodes-paned-with-touch.png in browser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts — a canvas pan snapshot, nothing this diff touches. The run is also from 2026-08-16. Worth a re-run before merge so the merge is not gated on a stale unrelated snapshot, but I do not read it as a signal about this change.
|
|
||
| // useUrlActionLoaders instantiates this loader only on Cloud, so every case | ||
| // below is a Cloud case. | ||
| vi.mock('@/platform/distribution/types', () => ({ isCloud: true })) |
There was a problem hiding this comment.
suggestion (non-blocking): this replaces the whole module, not just isCloud.
@/platform/distribution/types also exports DISTRIBUTION, isDesktop, and isNightly. With this factory they all become undefined for anything the suite pulls in transitively, so a future import of isDesktop in this call path would silently read falsy instead of failing loudly — and the mock would keep the test green while production disagreed.
Nothing in the current path reads them, so this is fine today. A partial mock keeps it fine later:
vi.mock('@/platform/distribution/types', async (importOriginal) => ({
...(await importOriginal<typeof import('@/platform/distribution/types')>()),
isCloud: true
}))The comment above it is good — it is the reason the pin is correct, and worth keeping either way.
Stacked on Comfy-Org#14866. ## Summary Comfy-Org#11464 renamed `isActiveSubscription` to `canAccessSubscriptionFeatures` because off cloud the value is forced `true` (`useSubscription.ts:48`), so the old name asserts something the value does not mean. That rename is what the local-credits P0 was blamed on in review, and it landed — but it kept an alias: ```ts // Alias kept for backward compatibility; equals canAccessSubscriptionFeatures. const isActiveSubscription = canAccessSubscriptionFeatures ``` re-exported from `useBillingContext` and typed as `@deprecated` in `types.ts`. So both names stayed live and the misleading one remained in use across the workspace composables, settings, storybook mocks and stories. The hazard the rename existed to remove is still present, now with two names for one value. This removes the alias and migrates every remaining reference. ## Change Pure rename. The alias was a direct assignment of the same computed, so every call site already read an identical value; there is no behavioural difference. Also removed were the duplicate object keys the collapse exposed — `useBillingContext`'s return object, the storybook mock, and `useMembersPanel.test.ts` each listed both names pointing at the same source. 20 files, +69/-63. ## Checks `pnpm typecheck` exit 0, `pnpm knip` exit 0, 687 tests pass across the 32 affected suites. - Fixes Comfy-Org#14862 --------- Co-authored-by: christian-byrne <christian-byrne@users.noreply.github.com>
Summary
useTopUpUrlLoadercomputed its own gate for theadd_api_credit_button_clicked/deep_linktelemetry fromisActiveSubscription && !isFreeTier, under a comment claiming it was the negation of the paywall gate inshowTopUpCreditsDialog. That claim went stale when the dialog moved tobillingPolicyCapabilities. Both now readtopUpAccess, so the two cannot drift again.Non-behavioral
This was originally filed as a fix for suppressed off-Cloud telemetry. That defect is not reachable:
useUrlActionLoadersinstantiates and runs this loader only whenisCloud, and itsdoes not instantiate or run any loader off cloudtest pins that. Across every reachable Cloud billing policy state the old expression andtopUpAccessagree, so there is no runtime behavior change to demonstrate.The unreachable off-Cloud regression case has been removed rather than left asserting a state production cannot enter. What remains is the value of the change: one source of truth for who may top up, so a future policy edit lands in both the dialog and its telemetry.