Skip to content

Fix legacy Cloud login route - #15022

Closed
dante01yoon wants to merge 4 commits into
mainfrom
dante/legacy-cloud-login-route
Closed

dante01yoon wants to merge 4 commits into
mainfrom
dante/legacy-cloud-login-route

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Summary

Add a Cloud router compatibility redirect from the legacy /login path to the canonical named cloud-login route while preserving query parameters.

This is the consumer-side companion to #15021, which stops the marketing website from generating new https://cloud.comfy.org/login URLs. This PR keeps existing bookmarks, browser history, emails, documentation, and externally shared legacy links working deterministically.

Root cause

The canonical Cloud login route is /cloud/login, but /login is not registered in the Cloud Vue router.

For logged-out users, the global auth guard previously masked the invalid route by redirecting to cloud-login and preserving the original path as previousFullPath=/login. The Login → Sign Up link preserves that query. After successful signup, the shared post-auth redirect restores previousFullPath, returning the now-authenticated user to unmatched /login. Because authenticated users pass the global guard, the application has no matched component to render and can remain blank or stuck on the loading UI.

This routing bug is independent of IR-105's cached JavaScript 404s. The asset-loading incident made the invalid URL more visible because no client-side routing could execute when the SPA failed to boot, but the signup reproduction exists without the cached 404.

AS IS

legacy /login
  → logged-out auth guard redirects to /cloud/login?previousFullPath=/login
  → user selects Sign Up
  → successful signup restores /login
  → authenticated guard allows the unmatched route
  → blank/loading UI

TO BE

legacy /login?<query>
  → named cloud-login route
  → /cloud/login?<query>

The compatibility redirect runs as route matching, before authentication-state-specific guard behavior can expose the invalid route.

Changes

  • Register /login as a Cloud-only compatibility redirect to the named cloud-login route.
  • Preserve all query parameters, including repeated values.
  • Add focused router coverage verifying the canonical destination, one redirect navigation, and query preservation.

Validation

The implementation was validated in an isolated project checkout before being applied to this branch:

  • Targeted Vitest: 9/9 passed
  • oxfmt check: passed
  • Type-aware Oxlint: 0 warnings, 0 errors
  • ESLint: passed
  • pnpm typecheck: passed
  • git diff --check: passed

Regression risk

Low. The new top-level route is part of cloudOnboardingRoutes, which is only installed for Cloud builds. It affects only the previously unregistered exact path /login; existing /cloud/login behavior is unchanged. Query preservation is covered by the regression test.

Screenshots

Not applicable. This changes URL routing only and does not modify rendered UI.

@dante01yoon
dante01yoon requested a review from a team August 11, 2026 00:57
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 13464b62-56b6-4300-ab2b-61085b37f5ad

📥 Commits

Reviewing files that changed from the base of the PR and between cc24696 and f82f7b8.

📒 Files selected for processing (1)
  • src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts

📝 Walkthrough

Walkthrough

The cloud onboarding router redirects legacy /login requests to the named cloud-login route. Tests verify the destination, guard calls, logged-out state, and repeated query parameters.

Changes

Cloud login redirect

Layer / File(s) Summary
Redirect and validation
src/platform/cloud/onboarding/onboardingCloudRoutes.ts, src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts
The router adds a top-level /login redirect to cloud-login and preserves query parameters. Tests verify the final route, guard calls, logged-out state, and repeated query values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: christian-byrne


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The review context does not provide the PR title or commit subjects, so the required bug-fix signal cannot be verified from metadata only. Provide the PR title and commit subjects to determine whether the end-to-end regression coverage rule applies.
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the problem, solution, scope, validation, regression risk, and screenshot applicability.
Title check ✅ Passed The title clearly and concisely identifies the legacy Cloud login route fix.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are limited to cloud onboarding router source and test files. None are under the specified LiteGraph, ECS, or graph-entity paths.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dante/legacy-cloud-login-route

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/11/2026, 03:33:08 PM UTC

Links

🎭 Playwright: ✅ 1804 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1785 / ❌ 0 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

📦 Bundle: 8.69 MB gzip 🔴 +17 B

Details

Summary

  • Raw size: 36.7 MB baseline 36.7 MB — 🔴 +96 B
  • Gzip: 8.69 MB baseline 8.69 MB — 🔴 +17 B
  • Brotli: 6.06 MB baseline 6.06 MB — 🔴 +5 B
  • Bundles: 436 current • 436 baseline • 1 added / 1 removed

Category Glance
Other 🔴 +96 B (14 MB) · Vendor & Third-Party ⚪ 0 B (16.3 MB) · Data & Services ⚪ 0 B (3.5 MB) · Graph Workspace ⚪ 0 B (1.36 MB) · Panels & Settings ⚪ 0 B (565 kB) · Utilities & Hooks ⚪ 0 B (550 kB) · + 5 more

App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 10 unchanged

Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 B

Reusable component library chunks

Status: 14 unchanged

Data & Services — 3.5 MB (baseline 3.5 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 38 unchanged

Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 17 unchanged

Other — 14 MB (baseline 14 MB) • 🔴 +96 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/onboardingCloudRoutes-CzMm9tts.js (new) — 9.31 kB 🔴 +9.31 kB 🔴 +2.84 kB 🔴 +2.42 kB
assets/onboardingCloudRoutes-BzTp0bqW.js (removed) 9.22 kB — 🟢 -9.22 kB 🟢 -2.82 kB 🟢 -2.42 kB

Status: 1 added / 1 removed / 284 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 124ms TBT · 94.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 160.7 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 793ms TBT · 163.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.5 MB heap

⚠️ 7 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 620ms 553ms -11% ⚠️ z=5.1
canvas-mouse-sweep: layout duration 4ms 4ms +8% ⚠️ z=2.4
canvas-zoom-sweep: task duration 438ms 381ms -13% ⚠️ z=2.4
large-graph-idle: task duration 823ms 693ms -16% ⚠️ z=2.8
large-graph-pan: task duration 1427ms 1290ms -10% ⚠️ z=4.8
minimap-idle: task duration 821ms 723ms -12% ⚠️ z=4.1
subgraph-idle: task duration 563ms 531ms -6% ⚠️ z=5.1
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=0.4
canvas-idle: p95 frame time 17ms 17ms +1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 8ms 8ms -2% z=-2.8
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 8 9 +13% z=-3.8
canvas-idle: task duration 620ms 553ms -11% ⚠️ z=5.1
canvas-idle: script duration 26ms 24ms -5% z=-0.4
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 67.0 MB 67.0 MB +0% —
canvas-idle: DOM nodes 16 18 +13% z=-3.6
canvas-idle: event listeners 4 4 +0% z=-1.6
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=0.2
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 4ms 4ms +8% ⚠️ z=2.4
canvas-mouse-sweep: style recalc duration 44ms 41ms -8% z=-0.7
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 78 75 -4% z=-1.6
canvas-mouse-sweep: task duration 1046ms 964ms -8% z=1.7
canvas-mouse-sweep: script duration 141ms 126ms -11% z=-1.6
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 49.3 MB 48.7 MB -1% —
canvas-mouse-sweep: DOM nodes 3 -286 -9617% z=-134.5
canvas-mouse-sweep: event listeners 4 -152 -3900% z=-38.5
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms +1% —
canvas-zoom-sweep: layout duration 1ms 1ms -10% z=-0.8
canvas-zoom-sweep: style recalc duration 22ms 15ms -30% z=-2.4
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 30 32 +5% z=0.5
canvas-zoom-sweep: task duration 438ms 381ms -13% ⚠️ z=2.4
canvas-zoom-sweep: script duration 28ms 19ms -32% z=-2.8
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 69.8 MB 69.8 MB +0% —
canvas-zoom-sweep: DOM nodes 76 77 +1% z=-2.8
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms -1% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 9ms 8ms -14% z=-2.7
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 11 11 -5% z=-5.2
dom-widget-clipping: task duration 410ms 395ms -4% z=1.9
dom-widget-clipping: script duration 66ms 60ms -10% z=-2.5
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 50.8 MB 50.7 MB -0% —
dom-widget-clipping: DOM nodes 18 17 -6% z=-3.6
dom-widget-clipping: event listeners 2 2 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=0.2
large-graph-idle: p95 frame time 17ms 17ms +1% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 8ms 6ms -21% z=-5.6
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 8 8 +0% z=-11.5
large-graph-idle: task duration 823ms 693ms -16% ⚠️ z=2.8
large-graph-idle: script duration 132ms 103ms -22% z=0.0
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 63.6 MB 64.2 MB +1% —
large-graph-idle: DOM nodes -283 -283 -0% z=-339.9
large-graph-idle: event listeners -149 -148 -1% z=-28.6
large-graph-pan: avg frame time 17ms 17ms -0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms -0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 15ms 18ms +21% z=0.6
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 69 +1% z=-0.9
large-graph-pan: task duration 1427ms 1290ms -10% ⚠️ z=4.8
large-graph-pan: script duration 470ms 417ms -11% z=0.4
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 62.0 MB 61.2 MB -1% —
large-graph-pan: DOM nodes -285 -284 -0% z=-183.7
large-graph-pan: event listeners -149 -149 +0% z=-185.9
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms -0% —
large-graph-zoom: layout duration 8ms 8ms +6% —
large-graph-zoom: style recalc duration 15ms 16ms +8% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 64 65 +2% —
large-graph-zoom: task duration 1710ms 1560ms -9% —
large-graph-zoom: script duration 601ms 543ms -10% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 70.7 MB 70.9 MB +0% —
large-graph-zoom: DOM nodes -289 -138 -52% —
large-graph-zoom: event listeners -151 -73 -52% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms +1% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 7ms 7ms -5% z=-3.3
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 7 8 +14% z=-2.3
minimap-idle: task duration 821ms 723ms -12% ⚠️ z=4.1
minimap-idle: script duration 135ms 107ms -21% z=0.9
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 65.0 MB 64.7 MB -0% —
minimap-idle: DOM nodes -285 -285 +0% z=-222.4
minimap-idle: event listeners -149 -164 +10% z=-255.3
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 12ms 11ms -8% z=-2.2
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 48 +1% z=-0.8
subgraph-dom-widget-clipping: task duration 435ms 412ms -5% z=1.8
subgraph-dom-widget-clipping: script duration 125ms 126ms +0% z=-0.4
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 51.3 MB 51.5 MB +0% —
subgraph-dom-widget-clipping: DOM nodes 20 21 +5% z=-1.1
subgraph-dom-widget-clipping: event listeners 8 8 +0% z=-1.4
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 10ms 9ms -10% z=-2.3
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 9 10 +11% z=-1.4
subgraph-idle: task duration 563ms 531ms -6% ⚠️ z=5.1
subgraph-idle: script duration 21ms 17ms -19% z=-1.1
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 66.8 MB 67.1 MB +0% —
subgraph-idle: DOM nodes 14 20 +43% z=-1.2
subgraph-idle: event listeners 4 4 +0% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% —
subgraph-mouse-sweep: layout duration 5ms 4ms -3% z=-0.9
subgraph-mouse-sweep: style recalc duration 40ms 37ms -6% z=-1.6
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 77 76 -1% z=-2.1
subgraph-mouse-sweep: task duration 814ms 776ms -5% z=0.1
subgraph-mouse-sweep: script duration 98ms 92ms -7% z=-1.4
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 58.2 MB 58.3 MB +0% —
subgraph-mouse-sweep: DOM nodes 63 64 +2% z=-1.3
subgraph-mouse-sweep: event listeners 4 4 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +0% —
subgraph-transition-enter: layout duration 14ms 11ms -18% —
subgraph-transition-enter: style recalc duration 33ms 30ms -8% —
subgraph-transition-enter: layout count 14 14 +0% —
subgraph-transition-enter: style recalc count 18 18 +0% —
subgraph-transition-enter: task duration 1083ms 993ms -8% —
subgraph-transition-enter: script duration 42ms 39ms -9% —
subgraph-transition-enter: TBT 164ms 124ms -24% —
subgraph-transition-enter: heap used 70.8 MB 94.9 MB +34% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2373 2375 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 41ms 45ms +9% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 251 +0% —
viewport-pan-sweep: task duration 5333ms 4746ms -11% —
viewport-pan-sweep: script duration 1717ms 1407ms -18% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 69.5 MB 68.4 MB -2% —
viewport-pan-sweep: DOM nodes -282 -281 -1% —
viewport-pan-sweep: event listeners -131 -132 +1% —
vue-large-graph-idle: avg frame time 18ms 18ms -0% —
vue-large-graph-idle: p95 frame time 17ms 17ms -0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 17936ms 18259ms +2% —
vue-large-graph-idle: script duration 620ms 577ms -7% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 159.2 MB 160.7 MB +1% —
vue-large-graph-idle: DOM nodes -8312 -8312 -0% —
vue-large-graph-idle: event listeners -16389 -16385 -0% —
vue-large-graph-pan: avg frame time 18ms 18ms -0% —
vue-large-graph-pan: p95 frame time 17ms 17ms -0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 21ms 26ms +26% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 149 171 +15% —
vue-large-graph-pan: task duration 21561ms 23224ms +8% —
vue-large-graph-pan: script duration 946ms 949ms +0% —
vue-large-graph-pan: TBT 349ms 793ms +127% —
vue-large-graph-pan: heap used 168.7 MB 163.7 MB -3% —
vue-large-graph-pan: DOM nodes -8312 -8312 +0% —
vue-large-graph-pan: event listeners -16383 -16381 -0% —
workflow-execution: avg frame time 17ms 17ms -0% z=0.1
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 2ms 1ms -46% z=-5.0
workflow-execution: style recalc duration 28ms 17ms -37% z=-3.1
workflow-execution: layout count 4 3 -38% z=-4.5
workflow-execution: style recalc count 12 8 -38% z=-5.0
workflow-execution: task duration 135ms 83ms -39% z=-3.7
workflow-execution: script duration 12ms 5ms -57% z=-8.0
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 65.6 MB 63.5 MB -3% —
workflow-execution: DOM nodes 135 121 -11% z=-5.7
workflow-execution: event listeners 97 37 -62% z=-3.4
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-11T15:43:57.745Z",
  "gitSha": "b4a1d984f310dcd9308c77358f3e90a3498f1cc6",
  "branch": "dante/legacy-cloud-login-route",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2104.3070000000057,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.913000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 562.65,
      "heapDeltaBytes": 5892680,
      "heapUsedBytes": 70279392,
      "domNodes": 18,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 26.348,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.61200000002,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.742,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.842,
      "heapDeltaBytes": 5882272,
      "heapUsedBytes": 70326584,
      "domNodes": 18,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 22.292,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1953.2539999999585,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 38.841,
      "layouts": 12,
      "layoutDurationMs": 4.271000000000001,
      "taskDurationMs": 972.5219999999999,
      "heapDeltaBytes": -12584020,
      "heapUsedBytes": 51957808,
      "domNodes": -288,
      "jsHeapTotalBytes": 23306240,
      "scriptDurationMs": 124.63099999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1887.8290000000106,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 42.18900000000001,
      "layouts": 12,
      "layoutDurationMs": 3.8840000000000003,
      "taskDurationMs": 954.7800000000001,
      "heapDeltaBytes": -14044096,
      "heapUsedBytes": 50245784,
      "domNodes": -283,
      "jsHeapTotalBytes": 24354816,
      "scriptDurationMs": 126.38,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.0169999999607,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.280999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.601,
      "taskDurationMs": 376.67499999999995,
      "heapDeltaBytes": 8859772,
      "heapUsedBytes": 73178508,
      "domNodes": 77,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 18.597,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.6659999999665,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.674000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.611,
      "taskDurationMs": 385.64500000000004,
      "heapDeltaBytes": 8853416,
      "heapUsedBytes": 73297144,
      "domNodes": 77,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 18.819,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 618.7920000000418,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.639000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 384.48099999999994,
      "heapDeltaBytes": -11222700,
      "heapUsedBytes": 53240868,
      "domNodes": 18,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 57.066,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 624.5929999998907,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.859000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.87700000000007,
      "heapDeltaBytes": -11168576,
      "heapUsedBytes": 53139128,
      "domNodes": 16,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 62.32299999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2029.5939999999746,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.8699999999999966,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 688.412,
      "heapDeltaBytes": 7708812,
      "heapUsedBytes": 67768112,
      "domNodes": -281,
      "jsHeapTotalBytes": 3510272,
      "scriptDurationMs": 101.90000000000002,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.2300000000178,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.841,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 698.493,
      "heapDeltaBytes": 7328660,
      "heapUsedBytes": 66841656,
      "domNodes": -284,
      "jsHeapTotalBytes": 3772416,
      "scriptDurationMs": 103.53399999999999,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2164.4469999999956,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.747000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1281.4299999999998,
      "heapDeltaBytes": 5076792,
      "heapUsedBytes": 65527616,
      "domNodes": -285,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 418.611,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2165.059000000042,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 20.754,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1298.772,
      "heapDeltaBytes": 2353792,
      "heapUsedBytes": 62887060,
      "domNodes": -283,
      "jsHeapTotalBytes": 4227072,
      "scriptDurationMs": 414.746,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3247.3850000000084,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 16.199,
      "layouts": 60,
      "layoutDurationMs": 8.241999999999999,
      "taskDurationMs": 1584.2969999999998,
      "heapDeltaBytes": 951504,
      "heapUsedBytes": 63152608,
      "domNodes": -287,
      "jsHeapTotalBytes": 6131712,
      "scriptDurationMs": 546.346,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3194.8190000000523,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 16.712,
      "layouts": 60,
      "layoutDurationMs": 8.53,
      "taskDurationMs": 1534.716,
      "heapDeltaBytes": 23293812,
      "heapUsedBytes": 85556364,
      "domNodes": 12,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 539.485,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2040.6710000000317,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.6610000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 765.1860000000001,
      "heapDeltaBytes": 7223856,
      "heapUsedBytes": 68196296,
      "domNodes": -285,
      "jsHeapTotalBytes": 3510272,
      "scriptDurationMs": 116.865,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.2770000000028,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.024000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 679.8490000000002,
      "heapDeltaBytes": 6921740,
      "heapUsedBytes": 67578992,
      "domNodes": -285,
      "jsHeapTotalBytes": 2985984,
      "scriptDurationMs": 96.409,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 613.4429999999611,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.328000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.95,
      "heapDeltaBytes": -10410332,
      "heapUsedBytes": 54091748,
      "domNodes": 22,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 128.644,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 624.6709999999212,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.16700000000003,
      "heapDeltaBytes": -10674252,
      "heapUsedBytes": 53929412,
      "domNodes": 20,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 122.877,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2011.5059999999971,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.305000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 517.436,
      "heapDeltaBytes": 5854704,
      "heapUsedBytes": 70356652,
      "domNodes": 20,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 15.935,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2019.4270000000643,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.847999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.7760000000001,
      "heapDeltaBytes": 5888788,
      "heapUsedBytes": 70440940,
      "domNodes": 20,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 18.853999999999996,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.2410000000004,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.679,
      "layouts": 16,
      "layoutDurationMs": 4.103,
      "taskDurationMs": 766.2959999999999,
      "heapDeltaBytes": -3385848,
      "heapUsedBytes": 61010864,
      "domNodes": 64,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 92.673,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.4259999999313,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 39.919999999999995,
      "layouts": 16,
      "layoutDurationMs": 4.684000000000001,
      "taskDurationMs": 786.3359999999999,
      "heapDeltaBytes": -3333864,
      "heapUsedBytes": 61229508,
      "domNodes": 64,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 90.798,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.3679999999868,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.145000000000007,
      "layouts": 14,
      "layoutDurationMs": 11.381000000000002,
      "taskDurationMs": 993.3280000000002,
      "heapDeltaBytes": 31102832,
      "heapUsedBytes": 99507832,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15204352,
      "scriptDurationMs": 38.638000000000005,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 124,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8434.741999999971,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 44.91,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4753.261,
      "heapDeltaBytes": 11822612,
      "heapUsedBytes": 71275088,
      "domNodes": -278,
      "jsHeapTotalBytes": 5537792,
      "scriptDurationMs": 1394.075,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8397.29299999999,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 44.498000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4738.251,
      "heapDeltaBytes": 12349356,
      "heapUsedBytes": 72091552,
      "domNodes": -283,
      "jsHeapTotalBytes": 5537792,
      "scriptDurationMs": 1418.972,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18495.503999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18463.700000000004,
      "heapDeltaBytes": -55985472,
      "heapUsedBytes": 171215540,
      "domNodes": -8312,
      "jsHeapTotalBytes": -7806976,
      "scriptDurationMs": 605.71,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18077.40100000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18054.387,
      "heapDeltaBytes": -62741008,
      "heapUsedBytes": 165767432,
      "domNodes": -8311,
      "jsHeapTotalBytes": -10166272,
      "scriptDurationMs": 548.602,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24076.99100000002,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 29.841000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24022.96,
      "heapDeltaBytes": -40611968,
      "heapUsedBytes": 166744332,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10919936,
      "scriptDurationMs": 981.261,
      "eventListeners": -16379,
      "totalBlockingTimeMs": 1027,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000004366
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22461.33199999997,
      "styleRecalcs": 161,
      "styleRecalcDurationMs": 22.965999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22424.938000000002,
      "heapDeltaBytes": -52159980,
      "heapUsedBytes": 176606208,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9973760,
      "scriptDurationMs": 917.414,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 559,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 121.70300000002499,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 17.984,
      "layouts": 2,
      "layoutDurationMs": 0.5299999999999999,
      "taskDurationMs": 86.501,
      "heapDeltaBytes": 3172580,
      "heapUsedBytes": 66570860,
      "domNodes": 114,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 6.519,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 119.81100000002698,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 16.98,
      "layouts": 3,
      "layoutDurationMs": 1.119,
      "taskDurationMs": 79.49800000000002,
      "heapDeltaBytes": 2915388,
      "heapUsedBytes": 66648380,
      "domNodes": 127,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 4.2330000000000005,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

coderabbitai[bot]
coderabbitai Bot previously requested changes Aug 11, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts`:
- Around line 57-66: Update the router setup in the test around createRouter to
use the production cloud-login route record from cloudOnboardingRoutes instead
of the synthetic route object. Preserve legacyLoginRoute and the existing memory
history, and ensure the test exercises the production named route at
/cloud/login.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fa11f15c-a923-4fbb-96ba-9282235c2801

📥 Commits

Reviewing files that changed from the base of the PR and between fec0fe2 and 9f2d1d7.

📒 Files selected for processing (2)
  • src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts
  • src/platform/cloud/onboarding/onboardingCloudRoutes.ts

@codecov

codecov Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #15022      +/-   ##
==========================================
+ Coverage   80.79%   80.81%   +0.01%     
==========================================
  Files        1872     1873       +1     
  Lines      121619   122094     +475     
  Branches    37546    37223     -323     
==========================================
+ Hits        98268    98674     +406     
- Misses      22812    22869      +57     
- Partials      539      551      +12     
Flag Coverage Δ
unit 72.54% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...platform/cloud/onboarding/onboardingCloudRoutes.ts 50.00% <100.00%> (+18.57%) ⬆️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

deepme987
deepme987 previously approved these changes Aug 11, 2026
@dante01yoon
dante01yoon dismissed coderabbitai[bot]’s stale review August 11, 2026 02:11

Addressed in 0715d38 and confirmed by CodeRabbit in the review thread.

coderabbitai[bot]
coderabbitai Bot previously requested changes Aug 11, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts`:
- Around line 73-76: Update the registered cloud-login route setup in
onboardingCloudRoutes.test.ts to preserve the production beforeEnter guard
instead of overriding it with undefined. Ensure the test navigates through the
unmodified route and verifies observable guard execution and the resulting route
behavior, mocking only project-owned authentication dependencies as needed.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 07916de4-8f67-4739-880e-4f8a3f66f6b0

📥 Commits

Reviewing files that changed from the base of the PR and between 9f2d1d7 and 0715d38.

📒 Files selected for processing (1)
  • src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm. I think there's a better way to exactly mirror the bug repro in the test. The test is also failing.

@dante01yoon
dante01yoon dismissed coderabbitai[bot]’s stale review August 11, 2026 15:31

Addressed by f82f7b8: the production cloud-login guard is preserved and its auth dependency execution is asserted.

@mattmillerai

mattmillerai commented Aug 11, 2026 •

Copy link
Copy Markdown
Member

Heads up that we collided on this one. #15026 registers the same /login to cloud-login redirect, and neither PR referenced the other, so I don't think either of us knew the other existed. You opened yours about 36 minutes earlier, and your root-cause writeup (auth guard masking the unregistered route, previousFullPath carrying /login through the Login to Sign Up hop) is the more complete diagnosis of the two. That was written while the page was still hanging in production.

I'm planning to land #15026 rather than this one, for two fairly narrow reasons:

  1. It preserves the fragment as well as the query: redirect: (to) => ({ name: 'cloud-login', query: to.query, hash: to.hash }). Since this is a client-side router redirect rather than an HTTP one, the browser won't reattach the hash for us. Unlikely to matter for /login in practice, but it's free.
  2. It's already approved with CI green, and it asserts that /cloud/login still resolves without a redirect loop. That path is currently being held up outside the application rather than inside it, and I'd like the in-app fix to be the thing carrying it.

For transparency: #15026 was agent-coded (it carries the agent-coded label). That's the collision. An agent picked up the work while you were already on it. Queueing the work before checking open PRs is on our side, not yours.

One thing your version tests that mine doesn't: array-valued query params surviving the redirect (campaign=one&campaign=two). to.query passes those through natively in both implementations so it isn't a behavior gap, but it's a good assertion and I'd rather not lose it. Very happy for you to push it onto #15026, or I can port it with attribution, whichever you prefer.

Leaving this open for you to close (or to push back on, if you think yours should be the one that lands, genuinely fine by me, it's a four-line route record and you got there first).

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Thanks for catching the collision and for the detailed comparison. I agree that #15026 should be the one that lands: preserving the hash and explicitly asserting that /cloud/login does not loop are useful improvements, and avoiding two competing implementations is the better outcome. Please port the array-valued query assertion (campaign=one&campaign=two) to #15026 with attribution so that coverage is not lost. I will leave #15022 open only until #15026 lands, then close it as superseded.

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Closing this as superseded by #15026, which has now merged the legacy /login redirect with query and hash preservation plus direct /cloud/login no-loop coverage.

The repeated query-parameter regression assertion from this PR was intentionally preserved in the focused follow-up #15054. Thanks @mattmillerai for catching the collision and coordinating the handoff.

@mattmillerai

Copy link
Copy Markdown
Member

Correction, and it matters because you deferred partly on the strength of it.

I said #15026 was preferable because it preserved the fragment and yours did not. That was wrong. vue-router carries both query and hash across a redirect on its own, so query: to.query and query: to.query, hash: to.hash behave identically here. Your version preserved the fragment too.

I found this while porting your test case. Stripping the passthrough out of the merged route record entirely, down to redirect: () => ({ name: 'cloud-login' }), leaves all fifteen tests passing. The explicit form restates the router's default rather than providing it.

So the honest scorecard on the two PRs is narrower than I made it out to be. #15026 landed because it was already approved with CI green and because it asserted the no-loop case, not because of any behavioural difference in the redirect. On the redirect itself the two were equivalent, and you had it first.

Your test case is now in #15058 along with guard coverage, credited to you in the commit. One thing worth flagging from your side of the comparison: your test drove the real beforeEnter on cloud-login, and the merged tests did not, because the helper there aborts navigation in a global guard before any per-route guard runs. You were testing something the merged version wasn't. #15058 fixes that, and the approach follows yours.

Also worth recording that your case earns its place for a different reason than I first gave. It doesn't catch a dropped query, since the router handles that. It catches someone replacing the redirect with a hand-built query, which flattens repeated keys. Substituting query: { only: 'this' } fails it immediately, so it's a real guard, just a narrower one than the name suggests.

pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Aug 12, 2026
## Summary

Ports the repeated-query regression coverage identified in superseded PR
Comfy-Org#15022 after Comfy-Org#15026 merged the legacy `/login` redirect. Original
coverage and test approach are attributed to Comfy-Org#15022 / @dante01yoon.

## Changes

- **What**: Extend the existing real-router redirect test to verify
`/login?campaign=one&campaign=two` reaches `cloud-login` with
`query.campaign` equal to `['one', 'two']`.

## Review Focus

Confirm the assertion covers Vue Router's repeated-query parsing while
retaining the existing query, hash, and no-loop coverage.

## Validation

- `pnpm test:unit
src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts` — 11 tests
passed
- `pnpm exec oxfmt --check
src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts` — passed
- `git diff --check origin/main...HEAD` — passed
- Commit hooks: typecheck, Oxlint, ESLint, and formatting passed; push
hook Knip passed

## Screenshots (if applicable)

Not applicable; this PR is test-only.

Co-authored-by: Amp <amp@ampcode.com>
christian-byrne added a commit that referenced this pull request Aug 13, 2026
…outes (IR-105) (#15063)

## Summary

Two durable fixes for the IR-105 splash-screen hang incident.

### Fix 1 — Bootstrap auth wait timeout (`bootstrapStore.ts`)

**Root cause:** `until(isInitialized).toBe(true)` and
`until(isAuthenticated).toBe(true)` in `startStoreBootstrap` have no
timeout. A stale Firebase session or broken auth response hangs
bootstrap silently and indefinitely — no error, no log, just a forever
splash screen.

**Fix:** Extract `waitForCloudAuth()` with:
- 16 s timeout (matching `router.ts:176` and `WorkspaceAuthGate.vue:78`
— existing convention)
- One retry after 3 s backoff
- On second timeout: `captureException` to Sentry + **continue
bootstrap** rather than blocking

This means the worst case is now 35 s to a usable (logged-out) state
instead of infinity.

### Fix 2 — Catch-all route for unknown paths (`router.ts`)

**Root cause:** A request to e.g. `cloud.comfy.org/woiadawd` gets a 200
+ app shell from the static host, Vue boots, finds **no matching
route**, and the global auth guard's `until(isInitialized)` then hangs
(see Fix 1). Even with Fix 1, a no-match route leaves the app on the
splash screen.

**Fix:** Add `{ path: '/:pathMatch(.*)*', redirect: '/' }` at the end of
the route list. Unknown paths redirect to root; the global auth guard
then sends unauthenticated users to `/cloud/login` as normal.

## Red-Green Verification

| Commit | Purpose |
|--------|---------|
| `test: add failing tests for unbounded auth wait in
startStoreBootstrap` | 🔴 Proves test catches the bug — the
"gives up" test times out in 5 s against the unpatched code |
| `fix: bound auth wait in startStoreBootstrap and add catch-all route`
| 🟢 Both new tests pass, all 18 tests in the two affected
files pass |

## Relation to open PRs

- Supersedes / closes the scope of #15032
(`fix/bootstrap-auth-wait-timeout`) — same fix, same tests. If reviewers
prefer to land #15032 first this PR can drop Fix 1.
- Companion to #15022 (marketing-site redirect) and #15026 (`/login` →
`cloud-login` route, already on main).

## Test Plan

- [x] `pnpm vitest run src/stores/bootstrapStore.test.ts` — 7/7 pass
(including 2 new timeout tests)
- [x] `pnpm vitest run
src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts` — 11/11
pass
- [x] `pnpm typecheck` — clean
- [x] `pnpm exec eslint src/stores/bootstrapStore.ts src/router.ts` —
clean
- [ ] CI green (Playwright, Storybook, Codecov)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: GitHub Action <action@github.com>
christian-byrne pushed a commit to balpreetgrowthnatives/ComfyUI_frontend that referenced this pull request Aug 16, 2026
…n guard (Comfy-Org#15058)

## Summary

Follow-up test coverage for the legacy `/login` redirect landed in
Comfy-Org#15026, driving the redirect through the real `cloud-login` guard
instead of stopping at route resolution.

## Changes

- **What**: adds `completeNavigation`, a helper that runs navigation to
completion against the real route table with view components swapped for
render-null stubs, so names, paths, meta, redirects and `beforeEnter`
all stay intact. Covers three journeys through `/login`: signed-out
lands on the login view, signed-in is forwarded past it, and
`switchAccount` leaves the guard inert. Also ports the
repeated-query-key case from the parallel fix in Comfy-Org#15022, contributed by
@dante01yoon.
- **Breaking**: none. Test-only change, no production code touched.

## Review Focus

The existing `attemptNavigation` helper aborts in a global `beforeEach`,
which is what keeps it cheap, but it means navigation never reaches a
per-route `beforeEnter`. Every redirect assertion we had stopped one
step short of the destination actually being entered. The reported
failure was someone completing that journey, so the untested step was
the interesting one.

Worth knowing for anyone reading the route record: vue-router carries
query and hash across a redirect by default. The explicit `query:
to.query, hash: to.hash` in the record restates the default rather than
providing it. I verified this by mutation, stripping the passthrough
entirely leaves every existing assertion passing. I have deliberately
left the code as-is, since it is harmless and reads as intent, but it
should not be mistaken for load-bearing.

That does mean the query assertions are narrower than they look. What
they genuinely catch is someone replacing the redirect with a hand-built
query, which flattens repeated keys. Substituting an explicit `query: {
only: 'this' }` fails three of these tests immediately, so the guard is
real, just narrower than "preserves the query" suggests.

Mutation results for the whole file, since tests that cannot fail are
decoration:

| Mutation | Result |
|---|---|
| Delete the `/login` record | 6 tests fail |
| Strip explicit `query`/`hash` from the redirect | 15 pass (vue-router
default) |
| Replace with an explicit overriding query | 3 tests fail |

## ELI5

Opening `cloud.comfy.org/login` used to hang forever, because the app
had no `/login` page registered and just sat there looking for one. That
was fixed by pointing `/login` at the real sign-in page.

The tests that shipped with that fix checked that the signpost points
the right way. They did not check that you can actually walk through the
door it points at, because they stopped the moment the direction was
known. The original bug was someone walking through the door, so this
adds tests that make the whole trip.

There are three trips worth making: a logged-out visitor should arrive
at the sign-in page, a logged-in visitor should be sent onward rather
than asked to sign in again, and someone deliberately switching accounts
should be left alone at the sign-in page even though they are already
logged in. All three now have tests.

While writing them I checked whether the tests could actually fail, by
deliberately breaking the redirect in three different ways and
confirming the right tests complained each time. One of those
experiments turned up something worth recording: part of the original
fix is redundant, because the router already does that work by default.
It is harmless and I have left it alone, but the note above means the
next person will not assume it is doing something it is not.

---------

Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants