Repository navigation
Fix legacy Cloud login route - #15022
dante01yoon wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe cloud onboarding router redirects legacy ChangesCloud login redirect
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1804 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 8.69 MB gzip 🔴 +17 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.5 MB (baseline 3.5 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14 MB (baseline 14 MB) • 🔴 +96 BBundles that do not match a named category
Status: 1 added / 1 removed / 284 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-11T15:43:57.745Z",
"gitSha": "b4a1d984f310dcd9308c77358f3e90a3498f1cc6",
"branch": "dante/legacy-cloud-login-route",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2104.3070000000057,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.913000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.65,
"heapDeltaBytes": 5892680,
"heapUsedBytes": 70279392,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 26.348,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2054.61200000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.742,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.842,
"heapDeltaBytes": 5882272,
"heapUsedBytes": 70326584,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 22.292,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1953.2539999999585,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.841,
"layouts": 12,
"layoutDurationMs": 4.271000000000001,
"taskDurationMs": 972.5219999999999,
"heapDeltaBytes": -12584020,
"heapUsedBytes": 51957808,
"domNodes": -288,
"jsHeapTotalBytes": 23306240,
"scriptDurationMs": 124.63099999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1887.8290000000106,
"styleRecalcs": 75,
"styleRecalcDurationMs": 42.18900000000001,
"layouts": 12,
"layoutDurationMs": 3.8840000000000003,
"taskDurationMs": 954.7800000000001,
"heapDeltaBytes": -14044096,
"heapUsedBytes": 50245784,
"domNodes": -283,
"jsHeapTotalBytes": 24354816,
"scriptDurationMs": 126.38,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.0169999999607,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.280999999999999,
"layouts": 6,
"layoutDurationMs": 0.601,
"taskDurationMs": 376.67499999999995,
"heapDeltaBytes": 8859772,
"heapUsedBytes": 73178508,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 18.597,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.6659999999665,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.674000000000001,
"layouts": 6,
"layoutDurationMs": 0.611,
"taskDurationMs": 385.64500000000004,
"heapDeltaBytes": 8853416,
"heapUsedBytes": 73297144,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 18.819,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 618.7920000000418,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.639000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.48099999999994,
"heapDeltaBytes": -11222700,
"heapUsedBytes": 53240868,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 57.066,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 624.5929999998907,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.859000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.87700000000007,
"heapDeltaBytes": -11168576,
"heapUsedBytes": 53139128,
"domNodes": 16,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 62.32299999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.5939999999746,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.8699999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.412,
"heapDeltaBytes": 7708812,
"heapUsedBytes": 67768112,
"domNodes": -281,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 101.90000000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.2300000000178,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.841,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.493,
"heapDeltaBytes": 7328660,
"heapUsedBytes": 66841656,
"domNodes": -284,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 103.53399999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2164.4469999999956,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.747000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1281.4299999999998,
"heapDeltaBytes": 5076792,
"heapUsedBytes": 65527616,
"domNodes": -285,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 418.611,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2165.059000000042,
"styleRecalcs": 70,
"styleRecalcDurationMs": 20.754,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1298.772,
"heapDeltaBytes": 2353792,
"heapUsedBytes": 62887060,
"domNodes": -283,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 414.746,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3247.3850000000084,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.199,
"layouts": 60,
"layoutDurationMs": 8.241999999999999,
"taskDurationMs": 1584.2969999999998,
"heapDeltaBytes": 951504,
"heapUsedBytes": 63152608,
"domNodes": -287,
"jsHeapTotalBytes": 6131712,
"scriptDurationMs": 546.346,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3194.8190000000523,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.712,
"layouts": 60,
"layoutDurationMs": 8.53,
"taskDurationMs": 1534.716,
"heapDeltaBytes": 23293812,
"heapUsedBytes": 85556364,
"domNodes": 12,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 539.485,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2040.6710000000317,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.6610000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 765.1860000000001,
"heapDeltaBytes": 7223856,
"heapUsedBytes": 68196296,
"domNodes": -285,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 116.865,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.2770000000028,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.024000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.8490000000002,
"heapDeltaBytes": 6921740,
"heapUsedBytes": 67578992,
"domNodes": -285,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 96.409,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.4429999999611,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.328000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.95,
"heapDeltaBytes": -10410332,
"heapUsedBytes": 54091748,
"domNodes": 22,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 128.644,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.6709999999212,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.16700000000003,
"heapDeltaBytes": -10674252,
"heapUsedBytes": 53929412,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 122.877,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.5059999999971,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.305000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.436,
"heapDeltaBytes": 5854704,
"heapUsedBytes": 70356652,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 15.935,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.4270000000643,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.847999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.7760000000001,
"heapDeltaBytes": 5888788,
"heapUsedBytes": 70440940,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 18.853999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.2410000000004,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.679,
"layouts": 16,
"layoutDurationMs": 4.103,
"taskDurationMs": 766.2959999999999,
"heapDeltaBytes": -3385848,
"heapUsedBytes": 61010864,
"domNodes": 64,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 92.673,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.4259999999313,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.919999999999995,
"layouts": 16,
"layoutDurationMs": 4.684000000000001,
"taskDurationMs": 786.3359999999999,
"heapDeltaBytes": -3333864,
"heapUsedBytes": 61229508,
"domNodes": 64,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 90.798,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.3679999999868,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.145000000000007,
"layouts": 14,
"layoutDurationMs": 11.381000000000002,
"taskDurationMs": 993.3280000000002,
"heapDeltaBytes": 31102832,
"heapUsedBytes": 99507832,
"domNodes": 13673,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 38.638000000000005,
"eventListeners": 2375,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8434.741999999971,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.91,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4753.261,
"heapDeltaBytes": 11822612,
"heapUsedBytes": 71275088,
"domNodes": -278,
"jsHeapTotalBytes": 5537792,
"scriptDurationMs": 1394.075,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8397.29299999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 44.498000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4738.251,
"heapDeltaBytes": 12349356,
"heapUsedBytes": 72091552,
"domNodes": -283,
"jsHeapTotalBytes": 5537792,
"scriptDurationMs": 1418.972,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18495.503999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18463.700000000004,
"heapDeltaBytes": -55985472,
"heapUsedBytes": 171215540,
"domNodes": -8312,
"jsHeapTotalBytes": -7806976,
"scriptDurationMs": 605.71,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18077.40100000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18054.387,
"heapDeltaBytes": -62741008,
"heapUsedBytes": 165767432,
"domNodes": -8311,
"jsHeapTotalBytes": -10166272,
"scriptDurationMs": 548.602,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 24076.99100000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 29.841000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24022.96,
"heapDeltaBytes": -40611968,
"heapUsedBytes": 166744332,
"domNodes": -8312,
"jsHeapTotalBytes": -10919936,
"scriptDurationMs": 981.261,
"eventListeners": -16379,
"totalBlockingTimeMs": 1027,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 22461.33199999997,
"styleRecalcs": 161,
"styleRecalcDurationMs": 22.965999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22424.938000000002,
"heapDeltaBytes": -52159980,
"heapUsedBytes": 176606208,
"domNodes": -8312,
"jsHeapTotalBytes": -9973760,
"scriptDurationMs": 917.414,
"eventListeners": -16383,
"totalBlockingTimeMs": 559,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 121.70300000002499,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.984,
"layouts": 2,
"layoutDurationMs": 0.5299999999999999,
"taskDurationMs": 86.501,
"heapDeltaBytes": 3172580,
"heapUsedBytes": 66570860,
"domNodes": 114,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 6.519,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 119.81100000002698,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.98,
"layouts": 3,
"layoutDurationMs": 1.119,
"taskDurationMs": 79.49800000000002,
"heapDeltaBytes": 2915388,
"heapUsedBytes": 66648380,
"domNodes": 127,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 4.2330000000000005,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts`:
- Around line 57-66: Update the router setup in the test around createRouter to
use the production cloud-login route record from cloudOnboardingRoutes instead
of the synthetic route object. Preserve legacyLoginRoute and the existing memory
history, and ensure the test exercises the production named route at
/cloud/login.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: fa11f15c-a923-4fbb-96ba-9282235c2801
📒 Files selected for processing (2)
src/platform/cloud/onboarding/onboardingCloudRoutes.test.tssrc/platform/cloud/onboarding/onboardingCloudRoutes.ts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15022 +/- ##
==========================================
+ Coverage 80.79% 80.81% +0.01%
==========================================
Files 1872 1873 +1
Lines 121619 122094 +475
Branches 37546 37223 -323
==========================================
+ Hits 98268 98674 +406
- Misses 22812 22869 +57
- Partials 539 551 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Amp-Thread-ID: https://ampcode.com/threads/T-019fee3a-1afc-7464-a79f-2017006f4ffd Co-authored-by: Amp <amp@ampcode.com>
Addressed in 0715d38 and confirmed by CodeRabbit in the review thread.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts`:
- Around line 73-76: Update the registered cloud-login route setup in
onboardingCloudRoutes.test.ts to preserve the production beforeEnter guard
instead of overriding it with undefined. Ensure the test navigates through the
unmodified route and verifies observable guard execution and the resulting route
behavior, mocking only project-owned authentication dependencies as needed.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 07916de4-8f67-4739-880e-4f8a3f66f6b0
📒 Files selected for processing (1)
src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts
christian-byrne
left a comment
There was a problem hiding this comment.
This lgtm. I think there's a better way to exactly mirror the bug repro in the test. The test is also failing.
Amp-Thread-ID: https://ampcode.com/threads/T-019fee3a-1afc-7464-a79f-2017006f4ffd Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fee3a-1afc-7464-a79f-2017006f4ffd Co-authored-by: Amp <amp@ampcode.com>
Addressed by f82f7b8: the production cloud-login guard is preserved and its auth dependency execution is asserted.
|
Heads up that we collided on this one. #15026 registers the same I'm planning to land #15026 rather than this one, for two fairly narrow reasons:
For transparency: #15026 was agent-coded (it carries the One thing your version tests that mine doesn't: array-valued query params surviving the redirect ( Leaving this open for you to close (or to push back on, if you think yours should be the one that lands, genuinely fine by me, it's a four-line route record and you got there first). |
|
Thanks for catching the collision and for the detailed comparison. I agree that #15026 should be the one that lands: preserving the hash and explicitly asserting that |
|
Closing this as superseded by #15026, which has now merged the legacy The repeated query-parameter regression assertion from this PR was intentionally preserved in the focused follow-up #15054. Thanks @mattmillerai for catching the collision and coordinating the handoff. |
|
Correction, and it matters because you deferred partly on the strength of it. I said #15026 was preferable because it preserved the fragment and yours did not. That was wrong. vue-router carries both query and hash across a redirect on its own, so I found this while porting your test case. Stripping the passthrough out of the merged route record entirely, down to So the honest scorecard on the two PRs is narrower than I made it out to be. #15026 landed because it was already approved with CI green and because it asserted the no-loop case, not because of any behavioural difference in the redirect. On the redirect itself the two were equivalent, and you had it first. Your test case is now in #15058 along with guard coverage, credited to you in the commit. One thing worth flagging from your side of the comparison: your test drove the real Also worth recording that your case earns its place for a different reason than I first gave. It doesn't catch a dropped query, since the router handles that. It catches someone replacing the redirect with a hand-built query, which flattens repeated keys. Substituting |
## Summary Ports the repeated-query regression coverage identified in superseded PR Comfy-Org#15022 after Comfy-Org#15026 merged the legacy `/login` redirect. Original coverage and test approach are attributed to Comfy-Org#15022 / @dante01yoon. ## Changes - **What**: Extend the existing real-router redirect test to verify `/login?campaign=one&campaign=two` reaches `cloud-login` with `query.campaign` equal to `['one', 'two']`. ## Review Focus Confirm the assertion covers Vue Router's repeated-query parsing while retaining the existing query, hash, and no-loop coverage. ## Validation - `pnpm test:unit src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts` — 11 tests passed - `pnpm exec oxfmt --check src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts` — passed - `git diff --check origin/main...HEAD` — passed - Commit hooks: typecheck, Oxlint, ESLint, and formatting passed; push hook Knip passed ## Screenshots (if applicable) Not applicable; this PR is test-only. Co-authored-by: Amp <amp@ampcode.com>
…outes (IR-105) (#15063) ## Summary Two durable fixes for the IR-105 splash-screen hang incident. ### Fix 1 — Bootstrap auth wait timeout (`bootstrapStore.ts`) **Root cause:** `until(isInitialized).toBe(true)` and `until(isAuthenticated).toBe(true)` in `startStoreBootstrap` have no timeout. A stale Firebase session or broken auth response hangs bootstrap silently and indefinitely — no error, no log, just a forever splash screen. **Fix:** Extract `waitForCloudAuth()` with: - 16 s timeout (matching `router.ts:176` and `WorkspaceAuthGate.vue:78` — existing convention) - One retry after 3 s backoff - On second timeout: `captureException` to Sentry + **continue bootstrap** rather than blocking This means the worst case is now 35 s to a usable (logged-out) state instead of infinity. ### Fix 2 — Catch-all route for unknown paths (`router.ts`) **Root cause:** A request to e.g. `cloud.comfy.org/woiadawd` gets a 200 + app shell from the static host, Vue boots, finds **no matching route**, and the global auth guard's `until(isInitialized)` then hangs (see Fix 1). Even with Fix 1, a no-match route leaves the app on the splash screen. **Fix:** Add `{ path: '/:pathMatch(.*)*', redirect: '/' }` at the end of the route list. Unknown paths redirect to root; the global auth guard then sends unauthenticated users to `/cloud/login` as normal. ## Red-Green Verification | Commit | Purpose | |--------|---------| | `test: add failing tests for unbounded auth wait in startStoreBootstrap` | 🔴 Proves test catches the bug — the "gives up" test times out in 5 s against the unpatched code | | `fix: bound auth wait in startStoreBootstrap and add catch-all route` | 🟢 Both new tests pass, all 18 tests in the two affected files pass | ## Relation to open PRs - Supersedes / closes the scope of #15032 (`fix/bootstrap-auth-wait-timeout`) — same fix, same tests. If reviewers prefer to land #15032 first this PR can drop Fix 1. - Companion to #15022 (marketing-site redirect) and #15026 (`/login` → `cloud-login` route, already on main). ## Test Plan - [x] `pnpm vitest run src/stores/bootstrapStore.test.ts` — 7/7 pass (including 2 new timeout tests) - [x] `pnpm vitest run src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts` — 11/11 pass - [x] `pnpm typecheck` — clean - [x] `pnpm exec eslint src/stores/bootstrapStore.ts src/router.ts` — clean - [ ] CI green (Playwright, Storybook, Codecov) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: GitHub Action <action@github.com>
…n guard (Comfy-Org#15058) ## Summary Follow-up test coverage for the legacy `/login` redirect landed in Comfy-Org#15026, driving the redirect through the real `cloud-login` guard instead of stopping at route resolution. ## Changes - **What**: adds `completeNavigation`, a helper that runs navigation to completion against the real route table with view components swapped for render-null stubs, so names, paths, meta, redirects and `beforeEnter` all stay intact. Covers three journeys through `/login`: signed-out lands on the login view, signed-in is forwarded past it, and `switchAccount` leaves the guard inert. Also ports the repeated-query-key case from the parallel fix in Comfy-Org#15022, contributed by @dante01yoon. - **Breaking**: none. Test-only change, no production code touched. ## Review Focus The existing `attemptNavigation` helper aborts in a global `beforeEach`, which is what keeps it cheap, but it means navigation never reaches a per-route `beforeEnter`. Every redirect assertion we had stopped one step short of the destination actually being entered. The reported failure was someone completing that journey, so the untested step was the interesting one. Worth knowing for anyone reading the route record: vue-router carries query and hash across a redirect by default. The explicit `query: to.query, hash: to.hash` in the record restates the default rather than providing it. I verified this by mutation, stripping the passthrough entirely leaves every existing assertion passing. I have deliberately left the code as-is, since it is harmless and reads as intent, but it should not be mistaken for load-bearing. That does mean the query assertions are narrower than they look. What they genuinely catch is someone replacing the redirect with a hand-built query, which flattens repeated keys. Substituting an explicit `query: { only: 'this' }` fails three of these tests immediately, so the guard is real, just narrower than "preserves the query" suggests. Mutation results for the whole file, since tests that cannot fail are decoration: | Mutation | Result | |---|---| | Delete the `/login` record | 6 tests fail | | Strip explicit `query`/`hash` from the redirect | 15 pass (vue-router default) | | Replace with an explicit overriding query | 3 tests fail | ## ELI5 Opening `cloud.comfy.org/login` used to hang forever, because the app had no `/login` page registered and just sat there looking for one. That was fixed by pointing `/login` at the real sign-in page. The tests that shipped with that fix checked that the signpost points the right way. They did not check that you can actually walk through the door it points at, because they stopped the moment the direction was known. The original bug was someone walking through the door, so this adds tests that make the whole trip. There are three trips worth making: a logged-out visitor should arrive at the sign-in page, a logged-in visitor should be sent onward rather than asked to sign in again, and someone deliberately switching accounts should be left alone at the sign-in page even though they are already logged in. All three now have tests. While writing them I checked whether the tests could actually fail, by deliberately breaking the redirect in three different ways and confirming the right tests complained each time. One of those experiments turned up something worth recording: part of the original fix is redundant, because the router already does that work by default. It is harmless and I have left it alone, but the note above means the next person will not assume it is doing something it is not. --------- Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com>
Summary
Add a Cloud router compatibility redirect from the legacy
/loginpath to the canonical namedcloud-loginroute while preserving query parameters.This is the consumer-side companion to #15021, which stops the marketing website from generating new
https://cloud.comfy.org/loginURLs. This PR keeps existing bookmarks, browser history, emails, documentation, and externally shared legacy links working deterministically.Root cause
The canonical Cloud login route is
/cloud/login, but/loginis not registered in the Cloud Vue router.For logged-out users, the global auth guard previously masked the invalid route by redirecting to
cloud-loginand preserving the original path aspreviousFullPath=/login. The Login → Sign Up link preserves that query. After successful signup, the shared post-auth redirect restorespreviousFullPath, returning the now-authenticated user to unmatched/login. Because authenticated users pass the global guard, the application has no matched component to render and can remain blank or stuck on the loading UI.This routing bug is independent of IR-105's cached JavaScript 404s. The asset-loading incident made the invalid URL more visible because no client-side routing could execute when the SPA failed to boot, but the signup reproduction exists without the cached 404.
AS IS
TO BE
The compatibility redirect runs as route matching, before authentication-state-specific guard behavior can expose the invalid route.
Changes
/loginas a Cloud-only compatibility redirect to the namedcloud-loginroute.Validation
The implementation was validated in an isolated project checkout before being applied to this branch:
oxfmtcheck: passedpnpm typecheck: passedgit diff --check: passedRegression risk
Low. The new top-level route is part of
cloudOnboardingRoutes, which is only installed for Cloud builds. It affects only the previously unregistered exact path/login; existing/cloud/loginbehavior is unchanged. Query preservation is covered by the regression test.Screenshots
Not applicable. This changes URL routing only and does not modify rendered UI.