Skip to content

test(router): drive the legacy /login redirect through the cloud-login guard - #15058

Merged
christian-byrne merged 2 commits into
mainfrom
matt/login-redirect-test-coverage
Aug 16, 2026
Merged

christian-byrne merged 2 commits into
mainfrom
matt/login-redirect-test-coverage

Conversation

@mattmillerai

Copy link
Copy Markdown
Member

Summary

Follow-up test coverage for the legacy /login redirect landed in #15026, driving the redirect through the real cloud-login guard instead of stopping at route resolution.

Changes

  • What: adds completeNavigation, a helper that runs navigation to completion against the real route table with view components swapped for render-null stubs, so names, paths, meta, redirects and beforeEnter all stay intact. Covers three journeys through /login: signed-out lands on the login view, signed-in is forwarded past it, and switchAccount leaves the guard inert. Also ports the repeated-query-key case from the parallel fix in Fix legacy Cloud login route #15022, contributed by @dante01yoon.
  • Breaking: none. Test-only change, no production code touched.

Review Focus

The existing attemptNavigation helper aborts in a global beforeEach, which is what keeps it cheap, but it means navigation never reaches a per-route beforeEnter. Every redirect assertion we had stopped one step short of the destination actually being entered. The reported failure was someone completing that journey, so the untested step was the interesting one.

Worth knowing for anyone reading the route record: vue-router carries query and hash across a redirect by default. The explicit query: to.query, hash: to.hash in the record restates the default rather than providing it. I verified this by mutation, stripping the passthrough entirely leaves every existing assertion passing. I have deliberately left the code as-is, since it is harmless and reads as intent, but it should not be mistaken for load-bearing.

That does mean the query assertions are narrower than they look. What they genuinely catch is someone replacing the redirect with a hand-built query, which flattens repeated keys. Substituting an explicit query: { only: 'this' } fails three of these tests immediately, so the guard is real, just narrower than "preserves the query" suggests.

Mutation results for the whole file, since tests that cannot fail are decoration:

Mutation Result
Delete the /login record 6 tests fail
Strip explicit query/hash from the redirect 15 pass (vue-router default)
Replace with an explicit overriding query 3 tests fail

ELI5

Opening cloud.comfy.org/login used to hang forever, because the app had no /login page registered and just sat there looking for one. That was fixed by pointing /login at the real sign-in page.

The tests that shipped with that fix checked that the signpost points the right way. They did not check that you can actually walk through the door it points at, because they stopped the moment the direction was known. The original bug was someone walking through the door, so this adds tests that make the whole trip.

There are three trips worth making: a logged-out visitor should arrive at the sign-in page, a logged-in visitor should be sent onward rather than asked to sign in again, and someone deliberately switching accounts should be left alone at the sign-in page even though they are already logged in. All three now have tests.

While writing them I checked whether the tests could actually fail, by deliberately breaking the redirect in three different ways and confirming the right tests complained each time. One of those experiments turned up something worth recording: part of the original fix is redundant, because the router already does that work by default. It is harmless and I have left it alone, but the note above means the next person will not assume it is doing something it is not.

…n guard

The redirect tests added with the /login fix abort navigation in a global
guard, so they prove the route table resolves the path but never enter the
destination. The reported failure was a user completing that journey, so the
part that was never exercised is the part that broke.

Adds a navigation helper that stubs view components while leaving names,
paths, meta, redirects and beforeEnter intact, and covers the signed-out,
signed-in and switchAccount paths through the redirect.

Also ports the repeated-query-key case from the parallel fix in #15022. Note
that vue-router carries query and hash across a redirect on its own, so the
explicit passthrough in the route record is belt and braces; what these cases
actually pin is that nobody replaces the query with a hand-built one, which
would flatten repeated keys.

Co-Authored-By: dante01yoon <6510430+dante01yoon@users.noreply.github.com>
@mattmillerai
mattmillerai requested a review from a team August 11, 2026 21:36
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: aada6ed2-957b-4357-a74b-48144d708b7f

📥 Commits

Reviewing files that changed from the base of the PR and between e690c0f and af05694.

📒 Files selected for processing (1)
  • src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/12/2026, 12:19:22 AM UTC

Links

🎭 Playwright: ✅ 1802 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1781 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 8.69 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 36.7 MB baseline 36.7 MB — ⚪ 0 B
  • Gzip: 8.69 MB baseline 8.69 MB — ⚪ 0 B
  • Brotli: 6.06 MB baseline 6.06 MB — ⚪ 0 B
  • Bundles: 436 current • 436 baseline

Category Glance
Vendor & Third-Party ⚪ 0 B (16.3 MB) · Other ⚪ 0 B (14 MB) · Data & Services ⚪ 0 B (3.5 MB) · Graph Workspace ⚪ 0 B (1.36 MB) · Panels & Settings ⚪ 0 B (565 kB) · Utilities & Hooks ⚪ 0 B (550 kB) · + 5 more

App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 10 unchanged

Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 B

Reusable component library chunks

Status: 14 unchanged

Data & Services — 3.5 MB (baseline 3.5 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 38 unchanged

Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 17 unchanged

Other — 14 MB (baseline 14 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 285 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 44.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 45.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 153ms TBT · 73.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.1 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 335ms TBT · 169.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap

⚠️ 8 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 484ms 497ms +3% ⚠️ z=3.3
canvas-zoom-sweep: task duration 367ms 399ms +9% ⚠️ z=3.1
large-graph-idle: task duration 675ms 686ms +2% ⚠️ z=2.7
large-graph-pan: task duration 1239ms 1374ms +11% ⚠️ z=6.8
large-graph-pan: script duration 416ms 459ms +11% ⚠️ z=2.6
minimap-idle: task duration 654ms 745ms +14% ⚠️ z=4.6
minimap-idle: script duration 101ms 123ms +21% ⚠️ z=2.5
subgraph-idle: task duration 452ms 511ms +13% ⚠️ z=4.5
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms -0% z=-0.5
canvas-idle: p95 frame time 17ms 17ms -0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 10ms 9ms -8% z=-2.1
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 10 +6% z=-2.9
canvas-idle: task duration 484ms 497ms +3% ⚠️ z=3.3
canvas-idle: script duration 19ms 21ms +10% z=-2.1
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 67.0 MB 67.1 MB +0% —
canvas-idle: DOM nodes 18 19 +6% z=-2.8
canvas-idle: event listeners 4 4 +0% z=-1.6
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=0.2
canvas-mouse-sweep: p95 frame time 17ms 17ms -0% —
canvas-mouse-sweep: layout duration 3ms 3ms +3% z=-0.9
canvas-mouse-sweep: style recalc duration 35ms 39ms +10% z=-1.1
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 74 77 +3% z=-0.9
canvas-mouse-sweep: task duration 857ms 951ms +11% z=1.5
canvas-mouse-sweep: script duration 118ms 131ms +11% z=-0.7
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 49.1 MB 49.5 MB +1% —
canvas-mouse-sweep: DOM nodes -281 -280 -0% z=-132.3
canvas-mouse-sweep: event listeners -153 -152 -1% z=-38.5
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-1.1
canvas-zoom-sweep: p95 frame time 17ms 17ms -0% —
canvas-zoom-sweep: layout duration 1ms 1ms +8% z=-1.0
canvas-zoom-sweep: style recalc duration 16ms 19ms +16% z=-0.1
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 33 +5% z=2.7
canvas-zoom-sweep: task duration 367ms 399ms +9% ⚠️ z=3.1
canvas-zoom-sweep: script duration 18ms 22ms +21% z=-1.8
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 69.8 MB 69.8 MB -0% —
canvas-zoom-sweep: DOM nodes 77 78 +1% z=-1.6
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 8ms 8ms -8% z=-3.0
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 12 11 -13% z=-5.2
dom-widget-clipping: task duration 363ms 390ms +7% z=1.5
dom-widget-clipping: script duration 57ms 62ms +7% z=-1.9
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 50.7 MB 50.7 MB +0% —
dom-widget-clipping: DOM nodes 20 17 -15% z=-3.6
dom-widget-clipping: event listeners 0 1 — variance too high
large-graph-idle: avg frame time 17ms 17ms -0% z=-0.6
large-graph-idle: p95 frame time 17ms 17ms +1% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 8ms 8ms +1% z=-3.6
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 9 9 -6% z=-9.9
large-graph-idle: task duration 675ms 686ms +2% ⚠️ z=2.7
large-graph-idle: script duration 103ms 108ms +5% z=0.5
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 63.5 MB 63.8 MB +0% —
large-graph-idle: DOM nodes -282 -282 -0% z=-338.8
large-graph-idle: event listeners -149 -148 -1% z=-28.6
large-graph-pan: avg frame time 17ms 17ms +0% z=0.8
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 14ms 15ms +5% z=-3.4
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 69 +1% z=-1.7
large-graph-pan: task duration 1239ms 1374ms +11% ⚠️ z=6.8
large-graph-pan: script duration 416ms 459ms +11% ⚠️ z=2.6
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 61.3 MB 60.7 MB -1% —
large-graph-pan: DOM nodes -285 -285 +0% z=-184.3
large-graph-pan: event listeners -149 -163 +9% z=-202.8
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 7ms 7ms +5% —
large-graph-zoom: style recalc duration 14ms 14ms -0% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 65 64 -2% —
large-graph-zoom: task duration 1502ms 1577ms +5% —
large-graph-zoom: script duration 527ms 555ms +5% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 56.7 MB 59.5 MB +5% —
large-graph-zoom: DOM nodes -288 -290 +1% —
large-graph-zoom: event listeners -153 -153 +0% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.7
minimap-idle: p95 frame time 17ms 17ms -0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 8ms 7ms -10% z=-3.3
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 8 7 -13% z=-3.8
minimap-idle: task duration 654ms 745ms +14% ⚠️ z=4.6
minimap-idle: script duration 101ms 123ms +21% ⚠️ z=2.5
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 64.7 MB 64.1 MB -1% —
minimap-idle: DOM nodes -283 -285 +1% z=-222.4
minimap-idle: event listeners -149 -163 +9% z=-253.8
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.4
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -1% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 11ms 12ms +2% z=-1.1
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 47 +0% z=-1.6
subgraph-dom-widget-clipping: task duration 398ms 408ms +3% z=1.6
subgraph-dom-widget-clipping: script duration 119ms 122ms +2% z=-1.0
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 51.3 MB 51.2 MB -0% —
subgraph-dom-widget-clipping: DOM nodes 20 20 +0% z=-1.9
subgraph-dom-widget-clipping: event listeners 6 6 +0% z=-1.7
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 7ms 9ms +18% z=-2.2
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 9 10 +6% z=-2.1
subgraph-idle: task duration 452ms 511ms +13% ⚠️ z=4.5
subgraph-idle: script duration 13ms 15ms +18% z=-1.8
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 66.8 MB 44.7 MB -33% —
subgraph-idle: DOM nodes 18 -280 -1656% z=-201.9
subgraph-idle: event listeners 4 -153 -3925% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.1
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% —
subgraph-mouse-sweep: layout duration 4ms 4ms +2% z=-0.9
subgraph-mouse-sweep: style recalc duration 37ms 38ms +5% z=-1.2
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 77 78 +1% z=-1.1
subgraph-mouse-sweep: task duration 801ms 838ms +5% z=1.0
subgraph-mouse-sweep: script duration 90ms 96ms +7% z=-0.7
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 45.7 MB 45.5 MB -0% —
subgraph-mouse-sweep: DOM nodes -281 -280 -1% z=-155.1
subgraph-mouse-sweep: event listeners -153 -153 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms -0% —
subgraph-transition-enter: p95 frame time 17ms 17ms -1% —
subgraph-transition-enter: layout duration 13ms 13ms +0% —
subgraph-transition-enter: style recalc duration 32ms 31ms -3% —
subgraph-transition-enter: layout count 15 14 -7% —
subgraph-transition-enter: style recalc count 19 18 -5% —
subgraph-transition-enter: task duration 1010ms 1027ms +2% —
subgraph-transition-enter: script duration 39ms 44ms +12% —
subgraph-transition-enter: TBT 154ms 153ms -1% —
subgraph-transition-enter: heap used 93.9 MB 73.0 MB -22% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2375 2375 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 37ms 38ms +3% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 250 +0% —
viewport-pan-sweep: task duration 4421ms 4653ms +5% —
viewport-pan-sweep: script duration 1393ms 1415ms +2% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 68.1 MB 68.7 MB +1% —
viewport-pan-sweep: DOM nodes -283 -282 -0% —
viewport-pan-sweep: event listeners -133 -131 -2% —
vue-large-graph-idle: avg frame time 18ms 18ms -0% —
vue-large-graph-idle: p95 frame time 17ms 17ms -0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 16575ms 17190ms +4% —
vue-large-graph-idle: script duration 527ms 572ms +9% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 157.8 MB 161.1 MB +2% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16387 -16387 +0% —
vue-large-graph-pan: avg frame time 18ms 18ms +2% —
vue-large-graph-pan: p95 frame time 17ms 17ms +1% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 17ms 20ms +20% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 139 149 +7% —
vue-large-graph-pan: task duration 20737ms 21307ms +3% —
vue-large-graph-pan: script duration 885ms 938ms +6% —
vue-large-graph-pan: TBT 228ms 335ms +47% —
vue-large-graph-pan: heap used 168.8 MB 169.5 MB +0% —
vue-large-graph-pan: DOM nodes -8312 -8312 +0% —
vue-large-graph-pan: event listeners -16387 -16381 -0% —
workflow-execution: avg frame time 17ms 17ms -0% z=0.6
workflow-execution: p95 frame time 17ms 17ms -0% —
workflow-execution: layout duration 1ms 1ms -14% z=-2.7
workflow-execution: style recalc duration 21ms 22ms +4% z=-1.0
workflow-execution: layout count 4 3 -25% z=-3.6
workflow-execution: style recalc count 15 16 +7% z=-0.9
workflow-execution: task duration 120ms 125ms +4% z=0.2
workflow-execution: script duration 10ms 11ms +13% z=-6.2
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 65.5 MB 65.4 MB -0% —
workflow-execution: DOM nodes 126 138 +9% z=-3.3
workflow-execution: event listeners 97 98 +1% z=10.6
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-12T00:29:51.138Z",
  "gitSha": "6c00d644169aadd0ef8f3f335c0f3f40f19b1580",
  "branch": "matt/login-redirect-test-coverage",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2042.2920000000317,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.531999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.48900000000003,
      "heapDeltaBytes": 5785036,
      "heapUsedBytes": 70305484,
      "domNodes": 18,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 20.038,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2048.460000000091,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.302000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.431,
      "heapDeltaBytes": 5886416,
      "heapUsedBytes": 70327168,
      "domNodes": 20,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 21.041,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2020.8959999999934,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 43.202,
      "layouts": 12,
      "layoutDurationMs": 3.3400000000000003,
      "taskDurationMs": 1027.5939999999998,
      "heapDeltaBytes": -12848168,
      "heapUsedBytes": 51535196,
      "domNodes": -279,
      "jsHeapTotalBytes": 24616960,
      "scriptDurationMs": 138.026,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1857.5029999999515,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 34.982,
      "layouts": 12,
      "layoutDurationMs": 3.5439999999999996,
      "taskDurationMs": 874.077,
      "heapDeltaBytes": -12025908,
      "heapUsedBytes": 52336524,
      "domNodes": -281,
      "jsHeapTotalBytes": 23044096,
      "scriptDurationMs": 123.968,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1753.7120000000073,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 19.819999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.5919999999999999,
      "taskDurationMs": 404.48999999999995,
      "heapDeltaBytes": 8769136,
      "heapUsedBytes": 73172644,
      "domNodes": 79,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 22.714000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.4900000000325,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.049999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.606,
      "taskDurationMs": 392.93,
      "heapDeltaBytes": 8749816,
      "heapUsedBytes": 73179948,
      "domNodes": 77,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 20.770999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 606.1799999999948,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.009,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 392.5710000000001,
      "heapDeltaBytes": -11356396,
      "heapUsedBytes": 53168584,
      "domNodes": 16,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 62.042,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 584.7589999999627,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.061000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 386.69100000000003,
      "heapDeltaBytes": -11116448,
      "heapUsedBytes": 53226508,
      "domNodes": 18,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 61.24100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2021.5519999999856,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.034999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 685.7370000000001,
      "heapDeltaBytes": 6695556,
      "heapUsedBytes": 66287880,
      "domNodes": -281,
      "jsHeapTotalBytes": 3248128,
      "scriptDurationMs": 107.31599999999999,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2012.5309999999672,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.882,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 686.9000000000001,
      "heapDeltaBytes": 7077276,
      "heapUsedBytes": 67527012,
      "domNodes": -282,
      "jsHeapTotalBytes": 2461696,
      "scriptDurationMs": 108.89599999999999,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2245.2840000000265,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.075999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1352.042,
      "heapDeltaBytes": 1269360,
      "heapUsedBytes": 61912984,
      "domNodes": -285,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 461.053,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2291.9749999999794,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.070999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1395.464,
      "heapDeltaBytes": 4870988,
      "heapUsedBytes": 65326584,
      "domNodes": -285,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 457.92299999999994,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3214.7559999999658,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.38,
      "layouts": 60,
      "layoutDurationMs": 7.385999999999999,
      "taskDurationMs": 1555.416,
      "heapDeltaBytes": -1868924,
      "heapUsedBytes": 60214464,
      "domNodes": -290,
      "jsHeapTotalBytes": 6393856,
      "scriptDurationMs": 548.4680000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3310.8819999999923,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.030000000000001,
      "layouts": 60,
      "layoutDurationMs": 7.481999999999999,
      "taskDurationMs": 1598.8100000000004,
      "heapDeltaBytes": 2291456,
      "heapUsedBytes": 64601080,
      "domNodes": -289,
      "jsHeapTotalBytes": 6656000,
      "scriptDurationMs": 562.523,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.6880000000215,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.058999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 725.0239999999999,
      "heapDeltaBytes": 6414076,
      "heapUsedBytes": 67275136,
      "domNodes": -285,
      "jsHeapTotalBytes": 3510272,
      "scriptDurationMs": 119.12,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.735000000097,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.659000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 765.7019999999999,
      "heapDeltaBytes": 6659004,
      "heapUsedBytes": 67197400,
      "domNodes": -285,
      "jsHeapTotalBytes": 3510272,
      "scriptDurationMs": 127.37200000000001,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 575.5419999999845,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 393.96600000000007,
      "heapDeltaBytes": -10364700,
      "heapUsedBytes": 53830892,
      "domNodes": 18,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 120.10399999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 625.4950000000008,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 13.26,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 422.256,
      "heapDeltaBytes": -10871968,
      "heapUsedBytes": 53465452,
      "domNodes": 22,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 123.899,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.0459999999694,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.271,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.318,
      "heapDeltaBytes": -17545808,
      "heapUsedBytes": 47003312,
      "domNodes": -282,
      "jsHeapTotalBytes": 22519808,
      "scriptDurationMs": 13.156,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2054.573000000005,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.087000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 529.438,
      "heapDeltaBytes": -17764784,
      "heapUsedBytes": 46711728,
      "domNodes": -278,
      "jsHeapTotalBytes": 23830528,
      "scriptDurationMs": 17.467999999999996,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.752000000014,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 36.946999999999996,
      "layouts": 16,
      "layoutDurationMs": 4.152,
      "taskDurationMs": 829.711,
      "heapDeltaBytes": -16386272,
      "heapUsedBytes": 48054672,
      "domNodes": -281,
      "jsHeapTotalBytes": 22781952,
      "scriptDurationMs": 95.241,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1768.9080000000104,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 39.980000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.6979999999999995,
      "taskDurationMs": 846.114,
      "heapDeltaBytes": -16952356,
      "heapUsedBytes": 47389740,
      "domNodes": -278,
      "jsHeapTotalBytes": 23568384,
      "scriptDurationMs": 97.07300000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1435.877000000005,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.787999999999997,
      "layouts": 14,
      "layoutDurationMs": 13.196000000000003,
      "taskDurationMs": 1027.168,
      "heapDeltaBytes": 3877652,
      "heapUsedBytes": 76598244,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15466496,
      "scriptDurationMs": 43.848,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 153,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8354.959000000008,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.844,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4571.015,
      "heapDeltaBytes": 11643120,
      "heapUsedBytes": 71176436,
      "domNodes": -284,
      "jsHeapTotalBytes": 5537792,
      "scriptDurationMs": 1389.211,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8450.263999999948,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 38.656,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4734.557000000001,
      "heapDeltaBytes": 14121548,
      "heapUsedBytes": 72909148,
      "domNodes": -280,
      "jsHeapTotalBytes": 4751360,
      "scriptDurationMs": 1441.02,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17246.0870000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17220.59,
      "heapDeltaBytes": -60736832,
      "heapUsedBytes": 167004504,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10428416,
      "scriptDurationMs": 539.784,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17179.07300000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17159.600000000002,
      "heapDeltaBytes": -46260356,
      "heapUsedBytes": 170786604,
      "domNodes": -8312,
      "jsHeapTotalBytes": -3608576,
      "scriptDurationMs": 604.871,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21688.42600000005,
      "styleRecalcs": 152,
      "styleRecalcDurationMs": 21.733999999999977,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21660.385000000002,
      "heapDeltaBytes": -29539436,
      "heapUsedBytes": 176495736,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8921088,
      "scriptDurationMs": 920.9239999999999,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 364,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21012.620000000083,
      "styleRecalcs": 145,
      "styleRecalcDurationMs": 18.674000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20953.773,
      "heapDeltaBytes": -43498912,
      "heapUsedBytes": 179016488,
      "domNodes": -8312,
      "jsHeapTotalBytes": -7876608,
      "scriptDurationMs": 954.531,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 306,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 452.7100000000246,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 19.831,
      "layouts": 3,
      "layoutDurationMs": 0.6930000000000001,
      "taskDurationMs": 118.249,
      "heapDeltaBytes": 5059164,
      "heapUsedBytes": 68547360,
      "domNodes": 128,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 10.181000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 488.8740000000098,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 24.34,
      "layouts": 3,
      "layoutDurationMs": 1.6170000000000002,
      "taskDurationMs": 132.349,
      "heapDeltaBytes": 5168028,
      "heapUsedBytes": 68672284,
      "domNodes": 147,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 11.459999999999999,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

@mattmillerai mattmillerai added the cursor-review Trigger multi-model Cursor agent review on this PR label Aug 11, 2026
@codecov

codecov Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #15058      +/-   ##
==========================================
- Coverage   80.85%   80.79%   -0.07%     
==========================================
  Files        1873     1873              
  Lines      121884   122030     +146     
  Branches    37442    37974     +532     
==========================================
+ Hits        98551    98593      +42     
- Misses      22800    22892      +92     
- Partials      533      545      +12     
Flag Coverage Δ
unit 72.52% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @mattmillerai.

Found 4 finding(s).

Severity Count
🟢 Low 2
⚪ Nit 2

Panel: 8/8 reviewers contributed findings.

Review follow-ups on the /login guard coverage.

`router.push` resolves with a NavigationFailure rather than throwing, and
completeNavigation discarded it, so a guard that aborted would have surfaced as
a confusing currentRoute mismatch. Assert it instead, and drop the isReady()
call, which was a no-op after an awaited push.

stubViews substituted only the singular `component` key, so a route using named
views would have compiled its real loaders inside the test body, the cost the
helper exists to avoid.

isLoggedIn is module-scope state reset only in the describe that flips it, and
the last test left it true. Reset it file-wide instead.
@christian-byrne
christian-byrne added this pull request to the merge queue Aug 16, 2026
Merged via the queue into main with commit 60d88b2 Aug 16, 2026
67 checks passed
@christian-byrne
christian-byrne deleted the matt/login-redirect-test-coverage branch August 16, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants