Repository navigation
test: cover repeated legacy login query params - #15054
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019ff291-263a-731b-a6ab-46a22c4d45d5 Co-authored-by: Amp <amp@ampcode.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesLogin redirect test
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1800 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle: 8.69 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.5 MB (baseline 3.5 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14 MB (baseline 14 MB) • ⚪ 0 BBundles that do not match a named category Status: 285 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-11T21:03:47.631Z",
"gitSha": "5538fd34a48b045f3c95bbc65f88715cee35bb1e",
"branch": "dante/test-legacy-login-repeated-query",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2045.5249999999978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.077999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.62,
"heapDeltaBytes": 5979556,
"heapUsedBytes": 70187392,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 14.529999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2010.8979999999974,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.231000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.715,
"heapDeltaBytes": 5888000,
"heapUsedBytes": 70238596,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 14.270999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.7440000000138,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.789,
"layouts": 12,
"layoutDurationMs": 3.509,
"taskDurationMs": 845.3050000000001,
"heapDeltaBytes": -14222552,
"heapUsedBytes": 50274080,
"domNodes": -281,
"jsHeapTotalBytes": 23568384,
"scriptDurationMs": 116.85199999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.1250000000282,
"styleRecalcs": 74,
"styleRecalcDurationMs": 34.923,
"layouts": 12,
"layoutDurationMs": 3.5440000000000005,
"taskDurationMs": 862.957,
"heapDeltaBytes": -11469412,
"heapUsedBytes": 52827272,
"domNodes": -280,
"jsHeapTotalBytes": 23830528,
"scriptDurationMs": 118.957,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.0030000000293,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.351999999999999,
"layouts": 6,
"layoutDurationMs": 0.601,
"taskDurationMs": 355.346,
"heapDeltaBytes": 8587116,
"heapUsedBytes": 72949368,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 17.115999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.9300000000003,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.585,
"layouts": 6,
"layoutDurationMs": 0.675,
"taskDurationMs": 368.193,
"heapDeltaBytes": 8876472,
"heapUsedBytes": 73172608,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 18.102999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 592.0959999999695,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.229999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.29799999999994,
"heapDeltaBytes": -11515896,
"heapUsedBytes": 52780260,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 56.961,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 588.965999999914,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.321000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.85699999999997,
"heapDeltaBytes": -11174852,
"heapUsedBytes": 53252712,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 58.79900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.688999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.932999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 661.763,
"heapDeltaBytes": 7488452,
"heapUsedBytes": 66846104,
"domNodes": -282,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 99.116,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.501000000063,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.407,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.04,
"heapDeltaBytes": 6889020,
"heapUsedBytes": 66374656,
"domNodes": -281,
"jsHeapTotalBytes": 2723840,
"scriptDurationMs": 105.185,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2172.153000000037,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.114,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1254.282,
"heapDeltaBytes": 4115140,
"heapUsedBytes": 64711052,
"domNodes": -285,
"jsHeapTotalBytes": 3440640,
"scriptDurationMs": 436.906,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2151.1319999999614,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.918,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1261.088,
"heapDeltaBytes": 19799956,
"heapUsedBytes": 80504544,
"domNodes": -282,
"jsHeapTotalBytes": 3178496,
"scriptDurationMs": 431.266,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3214.936000000023,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.480999999999996,
"layouts": 60,
"layoutDurationMs": 7.098,
"taskDurationMs": 1476.376,
"heapDeltaBytes": -3030144,
"heapUsedBytes": 60253220,
"domNodes": -286,
"jsHeapTotalBytes": 5869568,
"scriptDurationMs": 532.513,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3180.962999999906,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.156999999999998,
"layouts": 60,
"layoutDurationMs": 7.005000000000001,
"taskDurationMs": 1494.9139999999998,
"heapDeltaBytes": -2446484,
"heapUsedBytes": 59703544,
"domNodes": -288,
"jsHeapTotalBytes": 6918144,
"scriptDurationMs": 535.5680000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.284999999973,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.7780000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.677,
"heapDeltaBytes": 6349120,
"heapUsedBytes": 66902832,
"domNodes": -284,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 100.78899999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.755999999963,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.673000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 682.4530000000001,
"heapDeltaBytes": 1606432,
"heapUsedBytes": 62908088,
"domNodes": -283,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 105.03299999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.5270000000128,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.634,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.69100000000003,
"heapDeltaBytes": -10353168,
"heapUsedBytes": 53869932,
"domNodes": 16,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 119.56899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.6089999999676,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.879999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.445,
"heapDeltaBytes": -10136584,
"heapUsedBytes": 54197320,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 119.987,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.877999999991,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.918999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.76200000000006,
"heapDeltaBytes": 5932212,
"heapUsedBytes": 70504524,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 12.29,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2006.603000000041,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.439999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.71999999999997,
"heapDeltaBytes": -17581212,
"heapUsedBytes": 46753152,
"domNodes": -281,
"jsHeapTotalBytes": 22519808,
"scriptDurationMs": 13.142000000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.0489999999877,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.204,
"layouts": 16,
"layoutDurationMs": 4.415000000000001,
"taskDurationMs": 718.4560000000001,
"heapDeltaBytes": -3357620,
"heapUsedBytes": 61126776,
"domNodes": 62,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 85.50399999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1749.5869999999059,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.079,
"layouts": 16,
"layoutDurationMs": 4.22,
"taskDurationMs": 794.634,
"heapDeltaBytes": -16301144,
"heapUsedBytes": 48132508,
"domNodes": -281,
"jsHeapTotalBytes": 23044096,
"scriptDurationMs": 88.565,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.978000000066,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.932,
"layouts": 14,
"layoutDurationMs": 11.99,
"taskDurationMs": 910.156,
"heapDeltaBytes": 31009676,
"heapUsedBytes": 99993200,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 34.12799999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8289.584999999988,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.483,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4362.19,
"heapDeltaBytes": 10965936,
"heapUsedBytes": 71112984,
"domNodes": -283,
"jsHeapTotalBytes": 6586368,
"scriptDurationMs": 1381.491,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8260.206999999922,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.506,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4440.933999999999,
"heapDeltaBytes": 12543408,
"heapUsedBytes": 72073948,
"domNodes": -281,
"jsHeapTotalBytes": 5275648,
"scriptDurationMs": 1406.654,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 15932.251000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15918.286000000002,
"heapDeltaBytes": -60673700,
"heapUsedBytes": 166898132,
"domNodes": -8312,
"jsHeapTotalBytes": -8069120,
"scriptDurationMs": 508.82300000000004,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16222.815999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16172.933,
"heapDeltaBytes": -27672488,
"heapUsedBytes": 177821628,
"domNodes": -8312,
"jsHeapTotalBytes": -7016448,
"scriptDurationMs": 553.771,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 19911.27800000004,
"styleRecalcs": 137,
"styleRecalcDurationMs": 14.666000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19889.531000000003,
"heapDeltaBytes": -54097128,
"heapUsedBytes": 154033904,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 825.528,
"eventListeners": -16381,
"totalBlockingTimeMs": 142,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20269.390000000043,
"styleRecalcs": 140,
"styleRecalcDurationMs": 15.535000000000021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20217.668000000005,
"heapDeltaBytes": -38272688,
"heapUsedBytes": 167535652,
"domNodes": -8312,
"jsHeapTotalBytes": -11214848,
"scriptDurationMs": 873.925,
"eventListeners": -16383,
"totalBlockingTimeMs": 76,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 448.75999999999294,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.185,
"layouts": 2,
"layoutDurationMs": 0.3929999999999999,
"taskDurationMs": 102.583,
"heapDeltaBytes": 5059416,
"heapUsedBytes": 68550372,
"domNodes": 126,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.617,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 471.2279999999964,
"styleRecalcs": 14,
"styleRecalcDurationMs": 23.631,
"layouts": 4,
"layoutDurationMs": 1.5859999999999999,
"taskDurationMs": 117.12700000000001,
"heapDeltaBytes": 5045972,
"heapUsedBytes": 68504496,
"domNodes": 123,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.582,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15054 +/- ##
========================================
Coverage 81.38% 81.38%
========================================
Files 1873 1873
Lines 106451 106451
Branches 32847 33226 +379
========================================
Hits 86631 86631
+ Misses 19475 19465 -10
- Partials 345 355 +10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Ports the repeated-query regression coverage identified in superseded PR #15022 after #15026 merged the legacy
/loginredirect. Original coverage and test approach are attributed to #15022 / @dante01yoon.Changes
/login?campaign=one&campaign=tworeachescloud-loginwithquery.campaignequal to['one', 'two'].Review Focus
Confirm the assertion covers Vue Router's repeated-query parsing while retaining the existing query, hash, and no-loop coverage.
Validation
pnpm test:unit src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts— 11 tests passedpnpm exec oxfmt --check src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts— passedgit diff --check origin/main...HEAD— passedScreenshots (if applicable)
Not applicable; this PR is test-only.