Skip to content

test: cover the cloud auth surface - #14987

Merged
MaanilVerma merged 15 commits into
mainfrom
test/cloud-auth-coverage-standalone
Aug 18, 2026
Merged

MaanilVerma merged 15 commits into
mainfrom
test/cloud-auth-coverage-standalone

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Aug 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds the missing test coverage for the cloud sign-in and sign-up surface. Four files had no tests at all.

Changes

  • What: Tests only, no product code.

    Previously uncovered: the beforeEnter route guards and their switchAccount escape hatch, usePostAuthRedirect, the sign-in password schema, and the terms notice. The rest extends existing files rather than duplicating their setup.

    Covered here: route guards on both /cloud/login and /cloud/signup, post-auth redirect precedence and its open-redirect guard, password boundaries and character classes, the terms notice and its outbound-link safety, the sign-in form's validation states and autofill attributes, the turnstile gate on sign-up, and the insecure-context warning for self-hosted HTTP origins.

  • Breaking: None.

Review Focus

The route-guard tests drive both /cloud/login and /cloud/signup through the same describe.for. Those guards are byte-identical duplicates, so testing one would leave the other free to regress.

One assumption from the plan turned out to be wrong, and the test pins the real behaviour instead: a pristine sign-in button is enabled, not disabled. PrimeVue leaves $form.valid undefined until a field is touched, so submitting a pristine form is what surfaces the errors.

globalThis.isSecureContext is undefined under happy-dom rather than true, so the insecure-context test stubs the secure case. The value is a setup-time snapshot, so the stub has to precede mount.

Testing

90 tests. Every one was mutation-checked: the behaviour it pins was broken in the source, the test confirmed failing, then reverted. No survivors.

Area Cases Representative mutation → result
Password + email schema 19 drop any one complexity regex → that case fails; move the refine path → mismatch fails
Open-redirect guard 7 read the last repeated query entry instead of the first → fails; decode fallback returns a / path → fails
Post-auth redirect 7 router.replace → push → fails; drop the OAuth-resume early return → deep-link precedence fails
Route guards 19 negate isLoggedIn → both routes fail; if (!to.query.switchAccount) → if (true) → escape hatch fails
Terms notice 5 drop rel="noopener noreferrer" → fails; hard-code any locale fragment → fails
Sign-in form 12 drop :disabled="!$form.valid" → fails; current-password → new-password → fails
Sign-up form 15 remove useThrottleFn → double-submit fails; make resetTurnstile a no-op → fails
Login view 6 insecure-context warning v-if="false" → fails; force the webview notice → fails

Three guards are unkillable in isolation and die only once the outer gate is also removed, which is the signature of defence-in-depth rather than dead code: CloudSignInForm.onSubmit's event.valid, SignUpForm.onSubmit's waitingForTurnstile, and both forms' loading gate behind Button's disabled || loading.

No e2e spec. The two flows worth driving end to end — the deep-link round trip and the already-signed-in redirect — are pinned closer to the logic in usePostAuthRedirect.test.ts and onboardingCloudRoutes.test.ts, the latter on both routes. A browser spec added a slower path to the same assertions.

Adds the missing coverage for the cloud sign-in and sign-up surface: the
route guards and their switchAccount escape hatch, the post-auth redirect
and its open-redirect guard, the sign-in password schema, the terms notice,
the sign-in form's validation and autofill affordances, and the turnstile
gate on sign-up.

Also adds e2e for deep-link intent, the already-signed-in pass-through, and
the switchAccount hatch, mocked at the network boundary.
@MaanilVerma
MaanilVerma requested a review from a team August 10, 2026 12:58
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Added unit, component, route, and Playwright coverage for authentication validation, cloud onboarding, redirects, route guards, accessibility, security-state rendering, and account switching.

Changes

Authentication tests

Layer / File(s) Summary
Form validation and submission contracts
src/schemas/signInSchema.test.ts, src/components/dialog/content/signin/SignUpForm.test.ts
Tests cover password and email validation, confirmation errors, Turnstile status accessibility, and duplicate submission prevention.
Cloud onboarding component behavior
src/platform/cloud/onboarding/components/CloudSignInForm.test.ts, src/platform/cloud/onboarding/components/CloudTermsNotice.test.ts
Tests cover sign-in rendering, validation, submission, loading states, accessibility attributes, localized text, URLs, and link security attributes.
Cloud login security-state rendering
src/platform/cloud/onboarding/CloudLoginView.test.ts
Tests cover cleanup isolation and insecure-context warning visibility.
Post-auth redirects and route guards
src/platform/cloud/onboarding/composables/usePostAuthRedirect.test.ts, src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts, src/platform/cloud/onboarding/utils/previousFullPath.test.ts
Tests cover default and deep-link navigation, OAuth continuation, login guards, account switching, consent redirects, query preservation, and unsafe repeated paths.
Cloud email sign-in browser flow
browser_tests/tests/cloudAuthSignIn.spec.ts
Playwright tests mock Firebase authentication and verify deep-link restoration and authenticated redirects.

Estimated code review effort: 3 (Moderate) | ~30 minutes

Possibly related PRs

Suggested reviewers: christian-byrne


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The PR context lists changed files and the description, but it does not provide the PR title or commit subjects required to check for bug-fix language. Provide the PR title and commit subjects, then re-evaluate the bug-fix signal and the end-to-end coverage conditions.
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains only cloud authentication, schema, and browser test files; no src/lib/litegraph, src/ecs, or graph-entity files are modified.
Title check ✅ Passed The title clearly and concisely describes the primary change: expanded test coverage for the cloud authentication surface.
Description check ✅ Passed The description includes the required summary, changes, breaking-change status, review focus, and detailed testing information; screenshots are not applicable.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/cloud-auth-coverage-standalone

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The e2e counterpart to the inline sign-in error. Kept here rather than in
the fix branch because the spec file and its Firebase mocks only exist on
this branch.
@github-actions

github-actions Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/18/2026, 04:36:39 PM UTC

Links

🎭 Playwright: ✅ 1818 passed, 0 failed · 8 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1797 / ❌ 0 / ⚠️ 8 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 8.85 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 37.4 MB baseline 37.4 MB — ⚪ 0 B
  • Gzip: 8.85 MB baseline 8.85 MB — ⚪ 0 B
  • Brotli: 6.19 MB baseline 6.19 MB — ⚪ 0 B
  • Bundles: 438 current • 438 baseline

Category Glance
Vendor & Third-Party ⚪ 0 B (16.8 MB) · Other ⚪ 0 B (14.2 MB) · Data & Services ⚪ 0 B (3.52 MB) · Graph Workspace ⚪ 0 B (1.37 MB) · Panels & Settings ⚪ 0 B (566 kB) · Utilities & Hooks ⚪ 0 B (550 kB) · + 5 more

App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 B

Reusable component library chunks

Status: 14 unchanged

Data & Services — 3.52 MB (baseline 3.52 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 38 unchanged

Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 285 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 144ms TBT · 97.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.4 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.7 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 26ms TBT · 177.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap

⚠️ 3 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 509ms 492ms -3% ⚠️ z=3.1
large-graph-pan: task duration 1196ms 1172ms -2% ⚠️ z=2.1
subgraph-idle: task duration 494ms 466ms -6% ⚠️ z=3.1
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 10ms 9ms -12% z=-2.5
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 10 +6% z=-2.9
canvas-idle: task duration 509ms 492ms -3% ⚠️ z=3.1
canvas-idle: script duration 8ms 8ms -4% z=-7.9
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 56.9 MB 74.0 MB +30% —
canvas-idle: DOM nodes -282 -281 -0% z=-238.0
canvas-idle: event listeners -151 -166 +10% z=-37.5
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 3ms 3ms -1% z=-1.8
canvas-mouse-sweep: style recalc duration 36ms 33ms -7% z=-3.0
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 73 73 +0% z=-2.4
canvas-mouse-sweep: task duration 896ms 824ms -8% z=-0.7
canvas-mouse-sweep: script duration 117ms 106ms -10% z=-4.6
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 58.5 MB 64.1 MB +10% —
canvas-mouse-sweep: DOM nodes -281 -282 +0% z=-133.1
canvas-mouse-sweep: event listeners -149 -167 +12% z=-42.1
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-0.3
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms -29% z=-2.1
canvas-zoom-sweep: style recalc duration 19ms 16ms -13% z=-1.9
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 32 32 -2% z=0.5
canvas-zoom-sweep: task duration 378ms 337ms -11% z=0.4
canvas-zoom-sweep: script duration 10ms 8ms -19% z=-6.3
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 60.1 MB 60.4 MB +0% —
canvas-zoom-sweep: DOM nodes 76 77 +1% z=-3.5
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 7ms 7ms +2% z=-3.3
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 10 11 +5% z=-5.2
dom-widget-clipping: task duration 365ms 345ms -6% z=-1.2
dom-widget-clipping: script duration 59ms 54ms -9% z=-4.4
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 67.8 MB 67.5 MB -0% —
dom-widget-clipping: DOM nodes 16 17 +6% z=-3.6
dom-widget-clipping: event listeners 2 2 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms -0% z=-0.6
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 9ms 9ms -3% z=-3.5
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 9 10 +6% z=-6.7
large-graph-idle: task duration 625ms 589ms -6% z=0.9
large-graph-idle: script duration 17ms 14ms -18% z=-8.4
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 72.7 MB 59.8 MB -18% —
large-graph-idle: DOM nodes -262 -280 +7% z=-336.6
large-graph-idle: event listeners -151 -180 +19% z=-33.8
large-graph-pan: avg frame time 17ms 17ms -0% z=-0.2
large-graph-pan: p95 frame time 17ms 17ms -0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 14ms 14ms +6% z=-3.6
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 69 70 +1% z=-0.1
large-graph-pan: task duration 1196ms 1172ms -2% ⚠️ z=2.1
large-graph-pan: script duration 342ms 330ms -4% z=-3.9
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 72.9 MB 72.6 MB -0% —
large-graph-pan: DOM nodes -269 -251 -7% z=-163.3
large-graph-pan: event listeners -149 -147 -1% z=-183.5
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms -1% —
large-graph-zoom: layout duration 7ms 7ms -0% —
large-graph-zoom: style recalc duration 14ms 13ms -7% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 64 64 +0% —
large-graph-zoom: task duration 1335ms 1265ms -5% —
large-graph-zoom: script duration 394ms 372ms -6% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 73.4 MB 81.7 MB +11% —
large-graph-zoom: DOM nodes -274 10 -104% —
large-graph-zoom: event listeners 8 6 -25% —
legacy-node-drag: avg frame time 17ms 17ms +0% —
legacy-node-drag: p95 frame time 17ms 17ms +1% —
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 9ms 9ms +4% —
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 45 46 +1% —
legacy-node-drag: task duration 1465ms 1394ms -5% —
legacy-node-drag: script duration 477ms 446ms -6% —
legacy-node-drag: TBT 0ms 0ms +0% —
legacy-node-drag: heap used 60.0 MB 60.9 MB +1% —
legacy-node-drag: DOM nodes -272 -259 -5% —
legacy-node-drag: event listeners 31 33 +6% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms -1% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 8ms 8ms -3% z=-2.3
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 8 8 +0% z=-2.3
minimap-idle: task duration 606ms 598ms -1% z=1.5
minimap-idle: script duration 16ms 13ms -17% z=-8.6
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 71.5 MB 70.9 MB -1% —
minimap-idle: DOM nodes -268 -270 +1% z=-211.0
minimap-idle: event listeners -151 -147 -3% z=-229.6
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.4
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 12ms 11ms -7% z=-2.0
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 46 -3% z=-4.2
subgraph-dom-widget-clipping: task duration 389ms 368ms -5% z=-0.6
subgraph-dom-widget-clipping: script duration 122ms 113ms -7% z=-2.4
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 68.9 MB 68.5 MB -1% —
subgraph-dom-widget-clipping: DOM nodes 20 17 -15% z=-4.6
subgraph-dom-widget-clipping: event listeners 8 8 +0% z=-1.4
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms -0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 8ms 8ms +2% z=-3.5
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 9 9 -6% z=-3.7
subgraph-idle: task duration 494ms 466ms -6% ⚠️ z=3.1
subgraph-idle: script duration 7ms 6ms -12% z=-5.4
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 68.6 MB 58.4 MB -15% —
subgraph-idle: DOM nodes -280 -282 +1% z=-203.2
subgraph-idle: event listeners -181 -150 -17% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.8
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% —
subgraph-mouse-sweep: layout duration 5ms 4ms -16% z=-2.0
subgraph-mouse-sweep: style recalc duration 38ms 34ms -11% z=-2.5
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 75 76 +1% z=-2.4
subgraph-mouse-sweep: task duration 812ms 772ms -5% z=0.1
subgraph-mouse-sweep: script duration 87ms 81ms -7% z=-3.0
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 56.9 MB 58.0 MB +2% —
subgraph-mouse-sweep: DOM nodes -281 -280 -1% z=-155.1
subgraph-mouse-sweep: event listeners -151 -151 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +1% —
subgraph-transition-enter: layout duration 15ms 14ms -3% —
subgraph-transition-enter: style recalc duration 32ms 31ms -1% —
subgraph-transition-enter: layout count 15 15 +0% —
subgraph-transition-enter: style recalc count 20 20 +0% —
subgraph-transition-enter: task duration 917ms 897ms -2% —
subgraph-transition-enter: script duration 16ms 18ms +7% —
subgraph-transition-enter: TBT 141ms 144ms +2% —
subgraph-transition-enter: heap used 77.9 MB 97.5 MB +25% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2375 2375 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +1% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 37ms 35ms -6% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 251 +0% —
viewport-pan-sweep: task duration 4275ms 3896ms -9% —
viewport-pan-sweep: script duration 1080ms 984ms -9% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 74.8 MB 78.4 MB +5% —
viewport-pan-sweep: DOM nodes -281 -261 -7% —
viewport-pan-sweep: event listeners -163 -131 -20% —
vue-large-graph-idle: avg frame time 18ms 17ms -3% —
vue-large-graph-idle: p95 frame time 17ms 17ms -0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 16913ms 15697ms -7% —
vue-large-graph-idle: script duration 124ms 99ms -20% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 170.5 MB 168.7 MB -1% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16389 -16387 -0% —
vue-large-graph-pan: avg frame time 18ms 18ms -0% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 18ms 16ms -14% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 170 170 -0% —
vue-large-graph-pan: task duration 20739ms 19269ms -7% —
vue-large-graph-pan: script duration 402ms 392ms -2% —
vue-large-graph-pan: TBT 40ms 26ms -35% —
vue-large-graph-pan: heap used 181.8 MB 177.1 MB -3% —
vue-large-graph-pan: DOM nodes -8312 -8312 +0% —
vue-large-graph-pan: event listeners -16385 -16383 -0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms -0% —
workflow-execution: layout duration 1ms 1ms -11% z=-3.5
workflow-execution: style recalc duration 18ms 13ms -25% z=-5.0
workflow-execution: layout count 3 3 -17% z=-4.5
workflow-execution: style recalc count 8 7 -19% z=-5.5
workflow-execution: task duration 84ms 70ms -17% z=-4.9
workflow-execution: script duration 6ms 6ms -5% z=-7.9
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 60.6 MB 61.0 MB +1% —
workflow-execution: DOM nodes 113 124 +10% z=-5.2
workflow-execution: event listeners 49 25 -49% z=-6.1
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-18T16:47:17.819Z",
  "gitSha": "b97747367bdd0a603254e15d924cd86818a213f7",
  "branch": "test/cloud-auth-coverage-standalone",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2062.0030000000042,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.109,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 503.049,
      "heapDeltaBytes": 19270552,
      "heapUsedBytes": 80419340,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 9.002,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2023.1069999999818,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.129000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.52399999999994,
      "heapDeltaBytes": 14163472,
      "heapUsedBytes": 74772952,
      "domNodes": -281,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 6.312999999999999,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1806.6499999999905,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 32.515,
      "layouts": 12,
      "layoutDurationMs": 3.33,
      "taskDurationMs": 817.4019999999999,
      "heapDeltaBytes": 11499256,
      "heapUsedBytes": 73088944,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 106.42199999999998,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1819.4809999999961,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 33.915,
      "layouts": 12,
      "layoutDurationMs": 3.201,
      "taskDurationMs": 830.096,
      "heapDeltaBytes": 1128456,
      "heapUsedBytes": 61388228,
      "domNodes": -284,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 105.501,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1718.05599999999,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.017,
      "layouts": 6,
      "layoutDurationMs": 0.508,
      "taskDurationMs": 331.80499999999995,
      "heapDeltaBytes": 2666536,
      "heapUsedBytes": 63646188,
      "domNodes": 76,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 8.078,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.1709999999894,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.322,
      "layouts": 6,
      "layoutDurationMs": 0.585,
      "taskDurationMs": 341.59399999999994,
      "heapDeltaBytes": 2464632,
      "heapUsedBytes": 63106664,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 8.273,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 538.6169999999879,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.062999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 349.959,
      "heapDeltaBytes": 10382336,
      "heapUsedBytes": 70756944,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 54.51499999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 551.719999999932,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.496999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 339.159,
      "heapDeltaBytes": 10388140,
      "heapUsedBytes": 70877124,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 52.845,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.6789999999824,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.318000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 589.952,
      "heapDeltaBytes": -11720304,
      "heapUsedBytes": 62537764,
      "domNodes": -280,
      "jsHeapTotalBytes": -528384,
      "scriptDurationMs": 14.684999999999997,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2007.9179999999042,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.728999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.731,
      "heapDeltaBytes": -10071868,
      "heapUsedBytes": 62975928,
      "domNodes": -279,
      "jsHeapTotalBytes": -1839104,
      "scriptDurationMs": 12.749,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2142.480999999975,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 14.021999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1163.24,
      "heapDeltaBytes": 1470816,
      "heapUsedBytes": 76568952,
      "domNodes": -265,
      "jsHeapTotalBytes": -827392,
      "scriptDurationMs": 326.101,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2136.066000000028,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.869000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1180.9450000000002,
      "heapDeltaBytes": 906648,
      "heapUsedBytes": 75606032,
      "domNodes": -236,
      "jsHeapTotalBytes": -303104,
      "scriptDurationMs": 334.506,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3116.585999999984,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.393999999999998,
      "layouts": 60,
      "layoutDurationMs": 6.9479999999999995,
      "taskDurationMs": 1271.733,
      "heapDeltaBytes": 17768800,
      "heapUsedBytes": 93387560,
      "domNodes": 16,
      "jsHeapTotalBytes": 5279744,
      "scriptDurationMs": 378.88500000000005,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3082.431999999926,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 10.468999999999996,
      "layouts": 60,
      "layoutDurationMs": 6.720000000000001,
      "taskDurationMs": 1257.782,
      "heapDeltaBytes": 14810940,
      "heapUsedBytes": 77918884,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 364.235,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2214.3970000000195,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 7.875,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1369.6280000000002,
      "heapDeltaBytes": 2088632,
      "heapUsedBytes": 62948440,
      "domNodes": -275,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 444.427,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2232.610999999906,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1418.331,
      "heapDeltaBytes": -17758616,
      "heapUsedBytes": 64721616,
      "domNodes": -243,
      "jsHeapTotalBytes": 7073792,
      "scriptDurationMs": 448.523,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2068.061,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.882,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 605.6869999999999,
      "heapDeltaBytes": -6884460,
      "heapUsedBytes": 73700204,
      "domNodes": -270,
      "jsHeapTotalBytes": 3211264,
      "scriptDurationMs": 14.102,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2061.9140000000016,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.5,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 589.996,
      "heapDeltaBytes": -5740552,
      "heapUsedBytes": 74959696,
      "domNodes": -269,
      "jsHeapTotalBytes": 5046272,
      "scriptDurationMs": 12.567000000000002,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 559.1779999999744,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 13.838000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 375.748,
      "heapDeltaBytes": 11427952,
      "heapUsedBytes": 71831808,
      "domNodes": 20,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 114.582,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 545.8289999999124,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.720999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 360.016,
      "heapDeltaBytes": 11009112,
      "heapUsedBytes": 71853408,
      "domNodes": 14,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 111.867,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2014.64100000004,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.749999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.51000000000005,
      "heapDeltaBytes": 701596,
      "heapUsedBytes": 61263124,
      "domNodes": -282,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 5.914999999999998,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2039.3229999999676,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.603999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.113,
      "heapDeltaBytes": -298428,
      "heapUsedBytes": 61312416,
      "domNodes": -282,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 5.909000000000001,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1711.2349999999878,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 34.318,
      "layouts": 16,
      "layoutDurationMs": 3.797,
      "taskDurationMs": 791.4460000000001,
      "heapDeltaBytes": 162548,
      "heapUsedBytes": 60780460,
      "domNodes": -278,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 82.85000000000001,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1719.9530000000323,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 33.69,
      "layouts": 16,
      "layoutDurationMs": 4.3309999999999995,
      "taskDurationMs": 751.761,
      "heapDeltaBytes": 115728,
      "heapUsedBytes": 60791040,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 80.061,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.9520000000512,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 31.426999999999996,
      "layouts": 15,
      "layoutDurationMs": 14.435,
      "taskDurationMs": 896.8800000000001,
      "heapDeltaBytes": 20331728,
      "heapUsedBytes": 102275628,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 17.541999999999994,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8156.2300000000505,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 34.708000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3879.8070000000002,
      "heapDeltaBytes": 7306592,
      "heapUsedBytes": 81479032,
      "domNodes": -260,
      "jsHeapTotalBytes": -2138112,
      "scriptDurationMs": 981.2169999999999,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8222.965000000044,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 35.532,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3913.1800000000003,
      "heapDeltaBytes": 8882264,
      "heapUsedBytes": 82847956,
      "domNodes": -262,
      "jsHeapTotalBytes": -1351680,
      "scriptDurationMs": 986.077,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16765.030000000024,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16088.661000000002,
      "heapDeltaBytes": -39757704,
      "heapUsedBytes": 178209684,
      "domNodes": -8312,
      "jsHeapTotalBytes": -12521472,
      "scriptDurationMs": 102.943,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16259.756999999921,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15305.891,
      "heapDeltaBytes": -29452784,
      "heapUsedBytes": 175541216,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13787136,
      "scriptDurationMs": 94.47699999999999,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20165.046000000017,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 16.27400000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19589.974,
      "heapDeltaBytes": -14811168,
      "heapUsedBytes": 193004188,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15212544,
      "scriptDurationMs": 403.05600000000004,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 38,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19395.725999999966,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 15.050000000000036,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18948.958,
      "heapDeltaBytes": -28089628,
      "heapUsedBytes": 178448708,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13594624,
      "scriptDurationMs": 381.903,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 94.11899999997786,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 13.943999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.205,
      "taskDurationMs": 69.945,
      "heapDeltaBytes": 3046644,
      "heapUsedBytes": 63958044,
      "domNodes": 123,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.658,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 98.1649999999945,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 12.445,
      "layouts": 2,
      "layoutDurationMs": 0.8649999999999999,
      "taskDurationMs": 69.43900000000001,
      "heapDeltaBytes": 2983832,
      "heapUsedBytes": 63864516,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.876,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

@github-actions

Copy link
Copy Markdown
Contributor

🎭 Playwright: ⏳ Running...

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@browser_tests/tests/cloudAuthSignIn.spec.ts`:
- Around line 38-68: Move FirebasePasswordSignInResponse,
FirebaseLookupResponse, and FirebaseErrorResponse into a shared test contract
module, then remove their local declarations from cloudAuthSignIn.spec.ts and
authAccountSwitch.spec.ts. Import and reuse the shared types in both test files
so their Firebase REST response assertions validate against one common contract.

In `@src/components/dialog/content/signin/SignUpForm.test.ts`:
- Around line 321-329: Update the test “points the disabled submit button at the
hint” to fill all required fields with valid values while Turnstile is enabled,
then assert the submit button is disabled before verifying its aria-describedby
target. Keep the assertion focused on the user-visible disabled behavior rather
than only the hint attribute.

In `@src/platform/cloud/onboarding/components/CloudTermsNotice.test.ts`:
- Around line 51-63: Extend the link-security assertion in the test to include
the support link message symbol alongside the terms and privacy links. Keep
verifying target="_blank" and rel="noopener noreferrer" for all three links.
- Around line 74-93: Update the test in the “renders every fragment from the
locale, not hard-coded copy” case to assert that the privacy link is rendered as
an anchor using LONG_LOCALE.auth.login.privacyLink. Keep the existing
English-link absence check only if needed, but ensure the translated privacy
link assertion verifies both its localized name and link role.

In `@src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts`:
- Around line 154-169: Update runGuard to accept the parameterized route under
test and construct `to` from that route’s name and path instead of hardcoding
cloud-login values. Preserve strict TypeScript typing for the route and guard
arguments so cloud-signup cases exercise their actual route inputs.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: aa602996-25a4-46eb-9fc5-01b7ad9f482a

📥 Commits

Reviewing files that changed from the base of the PR and between fe834ec and c2d8d99.

📒 Files selected for processing (8)
  • browser_tests/tests/cloudAuthSignIn.spec.ts
  • src/components/dialog/content/signin/SignUpForm.test.ts
  • src/platform/cloud/onboarding/components/CloudSignInForm.test.ts
  • src/platform/cloud/onboarding/components/CloudTermsNotice.test.ts
  • src/platform/cloud/onboarding/composables/usePostAuthRedirect.test.ts
  • src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts
  • src/platform/cloud/onboarding/utils/previousFullPath.test.ts
  • src/schemas/signInSchema.test.ts

@codecov

codecov Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #14987      +/-   ##
==========================================
- Coverage   79.26%   78.81%   -0.45%     
==========================================
  Files        2209     1879     -330     
  Lines      117929   117492     -437     
  Branches    36522    34804    -1718     
==========================================
- Hits        93479    92604     -875     
- Misses      23918    24321     +403     
- Partials      532      567      +35     
Flag Coverage Δ
unit 72.96% <ø> (+0.05%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 878 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The assertion matched any visible error text, so a toast satisfied it just
as well as the inline banner it was written to defend. With that banner
gone the test passes for a different reason than it claims, which is worse
than not having it.

Removes the firebaseError helper and FirebaseErrorResponse type with it,
since nothing else built an error response.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@browser_tests/tests/cloudAuthSignIn.spec.ts`:
- Around line 78-81: Update mockFirebasePasswordSignIn to validate the expected
email and login fields before returning the successful credential, and throw
when a sign-in request fails validation. For non-sign-in identitytoolkit
operations, validate the expected lookup parameters before returning
lookupResponse; throw an explicit error for any unexpected operation or payload
instead of accepting it.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d66314db-a28e-4819-8371-014b6e5c080b

📥 Commits

Reviewing files that changed from the base of the PR and between c2d8d99 and fefb6f7.

📒 Files selected for processing (1)
  • browser_tests/tests/cloudAuthSignIn.spec.ts

Move the comments that explained why an assertion matters into vitest's
expect message argument, so the rationale shows up on failure instead of
drifting beside the code. Delete the rest.

Also from review:
- SignUpForm fills a valid signup before asserting the Turnstile-gated
  button is disabled, so the test fails if the gate is removed
- CloudTermsNotice covers the support link's target/rel and asserts the
  translated privacy link renders as an anchor
- onboardingCloudRoutes builds `to` from the parameterized route, so the
  cloud-signup cases exercise signup inputs rather than login ones
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 10, 2026
CI serves the built frontend from ComfyUI's static handler, which has no SPA
fallback: GET /cloud/login returns 404 with application/octet-stream, and
Playwright reports that as 'Download is starting'. Both remaining tests now
load the app root and let the guard route them.

Drops the ?switchAccount e2e case. It can only be reached by URL, so there is
no in-app path to it, and the guard behaviour is already pinned on both routes
in onboardingCloudRoutes.test.ts.
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 10, 2026
A self-hosted HTTP origin can have credentials intercepted, and nothing
asserted the warning renders there. happy-dom leaves globalThis.isSecureContext
undefined, so the secure case is the one that needed stubbing.

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/platform/cloud/onboarding/CloudLoginView.test.ts`:
- Around line 114-118: Replace the as never cast in the renderLoginView test
setup with a type-safe message fixture. Update renderLoginView’s message
parameter to accept the nested partial shape used by
auth.login.insecureContextWarning, or provide a complete typed FREE_RUN_MESSAGES
fixture, then remove the assertion while preserving the test’s translation
value.
🪄 Autofix

✅ Autofix completed


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c03d31be-7fb8-46d7-bc2c-e9800dca1dfd

📥 Commits

Reviewing files that changed from the base of the PR and between 7d751dd and ac3ec1e.

📒 Files selected for processing (1)
  • src/platform/cloud/onboarding/CloudLoginView.test.ts

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Fixes Applied Successfully

Fixed 1 file(s) based on 1 unresolved review comment.

Files modified:

  • src/platform/cloud/onboarding/CloudLoginView.test.ts

Commit: af22401820ebb8cb8db30689afc3d1d055416fe8

The changes have been pushed to the test/cloud-auth-coverage-standalone branch.

Time taken: 13m 21s

coderabbitai Bot and others added 2 commits August 10, 2026 18:19
Fixed 1 file(s) based on 1 unresolved review comment.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Both cases it drove are already pinned closer to the logic: the deep-link
round trip in usePostAuthRedirect.test.ts, and the signed-in redirect on both
routes in onboardingCloudRoutes.test.ts. The spec added a slower path to the
same assertions.
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 10, 2026
@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

@christian-byrne This is awaiting your review, incase missed.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, can you fix merge conflicts and re-run CI?

useRoute: () => ({ query: query.value })
}))

vi.mock('vue-i18n', () => ({ useI18n: () => ({ t: (key: string) => key }) }))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: (non-blocking) vi.mock('vue-i18n', ...) violates the project convention documented in vitest-patterns.md: "Don't mock vue-i18n -- use a real createI18n plugin. This applies to all tests that touch a composable calling useI18n()." The composable calls useI18n() to build the OAuth error toast summary. The correct pattern for a composable test is a host component with app.use(createI18n({...})). The identity stub t: (key) => key coincides with what an empty createI18n returns, so this is low-risk, but it sets a precedent ESLint can't enforce on composable files.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 99a80af. Swapped the vue-i18n mock for a real createI18n on a host component, following the useMediaAssetActions.test.ts pattern the doc points at. The error-toast test now asserts the real key (oauth.consent.sessionErrorToastSummary) rather than an identity stub.

screen.getByRole('button', { name: LOGIN_COPY.loginButton })

beforeEach(() => {
setActivePinia(createPinia())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: (non-blocking) setActivePinia(createPinia()) violates the convention (createTestingPinia from @pinia/testing) and is also dead code here -- useAuthStore is fully mocked at line 13, so real Pinia never runs. The whole setup block can just be removed.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 99a80af. Removed setActivePinia(createPinia()) and the now-unused pinia import — you're right that it was dead, useAuthStore is mocked outright.

})

describe('usePostAuthRedirect', () => {
it('sends a plain sign-in to the default destination', async () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: The happy-path tests (sends a plain sign-in, returns a deep-linked user, etc.) don't assert that toasts.add was called with severity: 'success'. onAuthSuccess() fires that unconditionally as its first action -- deleting the line in source leaves all tests green.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 99a80af. Added confirms the sign-in with a success toast. Mutation-checked: deleting the toastStore.add success call in the composable fails that test and only that test.

expect(await runGuard(route, {})).toEqual({ name: 'cloud-user-check' })
})

it('sends a signed-in visitor straight to consent mid-OAuth', async () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: (non-blocking) The test verifies the routing target but not the session-cookie side effect: createSessionOrThrow must be called in that path or the consent view fails with an unauthenticated request. The oauthConsentRedirect unit tests (lines 95-108) cover this in isolation, but the guard integration path has no assertion for it -- a regression there would pass guard tests while breaking prod silently.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 99a80af. The guard-integration test sends a signed-in visitor straight to consent mid-OAuth now asserts createSessionOrThrow was called once. Mutation-checked: stubbing out the mint makes it fail on both routes, where before it stayed green.


beforeEach(() => {
query.value = {}
replace.mockReset()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: (non-blocking) Individual mock.mockReset() calls in beforeEach instead of a single vi.resetAllMocks(). Convention per vitest-patterns.md: "vi.resetAllMocks() // Not individual mock.mockReset() calls". Risk: a new mock added later won't be reset automatically.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 99a80af. Dropped the manual resets entirely rather than swapping in vi.resetAllMocks() — vitest-patterns.md notes cleanup is already automatic via the mockReset config, so the only line left in beforeEach is the default resumeOAuthIfNeeded implementation that has to survive that reset.

useSessionCookie: () => ({ createSessionOrThrow })
}))

const loggedIn = vi.hoisted(() => ({ value: false }))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: (non-blocking) loggedIn is a plain POJO { value: false } not a ref. This works today because the guard calls useCurrentUser() fresh on each navigation (dynamic import inside beforeEnter), so loggedIn.value is read at call time. But a reader may assume it's broken -- or "fix" it to ref(loggedIn.value) which would snapshot the initial value and silently break the tests. A short comment explaining why the plain object is intentional would prevent that churn.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved by the merge with main. #15058 landed its own version of this mock with the rationale comment already on it, so the merged file carries the explanation.


const guardedRoutes = ['cloud-login', 'cloud-signup'].map((name) => {
const route = cloudLayout?.children?.find((c) => c.name === name)
if (typeof route?.beforeEnter !== 'function') {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: (non-blocking) typeof route?.beforeEnter !== 'function' doesn't exclude array guards (typeof [] === 'object'). RouteRecordRaw types beforeEnter as NavigationGuard | NavigationGuard[] | undefined, so if this route ever switches to an array form, runGuard silently throws at runtime instead of failing at setup time. Adding || Array.isArray(route?.beforeEnter) to the throw condition makes the check airtight.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 99a80af. Added || Array.isArray(route.beforeEnter) and reworded the throw to "has no single beforeEnter guard".

…age-standalone

# Conflicts:
#	src/platform/cloud/onboarding/CloudLoginView.test.ts
#	src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts
Use a real createI18n host component instead of mocking vue-i18n, drop the
dead Pinia setup and the redundant manual mock resets, assert the success
toast and the consent-path session cookie, and reject array beforeEnter
guards at setup time.
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 17, 2026
typeof [] is 'object', so the array clause sat behind a typeof check that
already rejected it and could never run. Check the array shape first, with
its own message.
@MaanilVerma
MaanilVerma enabled auto-merge August 18, 2026 16:35
@MaanilVerma
MaanilVerma added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit 3e1b0d2 Aug 18, 2026
68 of 69 checks passed
@MaanilVerma
MaanilVerma deleted the test/cloud-auth-coverage-standalone branch August 18, 2026 17:04
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants