Repository navigation
fix(billing): resolve terminal promise even if success side effects throw - #14964
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe billing success handler now reports post-success processing errors and resolves terminal operations even when toast rendering or subscription reconciliation throws. Tests cover both failure paths. ChangesBilling success handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Merge Risk: 🔵 Low · up to The change ensures billing operations still settle when success UI or toast side effects fail, but those failures are reported through a non-standard path that may reduce consistent telemetry and operation context. The PR is mergeable with explicit owner follow-up to use the repository’s required error-reporting helper. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list is available and shows only two files under ✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1963 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip 🔴 +229 kBDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • 🔴 +761 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +7.87 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 622 kB (baseline 621 kB) • 🔴 +972 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 26.2 kB (baseline 27.8 kB) • 🟢 -1.62 kBAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 3 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🟢 -5 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 118 kB (baseline 117 kB) • 🔴 +620 BReusable component library chunks
Status: 15 added / 15 removed Data & Services — 3.71 MB (baseline 3.6 MB) • 🔴 +107 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 560 kB (baseline 559 kB) • 🔴 +1.35 kBHelpers, composables, and utility bundles
Status: 29 added / 28 removed / 8 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.1 MB) • 🔴 +137 kBExternal libraries and shared vendor chunks
Status: 9 added / 9 removed / 9 unchanged Other — 17.1 MB (baseline 16.4 MB) • 🔴 +683 kBBundles that do not match a named category
Status: 171 added / 171 removed / 125 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-11T09:34:50.868Z",
"gitSha": "8bcdaa719ba3f1c464f66050e8aa75b75fd9f160",
"branch": "test/billing-op-store-coverage",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.3280000000295,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.206999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.952,
"heapDeltaBytes": 14406860,
"heapUsedBytes": 76355336,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.299999999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2006.9780000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.958999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.35299999999995,
"heapDeltaBytes": 1285960,
"heapUsedBytes": 63443340,
"domNodes": -263,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.798,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1992.3620000000142,
"styleRecalcs": 81,
"styleRecalcDurationMs": 34.849,
"layouts": 14,
"layoutDurationMs": 5.7299999999999995,
"taskDurationMs": 956.5630000000001,
"heapDeltaBytes": 18630992,
"heapUsedBytes": 79870432,
"domNodes": -266,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 167.778,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1863.145999999972,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.232999999999993,
"layouts": 14,
"layoutDurationMs": 4.445,
"taskDurationMs": 871.0959999999999,
"heapDeltaBytes": 7346160,
"heapUsedBytes": 69605052,
"domNodes": -263,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 157.20299999999997,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.7539999999813,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.614,
"layouts": 6,
"layoutDurationMs": 1.2520000000000002,
"taskDurationMs": 335.914,
"heapDeltaBytes": 2166724,
"heapUsedBytes": 64369788,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.755999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.58500000001,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.948999999999998,
"layouts": 6,
"layoutDurationMs": 1.1900000000000002,
"taskDurationMs": 335.40700000000004,
"heapDeltaBytes": 2084460,
"heapUsedBytes": 64334708,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.979,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 657.5629999999819,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.954,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.86400000000003,
"heapDeltaBytes": 18075676,
"heapUsedBytes": 80302284,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 155.424,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 648.6360000000104,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.078000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.45,
"heapDeltaBytes": 17836552,
"heapUsedBytes": 79883956,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 161.223,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2055.0269999999955,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.177000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.7150000000001,
"heapDeltaBytes": 2723540,
"heapUsedBytes": 82411940,
"domNodes": -250,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 33.652,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.6189999999924,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.490000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.533,
"heapDeltaBytes": 3036956,
"heapUsedBytes": 82893136,
"domNodes": -249,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 33.766000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2320.789999999988,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.674999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1691.554,
"heapDeltaBytes": -12420976,
"heapUsedBytes": 67471836,
"domNodes": -226,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 864.8820000000001,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2347.278000000074,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.948999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1673.6709999999998,
"heapDeltaBytes": -852912,
"heapUsedBytes": 79813352,
"domNodes": -248,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 860.347,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3602.8590000000236,
"styleRecalcs": 63,
"styleRecalcDurationMs": 16.522000000000002,
"layouts": 60,
"layoutDurationMs": 13.180000000000001,
"taskDurationMs": 1739.8799999999999,
"heapDeltaBytes": -6260828,
"heapUsedBytes": 74748972,
"domNodes": -256,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 796.6659999999999,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3553.538000000003,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.092,
"layouts": 60,
"layoutDurationMs": 13.876,
"taskDurationMs": 1675.0069999999998,
"heapDeltaBytes": 8722000,
"heapUsedBytes": 74716220,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 787.201,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3181.0409999999933,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.573000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2024.8850000000002,
"heapDeltaBytes": -7953612,
"heapUsedBytes": 82464688,
"domNodes": -234,
"jsHeapTotalBytes": 1495040,
"scriptDurationMs": 1028.252,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3143.0840000000444,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.787000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1949.083,
"heapDeltaBytes": 20500224,
"heapUsedBytes": 86492732,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1016.001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2007.2209999999586,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.4939999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.0150000000001,
"heapDeltaBytes": 19638304,
"heapUsedBytes": 83890520,
"domNodes": -257,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.381,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.07199999997,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.2840000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.4669999999999,
"heapDeltaBytes": 19732092,
"heapUsedBytes": 84380176,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.155,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.7040000000038,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.039,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.72499999999997,
"heapDeltaBytes": 14069960,
"heapUsedBytes": 77247212,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 149.624,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.8099999999722,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.632,
"heapDeltaBytes": 13736024,
"heapUsedBytes": 76441064,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 148.672,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.0150000000008,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.838000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.98300000000006,
"heapDeltaBytes": 10388464,
"heapUsedBytes": 73624696,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.935000000000001,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.7539999999917,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.273,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.621,
"heapDeltaBytes": 17315576,
"heapUsedBytes": 80536268,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.143,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.9090000000297,
"styleRecalcs": 79,
"styleRecalcDurationMs": 26.492,
"layouts": 18,
"layoutDurationMs": 4.947,
"taskDurationMs": 760.6959999999999,
"heapDeltaBytes": 6887784,
"heapUsedBytes": 70192496,
"domNodes": -272,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 98.858,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.3719999999075,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.478,
"layouts": 18,
"layoutDurationMs": 5.114,
"taskDurationMs": 775.816,
"heapDeltaBytes": -1252428,
"heapUsedBytes": 62087676,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 101.241,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1350.8850000000052,
"styleRecalcs": 16,
"styleRecalcDurationMs": 27.865000000000002,
"layouts": 5,
"layoutDurationMs": 11.727000000000002,
"taskDurationMs": 861.863,
"heapDeltaBytes": 19678000,
"heapUsedBytes": 101464804,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.698999999999998,
"eventListeners": 2387,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8290.83300000002,
"styleRecalcs": 247,
"styleRecalcDurationMs": 40.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5781.085,
"heapDeltaBytes": -12588780,
"heapUsedBytes": 67142264,
"domNodes": -249,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 2721.7789999999995,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8534.348000000024,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.545,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6041.018,
"heapDeltaBytes": 19870532,
"heapUsedBytes": 98354180,
"domNodes": -259,
"jsHeapTotalBytes": 2052096,
"scriptDurationMs": 2943.644,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17706.073000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17524.449,
"heapDeltaBytes": -34091740,
"heapUsedBytes": 174571292,
"domNodes": -6542,
"jsHeapTotalBytes": 1327104,
"scriptDurationMs": 303.214,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18164.822000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17498.373,
"heapDeltaBytes": -19123948,
"heapUsedBytes": 187737672,
"domNodes": -6542,
"jsHeapTotalBytes": 1241088,
"scriptDurationMs": 307.49000000000007,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21769.39900000002,
"styleRecalcs": 166,
"styleRecalcDurationMs": 20.06800000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21502.216,
"heapDeltaBytes": -37032664,
"heapUsedBytes": 163570808,
"domNodes": -6542,
"jsHeapTotalBytes": -2990080,
"scriptDurationMs": 962.6170000000001,
"eventListeners": -7476,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22696.943000000032,
"styleRecalcs": 169,
"styleRecalcDurationMs": 22.71899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22524.898999999998,
"heapDeltaBytes": -41131440,
"heapUsedBytes": 163860704,
"domNodes": -6542,
"jsHeapTotalBytes": -1888256,
"scriptDurationMs": 1028.692,
"eventListeners": -7476,
"totalBlockingTimeMs": 94,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-node-resize-workload",
"durationMs": 4989.955000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.91700000000002,
"layouts": 20,
"layoutDurationMs": 25.354000000000003,
"taskDurationMs": 4902.907,
"heapDeltaBytes": -17270612,
"heapUsedBytes": 176893372,
"domNodes": -6542,
"jsHeapTotalBytes": 24616960,
"scriptDurationMs": 100.402,
"eventListeners": -7478,
"totalBlockingTimeMs": 148,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6397.186000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 90.39,
"layouts": 20,
"layoutDurationMs": 32.641000000000005,
"taskDurationMs": 6372.802,
"heapDeltaBytes": -22865664,
"heapUsedBytes": 178894660,
"domNodes": -6542,
"jsHeapTotalBytes": 15745024,
"scriptDurationMs": 125.85499999999999,
"eventListeners": -7476,
"totalBlockingTimeMs": 436,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9000.536000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8749.984,
"heapDeltaBytes": 5884484,
"heapUsedBytes": 189928236,
"domNodes": 0,
"jsHeapTotalBytes": -2097152,
"scriptDurationMs": 143.32600000000008,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9098.74000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8693.121000000001,
"heapDeltaBytes": 865364,
"heapUsedBytes": 178695280,
"domNodes": 0,
"jsHeapTotalBytes": -4718592,
"scriptDurationMs": 173.57700000000008,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 483.2569999999805,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.415000000000003,
"layouts": 5,
"layoutDurationMs": 2.6580000000000004,
"taskDurationMs": 143.062,
"heapDeltaBytes": 5187988,
"heapUsedBytes": 66923440,
"domNodes": 151,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 15.235999999999999,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 112.13299999997162,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.445,
"layouts": 2,
"layoutDurationMs": 0.5640000000000001,
"taskDurationMs": 75.138,
"heapDeltaBytes": 3003548,
"heapUsedBytes": 64841096,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.127000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14964 +/- ##
==========================================
+ Coverage 82.40% 83.46% +1.05%
==========================================
Files 2673 2095 -578
Lines 134519 121757 -12762
Branches 36999 34798 -2201
==========================================
- Hits 110856 101624 -9232
+ Misses 22746 19954 -2792
+ Partials 917 179 -738
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 586 files with indirect coverage changes 🚀 New features to boost your workflow:
|
2bbb3af to
e3442d9
Compare
dante01yoon
left a comment
There was a problem hiding this comment.
The change correctly prevents the terminal promise from hanging when the dialog/toast success effects throw. The regression test covers the reported failure path. I left one non-blocking suggestion about broadening the guarantee to the other post-success effects.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/workspace/stores/billingOperationStore.ts`:
- Around line 416-441: Move the existing try/finally boundary in the terminal
operation flow to immediately follow updateOperationStatus, enclosing cleanup,
telemetry, reconciliation, and the current success handling so
resolveTerminal(opId) always executes. Add a regression test that makes a
reconciliation method throw synchronously and verifies the terminal promise
still resolves.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: effeceb8-512f-4b0c-b879-0b5803bbb825
📒 Files selected for processing (2)
src/platform/workspace/stores/billingOperationStore.test.tssrc/platform/workspace/stores/billingOperationStore.ts
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/workspace/stores/billingOperationStore.ts`:
- Around line 408-416: Update the success-side effects around
billingContext.reconcileSubscriptionSuccess, fetchStatus, and fetchBalance to
catch and log any rejected error before preserving the existing propagation or
return behavior. Keep the finally-based resolveTerminal flow unchanged, and use
the store’s existing logging mechanism.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 698f6984-e300-4643-9327-e4f2a7af1e1f
📒 Files selected for processing (2)
src/platform/workspace/stores/billingOperationStore.test.tssrc/platform/workspace/stores/billingOperationStore.ts
|
Verified the current state — the |
|
Heads up — this now has a merge conflict against |
Addresses review feedback: #14964 (comment)
Addresses review feedback: #14964 (comment)
…hrow A thrown error in the success-path side-effects block (dialog close, settings show, or toast add) silently skips resolveTerminal, leaving any caller awaiting startOperation() hanging forever. poll()'s catch-all swallowed the exception, masking the hang. Adds a try/finally so resolveTerminal runs unconditionally after the success side-effects block. Adds a regression test that throws from the second mockToastAdd call and asserts the terminal promise still resolves to succeeded. Found in the review of #14421.
The cancel path's updateActiveWorkspace call and dialog/toast calls are now all guarded by the same try/finally, so resolveTerminal fires even if any synchronous side effect throws.
…ciliation resolveTerminal now fires even if any synchronous side effect in handleSuccess throws — including cleanup, telemetry dispatches, billing context reconciliation, or the cancel workspace update. Adds a regression test verifying the terminal promise resolves when reconcileSubscriptionSuccess throws synchronously.
Addresses review feedback: #14964 (comment)
…pendent toast test
- captureException(error, {tags, extra}) instead of console.error, matching
the sibling useWorkspaceBilling.ts convention.
- Test targets the toast mock by severity instead of call order, so it
still catches the right failure if a third toast.add call is introduced.
Addresses #14964 (comment)
Addresses #14964 (comment)
Addresses review feedback: #14964 (comment)
Addresses review feedback: #14964 (comment)
fc3464c to
6f7ea6c
Compare
|
AI co-author trailers removed. Exact-head CI green. Full context for agent readers
|
Resolve billingOperationStore.test.ts conflict: keep main's vi.mock(import()) form and its real-store toast spies, keep the reportError mock this branch adds.
main's src/AGENTS.md now specifies <category>_<operation>_<subject> with the operation as a present participle, matching failure_initializing_workspace_auth_gate and failure_loading_node_templates. billing_success_handling_failed predated that section and has never shipped, so rename it rather than add a synonym. Addresses review feedback: #14964 (comment)
dante01yoon
left a comment
There was a problem hiding this comment.
Approving. Both of my earlier threads are resolved on dabc3c9, and I checked them against the code rather than taking the replies at face value:
- The call at L790 is
reportError(error, { errorType: 'failure_handling_billing_operation_success', context: { billing_op_id: opId } }),@sentry/vueis gone from the imports, andreportErrorRestrictionsineslint.config.tsdoes bancaptureExceptionon this path. The raw-captureExceptionblocker is genuinely gone. - The
tryboundary is exactly as you enumerated: it opens atcleanup(opId)(L676), immediately after thesucceededstatus write, and closes aftertoastStore.add(L788), withfinally { resolveTerminal(opId) }at L795-796. KeepingupdateOperationStatusoutside the block is the right call, sinceresolveTerminalresolves with whatever the operation map holds at that moment.
The bug is real rather than defensive coding. On main, resolveTerminal(opId) is the last statement of handleSuccess, and pollOnce's bare catch discards the propagated error once the identity guard fails, so any synchronous throw in the post-success block strands every caller awaiting startOperation() permanently. useWorkspaceBilling.ts L449 and L510 both await that promise before they check status !== 'succeeded', so this is a real hang and not a theoretical one.
git diff -w against main shows the guarded body is unchanged apart from indentation plus the removed resolveTerminal(opId) in the cancel early return, which the finally now covers. That was the thing I wanted to confirm before approving a change that reads as ~100 rewritten lines.
Validation: every check is green on dabc3c9 (Playwright shards, ecosystem matrix, codecov patch). I could not run the focused vitest slice locally — this sandbox has Node 25.9.0 and the repo requires >=26.8.2, so vitest.timer.setup.ts fails on localStorage.clear() before any test body executes. I read the three new tests closely instead and relied on CI for execution.
Three non-blocking notes inline; none of them need to hold the merge.
| const telemetry = useTelemetry() | ||
| const now = Date.now() | ||
| const operationDurationMs = now - operation.operationStartedAt | ||
| telemetry?.trackBillingEvent({ |
There was a problem hiding this comment.
suggestion (non-blocking): one try guarantees the promise, but it does not isolate the effects from each other — the first thrower still skips every effect after it.
telemetry?.trackBillingEvent() is the most plausible synchronous thrower in this block, since useTelemetry() fans out to whatever providers happen to be registered. A throw here skips the billingContext.fetchStatus() / fetchBalance() / capabilities.refresh() refreshes at L751-L763 and the success toast at L784, so the caller gets a resolved succeeded operation while the plan and credit balance rendered in the UI stay stale and no success toast ever appears.
This is not a regression — main skips the same effects, it just also hangs — so it should not block the PR. But if the property you want is "an authoritative success is always fully applied", the telemetry calls are the cheapest thing to move into their own guard, since nothing downstream of them depends on them.
| errorType: 'failure_handling_billing_operation_success', | ||
| context: { billing_op_id: opId } | ||
| }) | ||
| throw error |
There was a problem hiding this comment.
nit-pick (non-blocking): worth a one-line comment saying this rethrow is deliberately inert.
pollOnce()'s bare catch is its only consumer, and that handler returns immediately because updateOperationStatus replaced the operation object, so this throw neither surfaces the failure nor reschedules a poll — the reportError() above it is the only sink. Your PR description explains this well, but the description is not where the next reader will be when they wonder whether removing the rethrow changes anything.
|
|
||
| await vi.advanceTimersByTimeAsync(0) | ||
|
|
||
| await expect(terminal).resolves.toMatchObject({ status: 'succeeded' }) |
There was a problem hiding this comment.
suggestion (non-blocking): could this case assert mockReportError too?
Its two siblings above pin both halves of the new contract (terminal resolution and the report), and this is the case where a silent regression is easiest to introduce. The throw only reaches the catch because it happens while the arguments to Promise.allSettled are being evaluated; if reconcileSubscriptionSuccess ever becomes a rejected promise instead of a synchronous throw, allSettled swallows it, the terminal promise still resolves succeeded, and this test keeps passing while the reporting path is no longer exercised at all.
…hrow (#14964) - Guarantees terminal resolution after the operation is marked `succeeded`, even if any later cleanup, telemetry, reconciliation, workspace update, dialog, or toast effect throws. - Reports post-success failures through the shared `reportError()` path while preserving the original error and unconditional terminal resolution. - Adds regressions for failures at both ends of the protected block: cleanup and the success toast. The `try` in `handleSuccess()` opens at `cleanup(opId)` and runs to the success toast, so `finally { resolveTerminal(opId) }` covers every post-status effect: `cleanup()`, the `useTelemetry()` lookup and all four `trackBillingEvent` calls, `trackMonthlySubscriptionSucceeded`, the `useBillingContext()` / `useBillingCapabilities()` lookups and their `Promise.allSettled` refreshes, the `cancel` early return, `closeDialog` / `settingsDialog.show`, and `toastStore.add`. `updateOperationStatus(opId, 'succeeded', null)` stays outside deliberately: `resolveTerminal()` resolves with whatever the operation map holds, so the status write has to land before anything can reach the `finally`. `resolveTerminal(opId)` originally ran after the post-status success effects. A synchronous throw from any effect could skip it, leaving callers awaiting `startOperation()` indefinitely. `pollOnce()`'s bare `catch` then discards the rethrown error — by that point `operations.value.get(opId)` is the replaced `succeeded` entry, so the identity guard returns early and nothing is rescheduled or surfaced. The `reportError()` call is the only signal that the failure happened, which is why it has to reach both sinks. The operation has already reached its authoritative `succeeded` status before this block runs. Therefore callers still receive the successful terminal result when a later side effect fails; `reportError()` records the partial-success failure for both configured telemetry sinks under `errorType: 'failure_handling_billing_operation_success'`. PR #14421's broader implementation was absorbed by billing changes already on `main`. This PR retains its remaining terminal-resolution fix and regression coverage. - [x] `pnpm vitest run src/platform/workspace/stores/billingOperationStore.test.ts` - 106 passed - [x] `pnpm typecheck` - [x] `pnpm exec eslint src/platform/workspace/stores/billingOperationStore.ts src/platform/workspace/stores/billingOperationStore.test.ts` --------- Co-authored-by: GitHub Action <action@github.com>
…hrow (#14964) - Guarantees terminal resolution after the operation is marked `succeeded`, even if any later cleanup, telemetry, reconciliation, workspace update, dialog, or toast effect throws. - Reports post-success failures through the shared `reportError()` path while preserving the original error and unconditional terminal resolution. - Adds regressions for failures at both ends of the protected block: cleanup and the success toast. The `try` in `handleSuccess()` opens at `cleanup(opId)` and runs to the success toast, so `finally { resolveTerminal(opId) }` covers every post-status effect: `cleanup()`, the `useTelemetry()` lookup and all four `trackBillingEvent` calls, `trackMonthlySubscriptionSucceeded`, the `useBillingContext()` / `useBillingCapabilities()` lookups and their `Promise.allSettled` refreshes, the `cancel` early return, `closeDialog` / `settingsDialog.show`, and `toastStore.add`. `updateOperationStatus(opId, 'succeeded', null)` stays outside deliberately: `resolveTerminal()` resolves with whatever the operation map holds, so the status write has to land before anything can reach the `finally`. `resolveTerminal(opId)` originally ran after the post-status success effects. A synchronous throw from any effect could skip it, leaving callers awaiting `startOperation()` indefinitely. `pollOnce()`'s bare `catch` then discards the rethrown error — by that point `operations.value.get(opId)` is the replaced `succeeded` entry, so the identity guard returns early and nothing is rescheduled or surfaced. The `reportError()` call is the only signal that the failure happened, which is why it has to reach both sinks. The operation has already reached its authoritative `succeeded` status before this block runs. Therefore callers still receive the successful terminal result when a later side effect fails; `reportError()` records the partial-success failure for both configured telemetry sinks under `errorType: 'failure_handling_billing_operation_success'`. PR #14421's broader implementation was absorbed by billing changes already on `main`. This PR retains its remaining terminal-resolution fix and regression coverage. - [x] `pnpm vitest run src/platform/workspace/stores/billingOperationStore.test.ts` - 106 passed - [x] `pnpm typecheck` - [x] `pnpm exec eslint src/platform/workspace/stores/billingOperationStore.ts src/platform/workspace/stores/billingOperationStore.test.ts` --------- Co-authored-by: GitHub Action <action@github.com>
…hrow (#14964) - Guarantees terminal resolution after the operation is marked `succeeded`, even if any later cleanup, telemetry, reconciliation, workspace update, dialog, or toast effect throws. - Reports post-success failures through the shared `reportError()` path while preserving the original error and unconditional terminal resolution. - Adds regressions for failures at both ends of the protected block: cleanup and the success toast. The `try` in `handleSuccess()` opens at `cleanup(opId)` and runs to the success toast, so `finally { resolveTerminal(opId) }` covers every post-status effect: `cleanup()`, the `useTelemetry()` lookup and all four `trackBillingEvent` calls, `trackMonthlySubscriptionSucceeded`, the `useBillingContext()` / `useBillingCapabilities()` lookups and their `Promise.allSettled` refreshes, the `cancel` early return, `closeDialog` / `settingsDialog.show`, and `toastStore.add`. `updateOperationStatus(opId, 'succeeded', null)` stays outside deliberately: `resolveTerminal()` resolves with whatever the operation map holds, so the status write has to land before anything can reach the `finally`. `resolveTerminal(opId)` originally ran after the post-status success effects. A synchronous throw from any effect could skip it, leaving callers awaiting `startOperation()` indefinitely. `pollOnce()`'s bare `catch` then discards the rethrown error — by that point `operations.value.get(opId)` is the replaced `succeeded` entry, so the identity guard returns early and nothing is rescheduled or surfaced. The `reportError()` call is the only signal that the failure happened, which is why it has to reach both sinks. The operation has already reached its authoritative `succeeded` status before this block runs. Therefore callers still receive the successful terminal result when a later side effect fails; `reportError()` records the partial-success failure for both configured telemetry sinks under `errorType: 'failure_handling_billing_operation_success'`. PR #14421's broader implementation was absorbed by billing changes already on `main`. This PR retains its remaining terminal-resolution fix and regression coverage. - [x] `pnpm vitest run src/platform/workspace/stores/billingOperationStore.test.ts` - 106 passed - [x] `pnpm typecheck` - [x] `pnpm exec eslint src/platform/workspace/stores/billingOperationStore.ts src/platform/workspace/stores/billingOperationStore.test.ts` --------- Co-authored-by: GitHub Action <action@github.com>
…hrow (#14964) - Guarantees terminal resolution after the operation is marked `succeeded`, even if any later cleanup, telemetry, reconciliation, workspace update, dialog, or toast effect throws. - Reports post-success failures through the shared `reportError()` path while preserving the original error and unconditional terminal resolution. - Adds regressions for failures at both ends of the protected block: cleanup and the success toast. The `try` in `handleSuccess()` opens at `cleanup(opId)` and runs to the success toast, so `finally { resolveTerminal(opId) }` covers every post-status effect: `cleanup()`, the `useTelemetry()` lookup and all four `trackBillingEvent` calls, `trackMonthlySubscriptionSucceeded`, the `useBillingContext()` / `useBillingCapabilities()` lookups and their `Promise.allSettled` refreshes, the `cancel` early return, `closeDialog` / `settingsDialog.show`, and `toastStore.add`. `updateOperationStatus(opId, 'succeeded', null)` stays outside deliberately: `resolveTerminal()` resolves with whatever the operation map holds, so the status write has to land before anything can reach the `finally`. `resolveTerminal(opId)` originally ran after the post-status success effects. A synchronous throw from any effect could skip it, leaving callers awaiting `startOperation()` indefinitely. `pollOnce()`'s bare `catch` then discards the rethrown error — by that point `operations.value.get(opId)` is the replaced `succeeded` entry, so the identity guard returns early and nothing is rescheduled or surfaced. The `reportError()` call is the only signal that the failure happened, which is why it has to reach both sinks. The operation has already reached its authoritative `succeeded` status before this block runs. Therefore callers still receive the successful terminal result when a later side effect fails; `reportError()` records the partial-success failure for both configured telemetry sinks under `errorType: 'failure_handling_billing_operation_success'`. PR #14421's broader implementation was absorbed by billing changes already on `main`. This PR retains its remaining terminal-resolution fix and regression coverage. - [x] `pnpm vitest run src/platform/workspace/stores/billingOperationStore.test.ts` - 106 passed - [x] `pnpm typecheck` - [x] `pnpm exec eslint src/platform/workspace/stores/billingOperationStore.ts src/platform/workspace/stores/billingOperationStore.test.ts` --------- Co-authored-by: GitHub Action <action@github.com>
|
Follow-up opened: #18576 (telemetry isolation, inert-rethrow note, reportError assertion). Full context for agent readers#18576 covers the three post-merge review threads on this PR: telemetry try/catch, inert rethrow comment, and reportError assertion. Assigned to dante01yoon as the original reviewer. |
Summary
succeeded, even if any later cleanup, telemetry, reconciliation, workspace update, dialog, or toast effect throws.reportError()path while preserving the original error and unconditional terminal resolution.Scope of the guarded block
The
tryinhandleSuccess()opens atcleanup(opId)and runs to the success toast, sofinally { resolveTerminal(opId) }covers every post-status effect:cleanup(), theuseTelemetry()lookup and all fourtrackBillingEventcalls,trackMonthlySubscriptionSucceeded, theuseBillingContext()/useBillingCapabilities()lookups and theirPromise.allSettledrefreshes, thecancelearly return,closeDialog/settingsDialog.show, andtoastStore.add.updateOperationStatus(opId, 'succeeded', null)stays outside deliberately:resolveTerminal()resolves with whatever the operation map holds, so the status write has to land before anything can reach thefinally.Root cause
resolveTerminal(opId)originally ran after the post-status success effects. A synchronous throw from any effect could skip it, leaving callers awaitingstartOperation()indefinitely.pollOnce()'s barecatchthen discards the rethrown error — by that pointoperations.value.get(opId)is the replacedsucceededentry, so the identity guard returns early and nothing is rescheduled or surfaced. ThereportError()call is the only signal that the failure happened, which is why it has to reach both sinks.The operation has already reached its authoritative
succeededstatus before this block runs. Therefore callers still receive the successful terminal result when a later side effect fails;reportError()records the partial-success failure for both configured telemetry sinks undererrorType: 'failure_handling_billing_operation_success'.Relationship to #14421
PR #14421's broader implementation was absorbed by billing changes already on
main. This PR retains its remaining terminal-resolution fix and regression coverage.Test plan
pnpm vitest run src/platform/workspace/stores/billingOperationStore.test.ts- 106 passedpnpm typecheckpnpm exec eslint src/platform/workspace/stores/billingOperationStore.ts src/platform/workspace/stores/billingOperationStore.test.ts