Repository navigation
test(billing): cover workspace Activity usage feed - #14813
dante01yoon wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1786 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-26T10:18:35.554Z",
"gitSha": "5b3c8a563a7eed425861eb5c35ad94703690c0a2",
"branch": "dante/workspace-activity-api-e2e-v2",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2105.415999999991,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.209,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.123,
"heapDeltaBytes": 5347552,
"heapUsedBytes": 69382900,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 18.307000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2020.988999999986,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.091999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.123,
"heapDeltaBytes": 5390044,
"heapUsedBytes": 69521836,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 23.526000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1984.482000000014,
"styleRecalcs": 80,
"styleRecalcDurationMs": 45.814,
"layouts": 12,
"layoutDurationMs": 3.6710000000000003,
"taskDurationMs": 963.899,
"heapDeltaBytes": 379332,
"heapUsedBytes": 64415428,
"domNodes": 63,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 124.422,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.147999999987,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.476,
"layouts": 12,
"layoutDurationMs": 4.26,
"taskDurationMs": 908.3810000000001,
"heapDeltaBytes": -13764208,
"heapUsedBytes": 50463156,
"domNodes": -281,
"jsHeapTotalBytes": 25145344,
"scriptDurationMs": 118.665,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.699999999989,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.744000000000002,
"layouts": 6,
"layoutDurationMs": 0.573,
"taskDurationMs": 368.891,
"heapDeltaBytes": 8619364,
"heapUsedBytes": 72834724,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 18.512999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.3830000000362,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.030000000000001,
"layouts": 6,
"layoutDurationMs": 0.559,
"taskDurationMs": 372.093,
"heapDeltaBytes": 8604244,
"heapUsedBytes": 72689432,
"domNodes": 78,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 18.212,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 571.489999999983,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.542,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.22,
"heapDeltaBytes": -10920120,
"heapUsedBytes": 53181220,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 55.970000000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 627.3199999999974,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.597999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.8059999999999,
"heapDeltaBytes": -11064448,
"heapUsedBytes": 53023664,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 60.70399999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.7769999999819,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.475999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.965,
"heapDeltaBytes": 6828036,
"heapUsedBytes": 67117840,
"domNodes": -279,
"jsHeapTotalBytes": 4038656,
"scriptDurationMs": 96.92300000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2033.5890000000063,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.941,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 785.9950000000001,
"heapDeltaBytes": 7328000,
"heapUsedBytes": 67166672,
"domNodes": -283,
"jsHeapTotalBytes": 4038656,
"scriptDurationMs": 112.432,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2139.4900000000234,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.961000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1222.0500000000002,
"heapDeltaBytes": 1593208,
"heapUsedBytes": 61987172,
"domNodes": -283,
"jsHeapTotalBytes": 3706880,
"scriptDurationMs": 386.70500000000004,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2160.7179999999744,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.108,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1285.565,
"heapDeltaBytes": 4999812,
"heapUsedBytes": 65576600,
"domNodes": -284,
"jsHeapTotalBytes": 3706880,
"scriptDurationMs": 419.974,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3231.7880000000514,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.447999999999997,
"layouts": 60,
"layoutDurationMs": 7.819,
"taskDurationMs": 1509.153,
"heapDeltaBytes": 188452,
"heapUsedBytes": 62296044,
"domNodes": -287,
"jsHeapTotalBytes": 5611520,
"scriptDurationMs": 522.756,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3214.4329999999854,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.767000000000003,
"layouts": 60,
"layoutDurationMs": 8.118,
"taskDurationMs": 1494.69,
"heapDeltaBytes": -1335068,
"heapUsedBytes": 61328056,
"domNodes": -289,
"jsHeapTotalBytes": 6922240,
"scriptDurationMs": 521.343,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2065.5249999999796,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.021000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 696.8709999999999,
"heapDeltaBytes": 6802148,
"heapUsedBytes": 68032164,
"domNodes": -285,
"jsHeapTotalBytes": 2990080,
"scriptDurationMs": 102.918,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.7060000000001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.857000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 766.677,
"heapDeltaBytes": 6696488,
"heapUsedBytes": 67340812,
"domNodes": -281,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 118.252,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.0919999999892,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.848999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.961,
"heapDeltaBytes": -10774808,
"heapUsedBytes": 53330660,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 126.957,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.121000000021,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.702000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.853,
"heapDeltaBytes": -10558420,
"heapUsedBytes": 53783832,
"domNodes": 22,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 127.53899999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.561999999988,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.933999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.327,
"heapDeltaBytes": 4928752,
"heapUsedBytes": 69208460,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 13.671999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2002.0410000000197,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.491999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.50699999999995,
"heapDeltaBytes": 5414448,
"heapUsedBytes": 69683836,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 14.208000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.909000000015,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.30499999999999,
"layouts": 16,
"layoutDurationMs": 4.355,
"taskDurationMs": 789.682,
"heapDeltaBytes": -17027136,
"heapUsedBytes": 47169536,
"domNodes": -280,
"jsHeapTotalBytes": 23048192,
"scriptDurationMs": 85.73899999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.1609999999237,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.394999999999996,
"layouts": 16,
"layoutDurationMs": 4.691000000000001,
"taskDurationMs": 795.876,
"heapDeltaBytes": -4067812,
"heapUsedBytes": 60314184,
"domNodes": 60,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 97.37799999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.434000000003,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.518,
"layouts": 14,
"layoutDurationMs": 10.931,
"taskDurationMs": 916.4949999999999,
"heapDeltaBytes": 30727448,
"heapUsedBytes": 100919376,
"domNodes": 13673,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 32.98699999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 131,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8213.64699999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.452999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4341.576000000001,
"heapDeltaBytes": 5517916,
"heapUsedBytes": 64906468,
"domNodes": -282,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 1310.056,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8253.039000000059,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4409.798,
"heapDeltaBytes": 11551464,
"heapUsedBytes": 71089604,
"domNodes": -282,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 1326.0819999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18083.51299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18065.286999999997,
"heapDeltaBytes": -33861720,
"heapUsedBytes": 171041852,
"domNodes": -8312,
"jsHeapTotalBytes": -3088384,
"scriptDurationMs": 579.037,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18224.23200000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18208.517999999996,
"heapDeltaBytes": -44393508,
"heapUsedBytes": 167152664,
"domNodes": -8312,
"jsHeapTotalBytes": -8560640,
"scriptDurationMs": 573.592,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21834.789999999997,
"styleRecalcs": 152,
"styleRecalcDurationMs": 21.459000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21797.757,
"heapDeltaBytes": -60205988,
"heapUsedBytes": 167845652,
"domNodes": -8312,
"jsHeapTotalBytes": -6758400,
"scriptDurationMs": 938.3179999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 462,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21765.445999999996,
"styleRecalcs": 154,
"styleRecalcDurationMs": 20.602999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21713.491,
"heapDeltaBytes": -32848424,
"heapUsedBytes": 179059964,
"domNodes": -8312,
"jsHeapTotalBytes": -7614464,
"scriptDurationMs": 881.7250000000001,
"eventListeners": -16381,
"totalBlockingTimeMs": 457,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 451.17900000002464,
"styleRecalcs": 14,
"styleRecalcDurationMs": 21.723,
"layouts": 3,
"layoutDurationMs": 1.287,
"taskDurationMs": 119.768,
"heapDeltaBytes": 5308672,
"heapUsedBytes": 68375588,
"domNodes": 134,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.738000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 453.65899999990233,
"styleRecalcs": 14,
"styleRecalcDurationMs": 18.303,
"layouts": 2,
"layoutDurationMs": 0.37600000000000006,
"taskDurationMs": 106.377,
"heapDeltaBytes": 5072820,
"heapUsedBytes": 68182436,
"domNodes": 125,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.047,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## dante/workspace-activity-api-wiring #14813 +/- ##
======================================================================
Coverage ? 78.72%
======================================================================
Files ? 1806
Lines ? 107077
Branches ? 30695
======================================================================
Hits ? 84296
Misses ? 22326
Partials ? 455
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
## Summary Adds deterministic browser coverage for the current-main partner-node, top-up, and responsive billing-cycle workflows. This PR is stacked on the isolated maximum-warning prerequisite #14815, which is itself stacked on #14713 so the Cloud Team recovery-banner slice remains independently reviewable. ## Why this is needed These journeys span stateful API polling, exact currency payloads, workspace-scoped balances, partner-node recovery, permission boundaries, and responsive pricing interactions. Main and #14713 did not deterministically exercise them, leaving regressions dependent on live billing state and timing. The maximum top-up test also exposed a current frontend bug: manually entering an amount at or above $10,000 clamps the input correctly, but the enterprise guidance was unreachable because the warning only appeared for values strictly greater than the maximum. ## Changes - Adds a typed stateful billing API fixture for deterministic status, balance, plans, preview, top-up, subscription, cancellation, and operation polling responses. - Adds partner-node coverage for price presentation, prompt execution request, sufficient-credit balance deduction/refresh, insufficient-credit recovery after a failed billing refresh, and member privacy/permissions. - Adds top-up coverage for exact-cent personal preset/custom payloads, active Team workspace scoping, pending completion, HTTP failure/retry, failed operation feedback, and the current $10,000/enterprise contract. - Adds monthly-to-yearly Creator pricing interaction through the direct supported pricing route on Cloud desktop and mobile, guarded by nonempty interactive-plan assertions. - Depends on #14815, which isolates the `showCeilingWarning` production prerequisite. ## Root cause and fix ### AS IS `showCeilingWarning` used `value > MAX_AMOUNT`. Because the input is clamped to `MAX_AMOUNT`, the observable value could never remain above the cap, hiding the warning and Contact us link at $10,000. [AS IS screenshot](https://ampcode.com/user-content/artifacts/6f5bcdc4d255307bdaed598273b88977160cebe70cc89f89baa56c5330e79c0f-file.png) ### TO BE The warning uses `value >= MAX_AMOUNT`, preserving the cap while exposing enterprise billing guidance at the reachable maximum. [TO BE screenshot](https://ampcode.com/user-content/artifacts/4ef8548ce8b54dee264330d27bcef202cc5633667fecacd04c46d170a3a4b44b-file.png) ## Review focus - Stateful billing operation polling and mocked balance refresh/deduction behavior. - Team member permission/privacy expectations. - The one-line maximum-warning prerequisite is isolated in #14815. - #14526 is an active draft for a future saved-payment-method UI contract with component tests; these browser tests remain scoped to current-main behavior and do not mock provider metering. - Workspace Activity API wiring and browser coverage are isolated in #14811 and #14813 rather than duplicated here. ## Validation - `pnpm typecheck` and `pnpm typecheck:browser` - Focused Cloud partner-node/top-up/pricing Playwright - Pricing mobile-chrome repeated 3 times and Cloud once after the responsive route fix - ESLint, oxfmt, oxlint, knip, and `git diff --check` ## Stacking - Base: `dante/topup-max-enterprise-warning` (#14815) - #14815 is based on `dante01yoon/test-billing-e2e-matrix` (#14713) - Workspace Activity prerequisite/tests: #14811 → #14813 --------- Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fd293-f206-7568-aac5-3534ddb7a042
4405898 to
3e7d14e
Compare
DrJKL
left a comment
There was a problem hiding this comment.
The scenarios cover the claimed request authentication, workspace scope, rendering, filtering, refresh, empty state, and retry behavior, and the cloud CI run passed. I did not run the cloud E2E locally because this orb has no cloud backend; Playwright discovery found all three tests.
Requesting changes to bring the new spec in line with the canonical browser-test structure and to keep raw API mock types tied directly to the generated contract. Root and browser typechecks, ESLint, Oxlint, Playwright test discovery, and diff check pass.
| import { jsonRoute } from '@e2e/fixtures/utils/jsonRoute' | ||
| import { mockWorkspace, workspace } from '@e2e/fixtures/utils/workspaceMocks' | ||
|
|
||
| const APP_URL = process.env.PLAYWRIGHT_TEST_URL || 'http://localhost:8188' |
There was a problem hiding this comment.
This new spec puts mock data, route setup, locator wiring, and boot helpers at file scope, then requests only the bare page fixture and performs more arrangement inside each test. The canonical browser_tests/README.md requires spec files to contain only imports, Playwright hooks/config, and test blocks; arrangement belongs in fixtures or beforeEach, and tests should use comfyPage rather than manually recreating its readiness wait. Please move stable response data to fixtures/data, put the cloud boot/routes and settings navigation behind the narrowest fixture or existing page object, and leave the test bodies with user actions and behavioral assertions.
| BillingStatusResponse as GeneratedBillingStatusResponse, | ||
| ChurnkeyAuthResponse | ||
| } from '@comfyorg/ingest-types' | ||
| export type { BillingEventsResponse } from '@comfyorg/ingest-types' |
There was a problem hiding this comment.
Please do not expand workspaceApi.ts's public API only to type raw endpoint mocks. browser_tests/README.md names @comfyorg/ingest-types as the source of truth for cloud billing response bodies, and both BillingEventsResponse and BillingPlansResponse are generated there. Import the generated billing response types directly in the fixture data and remove this re-export plus the new export on the local plans interface. This also avoids blessing a second hand-declared BillingPlansResponse that can drift from the generated contract.
Summary
Adds deterministic cloud browser coverage for the workspace Activity usage feed introduced by #14811.
Changes
Review Focus
/api/billing/eventshas no workspace query parameter.