Repository navigation
feat: add transactional payment declined dialog (FE-1251) - #14091
dante01yoon wants to merge 10 commits into
Conversation
🎭 Playwright: ✅ 1895 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.67 MB gzip 🔴 +2.12 kBDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.58 MB (baseline 3.58 MB) • 🔴 +746 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 16 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.3 MB) • 🔴 +5.08 kBBundles that do not match a named category
Status: 79 added / 78 removed / 216 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-01T10:21:46.160Z",
"gitSha": "700b7d16424b07a080fceb6510f16b9f0fe45f64",
"branch": "feat/payment-declined-dialog",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2065.8219999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.1640000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.349,
"heapDeltaBytes": -9528192,
"heapUsedBytes": 59425712,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.626,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2033.980999999926,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.829,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.32000000000005,
"heapDeltaBytes": -428960,
"heapUsedBytes": 69040228,
"domNodes": -283,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.736,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1903.4649999999829,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.559,
"layouts": 14,
"layoutDurationMs": 4.912,
"taskDurationMs": 883.3160000000001,
"heapDeltaBytes": 4725224,
"heapUsedBytes": 74369872,
"domNodes": -285,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 147.063,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1818.5799999999972,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.861,
"layouts": 14,
"layoutDurationMs": 4.498,
"taskDurationMs": 865.3389999999999,
"heapDeltaBytes": -6873712,
"heapUsedBytes": 63008984,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 142.238,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.0139999999833,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.994000000000003,
"layouts": 6,
"layoutDurationMs": 1.164,
"taskDurationMs": 359.64799999999997,
"heapDeltaBytes": 4432580,
"heapUsedBytes": 74753936,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.918999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.747000000003,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.427999999999997,
"layouts": 6,
"layoutDurationMs": 1.083,
"taskDurationMs": 348.362,
"heapDeltaBytes": 4462312,
"heapUsedBytes": 74458064,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.82,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 659.2870000000062,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.4559999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.86500000000007,
"heapDeltaBytes": 17878496,
"heapUsedBytes": 87959372,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 153.882,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 646.6830000000527,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.325000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.851,
"heapDeltaBytes": 18147196,
"heapUsedBytes": 87993276,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 155.197,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2041.2959999999885,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.762999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.716,
"heapDeltaBytes": -13172172,
"heapUsedBytes": 86754360,
"domNodes": -270,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 38.786,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2043.5899999999947,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.376999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.919,
"heapDeltaBytes": -13303288,
"heapUsedBytes": 86754668,
"domNodes": -269,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 32.257,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2140.544000000034,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.653999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1533.623,
"heapDeltaBytes": 19063748,
"heapUsedBytes": 84705424,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 750.4549999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2119.538999999918,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.336999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1490.237,
"heapDeltaBytes": 20367472,
"heapUsedBytes": 86625284,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 724.9010000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3460.121000000015,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.547,
"layouts": 60,
"layoutDurationMs": 12.827000000000002,
"taskDurationMs": 1636.0450000000003,
"heapDeltaBytes": 11737488,
"heapUsedBytes": 79482128,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 751.069,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3434.902999999963,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.501,
"layouts": 60,
"layoutDurationMs": 12.553,
"taskDurationMs": 1636.4809999999998,
"heapDeltaBytes": 9811920,
"heapUsedBytes": 76547448,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 745.642,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3044.881999999973,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.466000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1864.1940000000002,
"heapDeltaBytes": 19236228,
"heapUsedBytes": 87015056,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 935.572,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3037.60299999999,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.272000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1859.3670000000002,
"heapDeltaBytes": 17314552,
"heapUsedBytes": 84635356,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 940.014,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1996.6249999999945,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6840000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.384,
"heapDeltaBytes": 22153448,
"heapUsedBytes": 88155492,
"domNodes": -9,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.593999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.4649999999547,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.156999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.5619999999999,
"heapDeltaBytes": -14386412,
"heapUsedBytes": 87543228,
"domNodes": -275,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 31.071,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.0899999999888,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.822,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.19500000000005,
"heapDeltaBytes": 13719680,
"heapUsedBytes": 85593520,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.905,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.6969999999455,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.473000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.32599999999996,
"heapDeltaBytes": 13649992,
"heapUsedBytes": 85601804,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 147.73600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.136999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.502,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.832,
"heapDeltaBytes": -5624540,
"heapUsedBytes": 66585012,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.665000000000002,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.6000000000013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.121000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.4080000000001,
"heapDeltaBytes": -8000440,
"heapUsedBytes": 63885576,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.068000000000001,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1781.25,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.039,
"layouts": 18,
"layoutDurationMs": 5.862000000000001,
"taskDurationMs": 822.9380000000001,
"heapDeltaBytes": -11546908,
"heapUsedBytes": 60637480,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 102.833,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.6569999999929,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.977000000000004,
"layouts": 18,
"layoutDurationMs": 5.625,
"taskDurationMs": 792.999,
"heapDeltaBytes": -8687652,
"heapUsedBytes": 63313320,
"domNodes": -297,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 102.84100000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.3900000000158,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.216999999999995,
"layouts": 14,
"layoutDurationMs": 14.169999999999998,
"taskDurationMs": 917.328,
"heapDeltaBytes": 22733836,
"heapUsedBytes": 97864712,
"domNodes": 13751,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 32.006,
"eventListeners": 2383,
"totalBlockingTimeMs": 120,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8216.609000000006,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.591,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5558.352999999999,
"heapDeltaBytes": -15156208,
"heapUsedBytes": 84500504,
"domNodes": -269,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2515.6299999999997,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8253.195000000005,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5520.873,
"heapDeltaBytes": -15621172,
"heapUsedBytes": 84439936,
"domNodes": -267,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 2516.323,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17917.68399999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17348.431,
"heapDeltaBytes": -47565764,
"heapUsedBytes": 162214244,
"domNodes": -6548,
"jsHeapTotalBytes": -5369856,
"scriptDurationMs": 289.942,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17822.20700000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17092.177,
"heapDeltaBytes": -29162532,
"heapUsedBytes": 175448440,
"domNodes": -6548,
"jsHeapTotalBytes": -3571712,
"scriptDurationMs": 290.18399999999997,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22242.06099999998,
"styleRecalcs": 168,
"styleRecalcDurationMs": 20.66000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21862.307,
"heapDeltaBytes": -41767136,
"heapUsedBytes": 167734424,
"domNodes": -6548,
"jsHeapTotalBytes": -3534848,
"scriptDurationMs": 902.283,
"eventListeners": -7467,
"totalBlockingTimeMs": 131,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22310.316000000057,
"styleRecalcs": 174,
"styleRecalcDurationMs": 20.888999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21924.321,
"heapDeltaBytes": -26491560,
"heapUsedBytes": 176227420,
"domNodes": -6548,
"jsHeapTotalBytes": 2039808,
"scriptDurationMs": 905.779,
"eventListeners": -7471,
"totalBlockingTimeMs": 95,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6339.362999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.12600000000003,
"layouts": 20,
"layoutDurationMs": 25.88900000000001,
"taskDurationMs": 6282.165,
"heapDeltaBytes": -26694300,
"heapUsedBytes": 175811640,
"domNodes": -6548,
"jsHeapTotalBytes": 11264000,
"scriptDurationMs": 115.51599999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 425,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6486.861999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.048,
"layouts": 20,
"layoutDurationMs": 27.115000000000013,
"taskDurationMs": 6447.408000000001,
"heapDeltaBytes": -30732180,
"heapUsedBytes": 166129820,
"domNodes": -6548,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 121.65599999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 540,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 452.303000000029,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.083999999999996,
"layouts": 3,
"layoutDurationMs": 1.618,
"taskDurationMs": 103.624,
"heapDeltaBytes": 5067788,
"heapUsedBytes": 72690040,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.394000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 113.58399999994617,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.725999999999997,
"layouts": 3,
"layoutDurationMs": 1.7930000000000001,
"taskDurationMs": 83.76199999999997,
"heapDeltaBytes": 3054704,
"heapUsedBytes": 66476628,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.58,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a feature-flagged payment-declined dialog with localized content, subscription and top-up variants, billing-portal recovery handling, keyed dialog-service integration, Storybook stories, and component/service tests. ChangesPayment declined experience
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant DialogService
participant PaymentDeclinedDialogContent
participant BillingContext
participant Toast
DialogService->>PaymentDeclinedDialogContent: opens with origin and declined reason
PaymentDeclinedDialogContent->>BillingContext: calls manageSubscription()
PaymentDeclinedDialogContent->>Toast: shows error when portal opening fails
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14091 +/- ##
=========================================
Coverage 82.25% 82.25%
=========================================
Files 2017 2018 +1
Lines 116536 116576 +40
Branches 31039 29242 -1797
=========================================
+ Hits 95856 95890 +34
- Misses 20505 20511 +6
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/workspace/components/dialogs/PaymentDeclinedDialogContent.vue`:
- Around line 40-48: Update the reason section in PaymentDeclinedDialogContent
so long or unbroken reason values cannot overflow the fixed dialog layout: apply
appropriate text wrapping and constrain or safely expand the section while
preserving the existing styling. Add a test covering a long multiline or
unbroken reason and verifying it remains within the dialog without overlapping
the action area.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0d4b49e9-545c-44a2-8ad9-e99c2e8173ad
📒 Files selected for processing (3)
src/platform/workspace/components/dialogs/PaymentDeclinedDialogContent.stories.tssrc/platform/workspace/components/dialogs/PaymentDeclinedDialogContent.test.tssrc/platform/workspace/components/dialogs/PaymentDeclinedDialogContent.vue
Amp-Thread-ID: https://ampcode.com/threads/T-019f94c7-35ee-71dc-ad60-782c2e5a3141 Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019f94c7-35ee-71dc-ad60-782c2e5a3141
338d485 to
0e8afff
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-019f94c7-35ee-71dc-ad60-782c2e5a3141 Co-authored-by: Amp <amp@ampcode.com>
## Summary Adds the independently flagged frontend slice for Payment Recovery US1 and US3: unattended renewal-failure visibility and role-safe paused-workspace run recovery, without depending on Comfy-Org#14091. ### Root cause and why this is needed Payment recovery states were coupled to `billing_control_enabled`, which is the rollout control for existing out-of-credits and subscription-ending notices. Paused workspaces also fell through the generic inactive path, replacing the entire queue group with `Subscribe to Run`. This hid batch/queue controls and exposed generic subscription/payment language to members instead of the required role-safe recovery UX. ### How this changes - Adds the authenticated server flag key `v1_payment_recovery`, exposed as `flags.v1PaymentRecovery` with the normal `ff:v1_payment_recovery` local override. - Gates only `payment_failed` and `paused` banners/run-lock behavior with the new flag; existing out-of-credits, ending, and generic inactive behavior remain on their existing paths. - Shows billing managers a non-dismissible `Payment failed` banner with `Update payment`; returning focus refetches status/balance while that banner is visible. - Keeps the queue group mounted when paused. Existing auto-run mode is reset and the visible dropdown is locked so no queued execution bypasses recovery. - Gives owners a gold `Update payment to run` action and portal recovery dialog; members see a gray locked `Run` action and a billing-private `Subscription paused` explainer with `Ok, got it`. - Uses the existing billing portal action, which opens Stripe Billing Portal in a new tab. ### API / backend boundary This PR consumes existing `billing_status` values (`payment_failed`, `paused`) and the existing payment-portal endpoint. Backend/remote config must deliver `v1_payment_recovery`. It does not implement dunning, recovery state transitions, or server mechanics. PR Comfy-Org#14091 remains separate transactional-decline work; this PR has no dependency on its dialog or implementation. ## Changes - **What**: Flag wiring, payment recovery banner derivation/focus refresh, paused queue lock, owner/member recovery dialog, focused unit/component coverage. ## Review Focus - Recovery states are independent from `billing_control_enabled` while unrelated states preserve existing gates. - Paused owner/member flows cannot submit via primary action or Run-on-Change, but batch/dropdown controls stay mounted. - Members receive no payment-declined, card, or payment-method details. ## Screenshots Captured in the real cloud application with billing/workspace endpoints mocked through the repository's Playwright fixtures; no Storybook state was used. ### AS IS — paused owner uses generic inactive replacement  ### TO BE — paused owner queue lock and recovery   ### TO BE — paused member privacy-safe explainer  ## Validation - `pnpm typecheck` - `pnpm lint:unstaged` - 101 focused unit/component tests - 2 real-app Playwright cloud scenarios (paused owner/member) - `pnpm exec oxfmt --check` on touched files - `git diff --check` `pnpm typecheck:browser` is currently blocked by pre-existing `BillingStatusResponse` fixture drift on `main` (existing fixtures are missing newly required seat fields); the added Playwright fixture itself was exercised successfully before being kept out of this focused diff. --------- Co-authored-by: Amp <amp@ampcode.com>
…vitest-cleanup Remove vi.resetAllMocks() from PaymentDeclinedDialogContent.test.ts and vi.clearAllMocks() from dialogService.paymentDeclined.test.ts — both are flagged as redundant by the comfy/no-redundant-vitest-cleanup oxlint rule. <!-- authored-by:agent cheap-drain -->
011dcad
|
Removed two redundant vitest cleanup calls flagged by
Fix commit: Verification:
Auto-merge (squash) re-enabled. PR will merge once remaining CI checks pass. |
|
Working the pre-17600 backlog. This is one of only two items on it that are genuinely The component itself is in good shape — tested, a Storybook story, purely additive (+390/−0), no conflicts after seven weeks, which is unusual for anything this old in this area. But nothing opens it. So merged as-is this adds a complete, tested dialog that no code path can reach. We are raising it because we found the same shape on #13762 an hour ago — 2,133 lines of auto-reload settings UI that persists nothing — and two instances in one backlog suggests the component-first split is being made routinely without a follow-up that wires it. One of those is a pattern; two is worth naming. The difference from #13762, and why we are not recommending close. That one had no backend concept anywhere, so it could not have worked. This one has a real state to attach to: // main, the existing decline path
// "Synchronous 'failed' here means the charge was declined, not rejected pre-attempt."
toast.add({ severity: 'error', summary: t('credits.topUp.purchaseError'), detail: t('credits.topUp.unknownError') })A dialog with recovery guidance is plainly better than Three ways this closes, and any is fine:
Not blocking on our side either way — there is nothing wrong with the code. |
Pull request was closed
Summary
dialogService.showPaymentDeclinedDialog({ origin, reason })seam for later operation wiringThe existing billing-status banner is unchanged. Generic billing failures are intentionally not wired to this dialog because the current operation API cannot reliably distinguish a card decline from provider/internal failures.
AS IS flow
pending,succeeded, orfailed, with an optional free-formerror_message.TO BE flow
showPaymentDeclinedDialog({ origin, reason }), stacking the declined surface over the still-mounted originating flow. The selected plan/cycle or top-up amount remains intact.useBillingContext().manageSubscription(). After the portal opens, the declined layer closes while the originating flow remains mounted.Retrying the exact failed Stripe charge is not part of this frontend seam; that requires a backend retry handle or endpoint.
UI preview — unwired Storybook surface
These captures use the isolated Storybook stories added by this PR. They demonstrate the implemented presentation states, not a production end-to-end decline trigger.
Subscription variant
Subscription and top-up variants
Behavior
billing_control_enabledthrough the existing feature-flag composable.Validation
pnpm typecheckpnpm build-storybookgit diff --checkBackend follow-up assessment
failedplus free-formerror_message, so FE cannot safely distinguish card declines from internal/provider errors.Scope note
This implements the reviewable design and integration seam only. Wiring operation failures should happen once the API provides a stable decline discriminator.