Repository navigation
test(billing): cover deterministic billing workflows - #14810
dante01yoon merged 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1786 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-06T02:17:00.770Z",
"gitSha": "15b8ec287289eb1f4a014d26a07166c739e89dc7",
"branch": "dante/billing-e2e-deterministic-followups-v2",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.6299999999733,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.559000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.61199999999997,
"heapDeltaBytes": 5343044,
"heapUsedBytes": 69335800,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 18.113,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2013.0810000000565,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.446000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.60800000000006,
"heapDeltaBytes": 5370448,
"heapUsedBytes": 69361336,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 18.377000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2122.7549999999837,
"styleRecalcs": 77,
"styleRecalcDurationMs": 44.685,
"layouts": 12,
"layoutDurationMs": 3.8640000000000003,
"taskDurationMs": 1058.4,
"heapDeltaBytes": -10808696,
"heapUsedBytes": 53232224,
"domNodes": -277,
"jsHeapTotalBytes": 24621056,
"scriptDurationMs": 142.433,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1901.254999999992,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.354,
"layouts": 12,
"layoutDurationMs": 3.464,
"taskDurationMs": 893.594,
"heapDeltaBytes": -11784444,
"heapUsedBytes": 52256264,
"domNodes": -282,
"jsHeapTotalBytes": 24883200,
"scriptDurationMs": 124.543,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.7709999999815,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.515,
"layouts": 6,
"layoutDurationMs": 0.647,
"taskDurationMs": 395.52200000000005,
"heapDeltaBytes": 8598228,
"heapUsedBytes": 72760684,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 22.134,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.5879999999788,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.961999999999996,
"layouts": 6,
"layoutDurationMs": 0.6539999999999998,
"taskDurationMs": 389.62,
"heapDeltaBytes": 8631080,
"heapUsedBytes": 72628588,
"domNodes": 75,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 20.944999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 591.713000000027,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.7799999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.69899999999996,
"heapDeltaBytes": -10760120,
"heapUsedBytes": 53097664,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 63.912,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 604.626000000053,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.629999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.41,
"heapDeltaBytes": -11049048,
"heapUsedBytes": 53041524,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 63.602999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.5330000000008,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.701999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 703.598,
"heapDeltaBytes": 7158540,
"heapUsedBytes": 66628280,
"domNodes": -283,
"jsHeapTotalBytes": 3252224,
"scriptDurationMs": 112.63400000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.0100000000093,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.095000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 694.2850000000001,
"heapDeltaBytes": 6991480,
"heapUsedBytes": 67215184,
"domNodes": -280,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 114.14200000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2154.088999999999,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.262000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1285.5430000000001,
"heapDeltaBytes": -4926460,
"heapUsedBytes": 55544332,
"domNodes": -285,
"jsHeapTotalBytes": 4038656,
"scriptDurationMs": 430.733,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2246.3650000000825,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.470999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1323.7250000000001,
"heapDeltaBytes": 4104664,
"heapUsedBytes": 64621660,
"domNodes": -283,
"jsHeapTotalBytes": 3444736,
"scriptDurationMs": 441.76400000000007,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3231.3159999999925,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.792,
"layouts": 60,
"layoutDurationMs": 7.4110000000000005,
"taskDurationMs": 1574.866,
"heapDeltaBytes": -1571972,
"heapUsedBytes": 60642704,
"domNodes": -288,
"jsHeapTotalBytes": 6660096,
"scriptDurationMs": 554.289,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3228.667000000087,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.055000000000001,
"layouts": 60,
"layoutDurationMs": 7.353,
"taskDurationMs": 1537.3210000000001,
"heapDeltaBytes": -1554796,
"heapUsedBytes": 61097904,
"domNodes": -289,
"jsHeapTotalBytes": 6922240,
"scriptDurationMs": 538.06,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.7990000000068,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.594999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.8659999999999,
"heapDeltaBytes": 6655704,
"heapUsedBytes": 67082052,
"domNodes": -281,
"jsHeapTotalBytes": 2990080,
"scriptDurationMs": 108.40599999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.7120000000314,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.758999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.478,
"heapDeltaBytes": 6204204,
"heapUsedBytes": 66692580,
"domNodes": -285,
"jsHeapTotalBytes": 4038656,
"scriptDurationMs": 106.41599999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.3840000000282,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.212,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.174,
"heapDeltaBytes": -10692468,
"heapUsedBytes": 53665012,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 119.79999999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.9109999999828,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.117,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.663,
"heapDeltaBytes": -10625228,
"heapUsedBytes": 53406592,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 125.46799999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1995.1990000000137,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.05,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.76399999999995,
"heapDeltaBytes": 5153948,
"heapUsedBytes": 69280132,
"domNodes": 22,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 13.819,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2012.5239999999849,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.154,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.4359999999999,
"heapDeltaBytes": -18830132,
"heapUsedBytes": 45431504,
"domNodes": 18,
"jsHeapTotalBytes": 24358912,
"scriptDurationMs": 14.853000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.8469999999584,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.631,
"layouts": 16,
"layoutDurationMs": 4.26,
"taskDurationMs": 778.561,
"heapDeltaBytes": -3897860,
"heapUsedBytes": 60226816,
"domNodes": 61,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 94.54,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.647000000019,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.364,
"layouts": 16,
"layoutDurationMs": 4.498,
"taskDurationMs": 837.334,
"heapDeltaBytes": -18374244,
"heapUsedBytes": 45669932,
"domNodes": 61,
"jsHeapTotalBytes": 24096768,
"scriptDurationMs": 98.772,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.034999999979,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.543,
"layouts": 14,
"layoutDurationMs": 13.047999999999996,
"taskDurationMs": 945.9989999999998,
"heapDeltaBytes": 8778588,
"heapUsedBytes": 97800156,
"domNodes": 13673,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 36.754999999999995,
"eventListeners": 2375,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8416.590999999982,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.438,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4712.292,
"heapDeltaBytes": 12525764,
"heapUsedBytes": 72115484,
"domNodes": -283,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 1489.703,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8299.80999999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.525,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4591.92,
"heapDeltaBytes": 9373008,
"heapUsedBytes": 69980092,
"domNodes": -284,
"jsHeapTotalBytes": 4755456,
"scriptDurationMs": 1397.203,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17410.319000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17377.764,
"heapDeltaBytes": -50609992,
"heapUsedBytes": 166737548,
"domNodes": -8316,
"jsHeapTotalBytes": -9379840,
"scriptDurationMs": 619.0100000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17168.812,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17150.113,
"heapDeltaBytes": -58032880,
"heapUsedBytes": 166871060,
"domNodes": -8312,
"jsHeapTotalBytes": -8855552,
"scriptDurationMs": 610.3199999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21071.641999999996,
"styleRecalcs": 148,
"styleRecalcDurationMs": 18.851000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21043.084,
"heapDeltaBytes": -40532048,
"heapUsedBytes": 166162064,
"domNodes": -8312,
"jsHeapTotalBytes": -10395648,
"scriptDurationMs": 932.7169999999999,
"eventListeners": -16383,
"totalBlockingTimeMs": 280,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20963.29800000001,
"styleRecalcs": 140,
"styleRecalcDurationMs": 17.53100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20895.288999999997,
"heapDeltaBytes": -49432544,
"heapUsedBytes": 164512564,
"domNodes": -8312,
"jsHeapTotalBytes": -8065024,
"scriptDurationMs": 932.413,
"eventListeners": -16385,
"totalBlockingTimeMs": 171,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 481.0099999999693,
"styleRecalcs": 16,
"styleRecalcDurationMs": 23.538000000000004,
"layouts": 3,
"layoutDurationMs": 0.7400000000000002,
"taskDurationMs": 136.236,
"heapDeltaBytes": 5322548,
"heapUsedBytes": 68598916,
"domNodes": 136,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.983000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 477.07500000001346,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.84,
"layouts": 3,
"layoutDurationMs": 0.5399999999999999,
"taskDurationMs": 117.651,
"heapDeltaBytes": 5076340,
"heapUsedBytes": 68455128,
"domNodes": 123,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.357,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## dante/topup-max-enterprise-warning #14810 +/- ##
====================================================================
Coverage 78.71% 78.71%
====================================================================
Files 1804 1804
Lines 107023 107023
Branches 29797 30683 +886
====================================================================
Hits 84238 84238
Misses 22330 22330
Partials 455 455
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5bdde95 to
799b266
Compare
huang47
left a comment
There was a problem hiding this comment.
Requesting changes for the two blocking issues below. Current-head visual evidence.
Amp-Thread-ID: https://ampcode.com/threads/T-019fd273-a52b-7504-9bc5-500c66549dd9 Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fd293-f206-7568-aac5-3534ddb7a042
Amp-Thread-ID: https://ampcode.com/threads/T-019fd293-f206-7568-aac5-3534ddb7a042 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fd4ca-d766-768d-a575-b14a4319592b Co-authored-by: Amp <amp@ampcode.com>
d349b73 to
c687235
Compare
huang47
left a comment
There was a problem hiding this comment.
comments resolved, thanks for adding the tests!
d6020be
into
dante/topup-max-enterprise-warning

Summary
Adds deterministic browser coverage for the current-main partner-node, top-up, and responsive billing-cycle workflows. This PR is stacked on the isolated maximum-warning prerequisite #14815, which is itself stacked on #14713 so the Cloud Team recovery-banner slice remains independently reviewable.
Why this is needed
These journeys span stateful API polling, exact currency payloads, workspace-scoped balances, partner-node recovery, permission boundaries, and responsive pricing interactions. Main and #14713 did not deterministically exercise them, leaving regressions dependent on live billing state and timing.
The maximum top-up test also exposed a current frontend bug: manually entering an amount at or above $10,000 clamps the input correctly, but the enterprise guidance was unreachable because the warning only appeared for values strictly greater than the maximum.
Changes
showCeilingWarningproduction prerequisite.Root cause and fix
AS IS
showCeilingWarningusedvalue > MAX_AMOUNT. Because the input is clamped toMAX_AMOUNT, the observable value could never remain above the cap, hiding the warning and Contact us link at $10,000.AS IS screenshot
TO BE
The warning uses
value >= MAX_AMOUNT, preserving the cap while exposing enterprise billing guidance at the reachable maximum.TO BE screenshot
Review focus
Validation
pnpm typecheckandpnpm typecheck:browsergit diff --checkStacking
dante/topup-max-enterprise-warning(fix(billing): show enterprise guidance at top-up cap #14815)dante01yoon/test-billing-e2e-matrix(test(billing): cover recovery banner permissions #14713)