Skip to content

refactor(design-system): move the brand layer into the package - #14790

Merged
christian-byrne merged 6 commits into
glary/design-system-brand-yellow-f2ff59from
glary/design-system-consolidate-brand
Aug 29, 2026
Merged

christian-byrne merged 6 commits into
glary/design-system-brand-yellow-f2ff59from
glary/design-system-consolidate-brand

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Stacked on #14484. That PR stops surfaces from restating token values; this one moves the brand layer itself into the package, so there is a single file that owns every brand colour and the brand typeface.

Changes

  • What: _brand.css (all brand colours + both brand font tokens) and brand-fonts.css (the PP Formula faces). base.css becomes the brand surface — brand, brand fonts, shared ramps; style.css is that plus everything product. apps/website/src/styles/global.css drops the 10 brand colours, the 6 PP Formula @font-face blocks, both font tokens and the dead Google Fonts Inter import, keeping only site-specific values. 82 mauve stroke literals across three HeroSections, 12 PP Formula literals in HubspotFormEmbed and 404.astro, and the --brand-yellow indirection in style.css are gone.
  • Breaking: _palette.css no longer carries brand tokens and base.css no longer loads Inter. Nothing consumes either today — checked. platform imports _palette.css for the neutral ramps only, and the website never used Inter (its body is font-formula), which is what made the Google Fonts import dead. Version bumped to 1.1.0; platform should move its import to base.css when it takes the upgrade.

Review Focus

Why the brand yellow could drift at all. It was declared in three places under different names, so no single change could keep them equal. The same was true of --font-formula, and worse: _palette.css said 'PP Formula', 'Inter', sans-serif while the website said 'PP Formula', sans-serif, and the website silently won. I kept the Inter fallback in the unified token, because the app bundles only three of the six PP Formula weights (src/platform/cloud/onboarding/assets) and leans on Inter for the rest. On comfy.org the fallback is inert — no Inter is served there — so rendering is unchanged on both surfaces.

The test is the part that lasts. brandColors.test.ts now fails if any --color-* or --font-* token is declared in more than one of _brand.css, _palette.css, and the website's @theme. Documentation alone would not have prevented this; the second declaration always looks reasonable in isolation.

SVG strokes went to utility classes, not var(). stroke="#4D3762" became class="stroke-secondary-mauve" rather than stroke="var(--color-secondary-mauve)" — substitution in SVG presentation attributes was only resolved into SVG2 in Nov 2025 and Chromium is uneven. The two occurrences inside @keyframes are real declarations, so those use var().

Verification. Diffed every emitted --color-* / --font-* in the built website CSS against the pre-change build: same 34 tokens, same values, only ordering differs plus the intended Inter fallback. Converted stroke counts match one-for-one in the built HTML (cloud 36, cloud/enterprise 39, download 5, zero leftover attributes). Both builds still resolve the full yellow chain to #f2ff59, all six PP Formula faces are present in the output, and no fonts.googleapis reference survives anywhere in dist.

Gates: lint (0 errors), format:check, typecheck, typecheck:website (0 errors), knip, website build (581 pages), 345 website tests, 672 tests across src/platform/cloud, packages/shared-frontend-utils and src/components/ui.

Answers Alexis's question in-repo. The README now says outright that the package holds two design systems, that the file is what distinguishes them, and that no naming convention reliably does — several token names predate the split. primary- is still overloaded across app-semantic roles and brand colours, and plum-600 / primary-comfy-plum remain the same hex under two names. Renaming them is deliberately not in this PR; it is a breaking change for consumers and wants its own decision.

Deliberately left alone. --text-2xs still disagrees between style.css (0.625rem) and the website (0.6875rem). The website's value wins on comfy.org, so aligning it is a visible type change across the site — a designer's call, not a refactor's. The duplicate-declaration test is scoped to the files base.css actually pulls in, so it does not paper over this.

Brand colours and the brand typeface were declared in three places at once —
_palette.css, style.css and the website's own @theme — so the same value
existed under different names with nothing keeping them equal. Collapse them
into a single brand layer the package owns.

- _brand.css holds every brand colour and both brand font tokens
- brand-fonts.css holds the PP Formula faces, loaded by base.css only
- base.css is now the brand surface; style.css is base plus product
- the website declares site-specific values and nothing else
- 82 mauve stroke literals, 12 PP Formula literals and the dead Google Fonts
  Inter import are gone
- brandColors.test.ts fails if any token is declared in two of the three files
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b454ad79-4480-4ead-a9f0-07762cb19898

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1982 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1961 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/23/2026, 01:19:12 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 141ms TBT · 93.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.8 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.1 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 60ms TBT · 168.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 476ms
canvas-idle: script duration 6ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.6 MB
canvas-idle: DOM nodes -284
canvas-idle: event listeners -151
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 35ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 858ms
canvas-mouse-sweep: script duration 110ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 54.8 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -152
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 361ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 62.2 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 381ms
dom-widget-clipping: script duration 58ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 68.6 MB
dom-widget-clipping: DOM nodes 15
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 608ms
large-graph-idle: script duration 15ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 64.7 MB
large-graph-idle: DOM nodes -277
large-graph-idle: event listeners -165
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1220ms
large-graph-pan: script duration 336ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 64.5 MB
large-graph-pan: DOM nodes -279
large-graph-pan: event listeners -164
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1406ms
large-graph-zoom: script duration 389ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.9 MB
large-graph-zoom: DOM nodes -276
large-graph-zoom: event listeners -147
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1465ms
legacy-node-drag: script duration 461ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 74.1 MB
legacy-node-drag: DOM nodes -118
legacy-node-drag: event listeners 109
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 594ms
minimap-idle: script duration 14ms
minimap-idle: TBT 0ms
minimap-idle: heap used 64.0 MB
minimap-idle: DOM nodes -282
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 382ms
subgraph-dom-widget-clipping: script duration 116ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 70.7 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 476ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.6 MB
subgraph-idle: DOM nodes -283
subgraph-idle: event listeners -151
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 36ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 822ms
subgraph-mouse-sweep: script duration 88ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.6 MB
subgraph-mouse-sweep: DOM nodes -282
subgraph-mouse-sweep: event listeners -167
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 12
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 887ms
subgraph-transition-enter: script duration 17ms
subgraph-transition-enter: TBT 141ms
subgraph-transition-enter: heap used 93.9 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4298ms
viewport-pan-sweep: script duration 1079ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 76.8 MB
viewport-pan-sweep: DOM nodes -254
viewport-pan-sweep: event listeners -135
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16212ms
vue-large-graph-idle: script duration 105ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.1 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16390
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 169
vue-large-graph-pan: task duration 19802ms
vue-large-graph-pan: script duration 415ms
vue-large-graph-pan: TBT 60ms
vue-large-graph-pan: heap used 168.3 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16389
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 89ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.4 MB
workflow-execution: DOM nodes 119
workflow-execution: event listeners 73
Raw data
{
  "timestamp": "2026-08-23T01:30:20.811Z",
  "gitSha": "85ad0cd4fefee3e39a57acb995ac24edc4a7cc8d",
  "branch": "glary/design-system-consolidate-brand",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2034.2789999999695,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.4079999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.862,
      "heapDeltaBytes": 19973668,
      "heapUsedBytes": 81729892,
      "domNodes": -283,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 6.478,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2032.5740000000678,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.016000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.938,
      "heapDeltaBytes": -3612000,
      "heapUsedBytes": 58033272,
      "domNodes": -285,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 5.95,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1773.4329999999545,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 33.214999999999996,
      "layouts": 12,
      "layoutDurationMs": 3.124,
      "taskDurationMs": 840.9499999999999,
      "heapDeltaBytes": -5648868,
      "heapUsedBytes": 57102972,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 111.53200000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1873.9309999999705,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 37.667,
      "layouts": 12,
      "layoutDurationMs": 3.746,
      "taskDurationMs": 875.958,
      "heapDeltaBytes": -4089144,
      "heapUsedBytes": 57841940,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 108.596,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.0689999999527,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 18.069000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.604,
      "taskDurationMs": 362.174,
      "heapDeltaBytes": 3023960,
      "heapUsedBytes": 64767320,
      "domNodes": 76,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 9.402,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1730.3470000000516,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.944,
      "layouts": 6,
      "layoutDurationMs": 0.644,
      "taskDurationMs": 358.861,
      "heapDeltaBytes": 2906012,
      "heapUsedBytes": 65630844,
      "domNodes": 75,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 10.497,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 683.0730000000358,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.424000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.6190000000001,
      "heapDeltaBytes": 10384376,
      "heapUsedBytes": 72387960,
      "domNodes": 14,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 58.037000000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 576.4039999999113,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.586999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.722,
      "heapDeltaBytes": 10377392,
      "heapUsedBytes": 71577252,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 57.751999999999995,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2021.065999999962,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.771,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 596.224,
      "heapDeltaBytes": -14147696,
      "heapUsedBytes": 62691240,
      "domNodes": -281,
      "jsHeapTotalBytes": 3657728,
      "scriptDurationMs": 15.988,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.5859999999193,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.911999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 619.271,
      "heapDeltaBytes": -4029744,
      "heapUsedBytes": 72926072,
      "domNodes": -273,
      "jsHeapTotalBytes": -12288,
      "scriptDurationMs": 13.945999999999996,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2224.6240000000057,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.444,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1193.585,
      "heapDeltaBytes": -5713160,
      "heapUsedBytes": 71920576,
      "domNodes": -273,
      "jsHeapTotalBytes": -573440,
      "scriptDurationMs": 333.749,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2195.705999999973,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.943999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1247.193,
      "heapDeltaBytes": -14229476,
      "heapUsedBytes": 63393252,
      "domNodes": -284,
      "jsHeapTotalBytes": 3657728,
      "scriptDurationMs": 337.325,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3202.539999999999,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.852000000000004,
      "layouts": 60,
      "layoutDurationMs": 6.944000000000001,
      "taskDurationMs": 1408.093,
      "heapDeltaBytes": -1429732,
      "heapUsedBytes": 77230600,
      "domNodes": -275,
      "jsHeapTotalBytes": -1847296,
      "scriptDurationMs": 389.904,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3181.7310000000134,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.092999999999996,
      "layouts": 60,
      "layoutDurationMs": 7.034000000000001,
      "taskDurationMs": 1403.586,
      "heapDeltaBytes": -1091488,
      "heapUsedBytes": 77799816,
      "domNodes": -276,
      "jsHeapTotalBytes": -3158016,
      "scriptDurationMs": 388.374,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2217.4019999999928,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.189,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1426.921,
      "heapDeltaBytes": 11157720,
      "heapUsedBytes": 90736584,
      "domNodes": 12,
      "jsHeapTotalBytes": 7532544,
      "scriptDurationMs": 460.924,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2354.049000000032,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.866,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1502.397,
      "heapDeltaBytes": -15672736,
      "heapUsedBytes": 64649128,
      "domNodes": -247,
      "jsHeapTotalBytes": -274432,
      "scriptDurationMs": 461.82700000000006,
      "eventListeners": 31,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.0460000000085,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.588999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 590.048,
      "heapDeltaBytes": -13886316,
      "heapUsedBytes": 63894236,
      "domNodes": -282,
      "jsHeapTotalBytes": 3395584,
      "scriptDurationMs": 12.714000000000002,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.6130000000167,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.032,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.035,
      "heapDeltaBytes": -13134588,
      "heapUsedBytes": 70249568,
      "domNodes": -281,
      "jsHeapTotalBytes": 4968448,
      "scriptDurationMs": 15.526000000000002,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 577.9600000000187,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.086,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 377.58599999999996,
      "heapDeltaBytes": 11823232,
      "heapUsedBytes": 74275616,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 114.146,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 591.4970000000039,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.525000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 385.44500000000005,
      "heapDeltaBytes": 11634552,
      "heapUsedBytes": 74014472,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 118.77600000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2010.2940000000444,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.140000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.11899999999997,
      "heapDeltaBytes": 19160748,
      "heapUsedBytes": 81720608,
      "domNodes": -284,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 6.155999999999998,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.7849999999326,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.125,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.92100000000005,
      "heapDeltaBytes": -2311124,
      "heapUsedBytes": 60015828,
      "domNodes": -282,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 5.803000000000001,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1738.6129999999866,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 37.641999999999996,
      "layouts": 16,
      "layoutDurationMs": 4.554,
      "taskDurationMs": 835.016,
      "heapDeltaBytes": 6394460,
      "heapUsedBytes": 69044368,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 91.996,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1726.5499999999747,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.876000000000005,
      "layouts": 16,
      "layoutDurationMs": 4.715999999999999,
      "taskDurationMs": 809.424,
      "heapDeltaBytes": -3960968,
      "heapUsedBytes": 58092620,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 84.422,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1383.2069999999703,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 31.084000000000007,
      "layouts": 12,
      "layoutDurationMs": 14.127999999999998,
      "taskDurationMs": 887.3239999999997,
      "heapDeltaBytes": 23843848,
      "heapUsedBytes": 98425560,
      "domNodes": 13673,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 16.698000000000004,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8328.178999999978,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 37.507,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4171.03,
      "heapDeltaBytes": 4881680,
      "heapUsedBytes": 81653108,
      "domNodes": -236,
      "jsHeapTotalBytes": -311296,
      "scriptDurationMs": 1077.0689999999997,
      "eventListeners": -135,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8493.107000000009,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 37.51199999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4425.048000000001,
      "heapDeltaBytes": 2408380,
      "heapUsedBytes": 79409772,
      "domNodes": -272,
      "jsHeapTotalBytes": -573440,
      "scriptDurationMs": 1080.4389999999999,
      "eventListeners": -135,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16834.84900000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16108.477999999997,
      "heapDeltaBytes": -43913392,
      "heapUsedBytes": 176557952,
      "domNodes": -8312,
      "jsHeapTotalBytes": -23990272,
      "scriptDurationMs": 107.322,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16848.33500000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16314.880000000003,
      "heapDeltaBytes": -47827096,
      "heapUsedBytes": 177994680,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15249408,
      "scriptDurationMs": 102.651,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20269.241000000024,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 16.573999999999977,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19745.574,
      "heapDeltaBytes": -40267124,
      "heapUsedBytes": 180175072,
      "domNodes": -8312,
      "jsHeapTotalBytes": -26681344,
      "scriptDurationMs": 445.38700000000006,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 83,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20456.133000000023,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 15.973000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19859.085,
      "heapDeltaBytes": -47606164,
      "heapUsedBytes": 172845156,
      "domNodes": -8312,
      "jsHeapTotalBytes": -25124864,
      "scriptDurationMs": 385.436,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 36,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 110.02899999994042,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 14.106,
      "layouts": 2,
      "layoutDurationMs": 0.4549999999999999,
      "taskDurationMs": 75.88399999999999,
      "heapDeltaBytes": 3167412,
      "heapUsedBytes": 65569844,
      "domNodes": 114,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.6000000000000005,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 452.4210000000721,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 17.922,
      "layouts": 3,
      "layoutDurationMs": 0.568,
      "taskDurationMs": 101.893,
      "heapDeltaBytes": 4932560,
      "heapUsedBytes": 67399764,
      "domNodes": 123,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.446999999999999,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

@github-actions

github-actions Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-14790.vercel.app

This commit: https://website-frontend-5304ors1b-comfyui.vercel.app

Last updated: 2026-08-23T01:18:55Z for b86773d

The colour scan only matched literal syntax, so fill="gold" in a brand asset
was invisible to both helpers — including the guard that exists to report a
colour it cannot read. Read the paint attributes directly instead: their value
is a colour unless it is one of the few non-colour keywords, so anything left
that does not parse is reported.

Verified by injecting fill="gold" into favicon.svg — the suite fails.
@codecov

codecov Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../src/components/product/enterprise/HeroSection.vue 0.00% 1 Missing ⚠️
@@                             Coverage Diff                             @@
##           glary/design-system-brand-yellow-f2ff59   #14790      +/-   ##
===========================================================================
- Coverage                                    79.39%   79.38%   -0.01%     
===========================================================================
  Files                                         2218     2218              
  Lines                                       112266   112265       -1     
  Branches                                     32457    36764    +4307     
===========================================================================
- Hits                                         89131    89125       -6     
- Misses                                       22653    22661       +8     
+ Partials                                       482      479       -3     
Flag Coverage Δ
e2e 67.42% <ø> (-0.01%) ⬇️
unit 73.44% <ø> (ø)
website-unit 26.31% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ebsite/src/components/contact/HubspotFormEmbed.vue 0.00% <ø> (ø)
...bsite/src/components/product/cloud/HeroSection.vue 0.00% <ø> (ø)
...bsite/src/components/product/local/HeroSection.vue 0.00% <ø> (ø)
.../src/components/product/enterprise/HeroSection.vue 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…-f2ff59' into glary/design-system-consolidate-brand
@christian-byrne christian-byrne added the Release Create a new release label Aug 9, 2026
@github-actions
github-actions Bot requested a review from benceruleanlu August 9, 2026 01:37
…-f2ff59' into glary/design-system-consolidate-brand

@benceruleanlu benceruleanlu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving directionally, but can you just take a look to see whether or not we want to actually follow SemVer? Because if we're following SemVer, we made breaking changes, and so maybe we want to bump it to 2.0 instead of 1.1? Up to you.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix merge conflicts.

…-f2ff59' into glary/design-system-consolidate-brand

# Conflicts:
#	apps/website/src/data/brandColors.test.ts
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 17, 2026
…-f2ff59' into glary/design-system-consolidate-brand
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Refreshed on top of the updated #14484 branch — clean merge, no conflicts. Head is now b86773d97b.

This should clear the red e2e-status. The failure was playwright-tests (mobile-chrome) on pan.spec.ts @mobile Can pan with touch — a stable 40-pixel screenshot diff that reproduced across five unrelated branches, three of them merge-queue runs. It was fixed on main by #15356 (text anti-aliasing), and this branch now contains that commit. Nothing here needed changing; the branch was just behind the fix.

Gates green: typecheck, lint, format:check, knip.

Still approved, still stacked — merges as soon as 14484 lands.

@christian-byrne

Copy link
Copy Markdown
Contributor Author
Full context for agent readers

benceruleanlu approved 0d9be9a67e3b6dcd18b95d9be2e044df2521ded4. The two later commits (693c836d, b86773d9) only merge refreshed versions of the target branch. The first refresh adapts brandColors.test.ts to the base branch's token-alias resolver; after that refresh, the PR patch is byte-equivalent through current head (stable patch-id 230cdf21b4e7405bf3ae9515b66263fe56726def). There are no review threads.

The blocking gate is land order, not Codecov: target PR #14484 is still open, BLOCKED, and has no human approval. #14790's current target branch has no required contexts; after #14484 lands, required-context status must be reevaluated against the resulting target before merge.

Next action remains with DrJKL as #14484's assignee. No queue action was applied.

@christian-byrne christian-byrne removed their assignment Aug 27, 2026
@christian-byrne
christian-byrne merged commit ac4dd38 into glary/design-system-brand-yellow-f2ff59 Aug 29, 2026
70 of 72 checks passed
@christian-byrne
christian-byrne deleted the glary/design-system-consolidate-brand branch August 29, 2026 03:00
christian-byrne added a commit that referenced this pull request Sep 2, 2026
Stacked on #14484. That PR stops surfaces from restating token values;
this one moves the brand layer itself into the package, so there is a
single file that owns every brand colour and the brand typeface.

- **What**: `_brand.css` (all brand colours + both brand font tokens)
and `brand-fonts.css` (the PP Formula faces). `base.css` becomes the
brand surface — brand, brand fonts, shared ramps; `style.css` is that
plus everything product. `apps/website/src/styles/global.css` drops the
10 brand colours, the 6 PP Formula `@font-face` blocks, both font tokens
and the dead Google Fonts Inter import, keeping only site-specific
values. 82 mauve stroke literals across three HeroSections, 12 PP
Formula literals in `HubspotFormEmbed` and `404.astro`, and the
`--brand-yellow` indirection in `style.css` are gone.
- **Breaking**: `_palette.css` no longer carries brand tokens and
`base.css` no longer loads Inter. Nothing consumes either today —
checked. `platform` imports `_palette.css` for the neutral ramps only,
and the website never used Inter (its body is `font-formula`), which is
what made the Google Fonts import dead. Version bumped to `1.1.0`;
platform should move its import to `base.css` when it takes the upgrade.

**Why the brand yellow could drift at all.** It was declared in three
places under different names, so no single change could keep them equal.
The same was true of `--font-formula`, and worse: `_palette.css` said
`'PP Formula', 'Inter', sans-serif` while the website said `'PP
Formula', sans-serif`, and the website silently won. I kept the Inter
fallback in the unified token, because the app bundles only three of the
six PP Formula weights (`src/platform/cloud/onboarding/assets`) and
leans on Inter for the rest. On comfy.org the fallback is inert — no
Inter is served there — so rendering is unchanged on both surfaces.

**The test is the part that lasts.** `brandColors.test.ts` now fails if
any `--color-*` or `--font-*` token is declared in more than one of
`_brand.css`, `_palette.css`, and the website's `@theme`. Documentation
alone would not have prevented this; the second declaration always looks
reasonable in isolation.

**SVG strokes went to utility classes, not `var()`.** `stroke="#4D3762"`
became `class="stroke-secondary-mauve"` rather than
`stroke="var(--color-secondary-mauve)"` — substitution in SVG
presentation attributes was only resolved into SVG2 in Nov 2025 and
Chromium is uneven. The two occurrences inside `@keyframes` are real
declarations, so those use `var()`.

**Verification.** Diffed every emitted `--color-*` / `--font-*` in the
built website CSS against the pre-change build: same 34 tokens, same
values, only ordering differs plus the intended Inter fallback.
Converted stroke counts match one-for-one in the built HTML (cloud 36,
cloud/enterprise 39, download 5, zero leftover attributes). Both builds
still resolve the full yellow chain to `#f2ff59`, all six PP Formula
faces are present in the output, and no `fonts.googleapis` reference
survives anywhere in `dist`.

Gates: `lint` (0 errors), `format:check`, `typecheck`,
`typecheck:website` (0 errors), `knip`, website build (581 pages), 345
website tests, 672 tests across `src/platform/cloud`,
`packages/shared-frontend-utils` and `src/components/ui`.

**Answers Alexis's question in-repo.** The README now says outright that
the package holds two design systems, that the file is what
distinguishes them, and that no naming convention reliably does —
several token names predate the split. `primary-` is still overloaded
across app-semantic roles and brand colours, and `plum-600` /
`primary-comfy-plum` remain the same hex under two names. Renaming them
is deliberately not in this PR; it is a breaking change for consumers
and wants its own decision.

**Deliberately left alone.** `--text-2xs` still disagrees between
`style.css` (`0.625rem`) and the website (`0.6875rem`). The website's
value wins on comfy.org, so aligning it is a visible type change across
the site — a designer's call, not a refactor's. The
duplicate-declaration test is scoped to the files `base.css` actually
pulls in, so it does not paper over this.
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
christian-byrne added a commit that referenced this pull request Sep 2, 2026
Stacked on #14484. That PR stops surfaces from restating token values;
this one moves the brand layer itself into the package, so there is a
single file that owns every brand colour and the brand typeface.

- **What**: `_brand.css` (all brand colours + both brand font tokens)
and `brand-fonts.css` (the PP Formula faces). `base.css` becomes the
brand surface — brand, brand fonts, shared ramps; `style.css` is that
plus everything product. `apps/website/src/styles/global.css` drops the
10 brand colours, the 6 PP Formula `@font-face` blocks, both font tokens
and the dead Google Fonts Inter import, keeping only site-specific
values. 82 mauve stroke literals across three HeroSections, 12 PP
Formula literals in `HubspotFormEmbed` and `404.astro`, and the
`--brand-yellow` indirection in `style.css` are gone.
- **Breaking**: `_palette.css` no longer carries brand tokens and
`base.css` no longer loads Inter. Nothing consumes either today —
checked. `platform` imports `_palette.css` for the neutral ramps only,
and the website never used Inter (its body is `font-formula`), which is
what made the Google Fonts import dead. Version bumped to `1.1.0`;
platform should move its import to `base.css` when it takes the upgrade.

**Why the brand yellow could drift at all.** It was declared in three
places under different names, so no single change could keep them equal.
The same was true of `--font-formula`, and worse: `_palette.css` said
`'PP Formula', 'Inter', sans-serif` while the website said `'PP
Formula', sans-serif`, and the website silently won. I kept the Inter
fallback in the unified token, because the app bundles only three of the
six PP Formula weights (`src/platform/cloud/onboarding/assets`) and
leans on Inter for the rest. On comfy.org the fallback is inert — no
Inter is served there — so rendering is unchanged on both surfaces.

**The test is the part that lasts.** `brandColors.test.ts` now fails if
any `--color-*` or `--font-*` token is declared in more than one of
`_brand.css`, `_palette.css`, and the website's `@theme`. Documentation
alone would not have prevented this; the second declaration always looks
reasonable in isolation.

**SVG strokes went to utility classes, not `var()`.** `stroke="#4D3762"`
became `class="stroke-secondary-mauve"` rather than
`stroke="var(--color-secondary-mauve)"` — substitution in SVG
presentation attributes was only resolved into SVG2 in Nov 2025 and
Chromium is uneven. The two occurrences inside `@keyframes` are real
declarations, so those use `var()`.

**Verification.** Diffed every emitted `--color-*` / `--font-*` in the
built website CSS against the pre-change build: same 34 tokens, same
values, only ordering differs plus the intended Inter fallback.
Converted stroke counts match one-for-one in the built HTML (cloud 36,
cloud/enterprise 39, download 5, zero leftover attributes). Both builds
still resolve the full yellow chain to `#f2ff59`, all six PP Formula
faces are present in the output, and no `fonts.googleapis` reference
survives anywhere in `dist`.

Gates: `lint` (0 errors), `format:check`, `typecheck`,
`typecheck:website` (0 errors), `knip`, website build (581 pages), 345
website tests, 672 tests across `src/platform/cloud`,
`packages/shared-frontend-utils` and `src/components/ui`.

**Answers Alexis's question in-repo.** The README now says outright that
the package holds two design systems, that the file is what
distinguishes them, and that no naming convention reliably does —
several token names predate the split. `primary-` is still overloaded
across app-semantic roles and brand colours, and `plum-600` /
`primary-comfy-plum` remain the same hex under two names. Renaming them
is deliberately not in this PR; it is a breaking change for consumers
and wants its own decision.

**Deliberately left alone.** `--text-2xs` still disagrees between
`style.css` (`0.625rem`) and the website (`0.6875rem`). The website's
value wins on comfy.org, so aligning it is a visible type change across
the site — a designer's call, not a refactor's. The
duplicate-declaration test is scoped to the files `base.css` actually
pulls in, so it does not paper over this.
christian-byrne added a commit that referenced this pull request Sep 4, 2026
Stacked on #14484. That PR stops surfaces from restating token values;
this one moves the brand layer itself into the package, so there is a
single file that owns every brand colour and the brand typeface.

- **What**: `_brand.css` (all brand colours + both brand font tokens)
and `brand-fonts.css` (the PP Formula faces). `base.css` becomes the
brand surface — brand, brand fonts, shared ramps; `style.css` is that
plus everything product. `apps/website/src/styles/global.css` drops the
10 brand colours, the 6 PP Formula `@font-face` blocks, both font tokens
and the dead Google Fonts Inter import, keeping only site-specific
values. 82 mauve stroke literals across three HeroSections, 12 PP
Formula literals in `HubspotFormEmbed` and `404.astro`, and the
`--brand-yellow` indirection in `style.css` are gone.
- **Breaking**: `_palette.css` no longer carries brand tokens and
`base.css` no longer loads Inter. Nothing consumes either today —
checked. `platform` imports `_palette.css` for the neutral ramps only,
and the website never used Inter (its body is `font-formula`), which is
what made the Google Fonts import dead. Version bumped to `1.1.0`;
platform should move its import to `base.css` when it takes the upgrade.

**Why the brand yellow could drift at all.** It was declared in three
places under different names, so no single change could keep them equal.
The same was true of `--font-formula`, and worse: `_palette.css` said
`'PP Formula', 'Inter', sans-serif` while the website said `'PP
Formula', sans-serif`, and the website silently won. I kept the Inter
fallback in the unified token, because the app bundles only three of the
six PP Formula weights (`src/platform/cloud/onboarding/assets`) and
leans on Inter for the rest. On comfy.org the fallback is inert — no
Inter is served there — so rendering is unchanged on both surfaces.

**The test is the part that lasts.** `brandColors.test.ts` now fails if
any `--color-*` or `--font-*` token is declared in more than one of
`_brand.css`, `_palette.css`, and the website's `@theme`. Documentation
alone would not have prevented this; the second declaration always looks
reasonable in isolation.

**SVG strokes went to utility classes, not `var()`.** `stroke="#4D3762"`
became `class="stroke-secondary-mauve"` rather than
`stroke="var(--color-secondary-mauve)"` — substitution in SVG
presentation attributes was only resolved into SVG2 in Nov 2025 and
Chromium is uneven. The two occurrences inside `@keyframes` are real
declarations, so those use `var()`.

**Verification.** Diffed every emitted `--color-*` / `--font-*` in the
built website CSS against the pre-change build: same 34 tokens, same
values, only ordering differs plus the intended Inter fallback.
Converted stroke counts match one-for-one in the built HTML (cloud 36,
cloud/enterprise 39, download 5, zero leftover attributes). Both builds
still resolve the full yellow chain to `#f2ff59`, all six PP Formula
faces are present in the output, and no `fonts.googleapis` reference
survives anywhere in `dist`.

Gates: `lint` (0 errors), `format:check`, `typecheck`,
`typecheck:website` (0 errors), `knip`, website build (581 pages), 345
website tests, 672 tests across `src/platform/cloud`,
`packages/shared-frontend-utils` and `src/components/ui`.

**Answers Alexis's question in-repo.** The README now says outright that
the package holds two design systems, that the file is what
distinguishes them, and that no naming convention reliably does —
several token names predate the split. `primary-` is still overloaded
across app-semantic roles and brand colours, and `plum-600` /
`primary-comfy-plum` remain the same hex under two names. Renaming them
is deliberately not in this PR; it is a breaking change for consumers
and wants its own decision.

**Deliberately left alone.** `--text-2xs` still disagrees between
`style.css` (`0.625rem`) and the website (`0.6875rem`). The website's
value wins on comfy.org, so aligning it is a visible type change across
the site — a designer's call, not a refactor's. The
duplicate-declaration test is scoped to the files `base.css` actually
pulls in, so it does not paper over this.
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 1, 2026
…brand-layer verdict (Comfy-Org#16796)

Docs-only follow-up answering the SemVer question raised on Comfy-Org#14790.

**Verdict: the brand-layer move is breaking, and the first release
carrying it must be `2.0.0`.** Key facts:

- The change removes brand tokens from `_palette.css` and stops
`base.css` from loading Inter, changing the package's public styling
surface.
- `@comfyorg/design-system@1.1.0` was published from `main` on
2026-09-05 without the brand-layer move.
- Comfy-Org#14790 remains outside `main`, so its old in-tree `1.1.0` version does
not establish a published precedent for the move.
- When the brand-layer stack lands, the release carrying that breaking
change must be a major bump from the shipped 1.x line.

This PR records the policy (exports are part of the public SemVer
surface; removing tokens, `@font-face` rules, or exported files is
breaking) and the current release precedent in the README's `Releasing`
section. It does not change package code or the package version.

## Verification

- `npm view @comfyorg/design-system version` reports `1.1.0`.
- `main` currently declares `1.1.0` in
`packages/design-system/package.json`.
- The PR diff is limited to `packages/design-system/README.md`.

<!-- authored-by:agent lane-srx-35-1653 -->

---------

Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Create a new release risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants